Commit Graph

7561 Commits

Author SHA1 Message Date
Ryan Lortie
08e15bbbae add clarification stating that the construct_child function is responsible
2006-11-26  Ryan Lortie  <desrt@desrt.ca>

        * docs/reference/gtk/tmpl/gtkbuildable.sgml: add clarification stating
        that the construct_child function is responsible for returning a
        reference.
        * gtkbuilder.c (_gtk_builder_construct): remove g_object_ref() for
        objects from constructors
        * gtkuimanager.c (gtk_ui_manager_buildable_construct_child): add
        g_object_ref() to this construction function (it's the only
        implementer in GTK)

        Fixes #496645.


svn path=/trunk/; revision=19075
2007-11-27 03:25:09 +00:00
Ryan Lortie
490af125c2 remove concept of root objects and just refcount all objects in the
2006-11-26  Ryan Lortie  <desrt@desrt.ca>

        * gtkbuilder.c: remove concept of root objects and just refcount
        all objects in the builder.  Fixes #496651.


svn path=/trunk/; revision=19074
2007-11-27 03:07:23 +00:00
Josselin Mouette
21a30978dc reviewed by: Federico Mena Quintero
2007-11-26  Josselin Mouette <joss@malsain.org>

        reviewed by: Federico Mena Quintero

        * gtk/gtkfilechooserdefault.c: (shortcuts_append_paths),
        (shortcuts_add_bookmarks), (shortcuts_selection_changed_cb),
        (shortcuts_list_create), (gtk_file_chooser_default_should_respond):
        Make the shortcuts activate with a single click. (#148828)
        Fix a few things affected by the change:
          - Set selection mode to GTK_SELECTION_SINGLE to allow a case 
            where no shortcut is selected.
          - Don't activate a shortcut in the response callback.
          - Filter out duplicate entries in volumes and bookmarks to 
            avoid the selection to change when reordering them with DnD.


svn path=/trunk/; revision=19072
2007-11-26 23:16:19 +00:00
Matthias Clasen
7819005e2e Fix up some doc comments to shut up gtk-doc.
2007-11-26  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkmain.c:
        * gtk/gtknotebook.c:
        * gtk/gtkplugprivate.h:
        * gtk/gtksocket.c:
        * gtk/gtksocketprivate.h:
        * gtk/gtktable.c: Fix up some doc comments to shut up gtk-doc.


svn path=/trunk/; revision=19066
2007-11-26 20:15:15 +00:00
Matthias Clasen
fa0328da18 Change some labels to be clearer. String change ! (#376361, Sven Neumann)
2007-11-26  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkprintunixdialog.c: Change some labels to be clearer.
        String change !   (#376361, Sven Neumann)


svn path=/trunk/; revision=19061
2007-11-26 18:27:20 +00:00
Matthias Clasen
3132888e1b Short-circuit on destroy. (gtk_notebook_destroy): Destroy tab_label
2007-11-26  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtknotebook.c (gtk_notebook_update_labels): Short-circuit on
        destroy.
        (gtk_notebook_destroy): Destroy tab_label widgets. (#388321, Morten
        Welinder)


svn path=/trunk/; revision=19059
2007-11-26 18:21:13 +00:00
Matthias Clasen
9936134d97 Improve alternative button ordering. (#476827, Yevgen Muntyan, patch by
2007-11-26  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkassistant.c: Improve alternative button
        ordering.  (#476827, Yevgen Muntyan, patch by Carlos Garnacho)


svn path=/trunk/; revision=19057
2007-11-26 18:16:46 +00:00
Matthias Clasen
225803d3ce Fix a theming problem with colors in GtkCalendar. (#499703, Michael
2007-11-26  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkcalendar.c: Fix a theming problem with colors
        in GtkCalendar.  (#499703, Michael Hofmann)


svn path=/trunk/; revision=19055
2007-11-26 17:42:35 +00:00
Matthias Clasen
736f86b303 Use templates for glib-mkenums calls instead of complicated commandlines
2007-11-26  Matthias Clasen  <mclasen@redhat.com>

        Use templates for glib-mkenums calls instead of
        complicated commandlines in Makefiles.  (#429910)

        * gdk-pixbuf/Makefile.am:
        * gdk/Makefile.am:
        * gtk/Makefile.am:
        * perf/Makefile.am: Use templates for glib-mkenums

        * gdk-pixbuf/gdk-pixbuf-enum-types.[ch].template:
        * gdk/gdkenumtypes.[ch].template:
        * gtk/gtktypebuiltings.[ch].template:
        * perf/typebuiltins.[ch].template: The templates


svn path=/trunk/; revision=19053
2007-11-26 17:32:19 +00:00
Matthias Clasen
d5eb6847e5 Don't use guint8 for bitfields, since some compilers choke on that.
2007-11-26  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkfilechooserbutton.c:
        * gtk/gtktoolbar.c: Don't use guint8 for bitfields, since
        some compilers choke on that.  (#467722)


svn path=/trunk/; revision=19051
2007-11-26 17:10:00 +00:00
Matthias Clasen
259244deda Add a note about hook setup. (#425004, Emmanuele Bassi)
2007-11-26  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkaboutdialog.c (gtk_about_dialog_set_website): Add a note
        about hook setup.  (#425004, Emmanuele Bassi)



svn path=/trunk/; revision=19050
2007-11-26 16:48:21 +00:00
Matthias Clasen
4896e24bb1 Require gtk-doc 1.8
2007-11-25  Matthias Clasen  <mclasen@redhat.com>

        * configure.in: Require gtk-doc 1.8

        * */*.c: Use gtk-doc abbreviations for examples in docs.


svn path=/trunk/; revision=19041
2007-11-25 06:51:19 +00:00
Matthias Clasen
1719428849 Fix a typo
svn path=/trunk/; revision=19039
2007-11-25 06:07:44 +00:00
Matthias Clasen
0184d7caad Move signal and property documentation inline, fix a problem with the
2007-11-25  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkdialog.c: Move signal and property documentation inline,
        fix a problem with the ::response signal docs.  (#499133, Josselin
        Mouette)


svn path=/trunk/; revision=19038
2007-11-25 05:40:49 +00:00
15:39:40 Tim Janik
2dc08ada49 call g_test_init() from gtk_test_init().
2007-11-22 15:39:40  Tim Janik  <timj@imendio.com>

        * gtk/gtktestutils.c: call g_test_init() from gtk_test_init().

        * gtk/tests/testing.c: use g_test_add_func() to register tests and use
	g_test_run() to run the tests to integrate with the testing framework.

        * gtk/tests/Makefile.am: removed exemplary testing rules.

        * Makefile.am, gtk/tests/Makefile.am, gtk/Makefile.am:
        * gtk/xdgmime/Makefile.am, gtk/theme-bits/Makefile.am:
        * tests/Makefile.am, docs/reference/gdk-pixbuf/Makefile.am:
        * docs/reference/gdk/Makefile.am, docs/reference/gtk/Makefile.am:
        * docs/reference/Makefile.am, docs/tools/Makefile.am:
        * docs/tutorial/Makefile.am, docs/faq/Makefile.am, docs/Makefile.am:
        * gdk-pixbuf/pixops/Makefile.am, gdk-pixbuf/Makefile.am:
        * demos/gtk-demo/Makefile.am, demos/Makefile.am:
        * modules/input/Makefile.am, modules/printbackends/file/Makefile.am:
        * modules/printbackends/test/Makefile.am, modules/printbackends/Makefile.am:
        * modules/printbackends/cups/Makefile.am, modules/printbackends/lpr/Makefile.am:
        * modules/engines/ms-windows/Theme/gtk-2.0/Makefile.am:
        * modules/engines/ms-windows/Theme/Makefile.am:
        * modules/engines/ms-windows/Makefile.am:
        * modules/engines/Makefile.am,  modules/engines/pixbuf/Makefile.am:
        * modules/Makefile.am, m4macros/Makefile.am, perf/Makefile.am:
        * contrib/Makefile.am, contrib/gdk-pixbuf-xlib/Makefile.am:
        * gdk/directfb/Makefile.am, gdk/linux-fb/Makefile.am:
        * gdk/quartz/Makefile.am, gdk/win32/rc/Makefile.am:
        * gdk/win32/Makefile.am, gdk/x11/Makefile.am, gdk/Makefile.am:
	include $(top_srcdir)/Makefile.decl, adapted EXTRA_DIST assignments.



svn path=/trunk/; revision=19033
2007-11-22 14:38:26 +00:00
Matthias Clasen
1ece9d4e40 Fix an aliasing problem. (#347585, Ed Catmur)
2007-11-22  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktextiter.c: Fix an aliasing problem.  (#347585, Ed Catmur)


svn path=/trunk/; revision=19024
2007-11-22 05:50:32 +00:00
Behdad Esfahbod
a64cba34e3 Make GtkMenuItem's arrow size themeable. (#469239, Michael Natterer)
2007-11-21  Behdad Esfahbod  <behdad@gnome.org>

        * gtk/gtkmenuitem.c (gtk_menu_item_class_init),
        (gtk_menu_item_paint): Make GtkMenuItem's arrow size themeable.
        (#469239, Michael Natterer)


svn path=/trunk/; revision=19020
2007-11-21 09:22:06 +00:00
Matthias Clasen
9116609354 Fix the default value of the toolbar-style property. (#489782, Jan Janech)
2007-11-21  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktoolbar.c: Fix the default value of the toolbar-style
        property.  (#489782, Jan Janech)



svn path=/trunk/; revision=19018
2007-11-21 05:49:35 +00:00
Matthias Clasen
11a88edb28 Avoid drawing one too many frames. (#107398, Owen Taylor, Miguel Gomez)
2007-11-20  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkimage.c (animation_timeout): Avoid drawing one too many
        frames.  (#107398, Owen Taylor, Miguel Gomez)


svn path=/trunk/; revision=19017
2007-11-21 04:56:50 +00:00
Tim Janik
40695ee368 Fixed copyright for newly submitted files.
svn path=/trunk/; revision=19014
2007-11-20 17:44:06 +00:00
Tim Janik
4f7a2da8e8 Moved Gdk test functions from Gtk+ to Gdk test utils.
* gdk/Makefile.am: added gdktestutils.h to public includes.

* gdk/gdk.h: added gdktestutils.h to public includes.

* gdk/gdk.symbols: added gdk_test_simulate_button, gdk_test_simulate_key,
gdk_test_render_sync.

* gdk/gdktestutils.h: new file, added prototypes for gdk_test_simulate_button,
gdk_test_simulate_key, gdk_test_render_sync.

* gdk/x11/Makefile.am: build gdktestutils-x11.c.

* gdk/x11/gdktestutils-x11.c: implemented gdk_test_simulate_button,
gdk_test_simulate_key, gdk_test_render_sync.

* gtk/gtktestutils.c:
* gtk/gtktestutils.h:
* gtk/gtk.symbols: removed gtk_test_simulate_button
gtk_test_simulate_key, gtk_test_xserver_render_sync.

* gtk/tests/testing.c: call gdk_test_render_sync.

svn path=/trunk/; revision=19012
2007-11-20 15:03:31 +00:00
Tim Janik
3cf208ef5e Added unit tests for Gtk+ testing utilities.
* gtk/tests/testing.c: added a sample test program that tests Gtk+ test
utility functions. some g_test_* related portions are disabled and need
to be enabled once Gtk+ depends on a new glib with the GLib testing
framework integrated.

* gtk/tests/Makefile.am: new subdirectory to include quick Gtk+ tests.
added exemplary test rules to run tests inside Xvfb. this needs to depend
on gtester for full fledged testing.

* gtk/Makefile.am: build gtk+/gtk/tests, define -DGTK_ENABLE_BROKEN when
collecting _get_type functions to catch e.g. gtk_text_get_type().

* configure.in: create gtk/tests/Makefile.in and gtk/tests/Makefile.

svn path=/trunk/; revision=19011
2007-11-20 15:03:28 +00:00
Tim Janik
936d27a475 Added Gtk+ testing utilities.
* gtk/gtktestutils.h, gtk/gtktestutils.c: added unit test utility functions.
for the most part, the functions herein involve navigating and interacting
with dialog elements programatically, to automate user interaction tests of
dialogs and widgets.

* gtk/gtk.h: include gtk/gtktestutils.h as public API.

* gtk/gtk.symbols: added gtk_test_* symbols.

* gtk/Makefile.am: include gtktestutils.h and gtktestutils.c into the build.
generate gtktypefuncs.c which contains a list of all _get_type functions in
Gtk+ and Gdk.

svn path=/trunk/; revision=19010
2007-11-20 15:03:26 +00:00
Matthias Clasen
e888b75e1b Fix the GtkBuildable implementation to allow setting column types.
2007-11-19  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktreestore.c: Fix the GtkBuildable implementation
        to allow setting column types.  (#496795, James Stephenson)



svn path=/trunk/; revision=19001
2007-11-19 05:47:36 +00:00
Matthias Clasen
5f4e93fe0a Make gtk_check_version() return const. (#496734, Nicolas Joseph)
2007-11-19  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkmain.[hc]: Make gtk_check_version() return const.
        (#496734, Nicolas Joseph)



svn path=/trunk/; revision=19000
2007-11-19 05:34:19 +00:00
Matthias Clasen
0add6313d3 Correct docs for program-name property. (#496689, Thomas Wood)
2007-11-19  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkaboutdialog.c: Correct docs for program-name property.
        (#496689, Thomas Wood)



svn path=/trunk/; revision=18999
2007-11-19 05:28:28 +00:00
Paolo Borelli
540569dadb Use gtk_text_buffer_get_insert instead of get_mark. Fixes Bug 497164.
2007-11-17  Paolo Borelli  <pborelli@katamail.com>

	* gtk/gtktextbuffer.c:
	* gtk/gtktextlayout.c:
	* gtk/gtktextview.c:
	Use gtk_text_buffer_get_insert instead of get_mark. Fixes Bug 497164.


svn path=/trunk/; revision=18997
2007-11-17 10:18:13 +00:00
Yevgen Muntyan
abad58b003 new functions _gtk_text_btree_get_insert() and
2007-11-15  Yevgen Muntyan  <muntyan@tamu.edu>

	* gtk/gtktextbtree.h:
	* gtk/gtktextbtree.c: new functions _gtk_text_btree_get_insert()
	and _gtk_text_btree_get_selection_bound() (#497102).
	* gtk/gtktextbuffer.c (gtk_text_buffer_get_insert),
	(gtk_text_buffer_get_selection_bound): use them here instead of
	hash table lookup.


svn path=/trunk/; revision=18996
2007-11-15 17:03:09 +00:00
Yevgen Muntyan
921da326f5 sort returned tags array by tags priority (#497102).
2007-11-15  Yevgen Muntyan  <muntyan@tamu.edu>

	* gtk/gtktextbtree.c (_gtk_text_btree_get_tags): sort returned
	tags array by tags priority (#497102).
	* gtk/gtktextiter.c (gtk_text_iter_get_tags), (gtk_text_iter_get_attributes):
	* gtk/gtktextlayout.c (get_tags_array_at_iter): and do not sort it here.


svn path=/trunk/; revision=18995
2007-11-15 17:00:33 +00:00
Yevgen Muntyan
a3eb6a98d7 do not call _gtk_text_btree_get_iter_at_line() and
2007-11-15  Yevgen Muntyan  <muntyan@tamu.edu>

	* gtk/gtktextlayout.c: (gtk_text_layout_get_line_display),
	(get_style): do not call _gtk_text_btree_get_iter_at_line() and
	_gtk_text_btree_get_tags() for every segment, instead call them
	once and then collect the tags while iterating over the segments.
	(get_tags_array_at_iter), (tags_array_toggle_tag): new functions
	for tags array handling.


svn path=/trunk/; revision=18994
2007-11-15 16:24:42 +00:00
Michael Natterer
65ef21dfb3 remove recently added gdk_flush() again, it's not needed after all.
2007-11-14  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkmenu.c (gtk_menu_popup): remove recently added
	gdk_flush() again, it's not needed after all.


svn path=/trunk/; revision=18991
2007-11-14 10:09:44 +00:00
Michael Natterer
24a6e04cb2 cast pointers to fix warnings about signdness.
2007-11-14  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkstyle.c (gtk_default_draw_focus): cast pointers to fix
	warnings about signdness.


svn path=/trunk/; revision=18988
2007-11-14 09:45:14 +00:00
Yevgen Muntyan
c9371f873b Moved gtk_text_view_update_im_spot_location() calls into an idle, fixes
2007-11-11  Yevgen Muntyan  <muntyan@tamu.edu>

	* gtk/gtktextview.c: Moved gtk_text_view_update_im_spot_location()
	calls into an idle, fixes #494776.
	GtkTextViewPrivate:im_spot_idle, do_update_im_spot_location(),
	queue_update_im_spot_location(), flush_update_im_spot_location(): new
	field and functions to queue the call;
	(changed_handler): call queue_update_im_spot_location() instead of
	gtk_text_view_update_im_spot_location();
	(gtk_text_view_key_press_event): flush the idle here.


svn path=/trunk/; revision=18984
2007-11-11 19:07:27 +00:00
Ryan Lortie
d65049378b Convert delayed_properties hashtable to linked list. Fixes #495769.
2007-11-10  Ryan Lortie  <desrt@desrt.ca>

        * gtk/gtkbuilder.c: Convert delayed_properties hashtable to linked
        list.  Fixes #495769.


svn path=/trunk/; revision=18983
2007-11-11 18:06:11 +00:00
Matthias Clasen
464ae98495 Leak less in error paths
svn path=/trunk/; revision=18980
2007-11-10 23:57:32 +00:00
Matthias Clasen
06d28ff884 Don't leak buffer if an error occurs.
2007-11-10  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkbuilder.c (gtk_builder_add_from_file): Don't
        leak buffer if an error occurs.



svn path=/trunk/; revision=18979
2007-11-10 05:03:10 +00:00
Matthias Clasen
6665188687 More robustness improvements of the parser
svn path=/trunk/; revision=18978
2007-11-10 04:50:15 +00:00
Matthias Clasen
f489387039 Don't assert on misplaced signal elements
svn path=/trunk/; revision=18977
2007-11-10 04:15:44 +00:00
Matthias Clasen
c3fcd42eda Handle misplaced property elements without asserting.
2007-11-09  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkbuilderparser.c (parse_property): Handle misplaced
        property elements without asserting.


svn path=/trunk/; revision=18976
2007-11-10 02:36:56 +00:00
Matthias Clasen
b2ad97dd38 Stylistic fixes
svn path=/trunk/; revision=18974
2007-11-09 16:56:17 +00:00
Matthias Clasen
fb4b0ddff7 don't leak 'filename' field memory when loading more than one file into
2007-11-08  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkbuilder.c: don't leak 'filename' field memory when loading
        more than one file into the same GtkBuilder instance. Noticed by
        Ryan Lortie.


svn path=/trunk/; revision=18973
2007-11-09 00:33:45 +00:00
Michael Natterer
d5dca93c58 include <glib.h> instead of <glib/gmarkup.h>
2007-11-08  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkbuildable.h: include <glib.h> instead of <glib/gmarkup.h>


svn path=/trunk/; revision=18972
2007-11-08 12:30:01 +00:00
Matthias Clasen
a27a83c37c Forgotten file
svn path=/trunk/; revision=18971
2007-11-08 05:21:06 +00:00
Ryan Lortie
36605333d0 Add GString 'text' to the property info structure. Used to accumulate
2007-11-07  Ryan Lortie  <desrt@desrt.ca>

        * gtk/gtkbuilderprivate.h: Add GString 'text' to the property info
        structure.  Used to accumulate property text across multiple 'text'
        calls.

        * gtk/gtkbuilderparser.c: Instead of translating/copying text on each
        'text' call while in <property> accumulate the text until the end and
        do it all in one go.  This fixes handling of <!-- --> inside
        properties as well as <property/> cases.


svn path=/trunk/; revision=18970
2007-11-08 04:12:52 +00:00
Michael Natterer
9b3edbc319 call gdk_flush() after showing the menu so we can definitely grab on it.
2007-11-06  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkmenu.c (gtk_menu_popup): call gdk_flush() after showing
	the menu so we can definitely grab on it. Grab failure found by
	Xan Lopez.


svn path=/trunk/; revision=18969
2007-11-06 14:23:56 +00:00
Michael Natterer
f93e2db2a9 fixed docs.
2007-11-06  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkwidget.c (gtk_widget_keynav_failed): fixed docs.


svn path=/trunk/; revision=18968
2007-11-06 08:57:33 +00:00
Richard Hult
fd90de672b Fix bug #486369, by passing the selection info along when pasting.
2007-11-03  Richard Hult  <richard@imendio.com>

	* gtk/gtkclipboard-quartz.c: (clipboard_owner_destroyed),
	(gtk_clipboard_set_contents), (clipboard_unset): Fix bug #486369,
	by passing the selection info along when pasting.

svn path=/trunk/; revision=18965
2007-11-03 13:12:45 +00:00
Richard Hult
5cb6747339 Redo the fix for bug #492117, by adding a getter for the private drag
2007-11-01  Richard Hult  <richard@imendio.com>

	* gdk/quartz/GdkQuartzWindow.c:
	* gdk/quartz/GdkQuartzWindow.h:
	* gdk/quartz/gdkdnd-quartz.c:
	* gdk/quartz/gdkquartz.h:
	* gtk/gtkdnd-quartz.c: Redo the fix for bug #492117, by adding a
	getter for the private drag context info so we don't need to
	expose so much in the public quartz header file.

svn path=/trunk/; revision=18959
2007-11-01 08:45:30 +00:00
Emmanuele Bassi
b2f4e11df3 Chain up to the parent's finalize virtual function.
2007-10-30  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkbuilder.c (gtk_builder_finalize): Chain up to the
	parent's finalize virtual function.

svn path=/trunk/; revision=18952
2007-10-30 12:25:39 +00:00
Owen Taylor
5072e43bb2 Allow the ::delete-range handler to delete text after the text it was
2007-10-28  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtktextbuffer.c (gtk_text_buffer_delete_interactive): Allow
        the ::delete-range handler to delete text after the text it was
        explicitly asked to delete without confusing us as to whether
        we're currently on an editable or not-editable segment.
        (#491207)

svn path=/trunk/; revision=18951
2007-10-28 22:27:15 +00:00