Daniel Boles
0c09e4776d
combobox—Always popup menu using current event
...
priv->trigger_event is never set, so it is always NULL. This means the
gtk_menu_popup*() methods use the current event. The only way to get any
other event to combobox_menu_popup() was from the button-press-event
handler I just removed, which would end up being the current one anyway.
So, bin priv->trigger_event & explicitly pass NULL to gtk_menu_popup*().
2017-02-16 21:33:25 +00:00
Daniel Boles
69d2459471
combobox—Remove useless button-press-event handler
...
We use toggled, which does everything we need; this adds nothing useful.
Credit to Timm for noticing this—I didn’t when moving it to the ui file.
2017-02-16 21:09:55 +00:00
Emmanuele Bassi
51010da740
Use gtk_show_uri_on_window() in GtkLabel
...
Avoid the deprecated gtk_show_uri(), and allow activating link in
sandboxed applications.
https://bugzilla.gnome.org/show_bug.cgi?id=778726
2017-02-16 16:37:55 +01:00
Bastien Nocera
0875aa56ba
GtkMountOperation: We use gtk_show_uri_on_window() by default
...
Not gtk_show_uri().
https://bugzilla.gnome.org/show_bug.cgi?id=778726
2017-02-16 16:37:55 +01:00
Bastien Nocera
76dfef6257
gtk: Ignore gtk_show_uri() deprecation warnings
...
https://bugzilla.gnome.org/show_bug.cgi?id=778726
2017-02-16 16:37:55 +01:00
Bastien Nocera
c358383d6c
GtkLinkButton: We use gtk_show_uri_on_window() by default
...
Not gtk_show_uri().
https://bugzilla.gnome.org/show_bug.cgi?id=778726
2017-02-16 16:37:55 +01:00
Bastien Nocera
d2c1e6faff
GtkAboutDialog: We use gtk_show_uri_on_window() by default
...
Not gtk_show_uri().
https://bugzilla.gnome.org/show_bug.cgi?id=778726
2017-02-16 16:37:55 +01:00
Daniel Boles
02e9fb5a78
widget: Document signal mnemonic-activate
...
Name the extra bool argument, and move the explanatory paragraph from
the emitting method to the signal, with some minor tweaks to wording.
https://bugzilla.gnome.org/show_bug.cgi?id=778534
2017-02-15 21:44:29 +00:00
Bastien Nocera
22ea1a535e
gtkshow: Prefer gtk_show_uri_on_window() which works for sandboxed apps
...
gtk_show_uri_on_window() will pass enough information for Portal helpers
to allow dialogue parenting in Flatpak, gtk_show_uri() won't, so
deprecate it.
https://bugzilla.gnome.org/show_bug.cgi?id=778678
2017-02-15 16:33:01 +01:00
Timm Bäder
4e141883e8
iconhelper: Remove unused _draw implementation
2017-02-14 16:56:55 +01:00
Timm Bäder
08355997c2
snapshot: Avoid a double-free
...
We can't pass the same string to two different snapshot states since
removing one of them will free the passed string, so just create another
one for the second state.
2017-02-14 16:56:55 +01:00
Timm Bäder
6a6b6549ea
widget: Remove get_preferred_width/height mention in warning
2017-02-14 16:56:55 +01:00
Timm Bäder
1fcbc5b9e9
gtkcontainerprivate: Remove unused function prototypes
2017-02-14 16:56:55 +01:00
Timm Bäder
ec2ce26d82
colorbutton: Inherit from GtkWidget
2017-02-14 16:56:55 +01:00
Lapo Calamandrei
c4524623a9
HC: insensitive styling for views.
2017-02-08 21:32:47 -05:00
Lapo Calamandrei
6eb9b57e72
adwaita: insensitive styling for views
...
Add an insensitive style to views, somehow we didn't ship one, so
for example, disabled textviews looked the same as sensitive ones.
2017-02-08 21:32:33 -05:00
Timm Bäder
78a36cf4bb
popover: Simplify gtk_popover_measure
2017-02-05 15:03:35 +01:00
Timm Bäder
07643764a6
infobar: Use GtkButton:icon-name
2017-02-05 15:03:35 +01:00
Timm Bäder
3b1601f8ad
colorchooserwidget: Show palette by default
...
Restore the old behavior.
2017-02-05 15:03:35 +01:00
Michael Catanzaro
3905726627
notebook: redraw arrows after closing a tab
...
Thanks to Daniel Boles for helping with a crash in an earlier version of
this patch.
https://bugzilla.gnome.org/show_bug.cgi?id=777547
2017-02-04 12:57:08 -06:00
Timm Bäder
f251c5bf94
spinbutton: Fix right and middle click on +/- buttons
...
Tell the gesture that we handle all buttons and actually claim the
gesture in the ::pressed handler
2017-02-01 21:05:27 +01:00
Daniel Boles
2f2ec4fec8
searchentry: Fix typo in documentation
2017-01-31 09:39:39 +00:00
Timm Bäder
2f6d60d6af
stack: Fix node position during crossfade
2017-01-30 18:11:15 +01:00
Timm Bäder
2aea8dfee9
togglebutton: Move :inconsistent to GtkCheckButton
2017-01-30 18:11:00 +01:00
Timm Bäder
66d584ce6e
togglebutton: Move :draw-indicator property to GtkCheckButton
...
It's not used in GtkToggleButton at all, only in GtkCheckButton and
GtkRadioButton.
2017-01-30 18:11:00 +01:00
Timm Bäder
1a0577b3f4
checkbutton: Remove unused vfunc
2017-01-30 18:11:00 +01:00
Timm Bäder
eb0c5a6a6c
checkbutton: Remove unused function prototype
2017-01-30 18:11:00 +01:00
Timm Bäder
6c6ed7496c
widget: Remove gtk_widget_class_list_style_properties
...
Unused.
2017-01-30 18:11:00 +01:00
Timm Bäder
de56947e86
gtkbuilder: Remove unused struct
2017-01-30 18:11:00 +01:00
Timm Bäder
c82fee4882
build: Stop compressing ui files
...
It's slower at runtime. Instead, strip blanks.
2017-01-30 18:11:00 +01:00
Piotr Drąg
bfaed659f1
Fix translator comments
...
They need to be exactly one line above a string to show up in .po files.
2017-01-28 01:13:12 +01:00
Michael Catanzaro
03c026e6b6
Revert "notebook: redraw arrows after closing a tab"
...
This reverts commit 218beb2ef4
.
2017-01-27 08:54:24 -06:00
Michael Catanzaro
218beb2ef4
notebook: redraw arrows after closing a tab
...
https://bugzilla.gnome.org/show_bug.cgi?id=777547
2017-01-24 08:33:35 -06:00
Timm Bäder
572639fed7
widget: Remove gtk_widget_get_preferred_size mention from docs
...
Mention gtk_widget_measure instead.
2017-01-22 15:01:53 +01:00
Timm Bäder
82e49952e5
flowbox: Measure child widget sizes using gtk_widget_measure
2017-01-22 15:01:40 +01:00
Timm Bäder
f05402ce2b
widget: Remove warning about already visible widgets
...
That was just added by mistake of course.
2017-01-22 14:48:28 +01:00
Timm Bäder
56a58655fe
Remove unnecessary gtk_widget_show calls
2017-01-22 14:38:21 +01:00
Timm Bäder
dc904ffaf9
gtkfontbutton: hexpand the font label
...
To restore the previous look.
2017-01-22 14:38:21 +01:00
Daniel Boles
90b9dc458f
combobox: Stop pointlessly NULL-checking the menu
...
We now have a valid menu to use at all times.
2017-01-21 21:34:46 +00:00
Daniel Boles
8c980445e3
combobox: Move area and menu to .ui file
...
Now that priv->area is guaranteed to be constructed by us, and not
passed in by a user, we can move it to the .ui file and stop manually
managing its lifetime altogether. And once the area is there, we can
move the menu there too (and stop pointlessly destroying/rebuilding it).
2017-01-21 21:34:46 +00:00
Daniel Boles
439fcf7578
combobox: Remove property cell-area
...
The CellArea is going to become a pure implementation detail & be moved
to the .ui, instead of letting users mess with it (if anyone ever did).
2017-01-21 21:34:45 +00:00
Daniel Boles
36413a8eca
combobox: Reuse code rather than reimplementing it
...
We already have cell_layout_is_sensitive() to get whether at least one
cell in a Layout is sensitive, which we need because CellLayout/View
do not implement foreach(). So, since we wrote that, we can use it to
check our CellArea too, instead of doing foreach with a custom callback.
2017-01-21 19:00:10 +00:00
Daniel Boles
c7e4c82df4
combobox: some code cleanups
...
* Merge adjacent if statements with the same condition
* Add a space between a function and its declaration
2017-01-21 18:59:27 +00:00
Daniel Boles
c5c0127e10
menushell: Fix select_last() to get last, not 1st
...
It was broken in the same way as select_first(), as explained in
commit a5211adb22
2017-01-21 18:55:46 +00:00
Daniel Boles
c662e691ed
combobox: Fix documentation typo bx => box
2017-01-21 16:13:44 +00:00
Daniel Boles
a5211adb22
menushell: Make select_first() do that, not last…
...
It was looping over all items, not breaking out when it found the first
selectable one, and then selecting the _last_ selectable one (if any)
found. So, it did exactly the opposite of its name. This made me quite
baffled when opening a submenu with right-arrow put me at its last item.
Originally, the loop set to_select and broke if the current item was
selectable and not tear-off, meaning that it would correctly select the
first suitable item. However, when tear-off functionality was removed
in commit 4ed9452e90
, so was the break.
2017-01-21 15:50:54 +00:00
Piotr Drąg
e47bd31e6a
Fix CSS spelling in a translatable string
2017-01-20 23:46:38 +01:00
Daniel Boles
71d7a1b3d0
menushell: Don’t dereference before typechecking
2017-01-20 22:15:42 +00:00
Daniel Boles
802f838aa0
combobox: If typechecking, don’t reference before
2017-01-20 21:08:58 +00:00
Timm Bäder
ab051fd53f
Don't hide windows and popovers in init()
...
Instead, don't make them visible in gtk_widget_init in the first place.
2017-01-20 21:51:05 +01:00