Commit Graph

3981 Commits

Author SHA1 Message Date
Manish Singh
8295d6982b declare _xdg_utf8_skip as extern to prevent multiple definitions.
Sun Feb  8 19:05:16 2004  Manish Singh  <yosh@gimp.org>

        * xdgmimeint.h: declare _xdg_utf8_skip as extern to prevent multiple
        definitions.
2004-02-09 03:06:22 +00:00
Manish Singh
4ac3998efb Add appropriate type casts for the gtk_window_set_screen() call.
Sun Feb  8 01:28:02 2004  Manish Singh  <yosh@gimp.org>

        * gtk/gtkcombobox.c (gtk_combo_box_set_popup_widget): Add appropriate
        type casts for the gtk_window_set_screen() call.
2004-02-08 09:29:11 +00:00
Matthias Clasen
41e49106e3 Make popups come up on the same screen as the combo box. (#133544, Morten
Sun Feb  8 01:44:06 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcombobox.c (gtk_combo_box_set_popup_widget): Make popups
	come up on the same screen as the combo box.  (#133544,
	Morten Welinder)
2004-02-08 00:42:59 +00:00
Jonathan Blandford
0180cce7f9 clean up the packing of the file selector.
Fri Feb  6 23:40:24 2004  Jonathan Blandford  <jrb@gnome.org>

        * gtk/gtkfilechooserdefault.c (create_file_list): clean up the
        packing of the file selector.
2004-02-07 17:28:36 +00:00
Matthias Clasen
bc21e066d6 Don't use function calls in array initializers, as some compilers seem to
Sat Feb  7 01:21:09 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtktreemodel.c (gtk_tree_model_base_init): Don't use function
	calls in array initializers, as some compilers seem to hate this.
	(#133216, Jonas Jonsson)
2004-02-07 00:21:37 +00:00
Matthias Clasen
c03700734e Add change notification for GtkAccelMap, by on-demand instantiating a
Sat Feb  7 00:06:44 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkaccelmap.[hc]: Add change notification for GtkAccelMap,
	by on-demand instantiating a singleton object with a "changed"
	signal.

	* gtk/gtkmarshalers.list (VOID:STRING,UINT,FLAGS): Add marshaller
	for GtkAccelMap::changed.
2004-02-06 23:37:00 +00:00
Matthias Clasen
738eeba8d6 Actually free the lists. Pointed out by Morten Welinder.
Fri Feb  6 23:08:29 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtktextbtree.c (_gtk_text_btree_check):
	* gtk/gtkcombobox.c (gtk_combo_box_cell_layout_clear_attributes):
	* gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear_attributes):
	Actually free the lists. Pointed out by Morten Welinder.
2004-02-06 22:25:01 +00:00
Matthias Clasen
09284d7aa0 Handle character positions in UTF-8 strings correctly. (#133315, Theppitak
Fri Feb  6 22:38:54 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcombo.c (gtk_combo_entry_key_press): Handle character
	positions in UTF-8 strings correctly.  (#133315, Theppitak
	Karoonboonyanan)
2004-02-06 21:47:37 +00:00
Morten Welinder
95ba48b38f Cleanup using gtk_menu_attach_to_widget. Also fixes leak, see #133411.
2004-02-06  Morten Welinder  <terra@gnome.org>

	* gtk/gtktoolbar.c (show_menu): Cleanup using
	gtk_menu_attach_to_widget.  Also fixes leak, see #133411.
2004-02-06 21:18:50 +00:00
Federico Mena Quintero
fd05813a0f Free the list. Fixes #133546.
2004-02-06  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free the
	list.  Fixes #133546.
2004-02-06 16:21:39 +00:00
Federico Mena Quintero
bf54dcdc5c Fix #132327.
2004-02-06  Federico Mena Quintero  <federico@ximian.com>

	Fix #132327.

	* gtk/gtkfilesystemunix.c (struct _GtkFileSystemUnix): Add a
	folder_hash field to keep a list of live folder objects.
	(gtk_file_system_unix_init): Create the folder_hash.
	(gtk_file_system_unix_finalize): Destroy the folder_hash.
	(gtk_file_system_unix_get_folder): Ref and return an existing
	folder if we have it around, otherwise return a new folder object.
	(struct _GtkFileFolderUnix): Add a field for the parent file system.
	(gtk_file_folder_unix_finalize): Remove the folder from the file
	system's hash table.
	(gtk_file_system_unix_create_folder):  Emit "files-added" on the
	newly-created folder's parent.  Fixes #132327.
2004-02-06 16:15:01 +00:00
Matthias Clasen
4bcc762377 Change the labels of the ZOOM_100 and ZOOM_FIT stock items to "_Normal
Fri Feb  6 00:51:57 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkstock.c (builtin_items): Change the labels of the
	ZOOM_100 and ZOOM_FIT stock items to "_Normal Size" and
	"Best _Fit", to be HIG compliant.  (#124080, Mariano
	Suárez-Alvarez)
2004-02-05 23:50:07 +00:00
Matthias Clasen
3b15c8b232 Add a finalize function to plug a few memory leaks. (#133544, Morten
Fri Feb  6 00:45:16 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcombobox.c (gtk_combo_box_finalize): Add a finalize
	function to plug a few memory leaks.  (#133544, Morten Welinder)
2004-02-05 23:45:21 +00:00
Matthias Clasen
5cc85a5a63 Support mnemonic_activate here as well.
Fri Feb  6 00:15:38 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcomboboxentry.c (gtk_combo_box_entry_mnemonic_activate):
	Support mnemonic_activate here as well.

	* gtk/gtkcombobox.c (gtk_combo_box_mnemonic_activate): Focus
	the button, not the tree_view.
2004-02-05 23:14:37 +00:00
Matthias Clasen
ee6d7bb5a4 Add this function, to make mnemonic_activate work for combo boxes.
Thu Feb  5 23:48:19 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcombobox.c (gtk_combo_box_mnemonic_activate): Add this
	function, to make mnemonic_activate work for combo boxes.
	(#133443, Paolo Borelli)
2004-02-05 22:46:22 +00:00
Matthias Clasen
4b50166b82 Initialize result to FALSE. (#133539, Morten Welinder)
Thu Feb  5 22:05:52 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkfilesystemunix.c (bookmark_list_read): Initialize result
	to FALSE.  (#133539, Morten Welinder)
2004-02-05 21:03:13 +00:00
Matthias Clasen
593806e0de Fix the logic of the depth one check. (#133488, Christian Persch)
Thu Feb  5 21:36:43 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcombobox.c (gtk_combo_box_set_active_iter): Fix the logic
	of the depth one check.  (#133488, Christian Persch)
2004-02-05 20:35:57 +00:00
Matthias Clasen
836953b5ba Fix the drawing of tearoff menu items which don't come first in their
Thu Feb  5 01:50:19 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtktearoffmenuitem.c (gtk_tearoff_menu_item_paint): Fix
	the drawing of tearoff menu items which don't come first in their
	menu.  (#33311)
2004-02-05 00:49:50 +00:00
Matthias Clasen
4fc7347cec Use g_completion_complete_utf8(). (#133313, Theppitak Karoonboonyanan)
Thu Feb  5 00:59:08 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcombo.c (gtk_combo_entry_key_press): Use
	g_completion_complete_utf8(). (#133313, Theppitak Karoonboonyanan)
2004-02-05 00:01:56 +00:00
Federico Mena Quintero
9a98cd8f87 Fix #59707.
2004-02-04  Federico Mena Quintero  <federico@ximian.com>

	Fix #59707.

	* gtk/gtklabel.c (gtk_label_focus): Removed, so we don't ignore
	the focus chain.
	(gtk_label_button_press): Fix prototype.
	(gtk_label_button_release): Likewise.
	(gtk_label_motion): Likewise.

	* tests/testgtk.c (create_message_dialog): For the dialog with
	only GTK_BUTTONS_CLOSE, make GTK_RESPONSE_CLOSE the default.
2004-02-04 21:55:33 +00:00
Morten Welinder
0b14aeea37 Show on the right screen. (Fixes bug 133411, apart from the leak.)
2004-02-04  Morten Welinder  <terra@gnome.org>

	* gtk/gtktoolbar.c (show_menu): Show on the right screen.  (Fixes
	bug 133411, apart from the leak.)
2004-02-04 21:17:54 +00:00
Manish Singh
9f35c7ae42 pass value in last in g_object_new, since it depends on lower and upper
Tue Feb  3 13:39:27 2004  Manish Singh  <yosh@gimp.org>

        * gtk/gtkadjustment.c (gtk_adjustment_new): pass value in last
        in g_object_new, since it depends on lower and upper being set.
2004-02-03 21:43:10 +00:00
Federico Mena Quintero
972b761cf2 Make the window not resizable. Fixes #114032.
2004-02-03  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkmessagedialog.c (gtk_message_dialog_init): Make the
	window not resizable.  Fixes #114032.
2004-02-03 20:46:52 +00:00
Federico Mena Quintero
2a18cfe2fa Add documentation for the use_separator style property.
2004-02-03  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkmessagedialog.c (gtk_message_dialog_class_init): Add
	documentation for the use_separator style property.
2004-02-03 20:04:33 +00:00
Federico Mena Quintero
d08dd112cc Fix #68938.
2004-02-03  Federico Mena Quintero  <federico@ximian.com>

	Fix #68938.

	* gtk/gtkdialog.c (GtkDialogPrivate): New private structure for
	GtkDialog; right now it only contains an ignore_separator field.
	(gtk_dialog_class_init): Register the private structure.
	(gtk_dialog_init): Initialize the priv->ignore_separator field.
	(_gtk_dialog_set_ignore_separator): New private function.
	(gtk_dialog_set_has_separator): Ignore the setting if appropriate.

	* gtk/gtkmessagedialog.c (gtk_message_dialog_class_init): Add a
	use_separator style property.
	(gtk_message_dialog_style_set): Change the dialog's separator
	based on the style property.
	(gtk_message_dialog_init): Set the dialog box to ignore the
	separator setting.
2004-02-03 19:46:43 +00:00
Matthias Clasen
09cf8937e2 Build filesystemwin32.c if OS_WIN32 and also dist gtkfilesystemwin32.[hc].
Tue Feb  3 02:35:09 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/Makefile.am: Build filesystemwin32.c if OS_WIN32 and
	also dist gtkfilesystemwin32.[hc].
2004-02-03 01:32:07 +00:00
Matthias Clasen
45b99a9cee Build filesystemwin32.c if OS_WIN32.
Tue Feb  3 02:32:52 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/Makefile.am: Build filesystemwin32.c if OS_WIN32.
2004-02-03 01:30:16 +00:00
Matthias Clasen
362158dc78 Right-justify labels in rtl mode. (#129071, chinen@jp.ibm.com)
Tue Feb  3 02:04:44 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtklabel.c (gtk_label_ensure_layout): Right-justify labels
	in rtl mode.  (#129071, chinen@jp.ibm.com)

Tue Feb  3 02:01:25 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkmenushell.c (gtk_real_menu_shell_move_current): Exchange the
	meaning GTK_MENU_DIR_PARENT/CHILD and GTK_MENU_DIR_PREV/NEXT in rtl
	mode.  (#107528)
2004-02-03 01:03:56 +00:00
Matthias Clasen
6c935950b2 Clip narrow columns in rtl-oriented tree views (#128089,
Tue Feb  3 01:38:06 2004  Matthias Clasen  <maclas@gmx.de>

	Clip narrow columns in rtl-oriented tree views (#128089,
	chinen@jp.ibm.com):

	* gtk/gtkstyle.c (gtk_default_draw_option):
	* gtk/gtkstyle.c (gtk_default_draw_check): Clip to the
	given area.

	* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action):
	Use the right clip area when calling gtk_cell_renderer_render().
	* gtk/gtktreeviewcolumn.c (_gtk_tree_view_column_cell_draw_focus):
	Use the right clip area when calling gtk_paint_focus().
	* gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
	Use the right clip area when calling gtk_paint_toggle() or
	gtk_paint_check().
	* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
	Clip to the expose_area when drawing the background rectangle.
2004-02-03 00:40:56 +00:00
Matthias Clasen
4ec8e2b20e Add init_hadjust_value and prev_width. Initialize them here. ...and here.
Tue Feb  3 00:15:17 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtktreeprivate.h (struct _GtkTreeViewPrivate): Add
	init_hadjust_value and prev_width.
	* gtk/gtktreeview.c (gtk_tree_view_init): Initialize
	them here.
	* gtk/gtktreeview.c (gtk_tree_view_update_size): ...and here.
	* gtk/gtktreeview.c (gtk_tree_view_size_allocate): Use them
	here to properly handle the initial position of rtl-oriented
	tree views.  (#127581, chinen@jp.ibm.com)
2004-02-02 23:20:42 +00:00
Federico Mena Quintero
f480c797cd Fix #130846, reported by R. McFarland <rwmcfa1@neces.com>.
2004-01-20  Federico Mena Quintero  <federico@ximian.com>

	Fix #130846, reported by R. McFarland <rwmcfa1@neces.com>.

	* gtk/gtktreeview.c (gtk_tree_view_button_press): Return TRUE when
	we handle an event in the colums, and FALSE at the end if the
	event is not handled at all.
2004-02-02 22:53:02 +00:00
Matthias Clasen
f744d5aa33 Don't access the level after removing the node, since that may kill the
Mon Feb  2 23:41:48 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtktreemodelfilter.c (gtk_tree_model_filter_row_changed):
	Don't access the level after removing the node, since that may
	kill the level.  (#132615, Crispin Flowerday)
2004-02-02 22:44:05 +00:00
Matthias Clasen
6eb2fe94cb The latest in menu separation technology.
Mon Feb  2 22:05:36 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkseparatormenuitem.c (gtk_separator_menu_item_init): The
	latest in menu separation technology.
2004-02-02 21:06:49 +00:00
Soeren Sandmann
a4bb27616f Only start sliding when using the new API.
Sun Feb  1 16:34:07 2004  Soeren Sandmann  <sandmann@daimi.au.dk>

	* gtk/gtktoolbar.c (gtk_toolbar_size_allocate): Only start
	sliding when using the new API.
2004-02-01 15:36:22 +00:00
Soeren Sandmann
623370a8e7 Make sure item_area is positioned correctly. Fix #133070, reported by
Sun Feb  1 16:03:39 2004  Soeren Sandmann  <sandmann@daimi.au.dk>

	* gtk/gtktoolbar.c (gtk_toolbar_size_allocate): Make sure
	item_area is positioned correctly. Fix #133070, reported by Jeroen
	Zwartepoorte.
2004-02-01 15:18:32 +00:00
Matthias Clasen
16a0782cea Don't crash when finalizing an unused GtkTextChildAnchor. (#132260,
Sat Jan 31 23:13:43 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtktextchild.c (gtk_text_child_anchor_finalize): Don't
	crash when finalizing an unused GtkTextChildAnchor.  (#132260,
	muppet)
2004-01-31 22:11:07 +00:00
Matthias Clasen
7139efeeb1 Correct the documentation for new_order. (#124790, Tim-Philipp Müller)
* gtk/gtktreemodel.c (gtk_tree_model_rows_reordered): Correct
	the documentation for new_order.  (#124790, Tim-Philipp Müller)

	* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_set_fixed_width):
	Reset use_resized_width when setting fixed_width.  (#108612,
	Felipe Heidrich)
2004-01-31 21:42:28 +00:00
Matthias Clasen
3269b900f8 Don't leak the GtkKeySnooperData. (#132038, R. McFarland)
Sat Jan 31 16:27:44 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkmain.c (gtk_key_snooper_remove): Don't leak the
	GtkKeySnooperData.  (#132038, R. McFarland)
2004-01-31 15:33:10 +00:00
Federico Mena Quintero
a9fbfc99f5 Fixes #132975.
2004-01-30  Federico Mena Quintero  <federico@ximian.com>

	Fixes #132975.

	* gtk/gtkfilesystem.c (gtk_file_system_make_path): Return NULL,
	not FALSE.
	(gtk_file_system_volume_render_icon): Likewise.

	* gtk/gtkfilesystemwin32.c (gtk_file_system_win32_make_path):
	Likewise.

	* gtk/gtktreestore.c (gtk_tree_store_iter_n_children): Return 0,
	not FALSE.

	* gtk/gtktoolbar.c (gtk_toolbar_get_drop_index): Return -1, not
	FALSE.

	* gtk/gtktextiter.c (gtk_text_iter_get_chars_in_line): Return 0,
	not FALSE.
	(gtk_text_iter_get_bytes_in_line): Likewise.

	* gdk/x11/gdkcursor-x11.c (gdk_display_get_default_cursor_size):
	Likewise.

	* gdk/linux-fb/gdkcolor-fb.c (gdk_colors_alloc): Return FALSE, not
	0.
2004-01-30 19:49:40 +00:00
Not Zed
ca644c4107 Fixes #132929.
2004-01-30  Not Zed  <NotZed@Ximian.com>

	Fixes #132929.

	* gtk/gtktreeview.c (cancel_arrow_animation): remove the timeout
	handler when we clear the timeout id.
2004-01-30 18:37:46 +00:00
Federico Mena Quintero
275cf046cf Fix #129872, based on a patch by Jan Arne Petersen <jpetersen@uni-bonn.de>
2004-01-30  Federico Mena Quintero  <federico@ximian.com>

	Fix #129872, based on a patch by Jan Arne Petersen
	<jpetersen@uni-bonn.de>

	* gtk/gtkfilesystemunix.c (gtk_file_system_unix_list_bookmarks):
	Implement.
	(gtk_file_system_unix_add_bookmark): Implement.
	(gtk_file_system_unix_remove_bookmark): Implement.

2004-01-29  Federico Mena Quintero  <federico@ximian.com>

	Fixes #132693.

	* gtk/gtkfilesystemunix.c (gtk_file_system_unix_get_parent): Don't
	use filename_from_path().  Also, check that the filename is
	absolute.
	(gtk_file_system_unix_get_folder): Likewise.
	(gtk_file_system_unix_create_folder): Likewise.
	(gtk_file_system_unix_make_path): Likewise.
	(gtk_file_system_unix_parse): Likewise.
	(gtk_file_folder_unix_get_info): Likewise.
	(filename_from_path): Removed.
2004-01-30 18:02:44 +00:00
Federico Mena Quintero
c43721c8eb Remove C++ comment; reported by Damien Carbery <damien.carbery@sun.com>.
2004-01-30  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkcalendar.c (arrow_action): Remove C++ comment; reported
	by Damien Carbery <damien.carbery@sun.com>.  Fixes #132956.
2004-01-30 17:59:59 +00:00
Matthias Clasen
cbfda60af1 Add properties to GtkAdjustment. (#64601, Murray Cumming)
Fri Jan 30 00:45:46 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkadjustment.c: Add properties to GtkAdjustment.
	(#64601, Murray Cumming)
2004-01-29 23:49:25 +00:00
Owen Taylor
a5f9b185ab gtk/gtktextlayout.c (line_display_iter_to_index) Only adjust the preedit
Thu Jan 29 18:08:06 2004  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtktextlayout.c (line_display_iter_to_index)
        * gtk/gtktextlayout.c (line_display_index_to_iter): Only
        adjust the preedit position for lines that include the
        preedit string. (#132353, Yao Zhang). How the heck
        did this work as well as it did?!?!

        * modules/input/gtkimcontextxim.c (gtk_im_context_xim_get_ic):
        Reverse change to change of XNFilterEvents event mask from
        #110493 -- it's documented and in the Xlib code an
        unsigned long.

        * modules/input/gtkimcontextxim.c (preedit_start_callback):
        Return -1 rather than void to indicate no length limit.
        (#129548)
2004-01-29 23:33:07 +00:00
Matthias Clasen
bdca6b33b8 Allow NULL for strings to clear the list. (#105386, Marco Pesenti Gritti)
Fri Jan 30 00:13:46 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcombo.c (gtk_combo_set_popdown_strings): Allow NULL
	for strings to clear the list.  (#105386, Marco Pesenti Gritti)
2004-01-29 23:26:45 +00:00
Richard Hult
25d649abbf Free font_desc. Fixes #132805.
2004-01-28  Richard Hult  <richard@imendio.com>

	* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_get_size):
	Free font_desc.  Fixes #132805.
2004-01-29 18:10:29 +00:00
Federico Mena Quintero
e3138546d1 Free the GError. Patch provided by Christian Persch
2004-01-29  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkiconfactory.c (render_icon_name_pixbuf): Free the GError.
	Patch provided by Christian Persch <chpe@stud.uni-saarland.de>
2004-01-29 17:55:48 +00:00
Owen Taylor
0cad69fcdd nul-terminate the target atoms. (#132656, Christian Persch)
Thu Jan 29 11:00:18 2004  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkselection.c (gtk_selection_default_handler):
        nul-terminate the target atoms. (#132656, Christian Persch)
2004-01-29 16:33:30 +00:00
Matthias Clasen
026542e29f Don't leak path if we bail out early. (#132505, Christian Persch)
Thu Jan 29 00:59:03 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtktreemodelfilter.c (gtk_tree_model_filter_rows_reordered): Don't leak
	path if we bail out early.  (#132505, Christian Persch)
2004-01-28 23:56:50 +00:00
Matthias Clasen
b3ecd29090 Do reference counting on the user_data that is shared between multiple
Thu Jan 29 00:48:47 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkactiongroup.c (gtk_action_group_add_toggle_actions_full):
	* gtk/gtkactiongroup.c (gtk_action_group_add_actions_full): Do reference
	counting on the user_data that is shared between multiple signal handlers,
	to avoid calling the destroy notify multiple times.  (#132447, Adam Hooper)
2004-01-28 23:49:10 +00:00