Kristian Rietveld
058a9090c2
treemodelfilter: Move more missions of row-deleted down
...
The row-deleted signal should be emitted after the internal data
structures have been updated. In gtk_tree_model_filter_remove_elt_from_level
and gtk_tree_model_filter_virtual_root_deleted the signal was still being
emitted before the updates were carried out.
2011-08-22 21:30:32 +02:00
Kristian Rietveld
cac5d60633
Unit test reference counting in GtkTreeModelSort
2011-08-22 21:30:31 +02:00
Kristian Rietveld
dec7a34047
Avoid unreferencing deleted nodes
...
Now that we call unref_node in free_level, we have to take care that
free_level may only unref (parent) nodes when these still exist in the
child model. After row-deleted has been received for a node, its
children may no longer unref this node.
2011-08-22 21:30:31 +02:00
Kristian Rietveld
7677e2d4e3
Bug 611922 - gtk_tree_model_sort_ref_node() is too slow
...
Referencing a parent node for each referenced node is overdone. Instead,
we now reference the parent from build_level and unreference in free_level.
Each level keeps a single reference on its immediate parent. This both
alleviates the performence problems and should perfectly serve the purpose.
2011-08-22 21:30:31 +02:00
Kristian Rietveld
d241323b08
Move asserts to gtktreemodelrefcount.h for other unit tests to use
2011-08-22 21:30:31 +02:00
Kristian Rietveld
bda09159c3
Add generic GtkTreeModel reference counting unit tests
2011-08-22 21:30:31 +02:00
Kristian Rietveld
1cb14a16b7
Add GtkTreeModelRefCount, only to be used in unit tests
2011-08-22 21:30:31 +02:00
Kristian Rietveld
b8752210ba
treemodelsort: Remove unnecessary comment
...
(I am no longer 17 years old and have grown up by now).
2011-08-22 21:30:31 +02:00
Kristian Rietveld
a485334c37
Add some comments to gtk_tree_model_filter_remove_elt_from_level
2011-08-22 21:30:31 +02:00
Kristian Rietveld
e89782742d
Fix a couple of memleaks in the filter model tests
...
(Not all of them yet, need to do the remainder on Linux since valgrind
on Mac OS X is a bit too noisy).
2011-08-22 21:30:31 +02:00
Kristian Rietveld
76cfd8bfac
Bug 621076 - GtkTreeModelFilter does not emit all signals in some ...
...
The bulk of the fix is to walk the chain of ancestors, starting at the
root level, and check if the visibility of any of the ancestors has
changed. If yes, the necessary signals are emitted so that this change
is propagated properly. This walk is done after a node has been
inserted, changed or deleted, see function
gtk_tree_model_filter_check_ancestors().
Bug reported, and initial debugging and analysis, by Xavier Claessens.
2011-08-22 21:30:31 +02:00
Kristian Rietveld
c8783d3339
Decrease code duplication in _remove_elt_from_level take two
2011-08-22 21:30:31 +02:00
Kristian Rietveld
df754517dd
Decrease amount of code duplication in _remove_elt_from_level
2011-08-22 21:30:31 +02:00
Kristian Rietveld
a9fd6b7f85
Rename gtk_tree_model_filter_remove_node for internal consistency
2011-08-22 21:30:31 +02:00
Kristian Rietveld
7a82045ca8
Change signature of gtk_tree_model_filter_remove_node
2011-08-22 21:30:31 +02:00
Xavier Claessens
22adfc67e5
Add thorough unit test for bug #621076
...
Minor edits and additions by Kristian Rietveld.
2011-08-22 21:30:30 +02:00
Kristian Rietveld
a172697d47
Corrections to has-child filter tests
2011-08-22 21:30:30 +02:00
Kristian Rietveld
74764f28bc
Improve specific_has_child_filter() test to also verify signals
2011-08-22 21:30:30 +02:00
Kristian Rietveld
ebb12d5f06
Improve specific_root_has_child_filter test to also verify signals
2011-08-22 21:30:30 +02:00
Kristian Rietveld
5bd3c52c0f
Have a separate category for tests of gtk_tree_model_filter_row_deleted
2011-08-22 21:30:30 +02:00
Kristian Rietveld
3452b0493d
Add two unit tests for gtk_tree_model_filter_row_inserted
2011-08-22 21:30:30 +02:00
Kristian Rietveld
4f33f10511
Use g_assert_cmpint instead of g_assert in check_level_length()
2011-08-22 21:30:30 +02:00
Kristian Rietveld
7b3c2751ee
Refactor emitting row-inserted for new nodes to a common code path
...
Suggested by Xavier Claessens / bug 621076.
2011-08-22 21:30:30 +02:00
Kristian Rietveld
bcb00d9a43
Fix comment
2011-08-22 21:30:30 +02:00
Kristian Rietveld
f064d07bda
Factor out find_elt_with_offset
...
Suggested by Xavier Claessens / bug 621076.
2011-08-22 21:30:30 +02:00
Kristian Rietveld
60f3f92e95
Refactor to a common code path for inserts of nodes in levels
...
Suggested by Xavier Claessens / bug 621076.
(Additional obseration: this should speed up the filter model's
handling of row-inserted as a binary search is now used instead
of a linear scan).
2011-08-22 21:30:30 +02:00
Xavier Claessens
dc12c373dc
Improve error messages of signal monitor
2011-08-22 21:30:30 +02:00
Kristian Rietveld
e0f12ce020
Factor out another part of gtk_tree_model_filter_row_deleted
2011-08-22 21:30:30 +02:00
Kristian Rietveld
1686e515d6
Three more TreeModelFilter remove ancestor tests
2011-08-22 21:30:30 +02:00
Kristian Rietveld
df0fcfb940
In sort model also emit row-deleted after updating the data structures
2011-08-22 21:30:30 +02:00
Kristian Rietveld
e9c960929b
Correct GtkTreeModelFilter to never unref an already deleted child node
2011-08-22 21:30:30 +02:00
Kristian Rietveld
b27a6568b7
Improve filter model remove node unit tests
2011-08-22 21:30:29 +02:00
Kristian Rietveld
f0da89fa20
Print failed assertions for failed child iterator conversions
2011-08-22 21:30:29 +02:00
Kristian Rietveld
2f5fbcd10a
Make _get_iter invalidate iterators when FALSE is returned
2011-08-22 21:30:29 +02:00
Kristian Rietveld
431987a2fa
Add more unit tests for gtk_tree_model_filter_row_deleted()
2011-08-22 21:30:29 +02:00
Kristian Rietveld
56f83ad197
Further reduce variable shadowing by factoring code out into functions
2011-08-22 21:30:29 +02:00
Kristian Rietveld
cb8c608e49
Add unit test for bug 77977 for reference
2011-08-22 21:30:29 +02:00
Kristian Rietveld
ed603fa790
Add bug base and bug numbers to tree model unit tests
2011-08-22 21:30:29 +02:00
Kristian Rietveld
f1d791355a
Move TreeModelSort specific tests to a new sortmodel.c file
2011-08-22 21:30:29 +02:00
Kristian Rietveld
b227aa06eb
Make naming of tree model unit tests consistent
...
All test paths now start with the name of the class which is being
tested.
2011-08-22 21:30:29 +02:00
Kristian Rietveld
2cb9f03a66
Put all GtkTreeModel unit tests in a single binary
...
This to reduce linking time and have all tests in a single binary.
2011-08-22 21:30:29 +02:00
Chun-wei Fan
ad73ed298d
Include C89 fallback code
...
gtk/gtkborderimage.c, gtk/gtklabel.c and gtk/gtkstyleproperty.c call
round() and/or rint(), which was only available in C99 compilers.
This adds the inclusion of the fallback implementation (gtk/fallback-c89.c)
to define these functions if they are not initially made available by the
compiler.
Also remove the rint() implementation in gtk/gtklabel.c as it is now in
the fallback implmentation.
2011-08-20 11:17:44 +08:00
Chun-wei Fan
db3fecc5b9
Add fallback implemetation for rint()/round()
...
Add an implementation for rint() and round() for compilers that do not
define one or both of them. Note that this file should be included
after config.h was included.
2011-08-20 11:17:43 +08:00
David Zeuthen
c68eeaa966
Bug 656851 – Allow use of GVariant in GtkListStore
...
Signed-off-by: David Zeuthen <davidz@redhat.com>
2011-08-18 17:49:40 -04:00
Matthias Clasen
915d32f59c
Fix up symbol lists for recent api additions
2011-08-15 21:25:58 -04:00
Matthias Clasen
8cf52c8e6c
Fix a typo
2011-08-15 19:24:59 -04:00
Matthias Clasen
6877893ed5
Make setting fontname work, independent of a screen
2011-08-15 18:57:58 -04:00
Matthias Clasen
1207757924
Keep the currently selected font over theme changes
...
When repopulating the list of fonts, don't loose the current
selection, unless the font is no longer in the list.
2011-08-15 18:57:57 -04:00
Matthias Clasen
9c85d4f6df
Deprecate GtkFontSelection and GtkFontSelectionDialog
2011-08-15 18:57:57 -04:00
Matthias Clasen
930715665e
Trivial formatting fix
2011-08-15 18:57:57 -04:00
Matthias Clasen
0ee89f1360
Add new symbols
2011-08-15 18:57:57 -04:00
Matthias Clasen
a09ee203ec
Add filtering to the font chooser
2011-08-15 18:57:57 -04:00
Matthias Clasen
ba564088c3
Add 'no matches' functionality
...
Initial cut at showing a 'no matches' message if the font list
is empty.
2011-08-15 18:57:57 -04:00
Matthias Clasen
6fb69845b0
Make the fontchooser dialog come up in a reasonable size
...
This is not a perfect solution; we really just want to set
a nice default size, but GTK+ does not make that easy.
2011-08-15 18:57:57 -04:00
Matthias Clasen
7c4ad1f400
Just use a single grid
...
The subgrid didn't really add anything.
2011-08-15 18:57:57 -04:00
Matthias Clasen
43d62c08e3
Clean up error handling
2011-08-15 18:57:57 -04:00
Matthias Clasen
5b9857d9b9
Rename some statics
...
gtk_font_chooser_ref_{family,face} -> gtk_font_chooser_set_{family,face}
2011-08-15 18:57:57 -04:00
Matthias Clasen
8dbdfa7e73
Avoid extraneous signals at destroy time
...
We need to disconnect the cursor-changed handler before the
treeview gets destroyed, to avoid unwanted emissions.
2011-08-15 18:57:57 -04:00
Matthias Clasen
97d26ac9c0
Simplify a few things
...
Adwaita seems to misrender focus on entries with margins, so
use spacing instead. Also, don't use entry buffer unnecessarily.
2011-08-15 18:57:57 -04:00
Matthias Clasen
a18fab88a1
Trivial formatting fixes
...
Just committing these is easier than writing them up.
2011-08-15 18:57:57 -04:00
Alberto Ruiz
a58a2dc0d3
GtkFontChooserDialog: GtkFontButton now uses GtkFontChooserDialog instead of GtkFontSelectionDialog
2011-08-15 18:57:57 -04:00
Alberto Ruiz
e79842ce94
GtkFontChooser: get_font_name did not return the font size
2011-08-15 18:57:56 -04:00
Alberto Ruiz
d33088a805
GtkFontChooser: Stub code to handle empty list by search.
2011-08-15 18:57:56 -04:00
Alberto Ruiz
66a7add23f
GtkFontChooser: font-name property notification wasn't properly propagated during size change from the spinbutton
2011-08-15 18:57:56 -04:00
Alberto Ruiz
52177f5e0d
GtkFontChooser: Missing G_END_DECLS in fontchooser header
2011-08-15 18:57:56 -04:00
Alberto Ruiz
5795d3d616
GtkFontChooser: Using G_N_ELEMENTS instead of a define
2011-08-15 18:57:56 -04:00
Alberto Ruiz
9245a66e6f
GtkFontChooser: Using the widget instead of the private struct as signal data in all conects
2011-08-15 18:57:56 -04:00
Alberto Ruiz
bf8ad994d4
GtkFontChooser: Fixed coding style wrt spacing around operators
2011-08-15 18:57:56 -04:00
Alberto Ruiz
26fb5c90b1
GtkFontChooser: Using explicit comparisons for g_strcmp0
2011-08-15 18:57:56 -04:00
Alberto Ruiz
ab1ebb072e
GtkFontChooser: Added missing breaks in switch statements
2011-08-15 18:57:56 -04:00
Alberto Ruiz
c36d291acc
GtkFontChooser: Setting all ought to be static functions as static
2011-08-15 18:57:56 -04:00
Alberto Ruiz
bf457d129e
GtkFontChooserDialog: Add parent window as a parameter in the constructor
2011-08-15 18:57:56 -04:00
Alberto Ruiz
523190f69a
GtkFontChooserDialog: Fix get_font_chooser public function name
2011-08-15 18:57:56 -04:00
Alberto Ruiz
23b15254bb
GtkFontChooser: Set correct margin values between UI elements
2011-08-15 18:57:56 -04:00
Alberto Ruiz
a55d2f67b0
GtkFontChooserDialog: Use g_object_new to set initial values in the dialog constructor
2011-08-15 18:57:56 -04:00
Alberto Ruiz
01f279338f
GtkFontChooser: Remove outdated Copyright information
2011-08-15 18:57:56 -04:00
Alberto Ruiz
1dda502bcb
GtkFontChooser: Fix size synchronization between slider and spin button
2011-08-15 18:57:56 -04:00
Alberto Ruiz
cabfcbd18d
GtkFontChooser: Cleanup comments and fix indentation alignments
2011-08-15 18:57:56 -04:00
Alberto Ruiz
e3f70857af
GtkFontChooser: Remove default geometry defines
2011-08-15 18:57:55 -04:00
Alberto Ruiz
55d50b3cca
GtkFontChooser: Fix scroll callback connected to treeview instead of preview
2011-08-15 18:57:55 -04:00
Alberto Ruiz
9dee34ad27
GtkFontChooser: Remove the themed color for the font title
2011-08-15 18:57:55 -04:00
Alberto Ruiz
f5a00f0c77
GtkFontChooser: Use a nested grid to achieve the right layout in the size controls
2011-08-15 18:57:55 -04:00
Alberto Ruiz
1075b7ac38
GtkFontChooser: Fix expand and fill properties for the grid layout
2011-08-15 18:57:55 -04:00
Alberto Ruiz
d9187472f5
GtkFontChooser: Use GtkBox instead of GtkVBox as base class.
2011-08-15 18:57:55 -04:00
Alberto Ruiz
b37863a5ba
GtkFontChooser: Use const instead of G_CONST_RETURN
2011-08-15 18:57:55 -04:00
Alberto Ruiz
03ab18fa7a
GtkFontChooser: Add preview entry to the grid
2011-08-15 18:57:55 -04:00
Alberto Ruiz
f60d0dc35a
GtkFontChooser: Initial work to use GtkGrid
2011-08-15 18:57:55 -04:00
Alberto Ruiz
4163fa5d29
GtkFontChooser: GtkFontChooserDialog: Update documenation to reflect Since: 3.2
2011-08-15 18:57:55 -04:00
Alberto Ruiz
4add47946b
GtkFontChooserDialog: Split the dialog out of gtkfontchooser.[ch] to gtkfontchooserdialog.[ch]
2011-08-15 18:57:55 -04:00
Alberto Ruiz
8e621f593e
GtkFontChooser: Use symbolic icons in the filter entry
2011-08-15 18:57:55 -04:00
Alberto Ruiz
5ccc66d855
GtkFontChooser: Now shearch filters each individual term rather than the whole string at once
2011-08-15 18:57:55 -04:00
Alberto Ruiz
db2ef8ce51
GtkFontChooser: Restore automatic alignment on scroll to selection
2011-08-15 18:57:55 -04:00
Alberto Ruiz
7067d36adb
GtkFontChooser: Removed support for deprecated functionality from GtkFontSelector
2011-08-15 18:57:55 -04:00
Alberto Ruiz
4bf22639d1
GtkFontChooser: Expose the new widget in gtk.h and add test cases
2011-08-15 18:57:55 -04:00
Alberto Ruiz
334ee81901
GtkFontChooser: Renaming the class names and fixing the tests
2011-08-15 18:57:55 -04:00
Alberto Ruiz
f2376ad401
GtkFontChooser: Remove wrong usage of GTK_DISABLE_DEPRECATED
2011-08-15 18:57:55 -04:00
Alberto Ruiz
bbe8d13c6e
GtkFontChooser: Check if the deprecated widgets are present before updating the size list
2011-08-15 18:57:54 -04:00
Alberto Ruiz
1b00a3eb76
GtkFontChooser: Update fontlist on style change
2011-08-15 18:57:54 -04:00
Alberto Ruiz
6dec212d1d
GtkFontChooser: Add a property to control whether the preview entry is shown or not
2011-08-15 18:57:54 -04:00
Alberto Ruiz
5eb614a25b
GtkFontChooser: Add gtk_font_selection_dialog_get_select_button and use GTK_DISABLE_DEPRECATED in gtkfontsel.h
2011-08-15 18:57:54 -04:00
Alberto Ruiz
1ce5a04406
GtkFontChooser: Changed dialog label from OK to Select, deprecated get_ok_button and internal apply button.
2011-08-15 18:57:54 -04:00
Alberto Ruiz
31776e2a25
GtkFontChooser: implement gtk_font_selection_set/get_preview_text
2011-08-15 18:57:54 -04:00
Alberto Ruiz
14fbbf1420
GtkFontChooser: check if font name is NULL in gtk_font_selection_set_font_name
2011-08-15 18:57:54 -04:00
Alberto Ruiz
ea4603e5d1
GtkFontChooser: gtk_font_selection_set_font_name implementation
2011-08-15 18:57:54 -04:00
Alberto Ruiz
3f2b09422d
GtkFontChooser: Setting the font-name property. Test updates. Remove warnings.
2011-08-15 18:57:54 -04:00
Alberto Ruiz
0aae453d77
GtkFontChooser: Improve bootstrapping of the deprecated lists
2011-08-15 18:57:54 -04:00
Alberto Ruiz
2ef00d23e3
GtkFontChooser: Update selection on deprecated size list selection
2011-08-15 18:57:54 -04:00
Alberto Ruiz
dc1a47ad70
GtkFontChooser: Update selection on deprecated face or font list selection
2011-08-15 18:57:54 -04:00
Alberto Ruiz
0ef0359566
GtkFontChooser: Update size when selecting an item of the deprecated size list
2011-08-15 18:57:54 -04:00
Alberto Ruiz
72a971b0e0
GtkFontChooser: Blocking the cursor change callbacks from happening on the deprecated widgets when selecting the font from the fontselector
2011-08-15 18:57:53 -04:00
Alberto Ruiz
c28b1e32e3
GtkFontChooser: Update deprecated font list on slection
2011-08-15 18:57:53 -04:00
Alberto Ruiz
1821eac1c1
GtkFontChooser: Refactoring the default font size, face and family assignment for clarity
2011-08-15 18:57:53 -04:00
Alberto Ruiz
aa10abacbc
GtkFontChooser: Use the theme font as the default font
2011-08-15 18:57:53 -04:00
Alberto Ruiz
4b92872a97
GtkFontChooser: Add callbacks and improve test to take deprecated widgets into account
2011-08-15 18:57:53 -04:00
Alberto Ruiz
e80053c659
GtkFontChooser: Use GTK_DISABLE_DEPRECATED to encapsulate the deprecated functionality
2011-08-15 18:57:53 -04:00
Alberto Ruiz
3c0b6914e0
GtkFontChooser: Unref deprecated widgets on finalize
2011-08-15 18:57:53 -04:00
Alberto Ruiz
bb008411e0
GtkFontChooser: Use scrolled windows for the deprecated widgets
2011-08-15 18:57:53 -04:00
Alberto Ruiz
706167bbbd
GtkFontChooser: Populate face names in the deprecated face list
2011-08-15 18:57:53 -04:00
Alberto Ruiz
0d112810f9
GtkFontChooser: Populate font family names in the deprecated family list
2011-08-15 18:57:53 -04:00
Alberto Ruiz
8826a10bc8
GtkFontChooser: Add tree view columns for the deprecated widgets
2011-08-15 18:57:53 -04:00
Alberto Ruiz
915b442dc1
GtkFontChooser: Fix segmentation fault in deprecated size list population
2011-08-15 18:57:53 -04:00
Alberto Ruiz
29a0685ee8
GtkFontChooser: Add deprecated calls to the test
2011-08-15 18:57:53 -04:00
Alberto Ruiz
1a2ef4db60
GtkFontChooser: update the size model for the deprecated size list
2011-08-15 18:57:53 -04:00
Alberto Ruiz
e08006f691
GtkFontChooser: initialization and destruction of deprecated widgets and data models
2011-08-15 18:57:53 -04:00
Alberto Ruiz
abc92d5030
GtkFontChooser: Initial support for deprecated functions
2011-08-15 18:57:53 -04:00
Alberto Ruiz
c96698e95f
GtkFontChooser: Filter also by font face
2011-08-15 18:57:53 -04:00
Alberto Ruiz
58b2204651
GtkFontChooser: Layout improvements, spacing between elements and default widget size.
2011-08-15 18:57:53 -04:00
Alberto Ruiz
36156a6c49
GtkFontChooser: Layout improvements. Adding shadow to scrolled windows. Font+Face text is now bold.
2011-08-15 18:57:52 -04:00
Alberto Ruiz
f75e4d314a
GtkFontChooser: Improvements on the size setting signals between the preview, scale and spinbutton. Adding more string fields to the model to allow for backwards compatibility.
2011-08-15 18:57:52 -04:00
Alberto Ruiz
1688512252
GtkFontChooser: Fixing mouse scroll zooming behaviour for the preview and the size controls
2011-08-15 18:57:52 -04:00
Alberto Ruiz
858e13cad6
GtkFontChooser: Setting a minimum width andfix the markup for the rows
2011-08-15 18:57:52 -04:00
Alberto Ruiz
af14106a63
GtkFontChooser: Ellipsize cell renderer and set a better size list
2011-08-15 18:57:52 -04:00
Alberto Ruiz
0db1b63b1f
GtkFontChooser: Keep reference to the face and the family objects
2011-08-15 18:57:52 -04:00
Alberto Ruiz
88ab6f14d3
GtkFontChooser: Better cursor selection and model leak fixes
2011-08-15 18:57:52 -04:00
Alberto Ruiz
f3e9bb312e
GtkFontChooser: Enable font selection
2011-08-15 18:57:52 -04:00
Alberto Ruiz
c9150374d9
GtkFontChooser: Setting a default vertical size
2011-08-15 18:57:52 -04:00
Alberto Ruiz
7f125d95e8
GtkFontChooser: Layout enhancements, using a scrolled window for the preview entry.
2011-08-15 18:57:52 -04:00
Alberto Ruiz
cbaca3e4bf
GtkFontChooser: Fixed size updating in the preview
2011-08-15 18:57:52 -04:00
Alberto Ruiz
272f11069f
GtkFontChooser: Improvements on the spin/slider interaction
2011-08-15 18:57:52 -04:00
Alberto Ruiz
c303d0b18c
GtkFontChooser: The spinner now updates the slider size if it is within the range
2011-08-15 18:57:52 -04:00
Alberto Ruiz
1fa2c503a7
GtkFontChooser: Getting the refiltering right for the clear icon. Filter function speedups.
2011-08-15 18:57:52 -04:00
Alberto Ruiz
94ee606f62
GtkFontChooser: Search entry icon is now dynamic depending on the content
2011-08-15 18:57:52 -04:00
Alberto Ruiz
4db5ea20e8
GtkFontChooser: Set the initial size to the slider, initial callbacks for size change
2011-08-15 18:57:52 -04:00
Alberto Ruiz
fb19245493
GtkFontChooser: Live search implemented
2011-08-15 18:57:51 -04:00
Alberto Ruiz
693617700b
GtkFontChooser: Inserted and deleted text callbacks
2011-08-15 18:57:51 -04:00
Alberto Ruiz
76809e128a
GtkFontChooser: Adding a tree model filter for the search functionality
2011-08-15 18:57:51 -04:00
Alberto Ruiz
ce10919978
GtkFontChooser: Setting the default preview text and the default font size
2011-08-15 18:57:51 -04:00
Alberto Ruiz
9af88217d1
GtkFontChooser: Compilation warning cleanups
2011-08-15 18:57:51 -04:00
Alberto Ruiz
b79802789d
GtkFontChooser: Iterate over faces as well as families to list them
2011-08-15 18:57:51 -04:00
Alberto Ruiz
f854a46890
GtkFontChooser: Improvements in the font face listing
2011-08-15 18:57:51 -04:00