Matthias Clasen
e8b9aacfc1
combo: Add .linked class when appropriate
...
Add the .linked style class to combo boxes which have
an entry, since that is what they are.
2016-01-15 17:55:44 -05:00
Matthias Clasen
54a6e032ca
combobox: Document the popup window CSS node
2016-01-15 17:48:39 -05:00
Cosimo Cecchi
23d8791a47
combobox: remove unused struct member
...
The box was removed a while ago.
2015-12-22 10:53:03 -08:00
Cosimo Cecchi
ef41bd7112
combobox: deprecate shadow-type style property
...
It does not add any value to what can be achieved through regular CSS
styling.
2015-12-22 09:29:43 -08:00
Cosimo Cecchi
f5628f0439
combobox: port to use a gadget
...
Wrap the size request and allocate code into a GtkCssCustomGadget. This
makes margins work on GtkComboBox.
2015-12-22 09:29:43 -08:00
Cosimo Cecchi
a90d928a34
combobox: use a private variable when possible
...
Instead of dereferencing the same variable over and over.
2015-12-22 09:29:43 -08:00
Cosimo Cecchi
f03268eabe
combobox: trivial code cleanup
2015-12-22 09:29:43 -08:00
Cosimo Cecchi
ebc7b59b44
combobox: remove unneeded check
...
The combobox always has a window.
2015-12-22 09:29:43 -08:00
Cosimo Cecchi
5764c09272
combobox: use GtkIcon to render button arrow
...
We can now use the newly introduced GtkIcon widget to properly render
the arrow in the combobox with CSS.
2015-12-22 09:29:43 -08:00
Carlos Garnacho
26f3d02f03
GtkComboBox: Avoid GdkDeviceManager API
...
We used to pick a master pointer "at random", use the default seat pointer
instead.
2015-12-16 19:47:06 +01:00
Carlos Garnacho
534b0af512
GtkComboBox: Use gdk_seat_grab()
...
https://bugzilla.gnome.org/show_bug.cgi?id=759309
2015-12-15 00:32:55 +01:00
Adam Reichold
5088b4937e
Fix method to update menu sensitivity of combo box
...
After removal of the selectable header and separator from the combo box,
the method to update the menu sensitivity must be changed as it assumes
at least two items within each sub menu and contains special handling
for the separator. Removing this fixes bug #759079 .
2015-12-07 11:23:18 -05:00
Matthias Clasen
f1b7005ede
combobox: Don't add .linked
...
It interferes with getting the desired styling for combo boxes
with an entry, and is not needed.
2015-11-05 21:59:56 -05:00
Matthias Clasen
92e3655ace
combo box: Add diagrams to CSS documentation
2015-11-03 14:27:35 -05:00
Florian Müllner
9a29a2768b
Deprecate widget-specific :focus-on-click properties
...
The differences between the existing properties and the newly added
GtkWidget:focus-on-click property are minimal (different owner_type
in GParamSpec), so it is extremely unlikely that dropping the former
would break anything.
https://bugzilla.gnome.org/show_bug.cgi?id=757269
2015-11-03 07:44:17 -05:00
Matthias Clasen
d229ea3de1
combobox: Use element names
...
Use combobox as the element name for the main CSS nodes of
GtkComboBox and GtkComboBoxText. Add the .combo style class
to the button and entry. in a GtkComboBox or GtkComboBoxText.
2015-11-02 13:56:25 -05:00
Benjamin Otte
624fb8b360
entry: Always render like with is_cellrenderer
...
And remove the API to set that variable.
If you want the entry to not fill its whole allocated area,
gtk_widget_set_valign (entry, GTK_ALIGN_FILL);
will give you the old behavior.
2015-10-28 19:44:26 +01:00
Benjamin Otte
bf95c8462b
combobox: Stop using old styling code
...
Instead of get_path_for_child() use CSS nodes.
2015-09-13 01:54:03 +02:00
Benjamin Otte
2550c6a4db
combobox: Refactor cell view treatment
...
Instead of putting it inside the button manually, put it there properly
by adding a box containing the cell view and the arrow.
Do the same thing in list mode, instead of creating an event box that
tries to behave as a button.
2015-07-31 04:03:44 +02:00
Benjamin Otte
bbd9c59832
combobox: Handle NULLing the cellview on remove simpler
2015-07-31 04:03:44 +02:00
Benjamin Otte
1261ec985b
combobox: Remove unused variables
2015-07-31 04:03:44 +02:00
Benjamin Otte
62c43aac43
combobox: Create cell view identically
...
... in the two places it can be created.
2015-07-31 04:03:44 +02:00
Benjamin Otte
5e2ab6db7f
combobox: Use ui file to construct internal button child
2015-07-26 17:18:42 +02:00
Benjamin Otte
5ad5431cb7
combobox: Create button on init() and destroy in destroy()
...
The button is the same in both menu and list mode, so there's no need to
destroy and recreate it.
2015-07-26 17:18:42 +02:00
Benjamin Otte
e0572212bc
combobox: Add scroll support in list mode
2015-07-26 17:18:42 +02:00
Benjamin Otte
8243140731
combobox: Remove unused argument
...
The visible check is always FALSE, so no need to keep the code around.
2015-07-26 17:18:42 +02:00
Benjamin Otte
63c219b8e7
combobox: Remove the box from the button
...
... when in menu mode.
Now that we don't have a separator anymore, the box is not needed
anymore.
2015-07-26 17:18:42 +02:00
Benjamin Otte
fcb26376df
combobox: Remove the separator
...
It was a special case and it's not used by themes anymore.
Plus, in the CSS world, if a theme wants a separator, it can just
style the button's border to create one.
2015-07-26 17:18:42 +02:00
Benjamin Otte
3402363684
combobox: Unconditionally draw background and border
2015-07-21 02:28:53 +02:00
Benjamin Otte
5f6db9a182
combobox: Remove autoscroll timer on popdown
2015-07-21 02:28:53 +02:00
Benjamin Otte
19726a5a0e
combobox: Remove cell_view_frame
...
Cell views can draw their own frames now.
2015-07-21 02:28:53 +02:00
Benjamin Otte
8d3bcb6ef8
combobox: Simplify code
...
We don't add new children to the child's parent, we add them to ourself.
Because guess who a child's parent is?
2015-07-18 05:39:01 +02:00
Benjamin Otte
d071415d56
combobox: Remove unused header function functionality
2015-07-18 05:18:19 +02:00
Benjamin Otte
1ec7f435d8
combobox: Remove unused argument from private function
2015-07-18 05:18:19 +02:00
Matthias Clasen
f16fc99391
combo box: Fix compiler warnings
...
Fix warnings due to -Wdeclaration-after-statement and -Wshadow.
2015-06-02 09:08:15 -04:00
Benjamin Otte
9744e86e04
combobox: Don't set cell view background
...
This can be done with CSS these days. Also, these days the background of
cell views is transparent, so it doesn't even have to be done.
2014-10-03 06:18:05 +02:00
Benjamin Otte
b5a8b7ef3b
widget: Make _gtk_set_simple_clip() take an optional content clip
2014-08-21 00:54:07 +02:00
Jasper St. Pierre
9c37b3de74
gtk: Don't use GObjectClass.constructor
...
Use the newer constructed instead, which has a fast path in GObject.
2014-06-26 19:06:43 -04:00
Matthias Clasen
f0f9c2aa37
Revert "gtkbin: replace internal api"
...
This reverts commit 0f4751c08e
.
This causes warnings from the notebook and combobox code.
2014-06-16 17:31:56 -04:00
Stefan Sauer
0f4751c08e
gtkbin: replace internal api
2014-06-14 08:10:46 +02:00
Matthias Clasen
ec9cf6d7c3
GtkComboBox: Add private api to get the popup
...
This will be used to make the popup appear in the inspector.
2014-06-10 08:54:12 -04:00
Matthias Clasen
1720eb4713
GtkComboBox: Notify for has-frame and editing-canceled
2014-06-09 13:30:55 -04:00
Matthias Clasen
a27ba44331
GtkComboBox: Use G_PARAM_EXPLICIT_NOTIFY
2014-06-09 13:30:53 -04:00
Carlos Garnacho
246e6cd0b9
combobox: Fix reentrancy in gtk_combo_box_popdown()
...
If called when already popped down, warnings would be issued due
to priv->grab_pointer being unexpectedly NULL, this would happen
in regular operation when selecting items in appears-as-list mode.
So both add a NULL check for priv->grab_pointer, and bail out early
if the popup window is already hidden.
2014-06-05 21:16:05 +02:00
Evan Nemerson
54ec42f035
gtk: port many nullability annotation fixes from Vala bindings
...
https://bugzilla.gnome.org/show_bug.cgi?id=730745
2014-05-30 13:24:20 -07:00
Benjamin Otte
1cbace5f68
combobox: Implement clip
2014-05-24 16:21:02 +02:00
Carlos Garnacho
46b4e5d388
combobox: remove superfluous GTK+ grabs
2014-05-23 19:54:24 +02:00
Matthias Clasen
9a127d364f
Drop GtkArrow use in GtkComboBox
...
This is in preparation for GtkArrow getting deprecated.
https://bugzilla.gnome.org/show_bug.cgi?id=729564
2014-05-13 23:50:12 -04:00
Benjamin Otte
a89c598617
combobox: Add workaround so evolution doesn't crash
...
Removing the NULL checks in 7f60cab47d
caused evolution to crash. It chains up with NULL and that used to work.
This patch should be reverted for GTK 4.0.
https://bugzilla.gnome.org/show_bug.cgi?id=729496
2014-05-05 15:53:03 +02:00
Cosimo Cecchi
7f60cab47d
combobox: fix a segfault
...
Don't dereference a NULL pointer.
2014-05-01 19:44:12 +02:00
Benjamin Otte
7455ab72f8
combobox: Remove unneeded checks
...
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
2014-05-01 14:51:27 +02:00
Bastien Nocera
f71f7215ab
all: Name more idles and timeouts
...
Following up from 438cd857c4
,
name more timeouts and idles.
The original grep was missing checking for gdk_threads_add_*()
functions (at least for some of the files).
https://bugzilla.gnome.org/show_bug.cgi?id=726870
2014-03-26 20:09:30 -04:00
William Jon McCann
469d333aa2
docs: use Returns: consistently
...
Instead of Return value:
2014-02-19 18:56:05 -05:00
Matthias Clasen
7f6a964c47
Docs: Remove all entities and turn off sgml mode
...
With all element markup gone, it is time to turn off
sgml mode, and get rid of entities as well.
2014-02-09 17:58:07 -05:00
William Jon McCann
326da2da58
docs: don't use <anchor>
2014-02-07 15:40:52 -05:00
William Jon McCann
13998c55e7
docs: use proper quotations instead of '*'
2014-02-07 14:22:39 -05:00
William Jon McCann
e34bd4137d
docs: use apostrophes in *n't
2014-02-07 13:32:47 -05:00
William Jon McCann
7a208fbbf3
docs: use proper apostrophe
...
https://wiki.gnome.org/Design/OS/Typography
2014-02-07 13:06:10 -05:00
William Jon McCann
0ce016650b
docs: Use markup for links
2014-02-07 09:42:12 -05:00
William Jon McCann
a22358c0c0
docs: use ` instead of <literal>
2014-02-04 18:24:29 -05:00
William Jon McCann
4c8bd8e7cf
docs: Identify examples that are C code
...
https://bugzilla.gnome.org/show_bug.cgi?id=723119
2014-01-29 12:45:49 -05:00
Carlos Garnacho
da86918c32
combobox: Set GDK_SCROLL_MASK on the eventbox in appears-as-list mode
...
This is so the scroll wheel works in both modes, and there's no behavioral
change depending on a style property.
https://bugzilla.gnome.org/show_bug.cgi?id=702663
2013-11-20 13:18:37 +01:00
Bastien Nocera
438cd857c4
all: Add names to timeouts
...
Add names to every timeout we setup, so it's easier to track their
usage, and debug possible misbehaviour.
https://bugzilla.gnome.org/show_bug.cgi?id=710651
2013-10-23 13:31:18 +02:00
David King
4415d087c6
combobox: Add missing Since tags for entry constructors
2013-08-22 20:36:17 +01:00
Matthias Clasen
8383f003f3
Avoid deprecation warnings
2013-08-20 00:15:37 -04:00
William Jon McCann
6f7b0cac94
Deprecate tear off menus
2013-07-18 12:16:02 -04:00
Emmanuele Bassi
0899ef7cc9
gtk: Use new macros for defining private data
...
https://bugzilla.gnome.org/show_bug.cgi?id=702996
2013-07-09 09:30:02 +01:00
Aleksander Morgado
24fa277329
combobox: popdown the combobox when on 'grab-broken-event'
...
And also explicitly remove pointer/keyboard grabs from the display.
Whenever the grab is reported lost, we should popdown the combobox, so that the
GDK_WINDOW_TEMP window is hidden and removed from the toplevel, as done with
the menu for example.
Leaving the GDK_WINDOW_TEMP window open when re-activating the application
triggers several issues in the win32 backend, due to restacking windows of the
non-toplevel group into the toplevel group:
https://bugzilla.gnome.org/show_bug.cgi?id=695200
2013-03-12 07:23:17 -04:00
Cosimo Cecchi
894f84c623
Revert "combobox: Don't special-case RTL child positions anymore"
...
This reverts commit cf712c462d
.
https://bugzilla.gnome.org/show_bug.cgi?id=694451
2013-02-23 14:53:23 -05:00
Benjamin Otte
cf712c462d
combobox: Don't special-case RTL child positions anymore
...
If you want to get rounded corners on an hbox, instead of
:first-child {
border-top-left-radius: 5px;
border-bottom-left-radius: 5px;
}
:last-child {
border-top-right-radius: 5px;
border-bottom-right-radius: 5px;
}
you now need to write:
:first-child, :last-child:dir(rtl) {
border-top-left-radius: 5px;
border-bottom-left-radius: 5px;
}
:last-child, :first-child:dir(rtl)
{
border-top-right-radius: 5px;
border-bottom-right-radius: 5px;
}
2012-12-18 18:25:42 +01:00
Benjamin Otte
7747910b9d
gtk: Use context's font
...
Instead of using gtk_style_context_get_font() in
pango_context_get_metrics(), use pango_context_get_font_description().
The context contains the font description we are about to use after all.
2012-12-06 02:57:18 +01:00
Benjamin Otte
33f111a47c
widget: Don't cache widget paths all the time
...
Add an internal API that allows GtkStyleContext to create a widget path
for the widget and with that bypassing gtk_widget_get_path() and that
function caching the path.
2012-04-17 08:59:21 +02:00
Benjamin Otte
ece9d2fd92
gtk: Make widget only invalidate widget positions
...
Instead of resetting them completely
2012-04-17 08:59:10 +02:00
Matthias Clasen
d7cf9d7b84
combobox: Make scrolling work again
...
Select for scroll events, making it possible to use a scroll
wheel to change the combobox.
2012-03-19 07:08:01 -04:00
Benjamin Otte
461803e407
gtk: Get gtkwidgetpath.h includes out of the public headers
...
and include them in the C files instead.
2012-03-19 02:26:16 +01:00
Benjamin Otte
2353d60b8a
types: Move GtkAdustment declaration to gtktypes.h
...
... and make all the headers to not include gtkadjustment.h anymore. Of
course, also include it in the source files instead.
2012-03-03 19:45:03 +01:00
Javier Jardón
9d0febc9a6
Change FSF Address
2012-02-27 17:06:11 +00:00
Cosimo Cecchi
26ff536069
combobox: fix cell area allocation in menu mode for RTL
...
We were missing a padding to subtract from the child widget here.
2012-01-31 20:30:43 -05:00
Cosimo Cecchi
aa16f469bc
combobox: fix dropdown menu alignment for RTL languages
...
We need to add in the left padding, instead of subtracting it in that
case.
2012-01-31 20:30:43 -05:00
Cosimo Cecchi
65e6248542
combobox: use gtk_container_class_handle_border_width()
...
Avoids us fiddling with the border width manually in our size request
and allocation cycles.
2012-01-31 20:30:43 -05:00
Cosimo Cecchi
cf7f0cb27a
combobox: always trim the allocated area by padding and border for child
...
When we're size allocating the children widgets, always trim the
allocation for padding and border of GtkComboBox, as that's all the area
they have available.
2012-01-31 20:30:42 -05:00
Cosimo Cecchi
ec6b36add5
combobox: cleanup allocation of children in list mode
...
Instead of setting the same values for child allocation in different
places, just do it once.
2012-01-31 20:30:42 -05:00
Cosimo Cecchi
a8211b75b2
combobox: cleanup and comment the allocation code somewhat
2012-01-31 20:30:42 -05:00
Cosimo Cecchi
00325e992b
combobox: make sure to respect the GtkComboBox padding in menu mode
...
When the combobox is in menu mode, we still shouldn't discard the
GtkComboBox padding value; it's wrong to allocate it to the button.
2012-01-31 20:30:42 -05:00
Cosimo Cecchi
c598a9501f
combobox: cleanup GTK_COMBO_BOX_SIZE_ALLOCATE_BUTTON
...
It was using the wrong padding values for RTL, and generally, using the
same variables in a distant macro makes this method even more
complicated than it already is...
2012-01-31 20:30:41 -05:00
Cosimo Cecchi
1bbd2c48c5
combobox: simplify size request code by using the button content box
...
Similar to what we did for size_allocate.
2012-01-31 20:30:41 -05:00
Cosimo Cecchi
821365af15
combobox: move the allocation of the button contents box directly
...
If we're in menu mode with no children, instead of tweaking the
allocation of the arrow and the separator separately, tweak the
allocation of the box that contain both.
2012-01-31 20:30:41 -05:00
Cosimo Cecchi
93523e70a0
combobox: allocate the CSS borders to GtkComboBox
...
Consider borders in the allocation/size-request machinery, like every
widget should do.
2012-01-31 20:30:40 -05:00
Cosimo Cecchi
4675ed27fd
combobox: remove handling of focus-padding and focus-line-width
...
GtkComboBox always handles focus through its children, so there's no
need to request and allocate them again.
In fact, Adwaita was forcing these style properties to zero for
GtkComboBox.
2012-01-31 20:30:40 -05:00
Carlos Garcia Campos
7f2b08c04d
gtkcombobox: Use symbolic names for button numbers
2012-01-27 09:47:43 +01:00
Benjamin Otte
9707d964f7
combobox: Don't allow an individual cell to cheat
...
Make sure we only set sensitive when the cell is sensitive and visible.
Also avoid invalid memory accesses if no cells existed.
2011-12-23 00:15:59 +01:00
Rui Matos
721920e9e9
combobox: Stop setting state flags on the style context for drawing
2011-12-19 19:21:15 +00:00
Matthias Clasen
020c1846b7
Use the workarea when placing popups
...
This uses the new workarea API to avoid placing popups underneath
panels, docks, etc.
2011-12-18 14:29:16 -05:00
Matthias Clasen
068e1f0390
Move wholly deprecated files to a subdirectory
...
Also install their headers to a subdirectory.
2011-11-01 23:51:18 -04:00
Michael Natterer
5c4f2ef0c1
gtk: move _gtk_modules_has_mixed_deps() to gtkmodlesprivate.h
...
and remove gtkmainprivate.h completely.
2011-10-23 13:57:07 +02:00
Tristan Van Berkom
2677a7d5b9
GtkComboBox: Add the format-entry-text signal.
...
This provides more control over how the selected item is shown in
the entry.
Bug #631167
2011-10-06 11:14:38 +02:00
Benjamin Otte
11e17601b3
combobox: Remove unused define
2011-09-29 04:24:02 +02:00
Cosimo Cecchi
e97ed4374f
combobox: implement get_path_for_child() for GtkComboBox
...
This way we can adjust borders and rounded corners from the theme when
displaying the widget children flipped for RTL locales.
https://bugzilla.gnome.org/show_bug.cgi?id=658507
2011-09-09 11:46:00 -04:00
Matthias Clasen
6f39855c08
More include cleanups
2011-08-28 01:54:55 -04:00
Cosimo Cecchi
7e22b46c1f
combobox: add a "combobox-entry" style class for comboboxes with entries
...
This way themes can use GtkComboBox.combobox-entry to match that
specific case, and GtkComboBox.combobox-entry .button to match the
button/arrow side of the widget.
2011-08-09 16:08:00 +02:00