Commit Graph

8076 Commits

Author SHA1 Message Date
Michael Natterer
2ba736d775 Bug 538395 – gtk_combo_box_append_text() on non-compliant model
2008-06-20  Michael Natterer  <mitch@imendio.com>

	Bug 538395 – gtk_combo_box_append_text() on non-compliant model
	segfaults

	* gtk/gtkcombobox.c (gtk_combo_box_append_text)
	(gtk_combo_box_insert_text)
	(gtk_combo_box_prepend_text)
	(gtk_combo_box_remove_text)
	(gtk_combo_box_real_get_active_text): apply patch from Christian
	Dywan which adds the needed g_return_if_fail() to prevent the
	crashes.


svn path=/trunk/; revision=20477
2008-06-20 10:00:40 +00:00
Johan Dahlin
9276cf5a06 Remove svn:executable property
svn path=/trunk/; revision=20475
2008-06-19 20:40:06 +00:00
Johan Dahlin
a4617da3bd Remove executable property
svn path=/trunk/; revision=20474
2008-06-19 20:36:01 +00:00
Johan Dahlin
234dc3726f remove an unused variable and cast accel_path to gchar, just like in
2008-06-19  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkmenuitem.c: remove an unused variable and cast
    accel_path to gchar, just like in gtkmenu.c


svn path=/trunk/; revision=20473
2008-06-19 19:09:50 +00:00
Matthias Clasen
e1c47e2ee0 Use GIO for this.
* gtk/gtkrecentmanager.c (get_icon_for_mime_type): Use GIO
        for this.

svn path=/trunk/; revision=20472
2008-06-19 19:04:22 +00:00
Johan Dahlin
2a5a00646d Fix a typo in a comment
2008-06-19  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkprintbackend.c: Fix a typo in a comment


svn path=/trunk/; revision=20471
2008-06-19 17:42:14 +00:00
Johan Dahlin
8aa6c973d8 Cast buf to unsigned char to avoid two compiler warnings.
2008-06-19  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkhsv.c (paint_ring, paint_triangle):
    Cast buf to unsigned char to avoid two compiler
    warnings.


svn path=/trunk/; revision=20470
2008-06-19 14:19:34 +00:00
Johan Dahlin
ce811f7cec Do not ignore the return value of g_slist_remove. gtkstyle.c changes
2008-06-19  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkclist.c:
    * gtk/gtkstyle.c (gtk_style_finalize):
    Do not ignore the return value of g_slist_remove.
    gtkstyle.c changes rubberstamped by Owen.


svn path=/trunk/; revision=20469
2008-06-19 14:08:59 +00:00
Johan Dahlin
9678ce2eb9 gdk_gc_set_dashes expects a list of gint8, not guint8.
2008-06-19  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtktreeview.c (gtk_tree_view_set_grid_lines),
    (gtk_tree_view_set_enable_tree_lines):
    gdk_gc_set_dashes expects a list of gint8, not guint8.


svn path=/trunk/; revision=20468
2008-06-19 14:07:28 +00:00
Johan Dahlin
6ef2f57450 Remove an unused variable and cast to gchar to avoid a compiler warning.
2008-06-19  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkmenu.c (gtk_menu_set_accel_path):
    Remove an unused variable and cast to gchar to avoid a compiler
    warning.


svn path=/trunk/; revision=20467
2008-06-19 13:43:51 +00:00
Christian Persch
c9e85e48f8 Add clipboard convenience helpers for URIs. Bug #537639.
svn path=/trunk/; revision=20465
2008-06-19 12:55:57 +00:00
Christian Persch
a58a173b48 Use gtk_drag_[dest|source]_add_[text|uri]_targets(), and simplify code. Bug #516092.
svn path=/trunk/; revision=20464
2008-06-19 12:52:40 +00:00
Christian Persch
446f41757b Use g_set_error_literal where appropriate. Bug #538640.
svn path=/trunk/; revision=20463
2008-06-19 12:47:48 +00:00
Johan Dahlin
1a30e12586 Use g_object_new instead of gtk_widget_new
2008-06-19  Johan Dahlin  <jdahlin@async.com.br>

    * demos/testpixbuf.c (new_testrgb_window):
    * gtk/gtkctree.c (gtk_ctree_new_with_titles):
    * gtk/gtkitemfactory.c (gtk_item_factory_construct),
    (gtk_item_factory_create_item):
    * gtk/gtkmenu.c (gtk_menu_set_tearoff_state):
    * gtk/gtkprogressbar.c (gtk_progress_bar_new),
    (gtk_progress_bar_new_with_adjustment):
    * gtk/gtkscrolledwindow.c (gtk_scrolled_window_new):
    * gtk/gtktext.c (gtk_text_new):
    * gtk/gtkviewport.c (gtk_viewport_new):
    * tests/simple.c (main):
    * tests/testgtk.c (create_statusbar), (create_get_image),
    (create_saved_position), (create_tooltips), (create_cursors),
    (create_display_screen), (create_progress_bar), (create_idle_test):
    * tests/testmultidisplay.c (make_selection_dialog), (main):
    * tests/testmultiscreen.c (main):
    * tests/testrgb.c (new_testrgb_window):
    Use g_object_new instead of gtk_widget_new


svn path=/trunk/; revision=20462
2008-06-19 12:25:19 +00:00
Johan Dahlin
a14ce91e91 Remove an unused prototype.
2008-06-19  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkcellrendererpixbuf.c: Remove an unused prototype.


svn path=/trunk/; revision=20461
2008-06-19 12:16:44 +00:00
Johan Dahlin
cafd4ffab2 Remove an unused variable.
2008-06-19  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtklabel.c (gtk_label_set_text_with_mnemonic): Remove
    an unused variable.


svn path=/trunk/; revision=20460
2008-06-19 12:15:55 +00:00
Johan Dahlin
94e207777d Use GdkModifierType instedd of guint, to avoid a gcc warning.
2008-06-19  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkactiongroup.c: Use GdkModifierType instedd of guint,
    to avoid a gcc warning.


svn path=/trunk/; revision=20459
2008-06-19 12:15:07 +00:00
Olle Bergkvist
ad54e22fc7 bgo538784 - Don't change the filename entry in CREATE_FOLDER mode
2008-06-18  Olle Bergkvist <olle.bergkvist@yahoo.se>

	http://bugzilla.gnome.org/show_bug.cgi?id=538784 - Don't change
	the filename in the name entry in CREATE_FOLDER mode when changing
	folders, so that you can enter a new subfolder name, double-click on a
	folder to change to it, and close the dialog.

	* gtk/gtkfilechooserdefault.c (update_chooser_entry): Don't change
	the filename in the entry in CREATE_FOLDER mode, either.

Signed-off-by: Federico Mena Quintero <federico@novell.com>

svn path=/trunk/; revision=20457
2008-06-18 22:35:32 +00:00
Olle Bergkvist
666b544ddd bgo419737 - Don't clear filename entry in SAVE/CREATE_FOLDER modes
2008-06-18  Olle Bergkvist <olle.bergkvist@yahoo.se>

	http://bugzilla.gnome.org/show_bug.cgi?id=419737#c59 - The file
	chooser clears the filename entry in SAVE/CREATE_FOLDER modes when
	it shouldn't.

	* gtk/gtkfilechooserdefault.c (shortcuts_activate_iter): Don't
	clear the entry for CREATE_FOLDER either; this needs the same
	behavior as SAVE mode.
	(update_chooser_entry): Only clear the entry in OPEN/SELECT_FOLDER
	modes.

Signed-off-by: Federico Mena Quintero <federico@novell.com>

svn path=/trunk/; revision=20455
2008-06-18 22:23:39 +00:00
Matthias Clasen
d217ec4f90 Use standard icon names.
2008-06-18  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkfilesystem.c (_gtk_file_system_volume_render_icon):
        * gtk/gtkfilechooserbutton.c (change_icon_theme):
        (model_add_bookmarks):
        (model_update_current_folder):
        * gtk/gtkfilechooserdefault.c (shortcuts_insert_file):
        (shortcuts_reload_icons): Use standard icon names.


svn path=/trunk/; revision=20454
2008-06-18 16:22:42 +00:00
Matthias Clasen
ad7fccfd96 Add some more standard icon names
svn path=/trunk/; revision=20453
2008-06-18 16:14:59 +00:00
Michael Natterer
09e8017c91 set the maximum of the "year" property to G_MAXINT >> 8 instead of
2008-06-18  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkcalendar.c: set the maximum of the "year" property to
	G_MAXINT >> 8 instead of G_MAXINT to fix overflows in internal
	calculations which in turn caused writing beyond the boundaries of
	the calendar->day_month[] and day[] arrays which in turn caused a
	SEGV. This limits the lifetime of GTK+ to the year 8,388,608 ;)


svn path=/trunk/; revision=20452
2008-06-18 15:42:27 +00:00
Michael Natterer
d5565f5b63 tests/Makefile.am tests/autotestfilechooser.c tests/buildertest.c
2008-06-18  Michael Natterer  <mitch@imendio.com>

	* tests/Makefile.am
	* tests/autotestfilechooser.c
	* tests/buildertest.c
	* tests/defaultvaluetest.c
	* tests/floatingtest.c
	* tests/objecttests.c
	* tests/pixbuf-init.c
	* tests/textbuffertest.c: remove unit tests here...

	* gtk/tests/Makefile.am
	* gtk/tests/builder.c
	* gtk/tests/defaultvalue.c
	* gtk/tests/filechooser.c
	* gtk/tests/floating.c
	* gtk/tests/object.c
	* gtk/tests/pixbuf-init.c
	* gtk/tests/textbuffer.c: ...and add them here.


svn path=/trunk/; revision=20450
2008-06-18 13:29:02 +00:00
Michael Natterer
67c6c28fe0 deprecate GdkDestroyNotify.
2008-06-18  Michael Natterer  <mitch@imendio.com>

	* gdk/gdk.h: deprecate GdkDestroyNotify.

	* gdk/gdkevents.c
	* gdk/gdktypes.h
	* gdk/x11/gdkevents-x11.c
	* gtk/gtkmain.c: s/GdkDestroyNotify/GDestroyNotify/g.


svn path=/trunk/; revision=20449
2008-06-18 09:39:24 +00:00
Michael Natterer
fe8a946e87 deprecate GtkDestroyNotify.
2008-06-18  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktypeutils.h: deprecate GtkDestroyNotify.

	* gtk/gtkactiongroup.[ch]
	* gtk/gtkcombobox.[ch]
	* gtk/gtkcontainer.[ch]
	* gtk/gtkliststore.[ch]
	* gtk/gtkmain.[ch]
	* gtk/gtkmenu.c
	* gtk/gtkstock.[ch]
	* gtk/gtktreedatalist.[ch]
	* gtk/gtktreemodelfilter.[ch]
	* gtk/gtktreemodelsort.[ch]
	* gtk/gtktreeprivate.h
	* gtk/gtktreeselection.[ch]
	* gtk/gtktreesortable.[ch]
	* gtk/gtktreestore.[ch]
	* gtk/gtktreeview.[ch]
	* gtk/gtktreeviewcolumn.[ch]: s/GtkDestroyNotify/GDestroyNotify/g.


svn path=/trunk/; revision=20448
2008-06-18 09:12:32 +00:00
Michael Natterer
9d21042702 deprecate GtkType, GtkSignalFunc and GTK_SIGNAL_FUNC().
2008-06-18  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktypeutils.h: deprecate GtkType, GtkSignalFunc and
	GTK_SIGNAL_FUNC().

	(struct GtkArg): s/GtkType/GType/ and s/GtkSignalFunc/GCallback/


svn path=/trunk/; revision=20446
2008-06-18 08:26:53 +00:00
Michael Natterer
73800758fd deprecate gtk_type_class().
2008-06-18  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktypeutils.[ch]: deprecate gtk_type_class().

	* gtk/gtk.symbols: changed accordingly.

	* gtk/gtksettings.c (gtk_settings_install_property)
	(gtk_settings_install_property_parser): get rid of using
	gtk_type_class() by keeping a static reference to GtkSettingsClass
	around in both functions and passing that pointer on to
	settings_install_property_parser().

	* tests/testgtk.c: use g_type_class_ref()/unref() instead of
	gtk_type_class().

	* gtk/gtkobject.c: #undef GTK_DISABLE_DEPRECATED around including
	gtktypeutils.h.


svn path=/trunk/; revision=20444
2008-06-18 07:00:46 +00:00
Johan Dahlin
78c88e77d6 Add deprecated version and change the deprecation markup used by ref/unref
2008-06-17  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkstyle.c: Add deprecated version
    and change the deprecation markup used by ref/unref 


svn path=/trunk/; revision=20443
2008-06-18 01:42:13 +00:00
Johan Dahlin
7c45f6f5fc Add deprecated versions and fixup markup.
2008-06-17  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkwidget.c: 
    Add deprecated versions and fixup markup.


svn path=/trunk/; revision=20442
2008-06-18 01:31:22 +00:00
Johan Dahlin
12934f6841 Don't markup deprecated in italics.
2008-06-17  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkaboutdialog.c:
    * gtk/gtkbutton.c (gtk_button_class_init):
    Don't markup deprecated in italics.


svn path=/trunk/; revision=20441
2008-06-18 01:19:53 +00:00
Carlos Garnacho
6bb24bf6c8 Remove GtkFileSystemError, use GtkFileChooserError instead. (#538378,
2008-06-18  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtkfilesystem.[ch]: Remove GtkFileSystemError, use
        GtkFileChooserError instead. (#538378, patch by Matthias Clasen)

svn path=/trunk/; revision=20440
2008-06-17 23:33:48 +00:00
Michael Natterer
07bf0bdb94 remove bogus extern declaration of non-existing function
2008-06-17  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkobject.c: remove bogus extern declaration of non-existing
	function gtk_object_init_type().


svn path=/trunk/; revision=20438
2008-06-17 21:34:15 +00:00
Michael Natterer
554e1eec70 s/GtkType/GType/
2008-06-17  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkbindings.c (gtk_binding_entry_add_signal):
	* gtk/gtktoolbutton.c (gtk_tool_button_get_type): 
	* examples/gtkdial/gtkdial.h (gtk_dial_get_type): 
	s/GtkType/GType/


svn path=/trunk/; revision=20436
2008-06-17 20:43:07 +00:00
Tor Lillqvist
293ed565ee Need to do the GTK_DISABLE_DEPRECATED #undef/#define dance here, too,
2008-06-17  Tor Lillqvist  <tml@novell.com>

	* gtk/gtknotebook.c: Need to do the GTK_DISABLE_DEPRECATED
	#undef/#define dance here, too, because
	gtk_notebook_set_group_id() is deprecated but used here before it
	is defined, and gcc complains about conflicting type from the
	implicit int declaration when it sees the actual void definition.


svn path=/trunk/; revision=20435
2008-06-17 19:29:22 +00:00
Michael Natterer
bd69ea0a7c build with GTK_DISABLE_DEPRECATED.
2008-06-17  Michael Natterer  <mitch@imendio.com>

	* gtk/Makefile.am: build with GTK_DISABLE_DEPRECATED.

	* gtk/gtkclist.c
	* gtk/gtkcombo.c
	* gtk/gtkctree.c
	* gtk/gtklist.c
	* gtk/gtklistitem.c
	* gtk/gtkoldeditable.c
	* gtk/gtkpixmap.c
	* gtk/gtktext.c
	* gtk/gtktipsquery.c
	* gtk/gtktree.c
	* gtk/gtktreeitem.c: whenever we #undef GTK_DISABLE_DEPRECATED and
	actually use deprecated symbols (not just types or macros),
	#define it again before #include "gtkalias.h" so the symbols match
	and the beast links.


svn path=/trunk/; revision=20433
2008-06-17 16:03:46 +00:00
Paolo Borelli
96d61db436 more tests for GtkRecentManager.
2008-06-17  Paolo Borelli  <pborelli@katamail.com>

	* gtk/tests/recentmanager.c: more tests for GtkRecentManager.

svn path=/trunk/; revision=20431
2008-06-17 15:46:40 +00:00
Michael Natterer
e96a880621 really move the GtkType typedef to an undeprecated section.
2008-06-17  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktypeutils.h: really move the GtkType typedef to an
	undeprecated section.


svn path=/trunk/; revision=20429
2008-06-17 14:34:59 +00:00
Michael Natterer
8676c45d5c deprecate GTK_CHECK_CAST, GTK_CHECK_CLASS_CAST, GTK_CHECK_GET_CLASS,
2008-06-17  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktypeutils.h: deprecate GTK_CHECK_CAST,	GTK_CHECK_CLASS_CAST,
	GTK_CHECK_GET_CLASS, GTK_CHECK_TYPE and GTK_CHECK_CLASS_TYPE.
	Move the GtkType typedef to an undeprecated section.


svn path=/trunk/; revision=20428
2008-06-17 14:17:29 +00:00
Michael Natterer
ea80bf6097 use G_TYPE macros for type checking instead of GTK_CHECK ones because it's
2008-06-17  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkprogress.h: use G_TYPE macros for type checking instead
	of GTK_CHECK ones because it's the parent class of an undeprecated
	class and the GTK_CHECK stuff will soon be deprecated.


svn path=/trunk/; revision=20427
2008-06-17 14:14:06 +00:00
Michael Natterer
d6ebf18108 gtk/gtkfilesel.c gtk/gtkinputdialog.c gtk/gtkmenutoolbutton.c
2008-06-17  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkfilesel.c
	* gtk/gtkinputdialog.c
	* gtk/gtkmenutoolbutton.c
	* gtk/gtkoptionmenu.c
	* gtk/gtktoolitem.c
	* gtk/gtktooltips.c: add or move around
	#undef GTK_DISABLE_DEPRECATED so it's possible to build without
	deprecated stuff again (with the minor glitch that it doesn't
	link ;) but at least it's a tool to keep the code clean).


svn path=/trunk/; revision=20426
2008-06-17 14:11:26 +00:00
Emmanuele Bassi
21284ce95f Fix dumb typo in the previous commit.
2008-06-17  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentmanager.c:
	(gtk_recent_manager_remove_item): Fix dumb typo in the previous
	commit.

svn path=/trunk/; revision=20425
2008-06-17 13:46:48 +00:00
Emmanuele Bassi
8bab0d7d03 Increase the consistency of the errors returned by GtkRecentManager.
2008-06-17  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentmanager.c:
	(gtk_recent_manager_remove_item),
	(gtk_recent_manager_move_item): Increase the consistency of the
	errors returned by GtkRecentManager. (Paolo Borelli)

svn path=/trunk/; revision=20424
2008-06-17 13:42:53 +00:00
Paolo Borelli
72a9cc895a add some unit tests for GtkRecentManager.
2008-06-17  Paolo Borelli  <pborelli@katamail.com>

	* gtk/tests/recentmanager.c: add some unit tests for GtkRecentManager.


svn path=/trunk/; revision=20423
2008-06-17 13:37:59 +00:00
Emmanuele Bassi
88c469420d Consistently use the same error when removing a URI from an empty
2008-06-17  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentmanager.c:
	(gtk_recent_manager_remove_item): Consistently use the same
	error when removing a URI from an empty GtkRecentManager.

svn path=/trunk/; revision=20422
2008-06-17 13:15:45 +00:00
Michael Natterer
40b6173aa3 remove static integer variables which hold the number of members in
2008-06-17  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkfilechooserdefault.c: remove static integer variables
	which hold the number of members in GtkTargetEntry arrays and use
	G_N_ELEMENTS() directly instead.


svn path=/trunk/; revision=20421
2008-06-17 12:54:16 +00:00
Michael Natterer
e8b84723ca move some deprecated symbols into #ifndef GTK_DISABLE_DEPRECATED.
2008-06-17  Michael Natterer  <mitch@imendio.com>

	* gtk/gtk.symbols: move some deprecated symbols into
	#ifndef GTK_DISABLE_DEPRECATED.


svn path=/trunk/; revision=20420
2008-06-17 12:47:57 +00:00
Emmanuele Bassi
ea51ac13f8 Remove the GtkRecentManager screen dance, as it has been deprecated since
2008-06-17  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkfilechooserdefault.c:
	(gtk_file_chooser_default_init),
	(gtk_file_chooser_default_constructor),
	(gtk_file_chooser_default_screen_changed),
	(recent_start_loading): Remove the GtkRecentManager screen
	dance, as it has been deprecated since 2.12. Now we get the
	GtkRecentManager singleton whewn we create the FileChooserDefault
	instance. (Michael Natterer)

svn path=/trunk/; revision=20419
2008-06-17 12:46:12 +00:00
Michael Natterer
4d4e558efd cast menu's toplevel to GtkWindow when passing to
2008-06-17  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkoptionmenu.c (gtk_option_menu_position): cast menu's
	toplevel to GtkWindow when passing to gtk_window_set_type_hint().


svn path=/trunk/; revision=20417
2008-06-17 11:27:37 +00:00
Michael Natterer
86f27564bd #undef GTK_DISABLE_DEPRECATED, clean up includes a bit.
2008-06-17  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktestutils.c: #undef GTK_DISABLE_DEPRECATED, clean up
	includes a bit.

	* gtk/gtkuimanager.c: #include "gtkwindow.h", it was only pulled
	in via deprecated headers.


svn path=/trunk/; revision=20416
2008-06-17 09:58:09 +00:00
Michael Natterer
9dd2aa7edc use g_object_ref() and unref() instead of the deprecated gtk_widget_ref()
2008-06-17  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkplug.c (_gtk_plug_send_delete_event): use g_object_ref()
	and unref() instead of the deprecated gtk_widget_ref() and unref().


svn path=/trunk/; revision=20411
2008-06-16 22:47:50 +00:00