Matthias Clasen
4a44f3f6e1
Formatting fixes
2011-03-12 21:22:27 -05:00
Cosimo Cecchi
677f268e8d
paned: don't set the "pane-separator" style class to all the container
...
Otherwise children inherit color properties specified for the pane
separator itself.
https://bugzilla.gnome.org/show_bug.cgi?id=644276
2011-03-12 20:36:40 -05:00
Carlos Garcia Campos
21558ae67f
themingengine: Use render_background_internal() to render handle background
...
Instead of using always the background color. This fixes handles that
have a background image like gnome-panel applets in a transparent
panel.
https://bugzilla.gnome.org/show_bug.cgi?id=644570
2011-03-12 20:32:42 -05:00
Matthias Clasen
aa1fdb4123
GtkAboutDialog: keep toggle button state in sync
...
When hiding the dialog, we hide the credits/license parts, so
we need to update the toggle buttons controlling them.
https://bugzilla.gnome.org/show_bug.cgi?id=644355
2011-03-12 13:43:28 -05:00
Benjamin Otte
015f227776
gtk: Queue a resize after state changes
...
Lots of style properties - border-width in this case - can change the
size of widgets, so we need to queue a resize instead of just redrawing.
2011-03-11 19:51:25 +01:00
Kristian Rietveld
a55b59fef3
Include gdkquartz.h so GDK_IS_QUARTZ_SCREEN is actually defined
2011-03-10 21:20:37 +01:00
Cosimo Cecchi
5215f72bd7
notebook: add an 'initial-gap' style property
...
It adds a gap before the first tab in the notebook.
https://bugzilla.gnome.org/show_bug.cgi?id=643841
2011-03-09 14:15:43 -05:00
Tristan Van Berkom
f632956166
Fixed GtkTreeModel::row-deleted documentation
...
This documentation was in direct conflict with the documentation
of gtk_tree_model_row_deleted() docs, the function docs are TRUE,
the signal docs were FALSE, fixed.
2011-03-09 15:06:45 +09:00
Cosimo Cecchi
e772082a2a
stylecontext: add a raised style class
...
This is useful for raised elements, for example raised buttons on
primary toolbars.
https://bugzilla.gnome.org/show_bug.cgi?id=644248
2011-03-08 20:05:30 -05:00
Carlos Garnacho
191428f596
gtksettings: plug a leak
...
Make the GValue take the created GString.
2011-03-07 23:06:55 +01:00
Carlos Garnacho
fe12c46531
cssprovider: Reset the scope before skipping to the next rule after an error happens.
...
This is so the selector token gets parsed with the correct GScanner scope/config
on all situations.
2011-03-07 23:06:54 +01:00
Carlos Garnacho
aa6eee73e5
cssprovider: plug two more leak fixes
2011-03-07 23:06:54 +01:00
Carlos Garnacho
794593a4f8
cssprovider: return immediately if there's remaining data behind a parsed value
...
parse_value() could fill in a GError, but yet (incorrectly) return G_TOKEN_NONE,
having the GError leaked as a result.
https://bugzilla.gnome.org/show_bug.cgi?id=642604 , Reported by Felix Riemann.
2011-03-07 23:06:54 +01:00
John Ralls
f7f9e16939
Finish making the GtkSettings object identical on all backends so that it doesn't assert on non-X11 backends
2011-03-07 12:28:50 -08:00
Cosimo Cecchi
96d6c2d108
treeview: propagate the selected state from the row
...
An expander in a row can't be selected on its own otherwise. This way
themes can override the expander colors when the row is selected.
https://bugzilla.gnome.org/show_bug.cgi?id=644089
2011-03-07 08:12:48 -05:00
Carlos Garnacho
b93a2ebeed
entry: Do not clobber state when rendering the default icons.
...
Use lower level methods that just require changing the state in the
GtkStyleContext instead. Fixes a problem where the insensitive state
was being set to the entry becasuse a parent was insensitive, spotted
by Alex Larsson.
2011-03-07 12:48:31 +01:00
Cosimo Cecchi
a3b3c91001
notebook: flip the render order
...
The render order for tabs is now
- left to right until the active tab
- right to left until the active tab
- active tab
This allows themes that use non-straight lines for the tab curvature to
draw them not worrying about flipping one side after the active tab.
2011-03-07 00:49:14 -05:00
Cosimo Cecchi
a54ca77fb7
notebook: fixup the last commit
...
Let the tab overlap eat the padding, otherwise having tab-overlap >
tab-curvature without cutting the label is impossible.
This way we give the label widget all the allocation possible before
giving up and cutting it if the values for tab-overlap are too extreme
for the given padding.
2011-03-06 22:08:26 -05:00
Cosimo Cecchi
da814ae767
notebook: make sure the label widget allocation not exceeds the overlap
2011-03-06 18:45:20 -05:00
Cosimo Cecchi
27a0cef60c
notebook: make sure the allocation keeps track of the tab curvature
...
This was a genuine typo, because "padding" was calculated but unused in
this branch of the code.
2011-03-06 14:48:09 -05:00
Ignacio Casal Quinteiro
0a03e81224
Fix conversion from GdkColor to GdkRGBA
2011-03-06 11:17:06 +01:00
Matthias Clasen
39d4207ab7
Use existing mime type for GTK_FILE stock icon
...
document-x-generic is not actually a mimetype. Using text-x-generic
instead lets us work out-of-the-box in a11y themes.
2011-03-06 00:31:20 -05:00
Matthias Clasen
e2ba86289f
Only count visible children during size request
...
This was causing spacing between image and label to be requested
in buttons, even though the image is invisible.
2011-03-05 23:27:26 -05:00
Benjamin Otte
8b17b16d63
theme: Fix spinner for inactive state.
...
Previously, the inactive state caused the spinner's solid line to be
drawn to the right. Now it's drawn to the top instead, which makes the
inactive state look more natural.
2011-03-05 15:03:56 +01:00
Benjamin Otte
9b8fbe5b72
theme: Make spinner animation turn clockwise
2011-03-05 15:03:56 +01:00
Benjamin Otte
2482847ecf
theme: Make spinner steps count forward, not backward
...
This makes the spinner roate the right way again.
2011-03-05 15:03:56 +01:00
Benjamin Otte
de3616d52c
theme: Make spinner drawing start with the solid line
...
Previously, for i == 0, we were drawing the translucent line first.
However, people reading the code would always assume the solid line is
indicated by the current step. So make the code do that.
Note that the spinner now rotates in the wrong direction. This will be
fixed in a future commit.
2011-03-05 15:03:56 +01:00
Benjamin Otte
41b5a6a900
theme: Compute scale values once
...
Use a local variable to store the xscale and yscale, so that it's only
computed once.
Makes it easier to do the changes I'm about to do.
2011-03-05 15:03:56 +01:00
Benjamin Otte
8c8dda6a6b
theme: Do general cairo setup in one place
...
Also remove wrong comment.
2011-03-05 15:03:56 +01:00
Benjamin Otte
639bf2a2a5
theme: Remove unnecessary save/restore in spinner code
2011-03-05 15:03:56 +01:00
Benjamin Otte
3e524ac28e
theme: Simplify spinner drawing code a bit.
2011-03-05 15:03:56 +01:00
Murray Cumming
5b347db1af
gtk_init*(): Document that argc/argv can be 0,NULL.
...
* gtk/gtkmain.c: (gtk_init): Mention that argc and argv can be 0,
using the new text from the g_applicatoin_run() documentation.
There was already introspection annotation about that.
(gtk_init_check, gtk_init_with_args): Use the same text here.
See bug #643649 comment 2.
2011-03-05 14:57:32 +01:00
Xan Lopez
eeedcf3612
spinbutton: remove unused variable
2011-03-04 21:43:08 +01:00
Cosimo Cecchi
6a423a99ad
spinbutton: rework GtkSpinButton drawing handler
...
Make the arrows bigger, and position them according to the mockups.
2011-03-04 11:13:14 -05:00
Cosimo Cecchi
cae7b93729
Revert "spinbutton: center-align by default"
...
This reverts commit 64ef11985b
.
2011-03-04 11:13:13 -05:00
Matthias Clasen
2ccc6c0d60
GtkNotebooks: fix regressions from tab-pack removal
2011-03-03 18:30:03 -05:00
Matthias Clasen
a71e801943
GtkNotebook: Don't let tab allocation go negative
2011-03-03 18:30:03 -05:00
Cosimo Cecchi
8da124aa1f
Cleanup unused variables
2011-03-03 17:48:26 -05:00
Cosimo Cecchi
e9182123a8
stylecontext: add a primary toolbar style class
2011-03-03 17:48:26 -05:00
Cosimo Cecchi
d5c4a0f503
all: add a "separator" style class
2011-03-03 17:48:26 -05:00
Cosimo Cecchi
fe3f9ca9cd
menuitem: set the menubar style class for menu items on a bar
...
So that themes can distinguish them from the other menu items.
2011-03-03 17:48:26 -05:00
Cosimo Cecchi
4a99e75ce7
window: don't confuse priv->type_hint with priv->gdk_type_hint
...
This broke, among the others, menu rendering.
2011-03-03 17:48:25 -05:00
Cosimo Cecchi
ee43f55b5f
menuitem: mark with the GTK_STYLE_CLASS_MENUITEM style class
2011-03-03 17:48:25 -05:00
Cosimo Cecchi
64aac9624c
Use 16 as default size for checkbutton indicator
...
So that 16x16 icons can be used from themes such as Adwaita in their
natural size.
2011-03-03 17:48:25 -05:00
Cosimo Cecchi
ea7661cb3f
switch: remove slider padding from available allocation when drawing
...
This also simplifies the code a bit, and makes previous workarounds
useless.
2011-03-03 17:48:25 -05:00
Cosimo Cecchi
6abbd68674
switch: fetch the padding values from the slider
...
It's the slider which acts as a child inside the container through, so
we should fetch the slider padding when computing height/width.
2011-03-03 17:48:25 -05:00
Cosimo Cecchi
c310c35a7a
switch: propagate the active state to the slider
2011-03-03 17:48:25 -05:00
Cosimo Cecchi
0ff4fdb233
combobox: add an arrow-scaling property to GtkComboBox
2011-03-03 17:48:25 -05:00
Cosimo Cecchi
64ef11985b
spinbutton: center-align by default
2011-03-03 17:48:25 -05:00
Cosimo Cecchi
fa4fb6724c
arrow: x and y coordinates of the arrow rendering should be double
...
To prevent off-by-one rounding errors when drawing them later.
2011-03-03 17:48:25 -05:00
Cosimo Cecchi
230bd4b461
range: x and y coordinates of the arrow rendering should be double
...
To prevent off-by-one rounding errors when drawing them later.
2011-03-03 17:48:25 -05:00
Cosimo Cecchi
11f07f9bdc
range: don't set junction sides on scrollbar steppers
2011-03-03 17:48:25 -05:00
Matthias Clasen
77e46de0e1
GtkScale: Add style classes for marks
...
This enables better styling of the slider in the presence of
marks. Based on a patch by Bastien Nocera,
https://bugzilla.gnome.org/show_bug.cgi?id=643685
2011-03-03 16:49:49 -05:00
Matthias Clasen
2a9d130ed2
GtkScale: Normalize mark positions
...
This is in preparation for making scale marks styling better.
As a side-effect, TOP and LEFT position are treated the same now,
as well as BOTTOM and RIGHT.
Based on a patch by Bastien Nocera,
https://bugzilla.gnome.org/show_bug.cgi?id=643685
2011-03-03 16:49:49 -05:00
John (J5) Palmieri
a47a7abe23
[gi] don't skip gtk_menu_attach_to_widget, correctly annotate the async callback
2011-03-03 16:06:28 -05:00
John (J5) Palmieri
cdf69b4bed
[gi] add missing annotations for signals that emit Gdk.Events
2011-03-03 16:05:28 -05:00
Matthias Clasen
a3883683e5
Add GtkBuilder custom attributes for style classes
...
GtkWidget now parses custom attributes like
<style>
<class name="dark-label"/>
<class name="big-heading"/>
</style>
to add style classes to widgets.
https://bugzilla.gnome.org/show_bug.cgi?id=643347
2011-03-02 20:12:23 -05:00
Benjamin Otte
7693804fcf
window: Add check for X11 window when calling x11 function
2011-03-02 17:29:21 +01:00
Benjamin Otte
172f894120
settings: Always use the same default values
...
Set the Mac key theme when creating a Quartz settings object instead of
having it the default when quartz is enabled.
This keeps compatibility with the GTK2 behavior that the Mac key theme
is not used for the X11 backend, which could now happen for a
multi-backend build.
2011-03-02 17:18:49 +01:00
Benjamin Otte
e69badbcd1
settings: Keep the GtkSettings object identical no matter the backend
...
Previously we were enabling some settings properties only if the X11
backend was enabled. This worked fine with GTK2 where only one backend
was enabled at a time, but now when multiple backends can be enabled,
this does not make sense.
2011-03-02 17:02:51 +01:00
Benjamin Otte
399dc74d74
settings: Avoid a segfault when loading keyfile
...
When the keyfile is loaded, no screen exists yet, so we need to vheck
for that.
2011-03-02 16:21:44 +01:00
Tristan Van Berkom
c844a24ae6
Allow GtkAppChooser classes to be instantiated with content-type=NULL.
...
Mostly for corner cases such as Glade that treats objects generically
and needs to have an object that doesnt crash out of g_object_new().
2011-03-01 19:41:15 +09:00
Matthias Clasen
63c7701ca3
Don't use GDK_NONE when GDK_SELECTION_CLIPBOARD is meant
2011-02-28 19:25:35 -05:00
Patricia Santana Cruz
49c48546c8
Removed incorrect description's sentence.
...
Description was wrong when it explained: "The two areas are separated
by a GtkHSeparator.". These separators are not used any more.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=643496
2011-02-28 17:36:05 +00:00
Matthias Clasen
9707d8a3e6
Don't assert on zero width/height in render functions
...
We can just silently ignore those rendering calls.
https://bugzilla.gnome.org/show_bug.cgi?id=643041
2011-02-28 07:52:59 -05:00
Matthias Clasen
2e192d01f1
List all available icons in Makefile.am
...
This mismatch was causing e.g. gtk-caps-lock-warning.png to show
up as missing image in entries.
2011-02-26 00:23:47 -05:00
Matthias Clasen
46cc85fd7e
GtkSwitch: use regular activation
...
GtkSwitch was listening for Space/Enter keyreleases itself, instead
of providing an 'activate' action signal, like e.g GtkButton. As a
side-effect, this fixes
https://bugzilla.gnome.org/show_bug.cgi?id=643321
2011-02-25 15:47:03 -05:00
Matthias Clasen
6b91392afd
GtkTrayIcon: chain up in dispose
...
Pointed out in bug 643131
2011-02-25 14:48:55 -05:00
Tristan Van Berkom
f85e80aada
More patchwork for icon view subclasses that access the icon view api prematurely.
...
In this patch we adress rows_reordered() and row_deleted() callbacks
(since some icon view subclasses manipulate the connected treemodel
from _init()).
2011-02-25 16:00:20 +09:00
Tristan Van Berkom
2408b1c59e
More patchwork to ensure GtkIconView subclasses can use the icon view api
...
from the subclass's instance structure initializer
2011-02-25 15:07:55 +09:00
Federico Mena Quintero
6c4196e9e4
[GtkFileChooser] Fix initial selection when hidden files are shown
...
We were breaking prematurely out of the loop that goes through
each file that is pending selection; not only does that loop
disable filtering and show hidden files if needed, but it also
selects the files themselves. So we need to walk the whole
list of files.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
https://bugzilla.gnome.org/show_bug.cgi?id=643170
2011-02-24 14:56:57 -06:00
Tristan Van Berkom
4164a49b84
Added documentation to "cell-area" construct-only properties.
...
Indicate what kind of area will be used by default if none is
provided by the user.
2011-02-24 16:05:41 +09:00
Tristan Van Berkom
db4fa1a941
Removed unused EXPOSE_EVENT enumeration from the GtkWidget signals.
2011-02-23 22:07:27 +09:00
Tristan Van Berkom
30f03a1c65
Remove mention of GtkWidget::expose-event from docs in gtkwidget.c
2011-02-23 21:58:48 +09:00
Tristan Van Berkom
4d76644f5c
Add more defensive code to avoid accessing GtkIconView's cell area before it exists.
...
Adding these cases here to cater to icon view subclasses that want to
access icon view APIs from the instance structure initializer instead
of properly waiting for the super class to initialize and adding renderers
from the ->constructor() vfunc.
2011-02-23 20:50:50 +09:00
Murray Cumming
8d54fa7102
More tiny documentation typo fixes.
2011-02-23 11:09:20 +01:00
Murray Cumming
f91c04e284
Minor documentation improvements
...
Mostly correcting it's to its and changing some , to .
2011-02-23 10:26:21 +01:00
Matthias Clasen
700276eae4
Don't export extra symbols for accessibility
2011-02-21 17:34:51 -05:00
Benjamin Otte
ff5d4e13de
textview: Remove x/y arguments from render_para() func
...
We were only passing 0 anyway and it's easy to translate the cairo
context in use instead of passing x/y coordinates.
2011-02-20 23:43:42 +01:00
Benjamin Otte
c647085e76
textview: Translate the cairo context instead of keeping y value
...
This avoids overflow when transforming a large value to a pango unit.
To reproduce the problem:
seq 200000 > test.txt && tets/print-editor test.txt
Then scroll to around line 140.000 to see it (depends on font size of
course).
2011-02-20 23:43:42 +01:00
Matthias Clasen
14fcfd3f7a
Fix spelling
...
It is 'accessible', not 'accesible'.
2011-02-20 16:46:27 -05:00
Matthias Clasen
48b0a55775
React to is-focus change, not ignore it
...
A very old bug, noticed in
https://bugzilla.gnome.org/show_bug.cgi?id=642791
2011-02-20 16:45:41 -05:00
Matthias Clasen
2180267f5d
Plug a memleak in the tracker search engine
...
Patch by Vincent Untz,
https://bugzilla.gnome.org/show_bug.cgi?id=642771
2011-02-19 13:31:50 -05:00
Matthias Clasen
84b259d076
Make gtk_combo_box_text_get_active_text() behave as documented
...
If there is an entry, it is supposed to return the contents
of the entry. Pointed out by Allin Cottrell,
https://bugzilla.gnome.org/show_bug.cgi?id=642681
2011-02-19 13:27:51 -05:00
Matthias Clasen
6d3b8c2c6b
GtkSwitch: Add an AtkAction implementation
2011-02-17 23:06:33 -05:00
Matthias Clasen
163f0daf6a
GtkSwitch: Use ATK_DEFINE_TYPE properly
2011-02-17 21:55:54 -05:00
Matthias Clasen
e7d4d77093
Fix a memory leak with file chooser previews
2011-02-17 18:34:28 -05:00
Matthias Clasen
c9b152ec71
Remove a leaking get_name implementation
...
This was leaking a lot of memory; just rely on atk_object_get_name.
2011-02-17 15:57:39 -05:00
Carlos Garnacho
3100b76ba9
Fix parsing of color names containing numbers
...
They were being defined correctly through @define-color
in CSS, but parsing failed at the moment of creating
GtkSymbolicColors depending on these.
2011-02-17 20:10:49 +01:00
Matthias Clasen
bdacdfb78b
Check if the accessible is actually an AtkAction
2011-02-17 13:29:59 -05:00
Matthias Clasen
13d717e2ce
Fix includes in gtkassistant.c
...
Also fix a bad case in gtk_assistant_accessible_get_n_children.
2011-02-17 12:35:07 -05:00
Matthias Clasen
7bddfb5790
GtkAssistant: Use _gtk_accessible_set_factory_type
2011-02-17 12:25:23 -05:00
Matthias Clasen
1692829594
GtkGrid: Avoid problems with uninitialized memory
...
valgrind complained about these, and they make for bad size allocation
and the occasional crash.
2011-02-17 11:53:38 -05:00
Emmanuele Bassi
a88a1fc832
Build fix in GtkSeparatorMenuItem
...
https://bugzilla.gnome.org/show_bug.cgi?id=642541
2011-02-17 09:24:25 +00:00
Matthias Clasen
ed901afe37
Use _gtk_accessible_set_factory_type in GtkSeparatorMenuItem
2011-02-17 01:34:10 -05:00
Matthias Clasen
221415f71f
Use _gtk_accessible_set_factory_type in GtkSwitch
2011-02-17 01:32:24 -05:00
Matthias Clasen
e757d1b2d2
Use _gtk_accessible_set_factory_type for GtkIconView
2011-02-17 01:30:33 -05:00
Matthias Clasen
9d321437b6
Add a private function for accessible factory registration
...
This avoids repeating the same code for each widget that
has its own accessible implementation inside GTK+.
2011-02-17 01:24:43 -05:00
Matthias Clasen
4a4004b706
Add an a11y implementation to GtkSeparatorMenuItem
...
Its all boilerplate, and it more than doubles the line count.
Yay :-(
2011-02-17 00:44:26 -05:00
Matthias Clasen
405b54c72e
Check the return value of gtk_tree_model_get_iter
...
Noticed in passing, didn't really see it crash there, but
better safe than sorry.
2011-02-16 18:48:42 -05:00