Benjamin Otte
2550c6a4db
combobox: Refactor cell view treatment
...
Instead of putting it inside the button manually, put it there properly
by adding a box containing the cell view and the arrow.
Do the same thing in list mode, instead of creating an event box that
tries to behave as a button.
2015-07-31 04:03:44 +02:00
Benjamin Otte
bbd9c59832
combobox: Handle NULLing the cellview on remove simpler
2015-07-31 04:03:44 +02:00
Benjamin Otte
1261ec985b
combobox: Remove unused variables
2015-07-31 04:03:44 +02:00
Benjamin Otte
62c43aac43
combobox: Create cell view identically
...
... in the two places it can be created.
2015-07-31 04:03:44 +02:00
Benjamin Otte
5e2ab6db7f
combobox: Use ui file to construct internal button child
2015-07-26 17:18:42 +02:00
Benjamin Otte
5ad5431cb7
combobox: Create button on init() and destroy in destroy()
...
The button is the same in both menu and list mode, so there's no need to
destroy and recreate it.
2015-07-26 17:18:42 +02:00
Benjamin Otte
e0572212bc
combobox: Add scroll support in list mode
2015-07-26 17:18:42 +02:00
Benjamin Otte
8243140731
combobox: Remove unused argument
...
The visible check is always FALSE, so no need to keep the code around.
2015-07-26 17:18:42 +02:00
Benjamin Otte
63c219b8e7
combobox: Remove the box from the button
...
... when in menu mode.
Now that we don't have a separator anymore, the box is not needed
anymore.
2015-07-26 17:18:42 +02:00
Benjamin Otte
fcb26376df
combobox: Remove the separator
...
It was a special case and it's not used by themes anymore.
Plus, in the CSS world, if a theme wants a separator, it can just
style the button's border to create one.
2015-07-26 17:18:42 +02:00
Benjamin Otte
3402363684
combobox: Unconditionally draw background and border
2015-07-21 02:28:53 +02:00
Benjamin Otte
5f6db9a182
combobox: Remove autoscroll timer on popdown
2015-07-21 02:28:53 +02:00
Benjamin Otte
19726a5a0e
combobox: Remove cell_view_frame
...
Cell views can draw their own frames now.
2015-07-21 02:28:53 +02:00
Benjamin Otte
8d3bcb6ef8
combobox: Simplify code
...
We don't add new children to the child's parent, we add them to ourself.
Because guess who a child's parent is?
2015-07-18 05:39:01 +02:00
Benjamin Otte
d071415d56
combobox: Remove unused header function functionality
2015-07-18 05:18:19 +02:00
Benjamin Otte
1ec7f435d8
combobox: Remove unused argument from private function
2015-07-18 05:18:19 +02:00
Matthias Clasen
f16fc99391
combo box: Fix compiler warnings
...
Fix warnings due to -Wdeclaration-after-statement and -Wshadow.
2015-06-02 09:08:15 -04:00
Benjamin Otte
9744e86e04
combobox: Don't set cell view background
...
This can be done with CSS these days. Also, these days the background of
cell views is transparent, so it doesn't even have to be done.
2014-10-03 06:18:05 +02:00
Benjamin Otte
b5a8b7ef3b
widget: Make _gtk_set_simple_clip() take an optional content clip
2014-08-21 00:54:07 +02:00
Jasper St. Pierre
9c37b3de74
gtk: Don't use GObjectClass.constructor
...
Use the newer constructed instead, which has a fast path in GObject.
2014-06-26 19:06:43 -04:00
Matthias Clasen
f0f9c2aa37
Revert "gtkbin: replace internal api"
...
This reverts commit 0f4751c08e
.
This causes warnings from the notebook and combobox code.
2014-06-16 17:31:56 -04:00
Stefan Sauer
0f4751c08e
gtkbin: replace internal api
2014-06-14 08:10:46 +02:00
Matthias Clasen
ec9cf6d7c3
GtkComboBox: Add private api to get the popup
...
This will be used to make the popup appear in the inspector.
2014-06-10 08:54:12 -04:00
Matthias Clasen
1720eb4713
GtkComboBox: Notify for has-frame and editing-canceled
2014-06-09 13:30:55 -04:00
Matthias Clasen
a27ba44331
GtkComboBox: Use G_PARAM_EXPLICIT_NOTIFY
2014-06-09 13:30:53 -04:00
Carlos Garnacho
246e6cd0b9
combobox: Fix reentrancy in gtk_combo_box_popdown()
...
If called when already popped down, warnings would be issued due
to priv->grab_pointer being unexpectedly NULL, this would happen
in regular operation when selecting items in appears-as-list mode.
So both add a NULL check for priv->grab_pointer, and bail out early
if the popup window is already hidden.
2014-06-05 21:16:05 +02:00
Evan Nemerson
54ec42f035
gtk: port many nullability annotation fixes from Vala bindings
...
https://bugzilla.gnome.org/show_bug.cgi?id=730745
2014-05-30 13:24:20 -07:00
Benjamin Otte
1cbace5f68
combobox: Implement clip
2014-05-24 16:21:02 +02:00
Carlos Garnacho
46b4e5d388
combobox: remove superfluous GTK+ grabs
2014-05-23 19:54:24 +02:00
Matthias Clasen
9a127d364f
Drop GtkArrow use in GtkComboBox
...
This is in preparation for GtkArrow getting deprecated.
https://bugzilla.gnome.org/show_bug.cgi?id=729564
2014-05-13 23:50:12 -04:00
Benjamin Otte
a89c598617
combobox: Add workaround so evolution doesn't crash
...
Removing the NULL checks in 7f60cab47d
caused evolution to crash. It chains up with NULL and that used to work.
This patch should be reverted for GTK 4.0.
https://bugzilla.gnome.org/show_bug.cgi?id=729496
2014-05-05 15:53:03 +02:00
Cosimo Cecchi
7f60cab47d
combobox: fix a segfault
...
Don't dereference a NULL pointer.
2014-05-01 19:44:12 +02:00
Benjamin Otte
7455ab72f8
combobox: Remove unneeded checks
...
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
2014-05-01 14:51:27 +02:00
Bastien Nocera
f71f7215ab
all: Name more idles and timeouts
...
Following up from 438cd857c4
,
name more timeouts and idles.
The original grep was missing checking for gdk_threads_add_*()
functions (at least for some of the files).
https://bugzilla.gnome.org/show_bug.cgi?id=726870
2014-03-26 20:09:30 -04:00
William Jon McCann
469d333aa2
docs: use Returns: consistently
...
Instead of Return value:
2014-02-19 18:56:05 -05:00
Matthias Clasen
7f6a964c47
Docs: Remove all entities and turn off sgml mode
...
With all element markup gone, it is time to turn off
sgml mode, and get rid of entities as well.
2014-02-09 17:58:07 -05:00
William Jon McCann
326da2da58
docs: don't use <anchor>
2014-02-07 15:40:52 -05:00
William Jon McCann
13998c55e7
docs: use proper quotations instead of '*'
2014-02-07 14:22:39 -05:00
William Jon McCann
e34bd4137d
docs: use apostrophes in *n't
2014-02-07 13:32:47 -05:00
William Jon McCann
7a208fbbf3
docs: use proper apostrophe
...
https://wiki.gnome.org/Design/OS/Typography
2014-02-07 13:06:10 -05:00
William Jon McCann
0ce016650b
docs: Use markup for links
2014-02-07 09:42:12 -05:00
William Jon McCann
a22358c0c0
docs: use ` instead of <literal>
2014-02-04 18:24:29 -05:00
William Jon McCann
4c8bd8e7cf
docs: Identify examples that are C code
...
https://bugzilla.gnome.org/show_bug.cgi?id=723119
2014-01-29 12:45:49 -05:00
Carlos Garnacho
da86918c32
combobox: Set GDK_SCROLL_MASK on the eventbox in appears-as-list mode
...
This is so the scroll wheel works in both modes, and there's no behavioral
change depending on a style property.
https://bugzilla.gnome.org/show_bug.cgi?id=702663
2013-11-20 13:18:37 +01:00
Bastien Nocera
438cd857c4
all: Add names to timeouts
...
Add names to every timeout we setup, so it's easier to track their
usage, and debug possible misbehaviour.
https://bugzilla.gnome.org/show_bug.cgi?id=710651
2013-10-23 13:31:18 +02:00
David King
4415d087c6
combobox: Add missing Since tags for entry constructors
2013-08-22 20:36:17 +01:00
Matthias Clasen
8383f003f3
Avoid deprecation warnings
2013-08-20 00:15:37 -04:00
William Jon McCann
6f7b0cac94
Deprecate tear off menus
2013-07-18 12:16:02 -04:00
Emmanuele Bassi
0899ef7cc9
gtk: Use new macros for defining private data
...
https://bugzilla.gnome.org/show_bug.cgi?id=702996
2013-07-09 09:30:02 +01:00
Aleksander Morgado
24fa277329
combobox: popdown the combobox when on 'grab-broken-event'
...
And also explicitly remove pointer/keyboard grabs from the display.
Whenever the grab is reported lost, we should popdown the combobox, so that the
GDK_WINDOW_TEMP window is hidden and removed from the toplevel, as done with
the menu for example.
Leaving the GDK_WINDOW_TEMP window open when re-activating the application
triggers several issues in the win32 backend, due to restacking windows of the
non-toplevel group into the toplevel group:
https://bugzilla.gnome.org/show_bug.cgi?id=695200
2013-03-12 07:23:17 -04:00