Commit Graph

2859 Commits

Author SHA1 Message Date
Kristian Rietveld
2ccd6fd5d7 update docs, return current FALSE if x is smaller than the current visible
Thu Jan 24 23:03:24 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreeview.c (gtk_tree_view_get_path_at_pos): update docs,
        return current FALSE if x is smaller than the current visible area,
        not than the requested area, don't correct y coordinate,
        TREE_WINDOW_Y_TO_RBTREE_Y will do that. Fixes #67477.
2002-01-24 22:07:35 +00:00
Jonathan Blandford
902c6a48d5 fix column reordering fully. (gtk_tree_view_size_allocate): fix evil bug.
Thu Jan 24 15:41:08 2002  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtktreeview.c
	 (gtk_tree_view_motion_draw_column_motion_arrow): fix column
	 reordering fully.
	 (gtk_tree_view_size_allocate): fix evil bug.
2002-01-24 20:42:48 +00:00
Owen Taylor
bc5dfe106d Don't clear the model until we clean up all the other objects that might
Thu Jan 24 11:53:19 2002  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtktreeview.c (gtk_tree_view_destroy): Don't clear
	the model until we clean up all the other objects
	that might refer to the object.
2002-01-24 16:54:54 +00:00
Mark McLoughlin
44047a30e2 include gtk/gtkwidget.h
2002-01-24  Mark McLoughlin  <mark@skynet.ie>

        * gtk/gtkaccessible.h: include gtk/gtkwidget.h
2002-01-24 15:59:37 +00:00
Owen Taylor
c431ffffc6 Use insensitive state for insensitive arrows, not just an "etched state".
Wed Jan 23 20:28:59 2002  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtknotebook.c (gtk_notebook_draw_arrow):
	Use insensitive state for insensitive arrows, not
	just an "etched state". (#67172, Adrian Custer)
2002-01-24 01:36:39 +00:00
Manish Singh
1b3a7630f2 use a variable that's actually been declared.
2002-01-23  Manish Singh  <yosh@gimp.org>

        * gtk/gtkentry.c (gtk_entry_set_text): use a variable that's actually
        been declared.
2002-01-24 00:29:49 +00:00
Damon Chaplin
ea23df6106 set minimum gtk-doc version to 0.9, since we need to use the new
2002-01-23  Damon Chaplin  <damon@ximian.com>

	* configure.in (gtk_doc_min_version): set minimum gtk-doc version to
	0.9, since we need to use the new --type-init-func argument for
	gtkdoc-scangobj.
2002-01-23 23:58:41 +00:00
Matthias Clasen
321db896a4 Remove excessive g_return_if_fail() calls. (#57615)
* gtk/gtkentry.c, gtk/gtkwidget.c: Remove excessive
        g_return_if_fail() calls. (#57615)
2002-01-23 23:46:25 +00:00
Matthias Clasen
d67b5ce070 Make it work for paths with underline accelerators. (#69247)
* gtk/gtkitemfactory.c (gtk_item_factory_delete_entries): Make
        it work for paths with underline accelerators. (#69247)
2002-01-23 22:51:01 +00:00
Owen Taylor
c099271bb5 Stop spinning if widget becomes insensitive. (#56248)
Wed Jan 23 15:12:16 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkspinbutton.c (gtk_spin_button_state_changed):
        Stop spinning if widget becomes insensitive. (#56248)
2002-01-23 20:15:48 +00:00
Owen Taylor
44d727eaa1 Decreate value since we now use doubles.
Wed Jan 23 14:44:12 2002  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkspinbutton.c (EPSILON): Decreate value since
	we now use doubles.
2002-01-23 19:51:43 +00:00
Jonathan Blandford
60afa9e14e Fix sizing bug I introduced accidentally, #69358
Tue Jan 22 16:58:37 2002  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtktreeview.c (gtk_tree_view_size_allocate): Fix sizing bug
	I introduced accidentally, #69358
2002-01-22 22:13:30 +00:00
Padraig O'Briain
e060f59406 Update last change to prevent core dump
* gtk/gtktreestore.c (gtk_tree_store_iter_children):
Update last change to prevent core dump
2002-01-22 15:44:20 +00:00
Kristian Rietveld
f0c42465b9 add some more stamp checks (pointed out by Anders Carlsson)
Mon Jan 21 01:21:54 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreestore.c: add some more stamp checks (pointed out
        by Anders Carlsson)

        * gtk/gtktreemodelsort.c (gtk_tree_model_sort_insert_value): don't
        assume _row_changed will insert sort (because _row_changed doesn't
        need to follow this signal), so apply insert sort here
        (gtk_tree_model_sort_level_find_insert): header doesn't need to be
        set here, so use a return instead of g_return_val_if_fail.
2002-01-22 00:21:40 +00:00
Jonathan Blandford
969279b54e Update top_row. Remove extraneous print statements.
Mon Jan 21 18:28:17 2002  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtktreeview.c (gtk_tree_view_adjustment_changed): Update
	top_row.  Remove extraneous print statements.
2002-01-21 23:30:17 +00:00
Matthias Clasen
236118bf89 Document allowed values for ifactory.
* gtk/gtkitemfactory.c (gtk_item_factory_popup,
        gtk_item_factory_popup_with_data): Document allowed values
        for ifactory.

        * gtk/gtkitemfactory.c (gtk_item_factory_delete_entry): Make
        it work for paths with underline accelerators.
2002-01-21 18:44:20 +00:00
Jonathan Blandford
19c5e80ce7 only resize the window.
Fri Jan 18 16:31:21 2002  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtktreeview.c (gtk_tree_view_size_allocate): only resize the
	window.
2002-01-21 17:38:28 +00:00
Owen Taylor
382cc81163 Trap the case where there is no default widget and the entry is the focus
Mon Jan 21 11:56:31 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkentry.c (gtk_entry_real_activate): Trap the
        case where there is no default widget and the entry
        is the focus widget, since this also causes infinite
        recursion. (#69158)
2002-01-21 17:04:47 +00:00
Owen Taylor
da117dcdca Set the fallback program class here, rather than
Mon Jan 21 11:46:39 2002  Owen Taylor  <otaylor@redhat.com>

        * gdk/gdk.c (gdk_init_check): Set the fallback program class here,
        rather than lazilygdk_get_program_class(), since we don't want
        -name to override it. (#69123, Ryan Lovett)
2002-01-21 16:50:45 +00:00
Owen Taylor
599b862f98 Fix wrong types for command line arguments (#69124, Ryan Lovett)
Mon Jan 21 10:29:45 2002  Owen Taylor  <otaylor@redhat.com>

	* gdk/gdk.c: Fix wrong types for command line arguments
	(#69124, Ryan Lovett)

	* gdk/gdk.c (gdk_arg_context_parse): Fix bug in parsing
	parsing '--arg VALUE'.

	* gdk/gdk.c: Remove unused variable gdk_error_trap_free_list.
2002-01-21 15:41:47 +00:00
Havoc Pennington
fffbc2b16e mention that window arg can be NULL
2002-01-21  Havoc Pennington  <hp@pobox.com>

	* gdk/gdkwindow.c (gdk_window_add_filter): mention that window
	arg can be NULL
2002-01-21 05:58:33 +00:00
Kristian Rietveld
4aebf9326a fix a load of open line ends (cell_edited): modified patch from German Poo
Sat Jan 19 20:49:41 2002  Kristian Rietveld  <kris@gtk.org>

        * demos/gtk-demo/editable_cells.c: fix a load of open line ends
        (cell_edited): modified patch from German Poo Caaman~o
        to fix up old_text declaration and free the memory
        (do_editable_cells): unref the model after creating the treeview

        * demos/gtk-demo/list_store.c: fix a load of open line ends,
        (add_columns): set the sort column id, so we can sort

        * demos/gtk-demo/tree_store.c: fix a load of open line ends,
        (do_tree_store): unref the model after creating the treeview
2002-01-19 20:15:56 +00:00
Havoc Pennington
31283d57ca link to new X11 section in a lot of places when mentioning the window
2002-01-19  Havoc Pennington  <hp@pobox.com>

	* gtk/gtkwindow.c: link to new X11 section in a lot of places when
	mentioning the window manager.

	* gtk/gtkwidget.c (gtk_widget_hide_on_delete): don't mention
	window manager since we're portable.

2002-01-19  Havoc Pennington  <hp@pobox.com>

	* gtk/x11.sgml: add a mostly-empty X11 section

	* gtk/framebuffer.sgml: make title consistent with windows section

	* gtk/tmpl/gtkdrawingarea.sgml: couple of fixes
2002-01-19 18:51:48 +00:00
Jeff Garzik
b292358479 Wrap case values in GPOINTER_TO_UINT(). Fixes build with gcc 3.x.
Sat Jan 19 08:47:41 2002  Jeff Garzik  <jgarzik@mandrakesoft.com>

        * gdk/linux-fb/gdkproperty-fb.c (gdk_atom_name):
        Wrap case values in GPOINTER_TO_UINT().  Fixes build with gcc 3.x.

        * gtk/gtkmain.c:  Include sys/types.h if G_OS_UNIX.
        Fixes build with gcc 3.x and -ansi.
2002-01-19 17:54:11 +00:00
Owen Taylor
eb9406c2b3 Fix problems when an engine declaration occurs in a reopened style, and
Fri Jan 18 23:01:37 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkrc.c (gtk_rc_parse_style): Fix problems when
        an engine declaration occurs in a reopened style, and
        g_free() of objects when errors occur.
2002-01-19 06:45:45 +00:00
Matthias Clasen
fc85da54ca Clarify documentation. (#69026)
* gtk/gtkitemfactory.c (gtk_item_factory_get_widget_by_action):
        Clarify documentation. (#69026)

        * gtk/gtkprogressbar.c (gtk_progress_bar_size_request): Fix
        missing initialization of adjustment. (#69025)
2002-01-18 21:37:31 +00:00
Raja R Harinath
dcb3638a7d Simplify Makefiles. <URL: http://bugzilla.gnome.org/show_bug.cgi?id=68969>
Simplify Makefiles.
<URL: http://bugzilla.gnome.org/show_bug.cgi?id=68969>
* gdk/Makefile.am: Remove use of automake conditionals to pick
library to build.
* gtk/Makefile.am: Likewise.

* gdk/Makefile.am (LDFLAGS): Use $(libdir), not @prefix@/lib.
* gtk/Makefile.am (LDFLAGS): Likewise.
2002-01-18 04:21:24 +00:00
Owen Taylor
a8e2fc3082 Fix missing allocation.x/y offsets. (#68962, Jacob Berkman)
Thu Jan 17 20:13:14 2002  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtknotebook.c (gtk_notebook_redraw_tabs): Fix
	missing allocation.x/y offsets. (#68962, Jacob
	Berkman)

	* gtk/gtknotebook.c (gtk_notebook_size_allocate):
	Queue a redraw on the entire widget if we hide
	the last page or show the first. (Also #68962)
2002-01-18 01:18:05 +00:00
Havoc Pennington
c6a3df0474 change GTK_MOVEMENT_PARAGRAPHS to go to start/end of paragraph before it
2002-01-17  Havoc Pennington  <hp@redhat.com>
	* gtk/gtktextview.c (gtk_text_view_move_cursor_internal): change
	GTK_MOVEMENT_PARAGRAPHS to go to start/end of paragraph before it
	starts to go up/down paragraphs. This makes Ctrl+Up/Ctrl+Down work
	as in the keynav spec, though it makes the interpretation of
	GTK_MOVEMENT_PARAGRAPHS different from the interpretation of some
	of the other GTK_MOVEMENT_ thingies, maybe, as if that enum makes
	any sense anyhow.
2002-01-18 00:45:50 +00:00
Jonathan Blandford
6bc31ea4d9 For some reason, I was activating a row while just selecting it. Reported
Thu Jan 17 16:34:55 2002  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtktreeview.c (gtk_tree_view_real_select_cursor_row): For
	some reason, I was activating a row while just selecting it.
	Reported by andersca.
	(gtk_tree_view_size_request): add a
	validate_rows_handler to give us a rough width of the widget.

	* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_update_button):
	Queue a resize here just in case.  It's needed in over half the
	cases, and I don't want to do a diff to figure out exactly when
	it's needed.
2002-01-18 00:23:26 +00:00
Matthias Clasen
841e8424ab More composite children. 2002-01-18 00:10:23 +00:00
Matthias Clasen
77c286304e Mark children as composite. (#66360)
* gtk/gtkcolorsel.c, gtk/gtkfilesel.c, gtk/gtkfontsel.c:
        Mark children as composite. (#66360)

        * gtk/gtkwidget.c (gtk_widget_push_composite_child): Explain
        composite children some more. (#66360)
2002-01-17 23:43:23 +00:00
Havoc Pennington
9e404f2a1e new function (which I then decided not to use but I think it's needed to
2002-01-17  Havoc Pennington  <hp@redhat.com>
	* gtk/gtktextlayout.c (_gtk_text_layout_get_line_xrange): new
	function (which I then decided not to use but I think it's needed
	to fix #68963
	* gtk/gtktextview.c: add page_horizontally action signal and
	implement Ctrl+PgUp, Ctrl+PgDown based on patch from Padraig,
	hackily modified to avoid adding GTK_MOVEMENT_ API. Part of
	#53934
	* gtk/gtkmarshalers.list: add NONE:INT,BOOL
2002-01-17 22:38:18 +00:00
Owen Taylor
cf25093441 Call gtk_selection_remove_all() here, not in destroy/ finalize. (#66636,
Thu Jan 17 17:02:38 2002  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkwidget.c (gtk_widget_real_unrealize): Call
	gtk_selection_remove_all() here, not in destroy/
	finalize. (#66636, Sergey Vlasov)

	* gtk/gtkselection.c (gtk_selection_request): Fix
	reentrancy problem with multiple conversions.

	* gtk/gtkselection.c (gtk_selection_remove_all):
	Don't remove incrs, we don't need the widget for
	maintain the incr.

	* gtk/gtkselection.c (struct _GtkIncrInfo): Remove
	the widget field from here, we don't need it.
2002-01-17 22:28:02 +00:00
Owen Taylor
c8698f924d Move here, and save/restore the X error handler to allow people using GTK+
Thu Jan 17 13:08:34 2002  Owen Taylor  <otaylor@redhat.com>

	* gdk/x11/gdkmain-x11.c (gdk_error_trap_push): Move
	here, and save/restore the X error handler to allow
	people using GTK+ to set the X error handler to something
	custom without disturbing the operation of GDK.

	* gdk/linux-fb/gdkmain-fb.c (gdk_error_trap_push)
	* gdk/win32/gdkmain-win32.c (gdk_error_trap_pop): Add
	dummy implementations.

	* gdk/x11/gdkmain-x11.c gdk/x11/gdkevents-x11.c
	gdk/x11/gdkdnd-x11.c: Use gdk_error_trap_push()/pop()
	for all error trapping.

	* gdk/x11/gdkdnd-x11.c: Remove '#if 0' code.

	* gdk/x11/gdkdnd-x11.c (gdk_window_cache_new): Fix
	problem where we would add the results anyways,
	and then add it again if no error occurred, and problem
	where we could leave _gdk_error_warnings() unset.
2002-01-17 20:45:23 +00:00
Owen Taylor
9961ddc205 Fix "deleting" filename by adding another boolean parameter to
Wed Jan 16 20:28:38 2002  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkfilesel.c: Fix "deleting" filename by adding
	another boolean parameter to file_selection_populate() -
	whether to clear the entry. Also, never fill in the
	entry when the user clicks on something in the
	directory list. (#6791, Reported by Jos Dehaes and many,
	many, many others.)
2002-01-17 01:37:06 +00:00
Havoc Pennington
fe622071f6 update cursor_y_pos with clamped delta rather than theoretical delta
2002-01-16  Havoc Pennington  <hp@redhat.com>
	* gtk/gtktextview.c (gtk_text_view_scroll_pages): update
	cursor_y_pos with clamped delta rather than theoretical delta
	(#68788). Also, if we can't page up/down further then jump
	to top/bottom of the document.
2002-01-17 01:08:59 +00:00
Owen Taylor
396f5ab1f6 Refresh the dialog on map. (#52877, inspired by request from Murray
Wed Jan 16 19:33:41 2002  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkfilesel.c (gtk_file_selection_map): Refresh
	the dialog on map. (#52877, inspired by request from
	Murray Cumming)
2002-01-17 00:53:50 +00:00
Owen Taylor
ee2d7c4556 Support "optional" bindings. If a binding signal has a boolean return
Wed Jan 16 19:23:04 2002  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkbindings.c (gtk_binding_entry_activate):
	Support "optional" bindings. If a binding signal
	has a boolean return value, and returns FALSE it
	is as if it didn't exist all.

	* gtk/gtkbindings.c (binding_compose_params): Switch
	over to GValue.

	* gtk/gtknotebook.[ch]: Make the select_page() and
	change_current_page() signals only take effect when
	the focus is on the tab area so that key presses
	in children pass up to the toplevel correctly.
2002-01-17 00:34:58 +00:00
Matthias Clasen
226b2fa14b Deprecate. (#68183)
* gtk/gtkenums.h (GtkMatchType): Deprecate. (#68183)

        * gtk/gtkscale.h (gtk_scale_value_width): Remove useless
        compatibility macro. (#67730)

        * gtk/changes-2.0.sgml: Details about GtkRange and subclasses
        rewrite. (#67730)
2002-01-16 19:12:47 +00:00
Owen Taylor
5b96321c3a Fix typo in --help output. (Arnaud Charlet).
Wed Jan 16 10:54:38 2002  Owen Taylor  <otaylor@redhat.com>

	* configure.in: Fix typo in --help output.
	(Arnaud Charlet).
2002-01-16 15:55:38 +00:00
Owen Taylor
476d48ddd1 Add gtkstockpixbufs.h.
Wed Jan 16 10:18:42 2002  Owen Taylor  <otaylor@redhat.com>

	* gtk/stock-icons/Makefile.am (EXTRA_DIST): Add
	gtkstockpixbufs.h.

	* configure.in: Make TIFF, JPEG, PNG loaders mandatory
	unless you configure with --without-libtiff, etc.
	(#54045, Brian Cameron)
2002-01-16 15:31:42 +00:00
Padraig O'Briain
b573dba9e0 Avoid unexpected warning message when navigating menu (#68517)
* gtk/gtkmenushell.c (gtk_real_menu_shell_move_current):
Avoid unexpected warning message when navigating menu (#68517)
2002-01-16 08:53:15 +00:00
Jody Goldberg
337982738d set_boxed will copy the color and will use a mem_chunk to do it. Avoid an
2002-01-13  Jody Goldberg <jody@gnome.org>

        * gtk/gtktexttag.c (get_color_arg) : set_boxed will copy the color
	  and will use a mem_chunk to do it.  Avoid an unnecessary copy, a
	  leak, and confusion.
2002-01-16 06:02:41 +00:00
Jody Goldberg
691be10dbc It is possible that a GtkLayout may have been scrolled _before_ it was
2002-01-15  Jody Goldberg <jody@gnome.org>

	* gtk/gtklayout.c (gtk_layout_realize) : It is possible that a
	GtkLayout may have been scrolled _before_ it was realized.
2002-01-16 06:01:31 +00:00
Owen Taylor
815ffe2edd Stop the timer on destroy, or when we are notified that we are shadowed by
Tue Jan 15 18:10:24 2002  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkspinbutton.c (gtk_spin_button_grab_notify): Stop
	the timer on destroy, or when we are notified that we are
	shadowed by a modal dialog.

	* gtk/gtkspinbutton.c: Remove explicit gtk_grab_add()/remove() -
	not needed any more.

	* gtk/gtkmain.c (gtk_grab_notify): Fix problem where notifications
	weren't sent out for the default grab group.

	* gtk/gtkmain.c (gtk_grab_notify): Fix notification of widgets that
	were getting events because they were part of the previous grab.
2002-01-16 01:07:11 +00:00
Owen Taylor
08431c79ba focus the activated tab, not the page. (#53612)
Tue Jan 15 12:23:33 2002  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtknotebook.c (gtk_notebook_mnemonic_activate_switch_page):
	focus the activated tab, not the page. (#53612)

	* gtk/gtknotebook.c (gtk_notebook_set_focus_child): Track
	the last focus descendant of the page.

	* gtk/gtknotebook.c (gtk_notebook_real_switch_page): If the focus
	was on the previous page, move it to the last focused widget /
	first element on the new page, if possible, or if not, to the
	notebook itself. (#68224, reported by Jonathan Blandford)

	* gtk/gtknotebook.c (focus_tabs_in): Don't focus tabs
	tabs aren't visible. (#65462, Damon Chaplin, fixed based
	on patch from Anders Carlsson)
2002-01-15 17:40:44 +00:00
Vitaly Tishkov
3b3eee9304 gtk/gtkstyle.c a misprint in documentation for gtk_style_render_icon () is
2002-01-15            Vitaly Tishkov       <tvv@sparc.spb.su>

        * gtk/gtkstyle.c
	a misprint in documentation for gtk_style_render_icon () is fixed
2002-01-15 16:35:01 +00:00
Tim Janik
1d43dcc334 map event_window after mapping child, so we don't loose events.
Mon Jan 14 23:21:47 2002  Tim Janik  <timj@gtk.org>

        * gtk/gtkmenuitem.c (gtk_menu_item_map): map event_window after
        mapping child, so we don't loose events.
2002-01-15 13:24:03 +00:00
Sven Neumann
29ccea0889 gtk/gtkaccellabel.h fixed documentation by syncing the parameter names
2002-01-15  Sven Neumann  <sven@gimp.org>

	* gtk/gtkaccellabel.h
	* gtk/gtkitemfactory.c: fixed documentation by syncing the parameter
	names used in headers and code.
2002-01-15 11:20:00 +00:00