Timm Bäder
3758762119
GtkImage: Simplify _set_from_icon_name
...
We don't need to strdup icon_name since that will happen in
_gtk_icon_helper_set_icon_name anyway.
2016-01-02 15:46:45 +01:00
Matthias Clasen
3075dac106
image: Don't assume baseline parameters are non-NULL
...
The GetSize callback *can* assume that minimum and natural are
non-NULL. Buy minimum_baseline and natural_baseline can and
will be NULL, so handle that. This was causing crashes e.g. in
pavucontrol.
2015-12-21 12:55:12 -05:00
Benjamin Otte
b79a187d47
iconhelper: Handle invalidation
...
When CSS, direction or scale factor change, handle the invalidation
inside the iconhelper.
This way the widgets using them don't have to.
2015-12-15 08:41:16 -05:00
Benjamin Otte
ad22612ab2
iconhelper: Require passing a cssnode to the constructor
...
Note that we don't use it yet.
2015-12-15 08:41:16 -05:00
Matthias Clasen
c0fd106019
image: Port to gadgets
2015-12-15 08:41:16 -05:00
Benjamin Otte
5cbbc62026
widget: Pass a GtkCssStyleChange instead of a bitmask
2015-12-13 04:11:58 +01:00
Benjamin Otte
ccfc4d3f12
iconhelper: Remove the context argument
...
Instead, use the widget's context.
2015-12-09 13:30:40 +01:00
Benjamin Otte
e95e2d5048
iconhelper: Get rid of _gtk_icon_helper_set_window()
...
Instead use the window of the owner widget.
2015-12-09 13:30:40 +01:00
Benjamin Otte
c9d1a45d30
iconhelper: Require a widget as construction argument
...
Note that the caller needs to ensure the widget lives as long as the
iconhelper as the iconhelper will not ref the widget.
2015-12-09 13:30:40 +01:00
Benjamin Otte
c10b6b7297
dnd: Add gtk_image_set_from_definition()
...
... and use it in the DND code, thereby getting rid of the icon helper.
2015-12-02 15:45:14 +01:00
Benjamin Otte
8a7dbe5f36
image: Remove unused code
...
I wonder how long that stuff has existed and not been used...
2015-12-02 14:56:15 +01:00
Benjamin Otte
c66a2057af
image: Split out a function
2015-12-02 14:54:15 +01:00
Benjamin Otte
a81bdf1e60
image: queue_resize() after changing icon-size property
2015-12-02 00:29:29 +01:00
Matthias Clasen
34be4de1ad
image: Use the element name image
...
Set hte element name on the CSS node.
2015-10-23 00:04:47 -04:00
Matthias Clasen
38901acea3
image: Convert to g_object_notify_by_pspec
...
This avoids pspec lookup overhead in g_object_notify.
2015-09-06 17:11:35 -04:00
Matthias Clasen
a56bd1c490
GtkImage: Plug a memory leak
2015-07-21 23:04:30 -04:00
cedlemo
d31e1fbef0
GtkImage: Make resource property work properly
...
gtk_image_set_from_resource was setting the resource_path,
only to have it overwritten again before returning. That
is not as it should be, so change things to set the resource
path late.
https://bugzilla.gnome.org/show_bug.cgi?id=751443
2015-06-25 06:50:44 -04:00
Matthias Clasen
c6a77d0f68
Revert "image: Optimize non-resize changes"
...
This reverts commit bae97a4c6b
.
We're still seeing regressions from there, see
http://bugzilla.redhat.com/show_bug.cgi?id=1208183
2015-04-08 14:13:20 -04:00
Matthias Clasen
bae97a4c6b
image: Optimize non-resize changes
...
When the image content is changed, only queue a resize
if the size is actually changing, otherwise just a
redraw. Suggested by Owen in
https://bugzilla.gnome.org/show_bug.cgi?id=613833
2015-03-21 22:40:46 -04:00
Matthias Clasen
278fa902e2
Revert "image: Optimize non-resize changes"
...
This reverts commit 6276b9cda0
.
This change was causing problems in gnome-mines. Revert it
until we can figure out what exactly is going wrong there.
See https://bugzilla.redhat.com/show_bug.cgi?id=1190887
2015-02-11 12:07:32 -05:00
Matthias Clasen
6276b9cda0
image: Optimize non-resize changes
...
Suggested by Owen in
https://bugzilla.gnome.org/show_bug.cgi?id=613833
2015-01-30 23:32:50 -05:00
Benjamin Otte
488ea44a59
image: Use _gtk_css_style_property_get_mask_affecting()
...
... to avoid recomputing the cached surface all the time.
2015-01-27 05:04:34 +01:00
Benjamin Otte
22967f1612
image: Compute clip properly
...
Use the helper function we have for this, don't do it manually. This has
the side effect of also supporting icon transforms.
2015-01-20 06:30:20 +01:00
Benjamin Otte
7afac9670b
image: Implement clipping support for icon-shadow
...
Testcase is attached.
2014-10-03 06:18:04 +02:00
Matthias Clasen
83c9fe109e
GtkImage: Always close the loader
...
This was causing some tests to fail with a critical.
2014-07-31 00:12:30 +02:00
Cosimo Cecchi
7e425f3019
image: support scale factor when loading from GResource and file
...
Currently, when loading an image from a GResource or file we don't take
the scale factor of the display into consideration, and let
GtkIconHelper scale it accordingly.
While this in general works for non-scalable images, we can take
advantage of the native loader's scaling for e.g. SVG images, and load
them at the right scale factor automatically.
This is achieved by switching to a pixbuf loader instead of using the
native function.
https://bugzilla.gnome.org/show_bug.cgi?id=733416
2014-07-29 10:13:21 +02:00
Matthias Clasen
d49d592316
GtkImage: Add cairo surface api to the docs
...
https://bugzilla.gnome.org/show_bug.cgi?id=732861
2014-07-07 22:36:56 -04:00
Matthias Clasen
68673963fc
GtkImage: Use G_PARAM_EXPLICIT_NOTIFY
...
And make use of the new icon helper API to avoid
redundant notification.
2014-06-09 13:31:04 -04:00
Matthias Clasen
7fa0228755
Revert "GtkImage: Drop use of GtkMisc::x/yalign"
...
This reverts commit 54d5b426fc
.
Conflicts:
gtk/gtkimage.c
2014-05-27 13:08:25 -04:00
Matthias Clasen
6ce2a8fb13
Revert "Fix up GtkLabel and GtkImage sizing"
...
This reverts commit 3b30cfa344
.
2014-05-27 13:04:43 -04:00
Matthias Clasen
7c83a71239
Revert "More label and image sizing fixes"
...
This reverts commit 68c1e83cf0
.
2014-05-27 13:04:34 -04:00
Matthias Clasen
68c1e83cf0
More label and image sizing fixes
...
Go back to respecting GtkMisc::xpad/ypad. Not doing so breaks
the misc-alignment reftest. As long as we still derive from
GtkMisc, we may as well do this.
2014-05-27 06:00:21 -04:00
Matthias Clasen
3b30cfa344
Fix up GtkLabel and GtkImage sizing
...
When GtkMisc was removed, I forgot to apply the style context
padding. This caused the info-bar-message-types reftest to fail.
2014-05-27 00:22:40 -04:00
Benjamin Otte
0430ae0ca5
image: Draw the image again
...
An important line of code was removed in
54d5b426fc
that lead to an undefined
variable. Add that line back.
2014-05-24 19:38:56 +02:00
Benjamin Otte
b03d54b75f
image: Remove unused variable
2014-05-24 16:16:32 +02:00
Matthias Clasen
54d5b426fc
GtkImage: Drop use of GtkMisc::x/yalign
...
Instead, use GtkWidget::h/valign to position the image inside
the allocation. And just stop using GtkMisc::x/ypad.
https://bugzilla.gnome.org/show_bug.cgi?id=730613
2014-05-24 00:04:41 -04:00
Matthias Clasen
ec0a60a248
Deprecate GtkMisc
...
This has been dangling ever since 3.0.
2014-05-13 08:45:00 -04:00
William Jon McCann
469d333aa2
docs: use Returns: consistently
...
Instead of Return value:
2014-02-19 18:56:05 -05:00
Matthias Clasen
c779b42476
Docs: use // for comments in examples
...
Without sgml mode, we can't escape /* as /* anymore,
so just switch to // for comments in examples.
2014-02-14 23:34:22 -05:00
William Jon McCann
37a8ee6e95
docs: fully break lines in examples
...
Try to do a better job of keeping example content
from being too wide. It is often rendered as <pre>
text so the only time we can wrap it is in the source.
It is best to full break lines at all punctuation and
to try to keep the width under 70 chars or so.
2014-02-12 18:42:50 -05:00
Matthias Clasen
7f6a964c47
Docs: Remove all entities and turn off sgml mode
...
With all element markup gone, it is time to turn off
sgml mode, and get rid of entities as well.
2014-02-09 17:58:07 -05:00
William Jon McCann
e34bd4137d
docs: use apostrophes in *n't
2014-02-07 13:32:47 -05:00
William Jon McCann
7a208fbbf3
docs: use proper apostrophe
...
https://wiki.gnome.org/Design/OS/Typography
2014-02-07 13:06:10 -05:00
William Jon McCann
2a45418b67
docs: use proper quotes
2014-02-05 15:08:42 -05:00
William Jon McCann
a3bad427c7
docs: don't use <application> tags
2014-02-04 18:01:24 -05:00
William Jon McCann
63e887e165
docs: replace all <examples> with markdown headings
2014-02-04 16:58:54 -05:00
William Jon McCann
4c8bd8e7cf
docs: Identify examples that are C code
...
https://bugzilla.gnome.org/show_bug.cgi?id=723119
2014-01-29 12:45:49 -05:00
William Jon McCann
768bc44081
docs: use |[ ]| instead of <programlisting></programlisting>
...
https://bugzilla.gnome.org/show_bug.cgi?id=723119
2014-01-29 12:45:49 -05:00
William Jon McCann
22586ea7c2
docs: use #*-struct instead of <structname>
2014-01-27 19:59:55 -05:00
Bastien Nocera
438cd857c4
all: Add names to timeouts
...
Add names to every timeout we setup, so it's easier to track their
usage, and debug possible misbehaviour.
https://bugzilla.gnome.org/show_bug.cgi?id=710651
2013-10-23 13:31:18 +02:00