Benjamin Otte
d5e5ca3e2a
filechooserentry: Reorganize function
...
Setter functions the way I code it look like this (in order):
1) Figure out if the value changed. If not, exit early.
2) Clear the old value (ie unref stuff, disconnect signals
3) Copy the new value
4) Set up things about the new value
This reorganization does that.
And by doing that, it even reduces the amount of code and the amount of
branches (and with it, nesting) needed.
2011-12-16 20:09:11 +01:00
Benjamin Otte
7b51ca9a47
filechooserentry: Use the actual discarding function to discard a folder
2011-12-16 20:09:11 +01:00
Benjamin Otte
edddb666a7
filechooserentry: Don't use a magic number
...
... when we have a proper enum value for a column.
2011-12-16 20:09:11 +01:00
Benjamin Otte
92a72ce3e5
entry: Move freeze/thaw into begin/end_change
2011-12-16 20:09:11 +01:00
Benjamin Otte
cf8f3c07f2
entry: Don't try to handle Tab in entry completions
...
Instead, fall through to the default handler after closing the
completion. This has the advantage of letting the file chooser entry
capture the tab key properly, so one can't accidentally move out of the
entry by pressing tab while the completion is popped up.
I also suspect it fixes bugs with weird tab keys and shift/ctrl
oddities. But who knows...
2011-12-16 20:09:11 +01:00
Daniel Mustieles
88da2e81ab
Updated Spanish translation
2011-12-16 14:22:49 +01:00
Benjamin Otte
e104219ab1
tests: Relax a refcount comparison check
...
We now test for real_refcount >= expected_refcount, because various
parts of the code (a11y, selection, cursor, ...) can and do add
references.
2011-12-16 13:39:43 +01:00
Benjamin Otte
113aff673f
a11y: Don't emit children-changed when nothing changed
...
When we have 0 columns, no children ever get added or removed.
2011-12-16 13:39:43 +01:00
Benjamin Otte
d78971b31d
treeview: Run unref helper for all rows
...
Don't do shortcuts. Because all rows need to be unreffed.
Introduced in 92929b968b
.
2011-12-16 13:39:43 +01:00
Matthias Clasen
afa945f480
Updates
2011-12-15 23:59:36 -05:00
Matthias Clasen
7f5a665b95
Fix more linking fallout
...
We are using xinput and gmodule API in a few places in libgtk.
https://bugzilla.gnome.org/show_bug.cgi?id=665326
2011-12-15 23:35:06 -05:00
Matthias Clasen
cea35016db
Add missing symbols to the docs
2011-12-15 23:09:23 -05:00
Matthias Clasen
89c8c1f8a8
Doc format fixes
2011-12-15 23:09:10 -05:00
Matthias Clasen
9cdeaaab30
Remove some accidental additions
...
These functions were never actually implemented
2011-12-15 23:03:12 -05:00
Matthias Clasen
8b60bc9d24
Cosmetic change
2011-12-15 23:03:12 -05:00
Matthias Clasen
2f25ab2b22
Doc typo fix
2011-12-15 23:03:12 -05:00
Matthias Clasen
a26afb6aab
Add new symbols
2011-12-15 23:03:12 -05:00
Matthias Clasen
55f1799b96
Doc typo fix
2011-12-15 23:03:12 -05:00
Matthias Clasen
ba59b9c4f9
Cosmetic changes
2011-12-15 23:03:12 -05:00
Benjamin Otte
f8426cd706
gtk-demo: Fix warnings in changedisplay
...
Use the brute force fix. I'm not really interested in fixing this
properly.
2011-12-16 04:53:17 +01:00
Benjamin Otte
c0fdcbf513
a11y: Remove unused gtk_cell_accessible_set_cell_data()
2011-12-16 04:53:17 +01:00
Benjamin Otte
b8b8ba8ed9
a11y: Make boolean cell render report its states the new way
2011-12-16 04:53:17 +01:00
Benjamin Otte
64aa203773
a11y: Refactor treeview code even more
...
- Split out set_cell_data()
- Use it
- Get rid of update_cell_value() function, it's now just 2 calls
2011-12-16 04:53:16 +01:00
Benjamin Otte
eb6465167e
a11y: Redo function signature
...
With the recent changes to gtk_cell_accessible_update_cache(), the
update_cell_value() function now needs less code, too.
2011-12-16 04:53:16 +01:00
Benjamin Otte
4ac501736e
a11y: Implement GtkContainerCellAccessible.update_cache
2011-12-16 04:53:16 +01:00
Benjamin Otte
118bc610f6
a11y: Move update_cache to GtkCellAccesible
...
This way, we can call it for container renderers, too.
2011-12-16 04:53:16 +01:00
Benjamin Otte
2e7fcc24ac
a11y: Redo cell update function
...
1) always emit signals
Previously, newly constructed cells would be told to not emit events.
However, we can ensure that nothing is connected to the signals, so
they will not actually emit anything.
2) don't return anything
The return value is unused anyway.
2011-12-16 04:53:16 +01:00
Benjamin Otte
5cca6b2dc2
a11y: Remove unused function
2011-12-16 04:53:16 +01:00
Benjamin Otte
d2a9220006
a11y: remove now unused property lists
2011-12-16 04:53:16 +01:00
Benjamin Otte
a3f60349ed
a11y: Don't copy data between renderers
...
Now that we don't use custom renderers anymore, we don't need to copy
data between them anymore.
2011-12-16 04:53:16 +01:00
Benjamin Otte
8ac579602c
a11y: Use cell renderer creation funcs unconditionally
...
Also delete the previous "new" functions and actually set the real cell
renderer here.
2011-12-16 04:53:16 +01:00
Benjamin Otte
c5433e852b
gtk: Add accessible types for cell renderers
2011-12-16 04:53:16 +01:00
Benjamin Otte
e5d5863a3f
a11y: Use the accessible type
2011-12-16 04:53:16 +01:00
Benjamin Otte
0470b91add
cellrenderer: Add API to keep the accessible type
...
It's private for now, because we require a GType that isn't exported in
the API yet.
2011-12-16 04:53:16 +01:00
Benjamin Otte
acb73f99bb
API: cellrenderer: Add a private struct
2011-12-16 04:53:15 +01:00
Benjamin Otte
c28f641921
a11y: Add GtkRendererCellAcessible::renderer
2011-12-16 04:53:15 +01:00
Benjamin Otte
dfb82333a3
a11y: Remove unused variable
2011-12-16 04:53:15 +01:00
Benjamin Otte
ccabccc42f
treeview: Send changed signal directly to a11y code
...
No more signal handler is needed, therefore the code can also get rid of
tracking the treemodel. And we use a faster approach for iterating the
changed cellrenderers: We just iterate all columns instead of over all
cell accessibles, as that number is likely quite a bit smaller.
2011-12-16 04:53:15 +01:00
Benjamin Otte
070124b0a5
tests: Add test resetting the model
...
We first set a NULL model and then reset the old model, just to get the
effect of clearing and then resetting.
We reset the cursor and selection afterwards, so the reset doesn't
destroy all the work we did.
2011-12-16 04:53:15 +01:00
Benjamin Otte
f5621a3a8e
treeview: Emit cursor-changed signal when new model is set
2011-12-16 04:53:15 +01:00
Benjamin Otte
c9c7e91db9
a11y: Improve treeview's add/remove_selection()
2011-12-16 04:53:15 +01:00
Benjamin Otte
dc8f5effd4
a11y: Improve get_selected_rows()
2011-12-16 04:53:15 +01:00
Benjamin Otte
20b56689c5
a11y: Improve table_is_row_selected()
2011-12-16 04:53:15 +01:00
Benjamin Otte
3112679a5e
treeview: Signal selection changes to the accessible
...
And another signal gone.
2011-12-16 04:53:15 +01:00
Benjamin Otte
1a3226e2f7
a11y: Emit children-changed properly for treeviews
...
Fixes the patch reverted in b7e74ef95f1d9cd851fb81a124beca0ca11dad00
properly.
https://bugzilla.gnome.org/show_bug.cgi?id=548782
2011-12-16 04:53:15 +01:00
Benjamin Otte
0005d820c7
treeview: Remove unnecessary accessible_expanded()
...
Instead, just call remove_state().
2011-12-16 04:53:15 +01:00
Benjamin Otte
c7b82c2cea
treeview: Add add() function to accessible
...
... and use that to emit the insertion signals.
2011-12-16 04:53:14 +01:00
Benjamin Otte
82a9f6faa0
treeview: Set expandable flag from treeview
...
... instead of trying to update it manually.
2011-12-16 04:53:14 +01:00
Benjamin Otte
9e9533fc88
a11y: Redo cell accessible action handling
...
Multiple changes:
- actions are now available unconditionally, but only work in the right
state. This mirrors other actions.
- instead of adding actions manually, they invoke the action on the
GtkCellAccessibleParent interface.
Tests have been updated to reflect the changes
2011-12-16 04:53:14 +01:00
Benjamin Otte
f840efae96
a11y: Remove "toggle" action from cell renderers
...
This is identical to "edit" (even though that name is kinda confusing).
2011-12-16 04:53:14 +01:00