Matthias Clasen
55b0019589
GtkTooltip: Avoid extra work
...
When we are hiding the label or icon anyway, no need to change
it right before, causing reallocation overhead.
2014-02-20 18:31:10 -05:00
William Jon McCann
0997303378
Don't leak list items of popovers
2014-02-20 16:41:15 -05:00
William Jon McCann
1e87b82048
file-chooser: make accept action sensitive only when has selection
...
https://bugzilla.gnome.org/show_bug.cgi?id=547988
2014-02-20 15:44:47 -05:00
Jasper St. Pierre
ad0c4c3e83
window: Fix configure request debug code in move_resize
...
Make it compile in GTK+3 and switch pos_changed / size_changed
to be the right way around.
2014-02-20 13:55:23 -05:00
Carlos Garnacho
eb0f86d485
popover: Always apply the window shape
...
In practice this shape is only used to outline the popover when it is
above native windows, in the most normal full-csw case the shape won't apply
visibly, so popovers will still be able to cast a shadow there.
If there are native windows below the popover, the shape will exclude the
shadow, so there are no alpha contents above the window. One worst case that
might happen is that the popover lays above patches of native/client-side
windows, so the shadow could come and go around the border. But first let's
see whether that happens often or visibly enough before adding something more
convoluted.
2014-02-20 16:36:34 +01:00
Matthias Clasen
8ea40e4956
Trivial annotation syntax fix
2014-02-20 10:18:45 -05:00
William Jon McCann
bc41268368
print-dialog: remove shadow in from some of the tabs
2014-02-20 09:19:31 -05:00
Benjamin Otte
b9e37f8d2d
revealer: Allocate extra size to child
...
Do not constrain the child widget to its preferred size when the
revealer is larger.
https://bugzilla.gnome.org/show_bug.cgi?id=724742
2014-02-20 02:10:07 +01:00
Benjamin Otte
1d422deb0f
stackswitcher: Don't do unneeded update
...
The update of the needs-attention state is done via its own property,
so it doesn't need to be done via visibility changes.
This patch is largely the result of inspecting the code due to a warning
and not a result of testing. So if issues pop up that bisect back to
this patch, that's why.
2014-02-20 02:10:07 +01:00
Benjamin Otte
f2d4b07f4b
stylecascade: Remove function
...
Inline it.
2014-02-20 02:10:07 +01:00
Benjamin Otte
6de50aa7d9
settings: Store style cascade in settings object
...
This ensures that the initialization for the CSS theme happens when the
style cascade gets queried.
https://bugzilla.redhat.com/show_bug.cgi?id=1064922
https://bugzilla.mozilla.org/show_bug.cgi?id=972382
2014-02-20 02:10:07 +01:00
Matthias Clasen
2a8446bdec
Add docs
2014-02-19 19:39:06 -05:00
William Jon McCann
469d333aa2
docs: use Returns: consistently
...
Instead of Return value:
2014-02-19 18:56:05 -05:00
Matthias Clasen
215c55f2b9
GtkActionBar: Implement destroy
...
Similar to map/unmap, this needs to follow the actual
widget tree. Without this, several test cases in
the templates test fail.
2014-02-19 01:34:19 -05:00
Matthias Clasen
bdaddaabad
Drop unimplemented functions
...
These were added to the header by mistake in a recent commit.
They have no implementation, so dropping them won't cause
any harm.
2014-02-19 01:03:37 -05:00
Matthias Clasen
c5874b1034
Document gtk_header_bar_get_has_subtitle
2014-02-19 01:03:37 -05:00
Matthias Clasen
e79842d64c
Document gtk_widget_get_scale_factor
2014-02-19 01:03:36 -05:00
Matthias Clasen
7fbf6a67a2
Fix a small memory leak
...
GtkPrintUnixDialog was leaking a GFile.
Spotted by Christian Persch in
https://bugzilla.gnome.org/show_bug.cgi?id=724631
2014-02-19 00:31:40 -05:00
Carlos Garnacho
63bb834b2e
popover: Accept NULL relative_to widgets
...
And document the fact that the popover will get destroyed if
a NULL relative-to is given on a parented popover, if no extra
references are kept.
For gtk_popover_new*(), a NULL relative-to will leave the widget
as a floating object, to be sunk by a later call to
gtk_widget_set_relative_to().
https://bugzilla.gnome.org/show_bug.cgi?id=724407
2014-02-19 00:25:34 -05:00
Paolo Borelli
2f379604d1
Do not call popover_set_relative with NULL
...
This gives a critical warning since that function expects a
valid widget.
https://bugzilla.gnome.org/show_bug.cgi?id=724407
2014-02-19 00:25:34 -05:00
Matthias Clasen
479babf339
GtkTextHandle: Deal with parent_scrollable going away
...
Use a weak reference to notice when parent_scrollable is
going away.
https://bugzilla.gnome.org/show_bug.cgi?id=724392
2014-02-19 00:24:30 -05:00
Matthias Clasen
e679812be0
GtkBox: Fix an off-by-one error with center allocation
...
This error was causing children to not get allocated when
the center widget is the first one in the list of the box's
children.
2014-02-18 22:55:45 -05:00
Matthias Clasen
bb4f8d8ce1
Make gtk_box_set_center_widget take NULL
...
It makes sense to allow this, and gtk_action_bar_set_center_widget
already assumes that it can pass NULL to this function.
2014-02-18 22:50:37 -05:00
Matthias Clasen
5eaebde394
Add map/unmap to GtkActionBar
...
The recursion in map needs to follow the actual physical
widget tree, otherwise we violate invariants. The generic
container map implementation uses gtk_container_forall to
operate on the children, and thus is not suitable for
containers where the children are inside some internal
container.
2014-02-18 22:50:37 -05:00
Matthias Clasen
3f0e28133d
Fix up gtk_action_bar_forall
...
We need to always iterate over non-internal children.
2014-02-18 22:50:37 -05:00
Matthias Clasen
53f6b8582a
Revert "action bar: remove the forall implementation"
...
This reverts commit 0ff0fdfefb
.
2014-02-18 22:50:37 -05:00
Paolo Borelli
d3c2819401
Add a GtkFrame inside GtkActionBar
...
This is needed to set a padding and draw a border since GtkBox does
not honour css padding yet.
https://bugzilla.gnome.org/show_bug.cgi?id=724693
2014-02-18 22:50:36 -05:00
Ignacio Casal Quinteiro
0b4cb125e7
Remove duplicated word "id" from warning message
2014-02-18 11:42:45 +01:00
Matthias Clasen
d308f39268
Make GtkSeparatorToolItem work for window-dragging again
...
This broke recently when the window dragging code was changed
to require motion events to be propagated as well.
https://bugzilla.gnome.org/show_bug.cgi?id=724539
2014-02-17 23:55:53 -05:00
Matthias Clasen
62254456f7
GtkLabel: don't eat too many button release events
...
We should only eat button release events when the label is
actually selectable, since the comment indicates that we
want to eat the release events belonging to press events
that triggered a selection. This fixes problems with actions
on parent widgets that are triggered by button release,
as seen in this bug:
https://bugzilla.gnome.org/show_bug.cgi?id=724541
2014-02-17 23:09:44 -05:00
Matthias Clasen
885026851f
Another trivial doc rewording
2014-02-17 22:38:24 -05:00
Matthias Clasen
99bc982bd8
Trivial typo fix
2014-02-17 22:38:24 -05:00
Matthias Clasen
67a00991b7
tree view: clean up custom search entry on destroy
...
Suprisingly, this bug has been there for a very long time.
I'm fixing it now because we now use a custom search entry
in the app chooser dialog, and this is causing the templates
cleanup test to fail.
2014-02-17 21:41:11 -05:00
Matthias Clasen
2392b1e534
Make print dialog destruction work
...
This was also causing the templates test to fail.
2014-02-17 21:40:36 -05:00
Matthias Clasen
0ff0fdfefb
action bar: remove the forall implementation
...
With nested internal children, this interferes with proper
cleanup, and makes the templates test fail.
2014-02-17 21:39:44 -05:00
Paolo Borelli
ad9019c2c9
gtkbox: fix positioning of center widget
2014-02-17 23:23:04 +01:00
Matthias Clasen
e734b79fd8
Fix return_if_fail lines in gtk_box_pack
...
Since the function now returns a value, these checks
need to be updated.
2014-02-17 11:55:56 -05:00
Paolo Borelli
b63ecf8b1a
Add builder support for GtkBox center widget
2014-02-17 14:05:36 +01:00
Matthias Clasen
11834ebf5c
app chooser: Reword a label
...
'Find New Applications' is shorter and less cryptic than 'Find
Applications in Software'.
2014-02-17 06:56:00 -05:00
Matthias Clasen
72e2094472
Drop with_separators from gtk_popover_bind_model
...
The with_separators argument does not really make sense
for popovers, it was just copied from the menu implementation.
Drop it now, before it becomes part of the public API.
2014-02-17 06:52:38 -05:00
Juan R. García Blanco
f3c9f86d14
popover: Make gtk_popover_bind_model() public
...
This is needed for the C++ bindings.
https://bugzilla.gnome.org/show_bug.cgi?id=724503
2014-02-17 06:52:23 -05:00
Matthias Clasen
8bfa5e4611
Drop GtkCenterBox
...
Its functionality has been subsumed in GtkBox.
2014-02-16 23:05:21 -05:00
Matthias Clasen
ef565e2713
action bar: Use a regular box instead of GtkCenterBox
...
GtkBox now supports a centered child, so GtkCenterBox is
no longer needed here.
2014-02-16 23:02:54 -05:00
Matthias Clasen
06716a6c79
Add center widget support to GtkBox
...
This makes GtkCenterBox unnecessary, and at the same time
adds more features: the center widget can be expanded, and
baseline alignment is supported.
2014-02-16 22:57:24 -05:00
Matthias Clasen
8bd94a9515
Fix a problem with window dragging
...
Dragging windows was not working on widgets in the titlebar
region unless they had the window-dragging style property
set. Fix this by looking at the region for motion notify
events as well as for buton press events.
2014-02-15 20:41:58 -05:00
Matthias Clasen
3c981d23dc
Don't show an empty license tab
...
It is not useful to show a license tab, if there's no license
to read. This was pointed out as a possibility in
https://bugzilla.gnome.org/show_bug.cgi?id=724411
2014-02-15 18:07:09 -05:00
Matthias Clasen
c779b42476
Docs: use // for comments in examples
...
Without sgml mode, we can't escape /* as /* anymore,
so just switch to // for comments in examples.
2014-02-14 23:34:22 -05:00
Matthias Clasen
e179c65da0
header bar: squeeze the title in
...
Let the center widget extend into the border area, to avoid
resizing header bars needlessly. This improves the uniformity
of header bars across applications, some of which don't use
subtitles, or use custom title widgets.
https://bugzilla.gnome.org/show_bug.cgi?id=706515
https://bugzilla.gnome.org/show_bug.cgi?id=707999
2014-02-14 15:39:08 -05:00
Matthias Clasen
4a208439e6
Raleigh: fix a typo
...
titlebar is a style class, so it needs a .
2014-02-14 15:33:47 -05:00
Matthias Clasen
c1def9c224
Forgotten file
2014-02-14 15:33:26 -05:00