AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity
57,650 Commits 969 Branches 749 Tags 504 MiB
5530331b35
Commit Graph

32146 Commits

Author SHA1 Message Date
Matthias Clasen
7a06859f38 Adwaita: Give model buttons visible focus 
Hard to use keynav, otherwise.  Also, hard
to debug focus issues if you can't see where
the focus is.
 2019-04-29 15:21:40 -04:00
Matthias Clasen
89861faa04 Merge branch 'tooltip-cleanup' into 'master' 
tooltip: Remove an unused gdk_surface_get_root_coords call

See merge request GNOME/gtk!793
 2019-04-29 19:04:49 +00:00
Benjamin Otte
5fd94e2027 Merge branch 'window-cursor' into 'master' 
window: Set cursor on the right surface

See merge request GNOME/gtk!792
 2019-04-29 19:02:21 +00:00
Matthias Clasen
0023b9036b tooltip: Remove an unused gdk_surface_get_root_coords call 
The tx and ty variables are not used, so don't
bother setting them.
 2019-04-29 14:56:00 -04:00
Matthias Clasen
89d1f8c3ca window: Set cursor on the right surface 
Set the cursor on the surface of the target
widget, not the surface of some of its parents.

This does not make a difference currently.
But it will in the future, when we have
parented widgets with surfaces.
 2019-04-29 14:51:55 -04:00
Matthias Clasen
7d9364655d icon view accessible: Stop presenting windows 
Thats really not its business.
 2019-04-29 14:46:40 -04:00
Jakub Steiner
6fbf13965c Adwaita: tone down lowres icon aid 
Fixes https://gitlab.gnome.org/GNOME/gtk/issues/1818
 2019-04-29 15:08:49 +02:00
Matthias Clasen
92e21c3f1c Drop the can-default property 
It was added at a time when default buttons
had a very large external border that would disrupt
aligment. Not a problem nowadays.
 2019-04-28 23:28:39 +00:00
Matthias Clasen
8880d27460 inspector: Stop showing default widget in misc 
This is just a regular window property now,
no need for special casing.
 2019-04-28 23:23:11 +00:00
Matthias Clasen
59d50be737 widget: Drop gtk_widget_grab_default 
The default widget is mostly a dialog concept,
and does not really need this generic api.

If you need to mark a widget as default,
use gtk_window_set_default() directly.
 2019-04-28 23:23:11 +00:00
Matthias Clasen
6d73443131 widget: Remove special handling for has-default 
We used to handle has-default specially in ui
files. It was awkward, so stop doing that. If you
need to influence the default widget in a window,
you can just set the default-widget property.
 2019-04-28 23:23:11 +00:00
Matthias Clasen
89f7b974f2 Stop using gtk_widget_grab_default 
Replace gtk_widget_grab_default by gtk_window_set_default_widget.
 2019-04-28 23:21:51 +00:00
Matthias Clasen
0ae958d45b Drop gtk_window_activate_default 
This api has been replaced by an action that
can be activated with gtk_widget_activate_action.
 2019-04-28 23:21:50 +00:00
Matthias Clasen
3d1fdf77dc file chooser: Stop using gtk_window_activate_default 
Instead, use the new way of activating default.

I think most of the default handling in
GtkFileChooserDialog should be dropped, but
for now this keeps things working.
 2019-04-28 23:20:13 +00:00
Matthias Clasen
0ae71cacb4 mount operation: Handle default activation via action 
Switch to the new way of activating default.
 2019-04-28 23:20:13 +00:00
Matthias Clasen
218d635ca2 entry: Activate default via action 
Switch to the new way of activating default.
 2019-04-28 23:20:13 +00:00
Matthias Clasen
7553d0c471 label: Activate default via action 
Switch to the new way of activating default.
 2019-04-28 23:20:13 +00:00
Matthias Clasen
f4880f5df5 Add gtk_widget_activate_default 
This is a convenience wrapper for
activating the "default.activate" action.
 2019-04-28 23:20:13 +00:00
Matthias Clasen
3ccdad76de popover: Add a default.activate action 
This is a first example of a widget intercepting
the default.activate for its own handling.
 2019-04-28 23:20:13 +00:00
Matthias Clasen
e464c08545 window: Add a default.activate action 
Activating this action will replace other
activate_default apis. It is more flexible,
since intermediate widgets can intercept the
action and do their own handling.
 2019-04-28 23:20:13 +00:00
Matthias Clasen
56e95ddfc8 popover: Add a default-widget property 
This is part of redoing default widget handling.
 2019-04-28 23:20:13 +00:00
Matthias Clasen
65052a5d6c Rename gtk_window_set_default 
Call it gtk_window_set_default_widget, to match
the getter, and the property name. Update all
callers.
 2019-04-28 23:20:13 +00:00
Matthias Clasen
1364eb2f62 window: Add a default-widget property 
This is a part of redoing default widget handling.
 2019-04-28 23:20:13 +00:00
Matthias Clasen
aa8ada3fed widget: Add a convenience api to activate actions 
Since actions are used increasingly, we should
have a convenient way to trigger an action in
the context of a widget.
 2019-04-28 23:19:05 +00:00
Matthias Clasen
3643a9fe86 Merge branch 'focus-cleanup' into 'master' 
Focus cleanup

See merge request GNOME/gtk!788
 2019-04-28 23:17:46 +00:00
Matthias Clasen
25f4bb2e17 Avoid critical warnings 
These critical warnings break the tests, otherwise.
 2019-04-28 22:55:43 +00:00
Matthias Clasen
3b62d9c027 Drop gtk_window_activate_focus 
This api wasn't used anywhere in GTK. And since
we've dropped the variant for the default widget,
this one should go too. If it is needed, it should
become and action too.
 2019-04-28 22:21:09 +00:00
Matthias Clasen
c92938b378 widget: Remove special handling of has-focus 
We used to handle has-focus in ui files specially.
It was awkward, so stop doing that. If you need
to influence the initial focus of a window, you
can just set the focus-widget property.
 2019-04-28 22:21:03 +00:00
Matthias Clasen
c98313016e window: Fix up the buildable implementation 
We were assuming that the parent class has a custom
set_property, which may not be the case. Be more
careful.
 2019-04-28 22:20:55 +00:00
Matthias Clasen
b6c1786165 inspector: Make property list sortable again 
We lost this when moving from a treeview to
a listbox. Bring it back, with homegrown list
headers.
 2019-04-28 21:56:10 +00:00
Matthias Clasen
ff604e1906 file chooser: Stay focused 
When hitting Escape in the location entry,
we were not moving the focus anywhere,
causing focus to be NULL, and key bindings
to stop working. The visible effect was
that Ctrl-L / Escape / Ctrl-L would not
get back to the location entry, as expected.

Closes: https://gitlab.gnome.org/GNOME/gtk/issues/1851
 2019-04-28 16:08:21 +00:00
Matthias Clasen
34974a8a66 Merge branch 'wip/baedert/filechooser2' into 'master' 
Assorted filechooser improvements

See merge request GNOME/gtk!783
 2019-04-28 15:33:07 +00:00
Matthias Clasen
b9467a4dc7 file chooser: Prevent accidental search 
When hitting Escape, the file chooser will go
into search mode, because the search entry
consumes the key to emit the ::search-stopped
signal. Recognize this situation and avoid
switching to search mode in this case.

Closes: https://gitlab.gnome.org/GNOME/gtk/issues/1850
 2019-04-28 15:20:07 +00:00
Timm Bäder
5a1c37a8c8 filechooserwidget: Use a center box for the search entry 
This way we can avoid a slight position offset when we show or hide the
spinner during a search.
 2019-04-28 11:30:13 +02:00
Timm Bäder
b75bc8aa64 filechooserwidget: Allow keynav from the treeview to the search entry 2019-04-28 11:27:42 +02:00
Timm Bäder
ed4c08d9b3 window: Check whether the new focus widget is the old one 
We generally do that for all properties.
 2019-04-28 11:27:21 +02:00
Timm Bäder
929cdd9259 treeview: Don't always grab_focus() when moving the cursor 
This doesn't really make sense, we can assume that the treeview already
has the focus when it receives key events.
 2019-04-28 11:26:40 +02:00
Timm Bäder
78049f452a filechooserwidget: Remove unneeded function prototype 2019-04-28 11:08:09 +02:00
Timm Bäder
cf2ef4863b filechooserwidget: Don't focus treeview when searching 
It's just weird that the search entry does not have focus while we type.
 2019-04-28 11:07:14 +02:00
Timm Bäder
2bd348558e filechooserwidget: Remove some GdkEvent usage 2019-04-28 11:05:37 +02:00
Timm Bäder
0f6d83bb5f filechooserbutton: Remove some dead code 2019-04-28 11:02:59 +02:00
Timm Bäder
7e20232607 colorbutton: Remove unneeded snapshot implementation 2019-04-28 10:55:10 +02:00
Timm Bäder
dcc55e3a73 Adwaita: Bring filechooserbutton spacing back 
Add some space between the icons and the text, like there was in gtk3.
 2019-04-28 10:40:54 +02:00
Timm Bäder
59fd48cee0 entry: Fix primary icon allocation in RTL entries 
The primary icon is on the right in RTL, so don't offset the text child
to the right for it.
Fixes the text and icon overlapping in the second entry
in tests/testentryicons
 2019-04-28 08:36:36 +02:00
Timm Bäder
1e16cb088a treeview: Always update expand when allocating columns 
It doesn't make sense to keep track of all the last_* values anymore now
that widgets only get allocated when their size changes anyway.
Remove all the associated (and thus now unused) flags as well.
 2019-04-28 06:54:10 +02:00
Timm Bäder
f4cf43359d treeview: Remove a useless check 2019-04-28 06:50:57 +02:00
Timm Bäder
6c8a5f5e2f treeview: Remove unused member 2019-04-28 06:45:33 +02:00
Matthias Clasen
936aba884a Merge branch 'file-chooser-search' into 'master' 
file chooser: Fix Ctrl-L

Closes #1829

See merge request GNOME/gtk!781
 2019-04-27 17:52:02 +00:00
Matthias Clasen
eea1388cf4 file chooser: Fix Ctrl-L 
We were forwarding key events to the search entry
and unconditionally considered search started
afterwards. That is not correct, since things
like a Ctrl key press should not trigger search.
Fix this by only switching to search mode when
the event was actually consumed.

Closes: https://gitlab.gnome.org/GNOME/gtk/issues/1829
 2019-04-27 17:43:59 +00:00
Matthias Clasen
6277f2fccc fontchooser: Fix type-to-search 
The key capture was interfering with other
entries in the dialog, so be smarter about
when we want to capture keys and when we
don't.

Closes: https://gitlab.gnome.org/GNOME/gtk/issues/1842
 2019-04-27 15:59:45 +00:00
Timm Bäder
cc4b3798e5 searchentry: Always measure and allocate icon 
Just measuring it (so the warning goes away) but then not using the
values will later underallocate the text widget.
Instead, always reserve space for the icon (which will inevitable be
visible as soon as the searchentry is actually being used).

Fixes #1831
 2019-04-27 08:40:33 +02:00
Timm Bäder
8634a51aa5 Adwaita: separate '.view text' from textview>text 
The first rule breaks GtkText inside GtkSearchEntry inside something
that has .view applied, as found in the file chooser when searching.
 2019-04-27 08:40:33 +02:00
Timm Bäder
4bb6e70d01 tooltip: Initialize tooltip coords to given event coords 
Otherwise the coordinates passed to the query-tooltip signal are always
0.
 2019-04-26 18:05:32 +02:00
Matthias Clasen
2bd9b42479 Merge branch 'wip/surface-transform-data' into 'master' 
Surface transform listener fixes

See merge request GNOME/gtk!776
 2019-04-25 16:42:42 +00:00
Jonas Ådahl
3a1ef7aa2c widget: Move surface relative transform fields into its own struct 
The purpose being to reduce the size of GtkWidgetPrivate. What is left
is a pointer to the allocated struct.
 2019-04-25 16:02:19 +02:00
Jonas Ådahl
1ad406e15d widget: Remove leftover parent-changed handler removal 
It was never added, as the listener was replaced by explicit code in
gtk_widget_(un)root(), but the removal code was left in place in error.
 2019-04-25 14:29:19 +02:00
Matthias Clasen
b9770fa752 widget: Drop gtk_widget_set_parent_surface 
And the getter, too. Widgets no longer have
extra surfaces that could serve as parent surfaces.
 2019-04-24 20:57:09 -04:00
Matthias Clasen
52d4bcf1be popover: Stop using gtk_widget_get_parent_surface 
We can just use the surface of the parent.
 2019-04-24 20:57:09 -04:00
Matthias Clasen
33f034d0d7 a11y: Stop using gtk_widget_get_parent_surface 
We can just use the surface of the parent.
 2019-04-24 20:54:05 -04:00
Matthias Clasen
2516f1142d Merge branch 'wip/widget-position-changed-callbacks' into 'master' 
widget: Add surface relative position changed callback

See merge request GNOME/gtk!760
 2019-04-24 19:26:27 +00:00
Matthias Clasen
ec37e1e462 Merge branch 'fix-and-improve-linked-button-style' into 'master' 
themes: Fix and improve linked button style

Closes #1294

See merge request GNOME/gtk!730
 2019-04-24 19:23:12 +00:00
Matthias Clasen
79180f62d7 Merge branch 'wip/jimmac/type-experiments' into 'master' 
Adwaita: generic type styles

See merge request GNOME/gtk!772
 2019-04-24 19:08:40 +00:00
Jakub Steiner
5cd4ec510d Adwaita: generic type styles 
- try to define a basic typographic structure

See https://gitlab.gnome.org/GNOME/gtk/issues/1808
 2019-04-24 19:23:05 +02:00
Kjell Ahlstedt
c21063e71e csserror: Add G_BEGIN_DECLS and G_END_DECLS 
Necessary when the header file is included in C++ code.

Merge request !773
 2019-04-24 16:32:54 +02:00
Jonas Ådahl
477ad2505b widget: Add surface relative transform changed callback 
Added two new private GtkWidget API:

 * gtk_widget_add_surface_transform_changed_callback()
 * gtk_widget_remove_surface_transform_changed_callback()

The intention is to let the user know when a widget transform relative
to the surface changes. It works by calculating the surface relative
transform during allocation, and notifying the callbacks if it changed
since last time. Each widget adds itself as a listener to its parent
widget, thus will be triggered if a parents surface relative transform
changes.
 2019-04-24 14:26:24 +02:00
Matthias Clasen
491829a2b5 builder-tool: Check canonical names 
Always canonicalize names before comparing.
We were missing properties like left_attach,
since we were comparing them to left-attach.
 2019-04-23 17:30:00 -04:00
Matthias Clasen
28be1c5d3a builder-tool: Fix property check 
Embarrassingly, there was a missing else
causing us to check all packing properties
as object properties, never finding them.
 2019-04-23 21:25:59 +00:00
Timm Bäder
65ff19d149 eventcontrollermotion: Document missing signal parameters 2019-04-23 17:24:51 +02:00
Timm Bäder
3da6e83609 cssprovider: Fix a parameter name mismatch 2019-04-23 17:24:07 +02:00
Matthias Clasen
c91371951a window: Remove dropped api from headers 
This was forgotten in fed2db1493.
 2019-04-23 01:23:01 +00:00
Matthias Clasen
fed2db1493 window: Drop some x11-specific apis 
The skip-taskbar, skip-pager and urgency hints were
only ever implemented for X11, and are not very useful
with modern desktops. Relegate the functionality to
x11 backend api, and drop the GtkWindow api.
 2019-04-20 02:28:46 +00:00
Matthias Clasen
77ff83cdd1 Fix a compiler warning 2019-04-19 13:58:52 -04:00
Matthias Clasen
0e26e95b00 window: Fix an oversight 
We must still reset cursors.
 2019-04-18 20:15:39 +00:00
Matthias Clasen
ba1c5cf43f Merge branch 'cursor-things' into 'master' 
Cursor things

See merge request GNOME/gtk!764
 2019-04-18 19:38:56 +00:00
Matthias Clasen
f3821031e0 window: Stop juggling cursors 
We have convenience api for this.
 2019-04-18 15:07:01 -04:00
Matthias Clasen
e37f4d0ea6 text: Stop juggling cursors 
We have a convenience api for this.
 2019-04-18 15:06:35 -04:00
Matthias Clasen
b26087845d label: Stop juggling cursors 
We have a convenience api for this.
 2019-04-18 15:06:09 -04:00
Matthias Clasen
8727b0708e css: Kerning affects text size 
Thats the point. And we were missing the proper
flags to make GTK do the right thing when
changing font-kerning in the inspector.
 2019-04-18 18:08:10 +00:00
Matthias Clasen
1932a50d36 css: Some updates to internal docs 
Minor corrections to the AFFECTS flags docs.
 2019-04-18 18:04:58 +00:00
Matthias Clasen
8400d8e75d css: Letterspacing affects text size 
It does. And we were missing the proper
flags to make GTK do the right thing when
changing letter-spacing in the inspector.
 2019-04-18 17:34:44 +00:00
Benjamin Otte
83696639a7 themes: Regenerate CSS 
Seems to have been forgotten a few times.
 2019-04-18 02:28:15 +02:00
Benjamin Otte
1aa1610611 cssprovider: Export correct API 
gtk_css_provider_get_named() is the old GTK3 style API to load themes.

Instead, export the function we currently use,
gtk_css_provider_load_named().

As a side effect we allow people to load a theme as often as they want
without conflicting with GTK's theme.
 2019-04-18 02:26:04 +02:00
Matthias Clasen
0c87b62251 Survive absence of librsvg without criticals 
We can't guarantee that we can load svgs, so
we shouldn't spew criticals when some of our
own resources fail to load due to that reason.
 2019-04-18 00:14:00 +00:00
Matthias Clasen
69f12ed6a5 Avoid a crash without librsvg 
gtk_css_image_recolor_load_texture may leave
recolor->text as NULL without setting error.
No need to crash for that.
 2019-04-18 00:13:53 +00:00
Matthias Clasen
a8db330341 HighContrast: Fix a typo 
The new css parser complains about an unknown pseudo-class
here.
 2019-04-18 00:13:48 +00:00
Matthias Clasen
2681f7c7af textview: Refine touch popup 
The touch popup was meant to have linked buttons.
 2019-04-17 23:40:32 +00:00
Matthias Clasen
836b5a217a text: Refine the touch popup 
The touch popup was meant to have linked buttons.
 2019-04-17 23:40:26 +00:00
Matthias Clasen
802c426d89 Add a png version of process-working-symbolic 
Otherwise, we get a spinning missing-image without
librsvg.
 2019-04-17 22:27:19 +00:00
Benjamin Otte
4ce217b1a5 Merge branch 'wip/otte/warnings' into 'master' 
Add more gcc error flags

See merge request GNOME/gtk!537
 2019-04-17 16:51:06 +00:00
Matthias Clasen
33eb72a69b dialog: Fix a doc typo 2019-04-16 21:13:40 -04:00
Matthias Clasen
21be06310c builder-tool: Tweak --help output 2019-04-16 21:13:16 -04:00
Timm Bäder
1ee5c2cac4 grid: Fix annotation typo 2019-04-16 07:20:13 -04:00
Benjamin Otte
b9fb2f0933 Add missing G_GNUC_FALLTHROUGH statements 2019-04-15 14:40:25 +02:00
Benjamin Otte
0791924bf7 Convert fallthrough comments to G_GNUC_FALLTHROUGH 
This way it's very obvious that fallthrough is indeed what we want.

Also bump the glib requirement to 2.59 which introduced
G_GNUC_FALLTHROUGH.
 2019-04-15 14:40:25 +02:00
Benjamin Otte
90870194ff filechoosernativewin32: Add missing break statement 2019-04-15 14:38:23 +02:00
Benjamin Otte
c593f86ac6 notebook: Add missing return statement 
Previously, the code would just fall thrrough and repeat an operation it
had tried before, but that seems quite unnecessary.
 2019-04-15 14:38:23 +02:00
Benjamin Otte
ad3ded7ba0 textview: Add missing break statement 2019-04-15 14:38:23 +02:00
Benjamin Otte
8ad38e5ae5 menu: Remove unused function parameter 
The parameter was only ever set to TRUE.

And to make matters even more fun, the function didn't ever look
at the parameter.
 2019-04-15 14:38:23 +02:00
Benjamin Otte
0cd2946676 menu: Move enum into only source file using it 2019-04-15 14:38:23 +02:00
Benjamin Otte
5473d13470 menu: remove bottom attach 
bottom attach is top attach + 1, so use that everywhere
 2019-04-15 14:38:23 +02:00