AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity
67,478 Commits 969 Branches 749 Tags 504 MiB
598e1304f6
Commit Graph

37449 Commits

Author SHA1 Message Date
Matthias Clasen
617d12fd77 Merge branch 'sophie-h/gtk-nullables-2' 
Merge Sophie's nullable annotations, with some documentation
fixups on top.
 2020-11-30 23:43:44 -05:00
Matthias Clasen
837f398a9b columnviewcolumn: Improve docs 
Mention what setting sorter to NULL means.
 2020-11-30 23:40:03 -05:00
Matthias Clasen
e18211deca centerlayout: Improve docs 
Explain what passing NULL does.
 2020-11-30 23:36:23 -05:00
Matthias Clasen
365afa381a Merge branch 'arnaudb/annotate-set-title' into 'master' 
Add "nullable" annotation.

See merge request GNOME/gtk!2895
 2020-11-30 21:14:28 +00:00
Matthias Clasen
39f0c48eb2 Apply 1 suggestion(s) to 1 file(s) 2020-11-30 17:44:30 +00:00
Matthias Clasen
7d24e1405e Apply 1 suggestion(s) to 1 file(s) 2020-11-30 17:42:39 +00:00
Matthias Clasen
f309fa21c9 build: Use link_whole for linking our convenience libs 
Without this, we lose exported symbols from e.g. libgsk
that are not used elsewhere in the code.
 2020-11-30 09:56:55 -05:00
Timm Bäder
dc13ff97e2 modelbutton: Reset active menu item on pointer leave 
We don't want to leave an active menu item behind if the pointer doesn't
enter another menu item.
This matches the old GtkMenu behavior
 2020-11-30 09:23:03 -05:00
Timm Bäder
af28237569 popovermenu: Connect to right controller signal 
leave is emitted before the new contains-pointer value is set, so the
signal handler wasn't working right.
 2020-11-30 09:22:57 -05:00
Timm Bäder
ff8de0a93f eventcontrollermotion: Notify by pspec 2020-11-30 09:22:49 -05:00
Timm Bäder
aefabcc056 popovermenu: Pull variable declaration in closest scope 2020-11-30 09:22:41 -05:00
Timm Bäder
1d6c6fc3b8 shortcutcontroller: Separate trigger/action early returns 
We take this early return in update_accel over 36k times when starting
the widget factory and always because the action is not a named action.
 2020-11-30 09:22:34 -05:00
Timm Bäder
8645773fc6 shortcutcontroller: Pass the muxer to update_accel() 
We only needed the widget to get its action muxer. And this way we don't
have to call gtk_widget_get_action_muxer() dozens of times, just once in
set_widget().
 2020-11-30 09:22:29 -05:00
Timm Bäder
d663909159 shortcutcontroller: Use priv->shortcuts directly in set_widget() 
Instead of treating the shortcut controller itself as a GListModel,
which just passes everything along from priv->shortcuts.
 2020-11-30 09:22:21 -05:00
Timm Bäder
e3ff92bc87 shortcutcontroller: Save signal handler ID 
gtk_shortcut_controller_finalize() used to take ~13.8% when closing the
complex listbox demo in gtk4-demo. Now it takes nothing.
 2020-11-30 09:21:57 -05:00
Timm Bäder
2d43ecf8ca widget: root child before emitting child observer signals 
Try to avoid the childen_observer signal handlers screwing up internal
state.

Fixes #3364
 2020-11-30 09:21:52 -05:00
Timm Bäder
5f4beb711f widgetprivate: Remove unused function 2020-11-30 09:21:42 -05:00
Matthias Clasen
8cf4ce5d9e Merge branch 'ebassi/cell-renderer-get-size' into 'master' 
Remove GtkCellRendererClass.get_size()

See merge request GNOME/gtk!2896
 2020-11-30 14:09:03 +00:00
Emmanuele Bassi
09b6c37e1d Merge branch 'ebassi/for-master' into 'master' 
Blend nodes might have NULL top/bottom nodes

See merge request GNOME/gtk!2891
 2020-11-30 13:10:25 +00:00
Emmanuele Bassi
60a7830ba5 Remove GtkCellRendererClass.get_size() 
The get_size() vfuncs is deprecated in GTK3, and only used as a
fallback path for cell renderers that do not implement preferred
size virtual functions.
 2020-11-28 19:21:24 +00:00
Emmanuele Bassi
ac473282a2 Port CellRendererGraph to preferred size vfuncs 
Drop use of GtkCellRendererClass.get_size()
 2020-11-28 19:21:24 +00:00
Emmanuele Bassi
20f9e0f144 Port GtkCellRendererProgress to preferred size vfuncs 
Drop the use of GtkCellRendererClass.get_size()
 2020-11-28 19:21:24 +00:00
Emmanuele Bassi
71a9e5d8c2 Port GtkCellRendererToggle to preferred size vfuncs 
Drop the use of GtkCellRendererClass.get_size()
 2020-11-28 19:21:24 +00:00
Emmanuele Bassi
a605fcc2bd Port GtkCellRendererSpinner to preferred size vfuncs 
Drop the use of GtkCellRendererClass.get_size()
 2020-11-28 19:21:23 +00:00
Emmanuele Bassi
3eaebf1e0b Port GtkCellRendererPixbuf to preferred size vfuncs 
Drop the GtkCellRendererClass.get_size() override.
 2020-11-28 19:21:23 +00:00
Arnaud Bonatti
55ce61d1a8 Add "nullable" annotation. 2020-11-28 12:15:38 +01:00
Jakub Steiner
bbbcc72460 Adwaita,HC: use dark prelights 
- increase :hover visibility by going darker rather than lighter
  puppies died.

Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3380
 2020-11-27 18:17:12 +01:00
Emmanuele Bassi
247fc2e471 Blend nodes might have NULL top/bottom nodes 
We have code in place to handle a NULL node in the state when dealing
with blend nodes, but we don't always check for NULL, which leads to
warnings in the CSS Blend modes demo.
 2020-11-26 00:21:11 +00:00
Matthias Clasen
9d2ca90b4c popover: Fix a typo 
s/Wether/Whether/

Fixes #3393
 2020-11-25 13:59:16 -05:00
Emmanuele Bassi
16b5a88097 a11y: Check before disconnecting Text signals 
Use the same initial check for the accessible object type that we use
when connecting the signal, in case we try to disconnect signals on
different widgets. Additionally, check before accessing data that might
have already been removed.

Fixes: #3403
 2020-11-25 18:15:04 +00:00
Emmanuele Bassi
fdf2e046c3 a11y: Check before disconnecting selection signals 
If the selection data has already been cleared we should just bail out.

Fixes: #3404
 2020-11-25 18:13:54 +00:00
Jakub Steiner
399b457f54 Adwaita: darker selected menuitem + sidebars 
- without sacrificing the fg/bg contrast too much, increase
  selected item visibility

Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3390
 2020-11-25 14:28:19 +01:00
Sophie Herold
fed734edfc Fix some nullable return annotations 2 2020-11-24 19:27:33 +01:00
Christian Hergert
1e994419ee textview: fix precondition assertions 
It is a programmer error to call this with a child widget that has not
been placed within the GtkTextView.

Fixes #3386
 2020-11-24 08:29:52 -08:00
Matthias Clasen
b75b359f19 Drop devel styling from our windows 
We are about to do a stable release. Time to get used
again to plain old, boring header bars.
 2020-11-23 12:10:01 -05:00
Emmanuele Bassi
ef86e46238 a11y: Cache the accessibility bus address 
Just check for it once; doing it every time we failed to create an
ATContext is just going to fill up the logs.
 2020-11-23 14:34:46 +00:00
Emmanuele Bassi
0a46baeb56 a11y: Turn critical warnings into debug messages 
The accessibility bus might not be available, and if it isn't the case,
it means something has failed at a level where the user can't do much
about it. There's no need to emit a critical warning.
 2020-11-23 14:34:46 +00:00
Emmanuele Bassi
1f44319588 Drop redundant dependencies 
PangoCairo already depends on Pango; Cairo-gobject already depends on
Cairo.
 2020-11-23 13:04:11 +00:00
Emmanuele Bassi
505478bc59 Drop GLib dependency from GTK's declared dependencies 
We depend on GObject, which already depends on GLib; on older versions
of Meson, this ends up trying to depend on the system copy of GLib,
instead of the sub-project copy, in case the version of GLib we have
installed is too old.
 2020-11-23 12:29:32 +00:00
Emmanuele Bassi
3a1b2083d6 Do not depend on GLib API introduced after 2.66 
To avoid bleeding edge deprecations we use GLIB_VERSION_MIN_REQUIRED and
GLIB_VERSION_MAX_ALLOWED. Since we depend on GLib 2.66, we cannot use
API introduced in 2.67, even when conditionally compiled.
 2020-11-23 12:06:22 +00:00
nana-4
61dcb685b2 Adwaita: Unify sidebar background-color 
The sidebar item style is already unified. The sidebar background-color
should be unified as well.

See https://gitlab.gnome.org/GNOME/gtk/-/issues/3382
 2020-11-23 10:51:58 +01:00
nana-4
bd0d75e237 Adwaita: Make sidebar row styling better 
- Reorder declaration blocks for code legibility.
- Don't lighten text color on :hover and :selected for better contrast.
- Add missing :focus-visible:focus-within styling to non-:selected row.
 2020-11-23 10:51:58 +01:00
nana-4
179fc68355 Adwaita: Fix some sidebar sizing 
- Don't set the sidebar padding twice.
- Add padding to the assistant sidebar directly, as it doesn't have
  .navigation-sidebar internally.
- Set missing margin to the sidebar separator.

See https://gitlab.gnome.org/GNOME/gtk/-/issues/3382
 2020-11-23 10:51:58 +01:00
nana-4
9828756e05 Adwaita: Move placessidebar-specific sizing from .navigation-sidebar 
The common .navigation-sidebar styling should be more generic.
 2020-11-23 10:51:58 +01:00
nana-4
40f2b49c0d Adwaita: Make treeexpander styling generic 
The widget can be used outside .navigation-sidebar.

This also fixes the label misalignment in the widget.
 2020-11-23 10:51:58 +01:00
nana-4
8e81cbef2c stacksidebar: Add missing .navigation-sidebar to the inner list 
Also don't set :show-separators, which is not applied in other sidebars.

See https://gitlab.gnome.org/GNOME/gtk/-/issues/3382
 2020-11-23 10:51:58 +01:00
Bilal Elmoussaoui
46601325f1 properly set ScaleButton's parent_class 
GtkScaleButton doesn't subclass GtkButton anymore
Fixes #3381
 2020-11-23 02:47:12 +01:00
Sophie Herold
1e01b9079d Fix some nullable return annotations 2020-11-21 16:33:40 +01:00
Jakub Steiner
ab163f168d Merge branch 'wip/jimmac/clipped-menu-shadows' into 'master' 
Adwaita: avoid clipping menu shadows

Closes #1987

See merge request GNOME/gtk!2872
 2020-11-20 12:37:49 +00:00
Jakub Steiner
e937f7eac8 Revert "Adwaita: unified sidebar styles" 
Doing the same mistake twice :( Even margin is eating from the container,
not expanding outside of it.

This reverts commit 6be575992f.
 2020-11-20 13:24:23 +01:00