Paolo Borelli
5a471fefdb
Remove unused alignment from GtkTooltip.
2011-12-04 19:20:23 +01:00
Paolo Borelli
7c779a0bee
Plug tiny leak in the css parser
2011-12-03 17:52:24 +01:00
Claudio Saavedra
f9c24e8f03
GtkIconView: fix a memory corruption in the drag-n-drop code
...
You shall free with g_slice_free() what you allocate with
g_slice_new().
https://bugzilla.gnome.org/show_bug.cgi?id=665338
2011-12-01 22:56:43 +01:00
Cosimo Cecchi
58b1f24d6d
image: use the default icon size if no icon size is provided
...
If no icon size is provided (e.g. when setting icon-name or stock-id
using the GObject property directly), use the default icon size. This
matches the previous GtkImage behavior.
2011-11-30 19:47:52 -05:00
Cosimo Cecchi
0c68227270
image: minor cleanup
2011-11-30 19:47:52 -05:00
Paolo Borelli
2ef5844bac
Introduce gtk_render_insertion_cursor
...
The new function provides an API that takes the PangoLayout and index
as input params, this way it handles strong and weak cursors internally
factoring out all code duplicated in the widgets that need to render
cursors.
https://bugzilla.gnome.org/show_bug.cgi?id=640317
2011-12-01 01:22:39 +01:00
Paolo Borelli
3c6842222a
Use the split-cursor setting for textview cursors
...
Explicitely check the split-cursor setting when drawing the textview
insertion cursor instead of relying on the cursor_direction set in the
textlayout. This makes the cursor drawin code more uniform with other
widgets in preparation to refactoring the cursor drawing code in a
shared function.
https://bugzilla.gnome.org/show_bug.cgi?id=640317
2011-12-01 01:22:39 +01:00
Paolo Borelli
0bff1af7a2
Rework GtkTextView cursor code.
...
Move the handling of primary/secondary cursors to gtktextdisplay, which
makes code simpler and more consistent to how GtkLabel and GtkEntry
draw cursors, which is useful in preparation to further refactoring.
https://bugzilla.gnome.org/show_bug.cgi?id=640317
2011-12-01 01:22:39 +01:00
Paolo Borelli
b3f850e6b9
Tiny cleanup.
...
https://bugzilla.gnome.org/show_bug.cgi?id=640317
2011-12-01 01:22:38 +01:00
Paolo Borelli
f18bbdff53
Remove draw_insertion_cursor in label and entry
...
Remove the the draw_insertion_cursor wrapper which just converts from
GtkTextDir to PangoDirection
https://bugzilla.gnome.org/show_bug.cgi?id=640317
2011-12-01 01:22:38 +01:00
Cosimo Cecchi
772459979f
image: simplify code
...
We can unconditionally call into the icon helper methods now that we
removed the g_return_val_if_fail() checks.
2011-11-30 19:06:38 -05:00
Cosimo Cecchi
d47e82ffdd
entry: simplify code
...
We can unconditionally call into the icon helper methods now that we
removed the g_return_val_if_fail() checks.
2011-11-30 19:05:34 -05:00
Cosimo Cecchi
864c5610f8
icon-helper: remove useless checks
...
When we change storage type, we always clear the rest of the object, so
these checks do not add any safety.
2011-11-30 19:04:17 -05:00
Cosimo Cecchi
d300ddc5e4
icon-helper: don't warn out when the icon size is GTK_ICON_SIZE_INVALID
...
We can call ensure_icon_size() for an empty image; don't warn out in
that case, but just return a zero width.
2011-11-30 18:32:01 -05:00
Cosimo Cecchi
e37c55aa3e
icon-helper: don't reset pixel_size when clearing the helper
...
Don't reset the pixel size when clearing the helper; pixel-size is e.g a
property of GtkImage, which is stable unless explicitly set.
2011-11-30 18:15:05 -05:00
Cosimo Cecchi
5224302a30
entry: always prepare the style context when using it for entry icons
...
Make sure to always prepare the entry's style context for the entry icon
style when passing it to GtkIconHelper.
2011-11-30 16:39:59 -05:00
Cosimo Cecchi
126651f889
cellrendererpix: make sure to select the default helper as a fallback
...
If we don't have expander pixbufs, select the default helper to render
the icon, even if the cell is an expander. This mimics what the old code
did.
2011-11-30 16:39:59 -05:00
Cosimo Cecchi
0304cc04d3
cellrendererpix: port to GtkIconHelper
2011-11-30 16:39:59 -05:00
Cosimo Cecchi
a4d6505cb3
entry: port to GtkIconHelper
2011-11-30 16:39:59 -05:00
Cosimo Cecchi
adbfbb7278
dnd: port to GtkIconHelper
2011-11-30 16:39:59 -05:00
Cosimo Cecchi
f085dde830
image: port to GtkIconHelper
...
Use newly introduced GtkIconHelper to render pixbufs in GtkImage.
2011-11-30 16:39:59 -05:00
Cosimo Cecchi
b5d8d2c4a8
icon-helper: add GtkIconHelper private object
...
GtkIconHelper is a helper object to easily obtain a pixbuf from
different icon sources (e.g. a GIcon, an icon name, a stock id, ...).
Code is ported from GtkImage, which will be adapted in the next commit.
2011-11-30 16:39:59 -05:00
Stef Walter
d462f86aad
GtkCssProvider: don't segfault when CSS file is not found
...
* Fix null dereference in gtk_css_provider_take_error()
* And another in gtk_css_provider_emit_error()
https://bugzilla.gnome.org/show_bug.cgi?id=664537
2011-11-30 00:23:07 -05:00
Federico Mena Quintero
830bc4304c
[GtkFileChooserDefault] Don't destroy and re-create the filename entry
...
This is a leftover from the big rework to remove the expanded/collapsed mode
in Save mode.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2011-11-29 15:11:56 -06:00
Federico Mena Quintero
463c98a9d7
[GtkPathBar] Remove unused error argument
...
It used to be that _gtk_path_bar_set_file() would return an error if
it wasn't able to switch to the specified file, but that hasn't been
the case for a long while now, since the file chooser became async.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2011-11-29 15:11:54 -06:00
Paolo Borelli
58d247d7ae
Avoid shadowing a variable
...
Move bg_color variable to an inner scope.
2011-11-29 21:28:30 +01:00
Federico Mena Quintero
7fb00c919e
[path-bar] Add some comments to explain the async recursion on an I/O callback
...
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2011-11-29 14:17:04 -06:00
Federico Mena Quintero
6ce48345ce
[path-bar] Only reset the children's styles if the children actually changed
...
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2011-11-29 14:17:02 -06:00
Federico Mena Quintero
07eb8d6952
Remove unused argument
...
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2011-11-29 14:17:00 -06:00
Benjamin Otte
5317cb1263
filechooserdefault: Don't unref value twice
...
Double unref was introduced in eb02dacb37
https://bugzilla.gnome.org/show_bug.cgi?id=646461
https://bugzilla.gnome.org/show_bug.cgi?id=664137
2011-11-29 20:44:57 +01:00
Benjamin Otte
7d3109a855
treeview: Properly change cursor when row is collapsed
...
Previously, when the cursor was a descendant of the collapsed row,
the cursor path was set to the collapsed row, but this was not
communicated via cursor-changed events.
2011-11-29 20:44:57 +01:00
Benjamin Otte
bbf00265fc
treeview: Reorder code a bit
...
This is mainly in preparation for the next commit, but also to reorder
the code to
1) prepare modification of tree
2) modify tree
3) emit signals
2011-11-29 20:44:57 +01:00
Benjamin Otte
c070e7acf5
treeview: Simplify code
...
Since the changes in commit 2b3de3dd
this simplification is possible.
2011-11-29 20:44:57 +01:00
Benjamin Otte
806dca0677
treeview: Rename function
...
_gtk_tree_view_find_path() was not a name that not really described what
the function does. And I kept forgetting it. Also, it took the tree view
as an argument and that was completely unnecessary.
2011-11-29 20:44:57 +01:00
Cosimo Cecchi
ae60f00ba4
themingengine: fix a typo
2011-11-29 10:52:03 -05:00
Cosimo Cecchi
41b56d87e7
themingengine: move code to make switch-case more clear
...
Code is more readable with the default case as the last one in the
switch block.
2011-11-29 10:52:02 -05:00
Cosimo Cecchi
f7d95b5fe3
pathbar: add the linked style class to GtkPathBar
2011-11-28 14:41:48 -05:00
Cosimo Cecchi
6740121fab
stylecontext: add GTK_STYLE_CLASS_LINKED
...
"linked" is a style class for linked areas, such as a box containing
buttons belonging to the same control.
2011-11-28 14:41:48 -05:00
Javier Jardón
f920d968f6
gtk/gtkeditable: Some docs fixes
2011-11-28 15:23:00 +00:00
Cosimo Cecchi
10cfa90817
spinbutton: redesign to use an horizontal layout
...
Rewrite GtkSpinButton to use a touchscreen friendly horizontal layout.
Other features include:
- support for theming buttons with nth-child
- full support for RTL
- use + and - symbolic icons instead of arrows
- general streamlining and cleanup of a lot of related code
https://bugzilla.gnome.org/show_bug.cgi?id=663359
2011-11-28 09:40:23 -05:00
Alexander Larsson
03b7bb6e29
win32-theme: Make tabs look better
2011-11-28 10:06:38 +01:00
Alexander Larsson
eb44036346
Support border-image in theme_engine_render_frame_gap
...
This is similar to the normal frame rendering, but has a clip
region applied for the gap.
2011-11-28 10:05:29 +01:00
Alexander Larsson
267b51ec98
win32-theme: Add some margins on GtkScale trought to look like win32
2011-11-28 09:14:13 +01:00
Alexander Larsson
21c7e8cf47
win32-theme: Support custom margins in win32 theme parts
2011-11-28 09:13:54 +01:00
Alexander Larsson
7756f49995
Fix up makefile rules for parallel builds
...
The gtkwin32css.h generation code used a temporary filename that was also
used by some other files, which is racy. Use a unique one.
2011-11-28 09:12:28 +01:00
Alexander Larsson
7c092be0ce
win32-theme: Make syntax for mixing theme parts more regular
...
This lets us extend the argument list better
2011-11-28 08:58:41 +01:00
Alexander Larsson
6898ba4f76
win32-theme: Make notebook tabs slightly better
2011-11-25 16:43:51 +01:00
Alexander Larsson
3f206dcd83
win32-theme: Fix background colors for new bg drawing
2011-11-25 16:40:25 +01:00
Alexander Larsson
75642d3af2
css: Always draw the bg color under the bg image
2011-11-25 16:14:20 +01:00
Alexander Larsson
8411f1a279
Implement background-clip and background-origin
2011-11-25 16:14:19 +01:00