Federico Mena Quintero
0ae26b94f2
Remove a NULL-GError that is no longer useful
...
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2013-02-27 18:12:20 -06:00
Federico Mena Quintero
63b9598b51
Don't use inout ints in the drag-action-requested signal
...
It's not friendly to bindings, and we didn't need an inout parameter anyway.
We use a simple return value from the signal handler now.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2013-02-27 14:39:39 -06:00
Federico Mena Quintero
bc38811645
Remove a couple of FIXMEs
2013-02-27 14:17:10 -06:00
Federico Mena Quintero
a7213e3ccf
Disallow drops on the recent:/// item
...
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2013-02-27 14:04:33 -06:00
Federico Mena Quintero
3363974c09
Remove temporary debugging code
...
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2013-02-27 14:04:23 -06:00
Federico Mena Quintero
6d94f8a56c
Don't allow drops in unmounted volumes
...
Unmounted volumes don't have a URI yet, so we can use that to distinguish them
from within the DnD code.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2013-02-27 12:16:31 -06:00
Federico Mena Quintero
dbf98bcfeb
Properly indicate when new bookmarks are being dropped between other bookmarks
...
We weren't handling the drag-URIs-as-bookmarks case in drag_motion_callback().
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2013-02-27 12:08:16 -06:00
Federico Mena Quintero
936045e82b
Merge branch 'master' into places-sidebar
...
Conflicts:
docs/reference/gtk/gtk-docs.sgml
gtk/gtkfilechooserdefault.c
gtk/org.gtk.Settings.FileChooser.gschema.xml
2013-02-13 20:37:36 -06:00
Federico Mena Quintero
04dbec4191
Allow dropping URIs as bookmarks between existing bookmarks
...
The before-drop machinery was already in place; here we implement the actual
dropping.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2013-02-05 14:44:58 -06:00
Federico Mena Quintero
46acb933cd
Remove the accept-uri-drops property
...
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2013-01-29 01:16:09 -06:00
Federico Mena Quintero
fafec940b3
Redo the logic for computing drop positions
...
Instead of having an accept_uri_drops flag, we'll always advertise as accepting URI drops.
However, we'll see if the caller actually handles the drag-action-requested signal. If it
does, we'll indeed allow performing file operations when URIs are dropped. Otherwise,
we'll only allow creating bookmarks from dragged URIs.
Dragging URIs directly into a places item will cause the sidebar to check if the caller
allows file operations. Dragging URIs between places items will cause the sidebar
to create bookmarks for those URIs instead.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2013-01-29 01:14:10 -06:00
Federico Mena Quintero
2a35574067
Whitespace cleanups
2013-01-29 01:02:57 -06:00
Federico Mena Quintero
4bff4b025b
Reset the treeview drag dest row if the drop is not possible
...
This keeps the drop indicator line from 'sticking' if you drag a bookmark above
the Bookmarks heading.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2013-01-25 18:01:42 -06:00
Federico Mena Quintero
f3fb51e96b
Remove TODO items that are done
2013-01-24 18:46:07 -06:00
Federico Mena Quintero
fc9489f381
Use GFile in the DnD signals instead of URIs
...
The rest of the public API works in terms of GFile, so remove this last remnant
of passing URIs around.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2013-01-21 17:59:44 -06:00
Cosimo Cecchi
a8f3465181
Add some missing annotations
2013-01-21 18:23:25 -05:00
Cosimo Cecchi
21a07a5760
Add GObject properties and C getters
2013-01-21 18:21:00 -05:00
Cosimo Cecchi
742a2f11a9
Remove useless style_set override
2013-01-21 18:04:14 -05:00
Cosimo Cecchi
f5b91b9176
Update TODO
2013-01-21 17:49:58 -05:00
Cosimo Cecchi
f59a618db9
Apply custom names to XDG dirs if possible
...
And make it possible to rename them
2013-01-21 17:49:01 -05:00
Cosimo Cecchi
03f220e4c2
Don't add built-in bookmarks twice
2013-01-21 17:49:01 -05:00
Cosimo Cecchi
7fa38fd6fb
Use g_clear_object()
2013-01-21 17:07:12 -05:00
Cosimo Cecchi
a97a5d3049
Don't unconditionally unref potentially NULL objects
...
We already have != NULL checks here, so fold the unrefs inside.
2013-01-21 17:06:42 -05:00
Cosimo Cecchi
0523b2f719
Avoid an useless ref/unref
...
The GMount will be kept alive by the async operation itself.
2013-01-21 17:00:50 -05:00
Cosimo Cecchi
ceb631b60f
Fix a FIXME about using symbolic icons
...
Use g_file_info_get_symbolic_icon() for it.
2013-01-21 16:57:27 -05:00
Cosimo Cecchi
2cf8970f91
Sync from Nautilus commit 463e8d1b1922474e4cf591a3029ea813804bd3e7
...
make sure to always notify when unmounting
2013-01-21 16:48:52 -05:00
Cosimo Cecchi
eea192adaa
Sync from Nautilus commit 480b1daf8814063f348d0f75082353a2f6a3eab3
...
cancel the hostnamed proxy creation on dispose
2013-01-21 16:38:23 -05:00
Federico Mena Quintero
26a5391caa
Add some missing docs for GtkPlacesSidebar
...
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2013-01-18 20:05:00 -06:00
Federico Mena Quintero
52d07c9148
Add toplevel docs for the sidebar
...
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2013-01-18 17:18:25 -06:00
Federico Mena Quintero
4cad0db95a
Add docstrings for the signals
...
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2013-01-11 17:55:36 -06:00
Federico Mena Quintero
306dcd3956
Add missing docstrings to public functions
2013-01-10 20:07:27 -06:00
Federico Mena Quintero
da2e081786
Make the set_location()/get_location() API consistent
...
We used to have set_current_location() and get_selected_location(), with confusing
semantics. Now they are symmetric, with the exception that if set_location() is
called with a location that is not shown in the sidebar, then it will both clear
the selection in the list and make get_selection() return NULL.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2013-01-10 18:12:15 -06:00
Federico Mena Quintero
0b4183234b
New API, gtk_places_sidebar_set_open_flags()
...
This lets us handle the 'Open in new tab' and 'Open in new window' menu items
on our own, and allows callers to have less code to deal with each mode.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2013-01-10 16:19:03 -06:00
Federico Mena Quintero
439a770efa
Use GtkTrashMonitor instead of an API to set the trash state
...
This lets us remove two entry points, gtk_places_sidebar_set_show_trash(),
and gtk_places_sidebar_set_trash_is_full().
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2013-01-10 15:06:01 -06:00
Federico Mena Quintero
ff041608ec
Remove to-do items for Nautilus; they are done now
2013-01-08 16:34:15 -06:00
Federico Mena Quintero
8dd233dfac
New public function to get the selected location from menu item callbacks
...
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2012-12-17 20:05:23 -06:00
Federico Mena Quintero
bfa1f4ac0b
Emit the populate-popup signal so the caller can spice things up
...
Also, we factor out the process of getting the selected item's info out of
the liststore.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2012-12-14 21:44:50 -06:00
Federico Mena Quintero
d0d02357e0
Remove the Properties menu item
...
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2012-12-14 18:15:49 -06:00
Federico Mena Quintero
335ce0edc6
Remove the Empty Trash menu item
...
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2012-12-14 18:08:50 -06:00
Federico Mena Quintero
55927f273d
Remove the multiple-tab/windows-supported APIs
...
We'll have the caller do these instead via the populate-popup signal.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2012-12-14 18:04:30 -06:00
Federico Mena Quintero
fc01ce0756
Rebuild the popup menu every time it is used
...
We'll need to rebuild it every time for the populate-popup signal.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2012-12-14 17:56:53 -06:00
Federico Mena Quintero
e00498fcd8
New signal populate-popup
...
Instead of conditionally creating contextual menu items like 'Show file properties',
we'll instead let the caller populate the popup menu, as is done for GtkEntry.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2012-12-14 11:57:49 -06:00
Federico Mena Quintero
42d239f6d5
Remove gtk_places_sidebar_set_show_cwd(), implement that in the file chooser
...
This removes more idiosyncratic API from the sidebar.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2012-12-11 15:52:17 -06:00
Federico Mena Quintero
c4f40a92ca
Remove the GError from the shortcut-related functions
...
See https://bugzilla.gnome.org/show_bug.cgi?id=650363#c8 and the next comment; this
argument just makes the API harder to use without real benefit.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2012-12-11 15:29:11 -06:00
Federico Mena Quintero
72ce506cfc
Rename signal location-selected to open-location
...
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2012-12-11 12:09:13 -06:00
Federico Mena Quintero
e4d5e66d44
Remove another to-do
2012-12-10 17:28:07 -06:00
Federico Mena Quintero
c26293eacd
Implement the Alt-number quick bookmark shortcuts
...
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2012-12-10 16:00:42 -06:00
Federico Mena Quintero
976672ad4b
Implement the application-side shortcuts in GtkFileChooserDefault
...
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2012-12-10 14:06:07 -06:00
Federico Mena Quintero
e4c70bb691
New machinery to add application-specific shortcuts
...
The file chooser needs them for gtk_file_chooser_add_shortcut_folder() and friends.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2012-12-07 13:42:39 -06:00
Federico Mena Quintero
19001bafaa
One less to-do
...
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2012-12-06 12:11:30 -06:00