Eric Williams
6038474060
Added an additional explanation and code snippet for GtkImageMenuItem.c
...
https://bugzilla.gnome.org/show_bug.cgi?id=752093
2015-07-08 13:53:07 -04:00
Eric Williams
a74a3da745
Added a more meaningful description for /deprecated/gtkimagemenuitem.c
...
https://bugzilla.gnome.org/show_bug.cgi?id=752088
2015-07-08 06:10:00 -04:00
Matthias Clasen
8e53a01188
places sidebar: Fix rows getting 'lost' when dnd fails
...
There was some code that lead to the places sidebar loosing track
of the row being dragged if a motion event came in between letting
go of the button and the drag snap-back animation ending. This would
cause us to not show the row again, giving the appearance that it
was 'lost'.
https://bugzilla.gnome.org/show_bug.cgi?id=751448
2015-07-08 06:10:00 -04:00
Benjamin Otte
0f6c955795
frame: Remove get_path_for_child implementation
...
As far as I can read the code it added the .frame style class to the
GtkFrame element. But GtKFrame already has a .frame style class these
days.
2015-07-08 05:48:59 +02:00
Benjamin Otte
6379a425b0
actionbar: Remove get_path_for_child implementation
...
It wasn't used because CSS walks the widget->parent chain, so it'd only
ever call this func for priv->revealer.
2015-07-08 05:48:59 +02:00
Benjamin Otte
7f8de66c0a
css: text-decoration-style is not inherited
2015-07-08 05:48:59 +02:00
Carlos Soriano
3fb1d1806d
gtksidebarrow: remove unused property
...
The sensitive property was a workaround which commit
3f8982a0cd
fixed.
Just remove it now that is not necessary.
2015-07-07 23:01:47 +02:00
Carlos Soriano
0f935a0483
gtkrevealer: fix preferred width calculation
...
A typo which was using minimum_width for natural_width and viceversa.
2015-07-07 22:49:45 +02:00
Piotr Drąg
d51e8a73cb
Fix a minor typo
2015-07-07 21:51:55 +02:00
Carlos Garnacho
9e2092d306
gtkdnd: Fix introspection annotations in some functions
...
The GdkEvent field is nullable on gtk_drag_begin*, and gtk_drag_cancel()
is a method, like the rest of the DnD API.
2015-07-07 12:50:14 +02:00
Carlos Garnacho
dadb2750b1
gtkdnd: Account for setting a same icon helper
...
g_set_object() will take care of ref'ing before destroying the previous
instance, which might actually be the same pointer.
https://bugzilla.gnome.org/show_bug.cgi?id=751401
2015-07-07 11:24:37 +02:00
Matthias Clasen
826c1db859
file chooser: Add a shortcut to focus the sidebar
...
Alt+P used to do this in the gtk2 filechooser (well, sometimes).
Add this back as a key binding.
https://bugzilla.gnome.org/show_bug.cgi?id=720684
2015-07-07 00:25:22 -04:00
Matthias Clasen
fb316156e2
place sidebar: Make removing bookmarks work again
...
This was accidentally broken in ae8c07c67c
when I
forgot to switch the sense of a condition.
2015-07-06 23:21:51 -04:00
Matthias Clasen
e1211577b3
file chooser: Make delete confirmation match nautilus
...
No need to diverge here.
2015-07-06 23:03:56 -04:00
Matthias Clasen
b96b796a8d
file chooser: Separate out delete and trash
...
We only ever show one of the two context menu items (and we prefer
Move to Trash over Delete). Only use the confirmation dialog when
deleting.
2015-07-06 22:57:40 -04:00
Matthias Clasen
3cbe6d86af
place sidebar: minor change
...
We generally prefer for loops to iterate over lists.
2015-07-06 21:59:10 -04:00
Matthias Clasen
06f9102840
file chooser: Allow rename-to-self
...
When checking for a name clash for renaming, don't complain if the
name is unchanged. That's harmless.
2015-07-06 21:39:39 -04:00
Matthias Clasen
7c9e3df198
wip: reshuffle name checks
2015-07-06 21:35:03 -04:00
Matthias Clasen
88cee9288b
file chooser: Remove unused field
2015-07-06 20:57:11 -04:00
Matthias Clasen
56af2358de
file chooser: Clear search entry when it goes away
...
Keeping the entry contents conflicts with type-to-search.
2015-07-06 20:50:08 -04:00
Paolo Borelli
1eb1481bdf
css: support text-decoration-style
...
The support is limited to underline single, double and wavy, which
is what pango has today.
2015-07-06 20:06:20 +02:00
Carlos Garnacho
3f8982a0cd
gtkdnd: Traverse across insensitive widgets
...
The current widget lookup code bails out on insensitive widgets, there's
however legit cases where we want DnD handled by a parent of the insensitive
widget, so just keep going upwards in that case.
We also use now the widget state flags, because get_sensitive() doesn't
propagate across hierarchies, so we could conceivably find a drop site
inside an insensitive widget.
https://bugzilla.gnome.org/show_bug.cgi?id=751793
2015-07-06 18:19:07 +02:00
Carlos Garnacho
7f57f63eba
gtkwindow: Only allow unrestricted positioning to text handle popovers
...
This behavior has been made optional on add_popover() time, text handles
will keep being able to overflow the window, in order to allow text
selection on views too close to the window edge.
Regular GtkPopovers are reinstaurated to the previous size positioning
logic though, that is, limited by the visible area of the window.
2015-07-06 16:39:06 +02:00
Carlos Garnacho
dec95caf94
scrolledwindow: Keep scrollbars out of GtkScrollable::get_border
...
It looks a bit odd that scrollbars stay over treeview headers and
similar, seems nicer to just avoid the border regions.
https://bugzilla.gnome.org/show_bug.cgi?id=751805
2015-07-06 16:37:31 +02:00
Benjamin Otte
4cbab1180c
cssmatcher: Make nth-child(odd) work on first line
...
.. instead of only on 3rd, 5th, 7th, ...
2015-07-06 15:33:50 +02:00
Benjamin Otte
8d3737e4e3
cssnode: Do finer-grained position invalidation
...
As a side effect, this should fix this bug:
https://bugzilla.gnome.org/show_bug.cgi?id=751910
2015-07-06 15:33:50 +02:00
Benjamin Otte
df7113812b
csstypes: Change NTH_CHILD and NTH_LAST_CHILD change propagation
...
For now assume that if those flags change for a node, they also changed
for all sibling nodes. This is not strictly true but simplifies
invalidation.
The reason it simplifies invalidation is that when removing or adding a
node, we can just invalidate the first node (for NTH_LAST_CHILD) and the
new node (for NTH_CHILD) and all the other nodes will be invalidated
automatically.
2015-07-06 15:33:50 +02:00
Benjamin Otte
69e396ea0a
cssselector: Report finer granularity for position changes
2015-07-06 15:33:50 +02:00
Benjamin Otte
6323010e2e
csstypes: expand GtkCssChange enum
...
Instead of GTK_CSS_CHANGE_POSITION we now have 4 values:
GTK_CSS_CHANGE_FIRST_CHILD, GTK_CSS_CHANGE_LAST_CHILD,
GTK_CSS_CHANGE_NTH_CHILD and GTK_CSS_CHANGE_NTH_LAST_CHILD
Nobody is using them directly yet.
2015-07-06 15:33:50 +02:00
Paolo Borelli
803430a779
pango: make merge_attrs return the merged list
...
This simplifies all the callers
2015-07-06 00:31:56 +02:00
Paolo Borelli
180a378a07
css: add shorthand text-decoration property
...
Note that for now we take into account only text-decoration-line
and text-decoration-color
2015-07-06 00:04:06 +02:00
Paolo Borelli
a57e6731c4
css: support text-decoration-color
2015-07-06 00:04:06 +02:00
Paolo Borelli
77658b76ae
linkbutton: use the text-decoration-line css
...
Remove the custom add() implementation and use css to underline the
label.
2015-07-06 00:04:06 +02:00
Paolo Borelli
384df61c90
css: add support for text-decoration-line
2015-07-06 00:04:06 +02:00
Paolo Borelli
9e26fa9a42
entry: add css letter-spacing
2015-07-06 00:04:06 +02:00
Paolo Borelli
a19331f231
label: add support for CSS letter-spacing property
...
Support letter-spacing CSS property on GtkLabel.
Reftest is included.
2015-07-06 00:04:05 +02:00
Paolo Borelli
b92c530a61
pango: move an utility function from gtklabel
...
This will be used both by gtklabel and gtkentry
2015-07-06 00:04:05 +02:00
Ting-Wei Lan
5436c74a19
Fix return value error in _gtk_file_system_model_get_directory
2015-07-06 03:27:42 +08:00
Matthias Clasen
39822092f4
file chooser: Allow deleting files
...
This is another often requestsed feature for save mode.
Based on a patch by John Beard,
https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-04 23:46:11 -04:00
Matthias Clasen
15617a69aa
file chooser: Allow renaming files
...
This has often been requested as a useful feature in save mode.
Based on a patch by John Beard,
https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-04 22:44:30 -04:00
Matthias Clasen
530d295a2e
Fix up some whitespace mishap
2015-07-04 22:38:30 -04:00
Matthias Clasen
8379ef3067
file chooser: Redo the trailing space warning
...
Redo this slightly differently, so we can keep all the simple
checks in one place. This will make it easier to reuse the code
for file renaming.
2015-07-04 22:38:30 -04:00
Matthias Clasen
8b90c79037
places sidebar: Fix memory handling of rename popover
...
We were freeing the same string twice here, leading to
badness.
2015-07-04 22:38:29 -04:00
Arc Riley
94bcdd3217
Strip leading and trailing whitespace from filechooser save filenames
...
This makes a local copy of the file part of the entry to strip it transparently
Since this is assumed to be a mistake, the user is not notified.
https://bugzilla.gnome.org/show_bug.cgi?id=593372
2015-07-04 19:21:45 -04:00
Arc Riley
02b5ac9ee4
Warn for whitespace at beginning or end of new folder names
...
The warning is not intended to disable the Create button and must only be shown
when the folder is not found, so this is implemented in the folder name exists
callback.
A "name" entry was added to FileExistsData to pass the filename to the callback
https://bugzilla.gnome.org/show_bug.cgi?id=751800
2015-07-04 18:57:13 -04:00
Emmanuele Bassi
d2569a3860
docs: Drop deprecated symbolic icon names
...
Do not suggest using icons that do not exist.
2015-07-04 19:34:23 +01:00
Emmanuele Bassi
c5a250ce37
container: Update the add() warning
...
Now that gtk_widget_reparent() has been deprecated, we should not
suggest it.
2015-07-04 19:34:23 +01:00
Matthias Clasen
309c845e69
file chooser: Make Ctrl-L work in search mode
...
There is no real reason to not allow this. The transition is
not quite as smooth as it should be, currently, but at least
it works.
2015-07-04 00:29:27 -04:00
Matthias Clasen
a453212591
file chooser dialog: Make button not take focus
...
Things work smoother, keynav-wise, if the search button does not
take focus on click.
2015-07-04 00:29:27 -04:00
Matthias Clasen
4dafcf9c8b
file chooser: Make unsetting save entry work
...
Fix an overzealous assertion.
2015-07-04 00:29:27 -04:00