AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity
68,406 Commits 969 Branches 749 Tags 504 MiB
61f709811c
Commit Graph

37840 Commits

Author SHA1 Message Date
Matthias Clasen
102b74f9eb emojichooser: Make keynav work with != 7 columns 
The number of 7 columns was hardcoded in a few places
related to keynav across sections. The flowbox does
not have an api for it, but we can find out anyway
how many columns there are.
 2021-01-25 23:32:08 -05:00
Matthias Clasen
8a0d4dfa94 searchbar: Capture events in the bubble phase 
This is an unfortunate naming clash, but it avoids
an event handling clash between the capture widget
and its children.

Fixes: #3098
 2021-01-25 22:16:29 -05:00
Matthias Clasen
b4e645862a searchbar: Fix documentation mishap 
The css section was inserted between the example
and the sentence referring to it.
 2021-01-25 22:15:56 -05:00
Matthias Clasen
ea48506a32 Merge branch 'simplify-get-module-path' into 'master' 
modules: Simplify _gtk_get_module_path

See merge request GNOME/gtk!3113
 2021-01-26 02:53:38 +00:00
Jan Alexander Steffens (heftig)
23f0a29260
modules: Simplify _gtk_get_module_path 
Remove the bizarre loops.
 2021-01-25 22:47:16 +01:00
Jakub Steiner
23af707b41 Adwaita: make scrollbars larger 
When using scrollbars as active controls, rather than their primary role as indicators,
increase their size as click targets.

Fixes https://gitlab.gnome.org/GNOME/gtk/issues/1886
 2021-01-25 14:15:22 +01:00
Matthias Clasen
344f9fcf05 css: Implement transform-origin 
Implement most of transform-origin. We only
handle the xy components currently, which lets
us reuse the position value implementation that
is used for background-position.
 2021-01-24 22:49:08 -05:00
Matthias Clasen
fe515c4c1c testsuite: Link some tests statically 
Link tests for private apis statically.
 2021-01-23 10:34:57 -05:00
Matthias Clasen
14f0a0addb Create a static library 
Rearrange our build to create a libgtk.a for the the contents of gtk/,
and build libgtk-4.so from our per-subdirectory static libraries.
This will let us link tests statically for testing internal apis.
 2021-01-23 10:31:23 -05:00
Matthias Clasen
0ef91c3ba8 Avoid a buffer overrun 
We were putting the '\0' behind the end. Oops.
 2021-01-22 13:56:04 -05:00
Matthias Clasen
39d5dd89c5 Avoid a heap-use-after-free 
_gtk_gesture_cancel_sequence frees the struct pointed to by data,
so don't write to it afterwards. Found by asan.
 2021-01-22 11:39:04 -05:00
Matthias Clasen
6c54abeca7 wayland: Explicitly announce ssd for kwin 
Without this, kwin correctly assumes that we are
using client-side decorations. This is a port
of 32ae97f1 from GTK 3.24.

Fixes: #3609
 2021-01-21 22:45:47 -05:00
Emmanuele Bassi
c46391420f Merge branch 'ebassi/lazier-a11y' into 'master' 
Lazier accessibility

See merge request GNOME/gtk!3102
 2021-01-21 18:57:34 +00:00
Matthias Clasen
5a3c3d8210 Merge branch 'inspector-controllers' into 'master' 
Inspector controllers

See merge request GNOME/gtk!3101
 2021-01-21 18:15:57 +00:00
Emmanuele Bassi
95ceb49770 a11y: Make GtkATContext realization lazier 
We only realize the ATContext on the top level, which will create an
GtkAtSpiRoot object and the corresponding GtkAtSpiCache object. Whenever
an AT connects to the accessibility bus, and asks for the various
objects, all the ATContext will be realized on demand.
 2021-01-21 16:40:57 +00:00
Emmanuele Bassi
0bde58ffd7 a11y: Avoid signal emission during cache population 
If we're responding to a request to get all the cached items, there's no
need to emit signals when adding an ATContext to the cache.
 2021-01-21 16:40:57 +00:00
Matthias Clasen
ccd9827b63 inspector: Redo the actions page 
Don't create widgets in bind, instead just set
the new action on the action-editor, and let it
recreate the parts that need to be recreated.
 2021-01-21 10:25:13 -05:00
Matthias Clasen
db189cfb9f inspector: Reshuffle action editor 
Prepare the action editor for being able to change its
actions after creation.
 2021-01-21 10:24:31 -05:00
Matthias Clasen
7527f181d5 inspector: Simplify action editor 
We are not using the size group anymore, so drop it.
 2021-01-21 10:20:21 -05:00
Matthias Clasen
c05b418512 inspector: Split out variant editor 2021-01-21 10:19:18 -05:00
Matthias Clasen
e97d996fe4 inspector: Redo the shortcuts page 
Use a column view here.
 2021-01-21 10:19:18 -05:00
Matthias Clasen
0537b167ca inspector: Redo the controllers page 
Use a column view, and only show the widgets own
controllers.
 2021-01-21 10:19:18 -05:00
Matthias Clasen
fff6b35821 inspector: Redo the controllers page 
Use a column view, and only show the widgets own
controllers.
 2021-01-20 18:51:01 -05:00
Emmanuele Bassi
a1216599ff Add rename-to annotation for GtkListStore.insert_valuesv() 
The vector-based variant should shadow the variadic arguments function
in bindings.
 2021-01-20 14:10:17 +00:00
Emmanuele Bassi
8fff0e0fdf docs: Reformat GtkListStore.insert_values() 2021-01-20 14:10:17 +00:00
Matthias Clasen
5985b62f60 columnview: Redo indicator arrows 
Use the same approach as GtkTreeViewColumn for sort
indicators. Luckily, the same css works for both.
 2021-01-19 14:24:19 -05:00
Matthias Clasen
e7c29b989c menbutton: Redo indicator arrows 
Instead of hardcoding icon names in the widget, use
arrow.none, arrow.up, arrow.down, arrow.left, arrow.right
styles and set the icon to use with -gtk-icon-source. This
lets themes change the icons that are used here, without
forcing all uses of pan-up/down/start/end-symbolic to be
treated the same.

Document this in the menubutton CSS docs.
 2021-01-19 14:02:23 -05:00
Matthias Clasen
2100e427d9 treeviewcolumn: Redo sort arrows 
Instead of hardcoding icon names in the widget, use
sort-indicator.ascending and sort-indicator.descending styles
and set the icon to use with -gtk-icon-source. This lets themes
change the icon that is used here, without forcing all uses of
pan-up/down-symbolic to be treated the same.

Document this in the treeview CSS docs.

Fixes: #3577
 2021-01-19 14:02:16 -05:00
Alexander Mikhaylenko
5968b10b0b listitemwidget: Activate on release instead of press 
Single click activation should only be done on release and not on press,
otherwise it breaks touch scrolling. Double-click activation still can be
done on press.

This matches the GtkListBox behavior as well.

Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3345
 2021-01-19 12:36:32 +05:00
Matthias Clasen
1ac1147ecb Merge branch 'check_button_activate' into 'master' 
Add activate signal to GtkCheckButton

Closes #3525 and #3550

See merge request GNOME/gtk!3012
 2021-01-19 04:06:01 +00:00
Matthias Clasen
6b7d56ac49 cellrenderertoggle: Fix css node handling 
Commit cbbbf44dd4 tried to replace
gtk_style_context_save_named with an explicit
css node to save to, but it failed, and the failure
was showing up as crashes in the inspector.

Fix by Benjamin Otte.

Fixes: #3599
 2021-01-18 20:52:59 -05:00
Thomas Holder
992cd088cf gtk_file_chooser_set_current_name: fix type of name argument 
The description says UTF-8 string, but the annotation said filename.

Cherry-picked from gtk-3-24 1573ff6803
 2021-01-18 22:14:03 +01:00
Matthias Clasen
6aa893e091 Merge branch 'matthiasc/for-master' into 'master' 
Matthiasc/for master

Closes #3437

See merge request GNOME/gtk!3087
 2021-01-17 17:51:15 +00:00
Matthias Clasen
5aa03bcb0d aboutdialog: Fix initial focus 
When GtkAboutDialog was changed to derive from
GtkWindow, it lost the initial focus handling that
GtkDialog has. Reinstate some of it.

Fixes: #3437
 2021-01-17 11:53:53 -05:00
Matthias Clasen
d7060025e0 inspector: Avoid a critical 
Avoid a critical when closing the inspector with the
recorder page open.
 2021-01-17 10:55:53 -05:00
Matthias Clasen
00883016af Merge branch 'wip/baedert/for-master' into 'master' 
Wip/baedert/for master

Closes #3593

See merge request GNOME/gtk!3086
 2021-01-17 14:20:13 +00:00
Timm Bäder
5ea3777599 widget: Fix gtk_widget_class_add_binding() argument name 2021-01-17 08:12:14 +01:00
Timm Bäder
a3949763f2 Add nullable annotations to GtkShortcutFunc 
Fixes #3593
 2021-01-17 08:11:42 +01:00
Matthias Clasen
1b961a9ae2 Merge branch 'surface-scale' into 'master' 
Surface scale

Closes #3578

See merge request GNOME/gtk!3085
 2021-01-17 05:23:22 +00:00
Timm Bäder
934b91f65f label: Remove unneeded NULL guards 
The pointers passed to GtkWidgetClass::measure cannot be NULL
 2021-01-17 04:39:26 +01:00
Timm Bäder
c3050231d1 label: Refactor get_layout_location 
Make this function shorter, the parameters non-nullable and the simple
cases more explicit.
 2021-01-17 04:39:26 +01:00
Timm Bäder
ec8614e8e4 label: Fix a potential memory leak 
This only happens in error cases so not very interesting. Anyway, try to
make scan-build happy.
 2021-01-17 04:39:26 +01:00
Timm Bäder
cb41b96a9e builderparser: Save finalizers in a GPtrArray 
We get up to 370 of these when starting the widget-factory.
 2021-01-17 04:39:26 +01:00
Timm Bäder
872b46a527 widget: Shorten get_halign() a bit 2021-01-17 04:39:26 +01:00
Timm Bäder
b1c8613dbe accessible: Fix memory leak if context is unset 
Unref the acessible values
 2021-01-17 04:39:26 +01:00
Timm Bäder
de6cd4f0d2 builder: Use a GPtrArray when parsing signals 2021-01-17 04:39:26 +01:00
Timm Bäder
aec2fb939f builderparser: Keep properties in a GPtrArray 2021-01-17 04:39:26 +01:00
Timm Bäder
69293db804 builderparser: Only allocate subparser stack when needed 
Out of the 3.3k possibly_finish_subparser calls when opening the
widget-factory, only 300 need one.
 2021-01-17 04:39:26 +01:00
Matthias Clasen
e905f7ff7c native: Listen for scale changes 
Connect to change notification for the surface
scale-factor property, and update the widgets
when it changes.

Fixes: #3578
 2021-01-16 15:22:46 -05:00
Matthias Clasen
a5e929ce36 docs: Add details 
Explain the difference between GtkPicture and GtkImage,
and when you might want to use which.
 2021-01-16 14:45:20 -05:00
Matthias Clasen
691b6b88ea inspector: Add a legend for the layout overlay 
Colors are more useful if you know what they represent.
 2021-01-16 12:38:24 -05:00
Matthias Clasen
144cf2d040 overlaylayout: Set the child type in the class 
We don't need to override create_layout_child here,
and setting the child type has the advantage that
the layout properties are showing up in the inspector.
 2021-01-15 22:35:11 -05:00
Matthias Clasen
d89ff71819 Flip margin-start and -end in RTL 
We lost this at some point, but the widget margins
are still meant to be relative to the text direction.

Fixes: #3583
 2021-01-15 14:58:21 -05:00
Matthias Clasen
f60d245e32 Make HighContrastInverse a dark variant 
Make HighContrastInverse available as the dark variant of HighContrast,
in addition to being a standalone theme. This regularizes our theme
variants, and doesn't hurt.
 2021-01-14 22:55:52 -05:00
Matthias Clasen
f04e5bd590 Make Adwaita-dark available as a theme 
This makes Adwaita-dark available as a standalone
theme.
 2021-01-14 22:42:50 -05:00
Emmanuele Bassi
ef33ec639c Merge branch 'ebassi/aspect-frame-doc' into 'master' 
Ebassi/aspect frame doc

See merge request GNOME/gtk!3073
 2021-01-12 16:50:31 +00:00
Emmanuele Bassi
39e07a8d56 Document limits of gtk_aspect_frame_get_ratio() 
The GtkAspectFrame:ratio getter will return the value set, not the
actual ratio computed in case GtkAspectFrame:obey-child is TRUE.
 2021-01-12 12:28:18 +00:00
Emmanuele Bassi
5286743cbe Document GtkAspectFrame properties 2021-01-12 12:28:00 +00:00
Emmanuele Bassi
58bb998ef0 docs: GtkAspectFrame is not a GtkFrame any more 2021-01-12 12:23:14 +00:00
Emmanuele Bassi
a56b2900dd a11y: Fix leak 
Introduced by me in commit 03b60a2d5e.
 2021-01-12 12:01:29 +00:00
Emmanuele Bassi
ff34124394 Merge branch 'ebassi/atspi-path-sanitize' into 'master' 
a11y: Sanitize the AT-SPI object path further

See merge request GNOME/gtk!3071
 2021-01-12 11:36:52 +00:00
Emmanuele Bassi
03b60a2d5e a11y: Sanitize the AT-SPI object path further 
When falling back to g_get_prgname(), we need to take into account that
the program name may be the full argv[0] path, which will end up messing
the DBus object path.
 2021-01-12 11:15:28 +00:00
Matthias Clasen
73fb28a058 iconhelper: Recreate the texture when needed 
When the icon size changes, we want to reload themed
icons.

This was showing up as the GtkImage in about dialogs
getting a big size with the same small icon upon
changing -gtk-icon-size in the inspector.
 2021-01-11 17:50:05 -05:00
Matthias Clasen
65eaf8e8c4 Adwaita: Make about dialog icons big 
Use 128 as the icon size for the image widget
in about dialogs.
 2021-01-11 17:50:05 -05:00
Matthias Clasen
beeedb5141 aboutdialog: Set icon-size for the logo 
Make it explicit that we want large icons here.
 2021-01-11 17:50:05 -05:00
Matthias Clasen
1d40750a60 aboutdialog: Set a style class 
Add the .aboutdialog style class to toplevel
widget of about dialogs, similar to what we
do for e.g. GtkAssistant.
 2021-01-11 17:46:55 -05:00
Matthias Clasen
96baf9769a about dialog: Remove manual icon sizing 
We have icon theme code to do that for us.
 2021-01-11 17:46:55 -05:00
Matthias Clasen
5044031b53 Merge branch 'wip/kalev/gcc-11' into 'master' 
Avoid diagnostics for gcc-11 false positive out of bounds accesses

See merge request GNOME/gtk!3064
 2021-01-11 22:04:52 +00:00
Kalev Lember
c514c41d0e Avoid diagnostics for gcc-11 false positive out of bounds accesses 
This is a patch by Jeff Law <law@redhat.com> done in downstream Fedora
to fix the build with gcc 11.
 2021-01-11 17:19:36 +01:00
Jakub Steiner
45848c5298 Merge branch 'wip/jimmac/adjust-for-contemporary-trends' into 'master' 
Wip/jimmac/adjust for contemporary trends

Closes #3568 and #3560

See merge request GNOME/gtk!3060
 2021-01-11 16:09:08 +00:00
Jakub Steiner
b5cb2f7e41 Adwaita: update image assets 
- reflect button styling
- ignore backdrop for non buttons
 2021-01-11 16:24:22 +01:00
Jakub Steiner
378ad75d48 Adwaita: scales border 
- remove -alt specialcasing for a straight forward border like
  everything else and avoid broken :dark and HC
 2021-01-11 16:00:32 +01:00
Jakub Steiner
6a047e53a8 Adwaita: less dramatic :active for undecorated buttons 
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3575
 2021-01-11 15:00:38 +01:00
Jakub Steiner
31a7bc70c9 Adwaita: fix button border logic 
- tint borders dark on non default / blue / red buttons
- just use plain $borders_color otherwise
- fixes HC/HCi
- ditch -alt buttons
 2021-01-11 14:08:57 +01:00
Jakub Steiner
874cae1dab Adwaita: flatter, lighter buttons 
- lighten up for contrast, less of an oldschool gradient

Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3568
 2021-01-11 13:50:32 +01:00
Jakub Steiner
7a3dd41dba Adwaita: round progress and levelbars 2021-01-11 13:50:32 +01:00
Jakub Steiner
149962670a Adwaita: :checked:active and checked:hover states 
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3560
 2021-01-11 13:50:32 +01:00
Jakub Steiner
849e3c8b4b Adwaita: flat scales, progressbars and level bars 2021-01-11 13:50:32 +01:00
Jakub Steiner
c9807f5afe Adwaita: remove edge highlights 
- flat is the name of the game
  - kids scream make it flat
  - simplify mixins
 2021-01-11 13:50:32 +01:00
Matthias Clasen
2b6b35d91f build: Add a sassc feature 
Add an option to disable css rebuilds. This allows
to build GTK from release tarballs (Which are including
the css) without a sassc dependency.
 2021-01-09 01:30:13 -05:00
Matthias Clasen
441d944c08 droptarget: Some docs cleanups 
Fixes #3565, among other things.
 2021-01-08 22:24:42 -05:00
Chun-wei Fan
99b2da4c47 gtk/gtksecurememoryprivate.h: Include glib.h 
Some compilers somehow do not have `inline` defined, so include glib.h
to ensure that keyword is defined.`
 2021-01-08 22:24:42 -05:00
Matthias Clasen
8243b5493b a11y: Avoid __ prefixes for variable names 
Seems that msvc does not like that.
 2021-01-08 22:24:42 -05:00
Matthias Clasen
2a79152762 Merge branch 'mcatanzaro/company-unparent-warning' into 'master' 
Add critical if widget has a parent during dispose

See merge request GNOME/gtk!3053
 2021-01-07 18:37:28 +00:00
Benjamin Otte
4761641098 Add critical if widget has a parent during dispose 
This is a refcounting bug. Be very verbose about it instead of trying to
call a function that releases a reference to the widget without
references.
 2021-01-07 11:39:32 -06:00
Michael Catanzaro
afaa275dc8 gtkbuilder: fix recommendations that no longer make sense in GTK 4 
In GTK 3, it was pretty much always better to use
gtk_builder_new_from_whatever() rather than
gtk_builder_add_from_whatever(). But in GTK 4, this is no longer
generally true. Let's add some context on when you want to use one or
the other.
 2021-01-07 11:34:42 -06:00
Matthias Clasen
d8d8322912 Merge branch 'wip/jimmac/flat-buttons' into 'master' 
Adwaita: fine tune flat button styling

Closes #3481

See merge request GNOME/gtk!3046
 2021-01-07 13:42:42 +00:00
Jakub Steiner
3a5eee7dbe HC: switch border color 
- lighten inverted HC borders while darkening the regular/light variant

Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3460
 2021-01-07 12:44:53 +01:00
Jakub Steiner
0cda6f42b8 Adwaita: fine tune flat button styling 
- enough contrast for hover and active, while noticably different in
  normal nad headerbar context (and both light and dark variants).

Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3481
 2021-01-07 12:12:55 +01:00
Matthias Clasen
7583810c90 Merge branch 'wip/exalm/headerbar' into 'master' 
headerbar: Prepend start window controls instead of appending

See merge request GNOME/gtk!3044
 2021-01-06 22:10:25 +00:00
Alexander Mikhaylenko
fd073deea9 headerbar: Prepend start window controls instead of appending 
Make sure they are always in the correct position.
 2021-01-06 22:04:55 +05:00
Matthias Clasen
5652ab0a61 Merge branch 'macos-ci' into 'master' 
Macos ci

See merge request GNOME/gtk!3032
 2021-01-06 14:52:11 +00:00
Matthias Clasen
2ff23b08be Merge branch 'wip/jimmac/headerbar-specialcasing' into 'master' 
Adwaita: specialcase switches and scales for headerbars

Closes #3504

See merge request GNOME/gtk!3043
 2021-01-06 14:40:36 +00:00
Jakub Steiner
e657da6658 Adwaita: specialcase switches and scales for headerbars 
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3504
 2021-01-06 13:02:21 +01:00
Jakub Steiner
fd00aa98ea HC: special case .dim-label 
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3507
 2021-01-06 12:46:35 +01:00
David Lechner
eb6fbf907f doc: fix annotation for GtkCssLocation 
GtkCssLocation is a type so it should be prefixed with # rather than @.
 2021-01-06 04:32:09 +00:00
Christian Hergert
4035f86b6d macos: use deprecated NSOnState for older systems 2021-01-05 16:37:30 -08:00
Christian Hergert
f2e0097cac gtk: fix brace initialization for bloom filter 
This was breaking CI for macOS and it is a simple enough change to ensure
that just works for the internal buckets.
 2021-01-05 16:21:05 -08:00
Matthias Clasen
ca9801f5fb 3to4: Remove GtkToolbar::toolbar_style 
The property was removed (with the rest of the widget),
so keeping it around in the ui file makes no sense.

Testcase included.
 2021-01-05 13:58:58 -05:00
David Lechner
a5b88a53c2 docs: fix parameter reference in gtk_bitset_contains() 
This fixes an error in the doc comments where the first parameter was
referred to as @bitset instead of @self.
 2021-01-05 11:39:43 -06:00