Commit Graph

2509 Commits

Author SHA1 Message Date
Kristian Rietveld
6284428f64 free cursor_path after usage
Tue Jan 29 18:50:46 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down): free
        cursor_path after usage
        (gtk_tree_view_real_start_interactive_search): use new g_signal
        and g_object calls
        (gtk_tree_view_search_dialog_destroy): use g_object calls and free
        selected_iter if set
        (gtk_tree_view_search_position_func): rework so it will never ever
        appear offscreen (#68492)
        (gtk_tree_view_search_move): use new g_object calls
        (gtk_tree_view_search_init): free selected_iter if set, use new
        g_object calls
        (gtk_tree_view_leave_notify): don't destroy interactive search
        dialog

Tue Jan 29 23:07:03 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreeview.c (gtk_tree_view_real_start_interactive_search):
        send focus in event
        (gtk_tree_view_search_dialog_destroy): send focus out event (#66466)
2002-01-29 22:08:12 +00:00
Anders Carlsson
1ae1f1ba6e Show correct size in the size entry.
2002-01-29  Anders Carlsson  <andersca@gnu.org>

	* gtk/gtkfontsel.c (gtk_font_selection_select_size): Show correct
	size in the size entry.
2002-01-29 21:29:55 +00:00
Owen Taylor
eb50860063 Use gtk_tree_view_set_cursor() instead of
Tue Jan 29 16:11:55 2002  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkfontsel.c (gtk_font_selection_show_available_sizes): Use
	gtk_tree_view_set_cursor() instead of gtk_tree_selection_select_iter().

	* gtk/gtkfontsel.c (gtk_font_selection_init): Add mnemonic to
	preview field. (#52433, patch from Anders Carlsson)

	* gtk/gtkfontsel.c (gtk_font_selection_dialog_init): Remove the
	dialog separator. (#69558, Alex Larsson, patch from Anders Carlsson)
2002-01-29 21:17:13 +00:00
Owen Taylor
833b99fca2 Switch over to GtkTreeView from GtkCList. Remove the entries above the
Tue Jan 29 15:24:59 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkfontsel.[ch]: Switch over to GtkTreeView from
        GtkCList. Remove the entries above the font/face lists
        since they were a little confusing. (Not sure about this
        change, so the code is still there the entries are
        just hidden.) (#68890)

        * gtk/gtkfilesel.c: Switch over to GtkTreeView from
        GtkCList. Add mnemonics for fileops. Allow Control/Shift
        Tab to focus out.

        * gtk/gtkfilesel.c: Make fileop dialogs transient-for
        the fileselector. (#69336, patch from Melvin Hadasht)

        * gtk/gtkgamma.c (button_clicked_callback): Fix handling
        of gamma dialog a bit. (#69336, Matthias Clasen.)
2002-01-29 20:53:17 +00:00
Owen Taylor
53ca71377d Return boolean (and FALSE from focus_in / focus_out handlers. (#69528,
Tue Jan 29 14:56:28 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtksocket.c (toplevel_focus_out_handler): Return boolean
        (and FALSE from focus_in / focus_out handlers. (#69528,
        Padraig O'Briain)
2002-01-29 19:58:43 +00:00
Owen Taylor
b2388ec7b4 Remove the scary startup warning.
Tue Jan 29 14:47:54 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkmain.c (gtk_init_check): Remove the scary startup
        warning.
2002-01-29 19:49:26 +00:00
Owen Taylor
854372b9be Add <Control>Tab bindings for "move-focus" so that Control-Tab to escape
Tue Jan 29 14:24:49 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkwindow.c (gtk_window_class_init): Add <Control>Tab
        bindings for "move-focus" so that Control-Tab to escape from
        something that eats Tab just works if not otherwise overriden.

        * gtk/gtkspinbutton.c (gtk_spin_button_new_with_range)
        * gtk/gtkvscale.c (gtk_vscale_new_with_range)
        * gtk/gtkhscale.c (gtk_hscale_new_with_range): Use a page_size
        of zero for the adjustment, since at times we think that the range
        is lower to upper - page_size. A page size equally to the
        step_increment is, in any case, not meaningful.
2002-01-29 19:44:49 +00:00
Sven Neumann
16ce67f81b don't install an empty icon_set if none of the image files could be found
2002-01-29  Sven Neumann  <sven@gimp.org>

	* gtk/gtkrc.c: don't install an empty icon_set if none of the image
	files could be found in the pixmap_path (bug #69398).
2002-01-29 12:24:02 +00:00
Tim Janik
c8a1ae5bce fix default value for ::digits property, leave as 1 as per havoc's
Tue Jan 29 11:51:14 2002  Tim Janik  <timj@gtk.org>

        * gtk/gtkscale.[hc]: fix default value for ::digits property,
        leave as 1 as per havoc's request.
        don't apply the draw_digits value to range->round_digits,
        so we don't perform gross quantization by default.
2002-01-29 11:35:28 +00:00
Havoc Pennington
5d82c0a4b6 fix assertion failure by creating the line data, but not validating it at
2002-01-25  Havoc Pennington  <hp@redhat.com>

        * gtk/gtktextbtree.c (_gtk_text_btree_delete): fix assertion
        failure by creating the line data, but not validating it at this
        stage. Also, remove old code related to the "bogus newline" mess
        that removed all tags from the last char in the buffer if you
        tried to delete it.
        (_gtk_text_line_data_new): put this here and prepend underscore,
        remove from gtktextlayout.c
2002-01-29 04:55:48 +00:00
Owen Taylor
ecd7479a37 Paint focus before shadow to give theme engines a bit more flexibility.
Mon Jan 28 18:25:10 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkentry.c (gtk_entry_draw_frame): Paint focus
        before shadow to give theme engines a bit more
        flexibility. (#69857)
2002-01-28 23:28:16 +00:00
Jonathan Blandford
76237096a8 no longer g_assert.
Mon Jan 28 16:23:20 2002  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtktreeview.c (gtk_tree_view_dy_to_top_row): no longer
	g_assert.
2002-01-28 21:24:27 +00:00
Jon Trowbridge
ddff4ea49f When setting the GtkTreeView's model, set prelight_node, prelight_tree,
2002-01-28  Jon Trowbridge  <trow@gnu.org>

	* gtk/gtktreeview.c (gtk_tree_view_set_model): When setting the
	GtkTreeView's model, set prelight_node, prelight_tree,
	button_pressed_node and button_pressed_tree to NULL. (#69603)
2002-01-28 20:28:52 +00:00
Bill Haneman
011cb31f18 Changes to gtktreeview to better support thicker focus lines,
and enhancements to the visibility of the default expander when
its size has been increased.
2002-01-28 20:19:42 +00:00
Jonathan Blandford
d8068f867c Only activate/edit the row if shift is not pressed, #69248
Mon Jan 28 14:44:40 2002  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtktreeview.c (gtk_tree_view_real_select_cursor_row): Only
	activate/edit the row if shift is not pressed, #69248
2002-01-28 19:48:48 +00:00
Anders Carlsson
7160e77b6b Fix build.
2002-01-28  Anders Carlsson  <andersca@gnu.org>

	* gtk/gtkcurve.c (gtk_curve_set_vector): Fix build.
2002-01-28 19:37:47 +00:00
Matthias Clasen
e2b730ac43 General property notification cleanup. 2002-01-28 18:52:49 +00:00
Jonathan Blandford
eb83e73898 Forgot to commit this last week. 2002-01-28 17:08:54 +00:00
Anders Carlsson
03a1601190 & with the default mod mask so accels work when numlock is on.
2002-01-28  Anders Carlsson  <andersca@gnu.org>

	* gtk/gtkaccelgroup.c (gtk_accel_groups_activate): & with the
	default mod mask so accels work when numlock is on.
2002-01-28 07:43:26 +00:00
Kristian Rietveld
2d0eb8a588 add _gtk_rbtree_mark_invalid (my previous commit already needed this ...)
Sun Jan 27 23:23:23  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtkrbtree.[ch]: add _gtk_rbtree_mark_invalid (my previous
        commit already needed this ...)

(/me broke the build for the first time ... :)
2002-01-27 22:21:27 +00:00
Kristian Rietveld
ad219f2e3a Fix for bug #69586
Sun Jan 27 22:13:02  Kristian Rietveld  <kris@gtk.org>

        Fix for bug #69586

        * gtk/gtktreeprivate.h: get rid of tab_offset, introduce
        expander_size

        * gtk/gtktreeview.c: get rid of ->priv->tab_offset, introduce
        expander_size caching (from style), fix CELL_HEIGHT macro,
        use MAX ("RBNODE_HEIGHT", expander_size) (differs per case) for
        row height calculation, added style_set callback
2002-01-27 21:11:29 +00:00
Anders Carlsson
529a9205e0 Set the cursor to GDK_XTERM.
2002-01-27  Anders Carlsson  <andersca@gnu.org>

	* gtk/gtklabel.c (gtk_label_create_window): Set the cursor to
	GDK_XTERM.
2002-01-27 18:54:36 +00:00
Anders Carlsson
8290dc99dc add mouse_cursor_obscured.
2002-01-27  Anders Carlsson  <andersca@gnu.org>

	* gtk/gtktextview.h (struct _GtkTextView): add mouse_cursor_obscured.

	* gtk/gtkentry.h (struct _GtkEntry): Add mouse_cursor_obscured.

	* gtk/gtktextview.c (set_invisible_cursor): New function.
	(gtk_text_view_obscure_mouse_cursor): Likewise.
	(gtk_text_view_key_press_event): Call obscure_cursor if text
	has been inserted.
	(gtk_text_view_motion_event): Restore the mouse cursor.

	* gtk/gtkentry.c (gtk_entry_realize): Add GDK_POINTER_MOTION_MASK.
	(set_invisible_cursor): New function.
	(gtk_entry_obscure_mouse_cursor): Likewise.
	(gtk_entry_key_press): call obscure_cursor if text has been inserted.
	(gtk_entry_motion_notify): Restore the mouse cursor.
2002-01-27 18:39:22 +00:00
Sven Neumann
f20c585eba removed unused return value.
2002-01-27  Sven Neumann  <sven@gimp.org>

	* gtk/gtkstyle.c (sanitize_size): removed unused return value.
2002-01-27 16:39:29 +00:00
Owen Taylor
1a60d00ed9 Don't send MODALITY_ON/OFF if socket->same_app (More fixes for #69735)
Sat Jan 26 19:27:23 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtksocket.c (gtk_socket_grab_notify): Don't
        send MODALITY_ON/OFF if socket->same_app (More fixes for #69735)
2002-01-27 00:36:38 +00:00
Owen Taylor
887c5ad832 Return FALSE not true in the grab_widget == NULL case. (Bug reported by
Sat Jan 26 19:04:37 2002  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkmain.c (check_is_grabbed): Return FALSE not true
	in the grab_widget == NULL case. (Bug reported by
	Padraig O'Briain, #69735)

	* gtk/gtkplug.c (handle_modality_on): Realize the modality
	window so gtk_widget_event() doesn't complain :-((((.
2002-01-27 00:19:31 +00:00
Sven Neumann
54b6e6f76b changed the comment so that gtk-doc doesn't get confused.
2002-01-25  Sven Neumann  <sven@gimp.org>

	* gtk/gtkwindow.c (gtk_window_get_size): changed the comment so
	that gtk-doc doesn't get confused.
2002-01-25 14:34:20 +00:00
Tim Janik
9c6dc3d52d assert that the passed in arrow is always _UP or _DOWN, this catches false
Fri Jan 25 14:03:36 2002  Tim Janik  <timj@gtk.org>

        * gtk/gtkspinbutton.c (gtk_spin_button_draw_arrow): assert
        that the passed in arrow is always _UP or _DOWN, this catches
        false invocations which lead to drawing artefacts.
        (start_spinning): likewise, i.e. sanity check the passed in arrow.
        (gtk_spin_button_button_release): fix arrow redrawing.
        (gtk_spin_button_button_press): must set click_child for
        button3 even if we don't take spinning action right away.

        * gtk/gtkspinbutton.h (struct _GtkSpinButton): document
        valid values for click_child.
2002-01-25 13:22:00 +00:00
Kristian Rietveld
2ccd6fd5d7 update docs, return current FALSE if x is smaller than the current visible
Thu Jan 24 23:03:24 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreeview.c (gtk_tree_view_get_path_at_pos): update docs,
        return current FALSE if x is smaller than the current visible area,
        not than the requested area, don't correct y coordinate,
        TREE_WINDOW_Y_TO_RBTREE_Y will do that. Fixes #67477.
2002-01-24 22:07:35 +00:00
Jonathan Blandford
902c6a48d5 fix column reordering fully. (gtk_tree_view_size_allocate): fix evil bug.
Thu Jan 24 15:41:08 2002  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtktreeview.c
	 (gtk_tree_view_motion_draw_column_motion_arrow): fix column
	 reordering fully.
	 (gtk_tree_view_size_allocate): fix evil bug.
2002-01-24 20:42:48 +00:00
Owen Taylor
bc5dfe106d Don't clear the model until we clean up all the other objects that might
Thu Jan 24 11:53:19 2002  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtktreeview.c (gtk_tree_view_destroy): Don't clear
	the model until we clean up all the other objects
	that might refer to the object.
2002-01-24 16:54:54 +00:00
Mark McLoughlin
44047a30e2 include gtk/gtkwidget.h
2002-01-24  Mark McLoughlin  <mark@skynet.ie>

        * gtk/gtkaccessible.h: include gtk/gtkwidget.h
2002-01-24 15:59:37 +00:00
Owen Taylor
c431ffffc6 Use insensitive state for insensitive arrows, not just an "etched state".
Wed Jan 23 20:28:59 2002  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtknotebook.c (gtk_notebook_draw_arrow):
	Use insensitive state for insensitive arrows, not
	just an "etched state". (#67172, Adrian Custer)
2002-01-24 01:36:39 +00:00
Manish Singh
1b3a7630f2 use a variable that's actually been declared.
2002-01-23  Manish Singh  <yosh@gimp.org>

        * gtk/gtkentry.c (gtk_entry_set_text): use a variable that's actually
        been declared.
2002-01-24 00:29:49 +00:00
Matthias Clasen
321db896a4 Remove excessive g_return_if_fail() calls. (#57615)
* gtk/gtkentry.c, gtk/gtkwidget.c: Remove excessive
        g_return_if_fail() calls. (#57615)
2002-01-23 23:46:25 +00:00
Owen Taylor
c099271bb5 Stop spinning if widget becomes insensitive. (#56248)
Wed Jan 23 15:12:16 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkspinbutton.c (gtk_spin_button_state_changed):
        Stop spinning if widget becomes insensitive. (#56248)
2002-01-23 20:15:48 +00:00
Owen Taylor
44d727eaa1 Decreate value since we now use doubles.
Wed Jan 23 14:44:12 2002  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkspinbutton.c (EPSILON): Decreate value since
	we now use doubles.
2002-01-23 19:51:43 +00:00
Jonathan Blandford
864cc237d4 Oops. Minor fix 2002-01-23 03:53:36 +00:00
Manish Singh
2f4b56176a remove old files (they live in the tests dir now)
-Yosh
2002-01-22 23:06:11 +00:00
Jonathan Blandford
60afa9e14e Fix sizing bug I introduced accidentally, #69358
Tue Jan 22 16:58:37 2002  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtktreeview.c (gtk_tree_view_size_allocate): Fix sizing bug
	I introduced accidentally, #69358
2002-01-22 22:13:30 +00:00
Padraig O'Briain
e060f59406 Update last change to prevent core dump
* gtk/gtktreestore.c (gtk_tree_store_iter_children):
Update last change to prevent core dump
2002-01-22 15:44:20 +00:00
Kristian Rietveld
f0c42465b9 add some more stamp checks (pointed out by Anders Carlsson)
Mon Jan 21 01:21:54 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreestore.c: add some more stamp checks (pointed out
        by Anders Carlsson)

        * gtk/gtktreemodelsort.c (gtk_tree_model_sort_insert_value): don't
        assume _row_changed will insert sort (because _row_changed doesn't
        need to follow this signal), so apply insert sort here
        (gtk_tree_model_sort_level_find_insert): header doesn't need to be
        set here, so use a return instead of g_return_val_if_fail.
2002-01-22 00:21:40 +00:00
Jonathan Blandford
969279b54e Update top_row. Remove extraneous print statements.
Mon Jan 21 18:28:17 2002  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtktreeview.c (gtk_tree_view_adjustment_changed): Update
	top_row.  Remove extraneous print statements.
2002-01-21 23:30:17 +00:00
Matthias Clasen
236118bf89 Document allowed values for ifactory.
* gtk/gtkitemfactory.c (gtk_item_factory_popup,
        gtk_item_factory_popup_with_data): Document allowed values
        for ifactory.

        * gtk/gtkitemfactory.c (gtk_item_factory_delete_entry): Make
        it work for paths with underline accelerators.
2002-01-21 18:44:20 +00:00
Jonathan Blandford
19c5e80ce7 only resize the window.
Fri Jan 18 16:31:21 2002  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtktreeview.c (gtk_tree_view_size_allocate): only resize the
	window.
2002-01-21 17:38:28 +00:00
Owen Taylor
382cc81163 Trap the case where there is no default widget and the entry is the focus
Mon Jan 21 11:56:31 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkentry.c (gtk_entry_real_activate): Trap the
        case where there is no default widget and the entry
        is the focus widget, since this also causes infinite
        recursion. (#69158)
2002-01-21 17:04:47 +00:00
Havoc Pennington
31283d57ca link to new X11 section in a lot of places when mentioning the window
2002-01-19  Havoc Pennington  <hp@pobox.com>

	* gtk/gtkwindow.c: link to new X11 section in a lot of places when
	mentioning the window manager.

	* gtk/gtkwidget.c (gtk_widget_hide_on_delete): don't mention
	window manager since we're portable.

2002-01-19  Havoc Pennington  <hp@pobox.com>

	* gtk/x11.sgml: add a mostly-empty X11 section

	* gtk/framebuffer.sgml: make title consistent with windows section

	* gtk/tmpl/gtkdrawingarea.sgml: couple of fixes
2002-01-19 18:51:48 +00:00
Jeff Garzik
b292358479 Wrap case values in GPOINTER_TO_UINT(). Fixes build with gcc 3.x.
Sat Jan 19 08:47:41 2002  Jeff Garzik  <jgarzik@mandrakesoft.com>

        * gdk/linux-fb/gdkproperty-fb.c (gdk_atom_name):
        Wrap case values in GPOINTER_TO_UINT().  Fixes build with gcc 3.x.

        * gtk/gtkmain.c:  Include sys/types.h if G_OS_UNIX.
        Fixes build with gcc 3.x and -ansi.
2002-01-19 17:54:11 +00:00
Owen Taylor
eb9406c2b3 Fix problems when an engine declaration occurs in a reopened style, and
Fri Jan 18 23:01:37 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkrc.c (gtk_rc_parse_style): Fix problems when
        an engine declaration occurs in a reopened style, and
        g_free() of objects when errors occur.
2002-01-19 06:45:45 +00:00
Matthias Clasen
fc85da54ca Clarify documentation. (#69026)
* gtk/gtkitemfactory.c (gtk_item_factory_get_widget_by_action):
        Clarify documentation. (#69026)

        * gtk/gtkprogressbar.c (gtk_progress_bar_size_request): Fix
        missing initialization of adjustment. (#69025)
2002-01-18 21:37:31 +00:00