Commit Graph

3327 Commits

Author SHA1 Message Date
Kristian Rietveld
64e33eb68f Fixes #78110
Tue Apr  9 21:41:24 2002  Kristian Rietveld  <kris@gtk.org>

        Fixes #78110

        * gtk/gtktreeselection.c (_gtk_tree_selection_internal_select_node):
        add override_browse_mode argument and implement,
        (gtk_tree_selection_unselect_path): always unselect the path,
        (toplevel): update uses of _gtk_tree_selection_internal_select_node

        * gtk/gtktreeview.c: update uses of
        _gtk_tree_selection_internal_select_node

        * gtk/gtktreeprivate.h (_gtk_tree_selection_internal_select_node):
        update prototype

Tue Apr  9 21:39:44 2002  Kristian Rietveld  <kris@gtk.org>

        Fixes #77862

        * gtk/gtktreeprivate.h: add _gtk_tree_view_column_has_editable_cell

        * gtk/gtktreeviewcolumn.c (_gtk_tree_view_column_has_editable_cell):
        new function

        * gtk/gtktreeview.c (gtk_tree_view_button_press): send cell event
        on first click when cell isn't editable

Tue Apr  9 21:37:31 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreedatalist.c (_gtk_tree_data_list_check_type): add some
        types which were missing and useful to use (fixes #77870)
2002-04-09 19:48:32 +00:00
Anders Carlsson
2e85b314e2 Initialize error to NULL.
002-04-09  Anders Carlsson  <andersca@gnu.org>

	* gtk/gtkfilesel.c (open_new_dir): Initialize error to NULL.
2002-04-09 12:05:37 +00:00
Manish Singh
4862c90b75 really revert testgtk.c
2002-04-08  Manish Singh  <yosh@gimp.org>

        * tests/testgtk.c: really revert testgtk.c
2002-04-08 19:32:38 +00:00
Kristian Rietveld
18dfabc12e check the return value of _gtk_tree_view_find_node and return if it's
Mon Apr  8 20:28:54 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreeselection.c (gtk_tree_selection_select_path),
        (gtk_tree_selection_unselect_path),
        (gtk_tree_selection_path_is_selected): check the return value of
        _gtk_tree_view_find_node and return if it's TRUE. This makes those
        functions work somewhat saner on non-expanded trees.
2002-04-08 17:42:45 +00:00
Kristian Rietveld
6d4655b01a free anchor row reference after unselecting the selection (fixes #76272)
Fri Apr  5 18:28:56 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreeselection.c (gtk_tree_selection_set_mode): free
        anchor row reference after unselecting the selection (fixes #76272)

Fri Apr  5 18:27:48 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreeview.c (gtk_tree_view_real_expand_row): only return
        when we don't have to open all children (fixes #75736)

Fri Apr  5 18:24:24 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_clear): unref
        cellrenderer after clearing the attributes of the renderer (fixes
        #75592)
2002-04-05 16:28:14 +00:00
Jonathan Blandford
8c114fa6a0 implement. (gtk_tree_view_move_cursor_up_down): check for focus
Fri Apr  5 05:55:14 2002  Jonathan Blandford  <jrb@gnome.org>

	* gtk/gtktreeview.c (gtk_tree_view_grab_focus): implement.
	  (gtk_tree_view_move_cursor_up_down): check for focus
	  (gtk_tree_view_move_cursor_page_up_down): ditto
	  (gtk_tree_view_move_cursor_left_right): ditto
	  (gtk_tree_view_move_cursor_start_end): ditto
	  (gtk_tree_view_real_select_all): ditto
	  (gtk_tree_view_real_unselect_all): ditto
	  (gtk_tree_view_real_select_cursor_row): ditto
	  (gtk_tree_view_real_toggle_cursor_row): ditto
	  (gtk_tree_view_real_expand_collapse_cursor_row): ditto
	  (gtk_tree_view_real_select_cursor_parent): ditto
	  (gtk_tree_view_real_start_interactive_search): ditto

	* gtk/gtktreeviewcolumn.c: grab focus
2002-04-05 16:11:32 +00:00
Alex Larsson
c744f44f0c Fix undefined variable typo. Patch from Simon Floery <simon.floery@gmx.at>
2002-04-05  Alex Larsson  <alexl@redhat.com>

	* gdk/linux-fb/gdkkeyboard-fb.c (write_string):
	Fix undefined variable typo.
	Patch from Simon Floery <simon.floery@gmx.at>
2002-04-05 15:11:00 +00:00
Tim Janik
cca4abf498 fix segfault upon NULL return from gdk_utf8_to_string_target().
Fri Apr  5 01:06:15 2002  Tim Janik  <timj@gtk.org>

        * gdk/x11/gdkwindow-x11.c (set_text_property): fix segfault
        upon NULL return from gdk_utf8_to_string_target().

        * gdk/x11/gdkselection-x11.c (gdk_utf8_to_string_target): fix
        return value comment to mention NULL returns upon EMFILE.
2002-04-04 23:10:58 +00:00
Soeren Sandmann
e61fd79f19 revert accidentally commited change to testgtk.c
Thu Apr  4 22:35:42 2002  Soeren Sandmann  <sandmann@daimi.au.dk>

	* tests/testgtk.c (menu_items): revert accidentally commited
	change to testgtk.c
2002-04-04 20:49:03 +00:00
Soeren Sandmann
3c52eba0b5 Fix problem with menu titles being clipped (#75948)
Thu Apr  4 22:28:08 2002  Soeren Sandmann  <sandmann@daimi.au.dk>

	* gtk/gtkmenuitem.c (gtk_menu_item_paint): Fix problem with menu
	titles being clipped (#75948)
2002-04-04 20:28:47 +00:00
Tor Lillqvist
abda40ede4 Fix some bugs, and introduce a minor feature.
2002-04-04  Tor Lillqvist  <tml@iki.fi>

	* gdk/gdkrgb.c: Fix some bugs, and introduce a minor feature.

	(gdk_rgb_convert_4_pack): New function, for 16-color (4 bits per
	pixel) static visuals (fixes #858).

	(gdk_rgb_convert_gray4_pack, gdk_rgb_convert_gray4_d_pack): Fix
	same bugs in both functions: Odd start coordinate (partial byte)
	was not handled correctly. Also a partial final byte was not
	handled correctly.

	(gdk_rgb_do_colormaps): Use G_N_ELEMENTS.
	(gdk_rgb_create_info): For pseudocolor visuals, use the 2x2x2
	colorcube only for depths 3 and 4. For static color, use it for
	depths 3..7 like before. (Depth 5..7 pseudocolor probably never
	occurs on X11. It doesn't normally occur on Win32 either, but
	there is experimental code in gdkvisual-win32.c to let the user
	restrict the size of palette used.)
	(gdk_rgb_init): Set gdk_rgb_verbose if the GDK_DEBUG_GDKRGB flag
	is set.
	(gdk_rgb_select_conv): Use gdk_rgb_convert_8 also for depths 5, 6
	and 7 (see above). Use gdk_rgb_convert_4_pack for 4 bits per pixel
	static color.
2002-04-04 20:23:56 +00:00
Jonathan Blandford
cdafcb42b1 set the sort_func correctly, 77030
Tue Apr  2 11:10:13 2002  Jonathan Blandford  <jrb@redhat.com>
	* gtk/gtkliststore.c (gtk_list_store_set_sort_func): set the
	sort_func correctly, 77030
2002-04-02 16:19:33 +00:00
Tim Janik
e6b73bedd3 update version to 2.0.2, binary age 2, interface age 2.
Tue Apr  2 13:44:27 2002  Tim Janik  <timj@gtk.org>

        * configure.in: update version to 2.0.2, binary age 2, interface
        age 2.

        * NEWS: updates for 2.0.2.
2002-04-02 12:10:57 +00:00
Kristian Rietveld
3089666944 add check for y > tree_view->priv->height (fixes #76974)
Mon Apr  1 22:20:24 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down): add
        check for y > tree_view->priv->height (fixes #76974)

Mon Apr  1 22:19:39 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreemodelsort.c (gtk_tree_model_sort_sort_level): get
        the stamp changes right this time

Mon Apr  1 22:13:24 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreemodel.c (gtk_tree_row_reference_free): only
        disconnect the ref callbacks when model == proxy (Thanks go to
        Manuel Clos Crespo for the remote debugging)
2002-04-01 20:40:58 +00:00
Owen Taylor
5a86c7f19e recommit after tagging 2_0_1 2002-03-30 20:52:42 +00:00
Owen Taylor
f42d57ab48 ===== Released 2.0.1 ======
Fri Mar 29 18:15:12 2002  Owen Taylor  <otaylor@redhat.com>

        * ===== Released 2.0.1 ======
2002-03-30 20:46:14 +00:00
Kristian Rietveld
8cc6b89fb9 revert the latest stamp increment changes, as it broke stuff for trees
Sat Mar 30 15:19:24 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreemodelsort.c: revert the latest stamp increment changes,
        as it broke stuff for trees
2002-03-30 14:15:28 +00:00
Owen Taylor
a302a5ea5b Call gdk_keyval_to_lower() on the key passed in, since we lowercase all
Fri Mar 29 18:09:18 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkaccelgroup.c (gtk_accel_group_query): Call
        gdk_keyval_to_lower() on the key passed in, since we
        lowercase all other key vals passed in, so querying
        keyvals will otherwise fail if the caller used
        an uppercase accelerators (#76899, Vitaly Tishkov)
2002-03-29 23:15:03 +00:00
Owen Taylor
b6cefaa0b7 Fix screwup in handling of module path that was resulting in freed memory
Fri Mar 29 17:41:21 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkmain.c (load_modules): Fix screwup in handling
        of module path that was resulting in freed memory being
        accessed when both GTK_MODULES and a theme were set.
        (#76902, Johan Dahlin)
2002-03-29 23:05:11 +00:00
Owen Taylor
b123b8d340 Fix wrong stock id's for ADD/REMOVE. (#76915, Vitaly Tishkov)
Fri Mar 29 17:57:36 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkiconfactory.c (get_default_icons): Fix wrong
        stock id's for ADD/REMOVE. (#76915, Vitaly Tishkov)
2002-03-29 23:00:41 +00:00
Hans Breuer
833579d8e1 fix typo in gtk_init_check macro, which caused crashes if argc != 0
2002-03-29  Hans Breuer  <hans@breuer.org>

	* gtk/gtkmain.h : fix typo in gtk_init_check macro, which
	caused crashes if argc != 0

	* gtk/stock-icons/makefile.msc : added new icons
2002-03-29 22:38:17 +00:00
Kristian Rietveld
835094b105 remove call to gtk_tree_model_sort_increment_stamp
Fri Mar 29 20:17:35 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreemodelsort.c (gtk_tree_model_sort_rows_reordered):
        remove call to gtk_tree_model_sort_increment_stamp
        (gtk_tree_model_sort_sort_level): always increment the stamp
2002-03-29 19:14:02 +00:00
Owen Taylor
bf5d6a7e91 Updates
Fri Mar 29 00:19:41 2002  Owen Taylor  <otaylor@redhat.com>

        * NEWS: Updates

        * configure.in: Version 2.0.1, binary, interface age 1.

        * configure.in (GDK_PIXBUF_VERSION): Up required versions
        of dependencies.

        * gtk/gtkiconfactory.c gtk/stock-icons/Makefile.am:
        Add stock_add/remove_16.
2002-03-29 06:23:35 +00:00
Owen Taylor
7dfb78f882 Don't show the window unless the widget is mapped. (#76742, Dennis
Thu Mar 28 18:38:30 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtk[hv]paned.c (gtk_[hv]paned_size_allocate):
	Don't show the window unless the widget is mapped.
        (#76742, Dennis Bjrklund, Soeren Sandmann)
2002-03-29 00:15:11 +00:00
Hans Breuer
fe60d43a26 Fixed dashed line issues (#74441) to an IMO reasonable extend. That is:
2002-03-29  Hans Breuer  <hans@breuer.org>

	Fixed dashed line issues (#74441) to an IMO reasonable extend.
	That is: use PS_USERSTYLE on WinNT (the next GDI limit appears
	to be with lines width > 50); Render horizontal and vertical
	dashed lines on Win9x 'by hand'. Dotted selection rectangles
	and Dia look nice ...

	* gdk/win32/gdkprivate-win32.h : add pen_dashes pointer and
	num_pen_dashes to _GdkGCWin32
	* gdk/win32/gdkgc-win32.c : initialize pen_dashes and remove
	the guesses from dashes to windoze line styles.
	(predraw_set_forground) : always ExtCreatePen (PS_SOLID) on
	Win9x, which does not support PS_USERSTYLE.
	* gdk/win32/gdkdrawable-win32.c : new functions render_line_
	<horizontal|vertical>. Use them if not running on NT in
	gdk_win32_draw_<rectangle|segments|lines> ()

	* gdk/win32/gdkkeys-win32.c (gdk_keyval_name) : return NULL
	for keyval == 0 to avoid to have zeros in all menu entries
	without accelerator.
2002-03-28 23:25:33 +00:00
Jakub Steiner
c141608750 new add, remove stock icons 2002-03-28 23:08:49 +00:00
Tim Janik
76e0cec01f when encountering non-UTF-8 file names, alert the user with g_message()
Thu Mar 28 21:11:04 2002  Tim Janik  <timj@gtk.org>

        * gtk/gtkfilesel.c (open_new_dir): when encountering non-UTF-8 file
        names, alert the user with g_message() instead of g_warning() and
        put out the actual conversion error.
2002-03-28 20:08:25 +00:00
Dave Camp
418e0c4622 Don't install the handler if the widget isn't realized.
2002-03-28  Dave Camp  <dave@ximian.com>

	* gtk/gtktreeview.c (install_scroll_sync_handler): Don't install
	the handler if the widget isn't realized.
2002-03-28 17:05:34 +00:00
Jakub Steiner
600817117c New font and text icons to solve the dark-theme-problem 2002-03-28 13:10:11 +00:00
Matthias Clasen
4a40933b1b Try to find libpng via pkg-config first, since libpng-1.2.2 will come with
* configure.in: Try to find libpng via pkg-config first,
	since libpng-1.2.2 will come with a .pc file.
2002-03-27 22:53:22 +00:00
Owen Taylor
f70bd1e465 changelog update 2002-03-27 16:46:42 +00:00
Owen Taylor
c5e6a170de Set page->last_focus_child to NULL as well as removing the weak reference,
Wed Mar 27 11:10:39 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtknotebook.c (gtk_notebook_real_remove): Set
        page->last_focus_child to NULL as well as removing the
        weak reference, to deal with reentrancy in set_focus_child().
        (#76634)
2002-03-27 16:15:48 +00:00
Murray Cumming
63c5610d89 ChangeLog typo. 2002-03-27 11:10:29 +00:00
Murray Cumming
271dfdc7bf Corrected registered return type of move-cursor signal. Had to add a
2002-03-27  Murray Cumming  <murrayc@usa.net>

 * gtk/gtktreeview.cc: Corrected registered return type of
move-cursor signal. Had to add a marshaller to
 gtk/gtkmarshalers.list.
2002-03-27 10:55:28 +00:00
Owen Taylor
441488cdb4 Shuffle the ordering around some more (position before realizing) fixing
Tue Mar 26 14:46:50 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkmenu.c (gtk_menu_popup): Shuffle the ordering around
        some more (position before realizing) fixing problems with
        arrows popping up at the wrong time (#73386), hopefully not
        introducing other problems. (Reported by Ettore Perrazoli, others)
2002-03-26 19:59:34 +00:00
Sven Neumann
c4e2102f3f fixed my ChangeLog entry 2002-03-26 17:22:49 +00:00
Dave Camp
e62f9fb020 Free the path after calling gtk_tree_view_row_activated() rather than
2002-03-26  Dave Camp  <dave@ximian.com>

        * gtk/gtktreeview.c (gtk_tree_view_button_press): Free the path
        after calling gtk_tree_view_row_activated() rather than before.
2002-03-26 17:12:30 +00:00
Sven Neumann
94168cf845 free the style's font_description before accessing a new one.
2002-03-25  Sven Neumann  <sven@gimp.org>

	* gtk/gtkrc.c (gtk_rc_parse_font_name): free the style's
	font_description before accessing a new one.
	(gtk_rc_parse_stock): always unref the created icon_set. #76289
2002-03-25 20:11:27 +00:00
Mark McLoughlin
cef7907ddd kill code duplicated in gtk_binding_entry_add_signall.
2002-03-25  Mark McLoughlin  <mark@skynet.ie>

        * gtk/gtkbindings.c: (gtk_binding_entry_add_signal),
        kill code duplicated in gtk_binding_entry_add_signall.
2002-03-25 16:40:03 +00:00
Jonathan Blandford
7cc14762b9 Make path arg const, #75653
Sun Mar 24 10:32:38 2002  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtktreemodel.c (gtk_tree_path_copy): Make path arg const, #75653

	* gtk/gtkfontsel.c (gtk_font_selection_show_available_styles): fix
	a warning

	* gtk/gtktreeview.c (gtk_tree_view_button_press): remove the grab
	when we emit row_activated so that listeners of this signal can
	grab the mouse, #75629
2002-03-25 04:10:49 +00:00
Havoc Pennington
dd99498088 invalidate the line containing start, even if the [start,end) range is
2002-03-23  Havoc Pennington  <hp@pobox.com>

	* gtk/gtktextlayout.c (gtk_text_layout_real_invalidate):
	invalidate the line containing start, even if the [start,end)
	range is empty (just invalidate [start,end], essentially).
	Partially fixes #72374
2002-03-23 22:14:40 +00:00
Havoc Pennington
ee8fd425f3 end any selection in progress, patch from db@zigo.dhs.org, #74620
2002-03-23  Havoc Pennington  <hp@pobox.com>

	* gtk/gtktextview.c (gtk_text_view_do_popup): end any selection in
	progress, patch from db@zigo.dhs.org, #74620
2002-03-23 18:08:52 +00:00
Havoc Pennington
0c45c57f6e extend selection for pageup/pagedown and ctrl+pageup/pagedown if shift is
2002-03-23  Havoc Pennington  <hp@pobox.com>

	* gtk/gtktextview.c (gtk_text_view_move_cursor_internal): extend
	selection for pageup/pagedown and ctrl+pageup/pagedown if
	shift is held. more of #53934
2002-03-23 17:54:16 +00:00
Havoc Pennington
e00f842a5b disconnect layout handlers earlier in the function, to avoid possible
2002-03-23  Havoc Pennington  <hp@pobox.com>

	* gtk/gtktextview.c (gtk_text_view_destroy_layout): disconnect
	layout handlers earlier in the function, to avoid possible
	reentrancy screwups
	(gtk_text_view_invalidate): Don't install idle handlers if
	layout == NULL, otherwise we get problems during finalization
	since clearing the buffer invalidates and puts the idle handlers
	back after we destroy the layout. #74660
	(gtk_text_view_ensure_layout): Install the validation handlers
	right after creating the layout.

	* gtk/gtktexttagtable.c (foreach_unref): call
	_gtk_text_buffer_notify_will_remove_tag(), #75126
2002-03-23 17:35:09 +00:00
Havoc Pennington
8d3df4d9a1 add more explanatory text to the error message about missing charsets, and
2002-03-22  Havoc Pennington  <hp@pobox.com>

	* gdk/x11/gdkfont-x11.c (gdk_fontset_load): add more explanatory
	text to the error message about missing charsets, and use
	g_printerr() not g_warning() since this is typically not a
	programming error (we do not export any API to ask whether
	a font set will have missing charsets so apps realistically can't
	do anything other than try the gdk_fontset_load())

	* gtk/gtktextview.c (gtk_text_view_key_press_event): return FALSE
	if the text view isn't editable and the user presses Return,
	so default buttons and such can be activated, #74937

	* gtk/gtktextbuffer.c (paste_from_buffer): don't insert
	if the insertion point is not editable and the paste
	is interactive, #74125

	* gtk/gtkwindow.c (gtk_window_move_resize): enhance the #if 0
	debug spew

	* gtk/gtktextbuffer.c (cut_or_copy): only remove the previous
	cut/copied data right before replacing it, when we know we are
	going to replace it. Fixes #74049
2002-03-23 04:37:53 +00:00
Richard Hult
56c5bd70a3 Fix typo, where x value was assigned to both x and y.
2002-03-22  Richard Hult  <rhult@codefactory.se>

	* gdk/gdkevents.c (gdk_event_get_root_coords): Fix typo, where x
	value was assigned to both x and y.
2002-03-22 17:47:51 +00:00
Owen Taylor
7425e42847 Partial fix for problem where keypad keys acted as shift-arrows in an
Fri Mar 22 11:29:11 2002  Owen Taylor  <otaylor@redhat.com>

        Partial fix for problem where keypad keys acted
        as shift-arrows in an entry rather than arrows (#74327)

        * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Sort lookup
        results by number of modifiers in the entry. Fixes
        problem where if a key matched both modified and unmodified
        key bindings ... e.g., the distinguishing key binding
        was consumed, then it was random which was used.

        * gtk/gtkbindings.c (gtk_binding_entries_sort_patterns):
        Catch the case where there are multiple entries from the
        same bindingset (with different modifiers), and use only
        the first entry, which, with the change in _gtk_key_hash_lookup()
2002-03-22 17:35:14 +00:00
Owen Taylor
abfed60cab Fix memory leak. (#74400, Morten Welinder.)
Fri Mar 22 10:56:19 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkaccelmap.c (gtk_accel_map_save_fd): Fix memory
        leak. (#74400, Morten Welinder.)

        * gtk/gtkaccelmap.c: Properly handle short returns from
        write() calls. (Handling EINTR isn't enough... that only
        handles the case where you were interrupted before you
        wrote a single byte.)

        * gdk/linux-fb/gdkmouse-fb.c gdk/linux-fb/gdkkeyboard-fb.c:
        Robustify against short returns from write() calls.
2002-03-22 16:06:06 +00:00
Owen Taylor
771e2d573c ri Mar 22 10:12:10 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtktextview.c (gtk_text_view_paint): Change
        G_BREAKPOINT() to g_assert_not_reached ().
	(#75865, Ashok Venkiteswaran)
2002-03-22 15:23:08 +00:00
Tor Lillqvist
1ffa06c6a5 Don't clear all of the pen_style, just the PS_STYLE_MASK. Seems to fix
2002-03-22  Tor Lillqvist  <tml@iki.fi>

	* gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Don't clear
	all of the pen_style, just the PS_STYLE_MASK. Seems to fix #74441,
	but that is just the special case of one-pixel wide one-pixel
	on-off dotted lines. To fully implement generic X11 style dashed
	lines a major rewrite would be needed.
2002-03-21 22:36:02 +00:00