AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity
36,454 Commits 969 Branches 749 Tags 504 MiB
7291d3e780
Commit Graph

449 Commits

Author SHA1 Message Date
Matthias Clasen
0795237bb2 Plug a few memory leaks 
The accessibles for icon view items were not properly freed
in all cases.
https://bugzilla.gnome.org/show_bug.cgi?id=683311
 2013-02-11 00:42:28 -05:00
Rico Tzschichholz
4fe1effb36 Revert "Visual C++: Update gtka11y projects completion" 
This broke 'make dist' on linux.

This reverts commit ecf2a9471b.
 2013-02-08 18:29:22 +01:00
Rico Tzschichholz
656cc63c75 Revert "Drop things that break distcheck" 
This reverts commit 2204f12083.
 2013-02-08 18:29:13 +01:00
Matthias Clasen
2204f12083 Drop things that break distcheck 2013-02-04 14:14:07 -05:00
Matthias Clasen
2ae8a27b4a Remove a no-op AtkAction from GtkRange 
The "activate" action here did not do anything.
It is possible we actually want to have some actions here,
like "step-up", "step-down", "page-up", "page-down", etc.
For now, just remove the AtkAction implementation.
https://bugzilla.gnome.org/show_bug.cgi?id=553334
 2013-02-04 00:59:14 -05:00
Matthias Clasen
935d458fa1 Improve AtkAction implementations 
Implement get_localized_name, and also translate the strings
returned by get_description.
https://bugzilla.gnome.org/show_bug.cgi?id=525226
 2013-02-04 00:57:46 -05:00
Matthias Clasen
fae1da8ec9 Include gtklevelbaraccessible.h in gtk-a11y.h 2013-02-01 22:54:20 -05:00
Mike Gorse
92f0c5c384 Add accessibility for GtkLevelBar and value test 2013-02-01 11:44:15 -06:00
Chun-wei Fan
ecf2a9471b Visual C++: Update gtka11y projects completion 
-Rename the "libgail" projects to gtka11y, for consistency with the
 autotools builds
-Update the projects completion in gtk/a11y/Makefile.am, as the sources are
 now listed under $(libgtka11y_la_SOURCES) instead of $(libgail_la_SOURCES)
 2013-01-23 13:56:11 +08:00
Matthias Clasen
88ed5af5e4 Use g_signal_connect_object for adjustments in GtkSpinButtonAccessible 
An instance of GtkAdjustment may be used by another instance after
the spin button widget is destroyed. In that case, the function
gtk_spin_button_accessible_value_changed() will be called with an
invalid argument. This situation is often caused when one use
GtkCellRendererSpin widget. To avoid invalid call of the function,
the signal handler for the "value-changed" signal should be disconnected
when the spin-button widget is destroyed.
Using g_signal_connect_object achieves just that.
https://bugzilla.gnome.org/show_bug.cgi?id=691592
 2013-01-20 22:16:47 -05:00
Benjamin Otte
f260affbb8 a11y: Implement get_name() instead of setting variables 
This avoids a later free of this const value.
 2013-01-14 00:01:44 +01:00
Matthias Clasen
5adecf183b Move single-include guards inside include guards 
gcc has optimizations for include guards that only work
if they are outermost in the the header.
https://bugzilla.gnome.org/show_bug.cgi?id=689810
 2012-12-28 09:57:56 -05:00
Matthias Clasen
6bc2a2da48 Another trivial sorting fix 2012-12-27 12:15:05 -05:00
Matthias Clasen
38963870eb Rename gtkcolorswatchaccessible.h 
Call it gtkcolorswatchaccessibleprivate.h. This matches what we're
doing for non-public widget headers in gtk/.
 2012-12-27 12:11:12 -05:00
Matthias Clasen
12f9b81b1e Drop separate scrollbar accessible implementation 
It didn't really add anything to the range accessible implementation.
 2012-12-27 12:06:23 -05:00
Matthias Clasen
5fa4232404 Install a11y headers 
We install the headers for the a11y implementations in
/usr/include/gtk-3.0/gtk/a11y/.
 2012-12-27 12:05:02 -05:00
Matthias Clasen
c3577c66e5 Add single-include guards to a11y headers 
More preparation for installing these headers.
 2012-12-27 12:05:02 -05:00
Matthias Clasen
07a00d5939 Fix inter-header includes 
Since we are going to install these headers soon, we need
to make their mutual includes work in the installed location
as well. Also, avoid including individual gtk headers, to
avoid trouble with single-include guards.
 2012-12-27 12:04:01 -05:00
Matthias Clasen
d2944ce633 More gail removal 
Rename GailMisc to GtkMiscImpl.
 2012-12-27 11:27:46 -05:00
Matthias Clasen
4cd806ff0c Rename and clean up gailutil 2012-12-27 11:27:45 -05:00
Matthias Clasen
651241b685 Some renaming 
Move gail.h to gtkaccessibility.h, and libgail to libgtka11y.
 2012-12-27 11:27:45 -05:00
Matthias Clasen
221ac71278 Cosmetics 
Replace GAIL in top comments by 'GTK+ - accessibility implementations'.
 2012-12-27 11:27:44 -05:00
Matthias Clasen
e4b5e94eb9 Make accessible implementations public 
This commit exposes the get_type() functions and standard
headers for accessible implementations. This makes it possible
to derive from the GTK accessible implementations without
GType magic tricks. This is necessary, because we require the
a11y type hierarchy to be parallel to the widget type hierarchy.
So, if you derive a widget and need to adjust its a11y implementation,
you have to be able to derive its accessible implementation.

This commit probably exposes more than is absolutely necessary,
it also exposes accessibles of widgets that are unlikely candidates
for deriving from.
 2012-12-27 11:23:22 -05:00
Matthias Clasen
853b5e5fa2 Trivial sorting fix 2012-12-27 01:50:54 -05:00
Matthias Clasen
f229945dab NotebookPageAccessible: Implement selectable/selected states 
The automatic handling for this was removed from atk, so
we need to do it ourselves here.
 2012-12-17 23:59:23 -05:00
Matthias Clasen
5bee1a994f GtkMenuItemAccessible: implement selectable/selected states 
The automatic handling for this was removed in atk, so
we need to do it ourselves now.
 2012-12-17 23:58:24 -05:00
Cosimo Cecchi
3782cf77c3 a11y: fix uninitialized variables compiler warning 
The code path where we update the tooltip text property doesn't set
the state and value variables, and so doesn't need to call
notify_state_change().
Return early, and move the if block at the beginning of the function for
clarity.
 2012-12-13 21:52:51 -05:00
Mario Sanchez Prada
57e1e0de94 Add missing NULL-check in GtkEntryAccessible 
Only call to atk_object_set_name if gtk_entry_get_icon_name() is not NULL.

https://bugzilla.gnome.org/show_bug.cgi?id=689923
 2012-12-09 11:52:11 +01:00
Matthias Clasen
5b9c687595 Avoid unreachable code 
Reestablish an else that went missing in commit 5ff328d2. Without
it, the return is reached unconditionally, and the code behind
it is dead.
 2012-11-29 23:10:40 -05:00
Matthias Clasen
4557e4d7a5 GtkCellAccessible: Add missing break statements 
This switch was entirely breakless. Amazing accessibility code,
found by Coverity.
 2012-11-29 23:10:34 -05:00
Matthias Clasen
a7ed598d37 GtkIconViewAccessible: Fix a copy-paste error 
Don't access vadjustment after checking hadjustment for
not being NULL. Found by Coverity.
 2012-11-29 23:10:34 -05:00
Mike Gorse
b7743430aa Add accessibles for GtkEntry icons 
Expose GtkEntry icons as child accessibles of a GtkEntry, and provide
actions to simulate clicking them. Also, refactor the a11y children test
slightly to add a test.

https://bugzilla.gnome.org/show_bug.cgi?id=686347
 2012-11-12 09:21:27 -06:00
Matthias Clasen
ffa42cb5bb Nuke GtkBoxAccessible 
It didn't contain anything useful.
 2012-11-07 20:17:30 -05:00
Cosimo Cecchi
f9db800713 text-cell-accessible: fix a double unref 
We're unreffing the GtkCellRenderer object twice, causing the
application to crash when trying to access the renderer later.

https://bugzilla.gnome.org/show_bug.cgi?id=687872
 2012-11-07 15:46:16 -05:00
Matthias Clasen
bec6b260b4 Be robust against unrealized windows in GtkWindowAccessible 
Based on a patch by Albert Astals Cid,
https://bugzilla.gnome.org/show_bug.cgi?id=686152
 2012-10-22 19:42:41 -04:00
Cosimo Cecchi
9208588771 a11y: fix private strict regression 
Commit 0bbfcc2491 added a private struct
for GtkImageAccessible, but forgot to call g_type_class_add_private().
 2012-10-15 17:09:04 -04:00
Cosimo Cecchi
10ead8a9d7 a11y: fix the build 
Fix a typo introduced in 0ad379708f
 2012-10-15 11:32:56 -04:00
Matthias Clasen
5465d89380 Add private structs to all remaining headers 
These are not used currently. Just put them in now in
case we need them in the future.
 2012-10-15 06:25:01 -04:00
Matthias Clasen
d83294d313 GtkWidgetAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
This also required removing access to GtkWidgetAccessible innards
from several accessible implementations.
 2012-10-15 06:04:11 -04:00
Matthias Clasen
19fc090354 GtkTreeViewAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
 2012-10-15 05:56:41 -04:00
Matthias Clasen
dad727d41c GtkToplevelAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
This also required removing access to GtkToplevelAccessible innards
from the GtkWindowAccessible implementation.
 2012-10-15 05:52:04 -04:00
Matthias Clasen
f1594c39be GtkTextViewAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
 2012-10-15 05:31:09 -04:00
Matthias Clasen
d13b70f779 GtkTextCellAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
 2012-10-14 21:21:34 -04:00
Matthias Clasen
8b667e006a GtkRendererCellAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
This also required removing access to GtkRendererCellAccessible innards
from various cell accessible implementations.
 2012-10-14 21:07:46 -04:00
Matthias Clasen
06542b2b59 GtkRadioMenuItemAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
 2012-10-14 20:48:30 -04:00
Matthias Clasen
8b6e962811 GtkRadioButtonAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
 2012-10-14 20:18:57 -04:00
Matthias Clasen
0ea0293356 GtkNotebookPageAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
 2012-10-14 20:15:28 -04:00
Matthias Clasen
c86628b41e GtkNotebookAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
 2012-10-14 20:09:58 -04:00
Matthias Clasen
f44c9dff3d GtkMenuItemAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
 2012-10-14 20:01:37 -04:00
Matthias Clasen
9a41636988 GtkLinkButtonAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
 2012-10-14 19:55:59 -04:00
Matthias Clasen
b8e4543ff3 GtkLabelAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
 2012-10-14 19:51:14 -04:00
Matthias Clasen
1ea3979864 GtkImageCellAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
 2012-10-14 19:43:47 -04:00
Matthias Clasen
0bbfcc2491 GtkImageAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
 2012-10-14 19:38:08 -04:00
Matthias Clasen
538c241951 GtkIconViewAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
 2012-10-14 16:06:08 -04:00
Matthias Clasen
4745adaeff GtkEntryAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
 2012-10-14 15:59:58 -04:00
Matthias Clasen
0ad379708f GtkContainerCellAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
This also required removing access to GtkContainerCellAccessible
innards from the GtkCellAccessible implementation.
 2012-10-14 15:56:51 -04:00
Matthias Clasen
978f336aa4 GtkContainerAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
This also required removing access to GtkContainerAccessible innards
from the GtkMenuItemAccessible implementation.
 2012-10-14 15:56:46 -04:00
Stefano Facchini
95f3fadcbd Remove leftover from commit 7264a996fe 2012-10-14 11:57:58 +02:00
Matthias Clasen
1dc4d2c621 GtkComboBoxAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
 2012-10-14 02:47:22 -04:00
Matthias Clasen
5226327e11 GtkBooleanCellAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
 2012-10-14 02:40:20 -04:00
Matthias Clasen
7264a996fe GtkArrowAccessible: add a private struct 
Move instance fields to a private struct, in preparation
for installing a11y headers.
 2012-10-14 02:39:32 -04:00
Benjamin Otte
9e486139ca a11y: Fix for -Wmissing-declarations 
I'll add a bunch of fixes for gcc complaining about
-Wmissing-declarations after finding a bunch of cases today where I had
forgotten to make functions static in the CSS code.

A thorn in those patches is G_DEFINE_TYPE() which doesn't allow making
the get_type() function static, so I added definitions for that function
above the G_DEFINE_TYPE().

After those patches, GTK should compile without warnings when this flag
is enabled.
 2012-10-02 19:32:38 +02:00
William Jon McCann
5debed5ae2 Shut down a11y when an app shuts down 
https://bugzilla.gnome.org/show_bug.cgi?id=684076
 2012-09-16 19:31:23 -04:00
Alejandro Piñeiro
5ff328d21f a11y: Solved leak on gtk_widget_accessible_get_description 
https://bugzilla.gnome.org/show_bug.cgi?id=643611
 2012-09-12 21:15:59 +02:00
Colin Walters
9ca355b460 GtkEntryAccessible: Remove unused variable 2012-08-16 10:37:05 -04:00
Mario Sanchez Prada
63e2a0ff0c Expose the masked string for password fields to assistive technologies. 
Call _gtk_entry_get_display_text()from gtkentryaccessible.c to make
sure we always consider the actual text being displayed when
implementing the functions from the AtkTet interface.

https://bugzilla.gnome.org/show_bug.cgi?id=681591
 2012-08-10 18:09:06 +02:00
Matthias Clasen
8d0e88bac7 gtk: Don't use GDK_THREADS_ENTER/LEAVE macros internally 
These are just wrappers for the functions, and we want to
deprecate them. Stopping to use them internally is a good
first step.
 2012-07-30 18:01:47 +02:00
Benjamin Otte
b900016a05 a11y: Make lockbutton notify about state changes 
In particular, ensure that the name of the lockbutton gets updated as
the displayed text of the lockbutton changes.

https://bugzilla.gnome.org/show_bug.cgi?id=677347
 2012-07-09 03:12:13 +02:00
Benjamin Otte
58cf6dfaaf a11y: Get lockbutton text directly 
Instead of letting the generic button code attempt to find the currently
displayed text, just return the text directly.

https://bugzilla.gnome.org/show_bug.cgi?id=677347
 2012-07-09 02:58:22 +02:00
Benjamin Otte
fb1b025cbf a11y: Add separate accessible for GtkLockButton 
The accessible doesn't do anything yet, this is just infrastructure
work.
 2012-07-09 02:29:16 +02:00
Benjamin Otte
0dbf5db0e1 a11y: Don't mess up if column gets hidden 
We were using a function that insisted on visible columns for computing
the potential ID of an invisible column. Not good.

https://bugzilla.gnome.org/show_bug.cgi?id=675990
 2012-07-09 01:28:26 +02:00
Alejandro Piñeiro
4cfe2a38bf a11y: remove implementation for [add/remove]_global_event_listener 
Since release 2.5.3, ATK provides an implementation for those
methods, so toolkits doesn't need to implement them.
 2012-06-28 12:38:11 +02:00
Colin Walters
ed8203e700 build: Drop --without-atk-bridge option 
Instead, always build it if and only if X11.  This reduces the set of
supported configurations.

https://bugzilla.gnome.org/show_bug.cgi?id=677491
 2012-06-26 13:50:39 -04:00
Colin Walters
71e0e72c69 build: Add --without-atk-bridge, only check for it on X11 platforms 
Some builders using gtk3 outside of the GNOME cycle want an option to
avoid linking to atk-bridge-2.0.  Provide that, and at the same time
ensure we're only looking for it on X11 platforms.

https://bugzilla.gnome.org/show_bug.cgi?id=677491
 2012-06-22 23:49:24 -04:00
Bastien Nocera
ffe1e31a2c gtk: Always load the atk-bridge 
Slightly modified by Alejandro Piñeiro

https://bugzilla.gnome.org/show_bug.cgi?id=677491
 2012-06-15 17:09:19 +01:00
Cosimo Cecchi
3473577386 a11y: fix a typo leading to a crash 
text can't be NULL here, or we would have failed way earlier.
The original code from gail returned if the renderer text was NULL, and
we have to do that, or we'll end up calling e.g.
g_utf8_offset_to_pointer() on a NULL pointer.

https://bugzilla.redhat.com/show_bug.cgi?id=827930

https://bugzilla.gnome.org/show_bug.cgi?id=677551
 2012-06-07 16:51:02 -04:00
Benjamin Otte
e31fb77c22 iconview: Bring back per-row contexts 
Apparently GtkCellAreaContext is broken enough to not allow multiple
allocations...
 2012-05-08 03:58:23 +02:00
Benjamin Otte
d20d7c54d3 iconview: Redo layouting 2012-05-07 00:12:26 +02:00
Benjamin Otte
ee91e272a8 iconview: Remove needless requirement 
If we use
  &item->cell_area
instead of
  (GdkRectangle *) item
there is no need anymore to keep the cell_area as the first member of
the the item. And we cget compile-time checks for changes to the item
struct.
 2012-05-07 00:12:26 +02:00
Benjamin Otte
47e44028e1 a11y: Add back the 'toggle' actions 
This is a hack.

But as long as Orca cannot figure out if a cell is heckable, the best we
can do is support the old way of providing a "toggle" action.

https://bugzilla.gnome.org/show_bug.cgi?id=672367
https://bugzilla.gnome.org/show_bug.cgi?id=672368
https://bugzilla.gnome.org/show_bug.cgi?id=672369
 2012-03-19 02:26:16 +01:00
Benjamin Otte
50e3f532b9 a11y: Only care about GtkOrientable::orientation 
There are other widgets (like PanelToplevel) that aren't a GtkOrientable
but still have that property.
 2012-03-09 13:23:05 +01:00
Benjamin Otte
2353d60b8a types: Move GtkAdustment declaration to gtktypes.h 
... and make all the headers to not include gtkadjustment.h anymore. Of
course, also include it in the source files instead.
 2012-03-03 19:45:03 +01:00
Javier Jardón
9d0febc9a6 Change FSF Address 2012-02-27 17:06:11 +00:00
Matthias Clasen
140e884868 Symbol exporting fixes 2012-02-21 01:50:19 +01:00
Matthias Clasen
e1a625aa78 GtkColorSwatch: Add accessible actions 2012-02-14 21:16:52 -05:00
Benjamin Otte
90e65f30ab a11y: Mark cells as defunct when deleting them 
Just unreffing isn't enough, atk-bridge might have a reference to the
object still.
 2012-02-12 16:45:14 +01:00
Benjamin Otte
194a48bd4a a11y: Redo ref_accessible_at_point() 
use direct access to the RBTree instead of fiddling with the path.

Removes the lat caller of get_index() and with it count_rows(), so those
are gone now.
 2012-02-11 05:11:00 +01:00
Benjamin Otte
3827d75f64 a11y: create focus cell accessibles when they get focused 2012-02-11 04:44:27 +01:00
Benjamin Otte
bf8d9ceb2f a11y: Split out cell creation function 2012-02-11 04:41:45 +01:00
Benjamin Otte
315ac9413b a11y: Set relations without tree path 
We can directly use at the rbtree's parent.
 2012-02-11 04:13:04 +01:00
Benjamin Otte
6130c65470 a11y: Remove unused variable 2012-02-11 03:42:14 +01:00
Benjamin Otte
da30c8253b a11y: Keep treeview accessibles around 
Refcounting behavior kinda requires that we track of accessibles until
the row goes away. This is necessary for reference handling and for some
assumptions that atk-bridge does.
 2012-02-11 03:37:25 +01:00
Benjamin Otte
5e587229c8 a11y: Remove old treeview focus tracking code 2012-02-11 03:14:22 +01:00
Benjamin Otte
24db6d7a6f a11y: Emit focus change events when focus cell changes 2012-02-11 03:02:20 +01:00
Benjamin Otte
07f8336dbd a11y: Update treeview focused status 
... when the cursor row changes. Also emit active-descendant-changed.
 2012-02-11 02:50:26 +01:00
Benjamin Otte
f90ff5d50b treeview: Notify accessible about focus changes 2012-02-11 02:38:48 +01:00
Benjamin Otte
a4559f1e19 treeview: Tell accessible about focus column changes 2012-02-11 01:59:19 +01:00
Benjamin Otte
dbabff0846 a11y: Invoke key snooper directly 
Gets around the deprecated function warnings.
 2012-01-19 10:32:21 +01:00
Benjamin Otte
ed8e7d1793 Revert "a11y: Remove keysnooping support" 
This reverts commit 0c8ecba7dc.

The change broke Orca completely, and we need a proper fix first.
So we have to live with the bugs intorduced by this until then.
 2012-01-18 18:33:11 +01:00
Matthias Clasen
3e6b37726a Remove a check that broke the color chooser a11y dump 
With the visible check, the opacity slider ended up without
a labeled-by, which is sad.
 2012-01-16 21:05:01 -05:00