Patch from bug #591186. It won't have any effect in this branch as the
whole XP-and-later theming code is broken and disabled, but when/if
that is fixed, then this patch should help.
Either g_type_register_static_simple (used by G_DEFINE_TYPE_EXTENDED)
and G_IMPLEMENT_INTERFACE use automatic variables for GTypeInfo and
GInterfaceInfo structs, while tutorials and source code often use
static variables. This commit consistently adopts the former method.
https://bugzilla.gnome.org/show_bug.cgi?id=600158
2009-03-21 Cody Russell <bratsche@gnome.org>
Bug 538840 – [Win32] GTK menu theming could be improved
* modules/engines/ms-windows/xp_theme.c
* modules/engines/ms-windows/msw_style.c: Use newer
menu styling API. This makes gtk+ look much better on
Windows Vista.
svn path=/trunk/; revision=22577
2009-01-16 Cody Russell <bratsche@gnome.org>
Bug 567944 – [Win32] Sorted treeview columns can be unreadable
* modules/engines/ms-windows/msw_style.c: Draw selected treeview
cells according to treeview focus, but ignore whether it is in
a sorted column or not. Otherwise the intersection of a selected
row and a sorted column looks very strange if the treeview does
not have focus.
svn path=/trunk/; revision=22126
2008-09-18 Dominic Lachowicz <domlachowicz@gmail.com>
* modules/engines/ms-windows/*: Revert most of previous patch, as it didn't work as expected;
Some work toward #531086 - the new GtkTooltip widget doesn't theme properly on win32. Now, at least
the background color seems okay
w
svn path=/trunk/; revision=21430
2008-09-18 Dominic Lachowicz <domlachowicz@gmail.com>
* modules/engins/ms-windows/*: MS Windows style should use pango_win32_font_description_from_logfont;
Allows us to rip out a lot of potentially buggy code, and also get the font specification from the
XP theme (#434987)
svn path=/trunk/; revision=21429
2008-03-16 Alberto Ruiz <aruiz@gnome.org>
* modules/engines/ms-windows/Theme/gtk-2.0/gtkrc:
* modules/engines/ms-windows/msw_style.c (draw_box) (draw_arrow)
(combo_box_draw_arrow) (setup_msw_rc_style): draw box does more intelligent
separation for the xp theming engine and the classic theme while drawing the
GtkComboBox button.
combobox_draw_arrow is not used anymore, commented.
The style has been updated to fix border/thickness glitches in the combobox
according to the fixes commited regarding bug #521442. (bug #461805)
svn path=/trunk/; revision=19887
2008-03-08 Alberto Ruiz <aruiz@gnome.org>
* modules/engines/ms-windows/msw_style.c (draw_shadow):
Do not draw frame if parent if combobox.
(draw_box):
Uses scrollbar width system metrics for combobox button.
Fixes#461805 for XP theme engine.
svn path=/trunk/; revision=19733
2008-03-03 Tor Lillqvist <tml@novell.com>
* modules/engines/ms-windows/msw_style.c (draw_box): Check that
the widget is a GtkButton before casting.
svn path=/trunk/; revision=19690
2008-02-01 Cody Russell <cody@jhu.edu>
* modules/engines/ms-windows/xp_theme.[ch]
* modules/engines/ms-windows/xp_theme_defs.h
* modules/engines/ms-windows/msw_rc_style.c
* modules/engines/ms-windows/msw_theme_main.c
* modules/engines/ms-windows/msw_style.c: Re-indented and generally
attempted to stylize more like the rest of the gtk+ stack's code.
svn path=/trunk/; revision=19455
2007-10-18 Cody Russell <cody@jhu.edu>
* modules/engines/ms-windows/msw_style.c: Draw focus rect for
buttons with relief set to GTK_RELIEF_NONE. (#487954)
svn path=/trunk/; revision=18931
2007-10-08 Cody Russell <bratsche@gnome.org>
* modules/engines/ms-windows/msw_style.c:
(draw_tab): Fix memory leak, and fix two instances where
a GtkRequisition and a GtkBorder were being freed with
g_free() rather than gtk_requisition_free() and
gtk_border_free(). (#484730, Daniel Atallah)
svn path=/trunk/; revision=18893
2007-09-20 Cody Russell <bratsche@gnome.org>
* modules/engines/ms-windows/msw_style.c: Override draw_layout
method in GtkStyle in order to adjust by 2 pixels any labels
that are in GtkNotebook tabs using XP theme, so that they appear
correctly centered. (#478637)
svn path=/trunk/; revision=18848
2007-08-27 Cody Russell <bratsche@gnome.org>
* modules/engines/ms-windows/msw_style.c: Correct draw_box()
function to check detail for "notebook". This fixes a problem
where notebooks without visible headers were not styling
correctly. (#470033, Daniel Atallah and Cody Russell)
svn path=/trunk/; revision=18689
2007-06-27 Cody Russell <bratsche@gnome.org>
* modules/engines/ms-windows/msw_style.c (draw_themed_tab_button):
Fixed, very hackishly, a one pixel error that occurs using the
XP theme engine only on the left-most tab, if it is active, when
the notebook is bottom-oriented. (#392283)
svn path=/trunk/; revision=18264
2007-06-26 Cody Russell <bratsche@gnome.org>
* modules/engines/ms-windows/xp_theme.[ch]
* modules/engines/ms-windows/msw_style.c: Add support for
drawing checkboxes with inconsistent states. (Tor, #164809)
svn path=/trunk/; revision=18246
2007-05-02 Dom Lachowicz <domlachowicz@gmail.com>
* modules/engines/ms-windows/msw_style.c: MS-Windows Theme top
tabs
rendered upside down for non-XP theme (#435053, Daniel Atallah)
svn path=/trunk/; revision=17773
2007-03-08 Mathias Hasselmann <mathias.hasselmann@gmx.de>
* modules/engines/ms-windows/msw_style.c: Use proper border style
when drawing shadow of scrolled windows on Windows XP (#168326)
* modules/engines/ms-windows/xp_theme.c: Explicitly set size of
element_part_map array to ensure it always is large enough.
svn path=/trunk/; revision=17429
2007-03-08 Mathias Hasselmann <mathias.hasselmann@gmx.de>
* gtk/gtkscrolledindow.c: Improve look of GtkScrolledWindow on Windows
by implementing a scrollbars-within-bevel style property. (#168326)
svn path=/trunk/; revision=17425
2007-02-23 Dom Lachowicz <domlachowicz@gmail.com>
* modules/engines/ms-windows/msw_style.c: Bug 411118 - bad bevel for
progress bar on windows classic. Match from Mathias Hasselmann.
svn path=/trunk/; revision=17344
2006-12-13 Dom Lachowicz <domlachowicz@gmail.com>
* src/modules/engines/ms-windows/msw_style.c: Bug 351679 - Notebooks
drawn with extra line below tab in MS-Windows theme. Patch by
Cody Russell
2006-12-02 Dom Lachowicz <domlachowicz@gmail.com>
* src/modules/engines/ms-windows/msw_style.c: Bug 351678 - Notebooks
not with PositionType.Top drawn incorrectly. Patch by Cody Russell
* modules/engines/ms-windows/msw_style.c: Override style->realize/
style->unrealize, so that GTK+ doesn't automatically attempt to apply
shading to the GC colors, causing a mismatch with the Win32 native
colors. Problem found by (and suggested solution by) "Cosmic Integer"
2006-03-11 Dom Lachowicz <cinamod@hotmail.com>
* modules/engines/ms-windows: Speed up the Windows theme
considerably (#163724, John Ehresman)
Be more careful about setting Pango font descriptions (#333372)
2005-11-12 Dom Lachowicz <cinamod@hotmail.com>
* modules/engines/ms-windows/msw_style.c: Bug #313627. Make win32
theme's handling of toolbars, handleboxes, and menubars more in-line
with Microsoft's IE style.
* modules/engines/ms-windows/*.c: Indentation cleanups
* modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
Experimentally, scrollbar steppers can shrink to 8 pixels on
Win32. Reflect that in the theme.
* modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
there is a 1-pixel border between a scrollbar and its child
in ScrolledWindows on Win32. Reflect that in the theme.
2005-09-16 Tor Lillqvist <tml@novell.com>
* modules/engines/ms-windows/msw_style.c (draw_extension,
draw_box_gap): Check whether the widget actually is a GtkNotebook
before treating it as such. Drop some unneeded local variables,
use parameter with same information instead. (#316412)
2005-06-04 Tor Lillqvist <tml@novell.com>
* modules/engines/ms-windows/msw_style.c: Render insensitive icons
in a way that more closely matches Windows. (#305986, Tim Evans).
* modules/engines/ms-windows/Makefile.am (LDADDS): Link with
gdk-pixbuf.
