Matthias Clasen
f9c7a4bbd0
Really make GtkFileSystem private by _-prefixing all functions.
...
* gtk/gtkfilechooserbutton.c:
* gtk/gtkfilechooserdefault.c:
* gtk/gtkfilechooserentry.c:
* gtk/gtkfilesystem.c:
* gtk/gtkfilesystem.h:
* gtk/gtkfilesystemmodel.c:
* gtk/gtkpathbar.c: Really make GtkFileSystem private
by _-prefixing all functions.
svn path=/trunk/; revision=20378
2008-06-13 16:47:41 +00:00
Carlos Garnacho
640d68778a
Bug 520874 - Should use gio directly.
...
2008-06-10 Carlos Garnacho <carlos@imendio.com>
Bug 520874 - Should use gio directly.
* gtk/gtkfilesystem.[ch]: Turn into a private object, which mostly
provides helper functions for asynchronous calls, folder abstraction
and uniform handling of volumes/drives/mounts.
* gtk/gtkfilesystemwin32.[ch]:
* gtk/gtkfilesystemunix.[ch]: Removed, these are no longer required.
* gtk/gtkfilechooser.c:
* gtk/gtkfilechooserbutton.c:
* gtk/gtkfilechooserdefault.c:
* gtk/gtkfilechooserentry.[ch]:
* gtk/gtkfilechooserprivate.h:
* gtk/gtkfilechooserutils.c:
* gtk/gtkfilesystemmodel.[ch]:
* gtk/gtkpathbar.[ch]: Use GIO internally. Adapt to GtkFileSystem API.
Do not load filesystem implementation modules.
* gtk/Makefile.am:
* gtk/gtk.symbols: the gtkfilesystem.h private header isn't installed
anymore, nor the unix/win32 implementations.
* README.in: Add blurb about these changes.
svn path=/trunk/; revision=20342
2008-06-10 00:39:35 +00:00
Federico Mena Quintero
cf62c83b0e
bnc355225 - File chooser crash in Tab completion
...
2008-06-03 Federico Mena Quintero <federico@novell.com>
* gtk/gtkfilechooserentry.c (install_completion_feedback_timer):
If the user presses Tab while the completion feedback window is
active, then we'll assert. Remove the assertion and just re-set
the timer. Fixes https://bugzilla.novell.com/show_bug.cgi?id=355225
Signed-off-by: Federico Mena Quintero <federico@novell.com>
svn path=/trunk/; revision=20305
2008-06-03 18:08:48 +00:00
Federico Mena Quintero
dec88cb285
Ahem, fix compilation
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19938
2008-03-26 20:34:22 +00:00
Federico Mena Quintero
00b34c0b3d
Make 'Ok' work for the file chooser entry
...
2008-03-26 Federico Mena Quintero <federico@novell.com>
* gtk/gtkfilechooserentry.c (commit_completion_and_refresh): New
helper function; factored out from the functions that commit the
current suggested autocompletion and that refresh the entry's paths.
(gtk_file_chooser_entry_activate): Use commit_completion_and_refresh().
(_gtk_file_chooser_entry_get_file_part): Likewise.
(_gtk_file_chooser_entry_get_current_folder): Likewise. This
makes the entry have the correct paths when *not* using any form
of completion (and makes the file chooser work when clicking the
OK button).
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19937
2008-03-26 20:22:50 +00:00
Federico Mena Quintero
5ed9d8099c
Hide the mouse cursor in the completion feedback window
...
2008-03-13 Federico Mena Quintero <federico@novell.com>
* gtk/gtkfilechooserentry.c (create_completion_feedback_window):
Set the mouse cursor of the feedback window to invisible, so that
we respect GtkEntry's invisible cursor while typing.
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19870
2008-03-14 02:45:44 +00:00
Federico Mena Quintero
d31b7a0dd8
Use rough font-based spacing for the completion entry's suggestion window
...
2008-03-13 Federico Mena Quintero <federico@novell.com>
* gtk/gtkfilechooserentry.c (show_completion_feedback_window): Put
the feedback window at entry_height/2 pixels to the right of the
cursor, for a cheap "M-width / 2" spacing.
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19869
2008-03-14 02:13:54 +00:00
Federico Mena Quintero
c2d5bcb7f7
Beep with gtk_widget_error_bell()
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19859
2008-03-13 00:48:10 +00:00
Federico Mena Quintero
cec81cbfdf
Better feedback for sole completions
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19858
2008-03-13 00:47:54 +00:00
Federico Mena Quintero
1e60639143
Don't complete the directory separator if it would result in double separators
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19857
2008-03-13 00:47:38 +00:00
Federico Mena Quintero
b7e32c8dcb
Remove obsolete FIXMEs
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19856
2008-03-13 00:47:21 +00:00
Federico Mena Quintero
74f3d16c26
Remove debug printfs
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19855
2008-03-13 00:47:05 +00:00
Federico Mena Quintero
bb4c73e81b
Add some FIXMEs
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19854
2008-03-13 00:46:48 +00:00
Federico Mena Quintero
b0e2c417cb
On error when loading a folder, use the raw error message instead of commenting it up
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19853
2008-03-13 00:46:31 +00:00
Federico Mena Quintero
c406ebcc44
Clear the current_folder_path if loading yields an error
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19852
2008-03-13 00:46:14 +00:00
Federico Mena Quintero
7efced5687
Present an error if we can't load the folder during explicit completion
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19851
2008-03-13 00:45:58 +00:00
Federico Mena Quintero
d5df63cc1c
Detect when Tab would generate no new completions
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19850
2008-03-13 00:45:41 +00:00
Federico Mena Quintero
801553bee6
Debug printfs for deleting/inserting the completion
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19849
2008-03-13 00:45:23 +00:00
Federico Mena Quintero
857c561ffe
If explicitly completing and we have a completion, just unselect it
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19848
2008-03-13 00:45:05 +00:00
Federico Mena Quintero
bcb36780ed
Another FIXME
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19847
2008-03-13 00:44:48 +00:00
Federico Mena Quintero
e33260acf3
Add completion feedback in other places
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19846
2008-03-13 00:44:30 +00:00
Federico Mena Quintero
932e20e9df
Find the cursor position from GtkEntry for the completion feedback
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19845
2008-03-13 00:44:12 +00:00
Federico Mena Quintero
197ab5dee8
Use a timer for the completion feedback window
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19844
2008-03-13 00:43:54 +00:00
Federico Mena Quintero
2465beb901
Destroy the completion feedback window
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19843
2008-03-13 00:43:36 +00:00
Federico Mena Quintero
53b09108df
Use an alignment for the label like in GtkTooltip
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19842
2008-03-13 00:43:18 +00:00
Federico Mena Quintero
547069a38e
Show the label as well as the feedback window
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19841
2008-03-13 00:42:58 +00:00
Federico Mena Quintero
b17ffff0ff
Debug printfs for the completion feedback position
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19840
2008-03-13 00:42:38 +00:00
Federico Mena Quintero
3b5ddd8b55
Create a tooltip-like window to present completion feedback
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19839
2008-03-13 00:42:19 +00:00
Federico Mena Quintero
f47227adde
Beep if there are no matches for explicit completion
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19838
2008-03-13 00:41:58 +00:00
Federico Mena Quintero
a83799a32a
Scan the completion store again to look for complete-but-not-unique matches
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19837
2008-03-13 00:41:38 +00:00
Federico Mena Quintero
e5f8a4693e
Stubs for all cases of completion feedback
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19836
2008-03-13 00:41:17 +00:00
Federico Mena Quintero
806cca3c9c
Update comments on explicit completion
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19835
2008-03-13 00:40:57 +00:00
Federico Mena Quintero
47ddc0c86f
Stubs to give feedback when doing explicit completion
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19834
2008-03-13 00:40:37 +00:00
Federico Mena Quintero
1510b02c75
Refresh the file part when it gets requested and when activating the entry
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19833
2008-03-13 00:40:16 +00:00
Federico Mena Quintero
8482f9a7de
Clear the completion flags before appending the common prefix
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19832
2008-03-13 00:39:56 +00:00
Federico Mena Quintero
6a06c6daee
Add FIXMEs for beeping later
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19831
2008-03-13 00:39:35 +00:00
Federico Mena Quintero
d2293cc4f8
Factor out some code
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19830
2008-03-13 00:39:15 +00:00
Federico Mena Quintero
989637296b
Implement the basic code path for explicit completion
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19829
2008-03-13 00:38:53 +00:00
Federico Mena Quintero
11a9457ee1
Clear pending completions thoroughly
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19828
2008-03-13 00:38:31 +00:00
Federico Mena Quintero
e7009432b2
Remove debug printfs from populate_completion_store()
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19827
2008-03-13 00:38:11 +00:00
Federico Mena Quintero
a531c03baf
Debug printfs for finishing the folder load
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19826
2008-03-13 00:37:50 +00:00
Federico Mena Quintero
deec573420
More debug printfs for populating the completion store
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19825
2008-03-13 00:37:27 +00:00
Federico Mena Quintero
b2fe9f70d3
Debug printfs for populating the completion store
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19824
2008-03-13 00:37:05 +00:00
Federico Mena Quintero
baeaea3ca8
Turn on in_change while changing the filename in the entry
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19823
2008-03-13 00:36:42 +00:00
Federico Mena Quintero
b25ec8e40e
Update some FIXMEs
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19822
2008-03-13 00:36:18 +00:00
Federico Mena Quintero
a6bdc59213
When finding the common prefix, assert that we have the correct folder loaded
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19821
2008-03-13 00:35:54 +00:00
Federico Mena Quintero
073093bde0
Discard the completion store when we change the folder
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19820
2008-03-13 00:35:31 +00:00
Federico Mena Quintero
f5343b9037
Add some more FIXMEs
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19819
2008-03-13 00:35:08 +00:00
Federico Mena Quintero
bdebb1c7fb
Remove obsolete comments
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19818
2008-03-13 00:34:44 +00:00
Federico Mena Quintero
69f62828f4
Cancel all forms of completion at the appropriate times, not just in ::changed
...
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19817
2008-03-13 00:34:21 +00:00