AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity
56,610 Commits 969 Branches 749 Tags 504 MiB
8d987be673
Commit Graph

56610 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Benjamin Otte
07722582ef simpleselection: Improve items-changed 
Make items-changed never emit 2 signals, instead, always emit only one,
potentially by extending the range reported in items-changed.

And be a lot more exhaustive about autoselect tests.
 2019-02-15 06:46:04 +01:00
Benjamin Otte
1f56f5c2e9 selectionmodel: Change prototype of query_range() 
1. Do not make position an inout variable
The function is meant to return a range for a given position, not modify
a position. So it makes no conceptual sense to use an inout variable.
2. Pass the selected state as an out variable
Using a boolean return value - in particular in an interface full of
boolean return values - makes the return value intuitively feel like a
success/failure return. Using an out variable clarifies the usage.
3. Allow passing every position value
Define what happens when position >= list.n_items
4. Clarify the docs about how this function should behave
In particular, mention the case from point (3)
5. Add more tests
Again, (3) needs testing.
 2019-02-15 06:28:35 +01:00
Benjamin Otte
cd37b872ca overlay: Remove hack for scrolled windows 
It's not needed now that we don't use scrollbars or overlays inside
scrolled windows anymore.
 2019-02-15 06:28:11 +01:00
Matej Urbančič
acaa257469 Updated Slovenian translation 2019-02-14 18:31:28 +01:00
Matthias Clasen
89d8ae0431 stack: Fix a crash 
We need to remove the weak pointer, as the stack switcher can
keep the list model alive beyond the stack. This was observed
to cause crashes:

==16870== Invalid write of size 8
==16870==    at 0x5168A4E: g_nullify_pointer (gutils.c:2284)
==16870==    by 0x522C500: weak_refs_notify (gobject.c:2791)
==16870==    by 0x50FE7BC: g_data_set_internal (gdataset.c:407)
==16870==    by 0x50FECA7: g_datalist_id_set_data_full (gdataset.c:670)
==16870==    by 0x5227EB4: g_object_real_dispose (gobject.c:1056)
==16870==    by 0x522D295: g_object_unref (gobject.c:3309)
==16870==    by 0x4AF849F: unset_stack (gtkstackswitcher.c:428)
==16870==    by 0x4AF892E: gtk_stack_switcher_dispose (gtkstackswitcher.c:527)
 2019-02-14 12:24:22 -05:00
Matthias Clasen
fb44491926 assistant: Add a pages property 
This is mainly useful to make the page objects
accessible in the inspector.
 2019-02-13 18:27:25 -05:00
Matthias Clasen
ae9a29f8ce Exempt "pages" properties from defaultvalue test 
Ironically, these properties are too good - they always
give you a proper value, which is unfortunately different
from the declared default value, which is NULL. So, don't
check these.
 2019-02-13 18:14:48 -05:00
Matthias Clasen
2866a13f30 inspector: Support list model properties 
This is just a very quick hack for a property editor
that allows to drill down into list models.
 2019-02-13 15:08:17 -05:00
Matthias Clasen
6ef775dbcb stack: Add a pages property 
This makes the list model available in the inspector.
 2019-02-13 14:14:54 -05:00
Matthias Clasen
927e983ff8 inspector: Make object property inspection work again 
This was lost when porting to GtkListView.
 2019-02-13 13:41:15 -05:00
Matthias Clasen
fbe0db4007 inspector: Add an api to activate an object 
This will be used to make object property inspection
work again.

This will be used to make object property inspection
work againn
 2019-02-13 13:40:40 -05:00
Matthias Clasen
8de8b8eebc inspector: Fix selecting objects with a next tab 
This was causing criticals.
 2019-02-13 13:04:00 -05:00
Matthias Clasen
82fdd483d2 Add a missing icon 
The view-refresh-symbolic icon is used in the data list
of the inspector. So ship it in gtk. No need to have
it in the demos, then.
 2019-02-13 12:49:31 -05:00
Matthias Clasen
8c0b70691b stack: Don't emit bad ::selection-changed signals 
We have to be careful to not pass bad numbers to
this signal, which was happening in cases where
we have on old or new selected item.
 2019-02-13 09:01:07 -05:00
Matthias Clasen
1750922631 stack: Fix a corner-case 
When the stack goes empty, we were failing to reset
the visible_child member to NULL, causing problems later
on, since we don't have a ref for it.
 2019-02-13 09:00:00 -05:00
Matthias Clasen
2dd85b826f stack: Don't leak a reference 
The page holds a reference to the widget, so can't just clear
this pointer.
 2019-02-13 08:42:58 -05:00
Matthias Clasen
c0c6c87781 stack: Avoid some ugly unrefs 
Instead of using the list model api that forces us
to drop the ref, just work with the list we have.
 2019-02-13 08:40:13 -05:00
Matthias Clasen
f4b26af255 selection model: Add sanity checks 
It is easy to emit wrong ::selection-changed signals,
and then bad things will usually happen later. Add
some sanity checks to gtk_selection_model_selection_changed
to make this easier to track down.
 2019-02-13 08:38:30 -05:00
Matthias Clasen
2bd93303c4 Merge branch 'included-icons' into 'master' 
Included icons

See merge request GNOME/gtk!580
 2019-02-13 03:33:16 +00:00
Matthias Clasen
4fb342fb03 Update check-icon-names tests 
Drop icons that are only used by demos, and check for ones
that are actually used in gtk.
 2019-02-12 21:37:02 -05:00
Matthias Clasen
ffc7a81f84 gtk-demo: Include our own icons 
Add enough icons as resources that gtk4-demo
works without an installed icon theme.
 2019-02-12 21:37:02 -05:00
Matthias Clasen
5f73d527ec stack demo: Use the proper icon name 
The gtk-demo logo was renamed. Follow suit.
 2019-02-12 21:37:02 -05:00
Matthias Clasen
93514b474f sidebar demo: Use an existing icon 
The help-about icon is legacy and not available in large sizes.
Just use the gtk-demo logo.
 2019-02-12 21:37:02 -05:00
Matthias Clasen
ce5f198c93 widget-factory: Include our own icons 
Add enough icons as resources that gtk4-widget-factory
works without an installed icon theme.
 2019-02-12 21:37:02 -05:00
Matthias Clasen
16026b6898 page setup dialog: Use theme icons 
We have non-gtk-specific icons in the icon theme for this
now, so drop the gtk-orientation icons and use the theme
ones instead.
 2019-02-12 21:37:02 -05:00
Matthias Clasen
7207c82c39 spin button: Use guaranteed icons 
We guarantee value-increase/decrease-symbolic now, no need
for fallback anymore.
 2019-02-12 21:37:02 -05:00
Matthias Clasen
bcafd20529 resources: Include more icons 
Include all the icons that gtk is using itself.
For now, we include size 16 and scalable, to keep
the size limited.
 2019-02-12 21:37:02 -05:00
Matthias Clasen
6c4e088620 resources: Include more icon directories 
We are going to include all the icons that are
used by gtk itself. Prepare for that by including
the necessary subdirectories from the icon theme.
 2019-02-12 19:34:19 -05:00
Matthias Clasen
4df2a4c82c icon theme: Remove fallbacks 
We want to include all needed icons as resources,
so disable the fallbacks and see what comes up.
 2019-02-12 17:34:43 -05:00
Matthias Clasen
92d6f5e8fd Add image-missing to the internal icons 
We assert if image-missing is missing,
so life is better if
we can guarantee that it is available.
 2019-02-12 17:34:18 -05:00
Matthias Clasen
ec6458db16 testsuite: Consider bookmark-new as required icon 
This was missing from the list.
 2019-02-12 17:34:07 -05:00
Timm Bäder
aa71b6c405 Rever more of the icon shadow commit 
Even adjusting the icon size is wrong for GTK4.
 2019-02-12 06:33:41 +01:00
Matthias Clasen
2d57cb6ce3 Revert a non-working addition 
Cell rendererers don't support <style> in ui files.
 2019-02-12 06:20:14 +01:00
Jakub Steiner
756e8f3189 Theme: add helper class names for Adwaita 
- helps legibility of app icons

Addresses https://gitlab.gnome.org/GNOME/gtk/issues/1434
 2019-02-12 06:19:22 +01:00
Matthias Clasen
52b83ac553 about dialog: Adapt to new stack visiblity handling 
We need to set the visible property of the stack pages
now.
 2019-02-12 00:10:54 -05:00
Piotr Drąg
4feb88e2a4 Update POTFILES.in 2019-02-11 22:27:57 +01:00
Matthias Clasen
14bc61cde7 Merge branch 'fix-fishbowl' into 'master' 
gtk-demo: Fix fishbowl setup

Closes #1665

See merge request GNOME/gtk!578
 2019-02-11 16:48:25 +00:00
Matthias Clasen
220ccaf363 gtk-demo: Fix fishbowl setup 
The fishbowl demo was failing to reset a static variable
when setting up, causing it to crash the second time around.

Closes: #1665
 2019-02-11 08:51:13 -05:00
Matthias Clasen
46fba85ed7 Merge branch 'stack-fixes' into 'master' 
Stack <> switcher api changes

See merge request GNOME/gtk!570
 2019-02-11 04:40:33 +00:00
Matthias Clasen
78da8e4dc5 Exclude some tests on too-old glib 
I'm coming to the conclusion that the ci test
failures are due to a recently fixed bug in
GListStore.
 2019-02-10 23:14:59 -05:00
Matthias Clasen
f496b4c072 add more autoselect tests 2019-02-10 22:19:28 -05:00
Matthias Clasen
2e1a204c49 Reorder tests 
Trying to get to the bottom of a ci failure
 2019-02-10 21:28:53 -05:00
Matthias Clasen
cdb729441e selection tests: Plug a memory leak 2019-02-10 21:08:44 -05:00
Matthias Clasen
e0f8b8e820 Merge branch 'fix-typo' into 'master' 
typo correction

See merge request GNOME/gtk!573
 2019-02-10 23:44:16 +00:00
Matthias Clasen
916508f3db stack: Drop the position property 
GtkStackSwitcher and GtkStackSidebar no longer
use the GtkStackPage::position property, so we
don't need to maintain it anymore.
 2019-02-10 18:43:59 -05:00
Matthias Clasen
9255a12493 stack sidebar: Use the selection model 
Make GtkStackSidebar and GtkStack communicate via
the selection model that GtkStack now exposes.

This is parallel to the GtkStackSwitcher changes
in the previous commit.
 2019-02-10 18:43:59 -05:00
Matthias Clasen
976664c004 a11y tests: Adapt to changes 
The buttons in the stack switcher are now toggle buttons, no
longer radio buttons. Update expected output for that.
 2019-02-10 18:43:59 -05:00
Matthias Clasen
8595665524 stack switcher: Use the selection model 
Make GtkStackSwitcher and GtkStack communicate via
the selection model that GtkStack now exposes.
 2019-02-10 18:43:59 -05:00
Matthias Clasen
7b08d13aea stack: Provide a selection model 
Make GtkStack expose a selection model for its pages.
The model can be used to track changes to the pages,
and to change what child is visible.
 2019-02-10 18:43:59 -05:00
Matthias Clasen
dc0750f6ef stack: Add a GtkStackPage::visible property 
This will let GtkStackSwitcher track visibility
without having to interact with the widgets directly.
 2019-02-10 18:43:59 -05:00