Matthias Clasen
1afca5510a
Prevent a segfault if GtkAppChooserDialog gets disposed early
...
If the async call is finished after the dialog is already disposed,
bad things happen. Prevent that by marking the dialog as dismissed
in this case.
2013-05-02 20:00:49 -04:00
Tristan Van Berkom
d50516ebd7
GtkAppChooserDialog: Define children with a GtkBuilder template
2013-04-08 21:19:28 +09:00
Cosimo Cecchi
944fa635ae
appchooserdialog: remove redundant checks
...
This is checked by GIO for us now.
Also, it's generally just a bad idea spawning error dialogs from inside
a library on top of other dialogs: lesson learned.
https://bugzilla.gnome.org/show_bug.cgi?id=675333
2013-03-04 14:41:21 -05:00
Cosimo Cecchi
319bb2641b
appchooserdialog: add a missing label mnemonic
...
https://bugzilla.gnome.org/show_bug.cgi?id=681577
2012-08-10 13:28:01 +02:00
Javier Jardón
9d0febc9a6
Change FSF Address
2012-02-27 17:06:11 +00:00
Cosimo Cecchi
2ae2c443d0
app-chooser-dialog: cancel the PK operation when the dialog is dismissed
...
This doesn't really seem to have any effect; probably PK doesn't listen
for changes on the passed-in cancellable, but it's correct.
Related to: https://bugzilla.gnome.org/show_bug.cgi?id=649121
2012-02-01 13:21:43 -05:00
Cosimo Cecchi
623b5192cc
app-chooser-dialog: make sure to hold a ref when doing async ops
...
Hold a ref to the GtkDialog while doing async operations with the
GtkAppChooserOnline object.
This is needed, since somebody could call gtk_widget_destroy() on us
while an async operation is in progress. We don't want to be finalized
in that case, but mark the fact that we were dismissed and just return
from the callback in that case.
This avoids crashing if the dialog is destroyed in the middle of a PK
operation.
https://bugzilla.gnome.org/show_bug.cgi?id=649121
2012-02-01 13:21:43 -05:00
Cosimo Cecchi
3a6996ea83
appchooser: make the "Find applications online" follow search state
...
Set the button as insensitive while searching, so that it can't be
accidentally clicked twice.
https://bugzilla.gnome.org/show_bug.cgi?id=651818
2011-10-04 11:34:10 -04:00
Cosimo Cecchi
569b5ffd5b
appchooser: add a GCancellable to the search operation
...
So that we can cancel it when the dialog is destroyed.
https://bugzilla.gnome.org/show_bug.cgi?id=651818
2011-10-04 11:34:10 -04:00
Matthias Clasen
f9379adca2
GtkAppChooserButton: Add a way to include the default app
...
This is necessary to use an app chooser button for selecting
default apps in the control center. Also, beef up the docs
for this widget family.
https://bugzilla.gnome.org/show_bug.cgi?id=642706
2011-09-10 01:42:07 -04:00
Matthias Clasen
18dba17f0b
GtkAppChooserDialog: handle sensitivity of 'Select' better
...
When the dialog comes up without a selected item, make 'Select'
insensitive. Also, don't allow to unselect an item without
selecting a different one.
2011-08-28 23:49:41 -04:00
Matthias Clasen
6d797d5356
GtkAppChooser: Deal with 'no app found' gracefully
...
Several functions inside GtkAppChooserDialog were not handling
the situation that app_info might be NULL after the user clicked
'Select'.
https://bugzilla.gnome.org/show_bug.cgi?id=651827
2011-08-28 22:46:46 -04:00
Diego Celix
372a907e97
gtkappchooserdialog: gtk_misc_set_alignment
...
Replacing the function gtk_misc_set_alignment () with
gtk_widget_set_halign () and gtk_widget_set_valign () in
gtk/gtkappchooserdialog.c
https://bugzilla.gnome.org/show_bug.cgi?id=650762
2011-08-28 20:16:56 -04:00
Matthias Clasen
ca0c7c1649
GtkAppChooserDialog: remove an unused variable
2011-08-24 00:32:20 -04:00
Matthias Clasen
80b94156ed
GtkAppChooserDialog: Simplify the construction
...
We do the same in other places.
2011-08-24 00:11:32 -04:00
Alexander Larsson
e274dbbdce
Ensure we always grab the gdk lock in async callbacks
...
Async callbacks are delivered in idles, so we need to make sure
we get the gdk lock before calling any gdk/gtk stuff. This was
missing in a few places.
2011-03-28 12:49:17 +02:00
Tristan Van Berkom
c844a24ae6
Allow GtkAppChooser classes to be instantiated with content-type=NULL.
...
Mostly for corner cases such as Glade that treats objects generically
and needs to have an object that doesnt crash out of g_object_new().
2011-03-01 19:41:15 +09:00
Matthias Clasen
9be8bbc9a0
Add gtk_app_chooser_button_get/set_heading
2011-01-24 19:25:08 -05:00
Matthias Clasen
a7bcb8a4d7
Add a way to set the heading of GtkAppChooserDialog
...
The application can probably set a better string than the default
we construct, like 'Select an application for "software" files'.
2011-01-20 20:57:47 -05:00
Matthias Clasen
70879d345f
Change the label of the GtkAppChooserDialog button
...
We are not "opening" an application, we are selecting it to
open a file. String change !
2011-01-20 19:59:55 -05:00
William Jon McCann
bbe56c1f9a
Make the show more button follow the show-other property
...
Instead of show-all.
https://bugzilla.gnome.org/show_bug.cgi?id=640006
2011-01-20 19:45:22 -05:00
Matthias Clasen
6cdb6255af
More documentation fixes
2011-01-06 09:44:08 -05:00
Matthias Clasen
7b88b29763
Add appchooser docs
2011-01-06 02:07:35 -05:00
Cosimo Cecchi
a5fe3fef7b
appchooserdialog: use new GLib API to modify positioning
...
The dialog will always show up with the last selected application.
2010-12-20 16:08:21 +01:00
Matthias Clasen
d5df33c75f
Fix abi check after recent merges
2010-12-05 12:18:30 -05:00
Cosimo Cecchi
4fe23cae78
app-chooser: other misc doc fixes
2010-11-30 17:27:53 +01:00
Cosimo Cecchi
d8ef15c592
app-chooser: update docs
2010-11-30 15:03:33 +01:00
Cosimo Cecchi
51cb082022
app-chooser-online: rework of the online module
...
- the _get_default() method is now async
- the PackageKit module will return NULL in case PackageKit is not
available in the session bus
- the dummy module doesn't exist anymore
- the dialog won't display the online button in case there's no module
available
2010-11-29 18:10:06 +01:00
Matthias Clasen
a498d9a9ba
Coding style fixups
...
This commit adjusts the app chooser code to GTK+ coding style:
- line up prototypes
- remove some excess {}
- remove tabs and trailing whitespace
- add docs
2010-11-24 18:32:05 -05:00
Cosimo Cecchi
627f9b70a7
app-chooser-dialog: add a 'Forget Association' context menu item
2010-11-24 17:12:08 +01:00
Cosimo Cecchi
067b4ccb33
Revert "open-with-dialog: remove automatic setting of support-for-type"
...
This reverts commit 4cfe121296
.
Conflicts:
gtk/gtkappchooserdialog.c
2010-11-24 15:49:47 +01:00
Cosimo Cecchi
05bb715c51
app-chooser: rename GtkOpenWith to GtkAppChooser
2010-11-23 17:50:15 +01:00