Commit Graph

10393 Commits

Author SHA1 Message Date
Michael Natterer
971023d922 Some unrelated cleanups found while reviewing the offscreen window patch:
2008-06-30  Michael Natterer  <mitch@imendio.com>

	Some unrelated cleanups found while reviewing
	the offscreen window patch:

	* gdk/gdkwindow.c: add missing Since: 2.14 to the redirection
	functions, fix some function header indentation, update
	documentation of redirect_to_drawable().

	* gdk/x11/gdkwindow-x11.c
	* gdk/x11/gdkpixmap-x11.c: fix function header
	formatting/indentation.

	* gtk/gtkwidget.c: use I_() on "damage_event".


svn path=/trunk/; revision=20708
2008-06-30 12:15:29 +00:00
Michael Natterer
2e3c1149ae remove duplicate declaration of _gdk_window_new().
2008-06-30  Michael Natterer  <mitch@imendio.com>

	* gdk/gdkinternals.h: remove duplicate declaration of
	_gdk_window_new().


svn path=/trunk/; revision=20707
2008-06-30 11:04:42 +00:00
Michael Natterer
b4201d4de9 reorder source lists alphabetically.
2008-06-30  Michael Natterer  <mitch@imendio.com>

	* gdk/Makefile.am: reorder source lists alphabetically.


svn path=/trunk/; revision=20706
2008-06-30 10:44:47 +00:00
Matthias Clasen
ab019f3ade Avoid unnecessary redraws when resizing. Patch by Owen Taylor
* gtk/gtkwindow.c: Avoid unnecessary redraws when resizing.
        Patch by Owen Taylor


svn path=/trunk/; revision=20705
2008-06-30 05:17:02 +00:00
Behdad Esfahbod
e670565932 Bug 530255 – GtkAboutDialog cuts off comments label Followup patch from
2008-06-29  Behdad Esfahbod  <behdad@gnome.org>

        Bug 530255 – GtkAboutDialog cuts off comments label
        Followup patch from  Jan Arne Petersen

        * gtk/gtklabel.c (gtk_label_get_layout_offsets): Ensure layout.


svn path=/trunk/; revision=20703
2008-06-29 17:17:09 +00:00
Michael Natterer
5390e1e24c properly indent the newly added GtkSelectionData accessors. Some newlines
2008-06-28  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkselection.h: properly indent the newly added
	GtkSelectionData accessors. Some newlines can't hurt either.


svn path=/trunk/; revision=20702
2008-06-28 17:02:20 +00:00
Mikael Hallendal
ff7f25c9af Removed accidental empty row in gtk_box_pack.
2008-06-27  Mikael Hallendal  <micke@imendio.com>

	* gtk/gtkbox.c (gtk_box_pack): Removed accidental empty row.

svn path=/trunk/; revision=20701
2008-06-28 16:21:28 +00:00
Mikael Hallendal
257ca7ef7d Factor out gtk_box_pack from gtk_box_pack_start and gtk_box_pack_end to reduce code duplication.
2008-06-27  Mikael Hallendal  <micke@imendio.com>

        * gtk/gtkbox.c (gtk_box_pack, gtk_box_pack_start, gtk_box_pack_end):
        Factored out gtk_box_pack from gtk_box_pack_start and use it from both
        pack_start and pack_end in order to reduce the code duplication.

svn path=/trunk/; revision=20700
2008-06-28 16:16:26 +00:00
Michael Natterer
b8cee08351 Bug 442042 – GtkScaleButton is too limited
2008-06-27  Michael Natterer  <mitch@imendio.com>

	Bug 442042 – GtkScaleButton is too limited

	* gtk/gtkscalebutton.c (gtk_scale_button_init): set the name
	"gtk-scalebutton-popup-window" on the popup window so it is
	properly themeable.


svn path=/trunk/; revision=20698
2008-06-27 20:13:25 +00:00
Kristian Rietveld
cf3542155f adapt to use GdkWindowImpl interface.
2008-06-27  Kristian Rietveld  <kris@imendio.com>

	* gdk/quartz/gdkgeometry-quartz.c:
	* gdk/quartz/gdkwindow-quartz.c:
	* gdk/quartz/gdkprivate-quartz.h: adapt to use GdkWindowImpl
	interface.


svn path=/trunk/; revision=20697
2008-06-27 17:06:06 +00:00
Carlos Garnacho
b3bb8c47b5 Fix two potential critical warnings. Bug #539470.
2008-06-27  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtkrecentmanager.c (get_icon_for_mime_type): Fix two potential
        critical warnings. Bug #539470.

svn path=/trunk/; revision=20696
2008-06-27 15:33:42 +00:00
Emmanuele Bassi
e27632cd6d Abstract some GdkWindow API into an interface that the backends must
2008-06-27  Emmanuele Bassi  <ebassi@gnome.org>

	Abstract some GdkWindow API into an interface that the backends
	must implement. (based on a patch by Alex Larsson)

	* gdk/Makefile.am: Add gdkwindowimpl.[ch]

	* gdk/gdk.symbols: Move symbols around.

	* gdk/gdkinternals.h:
	* gdk/gdkwindowimpl.[ch]: Move some of the GdkWindow API we require
	from the backends to a GInterface that the backends should implement
	instead.

	* gdk/gdkwindow.c: Provide some of the GdkWindow public API as a
	wrapper call around the GdkWindowImpl interface vtable.

	* gdk/x11/gdkevents-x11.c:
	* gdk/x11/gdkgeometry-x11.c:
	* gdk/x11/gdkprivate-x11.h:
	* gdk/x11/gdkwindow-x11.c:
	* gdk/x11/gdkwindow-x11.h: Update the X11 backend to implement
	the GdkWindowImpl interface.

svn path=/trunk/; revision=20695
2008-06-27 14:27:44 +00:00
Martyn James Russell
cf1df130dc Fixed the FAQ location in the warning produced here.
* gtk/gtkcontainer.c: (gtk_container_add): Fixed the FAQ location
	in the warning produced here.

svn path=/trunk/; revision=20693
2008-06-27 11:51:40 +00:00
Michael Natterer
53d96e46f4 Bug 442042 – GtkScaleButton is too limited
2008-06-27  Michael Natterer  <mitch@imendio.com>

	Bug 442042 – GtkScaleButton is too limited

	* gtk/gtkscalebutton.c: add "orientation" property. Make sure the
	stuff that is part of the public API continues to be created in
	init() to stay compatible. Move creating of the popup scale to
	constructor(). Add an internal HScale class. Changed popup
	positioning for horizontal scales accordingly.


svn path=/trunk/; revision=20692
2008-06-27 09:33:32 +00:00
Michael Natterer
d79185cf1f gtk/gtkscalebutton.c remove redundant init() and class_init() prototypes,
2008-06-26  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkscalebutton.c
	* gtk/gtkvolumebutton.c: remove redundant init() and class_init()
	prototypes, remove redundant includes, remove a little trailing
	whitespace.


svn path=/trunk/; revision=20691
2008-06-26 17:14:27 +00:00
Richard Hult
2f29e8d9f5 Patch from Christian Dywan to clean up selection data setting.
2008-06-26  Richard Hult  <richard@imendio.com>

	* gtk/gtkclipboard-quartz.c: (gtk_clipboard_wait_for_contents):
	* gtk/gtkquartz.c:
	(_gtk_quartz_get_selection_data_from_pasteboard),
	(_gtk_quartz_set_selection_data_for_pasteboard): Patch from
	Christian Dywan to clean up selection data setting.

svn path=/trunk/; revision=20690
2008-06-26 13:01:40 +00:00
Richard Hult
2e6f82b987 Don't use deprecated function gtk_widget_ref, replace with g_object_ref.
2008-06-26  Richard Hult  <richard@imendio.com>

	* gtk/gtkdnd-quartz.c (gtk_drag_begin_internal): Don't use
	deprecated function gtk_widget_ref, replace with g_object_ref.

svn path=/trunk/; revision=20689
2008-06-26 12:44:10 +00:00
Michael Natterer
1a6b0cb1ca #include "config.h"
2008-06-26  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkfilesystem.c: #include "config.h"


svn path=/trunk/; revision=20688
2008-06-26 10:19:23 +00:00
Carlos Garnacho
1732652e71 current_folder can be NULL here, do not try to reference it (Bug #540235)
2008-06-26  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtkfilechooserdefault.c
        (gtk_file_chooser_default_get_current_folder): current_folder can be
        NULL here, do not try to reference it (Bug #540235)
        (gtk_file_chooser_default_get_files): Deal better with
        gtk_file_chooser_default_get_current_folder() being able to return
        NULL.

svn path=/trunk/; revision=20687
2008-06-26 09:41:13 +00:00
Michael Natterer
260e94547f allocate the GtkTextUtilCallbackInfo structs with GSlice.
2008-06-26  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktextutil.c (_gtk_text_util_append_special_char_menuitems):
	allocate the GtkTextUtilCallbackInfo structs with GSlice.


svn path=/trunk/; revision=20686
2008-06-26 09:06:48 +00:00
Michael Natterer
3d322ce16a there is no reason to include <gtk/gtktypebuiltins.h> in the middle of the
2008-06-25  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktypeutils.h: there is no reason to include
	<gtk/gtktypebuiltins.h> in the middle of the file, move it to top,
	replacing the <glib-object.h> include. Also move the remaining few
	non-deprecated things to the top and move some deprecated things
	around to clean up the mess with too many deprecated sections even
	more.


svn path=/trunk/; revision=20685
2008-06-25 09:32:38 +00:00
Michael Natterer
0c1f022ba7 deprecate gtk_type_init() unconditionally (also for GTK_COMPILATION). Move
2008-06-24  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktypeutils.h: deprecate gtk_type_init() unconditionally
	(also for GTK_COMPILATION). Move some deprecated typedefs around
	to reduce the mess with zillions of deprecated sections.

	* gtk/gtkmain.c (do_post_parse_initialization): replace the call
	to gtk_type_init() by g_type_init() and gtk_object_get_type() even
	though the latter is probably completely pointless.


svn path=/trunk/; revision=20684
2008-06-24 19:11:30 +00:00
Johan Dahlin
c472d99c0b Revert GtkScaleButton accesses for plus/minus buttons, as per #539944
svn path=/trunk/; revision=20682
2008-06-24 13:41:13 +00:00
Michael Natterer
24c0eb5d39 also revert change in how the dialog's vbox was added (bug #539732).
2008-06-24  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkdialog.c (gtk_dialog_init): also revert change in how
	the dialog's vbox was added (bug #539732).


svn path=/trunk/; revision=20681
2008-06-24 10:49:12 +00:00
Carlos Garnacho
60e1b3ea89 Remove container implementation, which isn't thought for handling
2008-06-24  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtkdialog.[ch]: Remove container implementation, which isn't
        thought for handling non-direct children. Fixes #539732.
        (gtk_dialog_pack_start) (gtk_dialog_pack_end): Removed as well, it
        doesn't provide enough control to API users (removing, reordering...),
        this is better handled through:
        (gtk_dialog_get_content_area): New function which just returns
        dialog->vbox.
        * gtk/gtk.symbols: Modify accordingly.
        * docs/reference/gtk/tmpl/gtkdialog.sgml: Update docs to recommend
        using gtk_dialog_get_[action|content]_area() instead of accessing
        dialog struct members directly.

svn path=/trunk/; revision=20680
2008-06-24 10:22:40 +00:00
Michael Natterer
a13f698b3a gtk/gtkassistant.h gtk/gtkcellrenderer.h gtk/gtkfilechooserentry.h
2008-06-24  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkassistant.h
	* gtk/gtkcellrenderer.h
	* gtk/gtkfilechooserentry.h
	* gtk/gtkprivate.h
	* gtk/gtktooltip.h
	* gtk/gtktreeview.h
	* gtk/gtkwindow.h: no need to include gtkwidget.h or gtkobject.h
	if there is any other widget included, they all have to include
	their respective parent classes (the is-a relation works for
	includes too).


svn path=/trunk/; revision=20679
2008-06-24 10:16:01 +00:00
Michael Natterer
7146dd12e5 remove includes from this internal header.
2008-06-24  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktextutil.h: remove includes from this internal header.

	* gtk/gtktextutil.c: include gtktextbuffer.h before gtktextutil.h.


svn path=/trunk/; revision=20678
2008-06-24 09:55:08 +00:00
Michael Natterer
257cfa289b formatting.
2008-06-23  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkinvisible.h: formatting.


svn path=/trunk/; revision=20676
2008-06-23 14:28:13 +00:00
Michael Natterer
77e99003a8 gtk/gtkaction.h gtk/gtkbuildable.h gtk/gtkbuilderprivate.h
2008-06-23  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkaction.h
	* gtk/gtkbuildable.h
	* gtk/gtkbuilderprivate.h
	* gtk/gtkcelllayout.h
	* gtk/gtkentrycompletion.h
	* gtk/gtkfilechoosersettings.h
	* gtk/gtkfilesystem.h
	* gtk/gtkfilesystemmodel.h
	* gtk/gtkicontheme.h
	* gtk/gtklinkbutton.h
	* gtk/gtkpagesetup.h
	* gtk/gtkpapersize.h
	* gtk/gtkprintcontext.h
	* gtk/gtkprintoperation.h
	* gtk/gtkprintoperationpreview.h
	* gtk/gtkprintsettings.h
	* gtk/gtkrecentchooserprivate.h
	* gtk/gtkrecentmanager.h
	* gtk/gtksearchengine.h
	* gtk/gtktexttag.h
	* gtk/gtktreeselection.h
	* gtk/gtktreeviewcolumn.h
	* gtk/gtkuimanager.h: remove redundant inclusion of <glib.h> and
	<glib-object.h>. There is no point in relying on them being pulled
	in by other headers in some places and placing them explicitly in
	other places, so choose the "as little includes as possible"
	approach and get rid of them.


svn path=/trunk/; revision=20675
2008-06-23 14:07:19 +00:00
Kristian Rietveld
ed7d0ed47e do not hard code the prefix of the enum, use @ENUMPREFIX@ instead (you
2008-06-23  Kristian Rietveld  <kris@imendio.com>

	* gdk/gdkenumtypes.h.template:
	* gdk-pixbuf/gdk-pixbuf-enum-types.h.template:
	* gtk/gtktypebuiltins.h.template:
	* perf/typebuiltins.h.template: do not hard code the prefix of the
	enum, use @ENUMPREFIX@ instead (you need an up to date glib for this).


svn path=/trunk/; revision=20674
2008-06-23 12:09:15 +00:00
Michael Natterer
7dfaf81ee2 gtk/gtkmountoperation.h gtk/gtktestutils.h remove as many includes as
2008-06-23  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkmountoperation.h
	* gtk/gtktestutils.h
	* gtk/gtkshow.[ch]: remove as many includes as possible from these
	new files. They can't be included individually, so nothing can break.


svn path=/trunk/; revision=20673
2008-06-23 10:47:22 +00:00
Michael Natterer
91f84cd1d8 use g_param_spec_flags(), not enum() when registering the "modifier-mask"
2008-06-22  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkaccelgroup.c: use g_param_spec_flags(), not enum() when
	registering the "modifier-mask" property.


svn path=/trunk/; revision=20670
2008-06-22 16:42:22 +00:00
Johan Dahlin
d97cdbdf53 Include "config.h" instead of <config.h> Command used: find -name
2008-06-21  Johan Dahlin  <jdahlin@async.com.br>

    * *.[ch]: Include "config.h" instead of <config.h>
    Command used:
    find -name \*.[ch]|xargs perl -p -i -e 's/^#include <config.h>/#include "config.h"/g'
    Rubberstamped by Mitch and Tim


svn path=/trunk/; revision=20669
2008-06-22 14:28:52 +00:00
Carlos Garnacho
56bbbbf553 Bug 539466 – GtkMenuShell API/ABI break in trunk.
2008-06-21  Carlos Garnacho  <carlos@imendio.com>

        Bug 539466 – GtkMenuShell API/ABI break in trunk.

        * gtk/gtkmenushell.h: Fix API/ABI break, two guint fields had
        different name and packing width.

svn path=/trunk/; revision=20666
2008-06-21 14:56:07 +00:00
Johan Dahlin
a1362779ee Cast to guint8* to avoid a compiler warning.
2008-06-21  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkiconcachevalidator.c (check_pixel_data): Cast to guint8* to avoid
    a compiler warning.


svn path=/trunk/; revision=20665
2008-06-21 13:09:57 +00:00
Johan Dahlin
33d64796d0 Document a style property
2008-06-20  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkbutton.c: Document a style property


svn path=/trunk/; revision=20664
2008-06-21 12:34:12 +00:00
Michael Natterer
aefbaedc61 remove redundant include, fix indentation, replace header by a GDK
2008-06-21  Michael Natterer  <mitch@imendio.com>

	* gdk/gdkapplaunchcontext.h: remove redundant include, fix
	indentation, replace header by a GDK copyright header (don't say
	"The Gnome Library"), remove trailing whitespace.


svn path=/trunk/; revision=20663
2008-06-21 10:44:26 +00:00
Hans Breuer
d3ce448c20 fix 'function' : incompatible types - from 'struct _cairo *' to 'struct
2008-06-21  Hans Breuer  <hans@breuer.org>

	* gtk/gtkprintoperation-win32.c(1713) : fix 'function' : incompatible 
	types - from 'struct _cairo *' to 'struct _cairo_surface *' by
	passing the surface to cairo_surface_show_page(), not the context
	* gtk/gtkprintoperation-win32.c(866) : get rid of warning C4018: 
	'<' : signed/unsigned mismatch by using guint for the loop

	* gtk/gtkmenu.c(gtk_menu_get_property) : property 'menu::active' is 
	an uint, gtk_menu_get_active() returns the widget pointer. Convert
	the latter to the former by calculating the index in menu::children
	Also fix some occurences of g_return_if_fail() where 
	g_return_val_if_fail() was meant


svn path=/trunk/; revision=20662
2008-06-21 09:49:00 +00:00
Björn Lindqvist
743eebc1a5 Bug 539363 – Segfault when creating GtkPlugs
2008-06-21  Björn Lindqvist  <bjourne@gmail.com>

	Bug 539363 – Segfault when creating GtkPlugs

	* gtk/gtkplug.c (gtk_plug_class_init): Spaces not allowed in
	property names. "socket window" => "socket-window"

svn path=/trunk/; revision=20661
2008-06-21 01:03:25 +00:00
Jody Goldberg
87caf0d3ae Fix life cycle to avoid crash. [#536966]
2008-06-20  Jody Goldberg <jody@gnome.org>

	* gtk/gtkprintoperation-win32.c (gtk_print_run_page_setup_dialog) : 
	  Fix life cycle to avoid crash. [#536966]

svn path=/trunk/; revision=20660
2008-06-21 00:53:17 +00:00
Hans Breuer
8e2ef4982b must return a value of the appropriate type with g_return_val_if_fail
2008-06-20  Hans Breuer  <hans@breuer.org>

	* gtk/gtkmenuitem.c gtk/gtkmessagedialog.c gtk/gtkplug.c : must return
	a value of the appropriate type with g_return_val_if_fail
	
	* gdk/gdkconfig.h.win32 : add the GSEAL definition here as well

	* gtk/gtkfilesystem.c : don't add the "File System" on win32

	* tests/makefile.msc : remove broken autotestfile(system|chooser) 
	from build


svn path=/trunk/; revision=20657
2008-06-20 20:39:22 +00:00
Johan Dahlin
2e75eb1330 Document and use - instead of _ in signal names.
2008-06-20  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkeditable.c: Document and use - instead of _ in signal names.


svn path=/trunk/; revision=20656
2008-06-20 20:11:46 +00:00
Johan Dahlin
ef5e0e9601 Fix up deprecated markup syntax. Add version numbers and a message on the
2008-06-20  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkbutton.c:
    * gtk/gtkcolorsel.c:
    * gtk/gtkentry.c:
    * gtk/gtkitemfactory.c:
    * gtk/gtknotebook.c:
    Fix up deprecated markup syntax. Add version numbers and
    a message on the remaning ones.


svn path=/trunk/; revision=20655
2008-06-20 19:42:53 +00:00
Mikael Hallendal
df11b00dae Replaced use of gtk_signal_connect with the g_signal_connect equivalents.
2008-06-20  Mikael Hallendal  <micke@imendio.com>

	* tests/testthreads.c: Use g_signal_connect instead of
	gtk_signal_connect.

	* demos/testgtk/main.c: switched to use GSignal instead of GtkSignal.
	While the code is not built, people may still look at it.

svn path=/trunk/; revision=20654
2008-06-20 19:26:50 +00:00
Kjartan Maraas
0eba9bf8fe reviewed by: <Carlos Garnacho <garnacho@gnome.org>
2008-06-20  Kjartan Maraas  <kmaraas@gnome.org>

	reviewed by: <Carlos Garnacho <garnacho@gnome.org>

	* gtk/gtkbuilder.h:
	* gtk/gtkliststore.h:
	* gtk/gtkobject.h:
	* gtk/gtktextchild.h:
	* gtk/gtktreemodelfilter.h:
	* gtk/gtktreemodelsort.h:
	* gtk/gtktreestore.h:
	#include <gdkconfig.h> not <gdk/gdkconfig.h>

svn path=/trunk/; revision=20653
2008-06-20 18:52:52 +00:00
Martyn James Russell
c8322b8c0e Fix warnings from calling g_object_notify() on a GtkAccelGroup without
* gtk/gtkaccelgroup.c: Fix warnings from calling
	g_object_notify() on a GtkAccelGroup without casting to a
	GObject.

svn path=/trunk/; revision=20652
2008-06-20 15:10:00 +00:00
Johan Dahlin
755a662ff2 Modernize and order things as most other objects. Defines at the top,
2008-06-20  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkcolorsel.c: Modernize and order things as most
    other objects. Defines at the top, class init before init
    before gobject methods before object method before widget
    methods. No changes to the logic done.


svn path=/trunk/; revision=20651
2008-06-20 15:01:31 +00:00
Martyn James Russell
7e374415b6 Don't call g_object_notify() with properties that don't exist. Also, make
* gtk/gtkaccelgroup.c: Don't call g_object_notify() with
	properties that don't exist. Also, make sure we notify for
	the "is-locked" property.

svn path=/trunk/; revision=20650
2008-06-20 14:45:54 +00:00
Johan Dahlin
90bc8940c8 Remove left-over unused property enum.
2008-06-20  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtklayout.c (enum): Remove left-over unused property enum.


svn path=/trunk/; revision=20649
2008-06-20 14:34:50 +00:00
Johan Dahlin
9e400139b7 Add missing accessor for sealed fields GtkScaleButton->plus_button and
2008-06-20  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtk.symbols:
    * gtk/gtkscalebutton.c (gtk_scale_button_get_plus_button),
    (gtk_scale_button_get_minus_button):
    * gtk/gtkscalebutton.h:
    Add missing accessor for sealed fields GtkScaleButton->plus_button and
    minus_button.


svn path=/trunk/; revision=20648
2008-06-20 14:30:28 +00:00