AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity
51,553 Commits 969 Branches 749 Tags 504 MiB
98148d9d60
Commit Graph

142 Commits

Author SHA1 Message Date
Timm Bäder
46828f8e0a expander: fix sizes in resize_toplevel 
We can't use gtk_widget_get_allocation for either non-anchored widgets
(which happens with the child widget when the expander is unexpanded)
nor toplevel windows since that will include the window decorations.

Fixes #70 in gtk3
 2018-03-06 18:11:34 +01:00
Timm Bäder
456ca1062b expander: Make a code snippet compile 2018-01-07 16:38:41 +00:00
Daniel Boles
009e388bb7 Expander: get_label() return is nullable 
Also, use gchar to match the header.
 2017-09-15 18:25:19 +01:00
Daniel Boles
b68892b5be Expander: Annotate new()’s label arg as nullable 
to match new_with_mnemonic()
 2017-09-14 21:19:33 +01:00
Daniel Boles
7b08d11891 Expander: Replace (allow-none) with (nullable) 
The former is deprecated in favour of the latter.
 2017-09-14 21:19:14 +01:00
Daniel Boles
4e1e0cf138 Expander: Explain how to conditionally style arrow 2017-09-14 21:16:16 +01:00
Daniel Boles
18a6c5c4c6 Expander: Don’t set event_window over whole widget 
realize() gave the event_window the allocation of the whole widget. This
was wrong; it should be that of the title_gadget, as in size_allocate().

This broke expanders in which :expanded is TRUE before showing: Input
over the entire widget was sent to the title, making the child unable to
receive it. Clicking the child unexpectedly collapsed it. Once expanded
again, things fixed themselves as size_allocate() fixed the event_window
alloc. So, queuing a reallocate or resize after show() was a workaround.

Fix by giving event_window the allocation of the title_gadget, to match
what size_allocate() does. That is symmetrical and just plain correct.

https://bugzilla.gnome.org/show_bug.cgi?id=774134
 2017-08-29 18:47:33 +01:00
Daniel Boles
32553ad3a2 Expander: Also hide child GdkWindow when collapsed 
Just adding/removing to/from the BoxGadget is not sufficient; that
leaves the GdkWindow hanging around, taking input, changing the cursor,
and all sorts of other nefarious shenanigans.

Resolve by ensuring the child’s GdkWindow is unmapped if collapsed.

Note: the reflexive solution is just to set_visible(child, expanded),
but it is best to avoid messing with the child’s :visible property.

https://bugzilla.gnome.org/show_bug.cgi?id=776937
 2017-08-24 21:18:55 +01:00
Benjamin Otte
e1a03ead7a Use NULL for generic marshallers in g_signal_new() 
glib will use the correct marshaller automatically. And as a side
effect, we also get all glib optimizations, like a va marshaller.
 2016-08-29 16:20:54 +02:00
Matthias Clasen
2148708917 box gadget: Redo expand flag handling 
We only keep one align flag per child, so it seems odd to
keep separate h/v expand flags. Just keep one expand flag
and interpret it according to orientation. Allow setting
the expand flag for child widgets too, though, so we can
make widget expand without interfering with the recursive
widget expand flag.

Update all callers.

Use the new possibility of expanding child widgets to make
the label of check and radio buttons expand. This fixes
unexpected behavior of these widgets in RTL in some places.

https://bugzilla.gnome.org/show_bug.cgi?id=765742
 2016-04-28 21:59:34 -04:00
Matthias Clasen
8a308dd072 expander: Reverse alignments in RTL 
Flip alignments of the title gadget children.
 2016-04-28 21:59:34 -04:00
Matthias Clasen
763daf4420 expander: Reinstate rtl allocation behavior 
In rtl mode, we must not just reverse the children,
but also allocate from the right. Use the newly introduced
box gadget api to achieve this.

https://bugzilla.gnome.org/show_bug.cgi?id=762945
 2016-03-03 21:28:51 -05:00
Matthias Clasen
d2454000f6 expander: Draw focus again 
This was lost when GtkExpander was ported to use box gadgets.
 2016-02-20 11:17:12 -05:00
Matthias Clasen
2a665715b6 expander: Flip the alignment of the vertical box 
To ensure that the title moves to the other side as expected
in RTL, use GTK_ALIGN_START/END instead of GTK_ALIGN_FILL
when packing the title gadget into the vertical box, and
flip the alignment when the text direction changes.
 2016-01-18 00:19:31 -05:00
Matthias Clasen
296f80a580 expander: Handle rtl changes again 
Now that the box gadget has api for it, use it here to
change the order of the gadgets for right-to-left.
 2016-01-18 00:11:54 -05:00
Matthias Clasen
6d18b77ca7 expander: Destroy gadgets after child widgets 
With child widgets now being sorted into box gadgets, bad things
happen if those gadgets disappear prematurely.
 2016-01-15 10:30:08 -05:00
Matthias Clasen
2e27c0af25 expander: Convert to use box gadgets 
Use a vertical box gadget for the overall expander, and a
horizontal one for the title row. This lets us get rid of
all the custom allocation code here.
 2016-01-15 09:43:51 -05:00
Matthias Clasen
5f5dc10820 expander: Deprecate spacing property 
The same can be achieved with margins on the child, and
the spacing property gets in the way of converting the
expander to use box gadgets.
 2016-01-15 09:43:51 -05:00
Matthias Clasen
0acc6578d8 expander: center the arrow 
In lieu of more sophisticated alignment, we need to at least
center the arrow allocation wrt to the label.
 2016-01-14 07:35:59 -05:00
Matthias Clasen
ea4cff1ea4 Use convenience API that was introduced recently 
Use gtk_css_gadget_set_state in all the places where we previously
were getting a node from a gadget, just to call gtk_css_node_set_state.
 2016-01-13 00:19:31 -05:00
Alberto Ruiz
496f0892fc introspection: This patch fixes nullable return values fixes for the following symbols in gtk 
gtk_accel_group_query
  gtk_accel_group_from_accel_closure
  gtk_accel_label_get_accel_widget
  gtk_accessible_get_widget
  gtk_actionable_get_action_name
  gtk_app_chooser_get_app_info
  gtk_app_chooser_button_get_heading
  gtk_app_chooser_dialog_get_heading
  gtk_application_get_window_by_id
  gtk_assistant_get_nth_page
  gtk_binding_set_find
  gtk_builder_get_object
  gtk_builder_lookup_callback_symbol
  gtk_builder_get_application
  gtk_button_get_image
  gtk_cell_area_get_focus_from_sibling
  gtk_cell_renderer_start_editing
  gtk_cell_view_get_model
  gtk_cell_view_get_displayed_row
  gtk_clipboard_get_owner
  gtk_container_get_focus_child
  gtk_container_get_focus_vadjustment
  gtk_container_get_focus_hadjustment
  gtk_dialog_get_widget_for_response
  gtk_drag_get_source_widget
  gtk_drag_dest_get_target_list
  gtk_drag_source_get_target_list
  gtk_entry_completion_get_model
  gtk_entry_completion_compute_prefix
  gtk_expander_get_label_widget
  gtk_file_chooser_get_filename
  gtk_file_chooser_get_current_folder
  gtk_file_chooser_get_uri
  gtk_file_chooser_get_current_folder_uri
  gtk_file_chooser_get_preview_widget
  gtk_file_chooser_get_preview_file
  gtk_file_chooser_get_preview_filename
  gtk_file_chooser_get_preview_uri
  gtk_file_chooser_get_extra_widget
  gtk_file_chooser_get_filter
  gtk_file_chooser_native_get_accept_label
  gtk_file_chooser_native_get_cancel_label
  gtk_file_filter_get_name
  gtk_font_chooser_get_font_family
  gtk_font_chooser_get_font_face
  gtk_font_chooser_get_font
  gtk_font_chooser_get_font_desc
  gtk_font_chooser_get_font_map
  gtk_frame_get_label
  gtk_gesture_get_device
  gtk_gesture_get_window
  gtk_gl_area_get_error
  gtk_header_bar_get_title
  gtk_header_bar_get_subtitle
  gtk_header_bar_get_custom_title
  gtk_icon_info_get_filename
  gtk_icon_view_get_path_at_pos
  gtk_icon_view_get_model
  gtk_image_get_pixbuf
  gtk_image_get_animation
  gtk_label_get_mnemonic_widget
  gtk_label_get_attributes
  gtk_check_version
  gtk_menu_button_get_popup
  gtk_menu_button_get_menu_model
  gtk_menu_button_get_align_widget
  gtk_menu_button_get_popover
  gtk_menu_item_get_submenu
  gtk_menu_item_get_accel_path
  gtk_native_dialog_get_title
  gtk_native_dialog_get_transient_for
  gtk_notebook_get_nth_page
  gtk_notebook_get_tab_label_text
  gtk_notebook_get_menu_label
  gtk_notebook_get_menu_label_text
  gtk_notebook_get_group_name
  gtk_notebook_get_action_widget
  gtk_offscreen_window_get_surface
  gtk_offscreen_window_get_pixbuf
  gtk_paned_get_child1
  gtk_paned_get_child2
  gtk_places_sidebar_get_location
  gtk_places_sidebar_get_nth_bookmark
  gtk_plug_get_socket_window
  gtk_popover_get_default_widget
  gtk_progress_bar_get_text
  gtk_recent_filter_get_name
  gtk_recent_manager_lookup_item
  gtk_settings_get_default
  gtk_socket_get_plug_window
  gtk_stack_sidebar_get_stack
  gtk_stack_switcher_get_stack
  gtk_style_context_get_section
  gtk_style_context_get_parent
  gtk_style_context_get_frame_clock
  gtk_test_find_widget
  gtk_text_buffer_get_mark
  gtk_text_tag_table_lookup
  gtk_text_view_get_tabs
  gtk_text_view_toggle_cursor_visible
  gtk_text_view_get_window
  gtk_toolbar_get_nth_item
  gtk_tool_button_get_label
  gtk_tool_button_get_icon_name
  gtk_tool_button_get_label_widget
  gtk_tool_button_get_icon_widget
  gtk_tool_palette_get_drop_item
  gtk_tool_palette_get_drop_group
  gtk_tree_model_filter_convert_child_path_to_path
  gtk_tree_model_filter_convert_path_to_child_path
  gtk_tree_model_sort_convert_child_path_to_path
  gtk_tree_model_sort_convert_path_to_child_path
  gtk_tree_view_get_column
  gtk_tree_view_get_bin_window
  gtk_tree_view_column_get_widget
  gtk_tree_view_column_get_tree_view
  gtk_widget_get_frame_clock
  gtk_window_group_get_current_device_grab
  GtkTextBufferSerializeFunc
 2016-01-08 12:18:23 +00:00
Cosimo Cecchi
aadc13c4ec builtinicon: save/restore cairo context when rendering 2015-12-19 21:22:37 -08:00
Matthias Clasen
d36c93b91b expander: Fix drawing in rtl 
GtkBuiltinIcon leaves the cairo context in unclean state
when drawing, work around that.
 2015-12-19 11:24:27 -05:00
Matthias Clasen
7d801a4f69 Fix a case a height/width confusion 2015-12-19 11:24:27 -05:00
Matthias Clasen
d51de8cff8 expander: Use a builtin icon 
This saves quite a bit of code.
 2015-12-19 11:24:27 -05:00
Matthias Clasen
666e4135e8 expander: Deprecate style properties 
This can all be done with CSS properties now.
 2015-12-18 09:26:16 -05:00
Matthias Clasen
53787d29ad expander: Let gadget render focus 
This lets us drop lots of allocation fiddling, and reduces
the code that is consulting the style properties we want
to get rid of.
 2015-12-18 08:29:49 -05:00
Matthias Clasen
2f544655f9 Revise CSS node documentation 
Clarify the use of brackets in the CSS node diagrams:
[] means optional nodes or classes, <> means child widgets.
 2015-12-16 10:58:47 -05:00
Matthias Clasen
61fb3f828e expander: Convert to gadgets 
As part of the conversion, add another CSS node for the title
area including the arrow and the label.
 2015-12-15 08:41:16 -05:00
Benjamin Otte
971a277419 cssnode: Change style-changed signal 
Instead of having old and new style, now have a GtkCssStyleChange opaque
object that will compute the changes you are interested in for you.

This simplifies change signal handlers quite a bit and avoids lots of
repeated computation in every signal handler.
 2015-12-12 02:16:04 +01:00
Matthias Clasen
7085595c08 expander: Use the right state when querying style properties 
Failure to do so causes warnings.
 2015-11-17 20:48:50 -05:00
Matthias Clasen
7ba1368c40 epxander: Port to CSS nodes 
Use CSS nodes with name expander and arrow here.
 2015-11-07 00:42:24 -05:00
Matthias Clasen
6a214c9bcd GtkExpander: Fix a problem with resize-toplevel 
The toplevel resizing was not working properly when the
content had non-trivial height-for-width behavior (such
as a wrapping label).
 2014-10-02 18:06:02 -04:00
Benjamin Otte
75ac49c475 Use CHECKED instead of ACTIVE for expanded expanders 
https://bugzilla.gnome.org/show_bug.cgi?id=733967
 2014-08-27 21:27:20 +02:00
Matthias Clasen
43ba93971c GtkExpander: Use G_PARAM_EXPLICIT_NOTIFY 2014-06-09 13:31:01 -04:00
Carlos Garnacho
fbb3fdda8c expander: Use multipress gesture for event management 
This actually acts regardless of the value n_press, alternatively
expanding and collapsing the GtkExpander.
 2014-06-05 16:15:54 +02:00
Cosimo Cecchi
69f2fecb1c expander: don't use focus-line-width 2014-05-09 11:02:46 -07:00
Cosimo Cecchi
24a422631d expander: don't use focus padding 2014-05-09 11:02:43 -07:00
Cosimo Cecchi
d2f77984dc expander: add support for CSS padding and borders 
We need to do this since we're about to remove focus-pad.
 2014-05-09 11:02:43 -07:00
Cosimo Cecchi
b77a8bcb95 expander: always use interior focus 2014-05-09 11:02:41 -07:00
Benjamin Otte
b20d49fc04 expander: Call set_realized() later 
Widgets should only call set_realized() after having created and
registered their GDK windows. In this case, the creation of the style
context (or more exactly: figuring out the scale factor for it) requires
knowing if the widget is already realized. Which it isn't.

https://bugzilla.gnome.org/show_bug.cgi?id=726717
 2014-03-20 14:20:49 +01:00
William Jon McCann
469d333aa2 docs: use Returns: consistently 
Instead of Return value:
 2014-02-19 18:56:05 -05:00
Matthias Clasen
c779b42476 Docs: use // for comments in examples 
Without sgml mode, we can't escape /* as /&ast; anymore,
so just switch to // for comments in examples.
 2014-02-14 23:34:22 -05:00
Matthias Clasen
7f6a964c47 Docs: Remove all entities and turn off sgml mode 
With all element markup gone, it is time to turn off
sgml mode, and get rid of entities as well.
 2014-02-09 17:58:07 -05:00
William Jon McCann
13998c55e7 docs: use proper quotations instead of '*' 2014-02-07 14:22:39 -05:00
William Jon McCann
7a208fbbf3 docs: use proper apostrophe 
https://wiki.gnome.org/Design/OS/Typography
 2014-02-07 13:06:10 -05:00
William Jon McCann
0ce016650b docs: Use markup for links 2014-02-07 09:42:12 -05:00
William Jon McCann
2a45418b67 docs: use proper quotes 2014-02-05 15:08:42 -05:00
William Jon McCann
3b3d8ca456 docs: Use "#" for refsect2 instead of ## 2014-02-04 21:00:58 -05:00
Matthias Clasen
09d1b28249 docs: Convert to markdown 
Specifically, switch to using markdown syntax for sections.
 2014-02-02 00:30:27 -05:00