Alexander Larsson
4ce65f019e
GtkDragSource: Pass return value of drag-cancel into drag_end()
...
This is needed to work as the docs say (don't play fallback cancel animation
if cancel returned TRUE to signal the drop already happened).
2020-05-14 10:44:07 +02:00
Alexander Larsson
707229ce17
gtk-demo/dnd: Use gtk_popover_set_child(), not gtk_box_append
2020-05-14 10:13:05 +02:00
Alexander Larsson
e702d42597
x11 drag: Fix mapped error
...
In the gtk-demo drag-and-drop demo i can't drag anything, all I get
is:
(gtk4-demo:358993): Gdk-CRITICAL **: 09:36:19.617: Surface 0x7e1bb0 has not been mapped in GdkSeatGrabPrepareFunc
This is because GdkX11Drag.ipc_surface is not considered mapped, even
though we called gdk_x11_surface_show() on it, because the
GDK_SURFACE_STATE_WITHDRAWN flag is still set.
I added calls to gdk_synthesize_surface_state() to match what
e.g. show_popup() and gdk_x11_toplevel_present() does.
2020-05-14 09:54:34 +02:00
Matthias Clasen
64db8be7d5
Merge branch 'matthiasc/for-master' into 'master'
...
Matthiasc/for master
See merge request GNOME/gtk!1897
2020-05-14 05:47:26 +00:00
Matthias Clasen
7eaa10dd8e
gtk-demo: Fix a problem with the dnd demo
...
When I move this into gtk-demo, I broke the hack
that ensures the GtkColorSwatch type is registered.
Bring it back.
2020-05-14 01:16:56 -04:00
Matthias Clasen
102e7d0838
widget-factory: Ensure we have some backgrounds
...
The flowbox demo is otherwise less than useful,
if /usr/share/gnome/backgrounds isn't present.
At the same time, give the scale in the listbox
some function.
2020-05-14 00:28:03 -04:00
Matthias Clasen
9f4e7b1249
Merge branch 'matthiasc/for-master' into 'master'
...
Matthiasc/for master
See merge request GNOME/gtk!1896
2020-05-14 03:28:08 +00:00
Matthias Clasen
378cca75ea
Add a test for a flowbox crash
2020-05-13 21:47:11 -04:00
Matthias Clasen
69ab403d78
flowbox: Avoid an assertion in snapshot()
...
The api contract for size_allocate() vfuncs is
that they must allocate all the children that are
going to be snapshotted in snapshot(). The flowbox
size_allocate() was just bailing out when the children
request a size of 0x0, leading to an assertion in
snapshot() vfunc later. Just allocate all children
a size of 0x0 in this case.
2020-05-13 21:47:11 -04:00
Matthias Clasen
33011ccdff
flowbox: Avoid a crash in measure()
...
When the children request a height of zero, the
flowbox measure() function was happily dividing
by that zero, leading to badness.
2020-05-13 21:47:11 -04:00
Matthias Clasen
7915e998e2
listbox: Make Shift-Tab work again
...
The previous fix broke the case where we're Shift-Tabbing
from a listboxrow child to the row itself. This was causing
the widget-factory2.tab-backward test to fail. Fix it, by
grabbing the focus to the row explicitly.
2020-05-13 21:45:49 -04:00
Matthias Clasen
7ef51da1c1
listbox: Don't steal focus-on-click
...
If a row has content that is focus-on-click, and is set
to focus-on-click itself, then the row steals the focus
fromt he content, since it uses focus-on-click on button
release, as opposed to button press. Avoid that by
refusing to take focus if it is already on some
descendent of the row.
This was showing up in the widget-factory listbox on
page 2, where clicking on the spinbutton would briefly
put the focus on the spinbutton, only to lose it to
the row.
2020-05-13 19:43:04 -04:00
Matthias Clasen
ce949c0f25
widget-factory: Cosmetic changes
...
Change which rows in the listbox on page 2 are activatable,
and trigger a dialog. It did not really make sense that this
would happen when clicking on the spin button to focus it.
2020-05-13 19:22:31 -04:00
Matthias Clasen
e9d966488b
gtk-demo: Don't overdraw the fishbowl
...
Set overflow to hidden for the fishbowl widget, so the
blur buttons don't leak out into the window shadow.
2020-05-13 19:21:00 -04:00
Matthias Clasen
4c8688b846
inspector: Disable recursive inspection
...
We can't inspect the inspector, it doesn't work.
Therefore, disable the keybindings in the
inspector window.
2020-05-13 18:56:25 -04:00
Matthias Clasen
cea66139ae
flowbox: Make the children focusable again
...
This broke when the :focusable property was introduced.
The symptom was that keynav in the Emoji chooser did
not work anymore.
2020-05-13 18:27:18 -04:00
Matthias Clasen
c1658903b7
Merge branch 'tests-cleanup' into 'master'
...
Tests cleanup
See merge request GNOME/gtk!1894
2020-05-13 22:19:55 +00:00
Matthias Clasen
15e7bf50df
Merge branch 'matthiasc/for-master' into 'master'
...
Matthiasc/for master
See merge request GNOME/gtk!1895
2020-05-13 21:57:15 +00:00
Matthias Clasen
e87bc3d33d
gtk-demo: Plug a memory leak
...
This leak was there all along. But with the new
gtk_window_destroy(), it shows up as an unclosable
window. Very noticable.
2020-05-13 17:24:57 -04:00
Matthias Clasen
10be40a8b1
scrolledwindow: Fix swapping out child
...
This was not working in the case that the existing child
is not a scrollable. It showed up as crashes of the
scrolling benchmark in gtk4-demo when switching examples.
2020-05-13 17:10:36 -04:00
Matthias Clasen
8e6ec0b8a3
tests: Fix scrolling performance test
...
Maybe this should be added to the benchmarks section
in gtk-demo. For now, fix it to work again.
2020-05-13 17:10:00 -04:00
Matthias Clasen
25577e4fbf
tests: Drop testnoscreen
...
It tests something that no longer works, and that
we probably don't want to guarantee anyway.
See #2738
2020-05-13 16:35:28 -04:00
Matthias Clasen
dc8c37120e
tests: Drop testexpander
...
This was copied into gtk4-demo at some point.
See #2738
2020-05-13 16:23:48 -04:00
Matthias Clasen
a375c41510
tests: Drop testfontchooser
...
This test adds nothing over the font choosers in
our various demos.
See #2738
2020-05-13 16:18:50 -04:00
Matthias Clasen
b8e905eae7
tests: Drop testcolorchooser
...
We have plenty of color choosers in demos.
This test doesn't add anything.
See #2738
2020-05-13 16:15:09 -04:00
Matthias Clasen
d1134e7616
Merge branch 'usable-scales' into 'master'
...
Usable scales
See merge request GNOME/gtk!1893
2020-05-13 20:06:51 +00:00
Matthias Clasen
b0fcf64544
tests: Drop testbox
...
Not useful enough to keep.
See #2738
2020-05-13 16:04:00 -04:00
Matthias Clasen
604f4cf8bf
tests: Drop testcolorchooser2
...
This tests an embedded colorchooser. Just like we have in
widget-factory. And it doesn't work in !srcdir builds, so
it can go.
See: #2738
2020-05-13 15:55:29 -04:00
Matthias Clasen
1420e846b5
tests: Drop testicontheme
...
This is a command line utility for GtkIconTheme
that is probably not as useful as gtk4-icon-browser.
See: #2738
2020-05-13 15:55:21 -04:00
Matthias Clasen
c3aeac19bc
tests: Drop testpixbuf-scale
...
This looks like a GdkPixbuf utility, and we
are moving away from GdkPixbuf anyway.
See: #2738
2020-05-13 15:55:18 -04:00
Matthias Clasen
deef018c68
tests: Drop testtoolbar2
...
This is just a tool bar styling test; we have
the same in the widget factory.
See: #2738
2020-05-13 15:37:21 -04:00
Matthias Clasen
aae0770b82
scale: Make the area around the trough clickable
...
The narrow trough is too hard to hit as a click target.
Make the entire scale clickable.
2020-05-13 15:27:35 -04:00
Matthias Clasen
51ec0f1348
Merge branch 'wip/exalm/ocd' into 'master'
...
demo: Remove double borders from the treeview
See merge request GNOME/gtk!1892
2020-05-13 18:31:39 +00:00
Matthias Clasen
4ed062ec2a
Merge branch 'wip/jimmac/menu-styling-adjustments' into 'master'
...
Wip/jimmac/menu styling adjustments
See merge request GNOME/gtk!1891
2020-05-13 17:18:45 +00:00
Jakub Steiner
69ee1e1b86
Adwaita: use thinner arrows for navigation
...
- go-next go-previous instead of pan-end pan-start
See https://gitlab.gnome.org/GNOME/gtk/-/issues/2675
2020-05-13 17:18:45 +00:00
Alexander Mikhaylenko
3bf6bdae73
demo: Remove double borders from the treeview
2020-05-13 20:57:00 +05:00
sicklylife
d0c54c1286
Update Japanese translation
2020-05-13 15:16:19 +00:00
sicklylife
cbc2493315
Update Japanese translation
2020-05-13 15:12:03 +00:00
Matthias Clasen
fa784aaa06
Cosmetics
2020-05-13 08:11:50 -04:00
Matthias Clasen
ab148c0135
Merge branch 'wip/baedert/for-master' into 'master'
...
Wip/baedert/for master
Closes #2740 , #2742 , and #2741
See merge request GNOME/gtk!1890
2020-05-13 12:08:29 +00:00
Matthias Clasen
10813ddc23
Merge branch 'gtk-demo-expander-fix' into 'master'
...
gtk-demo: Fix expander demo
See merge request GNOME/gtk!1889
2020-05-13 11:44:11 +00:00
Matthias Clasen
8dfdd682cc
Merge branch 'print-editor-new-crash' into 'master'
...
print-editor: Fix crash
See merge request GNOME/gtk!1888
2020-05-13 11:42:00 +00:00
Timm Bäder
9149c79f25
window: Restructure gtk_window_destroy()
...
The previous code was unreffing the window twice, which caused problems
during dialog destruction. Move to g_list_store_find instead of
iterating manually.
ref() the window before and unref() after. g_list_store_remove will
actually unref() the window, since the toplevel_list owns its own
reference.
Fixes #2741
Fixes #2742
2020-05-13 12:18:09 +02:00
Timm Bäder
a50bf27cf2
main: Inline propagate_{down,up} in propagate_internal()
...
Don't have to worry about anyone calling the up/down variants on their
own this way.
2020-05-13 11:52:22 +02:00
Timm Bäder
ddaf50dfcc
window: Create constraint solver on demand
2020-05-13 11:52:16 +02:00
Timm Bäder
8a7fb4b133
widget: Make 1 if out of 2 ifs
2020-05-13 11:52:07 +02:00
Alexander Larsson
a02c588b19
gtk-demo: InfoBar is not a GtkBox anymore
...
Use gtk_info_bar_add_child to add children
2020-05-13 11:04:49 +02:00
Alexander Larsson
fede7cd81c
gtk-demo: Fix expander demo
...
GtkExpander is not a GtkBox anymore, so use the new gtk_expander_set_child()
API.
2020-05-13 10:50:41 +02:00
Alexander Larsson
fcbc972c2a
print-editor: Fix crash
...
We're trying to g_free a GFile, which is not good...
2020-05-13 10:18:17 +02:00
Timm Bäder
9e0bf35941
paned: Fix up the docs once more
2020-05-13 09:42:51 +02:00