Commit Graph

6277 Commits

Author SHA1 Message Date
Matthias Clasen
b4a538d994 Fix a typo. (#163128, kentaro fukuchi)
2005-01-06  Matthias Clasen  <mclasen@redhat.com>

	* README.in: Fix a typo.  (#163128, kentaro fukuchi)
2005-01-06 15:29:56 +00:00
James M. Cape
977a557a67 Use default title if NULL is passed.
2005-01-06  James M. Cape  <jcape@ignore-your.tv>

	* gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_new)
	(gtk_file_chooser_button_new_with_backend): Use default title if
	NULL is passed.

	* docs/reference/gtk/tmpl/gtkfilechooserbutton.sgml: Make examples
	match API.
2005-01-06 06:25:30 +00:00
Federico Mena Quintero
bbea189a4f Fix #161409:
2005-01-05  Federico Mena Quintero  <federico@ximian.com>

	Fix #161409:

	* gtk/gtkfilechooserdefault.c (shortcuts_row_activated_cb): Queue
	a pending operation to select the first row.
2005-01-06 01:53:50 +00:00
Federico Mena Quintero
faaee051d1 Don't call button_data_free() explicitly; the button is weak-reffed and
2005-01-05  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkpathbar.c (_gtk_path_bar_set_path): Don't call
	button_data_free() explicitly; the button is weak-reffed and the
	callback will free the button data.  Fixes #163010.
	(_gtk_path_bar_set_path): Don't ref/sink the button.  And for the
	failure case, call gtk_widget_destroy() on it.

	* gtk/gtkfilechooserdefault.c (check_is_folder): Use
	gtk_file_system_get_folder() again (see the ChangeLog entry from
	2004-08-25).  We can't first get the parent folder and then
	request the info for the path in question, as the parent folder
	may not be readable.  See bug #162617.
	(gtk_file_chooser_default_set_current_folder): Assert that the
	passed-in path is not null.
	(shortcuts_find_current_folder): Likewise.
	(shortcuts_add_current_folder): Likewise.
	(set_list_model): Likewise.
	(gtk_file_chooser_default_map): Only reload the current folder if
	it exists.
	(bookmarks_check_add_sensitivity): Check for the current folder
	being NULL.
	(browse_files_select_first_row): Don't set the cursor if there is
	no model loaded.
2005-01-06 01:46:39 +00:00
Matthias Clasen
9359ede29b Don't construct errors from the GTK_FILE_SYSTEM_ERROR domain. Partial fix
2005-01-05  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilechooserdefault.c: Don't construct errors from
	the GTK_FILE_SYSTEM_ERROR domain. Partial fix for #162911.
	(get_file_info, check_is_folder): Translate errors from
	the filesystem into the GTK_FILE_CHOOSER_ERROR domain. Rest
	of the fix for #162911, noticed by Murray Cumming.
2005-01-05 17:18:01 +00:00
Matthias Clasen
7794fa7f57 Don't construct errors from the GTK_FILE_SYSTEM_ERROR domain. Partial fix
2005-01-05  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilechooserdefault.c: Don't construct errors from
	the GTK_FILE_SYSTEM_ERROR domain. Partial fix for #162911.
2005-01-05 16:57:49 +00:00
Søren Sandmann
8b3a5e1424 Set the background of the windows to None instead of adding EXPOSURE_MASK,
Wed Jan  5 11:42:49 2005  Søren Sandmann  <sandmann@redhat.com>

	* gtk/gtkviewport.c (gtk_viewport_realize):
	* gtk/gtktextview.c ((text_window_realize): Set the background of
	the windows to None instead of adding EXPOSURE_MASK, as suggested
	by Owen in #162112.
2005-01-05 16:46:34 +00:00
Matthias Clasen
7e4cf78803 Update the user time when receiving a WM_DELETE message. (#162980, Elijah
2005-01-05  Matthias Clasen  <mclasen@redhat.com>

	* gdk/x11/gdkevents-x11.c (gdk_wm_protocols_filter): Update
	the user time when receiving a WM_DELETE message.  (#162980,
	Elijah Newren)
2005-01-05 16:27:52 +00:00
Jonathan Blandford
c8bad34daf only reorder on button 1, part of #141937
Tue Jan  4 16:52:14 2005  Jonathan Blandford  <jrb@redhat.com>

        * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
        only reorder on button 1, part of #141937
2005-01-04 22:10:56 +00:00
Søren Sandmann
cfeab5787d Bug 162112.
Tue Jan  4 11:36:43 2005  Søren Sandmann  <sandmann@redhat.com>

	Bug 162112.

	* gtk/gtktextview.c (text_window_realize): Add GDK_EXPOSURE_MASK
	to win->window's event_mask

	* gtk/gtkviewport.c (gtk_viewport_realize): Add GDK_EXPOSURE_MASK
	to viewport->view_window.
2005-01-04 16:39:56 +00:00
Matthias Clasen
9b561cf218 Remove the size_prepared callback, to test incremental display.
2005-01-04  Matthias Clasen  <mclasen@redhat.com>

	* demos/testpixbuf.c (main): Remove the size_prepared callback,
	to test incremental display.
	(new_testrgb_window): Return the drawing area, not the window,
	since we want to queue draws on the drawing area.
2005-01-04 13:44:34 +00:00
Matthias Clasen
44ec61dd97 Re-extract.
2005-01-03  Matthias Clasen  <mclasen@redhat.com>

	* examples/*: Re-extract.

	* docs/tutorial/gtk-tut.sgml: Small corrections.
2005-01-03 19:26:36 +00:00
Matthias Clasen
6803d93d38 Some updates for the drawing section. (#161414, Robert Ancell)
2005-01-03  Matthias Clasen  <mclasen@redhat.com>

	* docs/tutorial/gtk-tut.sgml: Some updates for the drawing
	section.  (#161414, Robert Ancell)
2005-01-03 19:16:20 +00:00
Matthias Clasen
600e5b4721 Make it build.
2005-01-03  Matthias Clasen  <mclasen@redhat.com>

	* docs/tutorial/gtk-tut.sgml: Make it build.
2005-01-03 17:51:38 +00:00
Matthias Clasen
31feb29bdf Some clarification regarding modality. (#112903, Dave Bordoley)
2005-01-03  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkdialog.c (gtk_dialog_run): Some clarification
	regarding modality.  (#112903, Dave Bordoley)
2005-01-03 17:40:36 +00:00
Matthias Clasen
d2203a3fea Add a little motivation. (#145556, Tommi Komulainen)
2005-01-03  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfixed.c (gtk_fixed_set_has_window):
	Add a little motivation.  (#145556, Tommi Komulainen)
2005-01-03 17:21:15 +00:00
Matthias Clasen
af77a6b707 Clarify section on g_signal_connect_swapped. (#120543, David Bourguignon)
2005-01-03  Matthias Clasen  <mclasen@redhat.com>

	* docs/tutorial/gtk-tut.sgml: Clarify section on
	g_signal_connect_swapped.   (#120543, David Bourguignon)
2005-01-03 17:07:56 +00:00
Matthias Clasen
35dfce0f90 Make gtk_icon_theme_load_icon() work independent of icon factory
2005-01-03  Matthias Clasen  <mclasen@redhat.com>

	Make gtk_icon_theme_load_icon() work independent of
	icon factory initialization.  (#162791, Tristan Van Berkom)

	* gtk/gtkiconfactory.[hc]: Rename ensure_default_icons to
	_gtk_icon_factory_ensure_default_icons, and make it non-static.

	* gtk/gtkicontheme.c (find_builtin_icon): ..and call it here.
2005-01-03 14:44:33 +00:00
Matthias Clasen
27c23e4dd5 Don't add a shortcut here. (#162752, Tor Lillqvist)
2005-01-02  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_remove_shortcut_folder):
	Don't add a shortcut here.  (#162752, Tor Lillqvist)
2005-01-03 04:26:33 +00:00
Tor Lillqvist
84c133b9c4 Mention another bug number, too, in my last entry. 2005-01-02 23:32:27 +00:00
Tor Lillqvist
c668f46d9e Add -lole32, needed for CoTaskMemFree in get_special_folder() below.
2005-01-02  Tor Lillqvist  <tml@iki.fi>

	* gtk/Makefile.am (libgtk_target_ldflags): Add -lole32, needed for
	CoTaskMemFree in get_special_folder() below.

	* gtk/gtkfilesystem.h: Implement case-insensitive path compare on
	Win32 using _gtk_file_system_win32_path_compare().

	* gtk/gtk.symbols: Add _gtk_file_system_win32_path_compare.

	* gtk/gtkfilechooserbutton.c (model_add_special)
	* gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Use
	_gtk_file_system_win32_get_desktop() to get correct Desktop folder
	on Win32. (#144003)

	* gtk/gtkfilesystemwin32.c: Remove unnecessary includes. Do
	consider all drives "mounted", including floppies. Trying to
	inspect the contents of a nonexistent floppy will cause errors
	later that are handled normally, no need to avoid them
	completely. Keep the drive type in the GtkFileSystemVolume.
	Support UNC paths. (#161797) Fix error message capitalizations
	as in gtkfilesystemunix.c.

	(gtk_file_system_win32_init): Start one timeout per
	GtkFileSystemWin32.

	(gtk_file_system_win32_finalize): Remove the timeout.

	(get_special_folder): Copied from GLib.

	(_gtk_file_system_win32_get_desktop): New function, uses
	get_special_folder().

	(gtk_file_system_win32_list_volumes): Don't start a timeout at
	each call to this function. Don't assume A: and B: are floppies.

	(gtk_file_system_win32_get_volume_for_path): Don't assume all
	volumes are drive roots, i.e. support share roots of UNC paths
	(\\server\share).

	(gtk_file_system_win32_get_folder): Don't assume errno is set
	after g_file_test() returns FALSE. It isn't on Win32 (and even on
	Unix I don't think one should assume anything about errno after
	g_file_test()).

	(gtk_file_system_win32_volume_get_is_mounted): Always return TRUE.

	(gtk_file_system_win32_volume_get_display_name): Don't call
	GetVolumeInformation() on drives A: or B: if they are removable,
	as they might then be floppies, causing an unnecessary
	delay. (#157820)

	(gtk_file_system_win32_volume_render_icon): Use network icon for
	unrecognized drive types.

	(canonicalize_filename, gtk_file_system_win32_parse): Don't get
	confused by UNC paths.

	(bookmarks_serialize): Use _gtk_file_system_win32_path_compare()
	for case-insensitive UTF-8 path comparison.

	(extract_icon): Use SHGetFileInfo() which is faster than
	ExtractAssociatedIcon(). Icon extraction is still slow, though,
	needs work.

	(win32_pseudo_mime_lookup): Don't use the same icon for all
	shortcuts or executables. Cache only other file type icons.

	(gtk_file_system_win32_render_icon): Use network stock icon for
	remote drives and UNC server share roots. Compare home directory
	case-insensitively. Do lookup icons also for executable files,
	after all, it's these files that can have individual icons in the
	first place. Yes, it can be slow. Needs work.

	(filename_is_drive_root): Require also the slash after the colon.

	(filename_is_server_share): New function.

	(_gtk_file_system_win32_path_compare): New function, does
	case-folded UTF-8 comparison.

	* gtk/gtkfilesystemwin32.h: Declare
	_gtk_file_system_win32_path_compare().
2005-01-02 23:15:21 +00:00
Matthias Clasen
4a6b6aa45c Allow unsetting the custom image by passing NULL. (gtk_button_init):
2005-01-01  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkbutton.c (gtk_button_set_image): Allow unsetting the
	custom image by passing NULL.
	(gtk_button_init): Initialize image_is_stock to TRUE, fixing
	a problem with changing stock labels.  (#162273, Marcin
	Krzyzanowski)
2005-01-02 03:14:34 +00:00
Tor Lillqvist
75ae663dd8 gtk/gtkmodules.c (get_module_path) With g_getenv() now returning UTF-8 on
2005-01-01  Tor Lillqvist  <tml@iki.fi>

	* gtk/gtkmodules.c (get_module_path)
	* gtk/gtkrc.c (gtk_rc_make_default_dir, gtk_rc_get_im_module_file,
	gtk_rc_get_theme_dir, gtk_rc_add_initial_default_files): With
	g_getenv() now returning UTF-8 on Win32, no need to call
	g_locale_to_utf8().
2005-01-01 03:04:17 +00:00
Matthias Clasen
d4e082d71c Don't sort a list of values as if it was a list of entries. This fixes
2004-12-31  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkkeyhash.c (_gtk_key_hash_lookup_keyval)
	(_gtk_key_hash_lookup): Don't sort a list of values as if
	it was a list of entries. This fixes crashes during mnemonic
	activation in the presence of multiple keymaps. (#162488,
	Christian Persch)
2004-12-31 06:40:05 +00:00
Matthias Clasen
3a316fb562 Fix state propagation when making an insensitive combo box sensitive
2004-12-30  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkcombobox.c (gtk_combo_box_button_state_changed): Fix
	state propagation when making an insensitive combo box sensitive
	again.  (#162524, Carlos Garnacho Parro)
2004-12-30 16:15:53 +00:00
Matthias Clasen
db4665b45e Use secondary text for error dialogs.
2004-12-30  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilechooserdefault.c: Use secondary text for error
	dialogs.
2004-12-30 07:42:07 +00:00
Matthias Clasen
be48fff80b Clean up some cases of errno handling (#162496, noted by Tor Lillqvist),
2004-12-30  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilesystemunix.c: Clean up some cases of errno handling
	(#162496, noted by Tor Lillqvist), and use g_filename_display_name()
	for error messages. Also mark some error messages for translation,
	fix capitalization of error messages.
2004-12-30 07:39:45 +00:00
Matthias Clasen
8927a48bf3 Clean up some cases of errno handling (#162496, noted by Tor Lillqvist),
2004-12-30  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilesystemunix.c: Clean up some cases of errno handling
	(#162496, noted by Tor Lillqvist), and use g_filename_display_name()
	for error messages.
2004-12-30 05:40:05 +00:00
Matthias Clasen
f7c6751c29 Use g_value_get_boolean() for ellipsize_set. (#162447, Brian Tarricone)
2004-12-30  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_set_property):
	Use g_value_get_boolean() for ellipsize_set.  (#162447,
	Brian Tarricone)
2004-12-30 05:11:03 +00:00
Tor Lillqvist
5e86a6c9cd Use /usr/share/pixmaps only on Unix.
2004-12-30  Tor Lillqvist  <tml@iki.fi>

	* gtk/gtkicontheme.c (gtk_icon_theme_init): Use /usr/share/pixmaps
	only on Unix.
2004-12-30 00:37:12 +00:00
Matthias Clasen
2833c7ee94 Inherit submenu direction from the parent menu.
2004-12-28  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkmenuitem.c (gtk_menu_item_position_menu): Inherit
	submenu direction from the parent menu.
2004-12-28 07:39:31 +00:00
Matthias Clasen
e77e1e24c2 Return a boolean indicating whether an item in the submenu was selected.
2004-12-28  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkmenushell.c (gtk_menu_shell_select_submenu_first):
	Return a boolean indicating whether an item in the submenu
	was selected.
	(gtk_real_menu_shell_move_current): When going in child
	direction, don't get stuck at completely insensitive
	submenus.  (#162055, Billy Biggs)
2004-12-28 05:33:27 +00:00
Matthias Clasen
676322ac06 Make the clipboard image API more robust (#162357, Torsten Schoenfeld):
2004-12-27  Matthias Clasen  <mclasen@redhat.com>

	Make the clipboard image API more robust (#162357,
	Torsten Schoenfeld):

	* gtk/gtkclipboard.c (clipboard_image_received_func): Don't
	ref the pixbuf if it is NULL.

	* gtk/gtkselection.c (gtk_selection_data_set_pixbuf):
	NULL-terminate the varargs in the call to
	gdk_pixbuf_save_to_buffer().
	(gtk_selection_data_get_pixbuf): Only use a pixbuf loader
	if there is data to load.
2004-12-28 04:31:40 +00:00
Matthias Clasen
34982b41d2 Set x_root and y_root in button and motion events from extended input
2004-12-27  Matthias Clasen  <mclasen@redhat.com>

	* gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
	Set x_root and y_root in button and motion events from
	extended input devices.  (#148715, Robert Ögren)
2004-12-28 01:09:45 +00:00
Matthias Clasen
661ec3189c Fix a typo. (#162339, Alessio Dessi)
* gtk/gtktreeview.c (gtk_tree_view_class_init): Fix a
	typo.  (#162339, Alessio Dessi)
2004-12-27 22:11:04 +00:00
Matthias Clasen
0298076fa1 Document properties as new since 2.4. (#156101, Billy Biggs)
2004-12-27  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkadjustment.c (gtk_adjustment_class_init): Document
	properties as new since 2.4.  (#156101, Billy Biggs)
2004-12-27 06:34:10 +00:00
Matthias Clasen
df1d6fb191 Add a warning about the linux-fb target. (#155488, Zeeshan Ali)
2004-12-27  Matthias Clasen  <mclasen@redhat.com>

	* configure.in: Add a warning about the linux-fb
	target.  (#155488, Zeeshan Ali)
2004-12-27 06:13:07 +00:00
Matthias Clasen
f1f0b19995 Typo fix. (#162278, Torsten Schoenfeld)
2004-12-27  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkmain.c (gtk_init_with_args): Typo fix.  (#162278,
	Torsten Schoenfeld)
2004-12-27 05:25:15 +00:00
Matthias Clasen
d181d74e77 Typo fix. (#162219, Masao Mutoh)
2004-12-26  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilechooser.c (gtk_file_chooser_set_action):
	Typo fix.  (#162219, Masao Mutoh)
	(gtk_file_chooser_set_preview_widget_active):
	Another typo.  (#162218, Masao Mutoh)
2004-12-26 06:35:39 +00:00
Matthias Clasen
1fc0fc6991 Typo fix. (#162219, Masao Mutoh)
2004-12-26  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilechooser.c (gtk_file_chooser_set_action):
	Typo fix.  (#162219, Masao Mutoh)
2004-12-26 06:28:00 +00:00
Matthias Clasen
6e63a0b871 Return TRUE if there are children. (#162134, Iñigo Serna, patch by John
2004-12-23  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkliststore.c (gtk_list_store_iter_children):
	Return TRUE if there are children.  (#162134, Iñigo Serna,
	patch by John Finlay)
2004-12-24 03:48:47 +00:00
Matthias Clasen
f9403b12e3 Transfer state from the button to the cell view to get prelighting right.
2004-12-23  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkcombobox.c (gtk_combo_box_button_state_changed):
	Transfer state from the button to the cell view to get
	prelighting right.  (#156327, Ricardo Veguilla)
2004-12-24 03:44:17 +00:00
Søren Sandmann Pedersen
512a0ebf00 Conflict markers 2004-12-22 19:25:42 +00:00
Søren Sandmann
63f2fd9614 Add sensitivity-changing timeout. Written by Christian Persch.
Wed Dec 22 14:22:19 2004  Søren Sandmann  <sandmann@redhat.com>

	* tests/testtoolbar.c (timeout_cb): Add sensitivity-changing
	timeout. Written by Christian Persch.

Wed Dec 22 14:14:02 2004  Søren Sandmann  <sandmann@redhat.com>

	Bug #161561

	* gdk/x11/gdkwindow-x11.c (tmp_{re,un}set_bg): Only set/reset the
	background for windows that get expose events.

	* gdk/gdkwindow.c (gdk_window_process_updates_internal): Remove
	hack to repaint !expose windows.
2004-12-22 19:25:24 +00:00
Matthias Clasen
e9740d62c3 Don't forget to null the mnemonic_menu when unsetting a mnemonic, reported
2004-12-22  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtklabel.c (gtk_label_setup_mnemonic): Don't forget to
	null the mnemonic_menu when unsetting a mnemonic, reported
	by Owen Taylor.
2004-12-22 18:52:41 +00:00
Matthias Clasen
5ec1648473 Fix sorting of list stores. (#161886, Marcin Krzyzanowski)
2004-12-22  Matthias Clasen  <mclasen@redhat.com>

	Fix sorting of list stores.  (#161886, Marcin Krzyzanowski)

	* gtk/gtkliststore.c (generate_order): Generate the order the
	way it is supposed to be, order[new_pos] == old_pos.
	(gtk_list_store_reorder): Invert the order before using it.

	* gtk/gtkiconview.c (gtk_icon_view_rows_reordered): Adapt to the
	list store fix.
2004-12-22 06:43:32 +00:00
Jonathan Blandford
61978d359b print out the version and binary name in the header comment. Problem
Wed Dec 22 01:24:01 2004  Jonathan Blandford  <jrb@redhat.com>

        * gtk/queryimmodules.c (main): print out the version and binary
        name in the header comment.  Problem reported by Seth Nickell.
2004-12-22 06:26:57 +00:00
Matthias Clasen
4045cc1ac5 Pass a root path to gtk_tree_model_rows_reordered(). (#161720, Marcin
2004-12-20  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkliststore.c (gtk_list_store_sort_iter_changed): Pass a
	root path to gtk_tree_model_rows_reordered().  (#161720,
	Marcin Krzyzanowski)
2004-12-20 17:15:11 +00:00
Matthias Clasen
8454afe8e6 Don't translate NULL messages. (#161789, Morten Welinder)
2004-12-20  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkactiongroup.c (gtk_action_group_translate_string): Don't
	translate NULL messages.  (#161789, Morten Welinder)
2004-12-20 16:05:25 +00:00
Matthias Clasen
7e00903af7 Don't show the secondary label on show_all(). (#161707, Christian Persch)
2004-12-20  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkmessagedialog.c (setup_primary_label_font): Don't show
	the secondary label on show_all().  (#161707, Christian Persch)
2004-12-20 15:50:45 +00:00