AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity
58,699 Commits 969 Branches 749 Tags 504 MiB
b224df8109
Commit Graph

32737 Commits

Author SHA1 Message Date
Matthias Clasen
b224df8109 constraint layout: go back to keeping constraints 
We want to minimize changes to the solver, so
keep the size constraints around and only update
them when the size changes.
 2019-07-01 01:54:57 +00:00
Matthias Clasen
c88e7c180d constraint layout: Use stronger force for min size 
We want our edit constraint to be strong enough to
overpower nat. size constraint, therefore use STRONG * 2.
 2019-07-01 01:49:20 +00:00
Emmanuele Bassi
2aabd64f1a Fix warnings from the introspection scanner 
The name of the arguments of the functions must match the name of the
arguments in the documentation stanza.
 2019-07-01 01:13:00 +01:00
Emmanuele Bassi
7990b24287 Add gtkconstraintguide.h to the public headers 
It needs to be introspected and installed.
 2019-07-01 01:12:25 +01:00
Emmanuele Bassi
c76c1a46e4 Remove specialised API from GtkConstraint 
Thet widget-based API for constraint target and source properties is
unused, and not really necessary.
 2019-07-01 01:05:04 +01:00
Emmanuele Bassi
68fed63eac Add missing documentation for GtkConstraint 2019-07-01 01:02:56 +01:00
Emmanuele Bassi
74c626f835 Document GtkConstraintGuide 2019-07-01 00:48:59 +01:00
Emmanuele Bassi
d45a662679 Move the VFL error domain to a public header 
Since the public API will use it to fill out GErrors, it needs to be
publicly available.
 2019-07-01 00:48:48 +01:00
Emmanuele Bassi
9a463056d0 constraint layout: Notice when guides change 
We need to queue a resize here.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
035baa092c Mark the layout as changed 
We should mark the layout as changed when
constraints are added or removed.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
499738c903 constraint guide: Avoid redundant constraints 
There is no point in creating a stay for nat
size when min == max. And no point in a constraint
for <= G_MAXINT either.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
f2d7433bf6 constraint guide: Fix initial property values 
This was overlooked when the max-width/max-height/
strength properties were added.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
405121bccc constraint solver: Use GTK_NOTE 
Allow using GTK_DEBUG=constraints to get debug
output from the constraints solver.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
cb96b34315 solver: Add private statistics api 
No point in keeping these counters without
a way to show them.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
9edf6fb6cb constraint layout: Dont reset constraints in allocate 
If trust our allocation algorithm, this can never
trigger (and in fact, it never does).
 2019-07-01 00:10:11 +01:00
Matthias Clasen
e3c4fb67ca constraints: Add some internal apis 
Checking if a set is empty or a singleton can
be done more efficiently than determining its size.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
a9dfca04e4 constraint guide: Make strength tweakable 
The strength for the natural width can be used
as a tie-breaker to make instable systems behave
in a more predictable way. This can be seen
in the simple constraints demo in gtk-demo.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
f62fc4e2f2 constraint layout: freeze/thaw on mass ops 
In measure and allocate we are potentially
changing quite a few constraints. Don't
optimize at every step.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
511e2b435e constraints: Use better data structures 
Use a GSequence for GtkVariableSet, to avoid
quadratic behavior.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
3f36340921 constraint layout: Measure min/nat size separately 
Only constraint the opposite direction if we
actually have a for_size, and measure natural
size after removing the edit constraints. With
these changes, the test that compares constraint
layout to grid layout passes.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
b1f0f4478e constraint layout: Use stays for natural size 
It makes more sense to treat the natural size
of both children and guides as stays, since
we want to meet these values as closely as we
can, under the circumstances.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
90f8dcc5e1 constraint layout: Add debug output for guides 
Print out the allocation we end up giving to
guides. This helps in making sense of the
allocations of the child widgets that these
guides relate to.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
b39a5fe5dc constraint guide: Add a name property 
We need to be able to print meaningful debug messages
regarding these objects, and eventually present them
in the inspector too.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
c7ef8411bd constraint guide: Shorten names 
Now that this is its own source file,
no need for these prefixes anymore.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
dab8a8b5c5 constraint layout: Measure more correctly 
Set up all constraints for minimum + natural
width + height when measuring, regardless
of the orientation we're measuring. Anything
else will lead to incorrect answers when
there are constraints that cut across
dimensions.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
8b9c5e3a04 solver: Fix a copy/paste error 2019-07-01 00:10:11 +01:00
Matthias Clasen
3d3a672deb constraint solver: Fix repeat suggestions 
We were not storing the previous value, causing
the first two suggestions to work, but not later
ones.

Fixes the test added in the previous commit.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
139a59cae3 Flesh out GtkConstraintGuide 
This commit moves GtkConstraintGuide into its own
source files to avoid gtkconstraintlayout.c turning
too messy, adds max size properties and implements
getters and setters.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
60fb9092fe Drop an indirection 
This struct is not really useful for just
a single hash table, and it gets in the way
of moving the guide code to its own file.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
61b4febbaf Detach guides on unroot 
We don't want to leave constraints behind.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
4f4ba8c4f6 Simplify the guide implementation 
Store the values and constraints in
arrays, to facilitate treating them
uniformly.
 2019-07-01 00:10:11 +01:00
Emmanuele Bassi
651adbfb39 Return the list of constraints added via VFL description 
Otherwise it's impossible to remove them.
 2019-07-01 00:10:11 +01:00
Emmanuele Bassi
3204347bb0 Add method to remove all constraints from a layout 2019-07-01 00:10:11 +01:00
Emmanuele Bassi
06c825df90 Add a C convenience function for VFL constraints 
The dictionary-based function is convenient for language bindings, but C
developers will feel more at home with a variadic arguments list.
 2019-06-30 23:42:45 +01:00
Emmanuele Bassi
859c95b435 Allow adding constraints described through VFL 2019-06-30 23:42:45 +01:00
Emmanuele Bassi
5ea8167802 Add VFL parser for constraints 
Constraints can be expressed with a compact syntax, called VFL (visual
format language).
 2019-06-30 23:42:45 +01:00
Emmanuele Bassi
92d3d55164 Remove GtkConstraintVariable.set_prefix() 
The prefix and name are set at construction time.
 2019-06-30 23:42:45 +01:00
Matthias Clasen
38d353dc1a Add GtkConstraintGuide 
This is meant to be a flexible space.
 2019-06-30 23:42:44 +01:00
Emmanuele Bassi
7ae04ba36b Use generic pointers for constraint targets 
Since GtkWidget implements GtkConstraintTarget, we can omit the explicit
cast, and validate the type at run time.
 2019-06-30 23:42:44 +01:00
Matthias Clasen
39c284c490 Redefine constraints with GtkConstraintTarget 
This is in preparation for allowing non-widgets
to act as constraint targets.
 2019-06-30 23:42:44 +01:00
Matthias Clasen
895e8e25a8 widget: Implement GtkConstraintTarget 2019-06-30 23:42:44 +01:00
Matthias Clasen
04562a76e3 Add GtkConstraintTarget 
This is an marker interface that we will
use to accept other things that widgets
in constraints.
 2019-06-30 23:42:44 +01:00
Emmanuele Bassi
b6781e06c1 Notify a layout change when adding and removing constraints 
Changing the set of constraints should cause a relayout.
 2019-06-30 23:42:44 +01:00
Emmanuele Bassi
54104b6676 Fix the opposite size measurement in GtkConstraintLayout 
We cannot use the given "for size" when querying our children, because
the constraint layout has no idea about the opposite size of its
children until the layout is complete.

Additionally, we should only suggest an opposite size for the layout if
we have one, instead of suggesting a weak zero size.
 2019-06-30 23:42:44 +01:00
Emmanuele Bassi
21450d5f23 Remove size constraints from ConstraintLayoutChild 
The size constraints are transient to measurement and allocation, so
they don't really need to be stored inside the GtkLayoutChild subclass
created by a GtkConstraintLayout.
 2019-06-30 23:42:44 +01:00
Matthias Clasen
a39bbb2041 constraints: Make internal consistency required 
The relations between left, right, width
and top, bottom, height are required for
internal consistency. It doesn't make sense
to ever drop these.

Changing the strength of these relations makes
my systems behave much more stable.
 2019-06-30 23:42:44 +01:00
Matthias Clasen
176d9c6baf Add gtk_constraint_layout_remove_constraint 
Otherwise, you can't do many interesting things.
 2019-06-30 23:42:44 +01:00
Emmanuele Bassi
64afa765c8 Do not release reference on the subject of an expression 
We don't own the reference in the first place.
 2019-06-30 23:42:44 +01:00
Matthias Clasen
a246d8c926 constraints solver: Avoid critials 
When the solver is finalized with existing
constraints, we end up with criticals when
the constraints ref finalize code calls
back into the hash table. Avoid that by
emptying the hash table beforehand.
 2019-06-30 23:42:44 +01:00
Matthias Clasen
0531e663ee constraint solver: Fix thawing 
There was an obviously wrong precondition here.
 2019-06-30 23:42:44 +01:00