2004-10-15 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkcellview.c (gtk_cell_view_get_size_of_row): Restore
the size info for the current row after measuring another
row. (#154945, William Jon McCann)
Tue Oct 12 17:11:02 2004 <timj@birnet.org>
* gtk/gtkwidget.c (gtk_widget_set_usize_internal): don't queue the
widget for resize or emit change notification if the usize didn't
change. this works around a buggy signal connection in #155139.
2004-10-09 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkactiongroup.h:
* gtk/gtkactiongroup.c: Reinstate the accidentally lost addition
of gtk_action_group_translate_string().
* gtk/gtkfilechooserdefault.c (renderer_edited_cb): Set the cell
renderer to inert mode to avoid bug #154921. This fixes a crash
which would otherwise occur if the editing is stopped for the second
time. (#154767, Manuel Baena García)
2004-10-08 Matthias Clasen <mclasen@redhat.com>
* gtk/gtktreeview.c (gtk_tree_view_button_press): Set cell data
unconditionally. (#152562, Federico Mena Quintero)
2004-10-08 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkuimanager.c (update_node): Also update smart separators
if the visibility of a menuitem with a submenu changes. (#153791,
Christian Persch)
2004-10-08 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkentry.h:
* gtk/gtkentry.c:
* gtk/gtkentrycompletion.c:
* gtk/gtkspinbutton.c: Share the three copies of get_borders()
under the name _gtk_entry_get_borders(). (#116368, Owen Taylor)
2004-10-06 Matthias Clasen <mclasen@redhat.com>
* gtk/gtktreeselection.c (gtk_tree_selection_get_selected): Clear
the iter instead of returning it unmodified. (#154186, Jonathan Blandford)
2004-10-06 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkfilechooserentry.c (gtk_file_chooser_entry_focus): Pop up
the completions again after tab. (#147700, Jens Bech Madsen)
2004-10-06 Matthias Clasen <mclasen@redhat.com>
* gtk/gtktreeview.c (gtk_tree_view_search_iter): Set the cursor
before changing the selection to make the file chooser preview
update work better. (#143826, Tommi Komulainen)
2004-10-06 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkrange.c (gtk_range_real_change_value): Replace a really
gross way of rounding to a specified number of digits. (#145232,
Peter Zelezny, patch by Soeren Sandmann)
Tue Oct 5 21:00:54 2004 Tim Janik <timj@gtk.org>
* gtk/gtkwidget.c (gtk_widget_size_allocate): reverted my last change
and applied owen's leaner conditional flag update which should be good
enough to preserve resizing flag invariants.
2004-10-05 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkicontheme.c (icon_info_ensure_scale_and_pixbuf): Go back to
not scaling up at all. Less magic.
Tue Oct 5 17:06:26 2004 Tim Janik <timj@gtk.org>
* gtk/gtkwidget.c (gtk_widget_size_allocate): if REQUEST_NEEDED is still
set on ::size-allocate, another size-request has been queued since
::size-request and needs to be requeued.
2004-10-05 Matthias Clasen <mclasen@redhat.com>
Provide access to the string representation of accelerators used
in GtkAccelLabel. (#154068, John Spray)
* gtk/gtkaccelgroup.h:
* gtk/gtkaccelgroup.c (gtk_accelerator_get_label): New function
to return the accelerator label used in GtkAccelLabel.
(gtk_accelerator_name): Update docs to point to
gtk_accelerator_get_label().
* gtk/gtkaccellabel.h:
* gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
New auxiliary function which creates the string representing the
accelerator.
2004-10-05 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkcombobox.c (gtk_combo_box_set_model): Resize the
popup if a new model is set. (#154129, Bernd Damian)
2004-10-04 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkicontheme.c (icon_info_ensure_scale_and_pixbuf):
Make the code work as intended for unthemed icons; don't scale
them up too much. Allow to scale them down, and do so
exactly. (#154142, Ross Burton)
(gtk_icon_info_load_icon): Amend docs.
2004-10-04 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkwindow.c (gtk_window_realize_icon): Only set
using_themed_icon if we actually got an icon list from the
theme. (#154472, Morten Welinder)
2004-10-04 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkwindow.c (gtk_window_set_icon_list):
(gtk_window_set_default_icon_list): Ref the new
icons before unreffing the old ones. (#154468, Morten Welinder)
2004-10-04 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkwindow.c (gtk_window_set_icon_list): Ref the new icons
before unreffing the old ones. (#154468, Morten Welinder)
2004-10-03 Matthias Clasen <mclasen@redhat.com>
* gtk/gtktreeviewcolumn.c
(gtk_tree_view_column_setup_sort_column_id_callback):
Set sort_indicator to FALSE when appropriate. (#153714,
Reinout van Schouwen)
2004-10-01 Matthias Clasen <mclasen@redhat.com>
Fix bug #150790:
* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_get_size): Fix the
calculation of x_offset when ellipsized and in RTL mode.
(gtk_cell_renderer_text_render): Fix the calculation of the layout
width when ellipsized.
2004-10-01 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear_attributes):
* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_layout_clear_attributes):
Silently ignore info being NULL. This is unavoidable with the
current design where we have every implementation of layout_clear
call layout_clear_attributes, and also delegate calls to dependent
cell layouts. (#154191, Martyn Russell)
2004-09-29 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkdialog.c (gtk_dialog_map): Skip selectable labels when
looking for the initial focus widget.
* gtk/gtklabel.c (gtk_label_focus): Remove to put selectable labels
in the regular focus chain again.
2004-09-28 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkmain.c (gtk_parse_args): Use gtk_get_option_group()
to obtain an option group with correctly set pre- and post-
parse hooks, instead of manually calling the hooks. This fixes
a problem with setting the program class in the gdk preparse
hook. (#153788, Robert Ögren)
2004-09-27 Matthias Clasen <mclasen@redhat.com>
Fix#153082:
* gtk/gtkmain.c (do_pre_parse_initialization): Don't call gdk_parse_args()
here, we don't want to parse args twice.
(gtk_init_with_args): Add the ugid check here as well.
(gtk_parse_args): Add the gdk options to the main option group as well.
2004-09-26 Matthias Clasen <mclasen@redhat.com>
* gtk/gtknotebook.c (gtk_notebook_class_init): Add a missing _
to the name of the has_secondary_backward_stepper property.
Noticed by Michèle Garoche.
2004-09-26 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkpathbar.c (gtk_path_bar_check_parent_path): Scroll
to make the current folder visible. (#152921)
2004-09-26 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkbutton.c: Revert the button state to !button_down,
if we're missing the release event due to grab shadowing
or insensitivation.
* gtk/gtkpathbar.c: Make the slider buttons scroll.
2004-09-22 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkfilechooserdefault.c (selection_check_foreach_cb): Don't use
bitops on booleans.
(gtk_file_chooser_default_should_respond): Make it easier to
select folders in SELECT_FOLDER mode.
2004-09-20 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkbutton.c (gtk_button_class_init): Add a boolean ::displace-focus
style property and apply child displacement to the focus rectangle
if it is TRUE. (#141170, Soeren Sandmann)
Sun Sep 19 23:56:18 2004 Søren Sandmann <sandmann@redhat.com>
* gtk/gtkmenu.c (MENU_SCROLL_TIMEOUT2): Change from 50 to 20 to
make the menus scroll faster.
2004-09-18 Federico Mena Quintero <federico@ximian.com>
Merged from 2.4:
* gtk/gtkfilesystem.h: Removed the GTK_FILE_PATH() and
GTK_IS_FILE_PATH() macros. They are not supposed to exist, as
GtkFilePath is not an object. And they never worked, anyway.
2004-09-18 Marco Pesenti Gritti <marco@gnome.org>
* gtk/gtkentry.c: (gtk_entry_completion_key_press):
Make numeric pad enter activate the selected completion
entry. Fix bug 143486 reported by Edd Dumbill.
2004-09-17 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render): Remove
leftover debug code.
Improve the behaviour of the file chooser in save mode. Fixes bugs
#151031, #151608, #151994 reported by Owen Taylor and Alexander
Larsson.
* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_set_property):
(location_entry_create): Propagate the action to the file
chooser entries.
(gtk_file_chooser_default_should_respond): Switch folders if
the user enters a directory name in the entry and clear the entry
after switching folders.
(gtk_file_chooser_default_should_respond, shortcuts_row_activated_cb):
Move focus to the file list when activating a shortcut.
(gtk_file_chooser_default_should_respond): Handle the case where the
user clicks on "Save" after selecting a folder in the file list.
* gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_set_property):
Propagate the action to the file chooser entries.
* gtk/gtkfilechooserentry.h:
* gtk/gtkfilechooserentry.c (_gtk_file_chooser_entry_set_action):
(_gtk_file_chooser_entry_get_action): New functions to propagate
the GtkFileChooserAction of the file chooser to the file chooser
entry.
(check_completion_callback): If we are in save mode, only do
inline completion for directories.
2004-09-16 Matthias Clasen <mclasen@redhat.com>
Fix#152760, Christian Persch:
* gtk/gtkaboutdialog.c (gtk_about_dialog_finalize): Don't free
private data.
(gtk_about_dialog_set_translator_credits): Recommend the msg
id translator-credits.
(display_credits_dialog): Show translator credits if they're
translated, not if they're untranslated.
Tue Sep 14 22:01:49 2004 Matthias Clasen <maclas@gmx.de>
* configure.in: New option --disable-visibility to disable
the use of ELF visibility attributes for PLT reduction.
* gtk/makegtkalias.pl:
* gdk/makegdkalias.pl: Respect the DISABLE_VISIBILITY
define.
Tue Sep 14 23:20:56 2004 Søren Sandmann <sandmann@redhat.com>
* gtk/gtkaction.c (connect_proxy): Call
gtk_tool_item_rebuild_menu().
* gtk/gtktoolitem.c (gtk_tool_item_class_init): Update
documentation for GtkToolItem::create_menu_proxy.
* gtk/gtktoolitem.c (gtk_tool_item_rebuild_menu): New
API to make the toolbar update itself when the proxy menu item
for a tool item changes.
* gtk/gtktoolbutton.c (gtk_tool_button_construct_contents): Call
gtk_tool_item_rebuild_menu here()
* gtk/gtktoolbutton.c (gtk_tool_button_construct_contents):
Remove redundant check for need_label.
2004-09-14 Matthias Clasen <mclasen@redhat.com>
* gtk/gtktreeview.c (gtk_tree_view_focus_to_cursor): Set the cursor
to the first selected row instead of always to the first row if there
is no cursor. (#143270, Jean Bréfort)
* tests/testfilechooser.c (main): Fix a few typos.
2004-09-13 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkexpander.c:
* gtk/gtktreeview.c: Change the default expander size to 12 to compensate
for the recent change to gtk_default_draw_expander().
* gtk/gtkstyle.c (gtk_default_draw_expander): Use a linewidth of one
for expander sizes up to 16.
2004-09-13 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkentrycompletion.c (gtk_entry_completion_get_model): Resize the
popup if the model is replaced. (#152333)
2004-09-13 Matthias Clasen <mclasen@redhat.com>
Fix some problems reported by Morten Welinder:
* gtk/gtkfilesystem.c: Include gtkmodules.h, not gtkmain.h, since
the modules stuff moved.
* gtk/gtkmain.c (gtk_arg_no_debug_cb): Add a missing return
* gtk/gtksettings.c: Add missing include.
(settings_update_modules): Remove an unused variable.
2004-09-09 Matthias Clasen <mclasen@redhat.com>
* gtk/makegtkalias.pl:
* gdk/makegdkalias.pl: Use the short prefix "IA__" for
aliases instead of the long suffix "__internal_alias".
Wed Sep 8 18:38:08 2004 Soeren Sandmann <sandmann@redhat.com>
Make dropping of expandable items look nicer.
* gtk/gtktoolbar.c (gtk_toolbar_set_drop_highlight_item): Make
placeholder expand if highlight item is expanding.
* gtk/gtktoolbar.c (toolbar_content_set_expand): New function.
* gtk/gtktoolbar.c (toolbar_content_get_expand): Return TRUE only
if the item is not disappering.
2004-09-07 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkuimanager.c (gtk_ui_manager_add_ui): Use the proper node type
for placeholders in toolbars. (#151963, Olivier Andrieu)
Sun Sep 5 17:14:16 2004 Matthias Clasen <maclas@gmx.de>
* gtk/gtkmain.c:
* gdk/gdk.c:
* gdk/x11/gdkmain-x11.c:
* gdk/win32/gdkmain-win32.c: Add descriptions for the
commandline arguments. The actual descriptions are mostly
taken from libbonoboui, so translators should be able to
copy existing translations from there.
Sun Sep 5 01:04:01 2004 Matthias Clasen <maclas@gmx.de>
Allow sorting of tree models to be turned off
again. (#151139, Torsten Schoenfeld)
* gtk/gtktreesortable.h:
Add GTK_TREE_SORTABLE_UNSORTED_SORT_COLUMN_ID.
* gtk/gtktreestore.c (gtk_tree_store_sort):
* gtk/gtkliststore.c (gtk_list_store_sort): Don't sort if
the list store is not sorted.
Fri Sep 3 22:45:03 2004 Matthias Clasen <maclas@gmx.de>
* gtk/gtkuimanager.c (print_node): Don't print out attributes
for the <ui> root node. (#151752, Lorenzo Gil Sánchez)
Sat Sep 4 02:38:57 2004 Søren Sandmann <sandmann@redhat.com>
* gtk/gtktoolbar.c (position): Accelerate the animation when it
has been running for a while. (#143647).
2004-09-01 Matthias Clasen <mclasen@redhat.com>
Make it possible to specify additional modules to load
via a setting. (#117236, Alex Graveley)
* gtk/gtkmodules.h:
* gtk/gtkmodules.c: New files which contain the module
handling code which was previously in gtkmain.[hc].
Additionally, the code now looks for the gtk-modules
setting, which can specify additional modules to load.
* gtk/gtkmain.c:
* gtk/gtkmain.h: Remove all the module handling code.
* gtk/gtkdebug.h: Add a debug flag for modules.
* gtk/gtk.h: Include gtkmodules.h
* gtk/Makefile.am (gtk_public_h_sources): Add gtkmodules.h
(gtk_c_sources): Add gtkmodules.c
* gtk/gtksettings.c: Add the gtk-modules setting.
* gdk/x11/gdkevents-x11.c: Add the Gtk/Modules XSetting.
Wed Sep 1 19:11:44 2004 Søren Sandmann <sandmann@redhat.com>
* gtk/gtktoolbar.c (gtk_toolbar_size_allocate): Make sure
children of the toolbar are given positive dimensions. (149540,
Felipe Heidrich).
2004-09-01 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkfilesystemunix.c:
* gtk/gtkfilechooserbutton.c: Protect the unistd.h include
by HAVE_UNISTD_H.
Tue Aug 31 23:24:49 2004 Matthias Clasen <maclas@gmx.de>
* gtk/gtkcalendar.c (gtk_calendar_main_button): Only start
a drag if the left button is pressed. (#151490, Frederic Croszat)
Tue Aug 31 17:07:41 2004 Jonathan Blandford <jrb@redhat.com>
* gtk/gtktreeviewcolumn.c
(gtk_tree_view_column_cell_process_action): constrain cell area to
passed in cell_area, #147867
* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_get_size): if
ellipsizing, get_size is only 3 chars wide.
* docs/tree-column-sizing.png: Add Matthias's excellent image.
2004-08-30 Matthias Clasen <mclasen@redhat.com>
* gtk/gtktextview.c (gtk_text_view_delete_surrounding_handler): Make it compile.
2004-08-27 Matthias Clasen <mclasen@redhat.com>
Fix#151112, Olexiy Avramchenko:
* gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout):
* gtk/gtkiconview.c (scroll_timeout, layout_callback)
(gtk_icon_view_item_accessible_idle_do_action):
* gtk/gtkcombobox.c (list_popup_resize_idle, popdown_idle)
(popup_idle): Protect idle callbacks and timeouts with
GDK_THREADS_ENTER/_LEAVE.
* gtk/gtkfilechooserbutton.c (update_dialog_idle): New function to
call update_dialog() from an idle with the necessary protection.
Mon Aug 30 01:34:42 2004 Matthias Clasen <maclas@gmx.de>
Changes to make sure input methods respect the editability
of entries and text views. #114173, Noah Levitt.
* gtk/gtkentry.c (popup_targets_received): Make the Input
Methods menuitem insensitive if we're not editable.
* gtk/gtkentry.c (gtk_entry_delete_surrounding_cb):
* gtk/gtkentry.c (gtk_entry_preedit_changed_cb):
* gtk/gtkentry.c (gtk_entry_commit_cb): Don't change anything
if we're not editable.
* gtk/gtkentry.c (gtk_entry_focus_out):
* gtk/gtkentry.c (gtk_entry_focus_in): Only send focus_in and
focus_out to the im context if we're editable.
* gtk/gtkentry.c (gtk_entry_set_property): Reset the im context
if the entry just became non-editable.
* gtk/gtktextview.c (gtk_text_view_delete_surrounding_handler):
Use gtk_text_buffer_delete_interactive() to not delete
non-editable portions of text.
Thu Aug 26 23:58:11 2004 Matthias Clasen <maclas@gmx.de>
* gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't crash
if model is not set. Noted by Mariano Suarez-Alvarez.
Thu Aug 26 22:44:12 2004 Matthias Clasen <maclas@gmx.de>
Provide information about how an adjustment change in a range
widget happened. Add a "slider-moved" signal which reports how
a user is interacting with the range, whether they are clicking
on a stepper or the trough, or dragging the slider. (#133263,
Thomas Fitzsimmons)
* gtk/gtkmarshalers.list: Add signal type BOOLEAN:ENUM,DOUBLE.
* gtk/gtkrange.c (gtk_range_class_init): Add "change-value"
signal.
(gtk_range_internal_set_value): Rename to
gtk_range_real_change_value. Add GtkScrollType parameter. Emit
the change-value signal when the range's value changes.
(update_slider_position, gtk_range_scroll_event, step_back,
step_forward, page_back, page_forward, scroll_begin,
scroll_end): Change gtk_range_internal_set_value to
gtk_range_real_change_value.
* gtk/gtkrange.h (struct _GtkRangeClass): Declare change_value
function.
Wed Aug 25 17:14:58 2004 Manish Singh <yosh@gimp.org>
* gtk/gtktreeview.c (gtk_tree_view_search_activate): initialize
path so we don't potentially use an undefined pointer.
* gtk/gtkfilechooserdefault.c (shortcuts_list_create): add G_CALLBACK
cast for tree_view_keybinding_cb.
* gtk/gtkfilechooserdefault.c (location_entry_create): cast to
GTK_FILE_CHOOSER_ENTRY for _gtk_file_chooser_entry_set_file_part()
calls.
* gtk/gtkcellrenderercombo.c (gtk_cell_renderer_combo_start_editing):
cast to GTK_COMBO_BOX for gtk_combo_box_set_active_iter() call.
* gtk/gtkselection.c (selection_get_text_plain): make len a gsize,
since that's what g_convert_with_fallback() expects.
Wed Aug 25 16:14:34 2004 Jonathan Blandford <jrb@redhat.com>
* gtk/gtktreeview.c (gtk_tree_view_search_activate): activate the
typeahead entry on enter.
2004-08-25 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkmenu.c (gtk_menu_attach_to_widget): Steal ATTACHED_MENUS
list so its tail isn't freed when we re-set it, noticed
by Hans Petter Jansson.
Wed Aug 25 15:15:56 2004 Jonathan Blandford <jrb@redhat.com>
* gtk/gtkpathbar.c (gtk_path_bar_size_allocate): Change the Down
button to be end-justified, so that clicking on it is a stable
operation.
Tue Aug 24 02:06:37 2004 Jonathan Blandford <jrb@gnome.org>
* gtk/gtktreeview.c
(gtk_tree_view_real_expand_collapse_cursor_row): Don't handle the
event if we have no children.
* gtk/gtkfilechooserdefault.c (trap_activate_cb):
(tree_view_keybinding_cb):Since GtkTreeView has a keybinding
attached to '/', we need to catch keypresses before the TreeView
gets them.
(gtk_file_chooser_default_class_init): add '/' to be a keybinding
to the C-l dialog.
(location_entry_create): Clear the text to "" when loading a file.
This has a much better feel than putting the currently selected
in.
* #include <errno.h>
2004-08-25 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkfilechooserdefault.c (check_is_folder): Use get_file_info() rather
than trying get_folder() and checking for an error directly because older
versions of the gnome-vfs backend don't return an error
immediately. (#150852, Zack Cerza )
Tue Aug 24 21:46:42 2004 Søren Sandmann <sandmann@redhat.com>
* gtk/gtksequence.c (_gtk_sequence_move): Just return if the
parameters are identical. (#150159, Robert Ögren)
2004-08-23 Matthias Clasen <mclasen@redhat.com>
Fix#150822, reported by Christian Persch
* gtk/gtklabel.c (gtk_label_ensure_layout): Set the layout width
appropriately when ellipsized.
(gtk_label_size_allocate): Only set the layout width if there
is a layout.
2004-08-22 Philip Langdale <plangdale@vmware.com>
* gtk/gtkaction.c (gtk_action_disconnect_proxy): Two signals
(gtk_action_sync_property and gtk_action_sync_sensitive) were
not being correctly disconnected, leading to actions continuing
to affect disconnected proxies. (#150607)
Sun Aug 22 16:55:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
* gtk/gtkexpander.c
* gtk/gtkalignment.c:
* gtk/gtktexttag.c
Make enums match property names. Found by a script by Tommi
Komulainen.
* gtk/gtkpaned.c (gtk_paned_class_init): fix min/max mixup.
Sun Aug 22 16:09:49 2004 Soeren Sandmann <sandmann@daimi.au.dk>
* gtk/gtkliststore.h (struct _GtkListStore):
* gtk/gtkliststore.c (gtk_list_store_init):
* gtk/gtkliststore.c (gtk_list_store_insert):
* gtk/gtkliststore.c (gtk_list_store_remove):
Restore length field; PyGTK and maybe others use it directly.
Sun Aug 22 15:46:56 2004 Soeren Sandmann <sandmann@daimi.au.dk>
* gtk/gtkpaned.c (gtk_paned_class_init):
s/CYCLE_HANDLE_FOCUS/CYCLE_CHILD_FOCUS/
* gtk/gtkfontbutton.c (gtk_font_button_class_init):
s/PROP_SHOW_SIZE/PROP_SHOW_STYLE/
Both pointed out by Tommi Komulainen.
Sun Aug 22 13:44:53 2004 Soeren Sandmann <sandmann@daimi.au.dk>
* gtk/gtkpaned.c (gtk_paned_class_init): Use PROP_MAX_POSITION,
not PROP_MIN_POSITION for the max_position property. Fix pointet
out by Tommi Komulainen.
Sun Aug 22 13:32:33 2004 Soeren Sandmann <sandmann@daimi.au.dk>
* gtk/gtkliststore.c (gtk_list_store_insert): Normalize the
position so we don't create paths with off-list
indices. (#150320).
Sun Aug 22 12:04:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
* gtk/gtkliststore.c (gtk_list_store_sort_iter_changed): Use the
correct tree path (#150289, Morten Welinder).
Sun Aug 22 00:08:44 2004 Matthias Clasen <maclas@gmx.de>
Fix#150406, reported by Fernando San Martín Woerner, patch
by Gustavo Carneiro.
* gtk/gtkentrycompletion.c
(gtk_entry_completion_default_completion_func): Check that
column is of type G_TYPE_STRING before proceeding.
Sat Aug 21 23:53:39 2004 Matthias Clasen <maclas@gmx.de>
* gtk/gtktreestore.c (gtk_tree_store_swap): Don't use an
uninitialized tree iter. (#150414, Torsten Schoenfeld)
Wed Aug 18 16:18:00 2004 Manish Singh <yosh@gimp.org>
* gtk/gtktreeview.c (gtk_tree_view_row_inserted): Initialize height
from fixed_height before we do anything, so it always has a valid
value.
* gtk/gtkfilechooserdefault.c (shortcuts_reload_icons): Fix call
to gtk_tree_model_get (missing "," in param list).
2004-08-18 Federico Mena Quintero <federico@ximian.com>
Merged from 2.4:
Fixes#149251:
* gtk/gtkfilechooserdefault.c: Renamed SHORTCUTS_COL_PATH to
SHORTCUTS_COL_DATA. Add SHORTCUTS_COL_IS_VOLUME, to determine
easily whether the SHORTCUTS_COL_DATA points to a GtkFilePath or a
GtkFileSystemVolume.
(shortcuts_model_create): Create a boolean column for
SHORTCUTS_COL_IS_VOLUME.
(shortcuts_reload_icons): Simplify with the use of the
SHORTCUTS_COL_IS_VOLUME column. Don't leak the pixbuf.
(shortcuts_insert_path): Add the SHORTCUTS_COL_IS_VOLUME data.
(shortcuts_free_row_data): New helper function; frees the data
columns for an iter.
(shortcuts_remove_rows): Don't take a callback for freeing the
data; free everything here instead. Use
shortcuts_free_row_data().
(volume_remove_cb): Removed.
(remove_bookmark_cb): Removed.
(remove_row_cb): Make this a single generic function to delete
rows.
(shortcuts_add_volumes): Use remove_row_cb().
(shortcuts_add_bookmarks): Likewise.
(struct _GtkFileChooserDefault): Removed the
shortcuts_current_folder_is_volume field.
(shortcuts_add_current_folder): Oops, don't free the volume.
(remove_current_folder_cb): Removed.
(shortcut_find_position): Simplify through the use of the
SHORTCUTS_COL_IS_VOLUME column.
(remove_selected_bookmarks): Assert that we don't get a volume.
(shortcuts_reorder): Likewise; also, plug a leak.
(gtk_file_chooser_default_remove_shortcut_folder): Simplify
through the use of shortcuts_remove_rows().
(gtk_file_chooser_default_list_shortcut_folders): Assert that we
don't get a volume.
(shortcuts_activate_iter): Simplify.
(home_folder_handler): Simplify by using
shortcuts_activate_iter().
(shortcuts_free): New function; frees all the data columns.
(gtk_file_chooser_default_finalize): Unref the
shortcuts_filter_model and the shortcuts model data first.
Wed Aug 18 08:31:17 2004 Manish Singh <yosh@gimp.org>
* gtk/gtkiconview.c: Applied patch from Olivier Andrieu to fix
bug #150440.
* gtk/gtkicontheme.c (gtk_icon_theme_init): xdg_data_dirs should
match constness attributes of g_get_system_data_dirs ().