Commit Graph

7487 Commits

Author SHA1 Message Date
Kristian Rietveld
94680cbffc don't "corrupt" all iterators by reversing the list after adding the
2007-10-08  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtkfilesystemmodel.c (got_root_folder_cb),
	(get_children_get_folder_cb): don't "corrupt" all iterators by
	reversing the list after adding the items.  Reversing the list isn't
	needed anyway as the order of the items in the model does not matter.
	(Fixes #327243, comment 10).


svn path=/trunk/; revision=18891
2007-10-08 12:44:35 +00:00
Kristian Rietveld
aed59b3ea9 Fix #482841, patch by Karl Tomlinson.
2007-10-08  Kristian Rietveld  <kris@imendio.com>

	Fix #482841, patch by Karl Tomlinson.

	* gtk/gtktooltip.c (gtk_tooltip_display_closed): use g_object_set_data
	instead of g_object_set ...
	(_gtk_tooltip_toggle_keyboard_mode),
	(_gtk_tooltip_handle_event): connect to GdkDisplay::closed after
	creating tooltip.


svn path=/trunk/; revision=18890
2007-10-08 12:39:02 +00:00
Murray Cumming
5d1a5ac216 Revert the change on 2007-04-29 (Also check the default handler when
2007-10-05  Murray Cumming  <murrayc@murrayc.com>

* gtk/gtkprintoperation.c: (print_pages_idle):
Revert the change on 2007-04-29 (Also check
the default handler when deciding whether to emit the
paginate signal.  (#345345, Yevgen Muntyan)).
This stopped printing from working in gtkmm, and is apparently 
not appropriate anyway. Bug #482089.

svn path=/trunk/; revision=18885
2007-10-05 08:18:43 +00:00
Hiroyuki Ikezoe
31f26042f7 Use g_object_ref() instead of gtk_widget_ref(). (#483563)
2007-10-05  Hiroyuki Ikezoe  <poincare@ikezoe.net>

	* gtk/gtkdnd.c: Use g_object_ref() instead of gtk_widget_ref().
	(#483563)


svn path=/trunk/; revision=18884
2007-10-05 03:08:55 +00:00
Emmanuele Bassi
43f5b189b7 Iterate on the proxies we hold when we change the sorting function and the
2007-10-04  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentaction.c:
	(gtk_recent_action_set_sort_func), (set_current_filter): Iterate
	on the proxies we hold when we change the sorting function and
	the filter.

	(gtk_recent_action_connect_proxy),
	(gtk_recent_action_create_menu): Set the GtkRecentChooser:filter
	property when we create/connect a proxy chooser. Thanks to
	Jonh Wendell for pointing this bug out on gtk-list.

	(gtk_recent_chooser_set_property): Bail out without iterating
	over the proxies when there's no need to.

svn path=/trunk/; revision=18883
2007-10-04 22:52:13 +00:00
Matthias Clasen
0afe895ad2 Add a second volume button.
2007-10-04  Matthias Clasen  <mclasen@redhat.com>

        * tests/testvolumebutton.c: Add a second volume button.

        * gtk/gtkscalebutton.c: Doh, don't release grabs we don't hold.
        (#478371, reported by Bill Nottingham)


svn path=/trunk/; revision=18881
2007-10-04 12:52:46 +00:00
Loïc Minier
618c8de221 Fix warnings and display of modified date / time in filechooser for some
2007-10-04  Loïc Minier  <lool@dooz.org>

       * gtk/gtkfilechooserdefault.c: (list_mtime_data_func): Fix warnings
       and display of modified date / time in filechooser for some locales as
       it was missing a locale to UTF-8 conversion. Fixes #482504.

svn path=/trunk/; revision=18880
2007-10-04 07:40:55 +00:00
Xan Lopez
1cea708e5e remove duplicated declaration of gtk_notebook_create_window. Patch by
2007-10-03  Xan Lopez  <xan@gnome.org>

	* gtk/gtknotebook.c: remove duplicated declaration of
	gtk_notebook_create_window. Patch by Hiroyuki Ikezoe (#482837)

svn path=/trunk/; revision=18878
2007-10-03 19:49:40 +00:00
Federico Mena Quintero
721eb57a22 455284 - Focus or toggle location entry
2007-10-02  Federico Mena Quintero  <federico@novell.com>

	Fix http://bugzilla.gnome.org/show_bug.cgi?id=455284 - In the file
	chooser, Ctrl-L should switch to the location entry.  If we are
	already on the location entry, turn it off.  Based on a patch by
	Jaap A. Haitsma <jaap@haitsma.org> and an idea by Wouter
	Bolsterlee.

	* gtk/gtkfilechooserdefault.c (location_button_toggled_cb): Call
	location_mode_set() directly instead of using toggle_location_mode().
	(toggle_location_mode): Removed.
	(location_toggle_popup_handler): If the file entry is not visible,
	show it.  If it is visible, turn it off only if it is focused.
	Otherwise, switch to the entry.

Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=18874
2007-10-02 15:50:27 +00:00
Kristian Rietveld
6e3df276df fix up if-condition to only set the true arrow type if show_sort_indicator
2007-10-01  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_update_button):
	fix up if-condition to only set the true arrow type if
	show_sort_indicator is TRUE.  (#448343, reported by Emil Nowak).


svn path=/trunk/; revision=18871
2007-10-01 09:04:57 +00:00
Emmanuele Bassi
7421a81f67 Fixes for bug #480123.
2007-09-25  Emmanuele Bassi  <ebassi@gnome.org>

	Fixes for bug #480123.

	* gtk/gtksearchenginesimple.c:
	(gtk_search_engine_simple_dispose), (search_thread_done_idle): Cancel
	the file tree walking thread when disposing the search engine
	implementation.

	* gtk/gtkfilechooserdefault.c (search_stop_searching): Forcibly
	stop the search engine implementation when stopping the search,
	instead of just unreffing the object.

svn path=/trunk/; revision=18865
2007-09-25 20:59:15 +00:00
Kristian Rietveld
37c5790a7f add extra NULL check for tooltipsdata to avoid code fiddling with
2007-09-24  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktooltips.c (gtk_tooltips_set_tip): add extra NULL check
	for tooltipsdata to avoid code fiddling with active_tips_data
	from crashing.  (Fixes #460194, Peter Wright, Matthijs De Smedt).


svn path=/trunk/; revision=18864
2007-09-24 18:23:01 +00:00
Tor Lillqvist
9e0fabe081 Set the GtkWin32EmbedWidget we create here as modal. Fixes #389358.
2007-09-24  Tor Lillqvist  <tml@novell.com>

	* gtk/gtkprintoperation-win32.c (pageDlgProc): Set the
	GtkWin32EmbedWidget we create here as modal. Fixes #389358.


svn path=/trunk/; revision=18860
2007-09-24 13:45:40 +00:00
Manish Singh
0983017630 gtk/gtkstyle.c (option_menu_get_props) use gtk_requisition_free() instead
2007-09-21  Manish Singh  <yosh@gimp.org>

        * gtk/gtkstyle.c (option_menu_get_props)
        * gtk/gtkoptionmenu.c (gtk_option_menu_get_props): use
        gtk_requisition_free() instead of g_free() for freeing
        requisitions.

svn path=/trunk/; revision=18855
2007-09-21 21:14:56 +00:00
Matthias Clasen
b0cc27c30b Some more fixed to prevent segfaults with missing or nonsensical ranges.
2007-09-21  Matthias Clasen <mclasen@redhat.com>

        * gtk/gtkprintoperation.c (print_pages_idle): Some more
        fixed to prevent segfaults with missing or nonsensical ranges.


svn path=/trunk/; revision=18854
2007-09-21 15:38:29 +00:00
Jean Brefort
e7131b2f91 abort printing when the range is NULL. (#478803)
2007-09-21  Jean Brefort  <jean.brefort@normalesup.org>

	* gtk/gtkprintoperation.c: (print_pages_idle): abort printing 
	when the range is NULL. (#478803)


svn path=/trunk/; revision=18853
2007-09-21 14:50:06 +00:00
Michael Natterer
86994b49d3 merged patch from maemo-gtk which handles failed keynav correctly also
2007-09-21  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktextview.c (gtk_text_view_move_cursor_internal)
	(gtk_text_view_move_viewport): merged patch from maemo-gtk which
	handles failed keynav correctly also when the cursor is invisible.
	(Tommi Komulainen)


svn path=/trunk/; revision=18851
2007-09-21 14:29:08 +00:00
Matthias Clasen
4e5d3ecf07 Forgotten file
svn path=/trunk/; revision=18850
2007-09-21 14:19:19 +00:00
Matthias Clasen
763417b4c1 Remove trailing commas
svn path=/trunk/; revision=18849
2007-09-21 14:17:53 +00:00
Emmanuele Bassi
4c335374f2 Search libtrackerclient.so.0 as libtracker changed the shared library
2007-09-18  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtksearchenginetracker.c: Search libtrackerclient.so.0
	as libtracker changed the shared library name. (#478173,
	Michael Kuhn)

svn path=/trunk/; revision=18846
2007-09-18 21:48:01 +00:00
Hans Breuer
7f1bc40a84 svn path=/trunk/; revision=18842
svn path=/trunk/; revision=18842
2007-09-17 19:53:54 +00:00
Michael Natterer
95116d0f1c don't simply crash if any of the pointer args are NULL. Instead,
2007-09-15  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkselection.c (gtk_target_list_find): don't simply crash if
	any of the pointer args are NULL. Instead, g_return_if_fail() on
	"list != NULL" and allow to pass NULL as return location for "info".


svn path=/trunk/; revision=18831
2007-09-15 16:48:56 +00:00
Emmanuele Bassi
5e3d2bb65a Remove the warning for the "select-multiple" property getter. (#476686,
2007-09-14  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentaction.c:
	* gtk/gtkrecentchoosermenu.c: Remove the warning for the
	"select-multiple" property getter. (#476686, Christian Persch)

svn path=/trunk/; revision=18826
2007-09-14 09:51:34 +00:00
Michael Natterer
80640a0f8c no need to get the list of menubars twice.
2007-09-14  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkmenubar.c (remove_from_window): no need to get the list
	of menubars twice.

	Some minor stylistic and indentation fixes.


svn path=/trunk/; revision=18825
2007-09-14 09:17:59 +00:00
Matthias Clasen
5f8cd8b9fb Turn off icon cache validation by default
svn path=/trunk/; revision=18823
2007-09-14 02:11:01 +00:00
Matthias Clasen
bebbf23f22 2.12.0
svn path=/trunk/; revision=18820
2007-09-14 00:56:57 +00:00
Kristian Rietveld
ecefbe8403 the tooltip-column property getter needs to set an integer, not a boolean.
2007-09-14  Kristian Rietveld  <kris@gtk.org>

	* gtk/gtktreeview.c (gtk_tree_view_get_property): the tooltip-column
	property getter needs to set an integer, not a boolean. (#476689,
	spotted and patch by Christian Persch).


svn path=/trunk/; revision=18818
2007-09-13 22:39:47 +00:00
Kristian Rietveld
e523ba2ce8 implement getter for keycode property. (#476665, patch by Christian
2007-09-14  Kristian Rietveld  <kris@gtk.org>

	* gtk/gtkcellrendereraccel.c (gtk_cell_renderer_accel_get_property):
	implement getter for keycode property.  (#476665, patch by
	Christian Persch).


svn path=/trunk/; revision=18817
2007-09-13 22:37:02 +00:00
Matthias Clasen
e297090fa7 Fix the value type
svn path=/trunk/; revision=18816
2007-09-13 21:25:48 +00:00
Kristian Rietveld
bd24768db6 if cell is set, always pass in path to gtk_tree_view_get_cell_area()
2007-09-13  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktreeview.c (gtk_tree_view_set_toooltip_cell): if cell
	is set, always pass in path to gtk_tree_view_get_cell_area() whether
	it is NULL or set.  Added explanatory comment and added this
	side case to the API documentation.


svn path=/trunk/; revision=18812
2007-09-13 14:15:40 +00:00
Emmanuele Bassi
e299a72a49 Use the "document-open-recent" icon for the the Recently Used shortcut in
2007-09-12  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkfilechooserdefault.c (render_recent_icon): Use the
	"document-open-recent" icon for the the Recently Used shortcut
	in the file chooser. (#306445)

	* gtk/Makefile.am:
	* gtk/stock-icons/16/document-open-recent.png:
	* gtk/stock-icons/16/document-open-recent.svg:
	* gtk/stock-icons/24/document-open-recent.png:
	* gtk/stock-icons/24/document-open-recent.svg: Add the
	"document-open-recent" icon to the builtin theme we provide
	as a fallback.

svn path=/trunk/; revision=18803
2007-09-12 18:00:30 +00:00
Kristian Rietveld
eab3ef3145 Fixes #426246.
2007-09-12  Kristian Rietveld  <kris@imendio.com>

	Fixes #426246.

	* gdk/gdk.symbols:
	* gdk/gdkwindow.[ch]
	(gdk_window_freeze_toplevel_updates_libgtk_only),
	(gdk_window_thaw_toplevel_updates_libgtk_only): new functions
	to freeze a toplevel window and all its descendants.  To be made
	public in 2.14,
	(gdk_window_schedule_update): return if toplevel is frozen,
	(gdk_window_process_all_updates): defer processing updates if toplevel
	is frozen.

	* gtk/gtkwindow.c (gtk_window_configure_event): directly size
	allocate for override redirect windows, freeze toplevel and
	descendants otherwise and wait until resizing is done.


svn path=/trunk/; revision=18802
2007-09-12 17:13:24 +00:00
Michael Natterer
a5bebb2e7b remove useless member "has_title" from the private struct and simply set
2007-09-11  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkfilechooserbutton.c: remove useless member "has_title"
	from the private struct and simply set the default title in
	constructor() whenever we create a dialog or the supplied one has
	no title. Also accept RESPONSE_ACCEPT *and* RESPONSE_OK as
	affirmative responses and document that accordingly. Fixes bug
	#436576. Fixed all compiler warnings in the file.


svn path=/trunk/; revision=18796
2007-09-11 18:54:00 +00:00
Michael Natterer
7b6c536cc7 Make sure menu_shell->button gets reset to 0 when we bail out early here
2007-09-11  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkmenu.c (gtk_menu_button_release): Make sure
	menu_shell->button gets reset to 0 when we bail out early here
	instead of chaining up, so it is in a consistent state for the
	next press/release in GtkMenuShell. Fixes bug #449371.


svn path=/trunk/; revision=18795
2007-09-11 17:38:12 +00:00
Kjartan Maraas
a7bce8a3e9 Fix some typos. Closes bug #475400.
2007-09-10  Kjartan Maraas  <kmaraas@gnome.org>

	* gtk/gtkentry.c: Fix some typos. Closes bug #475400.

svn path=/trunk/; revision=18790
2007-09-10 21:58:20 +00:00
Richard Hult
9ee525e0f7 Build fix, correct a typo in the G_BEGIN_DECLS fix below.
2007-09-10  Richard Hult  <richard@imendio.com>

	* gtk/gtksearchenginesimple.h: Build fix, correct a typo in the
	G_BEGIN_DECLS fix below.

svn path=/trunk/; revision=18787
2007-09-10 17:19:49 +00:00
Matthias Clasen
7c4652f9af Fix a typo
svn path=/trunk/; revision=18786
2007-09-10 16:40:15 +00:00
Kristian Rietveld
6f9364eceb when creating a new box, be sure to transfer a possible tooltip from the
2007-09-10  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_construct_contents):
	when creating a new box, be sure to transfer a possible tooltip from
	the old to the new box. (Fixes #458283, reported by Christian Persch).


svn path=/trunk/; revision=18785
2007-09-10 12:46:23 +00:00
Kristian Rietveld
a6755f707b only start typeahead search if tree_view has focus (and not one of the
2007-09-10  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktreeview.c (gtk_tree_view_key_press): only start
	typeahead search if tree_view has focus (and not one of the column
	buttons).


svn path=/trunk/; revision=18779
2007-09-10 09:24:38 +00:00
Matthias Clasen
af6b614527 Remove update_idle here. Might fix #383003.
2007-09-09  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkdnd.c (gtk_drag_source_info_destroy): Remove
        update_idle here. Might fix #383003.



svn path=/trunk/; revision=18776
2007-09-10 03:16:13 +00:00
Matthias Clasen
14afc3345a Add a bounding box test that will avoid getting the individual cell boxes
2007-09-09  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkiconview.c (gtk_icon_view_item_hit_test): Add a
        bounding box test that will avoid getting the individual cell
        boxes if they haven't been calculated yet.  (#404541)



svn path=/trunk/; revision=18775
2007-09-10 00:43:58 +00:00
Matthias Clasen
a6b824d7a4 fix the build
svn path=/trunk/; revision=18774
2007-09-09 23:54:17 +00:00
Matthias Clasen
8fb6c039bb Update the documentation to mark the optional constructors parameters. The
2007-09-09  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkaction.c:
        * gtk/gtkradioaction.c:
        * gtk/gtkrecentaction.c:
        * gtk/gtktoggleaction.c: Update the documentation to mark
        the optional constructors parameters. The GtkAction::name
        property is required, instead, as it is used by GtkUIManager
        to find the action object from the XML. (#450032, Murray Cumming,
        patch by Emmanuele Bassi)



svn path=/trunk/; revision=18773
2007-09-09 20:18:24 +00:00
Matthias Clasen
29490c0448 Remove trailing commas from enumerations, since some compilers don't like
2007-09-09  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtklinkbutton.c:
        * gtk/gtkrecentfilter.c:
        * gtk/gtkprinteroptionwidget.c: Remove trailing commas from
        enumerations, since some compilers don't like them.  (#467717)



svn path=/trunk/; revision=18771
2007-09-09 20:08:31 +00:00
Matthias Clasen
5c4d0d697d Don't assume that a path of depth 0 has no indices. (#467324, Szilard
2007-09-09  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_rows_reordered):
        * gtk/gtktreemodelsort.c (gtk_tree_model_sort_rows_reordered): Don't
        assume that a path of depth 0 has no indices.  (#467324, Szilard
        Pfeiffer)



svn path=/trunk/; revision=18770
2007-09-09 19:48:22 +00:00
Kristian Rietveld
cc7e7db612 Reverted r16699:
2007-09-09  Kristian Rietveld  <kris@gtk.org>

	Reverted r16699:

	2006-10-30  Kristian Rietveld  <kris@gtk.org>

	* gtk/gtktreeview.c (gtk_tree_view_class_init): change left/right
	keybindings to collapse/expand rows instead of moving the focus
	cursor. (#105895, Brian Bober and others).


svn path=/trunk/; revision=18768
2007-09-09 15:17:43 +00:00
Matthias Clasen
18475a4aa3 Revert the clamping of cursor coordinates, since it causes really ugly
2007-09-08  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkstyle.c (draw_insertion_cursor): Revert the clamping
        of cursor coordinates, since it causes really ugly drawing
        artifacts with horizontal scrolling.  (#471215, Yevgen Muntyan)



svn path=/trunk/; revision=18765
2007-09-09 02:15:13 +00:00
Matthias Clasen
5067b99881 Apply a number of patches by Xan Lopez to improve the interaction between
2007-09-08  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkentrycompletion.c:
        * gtk/gtkentry.c: Apply a number of patches by Xan Lopez
        to improve the interaction between actions and inline
        selection.  (#471132)


svn path=/trunk/; revision=18761
2007-09-08 05:38:58 +00:00
Matthias Clasen
54139b8806 Use g_slice for ToolbarContent. (#474696, Christian Persch)
2007-09-07  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktoolbar.c: Use g_slice for ToolbarContent.
        (#474696, Christian Persch)
 

svn path=/trunk/; revision=18760
2007-09-08 05:23:12 +00:00
Matthias Clasen
1a869c046a Add an internal child name for the notebook, so that GtkBuilder can be
2007-09-07  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkprintunixdialog.c: Add an internal child name for
        the notebook, so that GtkBuilder can be used to add custom tabs.
        (#472951, Christian Persch)


svn path=/trunk/; revision=18757
2007-09-07 20:03:22 +00:00