Commit Graph

4948 Commits

Author SHA1 Message Date
Matthias Clasen
c1d9c02b09 Make sure that we keep priv->columns >= 1 even for empty menus, since we
Tue Feb 17 23:11:21 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkmenu.c (gtk_menu_do_remove): Make sure that we keep
	priv->columns >= 1 even for empty menus, since we divide by it
	somewhere else.  (#133428, Vincent Noel)
2004-02-17 22:16:02 +00:00
Soeren Sandmann
6c8430c0c4 Fix for #119722, reported by Olexiy Avramchenko, patch by Owen Taylor.
Tue Feb 17 23:02:58 2004  Soeren Sandmann  <sandmann@daimi.au.dk>

	Fix for #119722, reported by Olexiy Avramchenko, patch by Owen
	Taylor.

	* gdk/x11/gdkprivate-x11.h (struct _GdkGCX11): Add a depth field

	* gdk/x11/gdkgc-x11.c (_gdk_x11_gc_new): Keep track of the GC's
	depth.

	* gdk/x11/gdkgc-x11.c (_gdk_gc_x11_get_fg_xft_color): First query
	the colormap, if no colormap, special case depth 1,

	* gdk/x11/gdkgc-x11.c (_gdk_x11_gc_get_fg_picture): Use
	_gdk_gc_x11_get_fg_xft_color() to get the foreground color.

	* gdk/x11/gdkdrawable-x11.c (gdk_x11_drawable_get_xft_draw):
	Special-case bitmaps without a colormap.

	* gdk/x11/gdkdrawable-x11.c (gdk_x11_draw_pixbuf): Use inherited
	draw_pixbuf() implementation in the bitmap case.
2004-02-17 22:05:47 +00:00
Mark McLoughlin
9d843deb46 only reference input method modules we've actually built. Fixes re-build
2004-02-17  Mark McLoughlin  <mark@skynet.ie>

        * modules/input/Makefile.am: only reference input method
        modules we've actually built. Fixes re-build failure with
        stale hangul module lying aroung. Bug #134518.
2004-02-17 15:24:25 +00:00
Owen Taylor
42c1eb9f39 Revert last commit, please don't commit patches without approval, this
Mon Feb 16 19:13:21 2004  Owen Taylor  <otaylor@redhat.com>

        * gdk/gdkdraw.c: Revert last commit, please don't commit patches
        without approval, this isn't the right way to do it.
2004-02-17 00:16:42 +00:00
David Odin
00a6e3be92 don't try to draw more than 32767 segments at a time, since XDrawSegments
* gdk/gdkdraw.c (gdk_draw_segments): don't try to draw more than 32767
	segments at a time, since XDrawSegments cannot handle more than this.

	fixes bug #122026.
2004-02-16 22:59:26 +00:00
Søren Sandmann Pedersen
7d62f99393 Fix ChangeLog 2004-02-16 19:30:50 +00:00
Soeren Sandmann
97ff0f48a4 Call gtk_tool_item_set_expand(), not gtk_tool_item_set_homogeneous() in
Mon Feb 16 18:26:39 2004  Soeren Sandmann  <sandmann@daimi.au.dk>

	* gtk/gtktoolbar.c (gtk_toolbar_set_child_property): Call
	gtk_tool_item_set_expand(), not gtk_tool_item_set_homogeneous()
	in the CHILD_PROP_EXPAND branch. (#134545, Damon Chaplin)
2004-02-16 19:16:03 +00:00
Matthias Clasen
2cc8cfa0ea Split declaration and assignment of combo_box.
Mon Feb 16 00:04:46 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcombobox.c (gtk_combo_box_cell_layout_*):
	Split declaration and assignment of combo_box.

	* gtk/gtkcombobox.c (gtk_combo_box_list_setup): Remove a
	pointless cast
2004-02-15 23:05:48 +00:00
Matthias Clasen
d7042395c4 Add deprecation notes pointing people to GtkComboBox. 2004-02-15 21:06:53 +00:00
Matthias Clasen
6993105c84 Document the tree DND API.
Sun Feb 15 02:49:45 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtktreednd.c:
	* gtk/gtktreeview.c: Document the tree DND API.

	* gtk/gtktreeview.c (gtk_tree_view_unset_rows_drag_source):
	Call gtk_drag_source_unset().
2004-02-15 01:47:05 +00:00
Matthias Clasen
128c2192cf Make stock_size an uint property, to allow custom icon sizes. Also clarify
Sun Feb 15 00:49:59 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_class_init):
	Make stock_size an uint property, to allow custom icon
	sizes. Also clarify the blurb.  (#130047, Erik Grinaker)
2004-02-14 23:58:50 +00:00
Manish Singh
57e6eef5ae Remove unnecessary STRIP_* definitions, and GNU make check.
Sat Feb 14 11:05:26 2004  Manish Singh  <yosh@gimp.org>

        * configure.in: Remove unnecessary STRIP_* definitions, and GNU
        make check.
2004-02-14 19:21:51 +00:00
Federico Mena Quintero
764b163ce6 Duh, duh, duh! Don't bail out if the bookmarks file doesn't exist the very
2004-02-13  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilesystemunix.c (gtk_file_system_unix_add_bookmark):
	Duh, duh, duh!  Don't bail out if the bookmarks file doesn't exist
	the very first time you try to save one.
2004-02-14 02:00:40 +00:00
Federico Mena Quintero
fff4999699 Fix #129020.
2004-02-13  Federico Mena Quintero  <federico@ximian.com>

	Fix #129020.

	* gtk/gtkfilechooserdialog.c
	(set_default_size): New function, sets a reasonable default size
	for the window.
	(gtk_file_chooser_dialog_realize): New function, call
	set_default_size().
	(gtk_file_chooser_dialog_style_set): Likewise.
	(gtk_file_chooser_dialog_screen_changed): Likewise.

	* tests/testfilechooser.c (main): Don't set a default size for the
	dialog.
2004-02-14 01:23:58 +00:00
Matthias Clasen
cf6d6a1a6e Use do instead of while. (#134031, Morten Welinder);
Sat Feb 14 00:05:18 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtktreemodelfilter.c (bsearch_elt_with_offset):
	Use do instead of while.  (#134031, Morten Welinder);
2004-02-13 23:02:58 +00:00
Matthias Clasen
a9ec2fba19 Suppress xsltproc and xmlcatalog checks if enable_man=no. (#134162, Julio
Sat Feb 14 00:00:52 2004  Matthias Clasen  <maclas@gmx.de>

	* configure.in: Suppress xsltproc and xmlcatalog checks
	if enable_man=no.  (#134162, Julio M. Merino Vidal)
2004-02-13 22:58:26 +00:00
Matthias Clasen
4d1bee0617 Remove checks for sgml2html. It was once used for building the linuxdoc
Fri Feb 13 23:54:48 2004  Matthias Clasen  <maclas@gmx.de>

	* configure.in: Remove checks for sgml2html. It was once
	used for building the linuxdoc version of the tutorial.
	Nowadays, we use db2html.  (#134164, Julio M. Merino Vidal)
2004-02-13 22:53:11 +00:00
Owen Taylor
634850fdf9 Fix various compilation problems (#134312, David Hawthorne)
Fri Feb 13 08:17:43 2004  Owen Taylor  <otaylor@redhat.com>

        Fix various compilation problems (#134312, David
        Hawthorne)

        * gtk/gtkscale.c (gtk_scale_get_layout_offsets): Use
        g_return_if_fail(), not g_return_val_if_fail().

        * gtk/gtkvscale.c (gtk_vscale_get_layout_offsets):
        * gtk/gtkhscale.c (gtk_hscale_get_layout_offsets): Use
        g_return_if_reached(), not g_return_val_if_reached().

        * gtk/gtkvscale.c (gtk_vscale_expose): Fix the types
        of some parameters.

        * gtk/gtkhscale.c (gtk_hscale_get_layout_offsets): Remove
        extra 'scale' parameter.
2004-02-13 13:21:10 +00:00
Owen Taylor
3588aeb4af Various reentrancy fixes for widgets being destroyed out of
Thu Feb 12 21:58:20 2004  Owen Taylor  <otaylor@redhat.com>

        Various reentrancy fixes for widgets being destroyed
        out of focus-out-event. (#128821, Grant Gayed)

        * gtk/gtkwindow.c (_gtk_window_unset_focus_and_default):
        Ref window and widget over callbacks.

        * gtk/gtkwidget.c (gtk_widget_hide)
          gtk/gtkwidget.c (gtk_widget_set_child_visible):
        Ref the widget before calling _gtk_window_unset_focus_and_default(),
        since that can call user callbacks.

        * gtk/gtkwidget.c (gtk_widget_invalidate_widget_windows):
        Do nothing if the widget isn't realized.
2004-02-13 03:03:21 +00:00
Matthias Clasen
e4d55e75e0 Don't draw bevels around active, RELIEF_NONE buttons that aren't
Fri Feb 13 01:31:44 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkbutton.c (_gtk_button_paint): Don't draw bevels around
	active, RELIEF_NONE buttons that aren't depressed. This improves
	the appearance of buttons in notebook tabs.  (#109213, reported
	by Benjamin Otte, patch by Rodney Dawes)
2004-02-13 00:31:19 +00:00
Matthias Clasen
6fed66fc9b Protect getc_unlocked() by HAVE_FLOCKFILE in all cases. (#134205, Julio M.
Fri Feb 13 01:06:08 2004  Matthias Clasen  <maclas@gmx.de>

	* demos/gtk-demo/main.c (read_line): Protect getc_unlocked() by
	HAVE_FLOCKFILE in all cases.  (#134205, Julio M. Merino Vidal)
2004-02-13 00:03:35 +00:00
Matthias Clasen
f6a32cf0d1 Fix for #104811, Padraig O'Briain:
Fri Feb 13 00:54:59 2004  Matthias Clasen  <maclas@gmx.de>

	Fix for #104811, Padraig O'Briain:

	* gtk/gtkscale.h:
	* gtk/gtkscale.c (_gtk_scale_clear_layout):
	* gtk/gtkscale.c (gtk_scale_get_layout_offsets):
	* gtk/gtkscale.c (gtk_scale_get_layout): New functions to determine the
	text and its position from a GtkScale, to make it more accessible.
	* gtk/gtkhscale.c (gtk_hscale_get_layout_offsets):
	* gtk/gtkvscale.c (gtk_vscale_get_layout_offsets): Implementations of the
	new GtkScale vfunc.
2004-02-12 23:58:46 +00:00
Owen Taylor
0c4c9f0d1c Remove an extraneous + 1 (#134015, Torsten Schoenfeld)
Thu Feb 12 17:59:52 2004  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkicontheme.c (gtk_icon_theme_get_search_path):
        Remove an extraneous + 1 (#134015, Torsten Schoenfeld)
2004-02-12 23:06:30 +00:00
Matthias Clasen
7b1d024a0e New function to improve the accessibility of tooltips. (#114851, Padraig
Thu Feb 12 23:55:08 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtktooltips.h:
	* gtk/gtktooltips.c (gtk_tooltips_get_info_from_tip_window): New
	function to improve the accessibility of tooltips.  (#114851,
	Padraig O'Briain)
2004-02-12 22:57:56 +00:00
Manish Singh
7cf055efb3 Assign xtype using gdk_x11_atom_to_xatom_for_display () when type !=
Thu Feb 12 11:05:16 2004  Manish Singh  <yosh@gimp.org>

        * gdk/x11/gdkproperty-x11.c (gdk_property_get): Assign xtype using
        gdk_x11_atom_to_xatom_for_display () when type != GDK_NONE.

        * gtk/gtkselection.c (_gtk_selection_request): Use GDK_NONE in
        gdk_property_get call instead of 0.

        * docs/reference/gdk/tmpl/properties.sgml: Document the above
        as GDK_NONE instead of simply 0.
2004-02-12 19:18:23 +00:00
Soeren Sandmann
8c80eedd0f Fix up item_area correctly in RTL mode. (#133984, patch from Semion
Thu Feb 12 15:46:26 2004  Soeren Sandmann  <sandmann@daimi.au.dk>

	* gtk/gtktoolbar.c (gtk_toolbar_size_allocate): Fix up item_area
	correctly in RTL mode. (#133984, patch from Semion Chichelnitsky).
2004-02-12 14:49:37 +00:00
Matthias Clasen
64aa39cd4f Correct the docs.
Thu Feb 12 02:22:02 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtktreemodelfilter.c (gtk_tree_model_filter_set_modify_func):
	Correct the docs.

Thu Feb 12 02:00:53 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/tmpl/gtktreemodelfilter.sgml:
	* gtk/tmpl/gtkentrycompletion.sgml:
	* gtk/tmpl/gtkcelllayout.sgml: Additions.

Thu Feb 12 01:27:02 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtk-sections.txt: Updates.

Thu Feb 12 01:26:42 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/Makefile.am (IGNORE_HFILES): Add some private headers.
2004-02-12 01:52:26 +00:00
Matthias Clasen
8321052434 Call gtk_drag_source_set(), so that things like gtk_drag_set_icon_*() work
Thu Feb 12 01:17:01 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtktreeview.c (gtk_tree_view_enable_model_drag_source): Call
	gtk_drag_source_set(), so that things like gtk_drag_set_icon_*() work
	for automatic DND.  (#133485, Tommi Komulainen)
2004-02-12 00:15:50 +00:00
Matthias Clasen
06d35613f7 Fix misleading debug output.
Thu Feb 12 00:37:00 2004  Matthias Clasen  <maclas@gmx.de>

	* gdk/x11/gdkproperty-x11.c (gdk_property_change): Fix misleading
	debug output.
2004-02-11 23:33:59 +00:00
Federico Mena Quintero
9562a48abb New ::map() handler. If no widget has the focus, try to give it to the
2004-02-11  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkmessagedialog.c (gtk_message_dialog_map): New ::map()
	handler.  If no widget has the focus, try to give it to the
	default widget.  If there is no default widget, give it to the
	first button.  Fixes the cause for which #59707 was reopened.
2004-02-11 20:25:18 +00:00
Federico Mena Quintero
ffbd6220fe Fixes #134051.
2004-02-11  Federico Mena Quintero  <federico@ximian.com>

	Fixes #134051.

	* gtk/gtkicontheme.c (struct _GtkIconInfo): Remove the ref_count field.
	(icon_info_new): Don't initialize the ref_count field.
2004-02-11 16:54:47 +00:00
Federico Mena Quintero
eb1c785d4f Shift the array correctly. Fixes #134055, patch by Tosten Schoenfeld
2004-02-11  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkicontheme.c (gtk_icon_theme_prepend_search_path): Shift
	the array correctly.  Fixes #134055, patch by Tosten Schoenfeld
	<kaffeetisch@gmx.de>.
2004-02-11 16:28:22 +00:00
Matthias Clasen
740252b0cf Handle focus [hv]adjustment correctly when the focus is located deeper
Wed Feb 11 02:23:39 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcontainer.c (gtk_container_real_set_focus_child): Handle
	focus [hv]adjustment correctly when the focus is located deeper
	down in the hierarchy.  (#133489)
2004-02-11 01:21:14 +00:00
Matthias Clasen
0cd208cfee Remove arbitrary low upper limits on the xpad, ypad, width and height
Wed Feb 11 02:06:38 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init): Remove
	arbitrary low upper limits on the xpad, ypad, width and height
	properties.  (#129696, John Ellis)

Wed Feb 11 01:24:20 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcombobox.c (gtk_combo_box_cell_layout_clear_attributes):
	Ugh. Don't try to free ints, even if they're stored in pointers.
	(#133997, Morten Welinder)
2004-02-11 01:09:25 +00:00
Federico Mena Quintero
e27a88458f Free the filters. Fixes #133547, patch by Morten Welinder
2004-02-10  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_finalize):
	Free the filters.  Fixes #133547, patch by Morten Welinder
	<mortenw@gnome.org>.
2004-02-10 19:48:38 +00:00
Owen Taylor
351ebd8bd2 Avoid triggering an X error when the client->manager_window is
Tue Feb 10 12:02:14 2004  Owen Taylor  <otaylor@redhat.com>

        * gdk/x11/xsettings-client.c (read_settings): Avoid
        triggering an X error when the client->manager_window
        is None...makes logs look cleaner.

        * gdk/x11/gdkproperty-x11.c (gdk_property_get): Handle
        GDK_NONE to mean AnyPropertyType as documented. (Reported
        by Yu Shao)

        * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window,
        gdk_x11_screen_get_window_manager_name): Fix error trap
        we've been leaking since 2002... (#129538)
2004-02-10 18:51:19 +00:00
Federico Mena Quintero
87c45c73b1 Fixes the entry-related part of #133852.
2004-02-10  Federico Mena Quintero  <federico@ximian.com>

	Fixes the entry-related part of #133852.

	* gtk/gtkfilechooserdefault.c (update_chooser_entry): Don't change
	the file part of the entry if the selected item is a folder.
2004-02-10 18:29:11 +00:00
Federico Mena Quintero
ab09a860ed Fixes #133995, patch by Morten Welinder <mortenw@gnome.org>.
2004-02-10  Federico Mena Quintero  <federico@ximian.com>

	Fixes #133995, patch by Morten Welinder <mortenw@gnome.org>.

	* tests/prop-editor.c (create_prop_editor): Free the title.
	(object_changed): Free the children list.
2004-02-10 17:49:14 +00:00
Matthias Clasen
6f1d9d471f Document these functions.
Tue Feb 10 01:58:55 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcontainer.c (gtk_container_set_focus_hadjustment):
	* gtk/gtkcontainer.c (gtk_container_set_focus_vadjustment): Document
	these functions.
2004-02-10 01:04:35 +00:00
Federico Mena Quintero
76108bc3da Request GTK_FILE_INFO_ALL from the file system model, so that arbitrary
2004-02-09  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilechooserdefault.c (set_list_model): Request
	GTK_FILE_INFO_ALL from the file system model, so that arbitrary
	filtering will work.  Perhaps we should have a way of aggregating
	info types to the model as filters get installed.
2004-02-09 21:58:26 +00:00
Matthias Clasen
a42ff49490 Ugh. Don't try to free ints, even if they're stored in pointers.
Mon Feb  9 22:22:19 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear_attributes):
	Ugh. Don't try to free ints, even if they're stored in pointers.
2004-02-09 21:19:35 +00:00
Federico Mena Quintero
11ad0f9d65 Fix #132256.
2004-02-09  Federico Mena Quintero  <federico@ximian.com>

	Fix #132256.

	* gtk/gtkfilechooserdefault.c
	(gtk_file_chooser_default_get_paths): Read the contents of the
	filename entry in both OPEN and SAVE mode.  In multiple-selection
	mode, add this to the selection from the file/folder list.
	(struct get_paths_closure): Add a path_from_entry field.
	(get_paths_foreach): Only add the iterated path if it is not the
	same as the path from the entry.
2004-02-09 20:31:38 +00:00
Federico Mena Quintero
52383cbb58 If the folder is already open, add the requested info types to it.
2004-02-09  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtkfilesystemunix.c (gtk_file_system_unix_get_folder): If
	the folder is already open, add the requested info types to it.
2004-02-09 19:01:25 +00:00
Manish Singh
4ac3998efb Add appropriate type casts for the gtk_window_set_screen() call.
Sun Feb  8 01:28:02 2004  Manish Singh  <yosh@gimp.org>

        * gtk/gtkcombobox.c (gtk_combo_box_set_popup_widget): Add appropriate
        type casts for the gtk_window_set_screen() call.
2004-02-08 09:29:11 +00:00
Matthias Clasen
41e49106e3 Make popups come up on the same screen as the combo box. (#133544, Morten
Sun Feb  8 01:44:06 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkcombobox.c (gtk_combo_box_set_popup_widget): Make popups
	come up on the same screen as the combo box.  (#133544,
	Morten Welinder)
2004-02-08 00:42:59 +00:00
Jonathan Blandford
0180cce7f9 clean up the packing of the file selector.
Fri Feb  6 23:40:24 2004  Jonathan Blandford  <jrb@gnome.org>

        * gtk/gtkfilechooserdefault.c (create_file_list): clean up the
        packing of the file selector.
2004-02-07 17:28:36 +00:00
Matthias Clasen
bc21e066d6 Don't use function calls in array initializers, as some compilers seem to
Sat Feb  7 01:21:09 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtktreemodel.c (gtk_tree_model_base_init): Don't use function
	calls in array initializers, as some compilers seem to hate this.
	(#133216, Jonas Jonsson)
2004-02-07 00:21:37 +00:00
Matthias Clasen
c03700734e Add change notification for GtkAccelMap, by on-demand instantiating a
Sat Feb  7 00:06:44 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtkaccelmap.[hc]: Add change notification for GtkAccelMap,
	by on-demand instantiating a singleton object with a "changed"
	signal.

	* gtk/gtkmarshalers.list (VOID:STRING,UINT,FLAGS): Add marshaller
	for GtkAccelMap::changed.
2004-02-06 23:37:00 +00:00
Matthias Clasen
738eeba8d6 Actually free the lists. Pointed out by Morten Welinder.
Fri Feb  6 23:08:29 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtktextbtree.c (_gtk_text_btree_check):
	* gtk/gtkcombobox.c (gtk_combo_box_cell_layout_clear_attributes):
	* gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear_attributes):
	Actually free the lists. Pointed out by Morten Welinder.
2004-02-06 22:25:01 +00:00
Matthias Clasen
e77b5747b2 Complete the previous commit 2004-02-06 21:53:28 +00:00