AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity
37,766 Commits 969 Branches 749 Tags 504 MiB
c20e8b0b49
Commit Graph

20146 Commits

Author SHA1 Message Date
Juan Pablo Ugarte
35df3bc182 GtkFlowBox: fixed NULL dereferencing segfaults 2014-05-01 20:31:59 -03:00
Juan Pablo Ugarte
a05b55872b GtkMenu: fixed more NULL dereferencing segfault 2014-05-01 20:31:31 -03:00
Juan Pablo Ugarte
018c394c52 GtkGrid: gtk_grid_get_size_for_size() do not dereference a NULL pointer. 2014-05-01 19:54:43 -03:00
Juan Pablo Ugarte
49fa04212b GtkBuilder: improved parsing error report for invalid properties and signals. 
Added GTK_BUILDER_ERROR_INVALID_PROPERTY and GTK_BUILDER_ERROR_INVALID_SIGNAL
error codes

ObjectInfo: Use a GType instead of a char * for the class name.
PropertyInfo: Use a GParamSpec instead of a char * for the property name.
SignalInfo: Use signal id and detail quark instead of a detailed signal name string.

This not only save us a few malloc in each case but lets us simplify the code
and report unknown properties and signals as a parsing error instead of just
printing a warning.
 2014-05-01 17:59:53 -03:00
Juan Pablo Ugarte
c4afca906c GtkBuilder: fixed a few minor memory leaks. 
Fixed memory leaks in parse_object(), parse_template() and parse_signal() functions.
Parameters value where strduped before the last posible return and not freed.
 2014-05-01 17:59:53 -03:00
Руслан Ижбулатов
0dd810ee22 W32: override selected button style to remove colored background 
https://bugzilla.gnome.org/show_bug.cgi?id=729353
 2014-05-01 18:20:20 +00:00
Руслан Ижбулатов
b83880b981 W32: Add a theme for .app-notification 
This is copied from Adwaita. Looks sufficiently ok.

https://bugzilla.gnome.org/show_bug.cgi?id=729346
 2014-05-01 17:54:46 +00:00
Cosimo Cecchi
24fd96d837 listbox: fix a segfault 
Don't dereference a NULL pointer.
 2014-05-01 19:48:41 +02:00
Cosimo Cecchi
7f60cab47d combobox: fix a segfault 
Don't dereference a NULL pointer.
 2014-05-01 19:44:12 +02:00
Cosimo Cecchi
489970bcdc themingengine: use outlines to render focus rings 
Instead of the old non-CSS implementation. This allows us to get rid of
the very last piece of custom theming in Adwaita.
 2014-05-01 18:14:49 +02:00
Cosimo Cecchi
e8cbbedbb2 css: add properties for outline-radius 
Both a shorthand and individual properties. This is not officially part
of the CSS standard, but there's precedence for it at least in Mozilla:
https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-outline-radius
 2014-05-01 18:14:49 +02:00
Cosimo Cecchi
a60ba815d9 treeview: respect focus-padding when rendering focus 
Adwaita had a hack to work this around, but now that we're moving focus
ring rendering into GTK, we can just fix the treeview instead.
 2014-05-01 18:14:49 +02:00
Benjamin Otte
b4282e5ef1 treeview: Always call size request funcs with valid out pointers 
Not doing so causes crashes since
a158a2aa48c8023f99963642cc2657bff207b82NULLd
 2014-05-01 15:16:17 +02:00
Benjamin Otte
c0f556ab71 revealer: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:28 +02:00
Benjamin Otte
17e0f9fb0a popover: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:28 +02:00
Benjamin Otte
b4ee8a9daf menuitem: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:28 +02:00
Benjamin Otte
34cfd5cd78 menu: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:28 +02:00
Benjamin Otte
fd527691a8 levelbar: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:28 +02:00
Benjamin Otte
6be0603215 eventbox: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:28 +02:00
Benjamin Otte
d7a3e67025 listbox: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:28 +02:00
Benjamin Otte
562147c267 frame: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:28 +02:00
Benjamin Otte
209781ae3c headerbar: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:28 +02:00
Benjamin Otte
68ceab6872 infobar: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:28 +02:00
Benjamin Otte
f72b496a45 grid: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:28 +02:00
Benjamin Otte
9ee00c3522 scrolledwindow: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:28 +02:00
Benjamin Otte
ddbd71e22a switch: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:28 +02:00
Benjamin Otte
c3dd043765 toolbar: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:28 +02:00
Benjamin Otte
a158a2aa48 treeview: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:28 +02:00
Benjamin Otte
9652b8cf82 viewport: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:27 +02:00
Benjamin Otte
29a4f0131e viewport: Implement hfw properly 
Previously, the code would fall back on GtkBin's hfw implementation
which didn't account for padding and borders.
 2014-05-01 14:51:27 +02:00
Benjamin Otte
b261fc64e2 viewport: Use a convenience function 
That function looks longer than not using it, but we'll need it in the
next commit.
 2014-05-01 14:51:27 +02:00
Benjamin Otte
2e2e3a5e24 viewport: Request 2x border-width 
It's nice that bugs get pointed out in code comments. Fixing them would
probably have been preferrable though.
 2014-05-01 14:51:27 +02:00
Benjamin Otte
db791ba3f5 widget: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:27 +02:00
Benjamin Otte
43e470dad1 flowbox: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:27 +02:00
Benjamin Otte
7455ab72f8 combobox: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:27 +02:00
Benjamin Otte
3914bc9ce6 button: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:27 +02:00
Benjamin Otte
71fe1a5fe3 alignment: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:27 +02:00
Benjamin Otte
e6b15c88ca arrow: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:27 +02:00
Benjamin Otte
a1bba344f2 spinner: Remove unneeded checks 
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
 2014-05-01 14:51:27 +02:00
Matthias Clasen
ff87672780 GtkSearchBar: fix the template 
There was a mismatch between GtkSearchBar being derived from GtkBin
and the template claiming the parent to be GtkBox.
 2014-04-29 21:46:38 -04:00
Benjamin Otte
8b15cd33ee window: Subtract shadow from passed in width for height 
... and height for width in size requests. Fixes mislayout in
control-center universal access panel.
 2014-04-29 19:36:26 +02:00
Benjamin Otte
73aa7bd2f5 widgets: Remove (GtkTickCallback) casts 
Instead, make the functions conform to the prototype, so that casting
isn't needed.
 2014-04-29 19:35:29 +02:00
Matthias Clasen
6061f234a9 GtkMenuSectionBox: Don't show separators for nested subsections 
...unless they are labeled.

To implement this, keep track of the nesting depth of section boxes,
starting from 0 for the toplevel and the submenu ones, and only
insert unlabeled separators if the depth is at most 1.
 2014-04-29 12:19:53 -04:00
Matthias Clasen
f3ba001a1d GtkMenuSectionBox: Always show separators for labeled sections 
...unless they are empty.
 2014-04-29 12:19:53 -04:00
Matthias Clasen
4f293c427c Add a comment with rules for separators 2014-04-29 12:19:53 -04:00
Matthias Clasen
effc7514e7 GtkMenuSectionBox: don't leak 
This wasn't fully fleshed out yet.
 2014-04-29 10:18:22 -04:00
Alexander Larsson
c0a87a85f4 treeview: Fix prelight redraw when adjustment changes 
When the adjustment changes (due to e.g. a mouse wheel scroll) we update
the prelight. The part that un-prelights the previous prelight was
broken by the the pixel cache, as it called update_prelight in the
middle of the scrolling operation, where the windows were moved
but the tree_view->priv->dy was not changed to the new value. This
caused the updates to the pixel cache to go to the wrong place.

We fix this by fully doing the scroll before we update_prelight().

https://bugzilla.gnome.org/show_bug.cgi?id=728284
 2014-04-29 09:12:02 +02:00
Matthias Clasen
a6fb006ab5 GtkMenuShell: We want separators in submenus 
This was probably an oversight when adding the merge_separators
parameter. Without this change, the testsuite/gtk/gtkmenu test
fails.
 2014-04-28 22:46:25 -04:00
Matthias Clasen
723dc0667e GtkMenuShell: Don't use a non-existing property 
GtkMenuTrackerItem::visible was removed a few commits ago.
It is not necessary to bind visible anyway, since the menu
tracker will insert and remove items as their visibility
changes.
 2014-04-28 21:55:41 -04:00
Carlos Garnacho
5b72e0f8cf popover: Always make room for the tail on all sides on size request 
Now that popovers may snap to any side with enough space, make enough
room on every side when requesting size, so that there's no w/h differences
at the time of setting the child allocation.

https://bugzilla.gnome.org/show_bug.cgi?id=729097
 2014-04-28 22:35:32 +02:00
Juan Pablo Ugarte
d1467c191d GtkRecentChooserMenu: Set current uri before activating an item. 
When activating an item using mnemonics GtkRecentChooserMenu does not select a
item before calling the item-activated signal thus
gtk_recent_chooser_get_current_uri() always return the last selected item
instead of the activated one.

Fixes Bug 495105 "Open recent file keyboard shortcuts do not work correctly"
 2014-04-28 17:08:12 -03:00
Matthias Clasen
2dcf6c6b71 Raleigh: fix a typo 2014-04-28 15:39:21 -04:00
Matthias Clasen
0af4b71cd1 GtkDialog: protect against show_all 
The real reason for the problem that the just reverted change
was supposed to address is that testfilechooser uses show_all
to tease out places where composite dialogs don't properly
protect their internals against unintended showing. Well,
lets do that, then.
 2014-04-28 15:39:21 -04:00
Matthias Clasen
26d6eadab7 Revert "GtkFileChooserDialog: Avoid a bottom border in the dialog" 
This reverts commit d871105fa8.
 2014-04-28 15:39:21 -04:00
Matthias Clasen
6c3936fb9a Document iconic section support 
https://bugzilla.gnome.org/show_bug.cgi?id=727477
 2014-04-28 14:21:07 -04:00
Matthias Clasen
28a567f5a9 GtkMenuSectionBox: add support for iconic sections 
Sections that have the display-hint attribute set to
"horizontal-boxes" will be rendered as a row of icon
buttons, instead of menuitem-like.
 2014-04-28 14:20:26 -04:00
Matthias Clasen
8fff8acbac GtkMenuTrackerItem: Add support for display-hint 
This commit adds a getter for the display-hint attribute.
 2014-04-28 14:20:26 -04:00
Matthias Clasen
6429b33f44 GtkModelButton: Add an iconic mode 
In iconic mode, model buttons will be styled like regular icon
buttons, preferring to show only the icon if one is set, falling
back to showing the label.

https://bugzilla.gnome.org/show_bug.cgi?id=727477
 2014-04-28 14:20:15 -04:00
Matthias Clasen
038de02574 GtkMenuTrackerItem: Add support for verb-icons 
When rendering iconic sections, we want to use icons for verbs,
and we want to differentiate these in the menu model, to keep
the icon attribute reserved for nouns.

https://bugzilla.gnome.org/show_bug.cgi?id=727477
 2014-04-28 14:14:43 -04:00
Ryan Lortie
5137e491dc GtkPopover: new approach to menu model binding 
Instead of using GtkMenuTracker to flatten the sections into a single
linear menu, handle the sections ourselves by nesting boxes.

Each section gets an inner and outer box.  The inner box numbers its
children in the way that the tracker instructs.  The outer box
containes the inner box and the separator, if appropriate.

Having the two separate boxes will allow us to change the orientation of
the inner box if we want to pack widgets horizontally within a section.
 2014-04-28 14:14:42 -04:00
Ryan Lortie
d930716daf GtkMenuTracker: add 'merge_sections' flag 
Add the possibility of a GtkMenuTracker that performs no section
merging.  Instead, it will report an item in the form of a separator for
subsections.  It is then possible to get a separate tracker for the
subsection contents by using gtk_menu_tracker_new_for_item_link().
 2014-04-28 14:14:42 -04:00
Ryan Lortie
f6ee00769a GtkMenuTracker: don't specialise "submenu" link 
We have some API in GtkMenuTracker and GtkMenuTrackerItem that is
specifically designed to deal with submenus.

Generalise these APIs to take a 'link_name' parameter that we always
give as G_MENU_SUBMENU for now.  In the future, this will allow creating
trackers for other types of links, such as sections.
 2014-04-28 14:14:41 -04:00
Ryan Lortie
48db841822 GtkMenuTracker: make "is-visible" a property 
Make this a property just like all of the other things and make the APIs
for accessing it non-private (but add a note that they are not intended
to be used).
 2014-04-28 14:14:41 -04:00
Ryan Lortie
06ab1d9203 GtkMenuTracker: remove "visible" property 
This is in conflict with the "is-visible" pseudo-property which is about
to be promoted to being an actual property.
 2014-04-28 14:14:40 -04:00
Руслан Ижбулатов
5432c37d5a W32: Update the css to match the .modelbutton->.button.menuitem transition 2014-04-28 15:51:51 +00:00
Matthias Clasen
baaf201f2a Rename the modelbutton style class 
This is not a great name to use in themes; instead, add the
menuitem class, so themes can use .button.menuitem for styles
that are specific to menuitem-like buttons.
 2014-04-27 18:49:27 -04:00
Matthias Clasen
987b56973c GtkModelButton: improve size allocation 
Only reserve size for an indicator if at least one sibling
actually has an indicator.
 2014-04-26 17:48:57 -04:00
Matthias Clasen
a5d2778737 Actually set the default for GtkMenuButton::use-popover 
The previous commit changed the property declaration, but
omitted the actual change of the default.
 2014-04-26 14:40:52 -04:00
Matthias Clasen
b6e724e76f Add Adwaita to the list of default icon themes 
Hardcode the fallback to Adwaita. I'm leaving gnome in here for
now, since we're in the middle of the transition. It will be
removed before 3.14.
 2014-04-26 10:14:38 -04:00
Juan Pablo Ugarte
f2d488dea1 Fixed crash in GtkLockButton if a button with permission set to NULL is clicked. 
https://bugzilla.gnome.org/show_bug.cgi?id=728992
 2014-04-25 22:13:56 -04:00
Matthias Clasen
063bd57873 GtkWindow: Avoid a critical in F10 handling 
The focus widget might be NULL, and we were forgetting to take
that possibility into account in one place.
 2014-04-25 22:12:05 -04:00
Matthias Clasen
66b6078ae2 GtkDialog: Update suggested-action more carefully 
We were not really handling all cases correctly here. We want
the suggested-action style class to only be set on headerbar
buttons, and it should be set on the default widget. Ensure
this by syncing the suggested-action style class with the
default style class. As a side-effect, setting has-default
on an action widget in ui files will now have the expected
effect.

https://bugzilla.gnome.org/show_bug.cgi?id=728846
 2014-04-25 22:11:53 -04:00
Matthias Clasen
90559a3fc5 GtkDialog: Support adding action widgets in ui files 
GtkDialog has convenience API for adding action widgets that are
either placed in the action area or the headerbar. This commit
makes the same functionality available from GtkBuilder ui files
by specifying "action" as the child type.

https://bugzilla.gnome.org/show_bug.cgi?id=728846
 2014-04-25 22:11:38 -04:00
Antoine Jacoutot
8935d2f123 openbsd: properly set len for gtkmountoperation-x11 
sysctl(3) is the correct way to get the lenght for len in this case.
Also drop unused headers and change style to match the rest of the file.
 2014-04-25 14:37:59 +02:00
Matthias Clasen
fab2173b31 GtkMenuButton: use popovers by default 
When constructing from a menu model, use popovers by default.
This change has the potential to cause some size problems for
applications with big gear menus, so we're doing it early in
the cycle to uncover and fix those.
 2014-04-24 23:35:18 -04:00
Руслан Ижбулатов
37aa840e89 W32: Add modelbutton styles 
According to what i've been told, modelbuttons are supposed to look
flat, like menu items.

This is basically an improved copy of the menuitem styles.

https://bugzilla.gnome.org/show_bug.cgi?id=728810
 2014-04-24 03:35:50 +00:00
Руслан Ижбулатов
1bcd7c40bd W32: Add a set of "focused" styles to checkmarks 
This prevents checkmarks in modelbuttons from being styled as buttons
(apparently, modelbuttons apply "focused" to their children, unlike
normal buttons).

https://bugzilla.gnome.org/show_bug.cgi?id=728808
 2014-04-24 03:35:50 +00:00
Руслан Ижбулатов
5309149f75 W32: Fix dummy prelight style for check/radio buttons 
Use a dummy transparent gradient instead of actual color (which screws up
focus rectangle on prelight), and apply to non-prelight state as well.

https://bugzilla.gnome.org/show_bug.cgi?id=728807
 2014-04-24 03:35:49 +00:00
Руслан Ижбулатов
f4b61e92f6 W32: remove the blue "selected" rectangle when activating a checkbutton 
https://bugzilla.gnome.org/show_bug.cgi?id=728806
 2014-04-24 03:35:49 +00:00
Matthias Clasen
6e5191f6b6 dialog: keep action area stretched out 
Adding an extra box in between had the side effect of
making the action area no longer go all across the dialog.
Setting hexpand compensates for this.
 2014-04-23 00:05:15 -04:00
Matthias Clasen
aab1610d40 DND: go back to a timeout for cancel animation 
Using a tick callback does not really make sense here, since we
are not drawing in a window, but moving a toplevel around.
https://bugzilla.gnome.org/show_bug.cgi?id=728183
 2014-04-22 23:45:59 -04:00
Matthias Clasen
d871105fa8 GtkFileChooserDialog: Avoid a bottom border in the dialog 
We recently started to respect border-width on the action_area
again, so set its border-width to 0 so it doesn't get in the way.

https://bugzilla.gnome.org/show_bug.cgi?id=722211
 2014-04-22 23:10:01 -04:00
William Jon McCann
7e479aa9ee dialog: add a box around the action area to use for styling 
If we want to set style properties that include the area
of the border-width part of action_area we need to use a
parent box.

https://bugzilla.gnome.org/show_bug.cgi?id=722211
 2014-04-22 22:35:02 -04:00
William Jon McCann
384b227e7b file-chooser: make enter location an operation mode 
https://bugzilla.gnome.org/show_bug.cgi?id=722211
 2014-04-22 22:35:02 -04:00
William Jon McCann
20dfe1dd7f file-chooser: merge path bar mode and location mode 
https://bugzilla.gnome.org/show_bug.cgi?id=722211
 2014-04-22 22:35:01 -04:00
William Jon McCann
d8ca588e17 file-chooser: remove select a folder info message 
https://bugzilla.gnome.org/show_bug.cgi?id=722211
 2014-04-22 22:35:01 -04:00
William Jon McCann
d46ed4ec00 file-chooser: don't use an special label for recent 
https://bugzilla.gnome.org/show_bug.cgi?id=722211
 2014-04-22 22:35:00 -04:00
William Jon McCann
a644b34154 file-chooser: add a search bar instead of using a path bar mode 
https://bugzilla.gnome.org/show_bug.cgi?id=722211
 2014-04-22 22:35:00 -04:00
William Jon McCann
cf9b29705f file-chooser: add sidebar class to sidebar 
https://bugzilla.gnome.org/show_bug.cgi?id=722211
 2014-04-22 22:35:00 -04:00
William Jon McCann
b5e13cd68f file-chooser: style location bar as a search bar 
So we get a nice bottom border etc.

https://bugzilla.gnome.org/show_bug.cgi?id=722211
 2014-04-22 22:34:59 -04:00
William Jon McCann
b05b91c692 file-chooser: style save mode name box as a search bar 
So we get a bottom border etc.

https://bugzilla.gnome.org/show_bug.cgi?id=722211
 2014-04-22 22:34:59 -04:00
William Jon McCann
22e3552a9d file-chooser: don't show a "save folder:" label 
https://bugzilla.gnome.org/show_bug.cgi?id=722211
 2014-04-22 22:34:58 -04:00
William Jon McCann
5c42068bb3 file-chooser: move location entry into same place as pathbar 
https://bugzilla.gnome.org/show_bug.cgi?id=722211
 2014-04-22 22:34:58 -04:00
William Jon McCann
1e925a85ca places-sidebar: add optional enter location place 
https://bugzilla.gnome.org/show_bug.cgi?id=722211
 2014-04-22 22:34:58 -04:00
William Jon McCann
e2b2339b89 file-chooser: no shadow on scrolled window 
https://bugzilla.gnome.org/show_bug.cgi?id=722211
 2014-04-22 22:34:57 -04:00
William Jon McCann
c253bc3165 file-chooser: use an action bar for extra widgets area 
https://bugzilla.gnome.org/show_bug.cgi?id=722211
 2014-04-22 22:34:57 -04:00
William Jon McCann
df9522d8a8 file-chooser: allow views to extend to the sides of the dialog 
https://bugzilla.gnome.org/show_bug.cgi?id=722211
 2014-04-22 22:34:56 -04:00
William Jon McCann
458cd04c13 file-chooser: move filter combo into extra area 
https://bugzilla.gnome.org/show_bug.cgi?id=722211
 2014-04-22 22:34:56 -04:00
William Jon McCann
256a3a51da file-chooser: move pathbar into preview pane 
https://bugzilla.gnome.org/show_bug.cgi?id=722211
 2014-04-22 22:34:56 -04:00
William Jon McCann
5a73757cdb places-sidebar: use separators instead of heading labels 
https://bugzilla.gnome.org/show_bug.cgi?id=722211
 2014-04-22 22:34:55 -04:00