Benjamin Otte
f7646cf541
textview: Remove GdkWindow usage from the public API
...
A sideeffect is that we don't set the correct parent window on child
widgets anymore, but that is hopefully going to be fixed once we get rid
of child windows completely.
2017-11-04 15:22:25 +01:00
Benjamin Otte
1c36c6ed4d
widget: Remove gtk_widget_has_screen()
...
All widgets always have a screen (or display).
2017-10-31 04:33:11 +01:00
Alexander Larsson
96b04836d8
Drop all uses of GdkPixbufAnimation in the gtk APIs
...
These are basically animated gifs, and don't fit well in how
modern things animate.
2017-10-23 16:56:49 +02:00
Alexander Larsson
0089e4ad58
Drop pixbuf support in IconHelper and ImageDefinition
...
These are no longer used, instead we always covert to surface as
early as possible and drop the pixbuf.
This means we never store both the pixbuf and the surface at
for any longer time, which is wasteful. Also, its one step further
to drop GdkPixbufs from generic use in our APIs.
2017-10-23 15:28:33 +02:00
Alexander Larsson
2b194089dd
GtkImage: Drop support for storing pixbufs
...
This drops the pixbuf property and the pixbuf getters. We keep
gtk_image_new/set_from_pixbuf, but these are small helpers that
immediately convert to a surface, and there is no way to later get
back the pixbuf you passed in.
The from file/resource codepaths are also changed to load a surface
instead of a pixbuf.
2017-10-23 15:28:33 +02:00
Matthias Clasen
9da057568c
Fix GtkStatusbarAccessible
...
GtkStatusbar is no longer a container, so GtkStatusbarAccessible
can no longer be a container accessible.
2017-10-18 17:30:20 +02:00
Daniel Boles
a5c0a5c546
a11y/entry: Fixups for previous commit
...
We still declare all variables at the start of the block.
Also, we can use the fast private _gtk_widget_get_allocation().
https://bugzilla.gnome.org/show_bug.cgi?id=784509
2017-10-15 12:58:25 +01:00
Samuel Thibault
9af088693a
a11y/entry: Fix text coords not adjusted for alloc
...
What is missing is the "allocation" part of x/y coordinates. Since
gtk_entry_realize doesn't call gtk_widget_set_window(priv->text_area),
the coordinates returned by gdk_window_get_origin don't include it.
This patch fixes this.
https://bugzilla.gnome.org/show_bug.cgi?id=784509
2017-10-15 12:37:44 +01:00
Benjamin Otte
43c212ac28
build: Enable -Wswitch-enum and -Wswitch-default
...
This patch makes that work using 1 of 2 options:
1. Add all missing enums to the switch statement
or
2. Cast the switch argument to a uint to avoid having to do that (mostly
for GdkEventType).
I even found a bug while doing that: clearing a GtkImage with a surface
did not notify thae surface property.
The reason for enabling this flag even though it is tedious at times is
that it is very useful when adding values to an enum, because it makes
GTK immediately warn about all the switch statements where this enum is
relevant.
And I expect changes to enums to be frequent during the GTK4 development
cycle.
2017-10-06 21:23:39 +02:00
Benjamin Otte
c1e9869329
build: Don't turn off critical warnings
...
-Wint-conversion is important because it checks casts from ints to
pointers.
-Wdiscarded-qualifiers is important to catch cases where we don't
strings when we should.
2017-10-06 16:03:08 +02:00
Benjamin Otte
2936953d9f
build: Remove old Makefile.inc files
...
They seem to have been forgotten in the meson transition
2017-10-06 16:03:07 +02:00
Matthias Clasen
d0c92fba69
entry accessible: Give up on GdkEvent api for now
...
Just include gdkeventsprivate.h here for now. This may be
resolved by just dropping icon support from GtkEntry down
the road.
2017-09-19 18:39:03 +02:00
Matthias Clasen
0554f6372b
a11y: Stop listening for configure events
...
This needs to be done differently.
2017-09-19 18:39:03 +02:00
Matthias Clasen
efd287feb3
a11y: Use GdkEvent API in some places
...
More work needed.
2017-09-19 18:39:03 +02:00
Matthias Clasen
9794dc5628
window accessible: Use GdkEvent API
2017-09-19 18:39:02 +02:00
Matthias Clasen
16781c8598
widget accessible: Use GdkEvent API
2017-09-19 18:39:02 +02:00
Carlos Garnacho
e5a3e95b8c
a11y: Partially update to using GdkEvent API
2017-09-19 18:39:02 +02:00
Benjamin Otte
212c46e20a
a11y: Remove check for GtkEventBox
2017-08-02 16:58:05 +01:00
Timm Bäder
cc60046ae9
treeviewaccessible: Don't rely on nonexistent style properties
...
The expander-size style property has been gone for a long time.
2017-07-19 21:27:14 -04:00
Timm Bäder
b60686e8f1
spinbuttonaccessible: Inherit from GtkWidgetAccessible
2017-07-19 21:27:11 -04:00
Tim-Philipp Müller
bdfcfdec57
meson: gtk: install headers
2017-05-03 15:10:54 +01:00
Timm Bäder
4fcca9945f
meson: update build files
2017-05-03 15:10:52 +01:00
Timm Bäder
409ed21594
meson: Sort input files by name
2017-05-03 15:10:52 +01:00
Timm Bäder
5475768d32
Meson build v2
2017-05-03 15:10:50 +01:00
Emmanuele Bassi
7a90e06a3c
Add Meson build files
...
Original work by: Jussi Pakkanen <jpakkane@gmail.com>
https://bugzilla.gnome.org/show_bug.cgi?id=769881
2017-05-03 15:10:50 +01:00
Timm Bäder
0ce9f26dc5
window: Remove has-toplevel-focus property
...
Since embedded toplevels don't exist anymore, :has-toplevel-focus is
equivalent to :active.
2017-03-31 09:50:39 +02:00
Timm Bäder
2aea8dfee9
togglebutton: Move :inconsistent to GtkCheckButton
2017-01-30 18:11:00 +01:00
Benjamin Otte
d50b73f66d
treeview: Remove gtk_tree_view_get_bin_window()
...
We don't want to expose GdkWindows in the public API.
2017-01-08 00:48:12 +01:00
Florian Müllner
593b75fb69
GtkLabelAccessible: Initialize link before setting parent
...
Since at-spi-atk commit 96621a5e95 fixed PropertyChange notifications
for AccessibleParent, setting the parent will result in a call to
ref_state_set() which assumes that the object is fully initialized.
https://bugzilla.gnome.org/show_bug.cgi?id=774939
2016-11-23 18:55:42 -05:00
Matthias Clasen
6e178aede2
Use GdkRGBA for text attributes
...
Now that GtkTextAttributes is private, we can clean this struct
up a bit. The first step is to switch from GdkColor to GdkRGBA,
and adapt all users.
2016-11-01 13:58:10 -04:00
Matthias Clasen
745c348ff8
Make GtkTextAttributes private
...
This is a problematic struct, and giving direct access to it
has kept us from making improvements to GtkTextView. Drop it
from the public API, together with the auxiliary APIs. If
it turns out that this functionality is needed, we should add
individual getters.
2016-11-01 13:58:10 -04:00
Rico Tzschichholz
2273f5d28e
iconset: Remove stray references
2016-10-23 11:12:13 +02:00
Timm Bäder
a5867ffe71
Remove some more GdkColor properties
2016-10-20 20:12:08 +02:00
Timm Bäder
dece018994
Remove GtkAlignment
2016-10-18 00:29:19 +02:00
Timm Bäder
e9a974f4f6
buttonaccessible: Stop looking at the button's image
2016-10-18 00:29:19 +02:00
Emmanuele Bassi
81e5996c91
Include the appropriate headers
...
The GtkStackAccessible implementation should include the private header,
and the private header should include the public one.
2016-10-17 11:10:14 +01:00
Emmanuele Bassi
d8892c0fdb
Remove redundant declarations
2016-10-17 11:10:14 +01:00
Emmanuele Bassi
137e1aa988
Use appropriate const declaration for static strings
2016-10-17 11:10:14 +01:00
Benjamin Otte
1518fe0a8f
API: stylecontext: Remove state argument from getters
...
The argument must always be the current state.
2016-10-16 18:18:58 +02:00
Timm Bäder
6a6c49369e
Fix a few GtkTextTag:*-gdk references
2016-10-16 18:17:21 +02:00
Timm Bäder
7f79a3fade
Remove GtkMisc
2016-10-16 18:17:21 +02:00
Timm Bäder
367f13a76f
Remove GtkArrow
2016-10-16 18:17:21 +02:00
Timm Bäder
ad155fb26c
Remove GtkStock API from GtkImage
2016-10-16 18:17:21 +02:00
Benjamin Otte
021fe010b6
API: Remove GtkPlug, GtkSocket and GtkWin32EmbedWidget
2016-10-16 18:17:21 +02:00
Benjamin Otte
da8cef16dc
a11y: Correctly indent code
2016-08-25 23:02:27 +02:00
Timm Bäder
9d5fe26420
build: add GtkStack accessible private header at the right place
2016-05-30 20:41:49 +02:00
Timm Bäder
0b0d4765a0
Add GtkStackAccessible
...
Show only the currently visible child to a11y.
2016-05-30 19:12:52 +02:00
Matthias Clasen
2b1fc6166c
a11y: Expose window type hint as attribute
...
This was an old request, maybe still useful.
https://bugzilla.gnome.org/show_bug.cgi?id=468122
2016-03-04 23:50:50 -05:00
Matthias Clasen
c264cd6785
Split off a private header for GtkTextBuffer
...
This avoids polluting the installed header with private symbols.
2015-10-15 23:04:44 -04:00
Matthias Clasen
93a4030c45
Remove a duplicate string
...
dialog-information was twice in the list of accessible labels
for icon names.
2015-07-26 02:57:39 -04:00
Joanmarie Diggs
8f644101b9
a11y: Only emit signals when cells change; not upon creation
...
This is a workaround for atspi-atk behaviour.
atspi-atk uses signal emission hooks. So it to already catches
signal emissions on creation of objects, before anyone could even
think of g_signal_connect()ing.
https://bugzilla.gnome.org/show_bug.cgi?id=746706
2015-04-10 16:36:06 +02:00
Joanmarie Diggs
9749013e5f
Fix an AtkStateType emitted for GtkBooleanCellAccessible
...
An apparent copy-and-paste error is resulting in ATs being notified of
changes in ATK_STATE_CHECKED when the cell's "sensitive" state changes.
https://bugzilla.gnome.org/show_bug.cgi?id=746784
2015-03-26 08:23:37 -04:00
Joanmarie Diggs
1ed9d33d24
a11y: Only emit name-changed once
...
We were emitting it twice, once with deleting the old text, once with
inserting the new text.
https://bugzilla.gnome.org/show_bug.cgi?id=746706
2015-03-25 04:06:23 +01:00
Joanmarie Diggs
c66d165676
a11y: Free the cell text after emitting text-changed:delete.
...
This is needed because AT-SPI2's ATK bridge exposes the deleted string
to ATs.
https://bugzilla.gnome.org/show_bug.cgi?id=746706
2015-03-25 04:06:23 +01:00
Joanmarie Diggs
d553c0ae1e
a11y: Refactor code
...
Put the equality check in front. This allows better detection of when an
insert or delete needs to be emitted.
Also, only emit text-changed:delete if the deleted text is not the empty
string. Only emit text-changed:insert if the inserted text is not the
empty string.
https://bugzilla.gnome.org/show_bug.cgi?id=746706
2015-03-25 04:06:23 +01:00
Joanmarie Diggs
4340e977e4
a11y: Refactor textcellaccessible code
...
Compute the new text and its length in advance. This way those
computations will not confuse us when they happen in the middle of the
actual action.
https://bugzilla.gnome.org/show_bug.cgi?id=746706
2015-03-25 04:06:23 +01:00
Christian Hergert
7bb3d9557f
a11y: handle atk race condition where widget has been destroyed
...
If the widget has been destroyed since a DBus message had been sent,
we could be in a condition that the widget pointer exists but it does
not have a window.
This bails as if the widget didn't exist if there is no available
GdkWindow.
We also set the extents to 0 to be defensive since this is a vfunc
implementation.
https://bugzilla.gnome.org/show_bug.cgi?id=746586
2015-03-21 20:05:08 -04:00
Matthias Clasen
fec8a1ee7f
menu button: Improve accessibility
...
Rework the way we assign an accessible name to menu buttons,
to make sure we pick up a label, should the button contain
one, and only override the name with "Menu" as a fallback.
2015-03-13 18:38:18 -04:00
Peter Bloomfield
5611cf2096
Do not return NULL AtkStateSet
...
https://bugzilla.gnome.org/show_bug.cgi?id=741511
2015-02-28 13:52:22 -05:00
Matthias Clasen
7624418ddf
Drop nonworking code to set a11y roles of tooltips
...
This code relied on widget names, and we don't set those anymore.
2015-02-18 17:28:07 -05:00
Alexander Larsson
8c361fd7e2
gtk: Add support for g_autoptr()
...
https://bugzilla.gnome.org/show_bug.cgi?id=743640
2015-02-02 09:31:27 +01:00
Mike Gorse
9cbf04c1d2
A11y: fix typo when initializing a container cell accessible
...
Gtk_container_cell_widget_set should chain up to its parent's set
function, not its parent's unset function. This was resulting in
accessibles being erroneously marked defunct after being created.
2015-01-26 15:03:10 -06:00
Maks Naumov
54806d1295
Fix accessible_class->widget_set initialization
...
Signed-off-by: Maks Naumov <maksqwe1@ukr.net>
https://bugzilla.gnome.org/show_bug.cgi?id=742778
2015-01-13 19:01:01 -05:00
Matthias Clasen
25d9412c7e
Split subdirectory file lists off
...
This moves a little closer to a proper nonrecursive setup, and
makes the gtk Makefile.am less monstrous.
2014-11-30 16:11:56 -05:00
Joanmarie Diggs
246c172e1e
GtkButtonAccessible: Stop emitting state-change signals for ATK_STATE_ARMED
...
ATK_STATE_ARMED is now deprecated. There is no replacement.
https://bugzilla.gnome.org/show_bug.cgi?id=740438
2014-11-25 22:33:27 -05:00
Joanmarie Diggs
2893a71a3e
Implement support for ATK_STATE_HAS_TOOLTIP
...
https://bugzilla.gnome.org/show_bug.cgi?id=738982
2014-10-22 22:55:13 -04:00
Matthias Clasen
ef62a872f5
GtkContainerAccessible: avoid resurrecting accessibles
...
When removing a child, we don't want to resurrect its
accessible needlessly.
2014-10-14 23:58:37 -04:00
Benjamin Otte
7e5b58c727
stylecontext: Move private a11y function to private header
2014-08-16 19:39:44 +02:00
Ryan Lortie
49ccb23743
GtkMenuItemAccessible: use "insert" signal
...
Use the "insert" rather than the "add" signal to reliably detect
additions of menu items.
https://bugzilla.gnome.org/show_bug.cgi?id=372545
2014-08-15 10:29:48 -04:00
Timm Bäder
fb7d710931
listboxrowaccessible: Avoid assertion failure
...
The next call to gtk_list_box_get_selection_mode just expected the
GtkListBoxRow's parent to be a GtkListBox and failed when the row was
added to something other than a GtkListBox.
https://bugzilla.gnome.org/show_bug.cgi?id=733782
2014-08-03 02:48:26 +02:00
Matthias Clasen
2b0ae4bad3
GtkPopover: Properly update a11y parent
...
When the relative-to widget changes, update the accessible parent
of the popovers accessible.
https://bugzilla.gnome.org/show_bug.cgi?id=733923
2014-07-30 23:14:41 +02:00
Alejandro Piñeiro
2be4474a19
a11y: unref selected item only if it is not NULL
...
https://bugzilla.gnome.org/show_bug.cgi?id=733610
2014-07-25 10:03:24 +02:00
Benjamin Otte
fcbbe54936
a11y: Do not include gtkx.h directly
2014-07-12 07:13:27 +02:00
Benjamin Otte
4b793dd508
a11y: Remove an outdated comment
2014-06-10 01:17:00 +02:00
Joanmarie Diggs
fc00381d30
GtkEntryAccessible: Emit signal after insertion
...
The signal needs to be emitted after the text insertion as at-spi gets
the text to compute the inserted text due to the AtkText::insert-text
signal not containing it.
Also adjust position to reflect changes to the offsets.
https://bugzilla.gnome.org/show_bug.cgi?id=731429
2014-06-10 01:07:57 +02:00
Evan Nemerson
bda145b19f
gtk: fix annotation syntax and missing some missing annotations
...
These changes clean up various errors and omissions resulting from
either slightly incorrect G-I/gtk-doc syntax or missing documentation
blocks.
https://bugzilla.gnome.org/show_bug.cgi?id=730745
2014-05-27 21:10:32 -07:00
Matthias Clasen
04703689b8
Deprecate GtkAligment
...
This has been dangling ever since 3.0.
https://bugzilla.gnome.org/show_bug.cgi?id=645781
2014-05-23 20:31:25 -04:00
Evan Nemerson
4a4b23bfad
a11y: build directly into libgtk instead of an internal library
...
https://bugzilla.gnome.org/show_bug.cgi?id=730615
2014-05-23 19:20:59 -04:00
Cosimo Cecchi
a2a1c6da95
cellarea: don't use focus-line-width
...
Use CSS padding instead.
2014-05-09 11:02:45 -07:00
Matthias Clasen
22ab2ca2a5
a11y: Avoid a warning
...
The listbox row accessible code was giving warnings when
parent is NULL, at destruction time.
2014-05-05 19:46:04 -04:00
Benjamin Otte
748b2bf5ae
a11y: Disable deprecation warnings in AtkMisc implementation
2014-05-05 16:10:16 +02:00
Matthias Clasen
9d7f7ddadf
GtkSpinButton: Implement new AtkValue interface
...
The AtkValue interface has been replaced in ATK 2.12.
Implement the new one in addition to the old one.
2014-05-02 20:47:16 -04:00
Matthias Clasen
fc7e7495a6
GtkScaleButton: Implement new AtkValue interface
...
The AtkValue interface has been replaced in ATK 2.12.
Implement the new one in addition to the old one.
2014-05-02 20:47:00 -04:00
Matthias Clasen
516cd70780
GtkRange: Implement new AtkValue interface
...
The AtkValue interface has been replaced in ATK 2.12.
Implement the new one in addition to the old one.
2014-05-02 20:46:45 -04:00
Matthias Clasen
1d50657740
GtkProgressBar: Implement new AtkValue interface
...
The AtkValue interface has been replaced in ATK 2.12.
Implement the new one in addition to the old one.
2014-05-02 20:46:30 -04:00
Matthias Clasen
98affc6829
GtkPaned: Implement new AtkValue interface
...
The AtkValue interface has been replaced in ATK 2.12.
Implement the new one in addition to the old one.
2014-05-02 20:46:17 -04:00
Matthias Clasen
987cce9e65
GtkLevelBar: Implement new AtkValue interface
...
The AtkValue interface has been replaced in ATK 2.12.
Implement the new one in addition to the old one.
2014-05-02 20:46:03 -04:00
Matthias Clasen
efcaaa524e
list box: Update accessible implementation
...
Now that multi selection is supported, we can provide a more
complete AtkSelection implementation.
2014-04-06 01:44:36 -04:00
Matthias Clasen
fee33b1a81
Clean up private headers
...
This commit adds a few missing private headers, and cleans up
some irregularities in the existing ones
2014-04-05 02:06:29 -04:00
Jonas Danielsson
b29bbc6210
a11y: atk_table_get_row_at_index is deprecated
...
Do not use deprecated index based AtkTable functions use static
helper instead.
https://bugzilla.gnome.org/show_bug.cgi?id=727313
2014-04-01 21:40:24 -04:00
Jonas Danielsson
e7962f5871
a11y: atk_component_get_position is deprecated
...
Switch to using atk_component_get_extents instead.
https://bugzilla.gnome.org/show_bug.cgi?id=727313
2014-04-01 21:40:23 -04:00
Bastien Nocera
f71f7215ab
all: Name more idles and timeouts
...
Following up from 438cd857c4
,
name more timeouts and idles.
The original grep was missing checking for gdk_threads_add_*()
functions (at least for some of the files).
https://bugzilla.gnome.org/show_bug.cgi?id=726870
2014-03-26 20:09:30 -04:00
Benjamin Otte
be7380a418
a11y: Move relationset updating to new vfunc
...
This way, we don't create lots of cell accessibles when creating the
first one (because surely one is the parent/child of another who again
is a parent/child of another who again....)
2014-03-24 16:38:18 +01:00
Benjamin Otte
8374a58623
a11y: Add API to update relationsets of cells to their parents
2014-03-24 16:38:18 +01:00
Benjamin Otte
fef14e0e87
a11y: Don't unref relations
...
Nobody was reffing those related object in the first place and that
was causing random crashes.
And if somebody had reffed those related objects, they'd have caused
reference cycles.
https://bugzilla.gnome.org/show_bug.cgi?id=726838
2014-03-24 16:38:17 +01:00
Carlos Garnacho
0e7884f1a7
a11y: Remove weak reference when updating a GtkPopoverAccessible relative-to widget
...
Otherwise the weak reference is left dangling, which later causes issues at the time
of destroying that widget.
https://bugzilla.gnome.org/show_bug.cgi?id=726749
2014-03-21 15:33:58 +01:00
Benjamin Otte
66fae0330c
a11y: Don't use signals
...
Instead, call functions directly. Fixes the fact that the signals
weren't disconnected even when the accessible was destroyed.
https://bugzilla.gnome.org/show_bug.cgi?id=725733
2014-03-13 02:02:50 +01:00
Carlos Garnacho
89c4ef5873
a11y: Don't allocate a list just for counting widgets in GtkContainerAccessible
...
It's more straightforward if counting through gtk_container_foreach().
2014-03-10 23:02:41 +01:00
Carlos Garnacho
31cd153050
a11y: Add GtkPopopverAccessible
...
And let GtkPopover use it as its GtkAccessible implementation, this
accessible sets the POPUP_FOR relationship to the relative-to widget,
and keeps track of changes there.
https://bugzilla.gnome.org/show_bug.cgi?id=725864
2014-03-10 23:02:14 +01:00
Carlos Garnacho
d4d6968e1a
a11y: Add private GtkContainerAccessible functions to add/remove a child
...
This may be useful in container implementations, or for internal children
that trigger no signal emission.
https://bugzilla.gnome.org/show_bug.cgi?id=725864
2014-03-10 23:01:59 +01:00