Commit Graph

7529 Commits

Author SHA1 Message Date
Yevgen Muntyan
c9371f873b Moved gtk_text_view_update_im_spot_location() calls into an idle, fixes
2007-11-11  Yevgen Muntyan  <muntyan@tamu.edu>

	* gtk/gtktextview.c: Moved gtk_text_view_update_im_spot_location()
	calls into an idle, fixes #494776.
	GtkTextViewPrivate:im_spot_idle, do_update_im_spot_location(),
	queue_update_im_spot_location(), flush_update_im_spot_location(): new
	field and functions to queue the call;
	(changed_handler): call queue_update_im_spot_location() instead of
	gtk_text_view_update_im_spot_location();
	(gtk_text_view_key_press_event): flush the idle here.


svn path=/trunk/; revision=18984
2007-11-11 19:07:27 +00:00
Ryan Lortie
d65049378b Convert delayed_properties hashtable to linked list. Fixes #495769.
2007-11-10  Ryan Lortie  <desrt@desrt.ca>

        * gtk/gtkbuilder.c: Convert delayed_properties hashtable to linked
        list.  Fixes #495769.


svn path=/trunk/; revision=18983
2007-11-11 18:06:11 +00:00
Matthias Clasen
464ae98495 Leak less in error paths
svn path=/trunk/; revision=18980
2007-11-10 23:57:32 +00:00
Matthias Clasen
06d28ff884 Don't leak buffer if an error occurs.
2007-11-10  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkbuilder.c (gtk_builder_add_from_file): Don't
        leak buffer if an error occurs.



svn path=/trunk/; revision=18979
2007-11-10 05:03:10 +00:00
Matthias Clasen
6665188687 More robustness improvements of the parser
svn path=/trunk/; revision=18978
2007-11-10 04:50:15 +00:00
Matthias Clasen
f489387039 Don't assert on misplaced signal elements
svn path=/trunk/; revision=18977
2007-11-10 04:15:44 +00:00
Matthias Clasen
c3fcd42eda Handle misplaced property elements without asserting.
2007-11-09  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkbuilderparser.c (parse_property): Handle misplaced
        property elements without asserting.


svn path=/trunk/; revision=18976
2007-11-10 02:36:56 +00:00
Matthias Clasen
b2ad97dd38 Stylistic fixes
svn path=/trunk/; revision=18974
2007-11-09 16:56:17 +00:00
Matthias Clasen
fb4b0ddff7 don't leak 'filename' field memory when loading more than one file into
2007-11-08  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkbuilder.c: don't leak 'filename' field memory when loading
        more than one file into the same GtkBuilder instance. Noticed by
        Ryan Lortie.


svn path=/trunk/; revision=18973
2007-11-09 00:33:45 +00:00
Michael Natterer
d5dca93c58 include <glib.h> instead of <glib/gmarkup.h>
2007-11-08  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkbuildable.h: include <glib.h> instead of <glib/gmarkup.h>


svn path=/trunk/; revision=18972
2007-11-08 12:30:01 +00:00
Matthias Clasen
a27a83c37c Forgotten file
svn path=/trunk/; revision=18971
2007-11-08 05:21:06 +00:00
Ryan Lortie
36605333d0 Add GString 'text' to the property info structure. Used to accumulate
2007-11-07  Ryan Lortie  <desrt@desrt.ca>

        * gtk/gtkbuilderprivate.h: Add GString 'text' to the property info
        structure.  Used to accumulate property text across multiple 'text'
        calls.

        * gtk/gtkbuilderparser.c: Instead of translating/copying text on each
        'text' call while in <property> accumulate the text until the end and
        do it all in one go.  This fixes handling of <!-- --> inside
        properties as well as <property/> cases.


svn path=/trunk/; revision=18970
2007-11-08 04:12:52 +00:00
Michael Natterer
9b3edbc319 call gdk_flush() after showing the menu so we can definitely grab on it.
2007-11-06  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkmenu.c (gtk_menu_popup): call gdk_flush() after showing
	the menu so we can definitely grab on it. Grab failure found by
	Xan Lopez.


svn path=/trunk/; revision=18969
2007-11-06 14:23:56 +00:00
Michael Natterer
f93e2db2a9 fixed docs.
2007-11-06  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkwidget.c (gtk_widget_keynav_failed): fixed docs.


svn path=/trunk/; revision=18968
2007-11-06 08:57:33 +00:00
Richard Hult
fd90de672b Fix bug #486369, by passing the selection info along when pasting.
2007-11-03  Richard Hult  <richard@imendio.com>

	* gtk/gtkclipboard-quartz.c: (clipboard_owner_destroyed),
	(gtk_clipboard_set_contents), (clipboard_unset): Fix bug #486369,
	by passing the selection info along when pasting.

svn path=/trunk/; revision=18965
2007-11-03 13:12:45 +00:00
Richard Hult
5cb6747339 Redo the fix for bug #492117, by adding a getter for the private drag
2007-11-01  Richard Hult  <richard@imendio.com>

	* gdk/quartz/GdkQuartzWindow.c:
	* gdk/quartz/GdkQuartzWindow.h:
	* gdk/quartz/gdkdnd-quartz.c:
	* gdk/quartz/gdkquartz.h:
	* gtk/gtkdnd-quartz.c: Redo the fix for bug #492117, by adding a
	getter for the private drag context info so we don't need to
	expose so much in the public quartz header file.

svn path=/trunk/; revision=18959
2007-11-01 08:45:30 +00:00
Emmanuele Bassi
b2f4e11df3 Chain up to the parent's finalize virtual function.
2007-10-30  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkbuilder.c (gtk_builder_finalize): Chain up to the
	parent's finalize virtual function.

svn path=/trunk/; revision=18952
2007-10-30 12:25:39 +00:00
Owen Taylor
5072e43bb2 Allow the ::delete-range handler to delete text after the text it was
2007-10-28  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtktextbuffer.c (gtk_text_buffer_delete_interactive): Allow
        the ::delete-range handler to delete text after the text it was
        explicitly asked to delete without confusing us as to whether
        we're currently on an editable or not-editable segment.
        (#491207)

svn path=/trunk/; revision=18951
2007-10-28 22:27:15 +00:00
Owen Taylor
00481dd67c Pay attention to tags that turn invisibility off as well as tags that turn
2007-10-26  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtktextbtree.c (_gtk_text_btree_char_is_invisible):
        Pay attention to tags that turn invisibility off as well
        as tags that turn invsibility on. (#488051, Mathias Hasselmann)

svn path=/trunk/; revision=18949
2007-10-26 14:02:06 +00:00
Johan Dahlin
949d340659 Improve gtk_builder_get_type_from_name() documentation. (#461222, Murray
2007-10-24  Johan Dahlin  <jdahlin@async.com.br>

	* gtk/gtkbuilder.c: Improve gtk_builder_get_type_from_name()
	documentation. (#461222, Murray Cumming)


svn path=/trunk/; revision=18948
2007-10-24 18:24:44 +00:00
Johan Dahlin
de5463131e Give up instead of raising an error if we can't find the parent dialog
2007-10-24  Johan Dahlin  <jdahlin@async.com.br>

	* gtk/gtk-builder-convert 
	(GtkBuilderConverter._convert_dialog_response): 
	Give up instead of raising an error if we can't find
	the parent dialog when converting response ids.
	(#479463, Priyank)


svn path=/trunk/; revision=18945
2007-10-24 11:52:56 +00:00
Johan Dahlin
fa13277655 Parse signals after <child> tags and add tests. (#468793, Benjamin Otte)
2007-10-24  Johan Dahlin  <jdahlin@async.com.br>

	* gtk/gtkbuilder.c: (_gtk_builder_construct),
	(_gtk_builder_add_signals):
	* gtk/gtkbuilderparser.c: (end_element):
	* gtk/gtkbuilderprivate.h:
	* tests/buildertest.c: (test_connect_signals):

	Parse signals after <child> tags and add tests.
	(#468793, Benjamin Otte)


svn path=/trunk/; revision=18944
2007-10-24 11:48:17 +00:00
Johan Dahlin
1d332bbb44 Allow empty property nodes so we can set empty strings. (#486420, Xavier
2007-10-24  Johan Dahlin  <jdahlin@async.com.br>

	* gtk/gtkbuilderparser.c (end_element): Allow empty property nodes
	so we can set empty strings. (#486420, Xavier Claessens)


svn path=/trunk/; revision=18943
2007-10-24 09:46:31 +00:00
Richard Hult
e4849ff2b7 Handle NSFilenamesPboardType in addition to NSURLPboardType to support dnd
2007-10-23  Richard Hult  <richard@imendio.com>

	* gtk/gtkquartz.c:
	(_gtk_quartz_get_selection_data_from_pasteboard): Handle
	NSFilenamesPboardType in addition to NSURLPboardType to support
	dnd with multiple files from Finder, based on patch from Paul
	Davis (bug #467490).

svn path=/trunk/; revision=18941
2007-10-23 19:07:32 +00:00
Johan Dahlin
1f36660d8d Use gtk_ascii_tolower/toupper instead of the C library variants. (#488918,
2007-10-22  Johan Dahlin  <jdahlin@async.com.br>

	* gtk/gtkbuilder.c: Use gtk_ascii_tolower/toupper instead of the C 
	library variants. (#488918, Sertaç Ö. Yıldız)


svn path=/trunk/; revision=18939
2007-10-22 09:15:50 +00:00
Owen Taylor
e6572dfb95 Move -Wl,-luuid to LDFLAGS to make libtool happy.
2007-10-17  Owen Taylor  <otaylor@redhat.com>

        * gtk/Makefile.am (libgtk_win32_2_0_la_LDFLAGS): Move -Wl,-luuid
        to LDFLAGS to make libtool happy.

svn path=/trunk/; revision=18928
2007-10-17 18:39:09 +00:00
Tor Lillqvist
5c6180b9a0 Use -Wl,-luuid instead of -luuid to work around libtool lossage.
2007-10-17  Tor Lillqvist  <tml@novell.com>

	* gtk/Makefile.am (libgtk_win32_2_0_la_LIBADD): Use -Wl,-luuid
	instead of -luuid to work around libtool lossage.


svn path=/trunk/; revision=18927
2007-10-17 16:30:17 +00:00
Matthias Clasen
b7f048b18c 2.12.1
svn path=/trunk/; revision=18924
2007-10-17 05:05:49 +00:00
Matthias Clasen
bf7db03224 Update the doc
svn path=/trunk/; revision=18920
2007-10-17 03:24:28 +00:00
Matthias Clasen
9bfea332aa Update the docs for the ::text-column property. (#352643, Josselin
2007-10-16  Matthias Clasen <mclasen@redhat.com>

        * gtk/gtkentrycompletion.c: Update the docs for the
        ::text-column property.  (#352643, Josselin Mouette)



svn path=/trunk/; revision=18919
2007-10-17 03:09:12 +00:00
Yevgen Muntyan
49b516bb4b Fixed typo in icon_size_lookup_intern() - colon instead of semicolon
svn path=/trunk/; revision=18917
2007-10-16 22:35:26 +00:00
Matthias Clasen
892d287fa3 Be more careful when handling (GtkIconSize)-1. (#456137, Harry Lu, Chris
2007-10-16  Matthias Clasen <mclasen@redhat.com>

        * gkt/gtkiconsize.c: Be more careful when handling
        (GtkIconSize)-1.  (#456137, Harry Lu, Chris Wang, et al)



svn path=/trunk/; revision=18916
2007-10-16 20:08:31 +00:00
Matthias Clasen
6abe62c95b Improve the docs. (#486155, Owen Taylor)
2007-10-16  Matthias Clasen <mclasen@redhat.com>

        * gtk/gtktextiter.c (gtk_text_iter_forward_line): Improve
        the docs.  (#486155, Owen Taylor)



svn path=/trunk/; revision=18914
2007-10-16 17:33:16 +00:00
Matthias Clasen
a07873dd16 Actually use the utf-8 version of the filename. (#485301, Takao Fujiwara)
2007-10-16  Matthias Clasen <mclasen@redhat.com>

        * gtk/gtkprinteroptionwidget.c (update_widgets): Actually use
        the utf-8 version of the filename.  (#485301, Takao Fujiwara)


svn path=/trunk/; revision=18912
2007-10-16 17:25:55 +00:00
Loïc Minier
3671b2bbe9 Fix "cannot open display" error message when display is set by the DISPLAY
2007-10-15  Loïc Minier  <lool@dooz.org>

        * gtk/gtkmain.c: (gtk_init): Fix "cannot open display" error message
        when display is set by the DISPLAY env var. (#486636, Mike Hommey)

svn path=/trunk/; revision=18909
2007-10-15 13:26:34 +00:00
Johan Dahlin
48a704da48 signal_name instead of signal. (#486360, Xavier Claessens)
2007-10-13  Johan Dahlin  <jdahlin@async.com.br>

	* gtk/gtk-builder-convert 
	(GtkBuilderConverter._add_action_from_menuitem): signal_name instead
	of signal. (#486360, Xavier Claessens)


svn path=/trunk/; revision=18907
2007-10-13 18:07:32 +00:00
Matthias Clasen
030529e04b Avoid double-free problems
svn path=/trunk/; revision=18906
2007-10-12 04:31:04 +00:00
Emmanuele Bassi
3ca1e0cd2d Document that you need to unref the returned GdkPixbuf. (#484132,
2007-10-10  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentmanager.c (gtk_recent_info_get_icon): Document
	that you need to unref the returned GdkPixbuf. (#484132,
	Christian Persch)

	(build_recent_info): Use g_slist_prepend() when building
	the applications list.

svn path=/trunk/; revision=18904
2007-10-10 09:31:36 +00:00
Emmanuele Bassi
2ad0ef4632 Convert the format to the current locale before passing it to strtime().
2007-10-10  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkfilechooserdefault.c (list_mtime_data_func): Convert
	the format to the current locale before passing it to
	strtime(). Fixes corrupt dates with non-UTF8 encodings on
	OpenSolaris. (#465380, Takao Fujiwara)

svn path=/trunk/; revision=18903
2007-10-10 08:09:13 +00:00
Emmanuele Bassi
928db3a71b Fix the time_t typecasting on OpenSolaris. (#465380, Takao Fujiwara)
2007-10-10  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkfilechooserdefault.c (list_mtime_data_func): Fix the
	time_t typecasting on OpenSolaris. (#465380, Takao Fujiwara)

svn path=/trunk/; revision=18902
2007-10-10 08:02:16 +00:00
Kristian Rietveld
18b264b5e0 make sure the new cursor node is visible when we are done. (Fixes #472965,
2007-10-09  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down): make
	sure the new cursor node is visible when we are done. (Fixes #472965,
	Carlos Garnacho).


svn path=/trunk/; revision=18899
2007-10-09 19:40:14 +00:00
Kristian Rietveld
449db79467 we should only "don't move the cursor, but just select the current node"
2007-10-09  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktreeview.c (gtk_tree_view_move_cursor_up_down): we should
	only "don't move the cursor, but just select the current node" if the
	cursor node is actually selectable.  (Fixes #483730, reported by
	Geoff Bache).


svn path=/trunk/; revision=18898
2007-10-09 17:08:18 +00:00
Kristian Rietveld
94680cbffc don't "corrupt" all iterators by reversing the list after adding the
2007-10-08  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtkfilesystemmodel.c (got_root_folder_cb),
	(get_children_get_folder_cb): don't "corrupt" all iterators by
	reversing the list after adding the items.  Reversing the list isn't
	needed anyway as the order of the items in the model does not matter.
	(Fixes #327243, comment 10).


svn path=/trunk/; revision=18891
2007-10-08 12:44:35 +00:00
Kristian Rietveld
aed59b3ea9 Fix #482841, patch by Karl Tomlinson.
2007-10-08  Kristian Rietveld  <kris@imendio.com>

	Fix #482841, patch by Karl Tomlinson.

	* gtk/gtktooltip.c (gtk_tooltip_display_closed): use g_object_set_data
	instead of g_object_set ...
	(_gtk_tooltip_toggle_keyboard_mode),
	(_gtk_tooltip_handle_event): connect to GdkDisplay::closed after
	creating tooltip.


svn path=/trunk/; revision=18890
2007-10-08 12:39:02 +00:00
Murray Cumming
5d1a5ac216 Revert the change on 2007-04-29 (Also check the default handler when
2007-10-05  Murray Cumming  <murrayc@murrayc.com>

* gtk/gtkprintoperation.c: (print_pages_idle):
Revert the change on 2007-04-29 (Also check
the default handler when deciding whether to emit the
paginate signal.  (#345345, Yevgen Muntyan)).
This stopped printing from working in gtkmm, and is apparently 
not appropriate anyway. Bug #482089.

svn path=/trunk/; revision=18885
2007-10-05 08:18:43 +00:00
Hiroyuki Ikezoe
31f26042f7 Use g_object_ref() instead of gtk_widget_ref(). (#483563)
2007-10-05  Hiroyuki Ikezoe  <poincare@ikezoe.net>

	* gtk/gtkdnd.c: Use g_object_ref() instead of gtk_widget_ref().
	(#483563)


svn path=/trunk/; revision=18884
2007-10-05 03:08:55 +00:00
Emmanuele Bassi
43f5b189b7 Iterate on the proxies we hold when we change the sorting function and the
2007-10-04  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentaction.c:
	(gtk_recent_action_set_sort_func), (set_current_filter): Iterate
	on the proxies we hold when we change the sorting function and
	the filter.

	(gtk_recent_action_connect_proxy),
	(gtk_recent_action_create_menu): Set the GtkRecentChooser:filter
	property when we create/connect a proxy chooser. Thanks to
	Jonh Wendell for pointing this bug out on gtk-list.

	(gtk_recent_chooser_set_property): Bail out without iterating
	over the proxies when there's no need to.

svn path=/trunk/; revision=18883
2007-10-04 22:52:13 +00:00
Matthias Clasen
0afe895ad2 Add a second volume button.
2007-10-04  Matthias Clasen  <mclasen@redhat.com>

        * tests/testvolumebutton.c: Add a second volume button.

        * gtk/gtkscalebutton.c: Doh, don't release grabs we don't hold.
        (#478371, reported by Bill Nottingham)


svn path=/trunk/; revision=18881
2007-10-04 12:52:46 +00:00
Loïc Minier
618c8de221 Fix warnings and display of modified date / time in filechooser for some
2007-10-04  Loïc Minier  <lool@dooz.org>

       * gtk/gtkfilechooserdefault.c: (list_mtime_data_func): Fix warnings
       and display of modified date / time in filechooser for some locales as
       it was missing a locale to UTF-8 conversion. Fixes #482504.

svn path=/trunk/; revision=18880
2007-10-04 07:40:55 +00:00
Xan Lopez
1cea708e5e remove duplicated declaration of gtk_notebook_create_window. Patch by
2007-10-03  Xan Lopez  <xan@gnome.org>

	* gtk/gtknotebook.c: remove duplicated declaration of
	gtk_notebook_create_window. Patch by Hiroyuki Ikezoe (#482837)

svn path=/trunk/; revision=18878
2007-10-03 19:49:40 +00:00