Commit Graph

7435 Commits

Author SHA1 Message Date
Matthias Clasen
b0c57a4b8f Initialize error to NULL before calling g_set_error(). Should fix #473954,
2007-09-06 Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkfilechooserdefault.c (shortcuts_drop_uris): Initialize
        error to NULL before calling g_set_error(). Should fix #473954,
        reported by Sebastien Bacher.

svn path=/trunk/; revision=18738
2007-09-06 19:15:37 +00:00
13:37:28 Tim Janik
fb0958f085 removed code that forced range repaints upon every motion event, because
2007-09-06 13:37:28  Tim Janik  <timj@imendio.com>

        * gtk/gtkrange.c (gtk_range_adjustment_value_changed): removed code
        that forced range repaints upon every motion event, because these tend
        to stall other repaints on busy CPUs.
        added a timer to still force repaints every once in a while (roughly
        5Hz atm) to avoid leaving the user without feedback on the range.
        fixes bug #460534.



svn path=/trunk/; revision=18730
2007-09-06 11:44:22 +00:00
Tim Janik
92ee6b3ae1 fix wrong default value in ::tab-expand param spec constructor.
Wed Sep  5 14:15:17 2007  Tim Janik  <timj@imendio.com>

        * gtk/gtknotebook.c (gtk_notebook_class_init): fix wrong default value
        in ::tab-expand param spec constructor.



svn path=/trunk/; revision=18725
2007-09-05 12:17:39 +00:00
Fernando Herrera
34cf2826d2 copy filename to builder->priv instead of holding a reference to it. Bug
2007-09-04  Fernando Herrera  <fherrera@onirica.com>

        * gtk/gtkbuilder.c: (gtk_builder_finalize),
        (gtk_builder_add_from_file): copy filename to builder->priv instead of
        holding a reference to it. Bug #472643


svn path=/trunk/; revision=18722
2007-09-04 12:36:24 +00:00
Johan Dahlin
c99040a4b3 Do not iterate recursively over all child nodes.
2007-09-04  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtk-builder-convert (GtkBuilder._packing_prop_to_child_attr):
    Do not iterate recursively over all child nodes.
    (GtkBuilderConverter._default_widget_converter): Use a more efficient
    way of iterating over all property nodes
    #472974 (Carlos Garnacho)


svn path=/trunk/; revision=18721
2007-09-04 12:19:37 +00:00
Michael Natterer
395c785512 added missing \n to g_print() in GTK_NOTE().
2007-09-04  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkmodules.c: added missing \n to g_print() in GTK_NOTE().


svn path=/trunk/; revision=18720
2007-09-04 12:04:07 +00:00
Johan Dahlin
0df0fe47d6 Do not remove empty properties, since we do not know the default
2007-09-04  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtk-builder-convert (GtkBuilderConverter._parse): Do not remove 
    empty properties, since we do not know the default GParamSpec values.
    #472981 (Carlos Garnacho)


svn path=/trunk/; revision=18719
2007-09-04 11:53:18 +00:00
Emmanuele Bassi
ba56e7dd57 Remove the stat() time barrier, as it seems to cause bug #463907 (thanks
2007-09-03  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentmanager.c
	(gtk_recent_manager_poll_timeout): Remove the stat() time barrier,
	as it seems to cause bug #463907 (thanks to Sebastien Bacher).

svn path=/trunk/; revision=18713
2007-09-03 09:49:59 +00:00
Kristian Rietveld
35cae8d92b lower the default timeout values for gtk-tooltip-timeout and
2007-08-29  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtksettings.c: lower the default timeout values for
	gtk-tooltip-timeout and gtk-tooltip-browse-timeout. (#451202,
	Richard Hult).


svn path=/trunk/; revision=18701
2007-08-29 12:01:15 +00:00
Stefan Kost
bf4b559a31 Update menu accelerators, when adding/removing AccelGroups dynamically.
* gtk/gtkwindow.c: Update menu accelerators, when adding/removing
	AccelGroups dynamically. (#469374)


svn path=/trunk/; revision=18691
2007-08-27 17:46:53 +00:00
Cody Russell
9c24a3dbd9 Use the correct type check on `window'. We now check GTK_IS_WINDOW rather
2007-08-23  Cody Russell  <bratsche@gnome.org>
        * gtk/gtkwindow.c (gtk_window_group_remove_window: Use the
        correct type check on `window'.  We now check GTK_IS_WINDOW
        rather than GTK_IS_WIDGET. (#461483, Josselin Mouette)


svn path=/trunk/; revision=18681
2007-08-23 16:00:10 +00:00
Jan Arne Petersen
d18eaf32dd Duplicate the string returned by d[n]gettext before it is potentially
2007-08-23  Jan Arne Petersen  <jpetersen@jpetersen.org>

	* gtk/gtkbuilderparser.c: (text): Duplicate the string returned by
	d[n]gettext before it is potentially freed. (#461945)


svn path=/trunk/; revision=18678
2007-08-23 15:29:59 +00:00
Emmanuele Bassi
a35bd52a96 Check if we are still holding the model before updating it; removes a set
2007-08-23  Emmanuele Bassi  <ebassi@gnome.org>

	* gtkfilechooserdefault.c:
	(search_hit_get_info_cb), (recent_item_get_info_cb): Check if
	we are still holding the model before updating it; removes a
	set of critical warnings when switching to the browse mode from
	a loading search or recent files list.

	(recent_clear_model), (recent_sort_model),
	(recent_idle_cleanup): When in recent files mode, set the
	model for the files list view when we have completed the loading
	of the recently used files list. This makes switching between
	modes fast again and reduces the amount of redraws needed
	to display the list. (#469214)

svn path=/trunk/; revision=18677
2007-08-23 10:48:28 +00:00
Kristian Rietveld
31fc4289c7 Do not allow the cursor to go to a separator row. Fixes #441219, modified
2007-08-22  Kristian Rietveld  <kris@imendio.com>

	Do not allow the cursor to go to a separator row.  Fixes #441219,
	modified patch by Carlos Garnacho.

	* gtk/gtktreeview.c (row_is_separator): new inline function
	for calling the row-separator-func, made all of gtktreeview.c use
	this function instead of calling the func themselves,
	(gtk_tree_view_button_press): treat a click on a separator like
	a click on empty space,
	(gtk_tree_view_update_rubber_band_selection_rage): skip
	non-selectable rows,
	(search_first_focusable_path),
	(gtk_tree_view_focus_to_cursor),
	(gtk_tree_view_move_cursor_up_down),
	(gtk_tree_view_move_cursor_page_up_down),
	(gtk_tree_view_move_cursor_start_end): skip separators,
	(gtk_tree_view_real_set_cursor): do not allow setting the cursor
	on a separator.


svn path=/trunk/; revision=18672
2007-08-22 14:26:32 +00:00
Tristan Van Berkom
0f9230d30a Corrected the published default value of GtkFrame::label-xalign (bug
* gtk/gtkframe.c: Corrected the published default value of
	GtkFrame::label-xalign (bug 460272).


svn path=/trunk/; revision=18671
2007-08-22 13:41:32 +00:00
Kristian Rietveld
7adde1e4fd update alignment padding after theme changes. (Fixes #467003, patch by
2007-08-21  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktooltip.c (gtk_tooltip_init),
	(gtk_tooltip_window_style_set): update alignment padding after
	theme changes. (Fixes #467003, patch by Benjamin Berg).


svn path=/trunk/; revision=18667
2007-08-21 13:13:42 +00:00
Kristian Rietveld
ef1da5f6c2 always set hide_tooltip to TRUE if we are handling a leave notify event.
2007-08-21  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktooltip.c (_gtk_tooltip_handle_event): always set
	hide_tooltip to TRUE if we are handling a leave notify event. (Fixes
	#468245, reported by Dennis Jacobfeuerborn).


svn path=/trunk/; revision=18666
2007-08-21 11:09:42 +00:00
Michael Natterer
183a3276ff applied patch from Mikael Hallendal which documents GtkPaned's keybinding
2007-08-21  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkpaned.c (gtk_paned_class_init): applied patch from Mikael
	Hallendal which documents GtkPaned's keybinding signals (#467117).


svn path=/trunk/; revision=18664
2007-08-21 11:00:56 +00:00
Kristian Rietveld
f6235caef9 Fix #457642, reported by Christian Persch.
2007-08-21  Kristian Rietveld  <kris@imendio.com>

	Fix #457642, reported by Christian Persch.

	* gtk/gtktooltip.c: added debugging output which can be compiled
	in with a #define, annotated all coordinate translations in the
	source code,
	(find_widget_under_pointer): remove the "no-window correction";
	always convert the coordinates from window relative to allocation
	relative; after recursing through a container, translate the
	coordinates from container allocation relative to child widget
	allocation relative;
	(find_topmost_widget_from_event): now we get allocation relative
	coordinates here we do not have to distinguish no-window and window
	widgets.


svn path=/trunk/; revision=18663
2007-08-21 10:52:43 +00:00
Cody Russell
72528aba5f Fixed incorrect compose mapping for capital U with macron. (#468055, Aaron
2007-08-18  Cody Russell  <bratsche@gnome.org>

        * gtk/gtkimcontextsimple.c: Fixed incorrect compose mapping
        for capital U with macron. (#468055, Aaron Crane)


svn path=/trunk/; revision=18651
2007-08-19 04:41:09 +00:00
Tim Janik
fda0eb309b Clarified activate_time docs.
Fri Aug 17 11:36:29 2007  Tim Janik  <timj@imendio.com>                                                                                                       
                                                                                                                                                              
        * gtk/gtkmenu.c (gtk_menu_popup): Clarified activate_time docs.                                                                                       
                                                                                                                                                              


svn path=/trunk/; revision=18643
2007-08-17 09:36:15 +00:00
Cody Russell
cd57ff1053 Another documentation fix that I forgot to commit yesterday. (#459340,
2007-08-15  Cody Russell  <bratsche@gnome.org>

        * gtk/gtkcontainer.c: Another documentation fix that I forgot to
        commit yesterday.  (#459340, Guillaume Cottenceau)


svn path=/trunk/; revision=18619
2007-08-15 14:49:56 +00:00
Cody Russell
46bbf4ebd8 gtk/gtkwidget.c gtk/gtkscrolledwindow.c Correct documentation that refers
2007-08-14  Cody Russell  <bratsche@gnome.org>

        * gtk/gtkwidget.c
        * gtk/gtkscrolledwindow.c
        * gtk/gtklabel.c: Correct documentation that refers to the
        deprecated gtk_widget_set_usize() API.  Refer instead to
        gtk_widget_set_size_request().  (#459340, Guillaume Cottenceau)


svn path=/trunk/; revision=18613
2007-08-14 22:44:11 +00:00
Kristian Rietveld
bd7b15f347 make sure we fail keynav if the only item in the list is already selected.
2007-08-14  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktreeview.c (gtk_tree_view_move_cursor_up_down): make
	sure we fail keynav if the only item in the list is already selected.
	(Fixes #465039, reported by Fernando Herrera).


svn path=/trunk/; revision=18610
2007-08-14 08:11:26 +00:00
Stefan Kost
07a789f58a Move documentation of gtk_ruler_set_range() to source and fix nonsense.
* docs/reference/gtk/tmpl/gtkruler.sgml:
	* gtk/gtkruler.c:
	Move documentation of gtk_ruler_set_range() to source and fix nonsense.


svn path=/trunk/; revision=18599
2007-08-09 12:58:25 +00:00
Mikael Hallendal
9e9767401d Document the new signals popup, popdown and move-active.
2007-08-08  Mikael Hallendal  <micke@imendio.com>

	* gtk/gtkcombobox.c (gtk_combo_box_class_init):
	Document the new signals popup, popdown and move-active.

svn path=/trunk/; revision=18594
2007-08-08 19:59:42 +00:00
Johan Dahlin
12e1855bba Do not assume that text is null-terminated as pointed out by Christopher
2007-08-07  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkbuilderparser.c (text): 
    * gtk/gtkcelllayout.c (attributes_text_element): 
    * gtk/gtkliststore.c (list_store_text): 
    Do not assume that text is null-terminated as pointed out by
    Christopher Fergeau


svn path=/trunk/; revision=18592
2007-08-07 21:52:29 +00:00
Johan Dahlin
f09b3248af Use g_strdup on the translated string instead of g_strndup() + the length
2007-08-07  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkbuilderparser.c (text): Use g_strdup on the translated
    string instead of g_strndup() + the length of the untranslated
    string. (#461945, Claude Paroz)


svn path=/trunk/; revision=18588
2007-08-07 21:04:23 +00:00
Kristian Rietveld
ce1d7e3a4a create a dummy tip_window and tip_label, so old applications with code
2007-08-07  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktooltips.c (gtk_tooltips_init),
	(gtk_tooltips_destroy), (gtk_tooltips_force_window): create a dummy
	tip_window and tip_label, so old applications with code accessing
	those fields won't crash.


svn path=/trunk/; revision=18587
2007-08-07 13:32:19 +00:00
Kristian Rietveld
02eda450ea Disable tooltips in touchscreen mode.
2007-08-07  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktooltip.c (_gtk_tooltip_handle_event): Disable tooltips
	in touchscreen mode.


svn path=/trunk/; revision=18586
2007-08-07 11:28:01 +00:00
Xan Lopez
f581dcca39 reset the completion prefix on Enter too, plug potential leak. Follow-up
2007-07-31  Xan Lopez  <xan@gnome.org>

	* gtk/gtkentry.c (gtk_entry_completion_key_press): reset the
	completion prefix on Enter too, plug potential leak.
	Follow-up to #458298

svn path=/trunk/; revision=18559
2007-07-31 19:17:25 +00:00
Matthias Clasen
b11262594c Make the label wrap, for compatibility with the old tooltips code. This
2007-07-31  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktooltip.c (gtk_tooltip_init): Make the label
        wrap, for compatibility with the old tooltips code. This
        fixes absurdly long tooltips in the color selector.



svn path=/trunk/; revision=18558
2007-07-31 17:38:27 +00:00
Kristian Rietveld
bed2f0e38c Fix documentation. (#461225, Murray Cumming).
2007-07-30  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktreeview.c (gtk_tree_view_set_tooltip_cell): Fix
	documentation. (#461225, Murray Cumming).


svn path=/trunk/; revision=18557
2007-07-30 10:57:25 +00:00
Emmanuele Bassi
d3625daed1 Add documentation for properties and fix the deprecation marker for the
2007-07-29  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentchooser.c: Add documentation for properties
	and fix the deprecation marker for the show-numbers
	accessor functions (Murray Cumming).

	* gtk/gtkrecentchooser.h: Add deprecation guards around
	gtk_recent_chooser_set_show_numbers() and
	gtk_recent_chooser_get_show_numbers(), as promised during
	last development cycle.

svn path=/trunk/; revision=18556
2007-07-30 09:38:05 +00:00
Michael Natterer
3c9a4ac633 Fix check/radio indicator drawing mess (bug #452225):
2007-07-27  Michael Natterer  <mitch@imendio.com>

	Fix check/radio indicator drawing mess (bug #452225):

	* gtk/gtkstyle.c (gtk_default_draw_check): really decrease the
	indicator size by one to ensure odd size (don't say -= -1).

	* gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
	removed -1 adjustment from calls to gtk_paint_option(). Theme
	engines now get the actually configured size passed, not one pixel
	less.

	* gtk/gtkcellrenderertoggle.c
	* gtk/gtkcheckmenuitem.c: changed default indicator size from 12
	to 13 so all widgets which draw check/option indicators have the
	same default size now (and render the same size after above
	changes).

	* README.in: mention above changes in the release notes.


svn path=/trunk/; revision=18547
2007-07-27 12:11:07 +00:00
Matthias Clasen
ef8bdfb703 Call gtk_tooltip_hide_tooltip() even if the tooltip is not visible yet.
2007-07-25  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktooltip.c (_gtk_tooltip_handle_event): Call
        gtk_tooltip_hide_tooltip() even if the tooltip is not
        visible yet. This fixes annoying dangling tooltips
        on systray icons.


svn path=/trunk/; revision=18544
2007-07-25 17:45:22 +00:00
Alexander Larsson
ffed09f28a Mark more internal symbols for prefixing
2007-07-25  Alexander Larsson  <alexl@redhat.com>

        * xdgmimealias.h:
        * xdgmimecache.h:
        * xdgmimeparent.h:
	Mark more internal symbols for prefixing


svn path=/trunk/; revision=18543
2007-07-25 16:19:36 +00:00
Matthias Clasen
4fba6e4f5b Silence the validator
svn path=/trunk/; revision=18541
2007-07-25 02:07:44 +00:00
Matthias Clasen
d708f2f081 Remove obsolete set-tooltip handler. (#458280, Christian Persch)
2007-07-24  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkmenutoolbutton.c: Remove obsolete set-tooltip
        handler.  (#458280, Christian Persch)



svn path=/trunk/; revision=18540
2007-07-24 15:44:04 +00:00
Matthias Clasen
57c44b18e7 Port to use new tooltips API. (#451397, Jan Arne Petersen)
2007-07-24  Matthias Clasen  <mclasen@redhat.com>

        * gtkcolorsel.c:
        * gtkfilechooserdefault.c:
        * gtkpagesetupunixdialog.c:
        * gtkprintunixdialog.c: Port to use new tooltips API.
        (#451397, Jan Arne Petersen)


svn path=/trunk/; revision=18539
2007-07-24 15:18:42 +00:00
Matthias Clasen
55c23d2b22 Restructure the code to make sense, and don't leak an empty accel.
2007-07-24  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkmenubar.c (window_key_press_handler):
        * gtk/gtkmenu.c (gtk_menu_key_press): Restructure the code
        to make sense, and don't leak an empty accel.  (#459515, Owen Taylor)



svn path=/trunk/; revision=18535
2007-07-24 04:56:47 +00:00
Matthias Clasen
17aacf414d Protect against recursion via gtk_container_remove(). (#459561, Christian
2007-07-23  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktooltip.c (gtk_tooltip_set_custom): Protect against
        recursion via gtk_container_remove().  (#459561, Christian Persch)
        (gtk_tooltip_window_hide): Simplify.



svn path=/trunk/; revision=18534
2007-07-24 03:54:16 +00:00
Matthias Clasen
dfe7852586 Fix some doc formatting errors
svn path=/trunk/; revision=18530
2007-07-23 18:33:35 +00:00
Emmanuele Bassi
cb388e4df8 Port the GtkRecentChooser default implementation widget to the new
2007-07-23  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentchooserdefault.c: Port the GtkRecentChooser default
	implementation widget to the new tooltips API, and make it look
	like the GtkFileChooser widget in recent files mode (move the
	full path from the widget to a tooltip on the row) to improve
	consistency.

	* gtk/gtkrecentchoosermenu.c: Port the GtkRecentChooserMenu widget
	to the new tooltips API.

	* tests/testrecentchooser.c:
	* tests/testrecentchoosermenu.c: Exercise the tooltips code paths.

svn path=/trunk/; revision=18526
2007-07-23 16:44:07 +00:00
Ross Burton
7ea3c88056 Correctly redraw when gtk-scrolled-window-placement is changed after the
2007-07-22  Ross Burton  <ross@openedhand.com>

	* gtk/gtkscrolledwindow.c:
	Correctly redraw when gtk-scrolled-window-placement is changed
	after the widget is realised (#458102)

svn path=/trunk/; revision=18523
2007-07-22 19:16:41 +00:00
Matthias Clasen
060fcd5b63 Rename the tips_data_list field back. (#447214)
2007-07-21  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktooltips.[hc]: Rename the tips_data_list field
        back.  (#447214)



svn path=/trunk/; revision=18520
2007-07-21 13:19:11 +00:00
Matthias Clasen
22f1a7f918 Add forgotten release markers
svn path=/trunk/; revision=18519
2007-07-21 13:12:48 +00:00
Matthias Clasen
c8c42229f1 Don't pop up under the cursor.
2007-07-20  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktooltip.c (gtk_tooltip_position): Don't pop up
        under the cursor.



svn path=/trunk/; revision=18512
2007-07-20 12:13:24 +00:00
Matthias Clasen
13e87f72c9 Don't leak a label. (#455901, Christian Persch, Vincent Geddes)
2007-07-20  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkpathbar.c (make_directory_button): Don't leak
        a label.  (#455901, Christian Persch, Vincent Geddes)



svn path=/trunk/; revision=18511
2007-07-20 11:10:07 +00:00
Matthias Clasen
13277b42e2 Apply a patch by Emmanuele Bassi to limit the number of shown recent
2007-07-20  Matthias Clasen  <mclasen@redhat.com>

        Apply a patch by Emmanuele Bassi to limit the number
        of shown recent files.  (#439715)

        * gtk/gtksettings.c: Add a setting for the number
        of recent files to display by default.

        * gtk/gtkrecentchooserdefault.c:
        * gtk/gtkfilechooserdefault.c: Respect the limit.

        * gtk/gtkrecentmanager.c: Remove the poll timeout in
        dispose, and do not stat more often than every 5 seconds.

        * gtk/gtkrecentchooserutils.c:
        * gtk/gtkrecentchoosermenu.c: Cleanups

        * tests/testrecentchoosermenu.c: Test limits.


svn path=/trunk/; revision=18510
2007-07-20 10:39:03 +00:00