Benjamin Otte
ed45a3c2f0
cssstyleproperty: Add _gtk_css_style_property_is_animated()
2012-04-17 08:59:17 +02:00
Benjamin Otte
9e4341f730
css: Move enum to the only source file using it
2012-04-17 08:59:17 +02:00
Benjamin Otte
e597f4d6a9
cssvalue: Add transition support for images
2012-04-17 08:59:16 +02:00
Benjamin Otte
d853a8f2f7
cssimage: Add GtkCssImageCrossFade
...
Supports the cross-fade() css notation the way the old CSS3 specs did.
The main reason for adding it is supporting image transitions though.
2012-04-17 08:59:16 +02:00
Benjamin Otte
8ad8a4febf
cssvalue: Add _gtk_css_value_to_string()
...
This is a tiny wrapper around _gtk_css_value_print().
It's intended for usage in gdb and printf debugging.
2012-04-17 08:59:16 +02:00
Benjamin Otte
41ce29767c
cssstyleproperty: Add transition properties
2012-04-17 08:59:16 +02:00
Benjamin Otte
7511109103
cssvalue: Add GtkCssEaseValue
...
This is supposed to hold the transition-easing-function and
animation-easing-function values.
2012-04-17 08:59:16 +02:00
Benjamin Otte
2ff47ed26d
cssvalue: Add a GtkCssValue for idents
2012-04-17 08:59:16 +02:00
Benjamin Otte
662d6787f3
css: Add <time> type to css number stuff
2012-04-17 08:59:16 +02:00
Benjamin Otte
68b7d3e410
computedvalues: Fix signage error
2012-04-17 08:59:16 +02:00
Benjamin Otte
a360e77a7b
css: Remove _gtk_css_computed_values_get_value_by_name()
...
Now that we use an enum for the IDs, we don't need that function
anymore.
2012-04-17 08:59:16 +02:00
Benjamin Otte
31565139ba
stylecontext: Convert _gtk_style_context_peek_property()
...
Take the property id instead of the name.
2012-04-17 08:59:15 +02:00
Benjamin Otte
5d8789680e
css: Add an enum for all the style properties
...
So instead of using
_gtk_css_style_property_get_id (GTK_CSS_STYLE_PROPERTY
(_gtk_style_property_lookup ("name")))
one can now use
GTK_CSS_PROPERTY_NAME
Esaier, eh?
2012-04-17 08:59:15 +02:00
Benjamin Otte
1a9dfab825
cssvalue: Add _gtk_css_value_transition()
...
Returns a value that transitions between start and end or %NULL if the
values cannot be transitioned.
So far, all implementations but numbers and rgba return NULL.
2012-04-17 08:59:15 +02:00
Benjamin Otte
bf92f2f7ac
cssvalue: Do a hacky conversion of font-size to a number value
...
Just store the value as px for now.
The font-size property needs a complete makeover anyway.
2012-04-17 08:59:15 +02:00
Benjamin Otte
ad05604b3e
cssvalue: Convert 'font-family'
...
It's now a CssArrayValue filled with CssStringValue
2012-04-17 08:59:15 +02:00
Benjamin Otte
7c75611bc2
cssvalue: Add a custom value for strings
2012-04-17 08:59:15 +02:00
Benjamin Otte
0cce3520d3
cssprovider: Store widget style value as string
...
There's no need to turn it into a GtkCssValue, it's always a string.
2012-04-17 08:59:15 +02:00
Benjamin Otte
4ba9be5b97
cssvalue: Add GtkCssArea to the enum values
...
... and get rid of its GType.
This makes it non-queryable using gtk_style_context_get() but it used to
be a private struct anyway.
2012-04-17 08:59:15 +02:00
Benjamin Otte
8e17f9c233
switch: Set ACTIVE state flag with is_active property
2012-04-17 08:59:15 +02:00
Benjamin Otte
40982eabbb
stylecontext: Keep the main style data around until revalidation
2012-04-17 08:59:15 +02:00
Benjamin Otte
751187aa0c
stylecontext: Keep per-styleinfo data
...
Instead of having one global data structure, keep it per style info.
This means that we can do special tricks on the "global" style data.
2012-04-17 08:59:14 +02:00
Benjamin Otte
a737adadf8
stylecontext: Make style_data_lookup() not take a state anymore
...
Instead, use the current state of the style context.
2012-04-17 08:59:14 +02:00
Benjamin Otte
8c49cd97a7
cssvalue: Add a cssvalue for images
2012-04-17 08:59:14 +02:00
Benjamin Otte
d63b11e56b
cssvalue: Add enum values for the pango enums
...
And fix the parser to conform to the CSS spec while at it.
2012-04-17 08:59:14 +02:00
Benjamin Otte
b65d17dda8
cssvalue: Make border styles be their own value
...
... and add them via gtkcssenumvalue.[ch] which will be used for all
enums.
2012-04-17 08:59:14 +02:00
Benjamin Otte
58b6d492b8
cssvalue: Add a custom RGBA value
...
Note: custom CSS properties still use the default GtkCssValue and always
will.
So there is a difference in css values used between those, even though
they both carry a GdkRGBA payload.
2012-04-17 08:59:14 +02:00
Benjamin Otte
dcec7a5529
cssstyleproperty: Make assign_value a vfunc
2012-04-17 08:59:14 +02:00
Benjamin Otte
81dfc2776e
customproperty: Implement assign vfunc
...
I'm going to overwrite the GtkCssStyleProperty one, so better keep this
one.
2012-04-17 08:59:14 +02:00
Benjamin Otte
645309e98b
shadow: Also rename files
2012-04-17 08:59:14 +02:00
Benjamin Otte
ec5c77a552
shadow: Rename to GtkCssShadowValue
...
I don't want to confuse css values with other stuff, so there.
2012-04-17 08:59:13 +02:00
Benjamin Otte
da40ba431d
cssvalue: Remove unused function
2012-04-17 08:59:13 +02:00
Benjamin Otte
96948576bd
shadow: Move parse function into GtkShadow
...
This way, we have less public API.
And gtkcssstylepropertyimpl.c looks less scary (only 1624 lines now).
2012-04-17 08:59:13 +02:00
Benjamin Otte
ccd443796c
shadow: Make this a GtkCssValue
2012-04-17 08:59:13 +02:00
Benjamin Otte
38ac68790e
shadow: Remove _gtk_shadow_get_resolved()
...
It's unused
2012-04-17 08:59:13 +02:00
Benjamin Otte
ca4a080c8a
stylepropertyimpl: Make shadows unqueryable
...
Normal APIs couldn't use GtkShadow anyway as the type was private.
2012-04-17 08:59:13 +02:00
Benjamin Otte
281d094b42
theming: Use peek_property() calls to query shadows
2012-04-17 08:59:13 +02:00
Benjamin Otte
a33df2d1d6
cssvalue: Split number values into their own class
2012-04-17 08:59:13 +02:00
Benjamin Otte
f7c0c7677b
cssstyleproperty: Make query func a vfunc
...
This will be needed soon.
2012-04-17 08:59:13 +02:00
Benjamin Otte
6ef76f4a92
customproperty: Add our own query_value function
...
I'm about to change the CssStyleProperty one, so better copy things
here.
2012-04-17 08:59:13 +02:00
Benjamin Otte
c8e57d63ec
cssstyelproperty: Rempove specified-type and computed-type props
...
This removes the necessity to keep a GType associated with style
properties and code can now make use of GtkCssValue completely.
2012-04-17 08:59:13 +02:00
Benjamin Otte
75a5f04352
styleproperty: Remove default parse function
...
... and assert every style property brings its own.
2012-04-17 08:59:13 +02:00
Benjamin Otte
a5d001b2ba
stylepropertyimpl: Add remaining parse functions
2012-04-17 08:59:12 +02:00
Benjamin Otte
0fdc287339
styleproperty: Simplify compute_value function
...
The compute_value fallback path is only needed for custom properties,
the real style properties have custom compute functions if they need
them already.
2012-04-17 08:59:12 +02:00
Benjamin Otte
7fbc583b88
css: Move shadow parse/print/compute funcs
...
They don't belong in the style funcs, as those are for custom
properties, and the shadow type is private.
2012-04-17 08:59:12 +02:00
Benjamin Otte
dd144c2bad
stylepropertyimpl: Add parse funcs for enums
2012-04-17 08:59:12 +02:00
Benjamin Otte
86a387f571
stylepropertyimpl: Add color parsing function
...
This is in preparation for removing the specified type and computed type
properties from GtkCssStyleProperty, which is in preparation for really
using GtkCssValue classes and not GTypes.
2012-04-17 08:59:12 +02:00
Benjamin Otte
b5fc484c99
customproperty: Don't rely on querying style property
...
This way, we can remove type madness from GtkCssStyleProperty later.
2012-04-17 08:59:12 +02:00
Benjamin Otte
bc9060a591
styleproperty: Make gtk_style_property_register() not be valist
...
Instead, make the caller create a GtkCssValue in advance.
2012-04-17 08:59:12 +02:00
Benjamin Otte
ffe50c3b67
cssvalue: Add _gtk_css_value_equal()
...
For now, we return FALSE for all default css values, so this is not very
useful.
I also think of this as an optimization equal, not a guaranteed equal,
because we don't even have a notion of what "equal" means.
For example, for background-repeat, "repeat, repeat" and "repeat"
are functionally equivalent. But the cssvalue has no idea that it's used
for background-repeat.
As a more complicated example, "repeat, no-repeat" and "repeat" are
equal to what one sees as long as there's only one image listed
background-image-source. But once you start transition'ing to an image
with 2 sources, it's different...
2012-04-17 08:59:12 +02:00
Benjamin Otte
b0e764000f
cssparser: Use _gtk_css_parser_error_full()
2012-04-17 08:59:12 +02:00
Benjamin Otte
e7acdec220
cssparser: Add _gtk_css_parser_error_full()
2012-04-17 08:59:11 +02:00
Benjamin Otte
9b7640b898
styleproperty: Make _gtk_style_property_parse_value() return a CssValue
...
Also split out initial/inherit handling into a custom GtkCssValue class.
2012-04-17 08:59:11 +02:00
Benjamin Otte
718ceaec45
css: Remove _gtk_css_style_property_is_specified_type()
...
That check is going to be refactored away.
2012-04-17 08:59:11 +02:00
Benjamin Otte
04f5c8708a
cssvalue: Add a CSS value for arrays
...
Make the value auto-cycle its child values, so it can be used for
background properties.
2012-04-17 08:59:11 +02:00
Benjamin Otte
df45983fcb
cssvalue: Remove _gtk_css_value_new_take_gvalue()
...
Having two constructors from GValues complicates refactorings, so I'd
rather not have them.
2012-04-17 08:59:11 +02:00
Benjamin Otte
8e3e3d582f
cssvalue: Get rid of unused functions
2012-04-17 08:59:11 +02:00
Benjamin Otte
5ac9ba714a
styleproperty: Make _gtk_style_property_query() take a GValue
...
... and don't make it return a GtkCssValue. We want to use this for
compat with the old GValue APIs after all...
2012-04-17 08:59:11 +02:00
Benjamin Otte
58e4fdf911
styleproperty: Make print_func take a GtkCssValue
...
Also, constify GtkCssValue getters, so we can pass a const GtkCssValue
to the print_func.
2012-04-17 08:59:11 +02:00
Benjamin Otte
b728cfd3e8
cssvalue: Make the structure vtable-based
...
Don't use real classes, just a vtable.
2012-04-17 08:59:11 +02:00
Benjamin Otte
3cdb9c91ca
styleproperty: Add support for equal_func
2012-04-17 08:59:11 +02:00
Benjamin Otte
d5a2392cc7
stylecontext: Don't clear cache when only state changes
...
This takes more memory, but changes to backdrop or active state are
quite expensive otherwise.
2012-04-17 08:59:11 +02:00
Benjamin Otte
44187ca3b5
cssmatcher: Use quarks for classes
2012-04-17 08:59:10 +02:00
Benjamin Otte
115c34498e
styleproperty: Add a function to compare values for equality
...
and default to never compare them as equal.
2012-04-17 08:59:10 +02:00
Benjamin Otte
5bbf59b519
cssvalue: Constify a bunch of APIs
2012-04-17 08:59:10 +02:00
Benjamin Otte
4a12717e4d
cssvalue: Remove unused functions
2012-04-17 08:59:10 +02:00
Benjamin Otte
585a1fae4f
stylecontext: Really queue style changes
...
Instead of instantly applying a new style, just mark the context as
invalid. Only apply the new style at layout time.
2012-04-17 08:59:10 +02:00
Benjamin Otte
eb537b60f4
stylecontext: Optimize the common case of "style didn't change"
2012-04-17 08:59:10 +02:00
Benjamin Otte
ece9d2fd92
gtk: Make widget only invalidate widget positions
...
Instead of resetting them completely
2012-04-17 08:59:10 +02:00
Benjamin Otte
e7a984b337
window: Set parent context instead of just resetting style
...
Otherwise the inherit properties won't inherit properly.
2012-04-17 08:59:10 +02:00
Benjamin Otte
27c9352df3
widget: Replace reset_style() calls
...
... with finer grained _gtk_widget_invalidate_style_context() calls.
2012-04-17 08:59:10 +02:00
Benjamin Otte
969daec353
widget: Don't go via path when resetting style
...
Instead, invalidate the path when the style context changes. And
invalidate the style context directly.
2012-04-17 08:59:09 +02:00
Benjamin Otte
d589566f40
widget: Add _gtk_widget_invalidate_style_context()
...
This is supposed to replace gtk_widget_reset_style().
2012-04-17 08:59:09 +02:00
Benjamin Otte
48a8ca8bbe
widget: Merge function into only caller
2012-04-17 08:59:09 +02:00
Benjamin Otte
257d961a01
widget: Clear broken widget path in constructor
...
... where it belongs instead of fiddling with it in get_path().
2012-04-17 08:59:09 +02:00
Benjamin Otte
198cf93f0f
stylecontext: On failure, exit the loop, don't try again
...
Because we will fail again. And then we try again. And then we fail
again. Ad infinitum.
2012-04-17 08:59:09 +02:00
Benjamin Otte
15be680540
stylecontext: Invalidate when setting classes/state/regions
...
... and nobody has called style_context_save().
2012-04-17 08:59:09 +02:00
Benjamin Otte
44d49c900d
stylecontext: Use _gtk_style_context_queue_invalidate() on self
2012-04-17 08:59:09 +02:00
Benjamin Otte
39ff874a11
stylecontext: Introduce _gtk_style_context_queue_invalidate()
...
This is for only queueing invalidations instead of doing a full
invalidation cycle.
2012-04-17 08:59:09 +02:00
Benjamin Otte
1a51ea3ea3
stylecontext: Keep track of children
2012-04-17 08:59:09 +02:00
Benjamin Otte
7f511f2b33
widget: Don't set widget path on style context
...
Instead, make the style context use the widget's path. Saves a bunch of
memory.
2012-04-17 08:59:09 +02:00
Benjamin Otte
e5ab48ac59
stylecontext: Notify widget directly of changes
...
This way, we don't need to g_signal_connect(), which saves a bunch of
memory and performance.
2012-04-17 08:59:08 +02:00
Benjamin Otte
1aa4a196dc
stylecontext: Add setter for widget
...
... and actually set the widget on the style context. Note that this
function does not take a reference on the widget, which is a very good
reason to keep it private.
2012-04-17 08:59:08 +02:00
Benjamin Otte
102d10016f
matcher: Add a superset matcher
...
This matcher always matches only on some relvant things and ignores the
rest. This allows you to match only on name and class, but ignore state
and parents/siblings for example.
2012-04-17 08:59:08 +02:00
Benjamin Otte
5f5bf27287
matcher: Add a matcher that matches anything
...
Lesson learned: Adwaita uses all possible selector types and all of
those for parents, too. But so far no siblings.
2012-04-17 08:59:08 +02:00
Benjamin Otte
3bdde54aaf
selector: Rewrite position tracking
...
We now track the position as a (type,a,b) tuple where the numbers make
up the an + b formula from CSS3 nth-child.
Also, the get_sibling() and get_sibling_index() vfuncs were replaced by
a has_position() vfunc. This is mostly so that the matcher can always
return TRUE. And I need that for the everything matcher.
2012-04-17 08:59:08 +02:00
Benjamin Otte
8dbe8c8349
syleprovider: Add a vfunc to get the changes
...
This way we can check what changes are even interesting for our matcher.
2012-04-17 08:59:08 +02:00
Benjamin Otte
b0b6c8ad4b
selector: Rename selector class
...
It's a 'position' pseudoclass, not a 'region' pseudoclass.
2012-04-17 08:59:08 +02:00
Benjamin Otte
2d01f7786d
css: Add selector change types
...
This allows querying selectors for which changes would change their
"matchingness".
2012-04-17 08:59:07 +02:00
Benjamin Otte
53317aed55
matcher: Turn GtkCssMatcher into a union
...
That way, we can add more matchers as we need them.
2012-04-17 08:59:07 +02:00
Benjamin Otte
b368c5f10a
matcher: Use a vtable
...
Now we can do lots of fancy matchers, yay!
2012-04-17 08:59:07 +02:00
Benjamin Otte
a94b85d375
css: Make the style provider take a matcher as an input argument
2012-04-17 08:59:07 +02:00
Benjamin Otte
c0b7c3321d
css: Add GtkCssMatcher
...
This is so we can later do matching with other things than
GtkWidgetPath.
In particular, this is a requirement for getting rid of GtkWidgetPath.
2012-04-17 08:59:07 +02:00
Benjamin Otte
a2ded8b72a
styleprovider: Add a custom object for a list of style providers
...
This way, we don't have to do magic inside GtkStyleContext, but have a
real API.
As a cute bonus, this object implements GtkStyleProvider itself. So we
can just pretend there's only one provider.
2012-04-17 08:59:07 +02:00
Benjamin Otte
015e3a768f
stylecontext: Stop querying style providers for icon factories
...
Nobody implements this feature and I don't wanna maintain it. If it
turns out somebody is using it, we gotta invent something.
2012-04-17 08:59:07 +02:00
Kalev Lember
234c7fcf28
application-window: Move desktop file handling code to separate function
...
https://bugzilla.gnome.org/show_bug.cgi?id=674118
2012-04-16 18:33:50 +03:00
Michael Vogt
19e55d620f
GtkImage: Move g_clear_object() to gtk_image_finalize()
...
This moves the freeing of the icon_helper from the destory to the finalize
function to avoid segfaults when trying to access a destroyed object before it
is disposed. This often happens in signal handlers which get called
asynchronously after destroy.
https://bugzilla.gnome.org/show_bug.cgi?id=674050
2012-04-16 06:51:43 +02:00
Cosimo Cecchi
398ba38cfe
application-window: try to use the desktop name in the fallback menu
...
Try to fetch the name from the application desktop file for the
fallback menu if possible, instead of forcing applications to use
g_set_application_name or hardcoding "Application".
https://bugzilla.gnome.org/show_bug.cgi?id=673882
2012-04-12 21:41:46 -04:00
Matthias Clasen
050cba6a31
Fix malformed doc comments
...
Most of these are forgotten :'s and similar details
which gtk-doc now warns about.
2012-04-12 21:12:16 -04:00
Benjamin Otte
555cf516fd
styleproperty: 3rd hotfix for a 3-line patch
...
I really should not write code sometimes...
Copy/paste error this time.
2012-04-10 16:55:05 +02:00
Benjamin Otte
3610ef90c3
Revert part of "textview: Remove extra magic for drawing children"
...
This partially reverts commit df37446f9b
.
The commit changed API that was public (or at least semi-public) and
it's not worth changing that.
The original bug should still be fixed.
https://bugzilla.gnome.org/show_bug.cgi?id=673839
2012-04-10 16:21:07 +02:00
Benjamin Otte
8b5910f8d7
styleproperty: Fix thinko
...
Introduced in 8243b16ad7
- seems I wasn't
really on top of my own capabilities on Saturday.
2012-04-09 20:33:46 +02:00
Benjamin Otte
9573ed467d
customproperty: Fix thinko
...
.. in 43c56d70ea
2012-04-09 03:27:55 +02:00
Benjamin Otte
8243b16ad7
styleproperty: Save some memory
...
Only create a new CssValue when we actually need one.
2012-04-09 03:14:51 +02:00
Benjamin Otte
fde43d01e5
customproperty: Ensure style properties are registered
...
... before reigstering our own. Also, use that capability to emit a
warning.
2012-04-09 03:11:20 +02:00
Benjamin Otte
43c56d70ea
csscustomproperty: Redo RGBA/Color parsing
...
This fixes custom parse functions returning RGBA values where we
expected symbolic colors.
2012-04-09 03:09:44 +02:00
Benjamin Otte
b7ad432654
cssvalue: Re-add support for random value types
...
This got lost in the CssValue transition, and apparently some people use
this.
2012-04-09 03:09:44 +02:00
Pavel Holejsovsky
331bba1ad6
entrycompletion: set_property() should call property setters
...
gtk_entry_completion_set_property() was setting many properties by
directly modifying priv values, bypassing notification invocation and
possibly another actions done by gtk_completion_entry_set_xxx ()
functions. Fix by invoking set_xxx() instead of setting the property
value directly.
The real bug observerd was that setting text-column property using
g_object_set() caused SIGFPE later when entry completion was about to
appear. gtk_entry_completion_set_text_column () apparently does way
more important things than just setting priv->text_column member.
https://bugzilla.gnome.org/show_bug.cgi?id=673693
2012-04-08 12:10:44 +02:00
Benjamin Otte
df37446f9b
textview: Remove extra magic for drawing children
...
Instead, just draw the children. The cairo code will keep track of
things, so there's no need to track things.
Also, the old code was doing it wrong.
https://bugzilla.gnome.org/show_bug.cgi?id=672544
2012-04-07 13:01:25 +02:00
Benjamin Otte
7a7e2ed92b
csscomputedvalues: Unref old value when setting new one
2012-04-07 13:01:25 +02:00
Benjamin Otte
605a472c99
treeview: Don't cache expander size
...
Style properties should not be cached, they should be queried live.
Also, this fixes the case where the expander size wasn't set when
constructing the widget which caused expanders to go missing.
2012-04-07 13:01:25 +02:00
Benjamin Otte
1ca8098543
widget: Create style context using regular API
2012-04-07 13:01:25 +02:00
Benjamin Otte
7204724c9f
menu: Undo a hack with style contexts
...
Widget implementations aren't allowed to fiddle with the widget's style
context.
Sheesh.
2012-04-07 13:01:25 +02:00
Benjamin Otte
b5714ea265
tray: Add suggested braces around empty body in 'if' statements
2012-04-07 13:01:24 +02:00
Benjamin Otte
bd400b0957
win32: Move variable declarations into #if block
2012-04-07 13:01:24 +02:00
Benjamin Otte
917ca6a802
gtk: Don't call gdk_window_process_updates() when scrolling
...
This can cause lagging when scrolling as it causes us to repaint
on every scroll event. This wasn't historically a great problem,
but with smooth scrolling we get a lot more events, so this
now creates visible lagging on slower machines.
2012-04-05 15:48:51 +02:00
Benjamin Otte
12d6b0fe62
paned: Shrinkable widgets don't require a size
...
This could otherwise lead to very funny size request behaviors, in
particular in empathy.
https://bugzilla.gnome.org/show_bug.cgi?id=587441
2012-04-05 11:30:41 +02:00
Nelson Benitez Leon
45a5151f94
gtktreeview: don't handle extra mouse buttons
...
Don't handle mouse button events greater than 5 so
they can bubble up to be used by the application.
This was causing nautilus list view to not go forward
and backwards when pressing the extra mouse buttons
designated for that.
Fixes bug 673441
Signed-off-by: Nelson Benitez Leon <nbenitezl@gmail.com>
2012-04-04 16:26:57 +02:00
Alexander Larsson
a4cde82365
win32: Fall back to raleigh with the classic theme
...
This is not ideal, we should have a real classic windows theme,
but at least its better than everything being pink, which is what
happens otherwise when theming is not enables.
2012-04-03 19:26:15 +02:00
Jasper St. Pierre
356c3a3b29
gactionmuxer: Fix list_actions
...
The code there before was just completely wrong
https://bugzilla.gnome.org/show_bug.cgi?id=673200
2012-03-30 15:21:06 -04:00
Matthias Clasen
d51840ccf3
filechooser: Fix entry completion
...
Inserting the selected completion did not actually work. Oops.
https://bugzilla.gnome.org/show_bug.cgi?id=673090
2012-03-29 18:59:07 -04:00
Alexander Larsson
0b26605ab0
css: Only keep around GtkCssSections if GTK_CSS_DEBUG env var set
...
These are used purely for CSS debugging, and was using over 100k just
starting up gtk3-demo.
2012-03-29 13:57:22 +02:00
Rob Bradford
13b2720308
build: Don't use Wayland GtkClipboard implementation if also building for X
...
Workaround for: https://bugzilla.gnome.org/show_bug.cgi?id=672358
2012-03-29 10:50:07 +01:00
Murray Cumming
c00cfda370
GtkApplication Docs: Add a hint.
...
gtk_application_set_app_menu(), gtk_application_set_menubar():
Mention that you probably want to call this in the startup signal
handler. If you do it earlier you will likely get a warning about
a missing D-Bus connection, because doing it earlier does not
make sense anyway.
2012-03-28 11:26:22 +02:00
Benjamin Otte
94dbefda1c
Fix for bug 672961 - Custom theme can crash apps with GtkEntryCompletion
2012-03-27 20:29:56 -04:00
Cosimo Cecchi
52bd5f2f1f
treeview: filter out invisible columns in get_path_for_child()
...
Since we check for !list->next (and !list->prev for RTL) to set the
GTK_REGION_LAST flag, we have to filter out invisible columns before
looping; if we don't do that we might end up assigning GTK_REGION_LAST
to an invisible column.
https://bugzilla.gnome.org/show_bug.cgi?id=672937
2012-03-27 12:39:20 -04:00
Matthias Clasen
8759575c0a
Revert "GtkMenuItem: Add since 3.2 tags for 2 signals."
...
This reverts commit c6e1024a86
.
2012-03-26 06:15:26 -04:00
Murray Cumming
c6e1024a86
GtkMenuItem: Add since 3.2 tags for 2 signals.
...
These signals were added in this commit in 2010-09:
http://git.gnome.org/browse/gtk+/commit/gtk/gtkmenuitem.c?id=3bd93e5bfd968d21cbcba15b952b254c41f204f9
2012-03-26 10:51:46 +02:00
Murray Cumming
0e171a28c9
GtkColorChooser docs: Fix small typos.
2012-03-26 10:51:46 +02:00
Murray Cumming
79758e3d98
Docs: GtkApplication: Hint about GtkActionMap
2012-03-26 10:51:46 +02:00
Matthias Clasen
ed17c74f58
grid: avoid a floating point exception
...
When a homogeneous grid has no visible children, we were
accidentally doing a division by zero. Instead, just bail
out early in this case, there is nothing to allocate anyway.
https://bugzilla.gnome.org/show_bug.cgi?id=672763
2012-03-24 17:19:46 -04:00
Jon McCann
482195d788
Ensure skipped row between sections has a nonzero height
...
https://bugzilla.gnome.org/show_bug.cgi?id=672587
2012-03-22 13:07:35 -04:00
Jon McCann
50a4fa5323
Reduce row spacing in about dialog credits
...
https://bugzilla.gnome.org/show_bug.cgi?id=672587
2012-03-22 13:07:35 -04:00
Cosimo Cecchi
295ed0033e
cellrendereraccel: don't translate Alt+Print to SysRq
...
We want to use Alt+Print for screenshot keybindings, so we have to avoid
translating it into SysRq, since that's what the keymap would dictate.
After talking with Owen, it sounds like doing this generically would be
a lot of work and quite hairy code, so hardcoding this should be OK.
https://bugzilla.gnome.org/show_bug.cgi?id=671006
2012-03-22 00:45:08 -04:00
Matthias Clasen
d718fd79b6
entry: Don't show a num lock warning
...
Hardware lies about num lock, and we have no way of knowing.
https://bugzilla.gnome.org/show_bug.cgi?id=658875
2012-03-22 00:16:12 -04:00
Chun-wei Fan
f32d8be6a5
gtk/gtkwin32theme.c: Remove C99ism
2012-03-21 23:28:43 +08:00
Alexander Larsson
ca9d826249
win32: Remove grippies on paned
...
Turns out win32 doesn't actually have these.
2012-03-20 12:58:21 +01:00
Alexander Larsson
51e0d80ad8
win32: Theme paned separator
2012-03-20 11:36:35 +01:00
Alexander Larsson
d43632fbdc
win32: More theme workaround on XP
2012-03-20 11:36:03 +01:00
Alexander Larsson
6e35ae8515
GtkPaned: Update orientation style classes
2012-03-20 11:35:39 +01:00
Matthias Clasen
ad1c0f7155
label: Don't use the selection too easily
...
When we are re-setting the same text for internal reasons
(e.g. when applying the mnemonics-visible change upon Alt press),
we should not needlessly loos the selection.
https://bugzilla.gnome.org/show_bug.cgi?id=671588
2012-03-20 01:05:05 -04:00
Benjamin Otte
c80436ac35
tests: Remove unused variables
2012-03-20 02:07:21 +01:00
Matthias Clasen
aba316207d
Undo the gtk_menu_popup_for_device rename-to annotation
2012-03-19 13:45:48 -04:00
Adrian Johnson
7a8e37edec
Make collate default to enabled
...
Fixes http://bugzilla.gnome.org/show_bug.cgi?id=671898
2012-03-19 13:00:33 +00:00
Matthias Clasen
d7cf9d7b84
combobox: Make scrolling work again
...
Select for scroll events, making it possible to use a scroll
wheel to change the combobox.
2012-03-19 07:08:01 -04:00
Matthias Clasen
c0431a7238
builder: Remove a questionable test
...
It doesn't really make sense to check properties of a cell renderer,
since those only get set when needed to render or size-allocate
a cell.
2012-03-18 22:56:44 -04:00
Benjamin Otte
6df7562570
tests: Remove deleted rows from cache
...
Otherwise the GNode pointer address that we use for indexing might get
reused for a new node and then we don't start out with a pristine
refcount.
2012-03-19 02:26:16 +01:00
Benjamin Otte
754bf5e3d8
treemodelfilter: Don't unref deleted rows
...
When we're fudging with child nodes of a deleted node, we don't want to
have them delete their parent - which is the deleted row.
2012-03-19 02:26:16 +01:00
Benjamin Otte
461803e407
gtk: Get gtkwidgetpath.h includes out of the public headers
...
and include them in the C files instead.
2012-03-19 02:26:16 +01:00
Benjamin Otte
47e44028e1
a11y: Add back the 'toggle' actions
...
This is a hack.
But as long as Orca cannot figure out if a cell is heckable, the best we
can do is support the old way of providing a "toggle" action.
https://bugzilla.gnome.org/show_bug.cgi?id=672367
https://bugzilla.gnome.org/show_bug.cgi?id=672368
https://bugzilla.gnome.org/show_bug.cgi?id=672369
2012-03-19 02:26:16 +01:00
Lionel Landwerlin
adf36e28d2
gtkbox: avoid warning when removing a widget with refcount of 1
...
If gtkbox is the only object having a reference on one of its child
and that we try to remove it from its container, we endup having a
warning when disconnecting a signal after having unparented the
widget.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@linux.intel.com>
https://bugzilla.gnome.org/show_bug.cgi?id=670176
2012-03-18 15:41:07 -04:00
Alexander Larsson
e65a2709a3
css: Support background-position property
2012-03-17 05:13:22 +01:00
Alexander Larsson
b874e6c3cf
css: Support GtkBackgroundPosition in cssvalue
2012-03-17 05:13:22 +01:00
Alexander Larsson
ca07559672
css: GtkBackgroundSize type
2012-03-17 05:13:22 +01:00
Benjamin Otte
f9727ee1bf
stylecontext: Get rid of unused parameter
...
It was always FALSE
2012-03-16 17:53:57 +01:00
Benjamin Otte
ae6ab3951c
docs: Add missing Since tag
2012-03-16 17:53:39 +01:00
Benjamin Otte
ccbcebdddf
iconview: Don't resize on size allocation
...
Let's see how much this breaks. But then, it also fixes things, so more
power to me!
https://bugzilla.gnome.org/show_bug.cgi?id=672173
2012-03-16 17:53:30 +01:00
Alexander Larsson
cb1a825cc3
win32: Theme statusbars
2012-03-16 16:44:24 +01:00
Alexander Larsson
30fb1e0256
win32: Theme paned separators
2012-03-16 14:31:32 +01:00
Alexander Larsson
0d307ab2fc
win32: Dim menubar text for non-active windows
2012-03-16 11:35:52 +01:00
Alexander Larsson
fff1af56ff
win32: Better color for separators
2012-03-16 11:05:20 +01:00
Alexander Larsson
a6d72dfec1
win32: Don't use separators in comboboxes
2012-03-16 11:05:00 +01:00
Alexander Larsson
eedf57f844
win32: Some theming of color selector
2012-03-16 10:49:21 +01:00
Alexander Larsson
6b35857e4d
win32: Fix typo in css
2012-03-15 21:25:36 +01:00
Alexander Larsson
59dc05d0c5
win32: Theme assistants
2012-03-15 21:12:38 +01:00
Alexander Larsson
3598756bee
win32: No frames around scrolled windows directly in tabs
2012-03-15 21:12:37 +01:00
Alexander Larsson
7e97dce946
win32: Fix listview checkbox prelight problems
...
We only support the preview state for checkboxes for GtkButton
because it gave problems when used in treeview where the prelight
state affects all checkboxes in the row.
2012-03-15 21:12:37 +01:00
Alexander Larsson
84b2d41a98
win32: Make spinner animate
2012-03-15 21:12:36 +01:00
Alexander Larsson
3b8cf23fbc
win32: Add borders around scrolled windows
2012-03-15 21:12:36 +01:00
Alexander Larsson
dc1510c53d
win32: Fix entry theming
2012-03-15 21:12:35 +01:00
Alexander Larsson
1e5a803614
win32: Support frameless entries in theme
2012-03-15 21:12:35 +01:00
Alexander Larsson
e0ac492732
win32: Fix up theme for menus on XP
2012-03-15 21:12:34 +01:00
Alexander Larsson
0a439fa162
win32: Fix tabs themeing on XP
2012-03-15 21:12:34 +01:00
Alexander Larsson
dcaec2610d
win32: Add more theme workarounds on XP
2012-03-15 21:12:33 +01:00
Alexander Larsson
a20b4423f4
Remove broken approach to get stable sort of CSS rules
...
The pointer comparisons in the sort compare function just doesn't
work.
We still need a stable sort, but the plan is to add a real
one in glib.
2012-03-15 21:12:32 +01:00
Alexander Larsson
8bfa0f8feb
win32: Fix up progressbar themeing on XP
2012-03-15 21:12:32 +01:00
Alexander Larsson
8f427babbb
win32: Clean up spinbutton themeing
2012-03-15 21:12:31 +01:00
Stefano Facchini
53af7dd3c0
paned: remove old default for cursor type
2012-03-15 18:24:41 +01:00
Carlos Garcia Campos
5ebfad5d09
printing: Make sure destroy function is always called by gtk_enumerate_printers
...
When GtkPrinterFunc always returns FALSE, for example when looking for
a non existent printer, if print list is done for all backends or print
backend status is UNAVAILABLE, gtk_enumerate_printers() finishes with an
empty backend list and destroy function is never called. We need to
check the backend list again after calling list_printers_init for all
backends and finish the enumeration if it's empty.
https://bugzilla.gnome.org/show_bug.cgi?id=672125
2012-03-15 14:47:33 +01:00
Benjamin Otte
05e6cde97d
win32: Fix compiler warning
2012-03-15 02:55:25 +01:00
Bastien Nocera
dd402bd7af
gtk: Prefer group-0 keycodes
...
As we don't give out information about the group or level when
giving back keycodes, we should prioritise group-0, level-0, followed by
level-0 only, and then any keycodes.
This fixes "q" being pressed when the Wacom tablet code in
gnome-settings-daemon is supposed to generate an "a" ("uk" keymap
in group-0, "fr" in group-1).
https://bugzilla.gnome.org/show_bug.cgi?id=671065
2012-03-13 18:28:49 +01:00
Alexander Larsson
e9f070db0f
win32: Fix up toolbar rendering on XP
...
It seems XP doesn't correctly set the alpha when rendering toolbar
buttons on an alpha target, we fix this up afterwards if necessary.
2012-03-13 17:10:44 +01:00
Alexander Larsson
94f1ed3031
win32: Fixup XP version of menu radio/checks
2012-03-13 17:10:11 +01:00
Alexander Larsson
a869ca51f4
Convert to unix line endings
2012-03-13 15:52:36 +01:00
Alexander Larsson
38d56c8e20
win32: Fix up notebook theming a bit
2012-03-13 15:50:32 +01:00
Alexander Larsson
95a903d020
win32: Use a separate css file for xp
...
Only vista and later has e.g. the menu theme parts
2012-03-13 15:14:36 +01:00
Alexander Larsson
68880e9a35
win32: Bump up padding on entry and button
2012-03-13 15:14:35 +01:00
Alexander Larsson
12fdf165ee
win32: Fix up notebook themeing
2012-03-13 15:14:35 +01:00
Javier Jardón
45f660ef75
Use GDK symbolic names for button numbers
2012-03-13 13:10:30 +00:00
Matthias Clasen
de115c3fd3
Avoid infinite recursion when removing a grab
...
https://bugzilla.gnome.org/show_bug.cgi?id=671819
2012-03-12 22:01:18 -04:00
Paolo Borelli
9ff75882c0
Explicitely mention -1 in the insert_with_values docs
...
-1 means "append". Spell it out like we do for ListStore docs.
2012-03-10 19:37:07 +01:00
Cosimo Cecchi
14e63a7370
scrolledwindow: take into account border/padding for junction
...
When the scrolled window has a frame (and the scrollbar is within the
bevel), we should take into account the CSS border/padding of the frame
and offset the scrollbars junction rendering with it.
2012-03-10 11:46:26 -05:00
Alexander Larsson
10d8c0621f
win32: Fix text color on XP
...
Use a different base text color as the old one leads to
white on white on XP.
2012-03-09 16:43:00 +01:00
Alexander Larsson
f4a68dff88
Fix rendering of theme parts on Windows XP
...
It seems XP doesn't handle drawing non-alpha theme parts
on alpha destinations. We fix this by using alpha bitmaps only when
needed.
However this means any non-drawn area by the theme part is now draw
black, so we must take more care to only draw where the theme part draws,
so we find the theme part size when available.
2012-03-09 16:43:00 +01:00
Benjamin Otte
50e3f532b9
a11y: Only care about GtkOrientable::orientation
...
There are other widgets (like PanelToplevel) that aren't a GtkOrientable
but still have that property.
2012-03-09 13:23:05 +01:00
Benjamin Otte
5d57981184
widget: Set up signals after initializing style context
...
Otherwise, signals would be emitted on semi set up style context which
would then cause crashes when the signal handlers tried to use them.
https://bugzilla.gnome.org/show_bug.cgi?id=662023
2012-03-09 13:23:05 +01:00
Alexander Larsson
a253d4cfec
Merge branch 'wip/cssvalue'
2012-03-08 17:33:18 +01:00
Alexander Larsson
ec65270c2c
Add some more types to GtkCssValue
...
Seems these types were used in the parser tests, so we need to
handle them.
2012-03-08 16:49:13 +01:00
Alexander Larsson
1ceed037b2
Don't use GValue in GtkCssValue
...
We now have complete coverage in the GtkCssValue API for type
handling, so drop the GValue from internal storage and just create
new ones when needed.
2012-03-08 16:39:49 +01:00
Alexander Larsson
616cc5b96d
Use GtkCssValue in symbolic color resolving
...
We now store the symbolic colors as a GtkCssValue which means that
we can reuse the color when resolving and storing the color in
the computed values in the style context.
Additionally we keep a last_resolved GtkCssValue cache in the
GtkSymbolicColor, and if resolving the color returns the same as
last time we reuse the old value. This further increases sharing
of Css Values.
2012-03-08 14:52:10 +01:00