Commit Graph

4830 Commits

Author SHA1 Message Date
Matthias Clasen
d41ae98e9b Destroy secondary dialogs if the main dialog is hidden. (#155084, Paolo
2004-10-17  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkaboutdialog.c (gtk_about_dialog_new): Destroy secondary
	dialogs if the main dialog is hidden. (#155084, Paolo Borelli)
2004-10-17 06:38:35 +00:00
Matthias Clasen
62fa88e473 Don't leak the secondary dialogs. (#155084, Paolo Borelli)
2004-10-16  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkaboutdialog.c (gtk_about_dialog_destroy): Don't leak
	the secondary dialogs.  (#155084, Paolo Borelli)
2004-10-16 05:10:55 +00:00
Matthias Clasen
47eb4aae6d Fix redraw issues with the focus on the ring.
2004-10-16  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkhsv.c (gtk_hsv_expose): Fix redraw issues with the
	focus on the ring.
2004-10-16 04:27:08 +00:00
Matthias Clasen
63ffb56f1e Unset GTK_REQUEST_NEEDED before emitting ::size-request, following this
2004-10-15  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtksizegroup.c (do_size_request): Unset GTK_REQUEST_NEEDED
	before emitting ::size-request, following this weeks discussion
	on gtk-devel-list@gnome.org.
2004-10-15 05:25:56 +00:00
Matthias Clasen
d0cc5dee2b Restore the size info for the current row after measuring another row.
2004-10-15  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkcellview.c (gtk_cell_view_get_size_of_row): Restore
	the size info for the current row after measuring another
	row.  (#154945, William Jon McCann)
2004-10-15 04:59:03 +00:00
Matthias Clasen
98019f4880 (shortcuts_add_current_folder): Don't leak volume. (#155400,
Morten Welinder)
2004-10-14 19:42:31 +00:00
Matthias Clasen
47666976ca (gtk_file_chooser_default_finalize): Don't forget to
unref the tooltips.  (#155412, Morten Welinder)
2004-10-14 19:23:41 +00:00
Matthias Clasen
817f3b94a8 Don't get text unnecessarily. (#155384, Morten Welinder)
2004-10-14  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilechooserdefault.c (shortcuts_remove_rows): Don't
	get text unnecessarily.  (#155384, Morten Welinder)
2004-10-14 14:14:12 +00:00
Matthias Clasen
34e1d6d70b Acknowledge the fact that invariants are broken and loop all the way up to
* gtk/gtkcontainer.c (_gtk_container_queue_resize): Acknowledge the fact        that invariants are broken and loop all the way up to the resize container.
2004-10-13 03:41:00 +00:00
4
3f32a4da46 don't queue the widget for resize or emit change notification if the usize
Tue Oct 12 17:11:02 2004    <timj@birnet.org>

        * gtk/gtkwidget.c (gtk_widget_set_usize_internal): don't queue the
        widget for resize or emit change notification if the usize didn't
        change. this works around a buggy signal connection in #155139.
2004-10-12 15:12:44 +00:00
Jonathan Blandford
0d12c6ad0d add /*< private >*/ markings.
Sun Oct 10 11:24:56 2004  Jonathan Blandford  <jrb@redhat.com>

        * gtk/gtkcontainer.h (struct _GtkContainer): add /*< private >*/
        markings.
2004-10-10 15:25:52 +00:00
Matthias Clasen
1488c49339 Add docs.
2004-10-09  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkcellview.c: Add docs.
2004-10-09 05:39:22 +00:00
Matthias Clasen
ff44b010bc Fix doc comment.
2004-10-09  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_get_menu): Fix
	doc comment.
2004-10-09 04:52:32 +00:00
Matthias Clasen
6b7f5ada66 Reinstate the accidentally lost addition of
2004-10-09  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkactiongroup.h:
	* gtk/gtkactiongroup.c: Reinstate the accidentally lost addition
	of gtk_action_group_translate_string().
2004-10-09 04:26:11 +00:00
Matthias Clasen
4ef4bd0c27 Declare gtk_accelerator_get_label.
2004-10-09  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkaccelgroup.h: Declare gtk_accelerator_get_label.
2004-10-09 04:05:07 +00:00
Matthias Clasen
724a8865d2 forgotten commit 2004-10-08 19:01:30 +00:00
Matthias Clasen
0caefdebc0 Don't start a drag if we loose the grab.
2004-10-08  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtktreeview.c (gtk_tree_view_grab_notify): Don't start a
	drag if we loose the grab.
2004-10-08 19:00:57 +00:00
Matthias Clasen
356c249aab Set the cell renderer to inert mode to avoid bug #154921. This fixes a
* gtk/gtkfilechooserdefault.c (renderer_edited_cb): Set the cell
	renderer to inert mode to avoid bug #154921.  This fixes a crash
	which would otherwise occur if the editing is stopped for the second
	time.  (#154767, Manuel Baena García)
2004-10-08 17:09:18 +00:00
Matthias Clasen
eabb63be3b Add a new debug flag, geometry, to debug size allocation.
2004-10-08  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkdebug.h:
	* gtk/gtkwidget.c (gtk_widget_size_allocate): Add a new debug
	flag, geometry, to debug size allocation.
2004-10-08 15:26:02 +00:00
Matthias Clasen
ca4f063f28 Set cell data unconditionally. (#152562, Federico Mena Quintero)
2004-10-08  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtktreeview.c (gtk_tree_view_button_press): Set cell data
	unconditionally.  (#152562, Federico Mena Quintero)
2004-10-08 14:42:39 +00:00
Matthias Clasen
f64d8567ed Also update smart separators if the visibility of a menuitem with a
2004-10-08  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkuimanager.c (update_node): Also update smart separators
	if the visibility of a  menuitem with a submenu changes.  (#153791,
	Christian Persch)
2004-10-08 05:00:34 +00:00
Matthias Clasen
daeea8b871 Share the three copies of get_borders() under the name
2004-10-08  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkentry.h:
	* gtk/gtkentry.c:
	* gtk/gtkentrycompletion.c:
	* gtk/gtkspinbutton.c: Share the three copies of get_borders()
	under the name _gtk_entry_get_borders().  (#116368, Owen Taylor)
2004-10-08 04:24:45 +00:00
Matthias Clasen
205d5ce310 Include gtkeventbox.h. (#154798, Morten Welinder)
* gtk/gtkfilechooserdefault.c: Include gtkeventbox.h.
	(#154798, Morten Welinder)
2004-10-08 03:04:25 +00:00
Matthias Clasen
71fbbf8911 Don't free info too early. (#154703, Morten Welinder)
2004-10-07  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilechooserdefault.c (check_is_folder): Don't free
	info too early.  (#154703, Morten Welinder)
2004-10-07 05:03:19 +00:00
Matthias Clasen
002ceac808 Reduce rounding error. (#154658, John Cupitt)
2004-10-06  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkpaned.c (gtk_paned_compute_position): Reduce rounding
	error.  (#154658, John Cupitt)
2004-10-07 03:44:58 +00:00
Matthias Clasen
cd79561f8f Clear the iter instead of returning it unmodified. (#154186, Jonathan
2004-10-06  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtktreeselection.c (gtk_tree_selection_get_selected): Clear
	the iter instead of returning it unmodified. (#154186, Jonathan Blandford)
2004-10-06 18:51:03 +00:00
Matthias Clasen
5fde6ffa0b Pop up the completions again after tab. (#147700, Jens Bech Madsen)
2004-10-06  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilechooserentry.c (gtk_file_chooser_entry_focus): Pop up
	the completions again after tab.  (#147700, Jens Bech Madsen)
2004-10-06 18:20:03 +00:00
Matthias Clasen
68b72ab7f8 Set the cursor before changing the selection to make the file chooser
2004-10-06  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtktreeview.c (gtk_tree_view_search_iter): Set the cursor
	before changing the selection to make the file chooser preview
	update work better.  (#143826, Tommi Komulainen)
2004-10-06 17:06:35 +00:00
Matthias Clasen
f0d016ef38 Replace a really gross way of rounding to a specified number of digits.
2004-10-06  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkrange.c (gtk_range_real_change_value): Replace a really
	gross way of rounding to a specified number of digits.  (#145232,
	Peter Zelezny, patch by Soeren Sandmann)
2004-10-06 05:11:36 +00:00
Tim Janik
229388f26d reverted my last change and applied owen's leaner conditional flag update
Tue Oct  5 21:00:54 2004  Tim Janik  <timj@gtk.org>

        * gtk/gtkwidget.c (gtk_widget_size_allocate): reverted my last change
        and applied owen's leaner conditional flag update which should be good
        enough to preserve resizing flag invariants.
2004-10-05 19:02:49 +00:00
Tim Janik
b9a31bbcb2 removed redundant gtk_entry_get_layout() decl.
Tue Oct  5 19:29:06 2004  Tim Janik  <timj@gtk.org>

        * gtk/gtkentry.h: removed redundant gtk_entry_get_layout() decl.
2004-10-05 17:30:03 +00:00
Matthias Clasen
dd0a7ce608 Go back to not scaling up at all. Less magic.
2004-10-05  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkicontheme.c (icon_info_ensure_scale_and_pixbuf): Go back to
	not scaling up at all. Less magic.
2004-10-05 17:06:00 +00:00
Tim Janik
841bb40d78 if REQUEST_NEEDED is still set on ::size-allocate, another size-request
Tue Oct  5 17:06:26 2004  Tim Janik  <timj@gtk.org>

        * gtk/gtkwidget.c (gtk_widget_size_allocate): if REQUEST_NEEDED is still
        set on ::size-allocate, another size-request has been queued since
        ::size-request and needs to be requeued.
2004-10-05 15:10:50 +00:00
Paolo Borelli
1ea4933f3f rename the activate-menu signal to show-menu as discussed in bug #153873.
2004-10-05  Paolo Borelli  <pborelli@katamail.com>

	* gtk/gtkmenutoolbutton.c: rename the activate-menu signal to
	show-menu as discussed in bug #153873.
2004-10-05 14:19:54 +00:00
Matthias Clasen
63f3fc79c6 Set action_name. (#154526, John Finlay)
2004-10-05  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkuimanager.c (gtk_ui_manager_add_ui): Set
	action_name.  (#154526, John Finlay)
2004-10-05 14:12:24 +00:00
Matthias Clasen
0dfe684dde Provide access to the string representation of accelerators used in
2004-10-05  Matthias Clasen  <mclasen@redhat.com>

	Provide access to the string representation of accelerators used
	in GtkAccelLabel.  (#154068, John Spray)

	* gtk/gtkaccelgroup.h:
	* gtk/gtkaccelgroup.c (gtk_accelerator_get_label): New function
	to return the accelerator label used in GtkAccelLabel.
	(gtk_accelerator_name): Update docs to point to
	gtk_accelerator_get_label().
	* gtk/gtkaccellabel.h:
	* gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
	New auxiliary function which creates the string representing the
	accelerator.
2004-10-05 05:17:22 +00:00
Matthias Clasen
d966036d4d Resize the popup if a new model is set. (#154129, Bernd Damian)
2004-10-05  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkcombobox.c (gtk_combo_box_set_model): Resize the
	popup if a new model is set.  (#154129, Bernd Damian)
2004-10-05 04:37:29 +00:00
Matthias Clasen
6e6824a06b Make the code work as intended for unthemed icons; don't scale them up too
2004-10-04  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkicontheme.c (icon_info_ensure_scale_and_pixbuf):
	Make the code work as intended for unthemed icons; don't scale
	them up too much. Allow to scale them down, and do so
	exactly.  (#154142, Ross Burton)
	(gtk_icon_info_load_icon): Amend docs.
2004-10-05 03:18:22 +00:00
Matthias Clasen
c6c858dda2 Improve docs. (#154504, Dave Cook)
2004-10-04  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkcelllayout.c (gtk_cell_layout_clear): Improve
	docs.  (#154504, Dave Cook)
2004-10-05 02:52:26 +00:00
Matthias Clasen
9de1565a99 Only set using_themed_icon if we actually got an icon list from the theme.
2004-10-04  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkwindow.c (gtk_window_realize_icon): Only set
	using_themed_icon if we actually got an icon list from the
	theme.  (#154472, Morten Welinder)
2004-10-04 15:16:57 +00:00
Matthias Clasen
ce2ddb38d7 Ref the new icons before unreffing the old ones. (#154468, Morten
2004-10-04  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkwindow.c (gtk_window_set_icon_list):
	(gtk_window_set_default_icon_list): Ref the new
	icons before unreffing the old ones.  (#154468, Morten Welinder)
2004-10-04 14:52:45 +00:00
Matthias Clasen
69a603cacc Ref the new icons before unreffing the old ones. (#154468, Morten
2004-10-04  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkwindow.c (gtk_window_set_icon_list): Ref the new icons
	before unreffing the old ones.  (#154468, Morten Welinder)
2004-10-04 14:47:03 +00:00
Matthias Clasen
49ba32e195 Reset pointers pointing to the old model. (#154350)
2004-10-03  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkiconview.c (gtk_icon_view_set_model): Reset pointers
	pointing to the old model.  (#154350)
2004-10-04 03:33:59 +00:00
Matthias Clasen
864c47e7dc Set sort_indicator to FALSE when appropriate. (#153714, Reinout van
2004-10-03  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtktreeviewcolumn.c
	(gtk_tree_view_column_setup_sort_column_id_callback):
	Set sort_indicator to FALSE when appropriate.  (#153714,
	Reinout van Schouwen)
2004-10-03 06:12:09 +00:00
Matthias Clasen
41f17245c5 Fix positioning near the monitor boundaries. (#154341, Ken Harris)
2004-10-03  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtktreeview.c (gtk_tree_view_search_position_func):
	Fix positioning near the monitor boundaries.  (#154341,
	Ken Harris)
2004-10-03 05:19:52 +00:00
Paolo Borelli
3fed513283 deactivate the menu before setiing it to something else. Bug #153887.
2004-10-01  Paolo Borelli  <pborelli@katamail.com>

	* gtk/gtkmenutoolbutton.c: deactivate the menu before setiing it
	to something else. Bug #153887.
2004-10-02 10:10:11 +00:00
Matthias Clasen
a263e05646 Fix bug #150790:
2004-10-01  Matthias Clasen  <mclasen@redhat.com>

	Fix bug #150790:

	* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_get_size): Fix the
	calculation of x_offset when ellipsized and in RTL mode.
	(gtk_cell_renderer_text_render): Fix the calculation of the layout
	width when ellipsized.
2004-10-01 21:39:01 +00:00
Matthias Clasen
49174ac1be Add a comment regarding cell renderers to the docs.
2004-10-01  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkcombobox.c (gtk_combo_box_set_model): Add a comment regarding
	cell renderers to the docs.
2004-10-01 19:00:47 +00:00
Matthias Clasen
03646f37b1 Silently ignore info being NULL. This is unavoidable with the current
2004-10-01  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear_attributes):
	* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_layout_clear_attributes):
	Silently ignore info being NULL. This is unavoidable with the
	current design where we have every implementation of layout_clear
	call layout_clear_attributes, and also delegate calls to dependent
	cell layouts.  (#154191, Martyn Russell)
2004-10-01 18:56:14 +00:00
Matthias Clasen
63110fc53d Make --g-fatal-warnings a G_OPTION_ARG_NONE, since it doesn't take an
2004-09-29  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkmain.c: Make --g-fatal-warnings a G_OPTION_ARG_NONE,
	since it doesn't take an argument.
2004-09-29 22:29:21 +00:00