Benjamin Otte
4b793dd508
a11y: Remove an outdated comment
2014-06-10 01:17:00 +02:00
Joanmarie Diggs
fc00381d30
GtkEntryAccessible: Emit signal after insertion
...
The signal needs to be emitted after the text insertion as at-spi gets
the text to compute the inserted text due to the AtkText::insert-text
signal not containing it.
Also adjust position to reflect changes to the offsets.
https://bugzilla.gnome.org/show_bug.cgi?id=731429
2014-06-10 01:07:57 +02:00
Evan Nemerson
bda145b19f
gtk: fix annotation syntax and missing some missing annotations
...
These changes clean up various errors and omissions resulting from
either slightly incorrect G-I/gtk-doc syntax or missing documentation
blocks.
https://bugzilla.gnome.org/show_bug.cgi?id=730745
2014-05-27 21:10:32 -07:00
Matthias Clasen
04703689b8
Deprecate GtkAligment
...
This has been dangling ever since 3.0.
https://bugzilla.gnome.org/show_bug.cgi?id=645781
2014-05-23 20:31:25 -04:00
Evan Nemerson
4a4b23bfad
a11y: build directly into libgtk instead of an internal library
...
https://bugzilla.gnome.org/show_bug.cgi?id=730615
2014-05-23 19:20:59 -04:00
Cosimo Cecchi
a2a1c6da95
cellarea: don't use focus-line-width
...
Use CSS padding instead.
2014-05-09 11:02:45 -07:00
Matthias Clasen
22ab2ca2a5
a11y: Avoid a warning
...
The listbox row accessible code was giving warnings when
parent is NULL, at destruction time.
2014-05-05 19:46:04 -04:00
Benjamin Otte
748b2bf5ae
a11y: Disable deprecation warnings in AtkMisc implementation
2014-05-05 16:10:16 +02:00
Matthias Clasen
9d7f7ddadf
GtkSpinButton: Implement new AtkValue interface
...
The AtkValue interface has been replaced in ATK 2.12.
Implement the new one in addition to the old one.
2014-05-02 20:47:16 -04:00
Matthias Clasen
fc7e7495a6
GtkScaleButton: Implement new AtkValue interface
...
The AtkValue interface has been replaced in ATK 2.12.
Implement the new one in addition to the old one.
2014-05-02 20:47:00 -04:00
Matthias Clasen
516cd70780
GtkRange: Implement new AtkValue interface
...
The AtkValue interface has been replaced in ATK 2.12.
Implement the new one in addition to the old one.
2014-05-02 20:46:45 -04:00
Matthias Clasen
1d50657740
GtkProgressBar: Implement new AtkValue interface
...
The AtkValue interface has been replaced in ATK 2.12.
Implement the new one in addition to the old one.
2014-05-02 20:46:30 -04:00
Matthias Clasen
98affc6829
GtkPaned: Implement new AtkValue interface
...
The AtkValue interface has been replaced in ATK 2.12.
Implement the new one in addition to the old one.
2014-05-02 20:46:17 -04:00
Matthias Clasen
987cce9e65
GtkLevelBar: Implement new AtkValue interface
...
The AtkValue interface has been replaced in ATK 2.12.
Implement the new one in addition to the old one.
2014-05-02 20:46:03 -04:00
Matthias Clasen
efcaaa524e
list box: Update accessible implementation
...
Now that multi selection is supported, we can provide a more
complete AtkSelection implementation.
2014-04-06 01:44:36 -04:00
Matthias Clasen
fee33b1a81
Clean up private headers
...
This commit adds a few missing private headers, and cleans up
some irregularities in the existing ones
2014-04-05 02:06:29 -04:00
Jonas Danielsson
b29bbc6210
a11y: atk_table_get_row_at_index is deprecated
...
Do not use deprecated index based AtkTable functions use static
helper instead.
https://bugzilla.gnome.org/show_bug.cgi?id=727313
2014-04-01 21:40:24 -04:00
Jonas Danielsson
e7962f5871
a11y: atk_component_get_position is deprecated
...
Switch to using atk_component_get_extents instead.
https://bugzilla.gnome.org/show_bug.cgi?id=727313
2014-04-01 21:40:23 -04:00
Bastien Nocera
f71f7215ab
all: Name more idles and timeouts
...
Following up from 438cd857c4
,
name more timeouts and idles.
The original grep was missing checking for gdk_threads_add_*()
functions (at least for some of the files).
https://bugzilla.gnome.org/show_bug.cgi?id=726870
2014-03-26 20:09:30 -04:00
Benjamin Otte
be7380a418
a11y: Move relationset updating to new vfunc
...
This way, we don't create lots of cell accessibles when creating the
first one (because surely one is the parent/child of another who again
is a parent/child of another who again....)
2014-03-24 16:38:18 +01:00
Benjamin Otte
8374a58623
a11y: Add API to update relationsets of cells to their parents
2014-03-24 16:38:18 +01:00
Benjamin Otte
fef14e0e87
a11y: Don't unref relations
...
Nobody was reffing those related object in the first place and that
was causing random crashes.
And if somebody had reffed those related objects, they'd have caused
reference cycles.
https://bugzilla.gnome.org/show_bug.cgi?id=726838
2014-03-24 16:38:17 +01:00
Carlos Garnacho
0e7884f1a7
a11y: Remove weak reference when updating a GtkPopoverAccessible relative-to widget
...
Otherwise the weak reference is left dangling, which later causes issues at the time
of destroying that widget.
https://bugzilla.gnome.org/show_bug.cgi?id=726749
2014-03-21 15:33:58 +01:00
Benjamin Otte
66fae0330c
a11y: Don't use signals
...
Instead, call functions directly. Fixes the fact that the signals
weren't disconnected even when the accessible was destroyed.
https://bugzilla.gnome.org/show_bug.cgi?id=725733
2014-03-13 02:02:50 +01:00
Carlos Garnacho
89c4ef5873
a11y: Don't allocate a list just for counting widgets in GtkContainerAccessible
...
It's more straightforward if counting through gtk_container_foreach().
2014-03-10 23:02:41 +01:00
Carlos Garnacho
31cd153050
a11y: Add GtkPopopverAccessible
...
And let GtkPopover use it as its GtkAccessible implementation, this
accessible sets the POPUP_FOR relationship to the relative-to widget,
and keeps track of changes there.
https://bugzilla.gnome.org/show_bug.cgi?id=725864
2014-03-10 23:02:14 +01:00
Carlos Garnacho
d4d6968e1a
a11y: Add private GtkContainerAccessible functions to add/remove a child
...
This may be useful in container implementations, or for internal children
that trigger no signal emission.
https://bugzilla.gnome.org/show_bug.cgi?id=725864
2014-03-10 23:01:59 +01:00
Carlos Garnacho
9d54fee952
a11y: Make GtkWindowAccessible know about popovers
...
https://bugzilla.gnome.org/show_bug.cgi?id=725864
2014-03-10 23:01:52 +01:00
Marek Kasik
158cb29e55
GtkIconViewAccessible: Don't access freed item
...
Don't get index from deleted GtkIconViewItem.
Remove the item before traversing list of items.
https://bugzilla.gnome.org/show_bug.cgi?id=701884
2014-03-05 21:03:36 +01:00
Benjamin Otte
af4b26f581
a11y: Fix refcounting for treeview cells
...
Old code assumed that AT-SPI would keep track of references and
therefore tried to only hold weak references. On the other hand it also
tried to keep objects alive so it referenced objects very randomly. All
of that lead to cycles and leaking.
As AT-SPI does not keep track of objects at all, the treeview now does.
The refcounting looks as follows:
GtkTreeViewAccessible
=> creates per row/column
GtkTreeViewAccessibleCellInfo
=> which references 1
GtkCellAccessible
If there is only one cell, this accessible is a
GtkRendererCellAccessible, otherwise a GtkContainerCellAccessible is
created and that accessible holds references to the
GtkRendererCellAccessibles that are created for every cell renderer.
https://bugzilla.gnome.org/show_bug.cgi?id=554618
2014-02-26 02:36:08 +01:00
Benjamin Otte
bcdb4aa2a7
a11y: Refactor function
...
Make the intent of the function clear by implementing it that way.
2014-02-26 02:36:08 +01:00
Benjamin Otte
5ea4dbf3e0
a11y: Split out a function
...
This will make the next refactoring easier.
2014-02-26 02:36:08 +01:00
Benjamin Otte
70ff97e812
a11y: Remove unused variable
2014-02-26 02:36:08 +01:00
Benjamin Otte
2fdd420e78
a11y: Use more obvious function name
2014-02-26 02:36:07 +01:00
Benjamin Otte
f60bb84d15
a11y: Split out creation of cell info
...
Don't mix cell info creation with cell accessible creation. Instead,
first create the accessible, then create the cell info.
2014-02-26 02:36:07 +01:00
Benjamin Otte
43fe3c499c
a11y: Split out a function
...
First in a set of refactorings to make the create_cell() function
actually understandable.
2014-02-26 02:36:07 +01:00
Alejandro Piñeiro
79ed2b790a
a11y: remove implementation for component->get_size
...
Recently get_size was removed because it was redundant, as
you can get the same information from get_extents.
https://bugzilla.gnome.org/show_bug.cgi?id=723863
2014-02-09 23:11:53 -05:00
Ignacio Casal Quinteiro
4238cc4b7b
Revert "Fix memory leak in GtkTreeViewAccessible"
...
This reverts commit 7a411eb6dd
.
This also makes gedit external tools manager to crash
2014-02-06 22:15:12 +01:00
William Jon McCann
2a45418b67
docs: use proper quotes
2014-02-05 15:08:42 -05:00
Benjamin Otte
43baa213b2
a11y: Ignore deprecation warnings for ATK focus tracker
2014-02-03 21:38:16 +01:00
Mike Gorse
e529dfe949
A11y: Fix text functions for table cells
...
Keep the PangoLayout around, and refresh in update_cache.
https://bugzilla.gnome.org/show_bug.cgi?id=707729
2014-01-13 23:51:26 -05:00
John Lindgren
7a411eb6dd
Fix memory leak in GtkTreeViewAccessible
...
https://bugzilla.gnome.org/show_bug.cgi?id=722030
2014-01-13 22:30:38 -05:00
Matthias Clasen
a4e4d7d1fd
GtkMenuItem: fix initial accessible selection state
...
When the accessible is created for an already-selected
menuitem, we were not properly setting the state of the
the accessible. Fix that.
2014-01-05 22:45:39 -05:00
Matthias Clasen
e015102fa9
a11y: Fix keybindings in menus
...
GtkMenuItemAccessible was assuming that an accel label is
always the immediate child of a menu item. It also did not
deal with manually set accels. Fix both of these.
https://bugzilla.gnome.org/show_bug.cgi?id=721086
2014-01-05 11:56:31 -05:00
Matthias Clasen
29cd52c854
Emit a11y state change notification for color swatches
...
Improve the color swatch accessible to set a proper role
depending on whether the swatch is selectable or not, and
set the checked atk state when appropriate.
https://bugzilla.gnome.org/show_bug.cgi?id=721048
2014-01-05 10:54:43 -05:00
Matthias Clasen
8085b41074
GtkCheckMenuItemAccessible: Make work with model menu items
...
GtkModelMenuItem does not emit the ::toggled signal when a radio
item is activated, so listen for property notification for that
property. We still keep the ::toggled signal handler, in order
to not break other uses of check and radio menu items.
https://bugzilla.gnome.org/show_bug.cgi?id=720983
2014-01-04 21:53:31 -05:00
Matthias Clasen
9137b4ed8e
GtkColorSwatch: Set an accessible role
...
And update the colorchooser a11y test to a) use GtkColorChooser
instead of the deprecated GtkColorSelection and b) match this
change. Pointed out in
https://bugzilla.gnome.org/show_bug.cgi?id=721045
2014-01-04 18:52:46 -05:00
Matthias Clasen
4de1259cd9
Trivial formatting fix
2014-01-04 17:41:23 -05:00
Matthias Clasen
9bf89f2b5e
GtkLabelAccessible: reorganize the code
...
Separate the GtkLabelAccessible, GtkLabelAccessibleLink and
GtkLabelAccessibleLinkImpl implementations more clearly.
2014-01-04 10:54:03 -05:00
Matthias Clasen
b85a8001e0
GtkLabelAccessible: update state of links
...
This commit makes the LinkImpl children of label accessibles
inherit all their state, except for focused and visited, which
are handled directly.
https://bugzilla.gnome.org/show_bug.cgi?id=721406
2014-01-04 10:54:03 -05:00