Commit Graph

10588 Commits

Author SHA1 Message Date
Michael Natterer
da61c61c4b bail out early if priv->button is NULL to avoid zillions of warnings when
2008-08-05  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkcombobox.c (gtk_combo_box_update_sensitivity): bail out
	early if priv->button is NULL to avoid zillions of warnings when
	destroying combo boxes that were working fine before the
	button sensitivity patch.


svn path=/trunk/; revision=21014
2008-08-05 15:44:04 +00:00
Michael Natterer
f2527e8d07 Bug 544858 – Seal GtkAdjustment
2008-08-05  Michael Natterer  <mitch@imendio.com>

	Bug 544858 – Seal GtkAdjustment

	* gtk/gtk.symbols
	* gtk/gtkadjustment.[ch] (struct GtkAdjustment): seal all struct
	members.

	Add accessors for all properties and additionally a new function
	gtk_adjustment_configure() which sets all properties at
	once. Patch by Christian Dywan and myself.


svn path=/trunk/; revision=21013
2008-08-05 14:46:26 +00:00
Michael Natterer
0affd82480 clamp the value to [lower...upper-page_size] instead of only
2008-08-05  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkadjustment.c (gtk_adjustment_set_value): clamp the value
	to [lower...upper-page_size] instead of only [lower...upper].

	* README: add note about this change.

	While this fix is correct and should have been there forever, it
	has the potential to break some corner cases, however these cases
	would set page_size to a value != 0 which suggests they want it
	honored.


svn path=/trunk/; revision=21012
2008-08-05 14:25:29 +00:00
Michael Natterer
b1ad452d25 don't use the deprecated gtk_box_pack_start_defaults().
2008-08-05  Michael Natterer  <mitch@imendio.com>

	* tests/testiconview.c: don't use the deprecated
	gtk_box_pack_start_defaults().


svn path=/trunk/; revision=21010
2008-08-05 12:30:15 +00:00
Matthias Clasen
c455b5eac1 Add some missing braces
svn path=/trunk/; revision=21005
2008-08-05 00:21:49 +00:00
Tor Lillqvist
36a571570d Trivialities.
svn path=/trunk/; revision=21004
2008-08-05 00:17:42 +00:00
Tor Lillqvist
5b97a90502 Cast pointer to gintptr instead of gulong to avoid warning on Win64.
2008-08-05  Tor Lillqvist  <tml@novell.com>

	* gtk/gtktext.c: Cast pointer to gintptr instead of gulong to
	avoid warning on Win64.


svn path=/trunk/; revision=21003
2008-08-04 23:55:40 +00:00
Tor Lillqvist
ffeb954aff Cast tile, stipple and clip_mask pointers to gintptr when calculating
2008-08-05  Tor Lillqvist  <tml@novell.com>

	* gtk/gtkgc.c: Cast tile, stipple and clip_mask pointers to
	gintptr when calculating hash, so we get all of the pointer bits
	on Win64 where long is 32 bits.


svn path=/trunk/; revision=21002
2008-08-04 23:51:16 +00:00
Tor Lillqvist
9be8382038 Don't need to declare IPrintDialogCallback with mingw64 either. It seems
2008-08-05  Tor Lillqvist  <tml@novell.com>

	* gtk/gtkprintoperation-win32.c: Don't need to declare
	IPrintDialogCallback with mingw64 either. It seems to come with
	newer versions of the headers.


svn path=/trunk/; revision=21001
2008-08-04 23:49:15 +00:00
Tor Lillqvist
a1e3946f58 Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
2008-08-05  Tor Lillqvist  <tml@novell.com>

	Bug 544684 - Win64 issue, window handles are assumed to be 32-bit

	* gtk/gtksocket-win32.c: Don't cast HWND to guint, pass it as such
	as the GdkNativeWindow parameter to
	gtk_window_remove_embedded_xid(). Debugging printout format fixes.

	* gtk/gtkwin32embed.h
	* gtk/gtkwin32embed.c: Change the types of wparam and lparam
	parameters to actually be WPARAM and LPARAM.

	* gtk/gtkplug-win32.c: Adapt accordingly.


svn path=/trunk/; revision=21000
2008-08-04 23:44:59 +00:00
Matthias Clasen
7d85757776 Bug 382291 – Automatically dim the combobox when the model is empty
2008-08-04  Matthias Clasen  <mclasen@redhat.com>

        Bug 382291 – Automatically dim the combobox when the model is empty

        * gtk/gtk.symbols:
        * gtkcombobox.[hc]: Add a GtkComboBox::button-sensitivity
        property with getter and setter to control the sensitity of
        empty combo boxes. Patch by Carlos Garnacho, Sven Herzberg,
        Christian Dywan and others.

        * README.in: Add a note about automatic combobox sensitivity.


svn path=/trunk/; revision=20997
2008-08-04 23:40:36 +00:00
Tor Lillqvist
b97d6816c8 Enclose ?: expression with parens so cast covers all of it.
2008-08-05  Tor Lillqvist  <tml@novell.com>

	* gtk/updateiconcache.c (write_bucket): Enclose ?: expression
	with parens so cast covers all of it.


svn path=/trunk/; revision=20996
2008-08-04 23:38:06 +00:00
Matthias Clasen
785b5f1b3f Improve a string
svn path=/trunk/; revision=20995
2008-08-04 23:36:17 +00:00
Tor Lillqvist
d6ab77ea70 Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
2008-08-05  Tor Lillqvist  <tml@novell.com>

	Bug 544684 - Win64 issue, window handles are assumed to be 32-bit

	* gdk/win32/gdkcursor-win32.c
	* gdk/win32/xcursors.h: Change some gchar* to guchar* and vice
	versa to avoid gcc 4.4 signedness warnings.

	* gdk/win32/gdkevents-win32.c: Add some guchar and char pointer
	casts to get rid of gcc 4.4 signedness warnings. Print GdkAtom
	values in debugging output using the %p format.
	
	* gdk/win32/gdkkeys-win32.c
	* gdk/win32/gdkfont-win32.c
	* gdk/win32/gdkmain-win32.c: Add some casts to avoid gcc warnings.
 
	* gdk/win32/gdkwindow-win32.c: Use SetWindowLongPtr() instead of
	SetWindowLong().

	* gdk/win32/gdkwin32id.c (gdk_handle_hash): Use all 64 bits of a
	HANDLE on Win64.


svn path=/trunk/; revision=20994
2008-08-04 23:21:36 +00:00
Tor Lillqvist
a860ec7d7b Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
2008-08-05  Tor Lillqvist  <tml@novell.com>

	Bug 544684 - Win64 issue, window handles are assumed to be 32-bit

	* gdk/win32/gdkproperty-win32.c
	* gdk/win32/gdkselection-win32.c: Add some guchar and char pointer
	casts to get rid of gcc 4.4 warnings. Print GdkAtom values in
	debugging output using the %p format.


svn path=/trunk/; revision=20993
2008-08-04 23:01:32 +00:00
Tor Lillqvist
eff4be5c8d Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
2008-08-05  Tor Lillqvist  <tml@novell.com>

	Bug 544684 - Win64 issue, window handles are assumed to be 32-bit

	* gtk/gtkwindow.h
	* gtk/gtkwindow.c: Change the type of the xid parameter of the
	internal gtk_window_remove_embedded_xid() and
	gtk_window_add_embedded_xid() functions from guint to
	GdkNativeWindow.

	* gtk/gtkwindow.c (send_client_message_to_embedded_windows):
	Instead of GPOINTER_TO_UINT(), just cast the gpointer to
	GdkNativeWindow. GPOINTER_TO_UINT() drops the upper 32 bits on
	Win64.


svn path=/trunk/; revision=20992
2008-08-04 22:57:36 +00:00
Tor Lillqvist
f4d9ce22f4 Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
2008-08-05  Tor Lillqvist  <tml@novell.com>

	Bug 544684 - Win64 issue, window handles are assumed to be 32-bit

	* gdk/gdkselection.h
	* gdk/gdkselection.c
	* gdk/win32/gdkselection-win32.c
	* gdk/x11/gdkselection-x11.c: Change type of the requestor
	window id parameter of gdk_selection_send_notify_for_display()
	and gdk_selection_send_notify() from guint32 to
	GdkNativeWindow.

	* gdk/win32/gdkselection-win32.c: Add some guchar and char pointer
	casts to get rid of gcc 4.4 warnings. Print GdkAtom values in
	debugging output using the %p format.


svn path=/trunk/; revision=20991
2008-08-04 22:43:57 +00:00
Matthias Clasen
7919814bf6 Fix make check
svn path=/trunk/; revision=20990
2008-08-04 22:38:56 +00:00
Tor Lillqvist
62b41df929 Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
2008-08-05  Tor Lillqvist  <tml@novell.com>

	Bug 544684 - Win64 issue, window handles are assumed to be 32-bit

	* gdk/gdkdnd.h
	* gdk/gdkdnd.c
	* gdk/win32/gdkdnd-win32.c
	* gdk/x11/gdkdnd-x11.c: Change return value and type of window id
	from guint32 to GdkNativeWindow for
	gdk_drag_get_protocol_for_display() and
	gdk_drag_get_protocol(). This is not an API break on existing
	platforms, as GdkNativeWindow has been guint32 for them
	already.


svn path=/trunk/; revision=20989
2008-08-04 22:36:53 +00:00
Tor Lillqvist
ad2ea92f75 Cast pointers to guintptr, not unsigned long, before doing bit tests on
2008-08-05  Tor Lillqvist  <tml@novell.com>

	* gdk/gdkrgb.c: Cast pointers to guintptr, not unsigned long,
	before doing bit tests on them.


svn path=/trunk/; revision=20987
2008-08-04 22:26:26 +00:00
Tor Lillqvist
6a5f3cc9d9 Define GDK_NATIVE_WINDOW_POINTER on 32-bit Windows, too. It just makes
2008-08-05  Tor Lillqvist  <tml@novell.com>

	* configure.in: Define GDK_NATIVE_WINDOW_POINTER on 32-bit
	Windows, too. It just makes more sense, as a HWND *is* a kind of
	pointer.

	* gdk/gdkconfig.h.win32: Ditto here.


svn path=/trunk/; revision=20986
2008-08-04 22:20:53 +00:00
Björn Lindqvist
67a8a3a265 Bug 534979 – GtkImageMenuItem is a bin but has two children.
2008-08-04  Björn Lindqvist  <bjourne@gmail.com>

	Bug 534979 – GtkImageMenuItem is a bin but has two children.

	* gtk/gtkimagemenuitem.c (gtk_image_menu_item_forall): Do not
	include the image widget when iterating over non-internal
	children. Patch by rainwoodman.

svn path=/trunk/; revision=20985
2008-08-04 21:37:02 +00:00
Matthias Clasen
361a787cfd Updates
svn path=/trunk/; revision=20984
2008-08-04 18:41:28 +00:00
Matthias Clasen
f9504c1402 Bump glib dependency
svn path=/trunk/; revision=20983
2008-08-04 18:24:14 +00:00
Michael Natterer
0ac989bdcc gtk/gtkclist.c gtk/gtkctree.c gtk/gtkpixmap.c get rid of using deprecated
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkclist.c
	* gtk/gtkctree.c
	* gtk/gtkpixmap.c
	* gtk/gtkpreview.c: get rid of using deprecated GDK APIs.

	* gtk/gtktext.c: ditto, apart from the text cruft APIs.


svn path=/trunk/; revision=20982
2008-08-04 17:59:43 +00:00
Michael Natterer
7261e61f29 call gdk_rgb_set_verbose(TRUE) if "gdkrgb" is in the debug flags.
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* gdk/gdk.c (gdk_parse_args): call gdk_rgb_set_verbose(TRUE) if
	"gdkrgb" is in the debug flags.

	* gdk/gdkrgb.c (gdk_rgb_init): remove setting the verbose flag
	here, this function is deprecated and the debug flag didn't work
	when using GDK properly.


svn path=/trunk/; revision=20981
2008-08-04 17:17:46 +00:00
Matthias Clasen
25536fafd0 Update to handle GEmblem`
svn path=/trunk/; revision=20980
2008-08-04 16:36:28 +00:00
Michael Natterer
45ac6c4fc1 undeprecate (apart from still using GtkOptionMenu).
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* tests/prop-editor.c: undeprecate (apart from still using
	GtkOptionMenu).


svn path=/trunk/; revision=20979
2008-08-04 16:33:28 +00:00
Michael Natterer
a3a5bc340d gtk/gtkseparatortoolitem.c remove pointless #undef GTK_DISABLE_DEPRECATED.
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkseparatortoolitem.c
	* tests/testactions.c: remove pointless #undef GTK_DISABLE_DEPRECATED.

	* gtk/gtkcalendar.c (calendar_set_display_option): use
	gtk_calendar_set_display_options() instead of the deprecated
	gtk_calendar_display_options().


svn path=/trunk/; revision=20977
2008-08-04 16:12:23 +00:00
Carlos Garnacho
65a53ff251 Fix "/* within comment" warning.
2008-08-04  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtkfilechooserbutton.c: Fix "/* within comment" warning.

svn path=/trunk/; revision=20975
2008-08-04 15:17:27 +00:00
Carlos Garnacho
e9be9eb190 Set drag window background to be the GtkNotebook background color. This is
2008-08-04  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtknotebook.c (gtk_notebook_expose): Set drag window background
        to be the GtkNotebook background color. This is a workaround to
        prevent black pixels in rounded tabs when reordering. Improves
        #368234.

svn path=/trunk/; revision=20973
2008-08-04 14:46:22 +00:00
Carlos Garnacho
7e439efc92 Deprecate gtk_file_chooser_*_new_with_backend(), since GIO is already used
2008-08-04  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtk.symbols:
        * gtk/gtkfilechooserbutton.[ch]:
        * gtk/gtkfilechooserdefault.[ch]:
        * gtk/gtkfilechooserdialog.[ch]:
        * gtk/gtkfilechooserwidget.[ch]: Deprecate
        gtk_file_chooser_*_new_with_backend(), since GIO is already used
        directly. Fixes #545976.

svn path=/trunk/; revision=20972
2008-08-04 14:43:53 +00:00
Carlos Garnacho
02c65db5c0 Make GFile-oriented API public. Fixes #545978.
2008-08-04  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtk.symbols:
        * gtk/gtkfilechooser.[ch]: Make GFile-oriented API public. Fixes
        #545978.
        * gtk/gtkfilechooserbutton.c:
        * gtk/gtkfilechooserdefault.c:
        * gtk/gtkfilechooserutils.c: Update to use public GFile API.

svn path=/trunk/; revision=20971
2008-08-04 14:43:05 +00:00
Michael Natterer
aa435e024a build with GTK_DISABLE_DEPRECATED again.
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* gtk/Makefile.am: build with GTK_DISABLE_DEPRECATED again.

	Fix pltcheck.sh by restricting the visibility of deprecated
	symbols to the places where they are actually used:

	* gtk/gtkclist.c
	* gtk/gtkctree.c
	* gtk/gtklistitem.c
	* gtk/gtklist.c
	* gtk/gtkprogressbar.c
	* gtk/gtkpixmap.c
	* gtk/gtkprogress.c: #undef GTK_DISABLE_DEPRECATED and #define
	__GTK_FOO_C__ on top instead of before including gtkaliasdef.c.

	* gtk/gtkclist.h
	* gtk/gtkctree.h
	* gtk/gtklistitem.h
	* gtk/gtklist.h
	* gtk/gtkpixmap.h
	* gtk/gtkprogress.h: make the headers visible if the respective
	__GTK_FOO_C__ are defined.


svn path=/trunk/; revision=20970
2008-08-04 14:38:35 +00:00
Michael Natterer
dbd5b75e5e gtk/gtkclist.c gtk/gtklist.c gtk/gtkoldeditable.c gtk/gtkpixmap.c
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkclist.c
	* gtk/gtklist.c
	* gtk/gtkoldeditable.c
	* gtk/gtkpixmap.c
	* gtk/gtktipsquery.c
	* gtk/gtktree.c
	* gtk/gtktreeitem.c: avoid using deprecated GtkWidget API.


svn path=/trunk/; revision=20969
2008-08-04 14:23:55 +00:00
Michael Natterer
906db67f37 gtk/gtkclist.[ch] gtk/gtkctree.[ch] gtk/gtkitemfactory.[ch]
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkclist.[ch]
	* gtk/gtkctree.[ch]
	* gtk/gtkitemfactory.[ch]
	* gtk/gtkobject.[ch]
	* gtk/gtksignal.[ch]: s/GtkDestroyNotify/GDestroyNotify/g


svn path=/trunk/; revision=20967
2008-08-04 14:13:56 +00:00
Sven Neumann
cd8bca1c64 update the link color when the "visited" state is changed.
2008-08-04  Sven Neumann  <sven@gimp.org>

	* gtk/gtklinkbutton.c (gtk_link_button_set_uri): update the link
	color when the "visited" state is changed.


svn path=/trunk/; revision=20966
2008-08-04 14:13:12 +00:00
Michael Natterer
d132b616e2 move the code of the deprecated gtk_window_set_policy() to a new private
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkwindow.c: move the code of the deprecated
	gtk_window_set_policy() to a new private function
	gtk_window_set_policy_internal() and call it from
	gtk_window_set_policy().

	(gtk_window_set_resizable): use the new internal function in order
	to avoid our own deprecated public API.


svn path=/trunk/; revision=20965
2008-08-04 13:52:56 +00:00
Michael Natterer
888c3a72b5 move the code of the deprecated gtk_binding_entry_clear() to a new private
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkbindings.c: move the code of the deprecated
	gtk_binding_entry_clear() to a new private function
	gtk_binding_entry_clear_internal() and call it from
	gtk_binding_entry_clear().

	(_gtk_binding_entry_add_signall)
	(gtk_binding_parse_bind): use the new internal function in order
	to avoid our own deprecated public API.


svn path=/trunk/; revision=20963
2008-08-04 11:08:33 +00:00
Michael Natterer
5a3691352d avoid our own deprecated public API and use
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkfontsel.c (gtk_font_selection_dialog_get_font):
	avoid our own deprecated public API and use
	gtk_font_selection_get_font_internal() instead of
	gtk_font_selection_get_font().

	(gtk_font_selection_get_font)
	(gtk_font_selection_dialog_get_font): Add missing
	"Deprecated: 2.0" to the api doc comments.


svn path=/trunk/; revision=20962
2008-08-04 10:33:02 +00:00
Michael Natterer
154f0f56de add the generated PNGs to CLEANFILES.
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* gdk/tests/Makefile.am: add the generated PNGs to CLEANFILES.


svn path=/trunk/; revision=20961
2008-08-04 10:20:16 +00:00
Tor Lillqvist
1934bff891 Small improvement.
svn path=/trunk/; revision=20960
2008-08-04 09:05:51 +00:00
Tor Lillqvist
71d9f3d45b Set LIB_EXE_MACHINE_FLAG to either X86 or X64 on Windows. AC_SUBST it.
2008-08-04  Tor Lillqvist  <tml@novell.com>

	* configure.in: Set LIB_EXE_MACHINE_FLAG to either X86 or X64 on
	Windows. AC_SUBST it.

	* gdk/Makefile.am
	* gtk/Makefile.am: Pass appropriate -machine flag to lib.exe.


svn path=/trunk/; revision=20957
2008-08-03 23:47:10 +00:00
Tor Lillqvist
963ee0de5e Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
2008-08-04  Tor Lillqvist  <tml@novell.com>

	Bug 544684 - Win64 issue, window handles are assumed to be 32-bit

	* configure.in: On Win64, define GDK_NATIVE_WINDOW_POINTER.

	* gdk/gdkconfig.h.win32: Ditto here.


svn path=/trunk/; revision=20956
2008-08-03 23:36:17 +00:00
Tor Lillqvist
6ecaa61a1c Fix typo in Win32 and Quartz code:
2008-08-04  Tor Lillqvist  <tml@novell.com>

	* gtk/gtkstatusicon.c: Fix typo in Win32 and Quartz code:
	s/gtk_icon_icon_info_load_icon/gtk_icon_info_load_icon/ .


svn path=/trunk/; revision=20955
2008-08-03 23:16:31 +00:00
Tor Lillqvist
72f0a30431 Don't bother with the test "if gio can sniff png" if $gio_can_sniff has
2008-08-04  Tor Lillqvist  <tml@novell.com>

	* configure.in: Don't bother with the test "if gio can sniff png"
	if $gio_can_sniff has been already set. Preset it to "no" for
	Win32. This helps cross-compilation from 32-bit Windows to
	64-bit. No idea how this should be handled for cross-compilation
	in general.


svn path=/trunk/; revision=20954
2008-08-03 23:09:28 +00:00
Tor Lillqvist
34159c417b Don't bother looking up EnumDisplayMonitors and GetMonitorInfoA
2008-08-04  Tor Lillqvist  <tml@novell.com>

	* gdk/win32/gdkdisplay-win32.c: Don't bother looking up
	EnumDisplayMonitors and GetMonitorInfoA dynamically, they are
	present in NT-based Windows since Windows 2000.
	(enum_monitor): For some reason the MONITORINFOEX struct in
	mingw-win64 is different than the proper one as in MSDN and 32-bit
	mingw, so just copy the proper definition here.


svn path=/trunk/; revision=20953
2008-08-03 23:05:37 +00:00
Björn Lindqvist
8303b4437e Bug 540379 – gtk_tree_view_enable_model_drag_dest and
2008-08-03  Björn Lindqvist  <bjourne@gmail.com>

	Bug 540379 – gtk_tree_view_enable_model_drag_dest and
	gtk_tree_view_enable_model_drag_source unsets reorderable property

	* gtk/gtktreeview.c: Improve docstrings regarding reorderable
	property.

svn path=/trunk/; revision=20952
2008-08-03 19:38:21 +00:00
Matthias Clasen
a8700de468 Support GEmblemedIcon
svn path=/trunk/; revision=20951
2008-08-03 19:28:05 +00:00
Matthias Clasen
ca66090cd5 Add translator comment
svn path=/trunk/; revision=20950
2008-08-03 19:25:00 +00:00