Commit Graph

2955 Commits

Author SHA1 Message Date
Havoc Pennington
e58c6eca32 remove unused variable (gtk_text_view_get_window): add warning about how
2002-02-06  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextview.c (gtk_text_view_scroll_hpages): remove unused variable
	(gtk_text_view_get_window): add warning about how you
	can't get the private window. #70683, and avoid default: in the
	switch so we get "enum value unhandled" warnings
2002-02-06 22:22:37 +00:00
Havoc Pennington
99b7d4a189 Add warnings if you try to use a child anchor that isn't inside a buffer.
2002-02-06  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextchild.c: Add warnings if you try to use a child
	anchor that isn't inside a buffer. Really kind of lame;
	we should separate the anchor from the buffer. But not worth
	fixing for now. #70601
2002-02-06 22:07:47 +00:00
Kristian Rietveld
2d1b1a623c rip out all the debugging ifdefs, as modelsort seems to be stable (and
Wed Feb  6 18:25:24 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreemodelsort.c: rip out all the debugging ifdefs, as
        modelsort seems to be stable (and nobody complained :)
2002-02-06 17:24:28 +00:00
Owen Taylor
9a8f790e8a Keep the length of the anti-expose queue finite, by if it gets too long,
Tue Feb  5 19:13:42 2002  Owen Taylor  <otaylor@redhat.com>

        * gdk/x11/gdkgeometry-x11.c (gdk_window_queue): Keep
        the length of the anti-expose queue finite, by if
        it gets too long, first doing a XSync() and checking
	the event queue, and if that doesn't work, simply
        discarding all anti-expose items in the queue.

	* gdk/x11/gdkdnd-x11.c (gdk_window_cache_filter): Fix ordering
	on ConfigureNotify (#56349, Thomas Leonard)
2002-02-06 00:41:07 +00:00
Havoc Pennington
d18c9de808 offset area being gotten from pixmap by the align/padding offsets, so we
2002-02-05  Havoc Pennington  <hp@redhat.com>

	* gtk/gtkimage.c (gtk_image_expose): offset area being gotten from
	pixmap by the align/padding offsets, so we don't get warnings
	in gdk_pixbuf_get_from_drawable (and so it works, of course)
2002-02-05 23:07:07 +00:00
Matthias Clasen
6370cf3b8e Remove a (now) misleading comment.
* gtk/gtkrc.c (gtk_rc_parse_file): Remove a (now) misleading comment.

	* gtk/tmpl/gtkrc.sgml: Update the description of RC file loading
	to match recent code changes. Also document font_name and engine.
2002-02-05 22:50:31 +00:00
Federico Mena Quintero
9b8cf1d532 Do not #include <gdk/gdkwindow.h>.
2002-02-05  Federico Mena Quintero  <federico@ximian.com>

	* gdk/gdkwindow.h: Do not #include <gdk/gdkwindow.h>.
2002-02-05 22:06:33 +00:00
Kristian Rietveld
f84fca8b0a let's set the path, which we're going to pass with the emission of
Tue Feb  5 22:54:16 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtkliststore.c (gtk_list_store_insert_after): let's set the
        path, which we're going to pass with the emission of row_inserted, to
        the iter we inserted and not its sibling.
2002-02-05 21:53:51 +00:00
Padraig O'Briain
402f5b9d93 Fix leak of GdkEvent (#70519)
* gtk/gtkmenu.c (gtk_menu_popup):
Fix leak of GdkEvent (#70519)
2002-02-04 17:46:33 +00:00
Owen Taylor
9c61501877 Fix from Matthias Clasen to clear background appropriately for theme by
Mon Feb  4 10:40:28 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkstyle.c (gtk_default_draw_resize_grip):
        Fix from Matthias Clasen to clear background appropriately
        for theme by calling gtk_style_apply_default_background().
        (#70449)
2002-02-04 15:43:09 +00:00
Owen Taylor
aea7e2c13a on Feb 4 10:06:49 2002 Owen Taylor <otaylor@redhat.com>
* gdk/x11/gdkevents-x11.c: gtk-double-click-time,
        not gtk-double-click-timeout. (#70501)
2002-02-04 15:13:26 +00:00
Havoc Pennington
b96ec2e0b2 rename "signal" arg to "name" to avoid compiler warnings about shadowing
2002-02-04  Havoc Pennington  <hp@pobox.com>

	* gtk/gtksignal.c (gtk_signal_connect_while_alive):
	(gtk_signal_connect_object_while_alive): rename
	"signal" arg to "name" to avoid compiler warnings
	about shadowing signal(). #70453
2002-02-04 06:08:28 +00:00
Anders Carlsson
4eca4af11b Add flipping support to the expanders.
2002-02-03  Anders Carlsson  <expander-master@gtk.org>

	* gtk/gtkstyle.c (gtk_default_draw_expander): Add
	flipping support to the expanders.
2002-02-03 21:18:44 +00:00
Owen Taylor
ab65e77988 RC file lookup improvements (#68234, suggestions from Matthias Clasen.)
Sat Feb  2 21:54:01 2002  Owen Taylor  <otaylor@redhat.com>

        RC file lookup improvements (#68234, suggestions
        from Matthias Clasen.)

        * gtk/gtkrc.c (gtk_rc_parse_file): Look for the
        locale suffix variants (gtkrc.en_US, gtkrc.en) for
        all RC files we parse, not just the default RC
        files.

        * gtk/gtkrc.c (gtk_rc_parse_default_files): Remove
        support for charset specific RC files.
2002-02-03 03:02:07 +00:00
Owen Taylor
ae7521bd9d Non-exported _gtk_menu_select_first() function that selects the first item
Sat Feb  2 20:16:04 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkmenushell.c (_gtk_menu_shell_select_first):
        Non-exported _gtk_menu_select_first() function that
        selects the first item of the menu in a standard
        way. (Skipping tearoffs.)

        * gtk/gtkmenushell.c gtk/gtkentry.c gtk/gtktextview.c
        gtkmenuitem.c: Use _gtk_menu_shell_select_first().

        * gtk/gtkmenuitem.c (gtk_real_menu_item_select): Remember
        if we are starting the timeout from a keypress so
        we can set menushell->ignore_enter properly.

        * gtk/gtknotebook.c (focus_child_in): Return something
        meaningful if there are no children.

        * gtk/gtkmenu.c (gtk_menu_key_press): Fix precendence
        problem.
2002-02-03 01:25:32 +00:00
Owen Taylor
0ed21b67d9 Fix some bugs in the determination of xgrab_shell.
Sat Feb  2 19:15:42 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkmenu.c (gtk_menu_popup): Fix some bugs in
        the determination of xgrab_shell.
2002-02-03 00:18:41 +00:00
Owen Taylor
d6622d38d6 Add a GtkSetting (gtk-entry-select-on-focus) controlling whether the
Sat Feb  2 17:43:00 2002  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkentry.c (gtk_entry_grab_focus): Add a GtkSetting
	(gtk-entry-select-on-focus) controlling whether the
	contents of an entry are selected on focus in.

	* gtk/gtkmenu.c (gtk_menu_key_press): Add a GtkSetting
	(gtk-can-change-accels) controlling whether accelerators can be
	changed on the fly or not. (#51902)

	* gtk/gtkmenu.c (gtk_menu_key_press): Allow unmodified
	accelerators, now that accelerator changing can be turned
	off for those who won't expect it. (#61285)

	* gtk/gtkaccelgroup.c (gtk_accelerator_valid): Allow
	Backspace/Delete/KP_Delete as valid accelerators.

	* gtk/gtkmenu.c (gtk_menu_key_press): Allow setting of
	Delete/Backspace as accelerators by making them toggle
	the menu item between empty and the pressed key.
	(#58605)

	* tests/testgtkrc: Remove the objectionably short cursor blink
	time setting.
2002-02-02 22:52:22 +00:00
Owen Taylor
2ee08d8ec6 To get around the fact that we may have a owner_events = FALSE grab in
Sat Feb  2 16:43:31 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkmenu.c (gtk_menu_popup): To get around the fact
        that we may have a owner_events = FALSE grab in effect
        when we pop up a window, make a temporary grab on a
        different window, then grab on the real window. Fixes
        a problem where if a context menu popped up under the
        cursor, the first item would be stuck unselected.
        (#59812, reported by Arnaud Charlet.)
2002-02-02 21:50:46 +00:00
Peter Williams
9e31153e9b Install gtkrc.default from $(srcdir) for when $(builddir) is different.
2002-02-02  Peter Williams  <peterw@ximian.com>

	* gtk/Makefile.am (install-data-local): Install gtkrc.default
	from $(srcdir) for when $(builddir) is different.
2002-02-02 20:12:53 +00:00
Kristian Rietveld
ea9e0c772c remove TESTGTK_RCFILE define
Sat Feb  2 19:00:39 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/Makefile.am: remove TESTGTK_RCFILE define
2002-02-02 17:58:07 +00:00
Owen Taylor
67ad02989f Remove the "select first item if popped up from keypress" hack -- was
Sat Feb  2 11:37:21 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkmenu.c (gtk_menu_popup): Remove the
        "select first item if popped up from keypress" hack --
        was causing more problems than it was worth
        (#53191, #68483)

        * gtk/gtktextview.c (popup_targets_received):
         gtk/gtkentry.c (popup_targets_received): If activated
        from keyboard, select first item of popup menu.
2002-02-02 17:52:01 +00:00
Kristian Rietveld
7bb3d17abe set upper member of vadjustment correct, so the vscrollbars of lists
Sat Feb  2 18:07:51 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreeview.c (gtk_tree_view_size_allocate): set upper member
        of vadjustment correct, so the vscrollbars of lists smaller than
        1 page are somewhat saner (#66905)

        * gtk/gtkliststore.c (gtk_list_store_remove_silently): do not
        increment the stamp, liststore is a model with persisting iters
2002-02-02 17:07:49 +00:00
Owen Taylor
a998112472 Support engine "" {} to mean override to the default engine. (#70205)
Fri Feb  1 23:54:00 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkrc.[ch] (gtk_rc_parse_engine): Support
        engine "" {} to mean override to the default
        engine. (#70205)
2002-02-02 16:37:23 +00:00
Owen Taylor
1c9b864974 Parse the RC string here when the first object is created rather than in
Fri Feb  1 23:25:33 2002  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtktooltips.c (gtk_tooltips_init): Parse the
	RC string here when the first object is created
	rather than in the class_init to not break doc
	building. (#70341, Havoc Pennington.)

	* gtk/gtkrc.c (parse_include_file): Use the directories
	for the currently parsed files as the starting point
	to look for include files. (#59975)
2002-02-02 04:34:09 +00:00
Manish Singh
47a43e8f72 use gtk_label_new_with_mnemonic for labels that actually have mnemonics
Fri Feb  1 20:21:56 2002  Manish Singh  <yosh@gimp.org>

        * gtk/gtkinputdialog.c: use gtk_label_new_with_mnemonic for labels
        that actually have mnemonics
2002-02-02 04:26:48 +00:00
Owen Taylor
caf1d42427 Fix use of ! in shell.
Fri Feb  1 19:57:59 2002  Owen Taylor  <otaylor@redhat.com>

	* configure.in: Fix use of ! in shell.

	* gtk/gtktooltips.c (gtk_tooltips_class_init) gtkrc.default:
	Move the setting of default tooltips colors to gtktooltips.c
	from gtkrc.default. (Use default priority so themes will
	override.) (#58542)
2002-02-02 01:00:42 +00:00
Owen Taylor
5288e07931 Fix ordering of priorities so that priorities take precendence over the
Fri Feb  1 17:48:51 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkrc.c (gtk_rc_get_style): Fix ordering of
        priorities so that priorities take precendence over
        the ordering by type. (#70205)

        * test/testgtkrc tests/testgtk.c (create_rc_file): Add
        some labels to test priorities in testgtkrc.
2002-02-02 00:44:52 +00:00
Kristian Rietveld
4eb836706c use y coordinate relative to the tree and not the treeview window (fixes
Fri Feb  1 00:37:49 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down): use
        y coordinate relative to the tree and not the treeview window
        (fixes the PgDn/PgUp brokenness)
2002-02-01 23:36:10 +00:00
Kristian Rietveld
87a0cbcffc adjust cell_area and background_area for possible treeview scroll (fixes
Fri Feb  1 23:40:31 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreeview.c (gtk_tree_view_button_press): adjust
        cell_area and background_area for possible treeview scroll
        (fixes #70283, #70065)
2002-02-01 22:41:39 +00:00
Kristian Rietveld
435235b8a4 (committed this again -- broken pipe and ChangeLog update)
Fri Feb  1 22:20:13 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreeview.c (gtk_tree_view_size_allocate): use
        height - page_size not height - allocation->height (fixes #66269)
2002-02-01 21:21:01 +00:00
Kristian Rietveld
0bb8e8d069 use height - page_size not height - allocation->height
Fri Feb  1 22:20:13 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreeview.c (gtk_tree_view_size_allocate): use
        height - page_size not height - allocation->height
2002-02-01 21:18:17 +00:00
Owen Taylor
17eaeb6feb Fix typo in property description. (Christian Rose.)
Fri Feb  1 15:22:23 2002  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkimage.c (gtk_image_class_init): Fix typo
	in property description. (Christian Rose.)
2002-02-01 20:23:12 +00:00
Owen Taylor
ff95eb051b Handle reparsing any strings if the theme changes. (#69465)
Fri Feb  1 14:50:36 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkrc.c (gtk_rc_parse_string): Handle reparsing
        any strings if the theme changes. (#69465)

        * tests/testgtk.c: Add a test for gtk_rc_parse_string().
2002-02-01 20:14:02 +00:00
Kristian Rietveld
593bc65f54 set tree to NULL if tree_view->priv->tree is NULL (#70152, patch by John
Fri Feb  1 20:50:29 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreeview.c (gtk_tree_view_dy_to_top_row): set tree to
        NULL if tree_view->priv->tree is NULL (#70152, patch by John Harper).
2002-02-01 19:49:49 +00:00
Owen Taylor
a7d3cece47 ri Feb 1 12:51:20 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtknotebook.c (focus_child_in): Catch the
        cur_page == NULL (no children) case. (#70287,
        Paolo Maggi.)
2002-02-01 17:53:56 +00:00
Owen Taylor
6fa24ee83e s/directory/folder/ in all labels and messages.
Fri Feb  1 12:12:12 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkfilesel.c (attempt_file_completion):
        s/directory/folder/ in all labels and messages.
2002-02-01 17:41:47 +00:00
Owen Taylor
7650f90550 Feb 1 08:57:38 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkmain.c (gtk_exit_func): Remove this useless
        atexit handler. (existance pointed out by Stefan Kost)

        * gtk/gtkmain.c (gtk_init_check): Warning fixes.
2002-02-01 14:15:56 +00:00
Jonathan Blandford
5759992c98 unref the model after the last use, not before.
Thu Jan 31 18:46:10 2002  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtktreemodel.c (gtk_tree_row_reference_free): unref the
	model after the last use, not before.
2002-01-31 23:47:23 +00:00
Owen Taylor
cb26587ff8 Install a Default RC file that sets the tooltips color to yellow. (#58542)
Thu Jan 31 14:50:16 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkrc.default gtk/Makefile.am: Install a Default
        RC file that sets the tooltips color to yellow. (#58542)

        * gtk/gtksettings.c (gtk_settings_class_init): make
        the default theme "Default", not NULL.
2002-01-31 20:14:18 +00:00
Owen Taylor
160725555e Fix another missing static.
Thu Jan 31 11:33:52 2002  Owen Taylor  <otaylor@redhat.com>

        * gdk/x11/gdkproperty-x11.c (insert_atom_pair): Fix
        another missing static.

        * gtk/gtkimmodule.c (n_loaded_contexts): And another.

        * gdk/x11/Makefile.am gdk/x11/gxid_lib.c: Don't
        build gxid sources at all except in the vanishingly
        rare case of --with-xinput=xfree.
2002-01-31 16:37:27 +00:00
Mark McLoughlin
60dd9e5477 make static.
2002-01-31  Mark McLoughlin  <mark@skynet.ie>

        * gdk/gdkimage.c: (scratch_image_info_for_depth): make static.

        * gdk/x11/gdkimage-x11.c: (get_full_image): ditto.

        * gdk/x11/gxid_lib.[ch]: (_gxid_claim_device), (_gxid_release_device):
        renamed from gxid_(claim|release)_device.

        * gdk/x11/gdkinput-gxi.c: (_gdk_input_enable_window),
        (_gdk_input_disable_window): upd for gxid change.

        * gtk/gtkimage.c: (animation_timeout): make static.

        * gtk/gtkstyle.c: (draw_thin_shadow), (draw_spin_entry_shadow): make
        static.

        * gtk/gtktextutil.c: (bidi_menu_entries): make static.
2002-01-31 15:48:58 +00:00
Owen Taylor
bb3ddb39f6 Handle the case where bin->child is NULL. (#70153, Padraig O'Briain)
Thu Jan 31 10:21:05 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkplug.c (gtk_plug_focus): Handle the case where
        bin->child is NULL. (#70153, Padraig O'Briain)

        * gtk/gtktextutil.c (_gtk_text_util_append_special_char_menuitems):
        Actually call gettext() on the labels; previously they
        were marked with N_() but we never called gettext().
2002-01-31 15:26:52 +00:00
Jonathan Blandford
9725d9958e save last minute changes before committing.
Wed Jan 30 20:15:49 2002  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtktreestore.c (gtk_tree_store_set_valist): save last minute
	changes before committing.
2002-01-31 01:17:21 +00:00
Jonathan Blandford
78d39ef504 only emit the signal if an interesting column changes.
Wed Jan 30 18:46:14 2002  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtkliststore.c (gtk_list_store_set_valist): only emit the
	signal if an interesting column changes.

	* gtk/gtktreestore.c: ditto.

	* gtk/gtktreeview.c (gtk_tree_view_set_cursor): change behavior so
	that it no longer grabs
2002-01-30 23:51:04 +00:00
Manish Singh
2cfa52b1ee remove unused variable.
2002-01-30  Manish Singh  <yosh@gimp.org>

        * gtk/gtkhandlebox.c (gtk_handle_box_destroy): remove unused
        variable.

        * gtk/gtkwindow.c (gtk_window_get_icon): function returns a value,
        so return NULL with g_return_val_if_fail instead of g_return_if_fail.
2002-01-30 23:35:08 +00:00
Matthias Clasen
53e7265067 Add bug number to my last entry. 2002-01-30 22:35:12 +00:00
Matthias Clasen
4dddfb2dc6 Remove excess calls to g_return_if_fail from static and virtual functions. 2002-01-30 22:29:03 +00:00
Anders Carlsson
95ab2a72b4 Allow a -1 icon size.
2002-01-30  Anders Carlsson  <andersca@gnu.org>

	* gtk/gtkstyle.c (gtk_default_render_icon): Allow a -1 icon size.
2002-01-30 21:00:49 +00:00
Tim Janik
bb974b6bd4 fix revrted bug fix. (use a define for max digits).
Wed Jan 30 20:29:01 2002  Tim Janik  <timj@gtk.org>

        * gtk/gtkscale.c (gtk_scale_set_digits): fix revrted bug fix.
        (use a define for max digits).
2002-01-30 19:29:59 +00:00
Owen Taylor
2a9af2ff42 Try to make sure that we have some focused widget on map. (#50339)
Wed Jan 30 13:55:59 2002  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkwindow.c (gtk_window_show): Try to make
	sure that we have some focused widget on map. (#50339)

	* gtk/gtkdialog.c (gtk_dialog_map): Handling picking
	a focus widget here differently so that if a
	response button gets picked, it's the default one.

	* tests/testgtk.c (make_message_dialog): Set the
	default response for the dialogs.
2002-01-30 18:58:31 +00:00