Commit Graph

7792 Commits

Author SHA1 Message Date
Xan Lopez
447de09918 Plug leak: When reordering the info in the list the old node is removed
2007-12-15  Xan Lopez  <xan.lopez@nokia.com>

	* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_layout_reorder):

	Plug leak: When reordering the info in the list the old node is
	removed but not freed. (#503569)

svn path=/trunk/; revision=19184
2007-12-15 11:15:19 +00:00
Ray Strode
8609315d28 Suggest g_signal_connect (..., "realize", ...) instead of
2007-12-14  Ray Strode  <rstrode@redhat.com>

	* gtk/gtkwidget.c: Suggest g_signal_connect (..., "realize", ...)
	instead of g_signal_connect_after (..., "realize", ...) as an
	alternative to gtk_widget_realize () (bug 503537).

svn path=/trunk/; revision=19181
2007-12-14 17:06:08 +00:00
Mathias Hasselmann
41c300a5c7 Correct "Since:" tags for GtkPageSetup and GtkPrintSettings as
next stable release shall be 2.16, not 2.14 - even if disagree.

* gtk/gtkpagesetup.c, gtk/gtkprintsettings.c: s/2.14/2.16/

svn path=/trunk/; revision=19179
2007-12-14 11:07:23 +00:00
Mathias Hasselmann
95adf7ee26 Change GtkToolItem to retrieve its properties from GtkToolShell interface,
instead of relying on being child of a GtkToolbar. (#5034079)

* gtk/gtk.symbols, docs/reference/gtk/gtk-docs.sgml,
docs/reference/gtk/gtk-sections.txt: Add GtkToolShell symbols.
* docs/reference/gtk/tmpl/gtktoolitem.sgml: Move section docs inline.
* gtk/gtktoolbar.c: Implement GtkToolShellIface.
* gtk/gtktoolbar.h: Remove _gtk_toolbar_rebuild_menu.
* gtk/gtktoolitem.c: Use GtkToolShell, instead of GtkToolbar.
Take section docs from template file and update them for GtkToolShell.
* gtk/Makefile.am: Add gtk/gtktoolshell.c and gtk/gtktoolshell.h.
* gtk/gtktoolshell.c, gtk/gtktoolshell.h: New GtkToolShellIface.

svn path=/trunk/; revision=19177
2007-12-14 10:57:46 +00:00
Mathias Hasselmann
ea8074a407 Extract loading of GtkPageSetup and GtkPrintSettings from their *_new_*()
functions and move that code into separate *_load_*() functions (#475565).

* gtk/gtk.symbols, gtk/gtkpagesetup.c, gtk/gtkpagesetup.h:
Extract gtk_page_setup_load_file, gtk_page_setup_load_key_file,
gtk_print_settings_load_file and gtk_print_settings_load_key_file.
Change the matching *_new_*() functions to use those functions.

svn path=/trunk/; revision=19176
2007-12-14 09:02:54 +00:00
Matthias Clasen
da057b5675 Close an api gap in tooltips
svn path=/trunk/; revision=19175
2007-12-14 05:00:51 +00:00
Kristian Rietveld
22e102081a added tests for insertion functions.
2007-12-14  Kristian Rietveld  <kris@imendio.com>

	* gtk/tests/liststore.c:
	* gtk/tests/treestore.c: added tests for insertion functions.


svn path=/trunk/; revision=19174
2007-12-14 00:52:04 +00:00
Kristian Rietveld
935d9a6574 test the move and swap functions on a store with only one node.
2007-12-13  Kristian Rietveld  <kris@imendio.com>

	* gtk/tests/liststore.c:
	* gtk/tests/treestore.c: test the move and swap functions on a
	store with only one node.


svn path=/trunk/; revision=19172
2007-12-13 16:28:12 +00:00
Kristian Rietveld
6900ad4b41 add a call to g_test_bug_base().
2007-12-13  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktestutils.c (gtk_test_init): add a call to
	g_test_bug_base().

	* gtk/tests/treeview-scrolling.c: add g_test_bug() calls to
	appriopriate tests.


svn path=/trunk/; revision=19171
2007-12-13 14:05:04 +00:00
Kristian Rietveld
790c308fd4 start composing tests for the list and tree store.
2007-12-13  Kristian Rietveld  <kris@imendio.com>

	* gtk/tests/liststore.c:
	* gtk/tests/treestore.c: start composing tests for the list and tree
	store.

	* gtk/tests/treeview-scrolling.c: added automated tests for
	GtkTreeView's scrolling "subsystem".

	* gtk/tests/Makefile.am: updated; added new test programs.


svn path=/trunk/; revision=19170
2007-12-13 12:59:01 +00:00
Michael Natterer
64c73a61b7 Remove all .cvsignore files.
svn path=/trunk/; revision=19169
2007-12-13 11:18:45 +00:00
Mathias Hasselmann
594e3660e9 Another attempt to improve gtk_drag_dest_set docs.
* gtk/gtkdnd.c: Another attempt to improve gtk_drag_dest_set docs.

svn path=/trunk/; revision=19164
2007-12-12 09:39:36 +00:00
Mathias Hasselmann
dce782750f Mention impact of GtkDestDefaults on "drag-motion" handlers. Clearify
* gtk/gtkdnd.c, gtk/gtkwidget.c: Mention impact of GtkDestDefaults
on "drag-motion" handlers. Clearify documentation for
gtk_drag_dest_set.

svn path=/trunk/; revision=19159
2007-12-11 18:56:56 +00:00
Matthias Clasen
2a702dcd42 Another fix to avoid further fallout from the fix for bug 388321.
2007-12-10  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtknotebook.c (gtk_notebook_real_remove): Another fix
        to avoid further fallout from the fix for bug 388321.



svn path=/trunk/; revision=19139
2007-12-10 06:19:53 +00:00
Matthias Clasen
c131da48c9 Correct the documentation of child property getter arguments. (#501992,
2007-12-07  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkcontainer.c: Correct the documentation of child
        property getter arguments.  (#501992, David Brigada)



svn path=/trunk/; revision=19130
2007-12-07 19:06:03 +00:00
Matthias Clasen
dcc86ce57c Don't leak pixbufs. (#502250, Yevgen Muntyan)
2007-12-07  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkfilechooserdefault.c (shortcuts_reload_icons): Don't
        leak pixbufs.  (#502250, Yevgen Muntyan)


svn path=/trunk/; revision=19128
2007-12-07 18:51:25 +00:00
Yevgen Muntyan
6003bcbd96 added alternative button order in Print and Page Setup dialogs.
2007-12-07  Yevgen Muntyan  <muntyan@tamu.edu>

	* gtk/gtkprintunixdialog.c:
	* gtk/gtkpagesetupunixdialog.c: added alternative button order in
	Print and Page Setup dialogs.


svn path=/trunk/; revision=19126
2007-12-07 18:05:42 +00:00
Tommi Komulainen
62315bd5d0 Remove trailing whitespace that can trigger false positives in abicheck.sh
2007-12-06  Tommi Komulainen  <tommi.komulainen@iki.fi>

	* gdk-pixbuf/gdk-pixbuf.symbols:
	* gdk/gdk.symbols:
	* gdk/gtk.symbols: Remove trailing whitespace that can trigger false
	positives in abicheck.sh

svn path=/trunk/; revision=19124
2007-12-06 20:14:17 +00:00
18:59:59 Tim Janik
9ba5da2f36 run tests in current dir after setting up the logging directory, so their
2007-12-05 18:59:59  Tim Janik  <timj@imendio.com>

        * gtk+/Makefile.decl: run tests in current dir after setting up the
        logging directory, so their results get properly merged into the
        resulting test log.

        * gtk+/gtk/gtktestutils.[hc]: added gtk_test_list_all_types() for
        tests to loop over registered Gdk/Gtk+ types.

        * gtk+/tests/objecttests.c: new test program, implements automated
        property tests. several properties are blacklisted because they
        seem to trigger Gdk/Gtk+ bugs. ./objecttests -m thorough --verbose
        can be used to test blacklisted properties and see which proprty failed.



svn path=/trunk/; revision=19115
2007-12-05 16:58:44 +00:00
Matthias Clasen
2b3c7b70ef Modify the tab-label-destroy fix to not crash epiphany.
2007-12-04  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtknotebook.c: Modify the tab-label-destroy fix to not
        crash epiphany.


svn path=/trunk/; revision=19107
2007-12-04 18:43:47 +00:00
Richard Hult
f411b93ca3 Don't crash when dragging from a source that doesn't support uri lists
2007-12-03  Richard Hult  <richard@imendio.com>

	* gtk/gtkquartz.c: (_gtk_quartz_set_selection_data_for_pasteboard):
	Don't crash when dragging from a source that doesn't support uri
	lists (bug #499868, Paul Davis).

svn path=/trunk/; revision=19102
2007-12-03 19:51:20 +00:00
Matthias Clasen
f9e4618bda Two optimizations for icon cache lookups.
2007-12-03  Matthias Clasen  <mclasen@redhat.com>

        Two optimizations for icon cache lookups.

        * gtk/gtkiconcache.[hc]:
        * gtk/gtkicontheme.c: Remember the directory index for
        subdirectories, instead of running over the directory list
        again and again.

        * gtk/gtkiconcache.c (find_image_offset): Remember the last
        chain and try it first; this helps with the the usage patterns
        in gtkicontheme.c, where the same icon is queried for a lot
        of subdirectories.


svn path=/trunk/; revision=19099
2007-12-03 17:44:27 +00:00
15:18:17 Tim Janik
f83588f87e use 'grep -o' to extract _get_type functions from header files. this
2007-12-03 15:18:17  Tim Janik  <timj@imendio.com>

        * gtk/Makefile.am (gtktypefuncs.c): use 'grep -o' to extract _get_type
        functions from header files. this should be portable across linux and
        Mac OS, unlike the previpous sed expression.



svn path=/trunk/; revision=19098
2007-12-03 14:17:31 +00:00
Cody Russell
48110a5013 [Win32]: On Windows, queue a redraw of child2 whenever we set the pane
2007-12-1  Cody Russell  <bratsche@gnome.org>

        * gtk/gtkpaned.c: (gtk_paned_set_position) [Win32]:      
        On Windows, queue a redraw of child2 whenever we set
        the pane handle position.  This is unfortunately kind
        of hacky, but solves the visual artifacts that were
        occuring on at least certain types of child widgets
        (e.g., text views and tree views) that are inside
        horizontal or vertical panes. (#144269)


svn path=/trunk/; revision=19095
2007-12-01 22:08:19 +00:00
Matthias Clasen
7fbc566d32 Fix doc typos
svn path=/trunk/; revision=19094
2007-11-30 18:20:39 +00:00
Matthias Clasen
5b48e3bfb3 Remove debug spew
svn path=/trunk/; revision=19092
2007-11-30 00:36:52 +00:00
Matthias Clasen
ff9ddfeb22 Fix subdir ordering
svn path=/trunk/; revision=19091
2007-11-29 23:54:23 +00:00
Tor Lillqvist
10825b14b8 A proper build of GNU libintl is supposed to export the variable
2007-11-28  Tor Lillqvist  <tml@novell.com>

	A proper build of GNU libintl is supposed to export the variable
	_nl_msg_cat_cntr. configure looks for that variable in order to
	recognize GNU gettext. If it sees that it is indeed GNU gettext
	that is used, it decides to install message catalogs in
	share/locale, otherwise in lib/locale. Until now on Windows I have
	built GTK+ against a build of GNU gettext that did not export
	_nl_msg_cat_cntr. But this will change, so we can't assume message
	catalogs are always in lib/locale.

	* gtk/gtkmain.c: (_gtk_get_localedir) [Win32]: Rework to handle
	GTK_LOCALEDIR being either in "lib" or "share". Move the function
	before the inclusion of gtkprivate.h so that it sees the original
	GTK_LOCALEDIR.

	* gtk-zip.sh.in: Check whether the message catalogs are in
	share/locale or lib/locale.


svn path=/trunk/; revision=19083
2007-11-28 01:06:07 +00:00
Tor Lillqvist
2159f9c7ca Improve portability. The -o option is present only in newish GNU egreps.
2007-11-28  Tor Lillqvist  <tml@novell.com>

	* gtk/Makefile.am: Improve portability. The -o option is present
	only in newish GNU egreps. Use one more sed in the pipeline
	instead.


svn path=/trunk/; revision=19082
2007-11-27 23:28:16 +00:00
Tor Lillqvist
d0f50cde27 Fix #375893, patch by Ben Hague:
2007-11-28  Tor Lillqvist  <tml@novell.com>

	Fix #375893, patch by Ben Hague:

	* gtk/gtkfilesystemwin32.c (get_viewable_logical_drives): Wrapper
	around GetLogicalDrives() that takes also the viewable drive
	restrictions in the Registry (which are usually the result of an
	Active Directory Group Policy) into account.

	(check_volumes, gtk_file_system_win32_list_volumes) Call
	get_viewable_logical_drives() instead of GetLogicalDrives().


svn path=/trunk/; revision=19079
2007-11-27 22:29:46 +00:00
Matthias Clasen
cd2d87b471 Zero some variables to silence valgrind. (#495124, Morten Welinder)
2007-11-27  Matthias Clasen <mclasen@redhat.com>

        * gtk/gtkwindow.c (gtk_window_move_resize): Zero some
        variables to silence valgrind.  (#495124, Morten Welinder)


svn path=/trunk/; revision=19077
2007-11-27 18:15:28 +00:00
Ryan Lortie
08e15bbbae add clarification stating that the construct_child function is responsible
2006-11-26  Ryan Lortie  <desrt@desrt.ca>

        * docs/reference/gtk/tmpl/gtkbuildable.sgml: add clarification stating
        that the construct_child function is responsible for returning a
        reference.
        * gtkbuilder.c (_gtk_builder_construct): remove g_object_ref() for
        objects from constructors
        * gtkuimanager.c (gtk_ui_manager_buildable_construct_child): add
        g_object_ref() to this construction function (it's the only
        implementer in GTK)

        Fixes #496645.


svn path=/trunk/; revision=19075
2007-11-27 03:25:09 +00:00
Ryan Lortie
490af125c2 remove concept of root objects and just refcount all objects in the
2006-11-26  Ryan Lortie  <desrt@desrt.ca>

        * gtkbuilder.c: remove concept of root objects and just refcount
        all objects in the builder.  Fixes #496651.


svn path=/trunk/; revision=19074
2007-11-27 03:07:23 +00:00
Josselin Mouette
21a30978dc reviewed by: Federico Mena Quintero
2007-11-26  Josselin Mouette <joss@malsain.org>

        reviewed by: Federico Mena Quintero

        * gtk/gtkfilechooserdefault.c: (shortcuts_append_paths),
        (shortcuts_add_bookmarks), (shortcuts_selection_changed_cb),
        (shortcuts_list_create), (gtk_file_chooser_default_should_respond):
        Make the shortcuts activate with a single click. (#148828)
        Fix a few things affected by the change:
          - Set selection mode to GTK_SELECTION_SINGLE to allow a case 
            where no shortcut is selected.
          - Don't activate a shortcut in the response callback.
          - Filter out duplicate entries in volumes and bookmarks to 
            avoid the selection to change when reordering them with DnD.


svn path=/trunk/; revision=19072
2007-11-26 23:16:19 +00:00
Matthias Clasen
7819005e2e Fix up some doc comments to shut up gtk-doc.
2007-11-26  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkmain.c:
        * gtk/gtknotebook.c:
        * gtk/gtkplugprivate.h:
        * gtk/gtksocket.c:
        * gtk/gtksocketprivate.h:
        * gtk/gtktable.c: Fix up some doc comments to shut up gtk-doc.


svn path=/trunk/; revision=19066
2007-11-26 20:15:15 +00:00
Matthias Clasen
fa0328da18 Change some labels to be clearer. String change ! (#376361, Sven Neumann)
2007-11-26  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkprintunixdialog.c: Change some labels to be clearer.
        String change !   (#376361, Sven Neumann)


svn path=/trunk/; revision=19061
2007-11-26 18:27:20 +00:00
Matthias Clasen
3132888e1b Short-circuit on destroy. (gtk_notebook_destroy): Destroy tab_label
2007-11-26  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtknotebook.c (gtk_notebook_update_labels): Short-circuit on
        destroy.
        (gtk_notebook_destroy): Destroy tab_label widgets. (#388321, Morten
        Welinder)


svn path=/trunk/; revision=19059
2007-11-26 18:21:13 +00:00
Matthias Clasen
9936134d97 Improve alternative button ordering. (#476827, Yevgen Muntyan, patch by
2007-11-26  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkassistant.c: Improve alternative button
        ordering.  (#476827, Yevgen Muntyan, patch by Carlos Garnacho)


svn path=/trunk/; revision=19057
2007-11-26 18:16:46 +00:00
Matthias Clasen
225803d3ce Fix a theming problem with colors in GtkCalendar. (#499703, Michael
2007-11-26  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkcalendar.c: Fix a theming problem with colors
        in GtkCalendar.  (#499703, Michael Hofmann)


svn path=/trunk/; revision=19055
2007-11-26 17:42:35 +00:00
Matthias Clasen
736f86b303 Use templates for glib-mkenums calls instead of complicated commandlines
2007-11-26  Matthias Clasen  <mclasen@redhat.com>

        Use templates for glib-mkenums calls instead of
        complicated commandlines in Makefiles.  (#429910)

        * gdk-pixbuf/Makefile.am:
        * gdk/Makefile.am:
        * gtk/Makefile.am:
        * perf/Makefile.am: Use templates for glib-mkenums

        * gdk-pixbuf/gdk-pixbuf-enum-types.[ch].template:
        * gdk/gdkenumtypes.[ch].template:
        * gtk/gtktypebuiltings.[ch].template:
        * perf/typebuiltins.[ch].template: The templates


svn path=/trunk/; revision=19053
2007-11-26 17:32:19 +00:00
Matthias Clasen
d5eb6847e5 Don't use guint8 for bitfields, since some compilers choke on that.
2007-11-26  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkfilechooserbutton.c:
        * gtk/gtktoolbar.c: Don't use guint8 for bitfields, since
        some compilers choke on that.  (#467722)


svn path=/trunk/; revision=19051
2007-11-26 17:10:00 +00:00
Matthias Clasen
259244deda Add a note about hook setup. (#425004, Emmanuele Bassi)
2007-11-26  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkaboutdialog.c (gtk_about_dialog_set_website): Add a note
        about hook setup.  (#425004, Emmanuele Bassi)



svn path=/trunk/; revision=19050
2007-11-26 16:48:21 +00:00
Matthias Clasen
4896e24bb1 Require gtk-doc 1.8
2007-11-25  Matthias Clasen  <mclasen@redhat.com>

        * configure.in: Require gtk-doc 1.8

        * */*.c: Use gtk-doc abbreviations for examples in docs.


svn path=/trunk/; revision=19041
2007-11-25 06:51:19 +00:00
Matthias Clasen
1719428849 Fix a typo
svn path=/trunk/; revision=19039
2007-11-25 06:07:44 +00:00
Matthias Clasen
0184d7caad Move signal and property documentation inline, fix a problem with the
2007-11-25  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkdialog.c: Move signal and property documentation inline,
        fix a problem with the ::response signal docs.  (#499133, Josselin
        Mouette)


svn path=/trunk/; revision=19038
2007-11-25 05:40:49 +00:00
15:39:40 Tim Janik
2dc08ada49 call g_test_init() from gtk_test_init().
2007-11-22 15:39:40  Tim Janik  <timj@imendio.com>

        * gtk/gtktestutils.c: call g_test_init() from gtk_test_init().

        * gtk/tests/testing.c: use g_test_add_func() to register tests and use
	g_test_run() to run the tests to integrate with the testing framework.

        * gtk/tests/Makefile.am: removed exemplary testing rules.

        * Makefile.am, gtk/tests/Makefile.am, gtk/Makefile.am:
        * gtk/xdgmime/Makefile.am, gtk/theme-bits/Makefile.am:
        * tests/Makefile.am, docs/reference/gdk-pixbuf/Makefile.am:
        * docs/reference/gdk/Makefile.am, docs/reference/gtk/Makefile.am:
        * docs/reference/Makefile.am, docs/tools/Makefile.am:
        * docs/tutorial/Makefile.am, docs/faq/Makefile.am, docs/Makefile.am:
        * gdk-pixbuf/pixops/Makefile.am, gdk-pixbuf/Makefile.am:
        * demos/gtk-demo/Makefile.am, demos/Makefile.am:
        * modules/input/Makefile.am, modules/printbackends/file/Makefile.am:
        * modules/printbackends/test/Makefile.am, modules/printbackends/Makefile.am:
        * modules/printbackends/cups/Makefile.am, modules/printbackends/lpr/Makefile.am:
        * modules/engines/ms-windows/Theme/gtk-2.0/Makefile.am:
        * modules/engines/ms-windows/Theme/Makefile.am:
        * modules/engines/ms-windows/Makefile.am:
        * modules/engines/Makefile.am,  modules/engines/pixbuf/Makefile.am:
        * modules/Makefile.am, m4macros/Makefile.am, perf/Makefile.am:
        * contrib/Makefile.am, contrib/gdk-pixbuf-xlib/Makefile.am:
        * gdk/directfb/Makefile.am, gdk/linux-fb/Makefile.am:
        * gdk/quartz/Makefile.am, gdk/win32/rc/Makefile.am:
        * gdk/win32/Makefile.am, gdk/x11/Makefile.am, gdk/Makefile.am:
	include $(top_srcdir)/Makefile.decl, adapted EXTRA_DIST assignments.



svn path=/trunk/; revision=19033
2007-11-22 14:38:26 +00:00
Matthias Clasen
1ece9d4e40 Fix an aliasing problem. (#347585, Ed Catmur)
2007-11-22  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktextiter.c: Fix an aliasing problem.  (#347585, Ed Catmur)


svn path=/trunk/; revision=19024
2007-11-22 05:50:32 +00:00
Behdad Esfahbod
a64cba34e3 Make GtkMenuItem's arrow size themeable. (#469239, Michael Natterer)
2007-11-21  Behdad Esfahbod  <behdad@gnome.org>

        * gtk/gtkmenuitem.c (gtk_menu_item_class_init),
        (gtk_menu_item_paint): Make GtkMenuItem's arrow size themeable.
        (#469239, Michael Natterer)


svn path=/trunk/; revision=19020
2007-11-21 09:22:06 +00:00
Matthias Clasen
9116609354 Fix the default value of the toolbar-style property. (#489782, Jan Janech)
2007-11-21  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktoolbar.c: Fix the default value of the toolbar-style
        property.  (#489782, Jan Janech)



svn path=/trunk/; revision=19018
2007-11-21 05:49:35 +00:00
Matthias Clasen
11a88edb28 Avoid drawing one too many frames. (#107398, Owen Taylor, Miguel Gomez)
2007-11-20  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkimage.c (animation_timeout): Avoid drawing one too many
        frames.  (#107398, Owen Taylor, Miguel Gomez)


svn path=/trunk/; revision=19017
2007-11-21 04:56:50 +00:00
Tim Janik
40695ee368 Fixed copyright for newly submitted files.
svn path=/trunk/; revision=19014
2007-11-20 17:44:06 +00:00
Tim Janik
4f7a2da8e8 Moved Gdk test functions from Gtk+ to Gdk test utils.
* gdk/Makefile.am: added gdktestutils.h to public includes.

* gdk/gdk.h: added gdktestutils.h to public includes.

* gdk/gdk.symbols: added gdk_test_simulate_button, gdk_test_simulate_key,
gdk_test_render_sync.

* gdk/gdktestutils.h: new file, added prototypes for gdk_test_simulate_button,
gdk_test_simulate_key, gdk_test_render_sync.

* gdk/x11/Makefile.am: build gdktestutils-x11.c.

* gdk/x11/gdktestutils-x11.c: implemented gdk_test_simulate_button,
gdk_test_simulate_key, gdk_test_render_sync.

* gtk/gtktestutils.c:
* gtk/gtktestutils.h:
* gtk/gtk.symbols: removed gtk_test_simulate_button
gtk_test_simulate_key, gtk_test_xserver_render_sync.

* gtk/tests/testing.c: call gdk_test_render_sync.

svn path=/trunk/; revision=19012
2007-11-20 15:03:31 +00:00
Tim Janik
3cf208ef5e Added unit tests for Gtk+ testing utilities.
* gtk/tests/testing.c: added a sample test program that tests Gtk+ test
utility functions. some g_test_* related portions are disabled and need
to be enabled once Gtk+ depends on a new glib with the GLib testing
framework integrated.

* gtk/tests/Makefile.am: new subdirectory to include quick Gtk+ tests.
added exemplary test rules to run tests inside Xvfb. this needs to depend
on gtester for full fledged testing.

* gtk/Makefile.am: build gtk+/gtk/tests, define -DGTK_ENABLE_BROKEN when
collecting _get_type functions to catch e.g. gtk_text_get_type().

* configure.in: create gtk/tests/Makefile.in and gtk/tests/Makefile.

svn path=/trunk/; revision=19011
2007-11-20 15:03:28 +00:00
Tim Janik
936d27a475 Added Gtk+ testing utilities.
* gtk/gtktestutils.h, gtk/gtktestutils.c: added unit test utility functions.
for the most part, the functions herein involve navigating and interacting
with dialog elements programatically, to automate user interaction tests of
dialogs and widgets.

* gtk/gtk.h: include gtk/gtktestutils.h as public API.

* gtk/gtk.symbols: added gtk_test_* symbols.

* gtk/Makefile.am: include gtktestutils.h and gtktestutils.c into the build.
generate gtktypefuncs.c which contains a list of all _get_type functions in
Gtk+ and Gdk.

svn path=/trunk/; revision=19010
2007-11-20 15:03:26 +00:00
Matthias Clasen
e888b75e1b Fix the GtkBuildable implementation to allow setting column types.
2007-11-19  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktreestore.c: Fix the GtkBuildable implementation
        to allow setting column types.  (#496795, James Stephenson)



svn path=/trunk/; revision=19001
2007-11-19 05:47:36 +00:00
Matthias Clasen
5f4e93fe0a Make gtk_check_version() return const. (#496734, Nicolas Joseph)
2007-11-19  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkmain.[hc]: Make gtk_check_version() return const.
        (#496734, Nicolas Joseph)



svn path=/trunk/; revision=19000
2007-11-19 05:34:19 +00:00
Matthias Clasen
0add6313d3 Correct docs for program-name property. (#496689, Thomas Wood)
2007-11-19  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkaboutdialog.c: Correct docs for program-name property.
        (#496689, Thomas Wood)



svn path=/trunk/; revision=18999
2007-11-19 05:28:28 +00:00
Paolo Borelli
540569dadb Use gtk_text_buffer_get_insert instead of get_mark. Fixes Bug 497164.
2007-11-17  Paolo Borelli  <pborelli@katamail.com>

	* gtk/gtktextbuffer.c:
	* gtk/gtktextlayout.c:
	* gtk/gtktextview.c:
	Use gtk_text_buffer_get_insert instead of get_mark. Fixes Bug 497164.


svn path=/trunk/; revision=18997
2007-11-17 10:18:13 +00:00
Yevgen Muntyan
abad58b003 new functions _gtk_text_btree_get_insert() and
2007-11-15  Yevgen Muntyan  <muntyan@tamu.edu>

	* gtk/gtktextbtree.h:
	* gtk/gtktextbtree.c: new functions _gtk_text_btree_get_insert()
	and _gtk_text_btree_get_selection_bound() (#497102).
	* gtk/gtktextbuffer.c (gtk_text_buffer_get_insert),
	(gtk_text_buffer_get_selection_bound): use them here instead of
	hash table lookup.


svn path=/trunk/; revision=18996
2007-11-15 17:03:09 +00:00
Yevgen Muntyan
921da326f5 sort returned tags array by tags priority (#497102).
2007-11-15  Yevgen Muntyan  <muntyan@tamu.edu>

	* gtk/gtktextbtree.c (_gtk_text_btree_get_tags): sort returned
	tags array by tags priority (#497102).
	* gtk/gtktextiter.c (gtk_text_iter_get_tags), (gtk_text_iter_get_attributes):
	* gtk/gtktextlayout.c (get_tags_array_at_iter): and do not sort it here.


svn path=/trunk/; revision=18995
2007-11-15 17:00:33 +00:00
Yevgen Muntyan
a3eb6a98d7 do not call _gtk_text_btree_get_iter_at_line() and
2007-11-15  Yevgen Muntyan  <muntyan@tamu.edu>

	* gtk/gtktextlayout.c: (gtk_text_layout_get_line_display),
	(get_style): do not call _gtk_text_btree_get_iter_at_line() and
	_gtk_text_btree_get_tags() for every segment, instead call them
	once and then collect the tags while iterating over the segments.
	(get_tags_array_at_iter), (tags_array_toggle_tag): new functions
	for tags array handling.


svn path=/trunk/; revision=18994
2007-11-15 16:24:42 +00:00
Michael Natterer
65ef21dfb3 remove recently added gdk_flush() again, it's not needed after all.
2007-11-14  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkmenu.c (gtk_menu_popup): remove recently added
	gdk_flush() again, it's not needed after all.


svn path=/trunk/; revision=18991
2007-11-14 10:09:44 +00:00
Michael Natterer
24a6e04cb2 cast pointers to fix warnings about signdness.
2007-11-14  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkstyle.c (gtk_default_draw_focus): cast pointers to fix
	warnings about signdness.


svn path=/trunk/; revision=18988
2007-11-14 09:45:14 +00:00
Yevgen Muntyan
c9371f873b Moved gtk_text_view_update_im_spot_location() calls into an idle, fixes
2007-11-11  Yevgen Muntyan  <muntyan@tamu.edu>

	* gtk/gtktextview.c: Moved gtk_text_view_update_im_spot_location()
	calls into an idle, fixes #494776.
	GtkTextViewPrivate:im_spot_idle, do_update_im_spot_location(),
	queue_update_im_spot_location(), flush_update_im_spot_location(): new
	field and functions to queue the call;
	(changed_handler): call queue_update_im_spot_location() instead of
	gtk_text_view_update_im_spot_location();
	(gtk_text_view_key_press_event): flush the idle here.


svn path=/trunk/; revision=18984
2007-11-11 19:07:27 +00:00
Ryan Lortie
d65049378b Convert delayed_properties hashtable to linked list. Fixes #495769.
2007-11-10  Ryan Lortie  <desrt@desrt.ca>

        * gtk/gtkbuilder.c: Convert delayed_properties hashtable to linked
        list.  Fixes #495769.


svn path=/trunk/; revision=18983
2007-11-11 18:06:11 +00:00
Matthias Clasen
464ae98495 Leak less in error paths
svn path=/trunk/; revision=18980
2007-11-10 23:57:32 +00:00
Matthias Clasen
06d28ff884 Don't leak buffer if an error occurs.
2007-11-10  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkbuilder.c (gtk_builder_add_from_file): Don't
        leak buffer if an error occurs.



svn path=/trunk/; revision=18979
2007-11-10 05:03:10 +00:00
Matthias Clasen
6665188687 More robustness improvements of the parser
svn path=/trunk/; revision=18978
2007-11-10 04:50:15 +00:00
Matthias Clasen
f489387039 Don't assert on misplaced signal elements
svn path=/trunk/; revision=18977
2007-11-10 04:15:44 +00:00
Matthias Clasen
c3fcd42eda Handle misplaced property elements without asserting.
2007-11-09  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkbuilderparser.c (parse_property): Handle misplaced
        property elements without asserting.


svn path=/trunk/; revision=18976
2007-11-10 02:36:56 +00:00
Matthias Clasen
b2ad97dd38 Stylistic fixes
svn path=/trunk/; revision=18974
2007-11-09 16:56:17 +00:00
Matthias Clasen
fb4b0ddff7 don't leak 'filename' field memory when loading more than one file into
2007-11-08  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkbuilder.c: don't leak 'filename' field memory when loading
        more than one file into the same GtkBuilder instance. Noticed by
        Ryan Lortie.


svn path=/trunk/; revision=18973
2007-11-09 00:33:45 +00:00
Michael Natterer
d5dca93c58 include <glib.h> instead of <glib/gmarkup.h>
2007-11-08  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkbuildable.h: include <glib.h> instead of <glib/gmarkup.h>


svn path=/trunk/; revision=18972
2007-11-08 12:30:01 +00:00
Matthias Clasen
a27a83c37c Forgotten file
svn path=/trunk/; revision=18971
2007-11-08 05:21:06 +00:00
Ryan Lortie
36605333d0 Add GString 'text' to the property info structure. Used to accumulate
2007-11-07  Ryan Lortie  <desrt@desrt.ca>

        * gtk/gtkbuilderprivate.h: Add GString 'text' to the property info
        structure.  Used to accumulate property text across multiple 'text'
        calls.

        * gtk/gtkbuilderparser.c: Instead of translating/copying text on each
        'text' call while in <property> accumulate the text until the end and
        do it all in one go.  This fixes handling of <!-- --> inside
        properties as well as <property/> cases.


svn path=/trunk/; revision=18970
2007-11-08 04:12:52 +00:00
Michael Natterer
9b3edbc319 call gdk_flush() after showing the menu so we can definitely grab on it.
2007-11-06  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkmenu.c (gtk_menu_popup): call gdk_flush() after showing
	the menu so we can definitely grab on it. Grab failure found by
	Xan Lopez.


svn path=/trunk/; revision=18969
2007-11-06 14:23:56 +00:00
Michael Natterer
f93e2db2a9 fixed docs.
2007-11-06  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkwidget.c (gtk_widget_keynav_failed): fixed docs.


svn path=/trunk/; revision=18968
2007-11-06 08:57:33 +00:00
Richard Hult
fd90de672b Fix bug #486369, by passing the selection info along when pasting.
2007-11-03  Richard Hult  <richard@imendio.com>

	* gtk/gtkclipboard-quartz.c: (clipboard_owner_destroyed),
	(gtk_clipboard_set_contents), (clipboard_unset): Fix bug #486369,
	by passing the selection info along when pasting.

svn path=/trunk/; revision=18965
2007-11-03 13:12:45 +00:00
Richard Hult
5cb6747339 Redo the fix for bug #492117, by adding a getter for the private drag
2007-11-01  Richard Hult  <richard@imendio.com>

	* gdk/quartz/GdkQuartzWindow.c:
	* gdk/quartz/GdkQuartzWindow.h:
	* gdk/quartz/gdkdnd-quartz.c:
	* gdk/quartz/gdkquartz.h:
	* gtk/gtkdnd-quartz.c: Redo the fix for bug #492117, by adding a
	getter for the private drag context info so we don't need to
	expose so much in the public quartz header file.

svn path=/trunk/; revision=18959
2007-11-01 08:45:30 +00:00
Emmanuele Bassi
b2f4e11df3 Chain up to the parent's finalize virtual function.
2007-10-30  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkbuilder.c (gtk_builder_finalize): Chain up to the
	parent's finalize virtual function.

svn path=/trunk/; revision=18952
2007-10-30 12:25:39 +00:00
Owen Taylor
5072e43bb2 Allow the ::delete-range handler to delete text after the text it was
2007-10-28  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtktextbuffer.c (gtk_text_buffer_delete_interactive): Allow
        the ::delete-range handler to delete text after the text it was
        explicitly asked to delete without confusing us as to whether
        we're currently on an editable or not-editable segment.
        (#491207)

svn path=/trunk/; revision=18951
2007-10-28 22:27:15 +00:00
Owen Taylor
00481dd67c Pay attention to tags that turn invisibility off as well as tags that turn
2007-10-26  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtktextbtree.c (_gtk_text_btree_char_is_invisible):
        Pay attention to tags that turn invisibility off as well
        as tags that turn invsibility on. (#488051, Mathias Hasselmann)

svn path=/trunk/; revision=18949
2007-10-26 14:02:06 +00:00
Johan Dahlin
949d340659 Improve gtk_builder_get_type_from_name() documentation. (#461222, Murray
2007-10-24  Johan Dahlin  <jdahlin@async.com.br>

	* gtk/gtkbuilder.c: Improve gtk_builder_get_type_from_name()
	documentation. (#461222, Murray Cumming)


svn path=/trunk/; revision=18948
2007-10-24 18:24:44 +00:00
Johan Dahlin
de5463131e Give up instead of raising an error if we can't find the parent dialog
2007-10-24  Johan Dahlin  <jdahlin@async.com.br>

	* gtk/gtk-builder-convert 
	(GtkBuilderConverter._convert_dialog_response): 
	Give up instead of raising an error if we can't find
	the parent dialog when converting response ids.
	(#479463, Priyank)


svn path=/trunk/; revision=18945
2007-10-24 11:52:56 +00:00
Johan Dahlin
fa13277655 Parse signals after <child> tags and add tests. (#468793, Benjamin Otte)
2007-10-24  Johan Dahlin  <jdahlin@async.com.br>

	* gtk/gtkbuilder.c: (_gtk_builder_construct),
	(_gtk_builder_add_signals):
	* gtk/gtkbuilderparser.c: (end_element):
	* gtk/gtkbuilderprivate.h:
	* tests/buildertest.c: (test_connect_signals):

	Parse signals after <child> tags and add tests.
	(#468793, Benjamin Otte)


svn path=/trunk/; revision=18944
2007-10-24 11:48:17 +00:00
Johan Dahlin
1d332bbb44 Allow empty property nodes so we can set empty strings. (#486420, Xavier
2007-10-24  Johan Dahlin  <jdahlin@async.com.br>

	* gtk/gtkbuilderparser.c (end_element): Allow empty property nodes
	so we can set empty strings. (#486420, Xavier Claessens)


svn path=/trunk/; revision=18943
2007-10-24 09:46:31 +00:00
Richard Hult
e4849ff2b7 Handle NSFilenamesPboardType in addition to NSURLPboardType to support dnd
2007-10-23  Richard Hult  <richard@imendio.com>

	* gtk/gtkquartz.c:
	(_gtk_quartz_get_selection_data_from_pasteboard): Handle
	NSFilenamesPboardType in addition to NSURLPboardType to support
	dnd with multiple files from Finder, based on patch from Paul
	Davis (bug #467490).

svn path=/trunk/; revision=18941
2007-10-23 19:07:32 +00:00
Johan Dahlin
1f36660d8d Use gtk_ascii_tolower/toupper instead of the C library variants. (#488918,
2007-10-22  Johan Dahlin  <jdahlin@async.com.br>

	* gtk/gtkbuilder.c: Use gtk_ascii_tolower/toupper instead of the C 
	library variants. (#488918, Sertaç Ö. Yıldız)


svn path=/trunk/; revision=18939
2007-10-22 09:15:50 +00:00
Owen Taylor
e6572dfb95 Move -Wl,-luuid to LDFLAGS to make libtool happy.
2007-10-17  Owen Taylor  <otaylor@redhat.com>

        * gtk/Makefile.am (libgtk_win32_2_0_la_LDFLAGS): Move -Wl,-luuid
        to LDFLAGS to make libtool happy.

svn path=/trunk/; revision=18928
2007-10-17 18:39:09 +00:00
Tor Lillqvist
5c6180b9a0 Use -Wl,-luuid instead of -luuid to work around libtool lossage.
2007-10-17  Tor Lillqvist  <tml@novell.com>

	* gtk/Makefile.am (libgtk_win32_2_0_la_LIBADD): Use -Wl,-luuid
	instead of -luuid to work around libtool lossage.


svn path=/trunk/; revision=18927
2007-10-17 16:30:17 +00:00
Matthias Clasen
b7f048b18c 2.12.1
svn path=/trunk/; revision=18924
2007-10-17 05:05:49 +00:00
Matthias Clasen
bf7db03224 Update the doc
svn path=/trunk/; revision=18920
2007-10-17 03:24:28 +00:00
Matthias Clasen
9bfea332aa Update the docs for the ::text-column property. (#352643, Josselin
2007-10-16  Matthias Clasen <mclasen@redhat.com>

        * gtk/gtkentrycompletion.c: Update the docs for the
        ::text-column property.  (#352643, Josselin Mouette)



svn path=/trunk/; revision=18919
2007-10-17 03:09:12 +00:00
Yevgen Muntyan
49b516bb4b Fixed typo in icon_size_lookup_intern() - colon instead of semicolon
svn path=/trunk/; revision=18917
2007-10-16 22:35:26 +00:00
Matthias Clasen
892d287fa3 Be more careful when handling (GtkIconSize)-1. (#456137, Harry Lu, Chris
2007-10-16  Matthias Clasen <mclasen@redhat.com>

        * gkt/gtkiconsize.c: Be more careful when handling
        (GtkIconSize)-1.  (#456137, Harry Lu, Chris Wang, et al)



svn path=/trunk/; revision=18916
2007-10-16 20:08:31 +00:00
Matthias Clasen
6abe62c95b Improve the docs. (#486155, Owen Taylor)
2007-10-16  Matthias Clasen <mclasen@redhat.com>

        * gtk/gtktextiter.c (gtk_text_iter_forward_line): Improve
        the docs.  (#486155, Owen Taylor)



svn path=/trunk/; revision=18914
2007-10-16 17:33:16 +00:00
Matthias Clasen
a07873dd16 Actually use the utf-8 version of the filename. (#485301, Takao Fujiwara)
2007-10-16  Matthias Clasen <mclasen@redhat.com>

        * gtk/gtkprinteroptionwidget.c (update_widgets): Actually use
        the utf-8 version of the filename.  (#485301, Takao Fujiwara)


svn path=/trunk/; revision=18912
2007-10-16 17:25:55 +00:00
Loïc Minier
3671b2bbe9 Fix "cannot open display" error message when display is set by the DISPLAY
2007-10-15  Loïc Minier  <lool@dooz.org>

        * gtk/gtkmain.c: (gtk_init): Fix "cannot open display" error message
        when display is set by the DISPLAY env var. (#486636, Mike Hommey)

svn path=/trunk/; revision=18909
2007-10-15 13:26:34 +00:00
Johan Dahlin
48a704da48 signal_name instead of signal. (#486360, Xavier Claessens)
2007-10-13  Johan Dahlin  <jdahlin@async.com.br>

	* gtk/gtk-builder-convert 
	(GtkBuilderConverter._add_action_from_menuitem): signal_name instead
	of signal. (#486360, Xavier Claessens)


svn path=/trunk/; revision=18907
2007-10-13 18:07:32 +00:00
Matthias Clasen
030529e04b Avoid double-free problems
svn path=/trunk/; revision=18906
2007-10-12 04:31:04 +00:00
Emmanuele Bassi
3ca1e0cd2d Document that you need to unref the returned GdkPixbuf. (#484132,
2007-10-10  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentmanager.c (gtk_recent_info_get_icon): Document
	that you need to unref the returned GdkPixbuf. (#484132,
	Christian Persch)

	(build_recent_info): Use g_slist_prepend() when building
	the applications list.

svn path=/trunk/; revision=18904
2007-10-10 09:31:36 +00:00
Emmanuele Bassi
2ad0ef4632 Convert the format to the current locale before passing it to strtime().
2007-10-10  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkfilechooserdefault.c (list_mtime_data_func): Convert
	the format to the current locale before passing it to
	strtime(). Fixes corrupt dates with non-UTF8 encodings on
	OpenSolaris. (#465380, Takao Fujiwara)

svn path=/trunk/; revision=18903
2007-10-10 08:09:13 +00:00
Emmanuele Bassi
928db3a71b Fix the time_t typecasting on OpenSolaris. (#465380, Takao Fujiwara)
2007-10-10  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkfilechooserdefault.c (list_mtime_data_func): Fix the
	time_t typecasting on OpenSolaris. (#465380, Takao Fujiwara)

svn path=/trunk/; revision=18902
2007-10-10 08:02:16 +00:00
Kristian Rietveld
18b264b5e0 make sure the new cursor node is visible when we are done. (Fixes #472965,
2007-10-09  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down): make
	sure the new cursor node is visible when we are done. (Fixes #472965,
	Carlos Garnacho).


svn path=/trunk/; revision=18899
2007-10-09 19:40:14 +00:00
Kristian Rietveld
449db79467 we should only "don't move the cursor, but just select the current node"
2007-10-09  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktreeview.c (gtk_tree_view_move_cursor_up_down): we should
	only "don't move the cursor, but just select the current node" if the
	cursor node is actually selectable.  (Fixes #483730, reported by
	Geoff Bache).


svn path=/trunk/; revision=18898
2007-10-09 17:08:18 +00:00
Kristian Rietveld
94680cbffc don't "corrupt" all iterators by reversing the list after adding the
2007-10-08  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtkfilesystemmodel.c (got_root_folder_cb),
	(get_children_get_folder_cb): don't "corrupt" all iterators by
	reversing the list after adding the items.  Reversing the list isn't
	needed anyway as the order of the items in the model does not matter.
	(Fixes #327243, comment 10).


svn path=/trunk/; revision=18891
2007-10-08 12:44:35 +00:00
Kristian Rietveld
aed59b3ea9 Fix #482841, patch by Karl Tomlinson.
2007-10-08  Kristian Rietveld  <kris@imendio.com>

	Fix #482841, patch by Karl Tomlinson.

	* gtk/gtktooltip.c (gtk_tooltip_display_closed): use g_object_set_data
	instead of g_object_set ...
	(_gtk_tooltip_toggle_keyboard_mode),
	(_gtk_tooltip_handle_event): connect to GdkDisplay::closed after
	creating tooltip.


svn path=/trunk/; revision=18890
2007-10-08 12:39:02 +00:00
Murray Cumming
5d1a5ac216 Revert the change on 2007-04-29 (Also check the default handler when
2007-10-05  Murray Cumming  <murrayc@murrayc.com>

* gtk/gtkprintoperation.c: (print_pages_idle):
Revert the change on 2007-04-29 (Also check
the default handler when deciding whether to emit the
paginate signal.  (#345345, Yevgen Muntyan)).
This stopped printing from working in gtkmm, and is apparently 
not appropriate anyway. Bug #482089.

svn path=/trunk/; revision=18885
2007-10-05 08:18:43 +00:00
Hiroyuki Ikezoe
31f26042f7 Use g_object_ref() instead of gtk_widget_ref(). (#483563)
2007-10-05  Hiroyuki Ikezoe  <poincare@ikezoe.net>

	* gtk/gtkdnd.c: Use g_object_ref() instead of gtk_widget_ref().
	(#483563)


svn path=/trunk/; revision=18884
2007-10-05 03:08:55 +00:00
Emmanuele Bassi
43f5b189b7 Iterate on the proxies we hold when we change the sorting function and the
2007-10-04  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentaction.c:
	(gtk_recent_action_set_sort_func), (set_current_filter): Iterate
	on the proxies we hold when we change the sorting function and
	the filter.

	(gtk_recent_action_connect_proxy),
	(gtk_recent_action_create_menu): Set the GtkRecentChooser:filter
	property when we create/connect a proxy chooser. Thanks to
	Jonh Wendell for pointing this bug out on gtk-list.

	(gtk_recent_chooser_set_property): Bail out without iterating
	over the proxies when there's no need to.

svn path=/trunk/; revision=18883
2007-10-04 22:52:13 +00:00
Matthias Clasen
0afe895ad2 Add a second volume button.
2007-10-04  Matthias Clasen  <mclasen@redhat.com>

        * tests/testvolumebutton.c: Add a second volume button.

        * gtk/gtkscalebutton.c: Doh, don't release grabs we don't hold.
        (#478371, reported by Bill Nottingham)


svn path=/trunk/; revision=18881
2007-10-04 12:52:46 +00:00
Loïc Minier
618c8de221 Fix warnings and display of modified date / time in filechooser for some
2007-10-04  Loïc Minier  <lool@dooz.org>

       * gtk/gtkfilechooserdefault.c: (list_mtime_data_func): Fix warnings
       and display of modified date / time in filechooser for some locales as
       it was missing a locale to UTF-8 conversion. Fixes #482504.

svn path=/trunk/; revision=18880
2007-10-04 07:40:55 +00:00
Xan Lopez
1cea708e5e remove duplicated declaration of gtk_notebook_create_window. Patch by
2007-10-03  Xan Lopez  <xan@gnome.org>

	* gtk/gtknotebook.c: remove duplicated declaration of
	gtk_notebook_create_window. Patch by Hiroyuki Ikezoe (#482837)

svn path=/trunk/; revision=18878
2007-10-03 19:49:40 +00:00
Federico Mena Quintero
721eb57a22 455284 - Focus or toggle location entry
2007-10-02  Federico Mena Quintero  <federico@novell.com>

	Fix http://bugzilla.gnome.org/show_bug.cgi?id=455284 - In the file
	chooser, Ctrl-L should switch to the location entry.  If we are
	already on the location entry, turn it off.  Based on a patch by
	Jaap A. Haitsma <jaap@haitsma.org> and an idea by Wouter
	Bolsterlee.

	* gtk/gtkfilechooserdefault.c (location_button_toggled_cb): Call
	location_mode_set() directly instead of using toggle_location_mode().
	(toggle_location_mode): Removed.
	(location_toggle_popup_handler): If the file entry is not visible,
	show it.  If it is visible, turn it off only if it is focused.
	Otherwise, switch to the entry.

Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=18874
2007-10-02 15:50:27 +00:00
Kristian Rietveld
6e3df276df fix up if-condition to only set the true arrow type if show_sort_indicator
2007-10-01  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_update_button):
	fix up if-condition to only set the true arrow type if
	show_sort_indicator is TRUE.  (#448343, reported by Emil Nowak).


svn path=/trunk/; revision=18871
2007-10-01 09:04:57 +00:00
Emmanuele Bassi
7421a81f67 Fixes for bug #480123.
2007-09-25  Emmanuele Bassi  <ebassi@gnome.org>

	Fixes for bug #480123.

	* gtk/gtksearchenginesimple.c:
	(gtk_search_engine_simple_dispose), (search_thread_done_idle): Cancel
	the file tree walking thread when disposing the search engine
	implementation.

	* gtk/gtkfilechooserdefault.c (search_stop_searching): Forcibly
	stop the search engine implementation when stopping the search,
	instead of just unreffing the object.

svn path=/trunk/; revision=18865
2007-09-25 20:59:15 +00:00
Kristian Rietveld
37c5790a7f add extra NULL check for tooltipsdata to avoid code fiddling with
2007-09-24  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktooltips.c (gtk_tooltips_set_tip): add extra NULL check
	for tooltipsdata to avoid code fiddling with active_tips_data
	from crashing.  (Fixes #460194, Peter Wright, Matthijs De Smedt).


svn path=/trunk/; revision=18864
2007-09-24 18:23:01 +00:00
Tor Lillqvist
9e0fabe081 Set the GtkWin32EmbedWidget we create here as modal. Fixes #389358.
2007-09-24  Tor Lillqvist  <tml@novell.com>

	* gtk/gtkprintoperation-win32.c (pageDlgProc): Set the
	GtkWin32EmbedWidget we create here as modal. Fixes #389358.


svn path=/trunk/; revision=18860
2007-09-24 13:45:40 +00:00
Manish Singh
0983017630 gtk/gtkstyle.c (option_menu_get_props) use gtk_requisition_free() instead
2007-09-21  Manish Singh  <yosh@gimp.org>

        * gtk/gtkstyle.c (option_menu_get_props)
        * gtk/gtkoptionmenu.c (gtk_option_menu_get_props): use
        gtk_requisition_free() instead of g_free() for freeing
        requisitions.

svn path=/trunk/; revision=18855
2007-09-21 21:14:56 +00:00
Matthias Clasen
b0cc27c30b Some more fixed to prevent segfaults with missing or nonsensical ranges.
2007-09-21  Matthias Clasen <mclasen@redhat.com>

        * gtk/gtkprintoperation.c (print_pages_idle): Some more
        fixed to prevent segfaults with missing or nonsensical ranges.


svn path=/trunk/; revision=18854
2007-09-21 15:38:29 +00:00
Jean Brefort
e7131b2f91 abort printing when the range is NULL. (#478803)
2007-09-21  Jean Brefort  <jean.brefort@normalesup.org>

	* gtk/gtkprintoperation.c: (print_pages_idle): abort printing 
	when the range is NULL. (#478803)


svn path=/trunk/; revision=18853
2007-09-21 14:50:06 +00:00
Michael Natterer
86994b49d3 merged patch from maemo-gtk which handles failed keynav correctly also
2007-09-21  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktextview.c (gtk_text_view_move_cursor_internal)
	(gtk_text_view_move_viewport): merged patch from maemo-gtk which
	handles failed keynav correctly also when the cursor is invisible.
	(Tommi Komulainen)


svn path=/trunk/; revision=18851
2007-09-21 14:29:08 +00:00
Matthias Clasen
4e5d3ecf07 Forgotten file
svn path=/trunk/; revision=18850
2007-09-21 14:19:19 +00:00
Matthias Clasen
763417b4c1 Remove trailing commas
svn path=/trunk/; revision=18849
2007-09-21 14:17:53 +00:00
Emmanuele Bassi
4c335374f2 Search libtrackerclient.so.0 as libtracker changed the shared library
2007-09-18  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtksearchenginetracker.c: Search libtrackerclient.so.0
	as libtracker changed the shared library name. (#478173,
	Michael Kuhn)

svn path=/trunk/; revision=18846
2007-09-18 21:48:01 +00:00
Hans Breuer
7f1bc40a84 svn path=/trunk/; revision=18842
svn path=/trunk/; revision=18842
2007-09-17 19:53:54 +00:00
Michael Natterer
95116d0f1c don't simply crash if any of the pointer args are NULL. Instead,
2007-09-15  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkselection.c (gtk_target_list_find): don't simply crash if
	any of the pointer args are NULL. Instead, g_return_if_fail() on
	"list != NULL" and allow to pass NULL as return location for "info".


svn path=/trunk/; revision=18831
2007-09-15 16:48:56 +00:00
Emmanuele Bassi
5e3d2bb65a Remove the warning for the "select-multiple" property getter. (#476686,
2007-09-14  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentaction.c:
	* gtk/gtkrecentchoosermenu.c: Remove the warning for the
	"select-multiple" property getter. (#476686, Christian Persch)

svn path=/trunk/; revision=18826
2007-09-14 09:51:34 +00:00
Michael Natterer
80640a0f8c no need to get the list of menubars twice.
2007-09-14  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkmenubar.c (remove_from_window): no need to get the list
	of menubars twice.

	Some minor stylistic and indentation fixes.


svn path=/trunk/; revision=18825
2007-09-14 09:17:59 +00:00
Matthias Clasen
5f8cd8b9fb Turn off icon cache validation by default
svn path=/trunk/; revision=18823
2007-09-14 02:11:01 +00:00
Matthias Clasen
bebbf23f22 2.12.0
svn path=/trunk/; revision=18820
2007-09-14 00:56:57 +00:00
Kristian Rietveld
ecefbe8403 the tooltip-column property getter needs to set an integer, not a boolean.
2007-09-14  Kristian Rietveld  <kris@gtk.org>

	* gtk/gtktreeview.c (gtk_tree_view_get_property): the tooltip-column
	property getter needs to set an integer, not a boolean. (#476689,
	spotted and patch by Christian Persch).


svn path=/trunk/; revision=18818
2007-09-13 22:39:47 +00:00
Kristian Rietveld
e523ba2ce8 implement getter for keycode property. (#476665, patch by Christian
2007-09-14  Kristian Rietveld  <kris@gtk.org>

	* gtk/gtkcellrendereraccel.c (gtk_cell_renderer_accel_get_property):
	implement getter for keycode property.  (#476665, patch by
	Christian Persch).


svn path=/trunk/; revision=18817
2007-09-13 22:37:02 +00:00
Matthias Clasen
e297090fa7 Fix the value type
svn path=/trunk/; revision=18816
2007-09-13 21:25:48 +00:00
Kristian Rietveld
bd24768db6 if cell is set, always pass in path to gtk_tree_view_get_cell_area()
2007-09-13  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktreeview.c (gtk_tree_view_set_toooltip_cell): if cell
	is set, always pass in path to gtk_tree_view_get_cell_area() whether
	it is NULL or set.  Added explanatory comment and added this
	side case to the API documentation.


svn path=/trunk/; revision=18812
2007-09-13 14:15:40 +00:00
Emmanuele Bassi
e299a72a49 Use the "document-open-recent" icon for the the Recently Used shortcut in
2007-09-12  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkfilechooserdefault.c (render_recent_icon): Use the
	"document-open-recent" icon for the the Recently Used shortcut
	in the file chooser. (#306445)

	* gtk/Makefile.am:
	* gtk/stock-icons/16/document-open-recent.png:
	* gtk/stock-icons/16/document-open-recent.svg:
	* gtk/stock-icons/24/document-open-recent.png:
	* gtk/stock-icons/24/document-open-recent.svg: Add the
	"document-open-recent" icon to the builtin theme we provide
	as a fallback.

svn path=/trunk/; revision=18803
2007-09-12 18:00:30 +00:00
Kristian Rietveld
eab3ef3145 Fixes #426246.
2007-09-12  Kristian Rietveld  <kris@imendio.com>

	Fixes #426246.

	* gdk/gdk.symbols:
	* gdk/gdkwindow.[ch]
	(gdk_window_freeze_toplevel_updates_libgtk_only),
	(gdk_window_thaw_toplevel_updates_libgtk_only): new functions
	to freeze a toplevel window and all its descendants.  To be made
	public in 2.14,
	(gdk_window_schedule_update): return if toplevel is frozen,
	(gdk_window_process_all_updates): defer processing updates if toplevel
	is frozen.

	* gtk/gtkwindow.c (gtk_window_configure_event): directly size
	allocate for override redirect windows, freeze toplevel and
	descendants otherwise and wait until resizing is done.


svn path=/trunk/; revision=18802
2007-09-12 17:13:24 +00:00
Michael Natterer
a5bebb2e7b remove useless member "has_title" from the private struct and simply set
2007-09-11  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkfilechooserbutton.c: remove useless member "has_title"
	from the private struct and simply set the default title in
	constructor() whenever we create a dialog or the supplied one has
	no title. Also accept RESPONSE_ACCEPT *and* RESPONSE_OK as
	affirmative responses and document that accordingly. Fixes bug
	#436576. Fixed all compiler warnings in the file.


svn path=/trunk/; revision=18796
2007-09-11 18:54:00 +00:00
Michael Natterer
7b6c536cc7 Make sure menu_shell->button gets reset to 0 when we bail out early here
2007-09-11  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkmenu.c (gtk_menu_button_release): Make sure
	menu_shell->button gets reset to 0 when we bail out early here
	instead of chaining up, so it is in a consistent state for the
	next press/release in GtkMenuShell. Fixes bug #449371.


svn path=/trunk/; revision=18795
2007-09-11 17:38:12 +00:00
Kjartan Maraas
a7bce8a3e9 Fix some typos. Closes bug #475400.
2007-09-10  Kjartan Maraas  <kmaraas@gnome.org>

	* gtk/gtkentry.c: Fix some typos. Closes bug #475400.

svn path=/trunk/; revision=18790
2007-09-10 21:58:20 +00:00
Richard Hult
9ee525e0f7 Build fix, correct a typo in the G_BEGIN_DECLS fix below.
2007-09-10  Richard Hult  <richard@imendio.com>

	* gtk/gtksearchenginesimple.h: Build fix, correct a typo in the
	G_BEGIN_DECLS fix below.

svn path=/trunk/; revision=18787
2007-09-10 17:19:49 +00:00
Matthias Clasen
7c4652f9af Fix a typo
svn path=/trunk/; revision=18786
2007-09-10 16:40:15 +00:00
Kristian Rietveld
6f9364eceb when creating a new box, be sure to transfer a possible tooltip from the
2007-09-10  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_construct_contents):
	when creating a new box, be sure to transfer a possible tooltip from
	the old to the new box. (Fixes #458283, reported by Christian Persch).


svn path=/trunk/; revision=18785
2007-09-10 12:46:23 +00:00
Kristian Rietveld
a6755f707b only start typeahead search if tree_view has focus (and not one of the
2007-09-10  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktreeview.c (gtk_tree_view_key_press): only start
	typeahead search if tree_view has focus (and not one of the column
	buttons).


svn path=/trunk/; revision=18779
2007-09-10 09:24:38 +00:00
Matthias Clasen
af6b614527 Remove update_idle here. Might fix #383003.
2007-09-09  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkdnd.c (gtk_drag_source_info_destroy): Remove
        update_idle here. Might fix #383003.



svn path=/trunk/; revision=18776
2007-09-10 03:16:13 +00:00
Matthias Clasen
14afc3345a Add a bounding box test that will avoid getting the individual cell boxes
2007-09-09  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkiconview.c (gtk_icon_view_item_hit_test): Add a
        bounding box test that will avoid getting the individual cell
        boxes if they haven't been calculated yet.  (#404541)



svn path=/trunk/; revision=18775
2007-09-10 00:43:58 +00:00
Matthias Clasen
a6b824d7a4 fix the build
svn path=/trunk/; revision=18774
2007-09-09 23:54:17 +00:00
Matthias Clasen
8fb6c039bb Update the documentation to mark the optional constructors parameters. The
2007-09-09  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkaction.c:
        * gtk/gtkradioaction.c:
        * gtk/gtkrecentaction.c:
        * gtk/gtktoggleaction.c: Update the documentation to mark
        the optional constructors parameters. The GtkAction::name
        property is required, instead, as it is used by GtkUIManager
        to find the action object from the XML. (#450032, Murray Cumming,
        patch by Emmanuele Bassi)



svn path=/trunk/; revision=18773
2007-09-09 20:18:24 +00:00
Matthias Clasen
29490c0448 Remove trailing commas from enumerations, since some compilers don't like
2007-09-09  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtklinkbutton.c:
        * gtk/gtkrecentfilter.c:
        * gtk/gtkprinteroptionwidget.c: Remove trailing commas from
        enumerations, since some compilers don't like them.  (#467717)



svn path=/trunk/; revision=18771
2007-09-09 20:08:31 +00:00
Matthias Clasen
5c4d0d697d Don't assume that a path of depth 0 has no indices. (#467324, Szilard
2007-09-09  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_rows_reordered):
        * gtk/gtktreemodelsort.c (gtk_tree_model_sort_rows_reordered): Don't
        assume that a path of depth 0 has no indices.  (#467324, Szilard
        Pfeiffer)



svn path=/trunk/; revision=18770
2007-09-09 19:48:22 +00:00
Kristian Rietveld
cc7e7db612 Reverted r16699:
2007-09-09  Kristian Rietveld  <kris@gtk.org>

	Reverted r16699:

	2006-10-30  Kristian Rietveld  <kris@gtk.org>

	* gtk/gtktreeview.c (gtk_tree_view_class_init): change left/right
	keybindings to collapse/expand rows instead of moving the focus
	cursor. (#105895, Brian Bober and others).


svn path=/trunk/; revision=18768
2007-09-09 15:17:43 +00:00
Matthias Clasen
18475a4aa3 Revert the clamping of cursor coordinates, since it causes really ugly
2007-09-08  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkstyle.c (draw_insertion_cursor): Revert the clamping
        of cursor coordinates, since it causes really ugly drawing
        artifacts with horizontal scrolling.  (#471215, Yevgen Muntyan)



svn path=/trunk/; revision=18765
2007-09-09 02:15:13 +00:00
Matthias Clasen
5067b99881 Apply a number of patches by Xan Lopez to improve the interaction between
2007-09-08  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkentrycompletion.c:
        * gtk/gtkentry.c: Apply a number of patches by Xan Lopez
        to improve the interaction between actions and inline
        selection.  (#471132)


svn path=/trunk/; revision=18761
2007-09-08 05:38:58 +00:00
Matthias Clasen
54139b8806 Use g_slice for ToolbarContent. (#474696, Christian Persch)
2007-09-07  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktoolbar.c: Use g_slice for ToolbarContent.
        (#474696, Christian Persch)
 

svn path=/trunk/; revision=18760
2007-09-08 05:23:12 +00:00
Matthias Clasen
1a869c046a Add an internal child name for the notebook, so that GtkBuilder can be
2007-09-07  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkprintunixdialog.c: Add an internal child name for
        the notebook, so that GtkBuilder can be used to add custom tabs.
        (#472951, Christian Persch)


svn path=/trunk/; revision=18757
2007-09-07 20:03:22 +00:00
Matthias Clasen
1e85985083 Don't use image->attach_points where image->n_attach_points was meant.
2007-09-07  Matthias Clasen  <mclasen@redhat.com>

        * gtk/updateiconcache.c (get_image_meta_data_size): Don't
        use image->attach_points where image->n_attach_points was meant.
        Pointed out by Albert Chin.


svn path=/trunk/; revision=18756
2007-09-07 19:57:33 +00:00
Kristian Rietveld
d719605dac implement missing get_cells method. (Spotted by Paolo Borelli).
2007-09-07  Kristian Rietveld  <kris@gtk.org>

	* gtk/gtkcombobox.c (gtk_combo_box_cell_layout_init),
	(gtk_combo_box_cell_layout_get_cells): implement missing get_cells
	method.  (Spotted by Paolo Borelli).


svn path=/trunk/; revision=18747
2007-09-07 11:02:04 +00:00
Matthias Clasen
b0c57a4b8f Initialize error to NULL before calling g_set_error(). Should fix #473954,
2007-09-06 Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkfilechooserdefault.c (shortcuts_drop_uris): Initialize
        error to NULL before calling g_set_error(). Should fix #473954,
        reported by Sebastien Bacher.

svn path=/trunk/; revision=18738
2007-09-06 19:15:37 +00:00
13:37:28 Tim Janik
fb0958f085 removed code that forced range repaints upon every motion event, because
2007-09-06 13:37:28  Tim Janik  <timj@imendio.com>

        * gtk/gtkrange.c (gtk_range_adjustment_value_changed): removed code
        that forced range repaints upon every motion event, because these tend
        to stall other repaints on busy CPUs.
        added a timer to still force repaints every once in a while (roughly
        5Hz atm) to avoid leaving the user without feedback on the range.
        fixes bug #460534.



svn path=/trunk/; revision=18730
2007-09-06 11:44:22 +00:00
Tim Janik
92ee6b3ae1 fix wrong default value in ::tab-expand param spec constructor.
Wed Sep  5 14:15:17 2007  Tim Janik  <timj@imendio.com>

        * gtk/gtknotebook.c (gtk_notebook_class_init): fix wrong default value
        in ::tab-expand param spec constructor.



svn path=/trunk/; revision=18725
2007-09-05 12:17:39 +00:00
Fernando Herrera
34cf2826d2 copy filename to builder->priv instead of holding a reference to it. Bug
2007-09-04  Fernando Herrera  <fherrera@onirica.com>

        * gtk/gtkbuilder.c: (gtk_builder_finalize),
        (gtk_builder_add_from_file): copy filename to builder->priv instead of
        holding a reference to it. Bug #472643


svn path=/trunk/; revision=18722
2007-09-04 12:36:24 +00:00
Johan Dahlin
c99040a4b3 Do not iterate recursively over all child nodes.
2007-09-04  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtk-builder-convert (GtkBuilder._packing_prop_to_child_attr):
    Do not iterate recursively over all child nodes.
    (GtkBuilderConverter._default_widget_converter): Use a more efficient
    way of iterating over all property nodes
    #472974 (Carlos Garnacho)


svn path=/trunk/; revision=18721
2007-09-04 12:19:37 +00:00
Michael Natterer
395c785512 added missing \n to g_print() in GTK_NOTE().
2007-09-04  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkmodules.c: added missing \n to g_print() in GTK_NOTE().


svn path=/trunk/; revision=18720
2007-09-04 12:04:07 +00:00
Johan Dahlin
0df0fe47d6 Do not remove empty properties, since we do not know the default
2007-09-04  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtk-builder-convert (GtkBuilderConverter._parse): Do not remove 
    empty properties, since we do not know the default GParamSpec values.
    #472981 (Carlos Garnacho)


svn path=/trunk/; revision=18719
2007-09-04 11:53:18 +00:00
Emmanuele Bassi
ba56e7dd57 Remove the stat() time barrier, as it seems to cause bug #463907 (thanks
2007-09-03  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentmanager.c
	(gtk_recent_manager_poll_timeout): Remove the stat() time barrier,
	as it seems to cause bug #463907 (thanks to Sebastien Bacher).

svn path=/trunk/; revision=18713
2007-09-03 09:49:59 +00:00
Kristian Rietveld
35cae8d92b lower the default timeout values for gtk-tooltip-timeout and
2007-08-29  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtksettings.c: lower the default timeout values for
	gtk-tooltip-timeout and gtk-tooltip-browse-timeout. (#451202,
	Richard Hult).


svn path=/trunk/; revision=18701
2007-08-29 12:01:15 +00:00
Stefan Kost
bf4b559a31 Update menu accelerators, when adding/removing AccelGroups dynamically.
* gtk/gtkwindow.c: Update menu accelerators, when adding/removing
	AccelGroups dynamically. (#469374)


svn path=/trunk/; revision=18691
2007-08-27 17:46:53 +00:00
Cody Russell
9c24a3dbd9 Use the correct type check on `window'. We now check GTK_IS_WINDOW rather
2007-08-23  Cody Russell  <bratsche@gnome.org>
        * gtk/gtkwindow.c (gtk_window_group_remove_window: Use the
        correct type check on `window'.  We now check GTK_IS_WINDOW
        rather than GTK_IS_WIDGET. (#461483, Josselin Mouette)


svn path=/trunk/; revision=18681
2007-08-23 16:00:10 +00:00
Jan Arne Petersen
d18eaf32dd Duplicate the string returned by d[n]gettext before it is potentially
2007-08-23  Jan Arne Petersen  <jpetersen@jpetersen.org>

	* gtk/gtkbuilderparser.c: (text): Duplicate the string returned by
	d[n]gettext before it is potentially freed. (#461945)


svn path=/trunk/; revision=18678
2007-08-23 15:29:59 +00:00
Emmanuele Bassi
a35bd52a96 Check if we are still holding the model before updating it; removes a set
2007-08-23  Emmanuele Bassi  <ebassi@gnome.org>

	* gtkfilechooserdefault.c:
	(search_hit_get_info_cb), (recent_item_get_info_cb): Check if
	we are still holding the model before updating it; removes a
	set of critical warnings when switching to the browse mode from
	a loading search or recent files list.

	(recent_clear_model), (recent_sort_model),
	(recent_idle_cleanup): When in recent files mode, set the
	model for the files list view when we have completed the loading
	of the recently used files list. This makes switching between
	modes fast again and reduces the amount of redraws needed
	to display the list. (#469214)

svn path=/trunk/; revision=18677
2007-08-23 10:48:28 +00:00
Kristian Rietveld
31fc4289c7 Do not allow the cursor to go to a separator row. Fixes #441219, modified
2007-08-22  Kristian Rietveld  <kris@imendio.com>

	Do not allow the cursor to go to a separator row.  Fixes #441219,
	modified patch by Carlos Garnacho.

	* gtk/gtktreeview.c (row_is_separator): new inline function
	for calling the row-separator-func, made all of gtktreeview.c use
	this function instead of calling the func themselves,
	(gtk_tree_view_button_press): treat a click on a separator like
	a click on empty space,
	(gtk_tree_view_update_rubber_band_selection_rage): skip
	non-selectable rows,
	(search_first_focusable_path),
	(gtk_tree_view_focus_to_cursor),
	(gtk_tree_view_move_cursor_up_down),
	(gtk_tree_view_move_cursor_page_up_down),
	(gtk_tree_view_move_cursor_start_end): skip separators,
	(gtk_tree_view_real_set_cursor): do not allow setting the cursor
	on a separator.


svn path=/trunk/; revision=18672
2007-08-22 14:26:32 +00:00
Tristan Van Berkom
0f9230d30a Corrected the published default value of GtkFrame::label-xalign (bug
* gtk/gtkframe.c: Corrected the published default value of
	GtkFrame::label-xalign (bug 460272).


svn path=/trunk/; revision=18671
2007-08-22 13:41:32 +00:00
Kristian Rietveld
7adde1e4fd update alignment padding after theme changes. (Fixes #467003, patch by
2007-08-21  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktooltip.c (gtk_tooltip_init),
	(gtk_tooltip_window_style_set): update alignment padding after
	theme changes. (Fixes #467003, patch by Benjamin Berg).


svn path=/trunk/; revision=18667
2007-08-21 13:13:42 +00:00
Kristian Rietveld
ef1da5f6c2 always set hide_tooltip to TRUE if we are handling a leave notify event.
2007-08-21  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktooltip.c (_gtk_tooltip_handle_event): always set
	hide_tooltip to TRUE if we are handling a leave notify event. (Fixes
	#468245, reported by Dennis Jacobfeuerborn).


svn path=/trunk/; revision=18666
2007-08-21 11:09:42 +00:00
Michael Natterer
183a3276ff applied patch from Mikael Hallendal which documents GtkPaned's keybinding
2007-08-21  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkpaned.c (gtk_paned_class_init): applied patch from Mikael
	Hallendal which documents GtkPaned's keybinding signals (#467117).


svn path=/trunk/; revision=18664
2007-08-21 11:00:56 +00:00
Kristian Rietveld
f6235caef9 Fix #457642, reported by Christian Persch.
2007-08-21  Kristian Rietveld  <kris@imendio.com>

	Fix #457642, reported by Christian Persch.

	* gtk/gtktooltip.c: added debugging output which can be compiled
	in with a #define, annotated all coordinate translations in the
	source code,
	(find_widget_under_pointer): remove the "no-window correction";
	always convert the coordinates from window relative to allocation
	relative; after recursing through a container, translate the
	coordinates from container allocation relative to child widget
	allocation relative;
	(find_topmost_widget_from_event): now we get allocation relative
	coordinates here we do not have to distinguish no-window and window
	widgets.


svn path=/trunk/; revision=18663
2007-08-21 10:52:43 +00:00
Cody Russell
72528aba5f Fixed incorrect compose mapping for capital U with macron. (#468055, Aaron
2007-08-18  Cody Russell  <bratsche@gnome.org>

        * gtk/gtkimcontextsimple.c: Fixed incorrect compose mapping
        for capital U with macron. (#468055, Aaron Crane)


svn path=/trunk/; revision=18651
2007-08-19 04:41:09 +00:00
Tim Janik
fda0eb309b Clarified activate_time docs.
Fri Aug 17 11:36:29 2007  Tim Janik  <timj@imendio.com>                                                                                                       
                                                                                                                                                              
        * gtk/gtkmenu.c (gtk_menu_popup): Clarified activate_time docs.                                                                                       
                                                                                                                                                              


svn path=/trunk/; revision=18643
2007-08-17 09:36:15 +00:00
Cody Russell
cd57ff1053 Another documentation fix that I forgot to commit yesterday. (#459340,
2007-08-15  Cody Russell  <bratsche@gnome.org>

        * gtk/gtkcontainer.c: Another documentation fix that I forgot to
        commit yesterday.  (#459340, Guillaume Cottenceau)


svn path=/trunk/; revision=18619
2007-08-15 14:49:56 +00:00
Cody Russell
46bbf4ebd8 gtk/gtkwidget.c gtk/gtkscrolledwindow.c Correct documentation that refers
2007-08-14  Cody Russell  <bratsche@gnome.org>

        * gtk/gtkwidget.c
        * gtk/gtkscrolledwindow.c
        * gtk/gtklabel.c: Correct documentation that refers to the
        deprecated gtk_widget_set_usize() API.  Refer instead to
        gtk_widget_set_size_request().  (#459340, Guillaume Cottenceau)


svn path=/trunk/; revision=18613
2007-08-14 22:44:11 +00:00
Kristian Rietveld
bd7b15f347 make sure we fail keynav if the only item in the list is already selected.
2007-08-14  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktreeview.c (gtk_tree_view_move_cursor_up_down): make
	sure we fail keynav if the only item in the list is already selected.
	(Fixes #465039, reported by Fernando Herrera).


svn path=/trunk/; revision=18610
2007-08-14 08:11:26 +00:00
Stefan Kost
07a789f58a Move documentation of gtk_ruler_set_range() to source and fix nonsense.
* docs/reference/gtk/tmpl/gtkruler.sgml:
	* gtk/gtkruler.c:
	Move documentation of gtk_ruler_set_range() to source and fix nonsense.


svn path=/trunk/; revision=18599
2007-08-09 12:58:25 +00:00
Mikael Hallendal
9e9767401d Document the new signals popup, popdown and move-active.
2007-08-08  Mikael Hallendal  <micke@imendio.com>

	* gtk/gtkcombobox.c (gtk_combo_box_class_init):
	Document the new signals popup, popdown and move-active.

svn path=/trunk/; revision=18594
2007-08-08 19:59:42 +00:00
Johan Dahlin
12e1855bba Do not assume that text is null-terminated as pointed out by Christopher
2007-08-07  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkbuilderparser.c (text): 
    * gtk/gtkcelllayout.c (attributes_text_element): 
    * gtk/gtkliststore.c (list_store_text): 
    Do not assume that text is null-terminated as pointed out by
    Christopher Fergeau


svn path=/trunk/; revision=18592
2007-08-07 21:52:29 +00:00
Johan Dahlin
f09b3248af Use g_strdup on the translated string instead of g_strndup() + the length
2007-08-07  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkbuilderparser.c (text): Use g_strdup on the translated
    string instead of g_strndup() + the length of the untranslated
    string. (#461945, Claude Paroz)


svn path=/trunk/; revision=18588
2007-08-07 21:04:23 +00:00
Kristian Rietveld
ce1d7e3a4a create a dummy tip_window and tip_label, so old applications with code
2007-08-07  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktooltips.c (gtk_tooltips_init),
	(gtk_tooltips_destroy), (gtk_tooltips_force_window): create a dummy
	tip_window and tip_label, so old applications with code accessing
	those fields won't crash.


svn path=/trunk/; revision=18587
2007-08-07 13:32:19 +00:00
Kristian Rietveld
02eda450ea Disable tooltips in touchscreen mode.
2007-08-07  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktooltip.c (_gtk_tooltip_handle_event): Disable tooltips
	in touchscreen mode.


svn path=/trunk/; revision=18586
2007-08-07 11:28:01 +00:00
Xan Lopez
f581dcca39 reset the completion prefix on Enter too, plug potential leak. Follow-up
2007-07-31  Xan Lopez  <xan@gnome.org>

	* gtk/gtkentry.c (gtk_entry_completion_key_press): reset the
	completion prefix on Enter too, plug potential leak.
	Follow-up to #458298

svn path=/trunk/; revision=18559
2007-07-31 19:17:25 +00:00
Matthias Clasen
b11262594c Make the label wrap, for compatibility with the old tooltips code. This
2007-07-31  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktooltip.c (gtk_tooltip_init): Make the label
        wrap, for compatibility with the old tooltips code. This
        fixes absurdly long tooltips in the color selector.



svn path=/trunk/; revision=18558
2007-07-31 17:38:27 +00:00
Kristian Rietveld
bed2f0e38c Fix documentation. (#461225, Murray Cumming).
2007-07-30  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktreeview.c (gtk_tree_view_set_tooltip_cell): Fix
	documentation. (#461225, Murray Cumming).


svn path=/trunk/; revision=18557
2007-07-30 10:57:25 +00:00
Emmanuele Bassi
d3625daed1 Add documentation for properties and fix the deprecation marker for the
2007-07-29  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentchooser.c: Add documentation for properties
	and fix the deprecation marker for the show-numbers
	accessor functions (Murray Cumming).

	* gtk/gtkrecentchooser.h: Add deprecation guards around
	gtk_recent_chooser_set_show_numbers() and
	gtk_recent_chooser_get_show_numbers(), as promised during
	last development cycle.

svn path=/trunk/; revision=18556
2007-07-30 09:38:05 +00:00
Michael Natterer
3c9a4ac633 Fix check/radio indicator drawing mess (bug #452225):
2007-07-27  Michael Natterer  <mitch@imendio.com>

	Fix check/radio indicator drawing mess (bug #452225):

	* gtk/gtkstyle.c (gtk_default_draw_check): really decrease the
	indicator size by one to ensure odd size (don't say -= -1).

	* gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
	removed -1 adjustment from calls to gtk_paint_option(). Theme
	engines now get the actually configured size passed, not one pixel
	less.

	* gtk/gtkcellrenderertoggle.c
	* gtk/gtkcheckmenuitem.c: changed default indicator size from 12
	to 13 so all widgets which draw check/option indicators have the
	same default size now (and render the same size after above
	changes).

	* README.in: mention above changes in the release notes.


svn path=/trunk/; revision=18547
2007-07-27 12:11:07 +00:00
Matthias Clasen
ef8bdfb703 Call gtk_tooltip_hide_tooltip() even if the tooltip is not visible yet.
2007-07-25  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktooltip.c (_gtk_tooltip_handle_event): Call
        gtk_tooltip_hide_tooltip() even if the tooltip is not
        visible yet. This fixes annoying dangling tooltips
        on systray icons.


svn path=/trunk/; revision=18544
2007-07-25 17:45:22 +00:00
Alexander Larsson
ffed09f28a Mark more internal symbols for prefixing
2007-07-25  Alexander Larsson  <alexl@redhat.com>

        * xdgmimealias.h:
        * xdgmimecache.h:
        * xdgmimeparent.h:
	Mark more internal symbols for prefixing


svn path=/trunk/; revision=18543
2007-07-25 16:19:36 +00:00
Matthias Clasen
4fba6e4f5b Silence the validator
svn path=/trunk/; revision=18541
2007-07-25 02:07:44 +00:00
Matthias Clasen
d708f2f081 Remove obsolete set-tooltip handler. (#458280, Christian Persch)
2007-07-24  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkmenutoolbutton.c: Remove obsolete set-tooltip
        handler.  (#458280, Christian Persch)



svn path=/trunk/; revision=18540
2007-07-24 15:44:04 +00:00
Matthias Clasen
57c44b18e7 Port to use new tooltips API. (#451397, Jan Arne Petersen)
2007-07-24  Matthias Clasen  <mclasen@redhat.com>

        * gtkcolorsel.c:
        * gtkfilechooserdefault.c:
        * gtkpagesetupunixdialog.c:
        * gtkprintunixdialog.c: Port to use new tooltips API.
        (#451397, Jan Arne Petersen)


svn path=/trunk/; revision=18539
2007-07-24 15:18:42 +00:00
Matthias Clasen
55c23d2b22 Restructure the code to make sense, and don't leak an empty accel.
2007-07-24  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkmenubar.c (window_key_press_handler):
        * gtk/gtkmenu.c (gtk_menu_key_press): Restructure the code
        to make sense, and don't leak an empty accel.  (#459515, Owen Taylor)



svn path=/trunk/; revision=18535
2007-07-24 04:56:47 +00:00
Matthias Clasen
17aacf414d Protect against recursion via gtk_container_remove(). (#459561, Christian
2007-07-23  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktooltip.c (gtk_tooltip_set_custom): Protect against
        recursion via gtk_container_remove().  (#459561, Christian Persch)
        (gtk_tooltip_window_hide): Simplify.



svn path=/trunk/; revision=18534
2007-07-24 03:54:16 +00:00
Matthias Clasen
dfe7852586 Fix some doc formatting errors
svn path=/trunk/; revision=18530
2007-07-23 18:33:35 +00:00
Emmanuele Bassi
cb388e4df8 Port the GtkRecentChooser default implementation widget to the new
2007-07-23  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentchooserdefault.c: Port the GtkRecentChooser default
	implementation widget to the new tooltips API, and make it look
	like the GtkFileChooser widget in recent files mode (move the
	full path from the widget to a tooltip on the row) to improve
	consistency.

	* gtk/gtkrecentchoosermenu.c: Port the GtkRecentChooserMenu widget
	to the new tooltips API.

	* tests/testrecentchooser.c:
	* tests/testrecentchoosermenu.c: Exercise the tooltips code paths.

svn path=/trunk/; revision=18526
2007-07-23 16:44:07 +00:00
Ross Burton
7ea3c88056 Correctly redraw when gtk-scrolled-window-placement is changed after the
2007-07-22  Ross Burton  <ross@openedhand.com>

	* gtk/gtkscrolledwindow.c:
	Correctly redraw when gtk-scrolled-window-placement is changed
	after the widget is realised (#458102)

svn path=/trunk/; revision=18523
2007-07-22 19:16:41 +00:00
Matthias Clasen
060fcd5b63 Rename the tips_data_list field back. (#447214)
2007-07-21  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktooltips.[hc]: Rename the tips_data_list field
        back.  (#447214)



svn path=/trunk/; revision=18520
2007-07-21 13:19:11 +00:00
Matthias Clasen
22f1a7f918 Add forgotten release markers
svn path=/trunk/; revision=18519
2007-07-21 13:12:48 +00:00
Matthias Clasen
c8c42229f1 Don't pop up under the cursor.
2007-07-20  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktooltip.c (gtk_tooltip_position): Don't pop up
        under the cursor.



svn path=/trunk/; revision=18512
2007-07-20 12:13:24 +00:00
Matthias Clasen
13e87f72c9 Don't leak a label. (#455901, Christian Persch, Vincent Geddes)
2007-07-20  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkpathbar.c (make_directory_button): Don't leak
        a label.  (#455901, Christian Persch, Vincent Geddes)



svn path=/trunk/; revision=18511
2007-07-20 11:10:07 +00:00
Matthias Clasen
13277b42e2 Apply a patch by Emmanuele Bassi to limit the number of shown recent
2007-07-20  Matthias Clasen  <mclasen@redhat.com>

        Apply a patch by Emmanuele Bassi to limit the number
        of shown recent files.  (#439715)

        * gtk/gtksettings.c: Add a setting for the number
        of recent files to display by default.

        * gtk/gtkrecentchooserdefault.c:
        * gtk/gtkfilechooserdefault.c: Respect the limit.

        * gtk/gtkrecentmanager.c: Remove the poll timeout in
        dispose, and do not stat more often than every 5 seconds.

        * gtk/gtkrecentchooserutils.c:
        * gtk/gtkrecentchoosermenu.c: Cleanups

        * tests/testrecentchoosermenu.c: Test limits.


svn path=/trunk/; revision=18510
2007-07-20 10:39:03 +00:00
Matthias Clasen
2b5eeba065 Apply a patch by Emmanuele Bassi to add tooltips to the file lists in
2007-07-20  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkfilechooserdefault.c: Apply a patch by Emmanuele
        Bassi to add tooltips to the file lists in recent files and
        search modes.



svn path=/trunk/; revision=18508
2007-07-20 09:53:20 +00:00
Matthias Clasen
cb1cfa8b1e Remove debug spew
svn path=/trunk/; revision=18507
2007-07-20 02:36:12 +00:00
Ryan Lortie
f0cfba930c add note that the semantics of this call, when mixed with the new
2007-07-20  Ryan Lortie  <desrt@desrt.ca>

        * gtk/gtkwidget.c (gtk_widget_is_composited): add note that the
        semantics of this call, when mixed with the new
        gdk_window_set_composited(), will change in the future.

        * gdk/x11/gdkevents-x11.c (gdk_event_translate): only grab Damage
        events that belong to us.


svn path=/trunk/; revision=18506
2007-07-19 23:50:39 +00:00
Matthias Clasen
6a45d5b825 Handle keypresses better when there is no completion. (#458298, Christian
2007-07-19  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkentry.c (gtk_entry_completion_key_press): Handle
        keypresses better when there is no completion.  (#458298,
        Christian Persch, patch by Xan Lopez)

        * gtk/gtkentrycompletion.c
        (gtk_entry_completion_insert_completion_text): Small cleanup.



svn path=/trunk/; revision=18505
2007-07-19 15:44:23 +00:00
Matthias Clasen
e1926de86a Merge color scheme before sending notification.
2007-07-19  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtksettings.c (apply_queued_setting): Merge color
        scheme before sending notification.



svn path=/trunk/; revision=18504
2007-07-19 15:32:04 +00:00
Matthias Clasen
a8442c5d01 Small fixes
svn path=/trunk/; revision=18503
2007-07-19 15:06:52 +00:00
Kristian Rietveld
9719e5fb3c handle no-window and regular widgets seperately.
2007-07-19  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktooltip.c (find_topmost_widget_coords_from_event): handle
	no-window and regular widgets seperately.

	* gtk/gtktreeview.c (gkt_tree_view_set_tooltip_cell): rect.x should
	be zero.


svn path=/trunk/; revision=18502
2007-07-19 15:03:18 +00:00
Matthias Clasen
7b2e82f5d0 Add new convenience api for tooltips on icon views
svn path=/trunk/; revision=18501
2007-07-19 14:59:44 +00:00
Matthias Clasen
38037481c2 markup fixes
svn path=/trunk/; revision=18500
2007-07-19 14:05:49 +00:00
Matthias Clasen
11548f29b1 markup fix
svn path=/trunk/; revision=18499
2007-07-19 13:57:16 +00:00
Matthias Clasen
cf5093a587 typo fix
svn path=/trunk/; revision=18498
2007-07-19 13:55:59 +00:00
Matthias Clasen
d5a7784394 Initialized GValues before unsetting them. (#457720)
2007-07-19  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktextview.c (gtk_text_view_compat_move_focus):
        Initialized GValues before unsetting them.  (#457720)



svn path=/trunk/; revision=18497
2007-07-19 13:45:12 +00:00
Kristian Rietveld
b1ec5f7556 add more convenience API.
2007-07-19  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtk.symbols:
	* gtk/gtktreeprivate.h:
	* gtk/gtktreeview.[ch] (gtk_tree_view_get_tooltip_context),
	(gtk_tree_view_[sg]et_tooltip_column): add more convenience API.

	* tests/testtooltip.c (query_tooltip_tree_view_cb): use
	gtk_tree_view_get_tooltip_context().

	* demos/gtk-demo/demo.ui: add a tooltip column to the list store,
	set tooltip-column on the tree view.


svn path=/trunk/; revision=18496
2007-07-19 13:21:09 +00:00
Matthias Clasen
07420f8d75 Correct some mistakes in the documentation of the test-expand/collapse-row
2007-07-18  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktreeview.c: Correct some mistakes in the
        documentation of the test-expand/collapse-row signals.
        (#457774, Olivier Andrieu)


svn path=/trunk/; revision=18489
2007-07-18 08:56:42 +00:00
Matthias Clasen
e0e3b2136f Small cleanups
svn path=/trunk/; revision=18488
2007-07-18 07:30:34 +00:00
Kristian Rietveld
2a8be448e3 only do the coordinate check if tmp is not NULL.
2007-07-17  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktooltip.c (find_widget_under_pointer): only do the
	coordinate check if tmp is not NULL.


svn path=/trunk/; revision=18486
2007-07-17 12:39:20 +00:00
Matthias Clasen
20580e491e Fix some issues with some combinations of inline-selection and
2007-07-16  Matthias Clasen <mclasen@redhat.com>

        Fix some issues with some combinations of inline-selection
        and inline-completion.  (#457384, Christian Persch)

        * gtk/gtkentry.c (gtk_entry_completion_key_press): Don't store
        the completion_prefix here, and be careful when using
        completion_prefix, because it may be NULL.
        * gtk/gtkentrycompletion.c (gtk_entry_completion_finalize):
        Free completion_prefix here.
        * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
        (gtk_entry_completion_insert_completion_text): Store the
        completion_prefix here.


svn path=/trunk/; revision=18479
2007-07-16 16:43:54 +00:00
Kristian Rietveld
50a0d3b8eb check if the pointer is really over the returned widget, since the
2007-07-16  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktooltip.c (find_topmost_widget_coords_from_event): check
	if the pointer is really over the returned widget, since the
	coordinate check may not always be hit in find_widget_under_pointer().


svn path=/trunk/; revision=18478
2007-07-16 16:39:53 +00:00
Matthias Clasen
9046ebc9f1 Plug a memleak. (#455721, Christian Persch)
2007-07-16  Matthias Clasen <mclasen@redhat.com>

        * gtk/gtkfilechooserbutton.c (model_add_special_get_info_cb):
        Plug a memleak. (#455721, Christian Persch)



svn path=/trunk/; revision=18476
2007-07-16 15:30:43 +00:00
Matthias Clasen
1053a08cc9 Apply a patch by Guillaume Cottenceau to improve the signal docs.
2007-07-16  Matthias Clasen <mclasen@redhat.com>

        * gtk/gtkscalebutton.c: Apply a patch by Guillaume Cottenceau
        to improve the signal docs.  (#456258)


svn path=/trunk/; revision=18475
2007-07-16 15:00:05 +00:00
Matthias Clasen
1fe3fa46ea Apply a patch by Xan Lopez to document a lot of GtkWidget signals.
2007-07-16  Matthias Clasen <mclasen@redhat.com>

        * gtk/gtkwidget.c: Apply a patch by Xan Lopez to document
        a lot of GtkWidget signals.  (#172424)


svn path=/trunk/; revision=18474
2007-07-16 14:40:37 +00:00
Matthias Clasen
bdf50bd4f6 Convenience functions to position tooltips on icon view items or cells.
2007-07-16  Matthias Clasen <mclasen@redhat.com>

        * gtk/gtk.symbols:
        * gtk/gtkiconview.h:
        * gtk/gtkiconview.c (gtk_icon_view_set_tooltip_item):
        (gtk_icon_view_set_tooltip_cell): Convenience functions to
        position tooltips on icon view items or cells.



svn path=/trunk/; revision=18473
2007-07-16 14:04:35 +00:00
Matthias Clasen
a6f92ce4b0 Avoid gratitious use of g_strdup_printf().
2007-07-13  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkrecentmanager.c (get_uri_shortname_for_display): Avoid
        gratitious use of g_strdup_printf().

        * gtk/gtkrecentchooserdefault.c:
        * gtk/gtkrecentchoosermenu.c: Mark some strings for
        translation.  (#439480, Murray Cumming)



svn path=/trunk/; revision=18465
2007-07-13 16:34:05 +00:00
Kristian Rietveld
da989212f3 #408327, improve tooltip positioning.
2007-07-13  Kristian Rietveld  <kris@imendio.com>

	#408327, improve tooltip positioning.

	* gtk/gtk.symbols: updated.

	* gtk/gtktooltip.[ch] (gtk_tooltip_position): factor out
	positioning code in here,
	(gtk_tooltip_set_tip_area): new function to set the tooltip
	area,
	(gtk_tooltip_reset), (_gtk_tooltip_handle_event): hide tooltip
	once the pointer leaves the tip area.

	* gtk/gtktreeview.[ch] (gtk_tree_view_set_tooltip_row),
	(gtk_tree_view_set_tooltip_cell): convenience functions to set
	tip area for row/column/cell.

	* tests/testtooltips.c (query_tooltip_tree_view_cb): use
	gtk_tree_view_set_tooltip_row.


svn path=/trunk/; revision=18464
2007-07-13 14:25:21 +00:00
Matthias Clasen
89b8b44a61 Add docs
svn path=/trunk/; revision=18455
2007-07-12 06:09:07 +00:00
Matthias Clasen
11eba86f2a Add docs
svn path=/trunk/; revision=18454
2007-07-12 03:23:42 +00:00
Matthias Clasen
37b454c5cc Add more documentation.
svn path=/trunk/; revision=18453
2007-07-12 01:55:15 +00:00
Matthias Clasen
8fb1dc2411 Make parameter naming consistent.
2007-07-11  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktreeview.c:
        * gtk/gtktoolitem.[hc]: Make parameter naming consistent.



svn path=/trunk/; revision=18452
2007-07-12 01:13:42 +00:00
Matthias Clasen
6608fbfd36 Small doc fixes
svn path=/trunk/; revision=18451
2007-07-12 00:57:23 +00:00
Matthias Clasen
4a5ebcfc45 Move some docs inline
svn path=/trunk/; revision=18447
2007-07-11 22:21:06 +00:00
Kristian Rietveld
23b358d7b5 x should be changed when converting widget <=> bin_window coordinates, not
2007-07-11  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktreeview.c (gtk_tree_view_*_to_*_coords): x should be
	changed when converting widget <=> bin_window coordinates, not
	when bin_window <=> tree_window.


svn path=/trunk/; revision=18446
2007-07-11 18:42:28 +00:00
Matthias Clasen
4c40014a86 New function to convert widget coords to what is expected by the at_pos
2007-07-11  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtk.symbols:
        * gtk/gtkiconview.[hc]
        (gtk_icon_view_convert_widget_to_bin_window_coords): New
        function to convert widget coords to what is expected by
        the at_pos functions.  (#455984)


svn path=/trunk/; revision=18445
2007-07-11 18:14:46 +00:00
Christian Persch
bd48f263ce Intern the action's name. Saves two string duplicates of it per action;
2007-07-11  Christian Persch  <chpe@gnome.org>

	* gtk/gtkaction.c: (gtk_action_buildable_set_name),
	(gtk_action_finalize), (gtk_action_set_property),
	(gtk_action_get_property):
	* gtk/gtkactiongroup.c: (gtk_action_group_init),
	(gtk_action_group_add_action),
	(gtk_action_group_add_action_with_accel),
	(gtk_action_group_remove_action): Intern the action's name. Saves two
	string duplicates of it per action; bug #455645.

svn path=/trunk/; revision=18441
2007-07-10 22:18:08 +00:00
Kristian Rietveld
15dee8e529 add getter/setter pair, slight addition to has-tooltip property
2007-07-10  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtk.symbols:
	* gtk/gtkwidget.[ch] (gtk_widget_{get,set}_has_tooltip): add
	getter/setter pair, slight addition to has-tooltip property
	documentation,
	(gtk_widget_real_set_has_tooltip): renamed internal function.


svn path=/trunk/; revision=18439
2007-07-10 18:24:37 +00:00
Christian Persch
03970ddcaf Remove work-around for the old tooltips code, and just set the action
2007-07-10  Christian Persch  <chpe@gnome.org>

	* gtk/gtkaction.c: (gtk_action_sync_tooltip),
	(gtk_action_set_tooltip):
	* gtk/gtkuimanager.c: (update_node): Remove work-around for the old
	tooltips code, and just set the action tooltip immediately on the
	proxy widget. Bug #455482.

svn path=/trunk/; revision=18437
2007-07-10 18:00:43 +00:00
Kristian Rietveld
75d9d02b72 use gtk_container_forall, instead of gtk_container_foreach(). Makes
2007-07-10  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktooltip.c (find_widget_under_pointer),
	(child_location_foreach): use gtk_container_forall, instead of
	gtk_container_foreach().  Makes tooltips on notebook tabs work. (Fixes
	bug reported by Christian Persch).


svn path=/trunk/; revision=18436
2007-07-10 17:47:10 +00:00
Kristian Rietveld
94cfbbfa15 ignore invisible (!drawable) widgets. (Fixes bug reported by Paolo
2007-07-10  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktooltip.c (child_location_foreach): ignore invisible
	(!drawable) widgets.  (Fixes bug reported by Paolo Borelli).


svn path=/trunk/; revision=18435
2007-07-10 17:40:05 +00:00
Matthias Clasen
eac947deea Fix doc formatting
svn path=/trunk/; revision=18430
2007-07-10 05:40:05 +00:00
Matthias Clasen
822f2614e1 Fix a typo
svn path=/trunk/; revision=18428
2007-07-10 05:00:24 +00:00
Matthias Clasen
4a5da8d09a Use a bit of the GtkLabel structure to remember that a pattern has been
2007-07-09  Matthias Clasen  <mclasen@redhat.com>

        * gtklabel.[ch]: Use a bit of the GtkLabel structure to
        remember that a pattern has been set.
        (gtk_label_set_pattern_internal): Don't do anything if
        a specific pattern has been set.
        (gtk_label_set_pattern): set the new bit to TRUE when
        setting a pattern, and recalculate everything if the
        pattern is unset. Fix gtk_label_set_pattern() not working
        anymore.  (#452861, Vincent Untz)



svn path=/trunk/; revision=18426
2007-07-09 20:50:22 +00:00
Matthias Clasen
4397046785 Remove deprecated tooltips, use new tooltips API. (#449311, Jan Arne
2007-07-09  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkvolumebutton.c: Remove deprecated tooltips,
        use new tooltips API.  (#449311, Jan Arne Petersen)



svn path=/trunk/; revision=18424
2007-07-09 20:32:35 +00:00
Matthias Clasen
5450603225 Don't ignore the passed-in len parameter. (#430049, Yevgen Muntyan)
2007-07-09  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkselection.c (normalize_to_crlf): Don't ignore
        the passed-in len parameter.  (#430049, Yevgen Muntyan)



svn path=/trunk/; revision=18423
2007-07-09 20:24:26 +00:00
Matthias Clasen
4689dc3fd3 Improve the handling of broken situations. (#427899, Francesco Montorsi)
2007-07-09  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkframe.c (gtk_frame_size_allocate): Improve the
        handling of broken situations.  (#427899, Francesco Montorsi)



svn path=/trunk/; revision=18422
2007-07-09 20:22:16 +00:00