Commit Graph

70 Commits

Author SHA1 Message Date
Martin Schlemmer
e822af1d98 [win32] Use pango_win32_font_description_from_logfontw() to get
the system font, instead of the code duplication.
2010-08-30 20:00:53 +02:00
Martin Schlemmer
78d120e299 [win32] Fix some warnings related to type differences and unused variables 2010-08-30 19:59:25 +02:00
Martin Schlemmer
770e308c42 win32: cummulated backport of xp theme fixes from master 2010-08-28 15:14:31 +02:00
Sam Thursfield
1fed87720e Add missing accessors for notebook details
The ms-windows theme engine needs to access the tab-{h,v}border,
so add accessors. Bug 625655.
(cherry picked from commit a2b72c5953)
2010-08-09 21:24:29 -04:00
Sam Thursfield
28eebcf383 Towards GSEAL-clean build on win32
Use accessors instead of direct member access in a few places.
Bug 625655.
(cherry picked from commit 4047d0526d)
2010-08-09 21:24:19 -04:00
Javier Jardón
4232115e22 Deprecate widget flag: GTK_WIDGET_HAS_FOCUS
Use gtk_widget_has_focus() instead

https://bugzilla.gnome.org/show_bug.cgi?id=69872
2010-03-01 06:11:01 +01:00
Steffen Macke
f94d62aeab Fix menu bar problem in ms-windows theme engine on Windows 7
Patch from bug #591186. It won't have any effect in this branch as the
whole XP-and-later theming code is broken and disabled, but when/if
that is fixed, then this patch should help.
2010-02-07 11:15:47 +02:00
Javier Jardón
56a893ca8c Deprecate widget flag: GTK_WIDGET_CAN_FOCUS
https://bugzilla.gnome.org/show_bug.cgi?id=69872
2010-01-07 10:05:08 +01:00
Javier Jardón
51e0dd9a82 Deprecate some widget flags
Deprecate the following:
GTK_WIDGET_APP_PAINTABLE
GTK_WIDGET_CAN_DEFAULT
GTK_WIDGET_DOUBLE_BUFFERED
GTK_WIDGET_HAS_DEFAULT
GTK_WIDGET_HAS_GRAB
GTK_WIDGET_RECEIVES_DEFAULT

https://bugzilla.gnome.org/show_bug.cgi?id=69872
2010-01-07 10:04:55 +01:00
Nicola Fontana
1e1131c959 Do not use static GTypeInfo and GInterfaceInfo
Either g_type_register_static_simple (used by G_DEFINE_TYPE_EXTENDED)
and G_IMPLEMENT_INTERFACE use automatic variables for GTypeInfo and
GInterfaceInfo structs, while tutorials and source code often use
static variables. This commit consistently adopts the former method.

https://bugzilla.gnome.org/show_bug.cgi?id=600158
2009-11-06 01:21:09 +01:00
Shixin Zeng
e10db38f0d Put variable definitions at start of block 2009-08-20 23:51:38 +03:00
Cody Russell
b48e4b070f Bug 538840 – [Win32] GTK menu theming could be improved
2009-03-21  Cody Russell  <bratsche@gnome.org>

        Bug 538840 – [Win32] GTK menu theming could be improved

        * modules/engines/ms-windows/xp_theme.c
        * modules/engines/ms-windows/msw_style.c: Use newer
        menu styling API.  This makes gtk+ look much better on
        Windows Vista.


svn path=/trunk/; revision=22577
2009-03-21 13:58:12 +00:00
Cody Russell
24a567924b Bug 567944 – [Win32] Sorted treeview columns can be unreadable
2009-01-16  Cody Russell  <bratsche@gnome.org>

        Bug 567944 – [Win32] Sorted treeview columns can be unreadable

        * modules/engines/ms-windows/msw_style.c: Draw selected treeview
        cells according to treeview focus, but ignore whether it is in
        a sorted column or not.  Otherwise the intersection of a selected
        row and a sorted column looks very strange if the treeview does
        not have focus.


svn path=/trunk/; revision=22126
2009-01-16 16:30:18 +00:00
Dominic Lachowicz
8bfc826f27 Revert most of previous patch, as it didn't work as expected; Some work
2008-09-18  Dominic Lachowicz  <domlachowicz@gmail.com>

        * modules/engines/ms-windows/*: Revert most of previous patch, as it didn't work as expected;
        Some work toward #531086 - the new GtkTooltip widget doesn't theme properly on win32. Now, at least
        the background color seems okay
w

svn path=/trunk/; revision=21430
2008-09-18 15:28:19 +00:00
Dominic Lachowicz
9194e5ac44 MS Windows style should use pango_win32_font_description_from_logfont;
2008-09-18  Dominic Lachowicz  <domlachowicz@gmail.com>

        * modules/engins/ms-windows/*: MS Windows style should use pango_win32_font_description_from_logfont;
        Allows us to rip out a lot of potentially buggy code, and also get the font specification from the
        XP theme (#434987)


svn path=/trunk/; revision=21429
2008-09-18 15:02:53 +00:00
Alberto Ruiz
67140c9d3b draw box does more intelligent separation for the xp theming engine and
2008-03-16  Alberto Ruiz <aruiz@gnome.org>

	* modules/engines/ms-windows/Theme/gtk-2.0/gtkrc:
	* modules/engines/ms-windows/msw_style.c (draw_box) (draw_arrow)
	(combo_box_draw_arrow) (setup_msw_rc_style): draw box does more intelligent
	separation for the xp theming engine and the classic theme while drawing the
	GtkComboBox button.
	combobox_draw_arrow is not used anymore, commented.
	The style has been updated to fix border/thickness glitches in the combobox
	according to the fixes commited regarding bug #521442. (bug #461805)


svn path=/trunk/; revision=19887
2008-03-16 03:39:15 +00:00
Alberto Ruiz
b60e426719 Do not draw frame if parent if combobox. (draw_box): Uses scrollbar width
2008-03-08  Alberto Ruiz  <aruiz@gnome.org>

	* modules/engines/ms-windows/msw_style.c (draw_shadow):
	Do not draw frame if parent if combobox.
	(draw_box):
	Uses scrollbar width system metrics for combobox button.
	Fixes #461805 for XP theme engine.


svn path=/trunk/; revision=19733
2008-03-08 07:20:33 +00:00
Tor Lillqvist
7cd3da8300 Check that the widget is a GtkButton before casting.
2008-03-03  Tor Lillqvist  <tml@novell.com>

	* modules/engines/ms-windows/msw_style.c (draw_box): Check that
	the widget is a GtkButton before casting.


svn path=/trunk/; revision=19690
2008-03-02 19:51:00 +00:00
Cody Russell
47663fd346 modules/engines/ms-windows/xp_theme.[ch]
2008-02-01  Cody Russell  <cody@jhu.edu>

        * modules/engines/ms-windows/xp_theme.[ch]
        * modules/engines/ms-windows/xp_theme_defs.h
        * modules/engines/ms-windows/msw_rc_style.c
        * modules/engines/ms-windows/msw_theme_main.c
        * modules/engines/ms-windows/msw_style.c: Re-indented and generally
        attempted to stylize more like the rest of the gtk+ stack's code.


svn path=/trunk/; revision=19455
2008-02-01 23:25:18 +00:00
Cody Russell
88aafca418 Draw focus rect for buttons with relief set to GTK_RELIEF_NONE. (#487954)
2007-10-18  Cody Russell  <cody@jhu.edu>

        * modules/engines/ms-windows/msw_style.c: Draw focus rect for
        buttons with relief set to GTK_RELIEF_NONE. (#487954)


svn path=/trunk/; revision=18931
2007-10-18 17:14:36 +00:00
Cody Russell
0fd21fa2ed Fix memory leak, and fix two instances where a GtkRequisition and a
2007-10-08  Cody Russell  <bratsche@gnome.org>
	* modules/engines/ms-windows/msw_style.c:
	(draw_tab): Fix memory leak, and fix two instances where
	a GtkRequisition and a GtkBorder were being freed with
	g_free() rather than gtk_requisition_free() and
	gtk_border_free(). (#484730, Daniel Atallah)


svn path=/trunk/; revision=18893
2007-10-08 15:02:23 +00:00
Cody Russell
a1045cf317 Override draw_layout method in GtkStyle in order to adjust by 2 pixels any
2007-09-20  Cody Russell  <bratsche@gnome.org>

        * modules/engines/ms-windows/msw_style.c: Override draw_layout
        method in GtkStyle in order to adjust by 2 pixels any labels
        that are in GtkNotebook tabs using XP theme, so that they appear
        correctly centered. (#478637)


svn path=/trunk/; revision=18848
2007-09-20 16:51:16 +00:00
Cody Russell
ec765b2492 Correct draw_box() function to check detail for "notebook". This fixes a
2007-08-27  Cody Russell  <bratsche@gnome.org>

        * modules/engines/ms-windows/msw_style.c: Correct draw_box()
        function to check detail for "notebook".  This fixes a problem
        where notebooks without visible headers were not styling
        correctly. (#470033, Daniel Atallah and Cody Russell)


svn path=/trunk/; revision=18689
2007-08-27 16:27:38 +00:00
Mathias Hasselmann
0d6acc6ae9 Draw no bevel when "GtkToolbar::shadow-type" is "none" (#450469).
2007-06-28  Mathias Hasselmann  <mathias.hasselmann@gmx.de>

	* modules/engines/ms-windows/msw_style.c: Draw no bevel
	when "GtkToolbar::shadow-type" is "none" (#450469).

svn path=/trunk/; revision=18282
2007-06-28 20:42:18 +00:00
Cody Russell
b487ed554d Fixed, very hackishly, a one pixel error that occurs using the XP theme
2007-06-27  Cody Russell  <bratsche@gnome.org>

        * modules/engines/ms-windows/msw_style.c (draw_themed_tab_button):
        Fixed, very hackishly, a one pixel error that occurs using the
        XP theme engine only on the left-most tab, if it is active, when
        the notebook is bottom-oriented. (#392283)


svn path=/trunk/; revision=18264
2007-06-27 20:00:53 +00:00
Cody Russell
0aa5be0dec modules/engines/ms-windows/xp_theme.[ch] Add support for drawing
2007-06-26  Cody Russell  <bratsche@gnome.org>

        * modules/engines/ms-windows/xp_theme.[ch]
        * modules/engines/ms-windows/msw_style.c: Add support for
        drawing checkboxes with inconsistent states. (Tor, #164809)


svn path=/trunk/; revision=18246
2007-06-26 19:50:24 +00:00
Dom Lachowicz
96fbfe49d8 MS-Windows Theme top tabs rendered upside down for non-XP theme (#435053,
2007-05-02  Dom Lachowicz <domlachowicz@gmail.com>

        * modules/engines/ms-windows/msw_style.c: MS-Windows Theme top 
tabs
        rendered upside down for non-XP theme (#435053, Daniel Atallah)


svn path=/trunk/; revision=17773
2007-05-02 15:07:34 +00:00
Cody Russell
954746fa05 Cleanup of notebook tab code
svn path=/trunk/; revision=17623
2007-04-24 03:31:48 +00:00
Cody Russell
cb47788d27 Fix menuitem rendering in Vista
svn path=/trunk/; revision=17614
2007-04-19 17:24:57 +00:00
Dominic Lachowicz
2bb4433af7 Fix pixbuf leaks in non-WinXP rendering paths. From Daniel Atallah
2007-04-19  Dominic Lachowicz <domlachowicz@gmail.com>

        * modules/engines/ms-windows/msw_style.c: Fix pixbuf leaks in
        non-WinXP rendering paths. From Daniel Atallah (#403470)


svn path=/trunk/; revision=17613
2007-04-19 14:42:12 +00:00
Cody Russell
c524f988bf Fix bottom-oriented notebook tabs on Win32. #399253
svn path=/trunk/; revision=17575
2007-04-01 18:50:38 +00:00
Mathias Hasselmann
d1e1f5d79b Use proper border style when drawing shadow of scrolled windows on Windows
2007-03-08  Mathias Hasselmann <mathias.hasselmann@gmx.de>

	* modules/engines/ms-windows/msw_style.c: Use proper border style
	when drawing shadow of scrolled windows on Windows XP (#168326)
	* modules/engines/ms-windows/xp_theme.c: Explicitly set size of
	element_part_map array to ensure it always is large enough.

svn path=/trunk/; revision=17429
2007-03-08 13:24:51 +00:00
Mathias Hasselmann
a1b0dba103 Add shadow-type style property, set shadow-type property of GtkEntry
2007-03-08  Mathias Hasselmann <mathias.hasselmann@gmx.de>

	* gtk/gtkcombobox.c: Add shadow-type style property, set shadow-type
	property of GtkEntry accordingly, unify size-allocation of toggle
	button (#411123, patch from Mathias Hasselmann).
	* gtk/gtkentry.c: Add shadow-type property. Query style properties
	on style changes only (#411123, patch from Mathias Hasselmann).
	* modules/engines/ms-windows/msw_style.c: Drop combo_box_draw_box
	hack as GtkComboBox emits drawing requests now (#411123, patch 
	from Mathias Hasselmann).

svn path=/trunk/; revision=17426
2007-03-08 02:36:46 +00:00
Mathias Hasselmann
439fd2147f Improve look of GtkScrolledWindow on Windows by implementing a
2007-03-08  Mathias Hasselmann <mathias.hasselmann@gmx.de>

	* gtk/gtkscrolledindow.c: Improve look of GtkScrolledWindow on Windows
	by implementing a scrollbars-within-bevel style property. (#168326)

svn path=/trunk/; revision=17425
2007-03-08 02:33:15 +00:00
Dom Lachowicz
0a9f941758 Bug 411118 - bad bevel for progress bar on windows classic. Match from
2007-02-23  Dom Lachowicz  <domlachowicz@gmail.com>

        * modules/engines/ms-windows/msw_style.c: Bug 411118 - bad bevel for
        progress bar on windows classic. Match from Mathias Hasselmann.


svn path=/trunk/; revision=17344
2007-02-23 16:30:05 +00:00
Dom Lachowicz
47b8d98aba Fix bug 404506, caused by prematurely releasing a DC. By Hiroyuki Yamamoto
2007-02-05  Dom Lachowicz <domlachowicz@gmail.com>

        * modules/engines/ms-windows/msw_style.c: Fix bug 404506, caused
        by prematurely releasing a DC. By Hiroyuki Yamamoto
        * modules/engines/ms-windows/msw_style.c: Fix bug 403470 - leaking
        pixbufs when drawing rotated tabs. By Daniel Atallah


svn path=/trunk/; revision=17263
2007-02-05 14:30:06 +00:00
Dom Lachowicz
c6a8f8b35c Bug 351679 - Notebooks drawn with extra line below tab in MS-Windows
2006-12-13  Dom Lachowicz <domlachowicz@gmail.com>

	* src/modules/engines/ms-windows/msw_style.c: Bug 351679 - Notebooks
	drawn with extra line below tab in MS-Windows theme. Patch by
	Cody Russell
2006-12-14 02:09:27 +00:00
Dom Lachowicz
a4a874c38a Bug 351678 - Notebooks not with PositionType.Top drawn incorrectly. Patch
2006-12-02  Dom Lachowicz <domlachowicz@gmail.com>

	* src/modules/engines/ms-windows/msw_style.c: Bug 351678 - Notebooks
	not with PositionType.Top drawn incorrectly. Patch by Cody Russell
2006-12-02 16:34:12 +00:00
Dom Lachowicz
eaa2c93fcd Remember to free GDI Pen resources, introduced by bug 340201.(#364514)
2006-10-23  Dom Lachowicz <domlachowicz@gmail.com>

        * src/modules/engines/ms-windows/msw_style.c (draw_expander): Remember
        to free GDI Pen resources, introduced by bug 340201.(#364514)
2006-10-23 20:24:31 +00:00
Dom Lachowicz
8d04e3466d Bug 340201 2006-09-12 09:45:29 +00:00
Dom Lachowicz
68d222c757 Emulate WinXP's drawing of menu separators 2006-04-01 16:28:00 +00:00
Dom Lachowicz
791d0b405b Override style->realize/ style->unrealize, so that GTK+ doesn't
* modules/engines/ms-windows/msw_style.c: Override style->realize/
        style->unrealize, so that GTK+ doesn't automatically attempt to apply
        shading to the GC colors, causing a mismatch with the Win32 native
        colors. Problem found by (and suggested solution by) "Cosmic Integer"
2006-03-15 17:37:19 +00:00
Dom Lachowicz
a579bc5a54 Speed up the Windows theme considerably (#163724, John Ehresman) Be more
2006-03-11  Dom Lachowicz <cinamod@hotmail.com>

	* modules/engines/ms-windows: Speed up the Windows theme
	considerably (#163724, John Ehresman)
	Be more careful about setting Pango font descriptions (#333372)
2006-03-11 18:04:36 +00:00
Dom Lachowicz
91336be9b3 Fix combobox theming regression noted in bug 321301 Ditto
* modules/engines/ms-windows/msw_style.c: Fix combobox theming
	regression noted in bug 321301
	* modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Ditto
2006-03-03 03:32:39 +00:00
Dom Lachowicz
cca151bab7 Re-sync with gtk-wimp Ditto
2006-01-28  Dom Lachowicz <cinamod@hotmail.com>

	* modules/engines/ms-windows/msw-style.c: Re-sync with gtk-wimp
	* modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Ditto
2006-01-29 03:28:25 +00:00
Dom Lachowicz
735d98916e Merge with gtk-wimp's CVS. Includes improved menu icon spacing, [+]/[-]
* modules/engines/ms-windows/*.[ch]: Merge with gtk-wimp's CVS.
	Includes improved menu icon spacing, [+]/[-] expander drawing,
	status-bar gippie drawing, and notebook tab drawing.
2005-11-25 23:47:46 +00:00
Dom Lachowicz
5411a3a1a2 Bug #313627. Make win32 theme's handling of toolbars, handleboxes, and
2005-11-12  Dom Lachowicz <cinamod@hotmail.com>

	* modules/engines/ms-windows/msw_style.c: Bug #313627. Make win32
	theme's handling of toolbars, handleboxes, and menubars more in-line
	with Microsoft's IE style.
	* modules/engines/ms-windows/*.c: Indentation cleanups
2005-11-12 14:20:51 +00:00
Dom Lachowicz
f9365c3747 Experimentally, scrollbar steppers can shrink to 8 pixels on Win32.
* modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
	Experimentally, scrollbar steppers can shrink to 8 pixels on
	Win32. Reflect that in the theme.
	* modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
	there is a 1-pixel border between a scrollbar and its child
	in ScrolledWindows on Win32. Reflect that in the theme.
2005-10-22 15:53:00 +00:00
Tor Lillqvist
6c54409759 Check whether the widget actually is a GtkNotebook before treating it as
2005-09-16  Tor Lillqvist  <tml@novell.com>

	* modules/engines/ms-windows/msw_style.c (draw_extension,
	draw_box_gap): Check whether the widget actually is a GtkNotebook
	before treating it as such. Drop some unneeded local variables,
	use parameter with same information instead. (#316412)
2005-09-15 22:14:03 +00:00
Matthias Clasen
3dffa71bea Fix a typo.
2005-08-19  Matthias Clasen  <mclasen@redhat.com>

	* modules/engines/ms-windows/msw_style.c (setup_system_styles):
	Fix a typo.
2005-08-19 19:21:45 +00:00