AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity
59,135 Commits 969 Branches 749 Tags 504 MiB
eb087c9943
Commit Graph

32981 Commits

Author SHA1 Message Date
Christian Hergert
b930c5a8a2 textiter: add _gtk_text_iter_same_line() 
This is a faster form to compare two text iter to see if they are on the
same line.
 2019-07-28 10:34:15 -07:00
Matthias Clasen
7eb5dfd294 inspector: Show the pango backend 2019-07-28 11:39:16 -04:00
Matthias Clasen
988fac404a Add pango version checks 
Seems the ci does not have pango 1.44 yet.
 2019-07-28 10:50:14 -04:00
Timm Bäder
eea76e8cce textview: Remove some unnecessary gtk_widget_show() calls 
Widgets are visible by default.
 2019-07-28 08:44:45 +02:00
Timm Bäder
b2d639b6d9 window: Unroot with old display 
Things might rely on the old display being set while unrooting.

Fixes #2052
 2019-07-27 07:57:06 +02:00
Matthias Clasen
f1c7803f80 label: Parse new pango attributes 
Support allow-breaks and show attributes.
These will be in pango 1.44
 2019-07-27 00:02:08 -04:00
Emmanuele Bassi
f1e4efebb7 Merge branch 'gtk-4-add-TCRYPT-options-to-ask-password-dialog' into 'master' 
gtkmountoperation: Add TCRYPT options to the ask-password dialog

See merge request GNOME/gtk!263
 2019-07-25 10:16:11 +00:00
Matthias Clasen
e89e182565 Merge branch 'avoid-redundant-attributes' into 'master' 
text layout: Avoid redundant text attributes

See merge request GNOME/gtk!1015
 2019-07-24 23:47:41 +00:00
Matthias Clasen
552fe0406c text layout: Avoid redundant text attributes 
Don't insert text attributes if the font, or scale
or fallback did not actually change. This helps
Pango avoid excessive item breaks, which in turn
helps shaping to work across things like color
changes.

Related: https://gitlab.gnome.org/GNOME/pango/issues/28
 2019-07-24 19:05:32 -04:00
Matthias Clasen
2f387c2a23 Merge branch 'missing-gobject-annotation' into 'master' 
Add nullable annotation to combo_box_text_get_active_text

See merge request GNOME/gtk!1012
 2019-07-24 13:50:04 +00:00
Timm Bäder
0d95c5dfe2 passwordentry: Normalize boolean value 2019-07-24 08:10:37 +02:00
Timm Bäder
f2a2908c59 passwordentry: Remove empty vfunc implementation 2019-07-24 08:10:26 +02:00
Timm Bäder
f4cb60dcca textlayout: Avoid querying CSS state if we don't have to 
This is actually pretty slow, and we almost never render a selection.
 2019-07-24 07:54:30 +02:00
Timm Bäder
b3d0629709 popover: Remove some unnecessary checks 
gtk_popover_move_resize() already checks whether the popover has a
surface.
 2019-07-24 07:54:30 +02:00
Matthias Clasen
30f55c4d07 Remove a redundant vfunc 
PangoRenderer has a perfectly adequate default
implementation of draw_glyphs, no need to duplicate that.
 2019-07-23 23:28:24 -04:00
Ryan Westlund
f00d964f4f Add nullable annotation to combo_box_text_get_active_text 2019-07-23 22:59:35 -04:00
Matthias Clasen
d2920c501d Merge branch 'blink-later' into 'master' 
Blink later

See merge request GNOME/gtk!1011
 2019-07-24 02:05:32 +00:00
Matthias Clasen
af528b08dc Merge branch 'error-nodes' into 'master' 
Render error underlines as render nodes

See merge request GNOME/gtk!1009
 2019-07-24 01:39:37 +00:00
Matthias Clasen
a628907891 textview: Defer cursor blinking on input 
We were not calling the right cursor functions
in the commit handler.
 2019-07-23 21:18:03 -04:00
Matthias Clasen
19ad4d67ef textview: Delay initial cursor blinking 
These changes follow the same changes for
gtktext.c in the previous commit.
 2019-07-23 21:17:05 -04:00
Matthias Clasen
a4e427b44a text: Delay initial cursor blinking 
We used to have a solid cursor for 2/3 of the cycle,
now we start fading after 1/4th. To make up for it,
add half a cycle of delay.
 2019-07-23 21:08:47 -04:00
Matthias Clasen
3278e9ab6c Render error underlines as render nodes 
Use a sequence of transformed squares,
instead of a cairo node. The drawing is not
identical to the previous code, but reasonably
close.
 2019-07-23 18:31:39 -04:00
Christian Hergert
02d8e95b73 textlayout: remove use of gtk_text_layout_free_line_display 
Now that these are reference counted, we no longer need to use
the variant requiring access to the GtkTextLayout.
 2019-07-23 14:59:40 -07:00
Christian Hergert
e0b9b51e9f textlayout: make GtkTextLineDisplay reference counted 
This makes GtkTextLineDisplay use GRcBox instead of g_slice_*
directly. By using reference counting for this structure, we
can ensure that we hold an extra ref for one_display_cache as
well as caching additional GtkTextLineDisplay for the visible
range in the future.
 2019-07-23 14:52:14 -07:00
Matthias Clasen
fb06b7fa94 text: Remove an outdated comment 2019-07-23 15:14:38 -04:00
Matthias Clasen
7b451678f5 fix the build 2019-07-23 14:26:32 -04:00
Matthias Clasen
758c54eab8 text: Fix incomplete invalidation 
When a style change affects the text, we need to
clear the cached content, in order to pick up the
new text style.
 2019-07-23 10:41:52 -04:00
Matthias Clasen
c39cc15573 text view: Fix incomplete invalidation 
Update the cached text style when a css change affects
content or background. This fixes text views drawing
black-on-dark when switching to the dark theme.
 2019-07-23 10:41:43 -04:00
Christian Hergert
e475d4bdc5 textlayout: fix bounds for clipping 
This should match gtk_snapshot_append_layout(), which means that we expect the
bounds to be rooted at 0, 0.
 2019-07-21 18:21:04 -07:00
Matthias Clasen
064ad42432 text view: Smooth cursor blinking 
Fade the text cursor in and out, instead
of abruptly turning it on and off.
 2019-07-21 16:03:49 -07:00
Christian Hergert
4ff9163c47 textview: port GtkTextView to GskPangoRenderer 
This removes the use of GtkTextDisplay (a PangoRenderer) to use
the GskPangoRender which generates render nodes. Part of this means
improving the GskPangoRenderer to support the necessary features for
displaying a GtkTextView.

Primarily, this is a merging of GtkTextDisplay features into
GskPangoRender. Additionally, GtkTextDisplay was removed to allow for
gtk_text_layout_snapshot() to be implemented elsewhere.
 2019-07-21 16:03:45 -07:00
Matthias Clasen
45ebe47d94 textview: Stop exporting private apis 
These headers are no longer 'semi-public, but private
and uninstalled, so exporting these functions does
not do any good.
 2019-07-21 13:26:40 -07:00
Matthias Clasen
51161fb0d6 text: Smooth cursor blinking 
Fade the text cursor in and out, instead
of abruptly turning it on and off.
 2019-07-21 11:35:13 -07:00
Matthias Clasen
63fd97749c Adwaita: Fix entry block cursors 2019-07-21 11:35:04 -07:00
Timm Bäder
8f734b01b2 window: Plug a GList leak 
We need to free the GList manually when using g_list_remove_link().
 2019-07-21 12:45:10 +02:00
Timm Bäder
8beea4d958 window: Merge some functions into their only callers 
So it's clear we only add or remove the pointerfocus-es in
_update_pointer_focus.
 2019-07-21 11:06:24 +02:00
Timm Bäder
1583200e24 cellrenderertext: Remove some unnecessary NULL checks 2019-07-21 10:26:00 +02:00
Timm Bäder
03fa8ed259 cellrenderertext: Don't unnecessarily ref a layout 
We never pass a NULL layout to get_size().
 2019-07-21 10:22:05 +02:00
Timm Bäder
0bd939624e textlayout: Remove some outdated comments 
These two members have been commented out for 19 years.
 2019-07-21 10:02:54 +02:00
Timm Bäder
b658a1a8e3 entry: Measure icons again 
This was previously removed because it changes the minimum and natural
size of the entry when the icons are shown/hidden at runtime. Just not
measuring them does not work however, so reintroduce this.
 2019-07-21 09:58:08 +02:00
Timm Bäder
7eae9d115c placesview: Make "Other Locations" search case-insensitive 
It's just weird to search for "c" and not find the list item labelled
"Computer".
 2019-07-21 09:51:54 +02:00
Timm Bäder
2ca56d4c4c linedisplay: Save paragraph bg color inline 
No need to allocate this separately.
 2019-07-21 09:47:09 +02:00
Timm Bäder
3935027880 filechooserwidget: Fold function into only caller 2019-07-19 18:14:50 +02:00
Timm Bäder
8665828d7f filechooserwidget: Don't emit default-size-changed() in unroot() 
It doesn't make much sense to assume the default size has changed just
because the widget has been unrooted.
 2019-07-19 18:14:50 +02:00
Timm Bäder
a8b559e99f filechooser: Remove SETTINGS_KEY_WINDOW_POSITION 
Now unused.
 2019-07-19 18:14:50 +02:00
Timm Bäder
5674a3db46 filechooserwidget: Don't look at saved window position 
We don't save it anymore so no need to look at it here.
 2019-07-19 18:14:49 +02:00
Timm Bäder
dd3acc9014 filechooserdialog: Stop using gtk_window_get_position() 2019-07-19 18:14:49 +02:00
Timm Bäder
a9364bc053 Revert "file chooser: Stop using gtk_window_get_position" 
This reverts commit 2ed533c3e1.

This also made the filechooser dialog not save the window size anymore,
which does not depend on the gtk_window_get_position() removal.
 2019-07-19 18:14:49 +02:00
Timm Bäder
59313e1459 gtkfilechooserwidget: Temporarily disable revealer transitions... 
... when going between recent and browse. It just looks weird to have
this transition while the treeview model is just cleared/repopulated
without any transition.
 2019-07-19 18:14:49 +02:00
Timm Bäder
3e54d374de placessidebar: Remove sidebar border again 2019-07-19 18:14:49 +02:00
segfault
97cdf87350 gtkmountoperation: Add TCRYPT options to the ask-password dialog 2019-07-18 20:06:20 +02:00
segfault
e5cccbf5a0 gtkmountoperation: Support TCRYPT options when using proxy handler 
GMountOperation now supports options to unlock TCRYPT volumes. This
patch sets these options if they are returned by AskPassword() of a
GtkMountOperationHandlerProxy.
 2019-07-18 11:41:45 +02:00
Timm Bäder
24a4063645 scrollbar: Use a box layout 
Makes a lot more sense than the intermediate box just for its layout.
 2019-07-15 07:52:42 +02:00
Timm Bäder
4f11bbc59b text: Don't leak emoji chooser 2019-07-15 06:56:19 +02:00
Timm Bäder
9ceb41f9a4 menu: Fix an uninitialized value 
If the menu does not have any children, we'd otherwise end up calling
g_object_ref() on an uninitialized value.
 2019-07-15 06:43:25 +02:00
Timm Bäder
831309eed2 progressbar: Use box layout 
Instead of the custom layouting we did before.
 2019-07-15 06:38:51 +02:00
Timm Bäder
4bb4a98493 text: Move some locals into the closest scope 2019-07-15 05:38:25 +02:00
Timm Bäder
70b0f712ad text: Remove some useless casts 2019-07-15 05:19:02 +02:00
Timm Bäder
c6e9372ba3 text: Move some locals into the closest scope 2019-07-15 05:17:46 +02:00
Timm Bäder
38f4a7708e Remove some dead assignments 2019-07-14 10:08:04 +02:00
Timm Bäder
6abcd8d013 Adwaita: Add fontbutton spacing back 2019-07-14 10:08:04 +02:00
Timm Bäder
37906a2200 adwaita: Remove a dead rule 
GtkFileChooserButtons are called "filechooserbutton" these days, not
button.file
 2019-07-14 10:08:04 +02:00
Timm Bäder
92a79d3f96 popover: Fix a broken cast 
The widget passed here is priv->relative_to, not the popover.
 2019-07-13 17:06:22 +02:00
Timm Bäder
2884691740 picture: Unref previous paintable 
We were leaking all of them.
 2019-07-13 09:38:28 +02:00
Timm Bäder
a13d6bbbdf Merge branch 'fix-issue-2014-gtk4' into 'master' 
Fix a string leak in gtkemojicompletion.c [gtk4]

Closes #2014

See merge request GNOME/gtk!993
 2019-07-12 09:59:38 +00:00
Luca Bacci
d15dc6f90b Fix a string leak 
Fixes #2014
 2019-07-12 08:43:44 +00:00
Timm Bäder
58e6c277b0 fpsoverlay: Fix fps overlay position 2019-07-10 18:34:16 +02:00
Matthias Clasen
1d29d44ddb Merge branch 'wip/baedert/accelmap' into 'master' 
AccelMap: Sort accels before iterating over them in foreach()

See merge request GNOME/gtk!980
 2019-07-09 19:39:58 +00:00
Matthias Clasen
bda3c6c084 Merge branch 'wip/baedert/for-master' into 'master' 
Improve the valgrind experience

See merge request GNOME/gtk!984
 2019-07-09 19:39:13 +00:00
Robert Ancell
dbd2a81501 Change the few examples that use a full GTK_ enum value in .ui files. 
Lowercase versions work just as well and are much more readable.
 2019-07-08 15:52:28 +12:00
Timm Bäder
264d4bada6 widget: Remove queue_resize_no_redraw 
We always invalidate the widget in size_allocate() anyway.
 2019-07-07 07:43:08 +02:00
Timm Bäder
633172fd66 widget: Make queue_compute_expand() private 
Nobody needs to call this anymore.
 2019-07-07 07:36:29 +02:00
Timm Bäder
95f30fee87 iconhelper: Try to avoid some save/restore calls 
GtkImage already does something similar so we often end up with 0/0
here. Avoid the save()/restore() calls in GtkSnapshot in that case.
 2019-07-07 07:24:00 +02:00
Timm Bäder
449c96ffb3 widget: Unref previous transform 2019-07-07 07:24:00 +02:00
Timm Bäder
4123c85021 actionmuxer: Plug a memory leak 2019-07-07 07:24:00 +02:00
Timm Bäder
a77f8e886b cssprovider: Fix a memory leak in load_internal 
We create a new GBytes but never unref it.
 2019-07-06 09:50:07 +02:00
Adrien Plazas
3bae6fa1c7 headerbar: Don't change the custom title's valign 
This allows custom titles to use the vertical alignment of their choice
without having to set it manually after it has been added to the header
bar, hence allowing them to define their preferred alignment from a UI
template.

This is useful for widgets like the view switcher which requires filling
the header bar's whole height.
 2019-07-04 13:03:37 +02:00
Timm Bäder
68f19a8e6a accelmap: Sort accels before interating over them in foreach() 2019-07-04 08:35:42 +02:00
Timm Bäder
12ebbd1b24 accelmap: Avoid a confusing goto 2019-07-04 08:35:34 +02:00
Benjamin Otte
b2868d7218 Merge branch 'wip/frame-clock-consumers' into 'master' 
Frame clock consumers

See merge request GNOME/gtk!971
 2019-07-03 16:21:32 +00:00
Matthias Clasen
9768f35931 widget: Don't lose a layout manager ref 
gtk_widget_set_layout_manager is transfer-full,
so we must give it a new reference from set_property
to implement object property semantics properly.
 2019-07-03 09:18:41 -04:00
Jonas Ådahl
f66e764855 menu: Remove unused variable 2019-07-03 11:42:28 +02:00
Mohammed Sadiq
a8c23d06ac constraint: Fix property name typo in doc 2019-07-03 09:31:39 +05:30
Matthias Clasen
274c47e5ba constraint layout: Provide list models 
Provide list models for the constraints and guides,
so we can show them in the inspector, and use them
in e.g. the constraints editor.
 2019-07-02 10:03:48 -04:00
Matthias Clasen
b2f15a622d Merge branch 'wip/ebassi/constraint-layout' into 'master' 
Add constraint-based layout manager

Closes #1090

See merge request GNOME/gtk!973
 2019-07-02 14:01:01 +00:00
Benjamin Otte
129691f3a6 flattenlistmodeL: Compute items-changed position properly 
The code previously forgot to include the left child of the model's
node. Which of course only happened if that child wasn't NULL, which is
a common case.

Found and test provided by Matthias Clasen.
 2019-07-02 02:53:00 +02:00
Emmanuele Bassi
8ab609e4e7 Add custom parser for guides defined in GtkBuilder UI files 
Like we describe constraints, we can also define guides.
 2019-07-01 19:22:48 +01:00
Emmanuele Bassi
6bc156c237 Implement GtkBuildable for GtkConstraintLayout 
Using GtkBuildable we can provide a custom parser for reading
constraints defined in a GtkBuilder UI file.
 2019-07-01 18:03:20 +01:00
Emmanuele Bassi
b435dc4366 Use the right GValue getter for GtkConstraintGuide:strength 
The property is defined as an enum.

This fixes the defaultvalue and notify tests.
 2019-07-01 18:02:19 +01:00
Emmanuele Bassi
4dd1de4129 Use explicit values for constraint strength 
Instead of playing games with mapping negative symbolic values to
positive ones, let's use the appropriate constants everywhere. This
allows us to use:

        GTK_CONSTRAINT_STRENGTH_WEAK * 2

Or

        GTK_CONSTRAINT_STRENGTH_STRONG + 1

In code using the public API.

We also store the strength values as integers, so we can compare them
properly, and only turn them into doubles when they are inserted into
the solver, just like every other variable.
 2019-07-01 12:39:24 +01:00
Matthias Clasen
658397fad0 Documentation fixes 
Make sure all types show up in the docs,
and misc other improvements.
 2019-07-01 03:17:58 +00:00
Matthias Clasen
b224df8109 constraint layout: go back to keeping constraints 
We want to minimize changes to the solver, so
keep the size constraints around and only update
them when the size changes.
 2019-07-01 01:54:57 +00:00
Matthias Clasen
c88e7c180d constraint layout: Use stronger force for min size 
We want our edit constraint to be strong enough to
overpower nat. size constraint, therefore use STRONG * 2.
 2019-07-01 01:49:20 +00:00
Emmanuele Bassi
2aabd64f1a Fix warnings from the introspection scanner 
The name of the arguments of the functions must match the name of the
arguments in the documentation stanza.
 2019-07-01 01:13:00 +01:00
Emmanuele Bassi
7990b24287 Add gtkconstraintguide.h to the public headers 
It needs to be introspected and installed.
 2019-07-01 01:12:25 +01:00
Emmanuele Bassi
c76c1a46e4 Remove specialised API from GtkConstraint 
Thet widget-based API for constraint target and source properties is
unused, and not really necessary.
 2019-07-01 01:05:04 +01:00
Emmanuele Bassi
68fed63eac Add missing documentation for GtkConstraint 2019-07-01 01:02:56 +01:00
Emmanuele Bassi
74c626f835 Document GtkConstraintGuide 2019-07-01 00:48:59 +01:00
Emmanuele Bassi
d45a662679 Move the VFL error domain to a public header 
Since the public API will use it to fill out GErrors, it needs to be
publicly available.
 2019-07-01 00:48:48 +01:00
Emmanuele Bassi
9a463056d0 constraint layout: Notice when guides change 
We need to queue a resize here.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
035baa092c Mark the layout as changed 
We should mark the layout as changed when
constraints are added or removed.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
499738c903 constraint guide: Avoid redundant constraints 
There is no point in creating a stay for nat
size when min == max. And no point in a constraint
for <= G_MAXINT either.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
f2d7433bf6 constraint guide: Fix initial property values 
This was overlooked when the max-width/max-height/
strength properties were added.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
405121bccc constraint solver: Use GTK_NOTE 
Allow using GTK_DEBUG=constraints to get debug
output from the constraints solver.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
cb96b34315 solver: Add private statistics api 
No point in keeping these counters without
a way to show them.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
9edf6fb6cb constraint layout: Dont reset constraints in allocate 
If trust our allocation algorithm, this can never
trigger (and in fact, it never does).
 2019-07-01 00:10:11 +01:00
Matthias Clasen
e3c4fb67ca constraints: Add some internal apis 
Checking if a set is empty or a singleton can
be done more efficiently than determining its size.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
a9dfca04e4 constraint guide: Make strength tweakable 
The strength for the natural width can be used
as a tie-breaker to make instable systems behave
in a more predictable way. This can be seen
in the simple constraints demo in gtk-demo.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
f62fc4e2f2 constraint layout: freeze/thaw on mass ops 
In measure and allocate we are potentially
changing quite a few constraints. Don't
optimize at every step.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
511e2b435e constraints: Use better data structures 
Use a GSequence for GtkVariableSet, to avoid
quadratic behavior.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
3f36340921 constraint layout: Measure min/nat size separately 
Only constraint the opposite direction if we
actually have a for_size, and measure natural
size after removing the edit constraints. With
these changes, the test that compares constraint
layout to grid layout passes.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
b1f0f4478e constraint layout: Use stays for natural size 
It makes more sense to treat the natural size
of both children and guides as stays, since
we want to meet these values as closely as we
can, under the circumstances.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
90f8dcc5e1 constraint layout: Add debug output for guides 
Print out the allocation we end up giving to
guides. This helps in making sense of the
allocations of the child widgets that these
guides relate to.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
b39a5fe5dc constraint guide: Add a name property 
We need to be able to print meaningful debug messages
regarding these objects, and eventually present them
in the inspector too.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
c7ef8411bd constraint guide: Shorten names 
Now that this is its own source file,
no need for these prefixes anymore.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
dab8a8b5c5 constraint layout: Measure more correctly 
Set up all constraints for minimum + natural
width + height when measuring, regardless
of the orientation we're measuring. Anything
else will lead to incorrect answers when
there are constraints that cut across
dimensions.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
8b9c5e3a04 solver: Fix a copy/paste error 2019-07-01 00:10:11 +01:00
Matthias Clasen
3d3a672deb constraint solver: Fix repeat suggestions 
We were not storing the previous value, causing
the first two suggestions to work, but not later
ones.

Fixes the test added in the previous commit.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
139a59cae3 Flesh out GtkConstraintGuide 
This commit moves GtkConstraintGuide into its own
source files to avoid gtkconstraintlayout.c turning
too messy, adds max size properties and implements
getters and setters.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
60fb9092fe Drop an indirection 
This struct is not really useful for just
a single hash table, and it gets in the way
of moving the guide code to its own file.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
61b4febbaf Detach guides on unroot 
We don't want to leave constraints behind.
 2019-07-01 00:10:11 +01:00
Matthias Clasen
4f4ba8c4f6 Simplify the guide implementation 
Store the values and constraints in
arrays, to facilitate treating them
uniformly.
 2019-07-01 00:10:11 +01:00
Emmanuele Bassi
651adbfb39 Return the list of constraints added via VFL description 
Otherwise it's impossible to remove them.
 2019-07-01 00:10:11 +01:00
Emmanuele Bassi
3204347bb0 Add method to remove all constraints from a layout 2019-07-01 00:10:11 +01:00
Georges Basile Stavracas Neto
b929846cc1
Adwaita: Also apply $color_menu to popover arrows 
So that popovers and arrows are always in agreement of
the background color.
 2019-06-30 19:51:51 -03:00
Georges Basile Stavracas Neto
fe65da05be
Adwaita: Use $menu_color background in popover.menu 
GtkPopoverMenus should mimic menus. Commit d936967b7a introduced
some CSS related to menu popovers, however, it hardcodes 'white'
as the background color. That is problematic for the dark theme.

Use '$menu_color' instead of 'white', since $menu_color both
guarantees menu popovers and menus match, and already handles
different colors for dark and light theme variants.
 2019-06-30 19:47:32 -03:00
Emmanuele Bassi
06c825df90 Add a C convenience function for VFL constraints 
The dictionary-based function is convenient for language bindings, but C
developers will feel more at home with a variadic arguments list.
 2019-06-30 23:42:45 +01:00
Emmanuele Bassi
859c95b435 Allow adding constraints described through VFL 2019-06-30 23:42:45 +01:00
Emmanuele Bassi
5ea8167802 Add VFL parser for constraints 
Constraints can be expressed with a compact syntax, called VFL (visual
format language).
 2019-06-30 23:42:45 +01:00
Emmanuele Bassi
92d3d55164 Remove GtkConstraintVariable.set_prefix() 
The prefix and name are set at construction time.
 2019-06-30 23:42:45 +01:00
Matthias Clasen
38d353dc1a Add GtkConstraintGuide 
This is meant to be a flexible space.
 2019-06-30 23:42:44 +01:00
Emmanuele Bassi
7ae04ba36b Use generic pointers for constraint targets 
Since GtkWidget implements GtkConstraintTarget, we can omit the explicit
cast, and validate the type at run time.
 2019-06-30 23:42:44 +01:00
Matthias Clasen
39c284c490 Redefine constraints with GtkConstraintTarget 
This is in preparation for allowing non-widgets
to act as constraint targets.
 2019-06-30 23:42:44 +01:00
Matthias Clasen
895e8e25a8 widget: Implement GtkConstraintTarget 2019-06-30 23:42:44 +01:00
Matthias Clasen
04562a76e3 Add GtkConstraintTarget 
This is an marker interface that we will
use to accept other things that widgets
in constraints.
 2019-06-30 23:42:44 +01:00
Emmanuele Bassi
b6781e06c1 Notify a layout change when adding and removing constraints 
Changing the set of constraints should cause a relayout.
 2019-06-30 23:42:44 +01:00
Emmanuele Bassi
54104b6676 Fix the opposite size measurement in GtkConstraintLayout 
We cannot use the given "for size" when querying our children, because
the constraint layout has no idea about the opposite size of its
children until the layout is complete.

Additionally, we should only suggest an opposite size for the layout if
we have one, instead of suggesting a weak zero size.
 2019-06-30 23:42:44 +01:00
Emmanuele Bassi
21450d5f23 Remove size constraints from ConstraintLayoutChild 
The size constraints are transient to measurement and allocation, so
they don't really need to be stored inside the GtkLayoutChild subclass
created by a GtkConstraintLayout.
 2019-06-30 23:42:44 +01:00
Matthias Clasen
a39bbb2041 constraints: Make internal consistency required 
The relations between left, right, width
and top, bottom, height are required for
internal consistency. It doesn't make sense
to ever drop these.

Changing the strength of these relations makes
my systems behave much more stable.
 2019-06-30 23:42:44 +01:00
Matthias Clasen
176d9c6baf Add gtk_constraint_layout_remove_constraint 
Otherwise, you can't do many interesting things.
 2019-06-30 23:42:44 +01:00
Emmanuele Bassi
64afa765c8 Do not release reference on the subject of an expression 
We don't own the reference in the first place.
 2019-06-30 23:42:44 +01:00
Matthias Clasen
a246d8c926 constraints solver: Avoid critials 
When the solver is finalized with existing
constraints, we end up with criticals when
the constraints ref finalize code calls
back into the hash table. Avoid that by
emptying the hash table beforehand.
 2019-06-30 23:42:44 +01:00
Matthias Clasen
0531e663ee constraint solver: Fix thawing 
There was an obviously wrong precondition here.
 2019-06-30 23:42:44 +01:00
Emmanuele Bassi
bd2349c0a0 Do not leak LayoutChild instances 
Since the LayoutManager owns the LayoutChild it creates, it's also
responsible for mopping them up.
 2019-06-30 23:42:44 +01:00
Emmanuele Bassi
cdf80f1d65 Add GtkConstraintLayout 
A layout manager using GtkConstraintSolver to measure and allocate
children.
 2019-06-30 23:42:44 +01:00
Emmanuele Bassi
e7b2c530c5 Propagate rooting and unrooting widgets to layout managers 
Layout managers may need to get access to data attached to the root of a
scene graph.
 2019-06-30 23:42:44 +01:00
Emmanuele Bassi
e07098da03 window: Create a GtkConstraintSolver 
Implement the GtkRoot getter for GtkConstraintSolver.
 2019-06-30 23:42:44 +01:00
Emmanuele Bassi
98a21bf498 Assign a GtkConstraintSolver to each GtkRoot 
Constraints need to work across different parents, so it's better to
have a single constraint solver per top level.
 2019-06-30 23:42:44 +01:00
Emmanuele Bassi
c694dd6049 Move the Root interface to a private header 
We don't expect out of tree implementations of GtkRoot, and having the
interface structure private to the GTK code allows us to add virtual
functions involving private types.
 2019-06-30 23:42:44 +01:00
Emmanuele Bassi
6b308cd71e Add constraint solver 
GtkConstraintSolver is an implementation of the Cassowary constraint
solving algorithm:

  http://constraints.cs.washington.edu/cassowary/

The Cassowary method allows to incrementally solve a tableau of linear
equations, in the form of:

  x = y × coefficient + constant

with different weights, or strengths, applied to each one.

These equations can be used to describe constraints applied to a layout
of UI elements, which allows layout managers using the Cassowary method
to quickly, and efficiently, lay out widgets in complex relations
between themselves and their parent container.
 2019-06-30 23:42:44 +01:00
Matthias Clasen
3b6ee32f83 Fix a crash in action muxer destruction 
I've seen a crash when the action muxer gets
disposed during widget destroy, and tries to
disconnect from widget signals too late.

There is no real need to disconnect, since the
only time an action muxer is going away is when
its widget is destroyed, so just don't do it.
 2019-06-30 18:37:32 +00:00
Timm Bäder
a6a9853676 Adwaita: Fix popover style 
We add the .background class to the popover node now.
 2019-06-29 09:06:32 +02:00
Matthias Clasen
8fa7de5563 grid layout: Fix initial property values 
Too bad that we don't cover layout children
in the default value test - it would have
caught this.
 2019-06-28 12:42:06 +00:00
Jakub Steiner
9e6b4e82c9 Adwaita: allow flat list row buttons to be flat 
- Be more specific about the list row image buttons

Addresses corner case of https://gitlab.gnome.org/GNOME/gtk/issues/1748
 2019-06-27 12:15:51 +02:00
Jakub Steiner
4be2e804ae Adwaita: lighten dark switch sliders 
- addresses legibility concerns

Fixes https://gitlab.gnome.org/GNOME/gtk/issues/1819
 2019-06-27 10:58:18 +02:00
Alex Monday
1056e9976a Adwaita: Apply border-radius to .csd popovers 
Fix popover_radius variable doesn't apply to .csd popover.

Closes https://gitlab.gnome.org/GNOME/gtk/issues/1984
 2019-06-27 10:40:22 +02:00
Alex Monday
851bb61455 Adwaita: Fix padding/rounding on submenus 
- Apply menubar submenu style for .csd submenus;
- Remove child subemenu style (looks like it is inherited
  from a parent).

Closes https://gitlab.gnome.org/GNOME/gtk/issues/1976
 2019-06-27 10:31:11 +02:00
Jakub Steiner
3aadc29af4 Adwaita: darken osd background for A:dark 
- OSD background color was too close to $bg_color to make out outline

Fixes https://gitlab.gnome.org/GNOME/gtk/issues/1964
 2019-06-27 10:30:01 +02:00
Hodong Kim
19b1fcfee3 Fix a typo 2019-06-24 18:42:40 +00:00
Daniel Boles
98cfbd3712 ShortcutsSection: Fix tiny grammar-o "in for"→"in" 2019-06-24 18:02:15 +01:00
Matthias Clasen
2405e2711e Add a non-varargs variant of activate_action 
I recently turned gtk_widget_activate_action()
into a varargs function. That is more convenient
from C, but we need a non-varargs variant for
bindings. So add the old API back, under the
name gtk_widget_activate_action_variant(),
with a rename-to annotation.
 2019-06-24 15:51:39 +00:00
Matthias Clasen
3acc014499 Make gtk_widget_activate_action better 
As a convenience API, this should be easy to use,
so don't expect callers to manually create a
variant, do it for them.

Update all callers.
 2019-06-23 22:51:55 +00:00
Matthias Clasen
3ebe30bf32 widget: create parent muxers lazily 
We need to create a muxer eagerly for every
widget that has class actions, since those
are otherwise missed in the action lookup
on the muxer side. But otherwise, there is
no reason to create parent muxers aggressively,
as long as we update the parent muxers on
root/unroot.

This reduces the number of muxers we create
in widget-factory from 210 to around 50.
 2019-06-23 17:59:41 +00:00
Matthias Clasen
996f011ed8 window: Fix the default value of mnemonics-visible 
They aren't visible, so why should the property
be TRUE?
 2019-06-23 10:59:17 -04:00
Timm Bäder
0611370a5f Merge branch '362-gtk-fileopen-dialog-need-filetype-mime-sort-option-2_GTK4' into 'master' 
GtkFileChooser: add a sortable "Type" column

Closes #362

See merge request GNOME/gtk!874
 2019-06-23 07:58:26 +00:00
Matthias Clasen
8fd968e5bf action muxer: Don't activate disabled actions 
We really shouldn't.
 2019-06-23 01:39:26 +00:00
Matthias Clasen
203d612afd widget: Clarify docs for action inheritance 
Spell out how action inheritance works wrt to prefixes.
 2019-06-22 19:17:30 -04:00
Matthias Clasen
ad4a81e9df action muxer: Change inheritance 
Previously, we would not look any further for
an action once we found a match for the prefix,
defining inheritance by groups. Change this to
inheritance for individual actions, since we
are moving towards individual actions as the
main ingredient in GTKs action support.
 2019-06-22 22:51:23 +00:00
Matthias Clasen
95e5472ade action muxer: Remove unused api 2019-06-22 22:38:14 +00:00
Matthias Clasen
06ff4a8b6f textview: Stop using action muxer needlessly 
This lets us drop some private api.
 2019-06-22 22:34:26 +00:00
Matthias Clasen
1f0904d3df widget: Teach query_action about property actions 
This might be useful for documentation purposes.
 2019-06-22 17:04:01 -04:00
Matthias Clasen
35a88c1440 widget: Rename a function 
set_enabled is shorter and more to the point
than enabled_changed, now that we no longer have
a callback to query the state.

Adapt all callers.
 2019-06-22 17:03:51 -04:00
Matthias Clasen
d1f4068b94 Replace stateful actions by property actions 
The only cases of stateful actions we've seen
so far have been boolean properties, and we
don't really want to add much state handling
API, so lets just go with property actions
for now.

Adapt the only user in GtkText.
 2019-06-22 17:03:38 -04:00
Matthias Clasen
7e73da5f73 widget: Add parameter type back to install_action 
Adapt all callers.
 2019-06-22 16:48:16 -04:00
Nelson Benítez León
c789a39660 GtkFileChooser: add a sortable "Type" column 
along with a new 'type-format' setting that allows
to choose the output format for the "Type" column.

The options implemented for this setting are:

'mime' : Output from g_content_type_get_mime_type().

'description' : Output from g_content_type_get_description().

'category' : It uses the corresponding generic icon
  of the mime type to group by categories (aka basic types).

  This produces a more compact output than previous options,
  and allows for type families to be grouped together, so eg.
  after sorting by "Type" column, jpeg and png images will
  be placed together, or the various types of archiver files
  will also be grouped together.

  This format was copied from and currently used by Nautilus
  list view, so we also improve consistency with Nautilus.
  Bugzilla entry for Nautilus implementation is:
  https://bugzilla.gnome.org/show_bug.cgi?id=683722

  The list of type families or categories can be checked on:
  https://developer.gnome.org/icon-naming-spec/#mimetypes

  This 'category' format is set as default.

Issue #362
 2019-06-22 13:22:59 -04:00
Matthias Clasen
3c6045e300 css: Fix some doc typos 2019-06-22 09:49:50 -04:00
Matthias Clasen
9389768a17 Add GTK_CSS_PARSER_WARNING_UNIMPLEMENTED 
gtk-doc was complaining about it missing,
and it is used in some ifdefed code.
 2019-06-22 09:48:34 -04:00
Matthias Clasen
412006ad23 Add owner types for widget actions 
This lets us filter out actions from parent classes
when introspecting.
 2019-06-22 09:38:30 -04:00
Matthias Clasen
ea456b80da Make actions minimally introspectable 
This will let us autogenerate some docs for
actions, in the future.
 2019-06-21 22:47:40 -04:00
Matthias Clasen
152eabbaba widget actions: Add an explicit state type 
Make the state type part of the API for installing
stateful widget actions. That lets us introspect it.

Update all callers.
 2019-06-21 22:47:40 -04:00
Matthias Clasen
9be0b3d76f application: Stop extracting accels from menus 
This functionality has been superseded by
gtk_application_set_accels_for_action in GTK3,
and we don't want to carry it forward in GTK4.
 2019-06-21 22:47:40 -04:00
Matthias Clasen
9b0d87c5a7 window: Cosmetics 2019-06-21 02:55:27 +00:00
Matthias Clasen
a515fca63f inspector: Fix actions visibility 
We need to always hide the page when setting
an object, otherwise the initial visibility
sticks.
 2019-06-20 22:49:22 -04:00
Matthias Clasen
b6baa15e0a inspector: Use event controller names 
Use these in the same place we use widget names.
 2019-06-20 22:48:42 -04:00
Matthias Clasen
955ae40cd6 event controller: Add a name property 
This helps identifying controllers in the inspector.
 2019-06-20 22:48:33 -04:00
Matthias Clasen
dee9e40ad3 Build fix 2019-06-20 22:47:35 -04:00
Matthias Clasen
a933a9bc79 Fix initial mnemonic visibility 
We were showing mnemonics initially, which is not desired.
 2019-06-21 02:38:05 +00:00
Matthias Clasen
6a4a082660 main: Move visible mnemonics handling 
No need to special-case this anymore; we can use
a regular event controller in GtkWindow for this.
 2019-06-21 02:37:51 +00:00
Matthias Clasen
a7cdcdf92c main: Move visible focus handling 
No need to special-case this anymore; we can use
a regular event controller in GtkWindow for this.
 2019-06-21 02:37:12 +00:00
Daniel Boles
a7a0a34da1 Overlay: Document overlay children aren't measured 
Some users expect that the Overlay will automatically request enough
size for its overlay children as well as its main child. It doesn't,
because it's just a GtkBin. Add a short paragraph pointing that out.

Close https://gitlab.gnome.org/GNOME/gtk/issues/1939
 2019-06-20 21:41:59 +01:00
Daniel Boles
a03e531772 FileChooserButton: Document the CSS nodes & class 
The only glancing mention of this we had was that GtkButton mentioned it
in passing when discussing how `button` could get contextual classes,
and even that's not relevant in master anymore... so drop it from there.
 2019-06-20 20:51:37 +01:00
Daniel Boles
217f9ea3b8 ListBox: Document buildable child type placeholder 
andyholmes on IRC asked about this and it wasn't documented, so fix that
 2019-06-18 21:45:08 +01:00
Daniel Boles
ab7b9d882e Window: Hyperlink to GtkBuildable from its section 2019-06-18 21:45:08 +01:00
Benjamin Otte
27d6276212 bindings: Make gtk_binding_entry_add_signall() private 
This function needs a replacement and that will appear after
refactorings.
 2019-06-18 15:54:27 -04:00
Benjamin Otte
d8d5cc9788 bindings: Hide structs 2019-06-18 15:54:07 -04:00
Benjamin Otte
2687a2eb8d bindings: Remove unused member variables 2019-06-18 15:53:48 -04:00
Matthias Clasen
7dbeee5d50 color chooser widget: Use the new action machinery 
Port GtkColorChooserWidget to use widget class actions.

Note that this also changes the names of
the GtkColorChooserWidget actions away from a generic
"context" prefix.
 2019-06-18 14:48:02 -04:00
Matthias Clasen
01e89f9142 link button: Use the new action machinery 
Port GtkLinkButton to use widget class actions.

Note that this also changes the names of
the GtkLinkButton actions away from a generic
"context" prefix.
 2019-06-18 14:47:33 -04:00
Matthias Clasen
dafb7054a1 window: Use the new action machinery 
Change the default.activate action to use the
new action machinery.
 2019-06-18 14:47:33 -04:00
Matthias Clasen
04bace1982 textview: Use the new action machinery 
Port GtkTextView to use widget class actions.

Note that this also changes the names of
the GtkTextView actions away from a generic
"context" prefix.
 2019-06-18 14:47:33 -04:00