forked from AuroraMiddleware/gtk
4d883861b1
With recent updates to GLib, I now see cases where we can hit a state that has finalized before notify (which will bump the ref count back up). This is evident in GNOME Text Editor when showing a language submenu from a popover, and then dismissing the popover and subsequently the tab. With the previous commit, we at least get a warning like this, which helped track down the issue. Gtk-CRITICAL **: gtk_action_observable_unregister_observer: assertion 'GTK_IS_ACTION_OBSERVABLE (observable)' failed GLib-GObject-CRITICAL **: g_object_ref: assertion '!object_already_finalized' failed This patch fixes both of those criticals. Fixes #5009
1078 lines
34 KiB
C
1078 lines
34 KiB
C
/*
|
||
* Copyright © 2013 Canonical Limited
|
||
*
|
||
* This library is free software; you can redistribute it and/or
|
||
* modify it under the terms of the GNU Lesser General Public
|
||
* License as published by the Free Software Foundation; either
|
||
* version 2 of the licence, or (at your option) any later version.
|
||
*
|
||
* This library is distributed in the hope that it will be useful,
|
||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
||
* Lesser General Public License for more details.
|
||
*
|
||
* You should have received a copy of the GNU Lesser General Public
|
||
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
||
*
|
||
* Author: Ryan Lortie <desrt@desrt.ca>
|
||
*/
|
||
|
||
#include "config.h"
|
||
|
||
#include "gtkmenutrackeritemprivate.h"
|
||
#include "gtkactionmuxerprivate.h"
|
||
#include "gtkdebug.h"
|
||
#include "gtkintl.h"
|
||
|
||
#include <string.h>
|
||
|
||
/*< private >
|
||
* GtkMenuTrackerItem:
|
||
*
|
||
* A GtkMenuTrackerItem is a small helper class used by GtkMenuTracker to
|
||
* represent menu items. It has one of three classes: normal item, separator,
|
||
* or submenu.
|
||
*
|
||
* If an item is one of the non-normal classes (submenu, separator), only the
|
||
* label of the item needs to be respected. Otherwise, all the properties
|
||
* of the item contribute to the item’s appearance and state.
|
||
*
|
||
* Implementing the appearance of the menu item is up to toolkits, and certain
|
||
* toolkits may choose to ignore certain properties, like icon or accel. The
|
||
* role of the item determines its accessibility role, along with its
|
||
* decoration if the GtkMenuTrackerItem::toggled property is true. As an
|
||
* example, if the item has the role %GTK_MENU_TRACKER_ITEM_ROLE_CHECK and
|
||
* GtkMenuTrackerItem::toggled is %FALSE, its accessible role should be that of
|
||
* a check menu item, and no decoration should be drawn. But if
|
||
* GtkMenuTrackerItem::toggled is %TRUE, a checkmark should be drawn.
|
||
*
|
||
* All properties except for the two class-determining properties,
|
||
* GtkMenuTrackerItem::is-separator and GtkMenuTrackerItem::has-submenu are
|
||
* allowed to change, so listen to the notify signals to update your item's
|
||
* appearance. When using a GObject library, this can conveniently be done
|
||
* with g_object_bind_property() and GBinding, and this is how this is
|
||
* implemented in GTK; the appearance side is implemented in GtkModelMenuItem.
|
||
*
|
||
* When an item is clicked, simply call gtk_menu_tracker_item_activated() in
|
||
* response. The GtkMenuTrackerItem will take care of everything related to
|
||
* activating the item and will itself update the state of all items in
|
||
* response.
|
||
*
|
||
* Submenus are a special case of menu item. When an item is a submenu, you
|
||
* should create a submenu for it with gtk_menu_tracker_new_item_for_submenu(),
|
||
* and apply the same menu tracking logic you would for a toplevel menu.
|
||
* Applications using submenus may want to lazily build their submenus in
|
||
* response to the user clicking on it, as building a submenu may be expensive.
|
||
*
|
||
* Thus, the submenu has two special controls -- the submenu’s visibility
|
||
* should be controlled by the GtkMenuTrackerItem::submenu-shown property,
|
||
* and if a user clicks on the submenu, do not immediately show the menu,
|
||
* but call gtk_menu_tracker_item_request_submenu_shown() and wait for the
|
||
* GtkMenuTrackerItem::submenu-shown property to update. If the user navigates,
|
||
* the application may want to be notified so it can cancel the expensive
|
||
* operation that it was using to build the submenu. Thus,
|
||
* gtk_menu_tracker_item_request_submenu_shown() takes a boolean parameter.
|
||
* Use %TRUE when the user wants to open the submenu, and %FALSE when the
|
||
* user wants to close the submenu.
|
||
*/
|
||
|
||
typedef GObjectClass GtkMenuTrackerItemClass;
|
||
|
||
struct _GtkMenuTrackerItem
|
||
{
|
||
GObject parent_instance;
|
||
|
||
GtkActionObservable *observable;
|
||
char *action_namespace;
|
||
char *action_and_target;
|
||
GMenuItem *item;
|
||
GtkMenuTrackerItemRole role : 4;
|
||
guint is_separator : 1;
|
||
guint can_activate : 1;
|
||
guint sensitive : 1;
|
||
guint toggled : 1;
|
||
guint submenu_shown : 1;
|
||
guint submenu_requested : 1;
|
||
guint hidden_when : 2;
|
||
guint is_visible : 1;
|
||
};
|
||
|
||
#define HIDDEN_NEVER 0
|
||
#define HIDDEN_WHEN_MISSING 1
|
||
#define HIDDEN_WHEN_DISABLED 2
|
||
#define HIDDEN_WHEN_ALWAYS 3
|
||
|
||
enum {
|
||
PROP_0,
|
||
PROP_IS_SEPARATOR,
|
||
PROP_LABEL,
|
||
PROP_USE_MARKUP,
|
||
PROP_ICON,
|
||
PROP_VERB_ICON,
|
||
PROP_SENSITIVE,
|
||
PROP_ROLE,
|
||
PROP_TOGGLED,
|
||
PROP_ACCEL,
|
||
PROP_SUBMENU_SHOWN,
|
||
PROP_IS_VISIBLE,
|
||
N_PROPS
|
||
};
|
||
|
||
static GParamSpec *gtk_menu_tracker_item_pspecs[N_PROPS];
|
||
|
||
static void gtk_menu_tracker_item_init_observer_iface (GtkActionObserverInterface *iface);
|
||
G_DEFINE_TYPE_WITH_CODE (GtkMenuTrackerItem, gtk_menu_tracker_item, G_TYPE_OBJECT,
|
||
G_IMPLEMENT_INTERFACE (GTK_TYPE_ACTION_OBSERVER, gtk_menu_tracker_item_init_observer_iface))
|
||
|
||
GType
|
||
gtk_menu_tracker_item_role_get_type (void)
|
||
{
|
||
static gsize gtk_menu_tracker_item_role_type;
|
||
|
||
if (g_once_init_enter (>k_menu_tracker_item_role_type))
|
||
{
|
||
static const GEnumValue values[] = {
|
||
{ GTK_MENU_TRACKER_ITEM_ROLE_NORMAL, "GTK_MENU_TRACKER_ITEM_ROLE_NORMAL", "normal" },
|
||
{ GTK_MENU_TRACKER_ITEM_ROLE_CHECK, "GTK_MENU_TRACKER_ITEM_ROLE_CHECK", "check" },
|
||
{ GTK_MENU_TRACKER_ITEM_ROLE_RADIO, "GTK_MENU_TRACKER_ITEM_ROLE_RADIO", "radio" },
|
||
{ 0, NULL, NULL }
|
||
};
|
||
GType type;
|
||
|
||
type = g_enum_register_static (I_("GtkMenuTrackerItemRole"), values);
|
||
|
||
g_once_init_leave (>k_menu_tracker_item_role_type, type);
|
||
}
|
||
|
||
return gtk_menu_tracker_item_role_type;
|
||
}
|
||
|
||
static void
|
||
gtk_menu_tracker_item_get_property (GObject *object,
|
||
guint prop_id,
|
||
GValue *value,
|
||
GParamSpec *pspec)
|
||
{
|
||
GtkMenuTrackerItem *self = GTK_MENU_TRACKER_ITEM (object);
|
||
|
||
switch (prop_id)
|
||
{
|
||
case PROP_IS_SEPARATOR:
|
||
g_value_set_boolean (value, gtk_menu_tracker_item_get_is_separator (self));
|
||
break;
|
||
case PROP_LABEL:
|
||
g_value_set_string (value, gtk_menu_tracker_item_get_label (self));
|
||
break;
|
||
case PROP_USE_MARKUP:
|
||
g_value_set_boolean (value, gtk_menu_tracker_item_get_use_markup (self));
|
||
break;
|
||
case PROP_ICON:
|
||
g_value_take_object (value, gtk_menu_tracker_item_get_icon (self));
|
||
break;
|
||
case PROP_VERB_ICON:
|
||
g_value_take_object (value, gtk_menu_tracker_item_get_verb_icon (self));
|
||
break;
|
||
case PROP_SENSITIVE:
|
||
g_value_set_boolean (value, gtk_menu_tracker_item_get_sensitive (self));
|
||
break;
|
||
case PROP_ROLE:
|
||
g_value_set_enum (value, gtk_menu_tracker_item_get_role (self));
|
||
break;
|
||
case PROP_TOGGLED:
|
||
g_value_set_boolean (value, gtk_menu_tracker_item_get_toggled (self));
|
||
break;
|
||
case PROP_ACCEL:
|
||
g_value_set_string (value, gtk_menu_tracker_item_get_accel (self));
|
||
break;
|
||
case PROP_SUBMENU_SHOWN:
|
||
g_value_set_boolean (value, gtk_menu_tracker_item_get_submenu_shown (self));
|
||
break;
|
||
case PROP_IS_VISIBLE:
|
||
g_value_set_boolean (value, gtk_menu_tracker_item_get_is_visible (self));
|
||
break;
|
||
default:
|
||
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
|
||
break;
|
||
}
|
||
}
|
||
|
||
static void
|
||
gtk_menu_tracker_item_finalize (GObject *object)
|
||
{
|
||
GtkMenuTrackerItem *self = GTK_MENU_TRACKER_ITEM (object);
|
||
|
||
g_clear_pointer (&self->action_namespace, g_free);
|
||
g_clear_pointer (&self->action_and_target, g_free);
|
||
g_clear_object (&self->observable);
|
||
g_clear_object (&self->item);
|
||
|
||
G_OBJECT_CLASS (gtk_menu_tracker_item_parent_class)->finalize (object);
|
||
}
|
||
|
||
static void
|
||
gtk_menu_tracker_item_init (GtkMenuTrackerItem * self)
|
||
{
|
||
}
|
||
|
||
static void
|
||
gtk_menu_tracker_item_class_init (GtkMenuTrackerItemClass *class)
|
||
{
|
||
class->get_property = gtk_menu_tracker_item_get_property;
|
||
class->finalize = gtk_menu_tracker_item_finalize;
|
||
|
||
gtk_menu_tracker_item_pspecs[PROP_IS_SEPARATOR] =
|
||
g_param_spec_boolean ("is-separator", NULL, NULL, FALSE, G_PARAM_STATIC_STRINGS | G_PARAM_READABLE);
|
||
gtk_menu_tracker_item_pspecs[PROP_LABEL] =
|
||
g_param_spec_string ("label", NULL, NULL, NULL, G_PARAM_STATIC_STRINGS | G_PARAM_READABLE);
|
||
gtk_menu_tracker_item_pspecs[PROP_USE_MARKUP] =
|
||
g_param_spec_boolean ("use-markup", NULL, NULL, FALSE, G_PARAM_STATIC_STRINGS | G_PARAM_READABLE);
|
||
gtk_menu_tracker_item_pspecs[PROP_ICON] =
|
||
g_param_spec_object ("icon", NULL, NULL, G_TYPE_ICON, G_PARAM_STATIC_STRINGS | G_PARAM_READABLE);
|
||
gtk_menu_tracker_item_pspecs[PROP_VERB_ICON] =
|
||
g_param_spec_object ("verb-icon", NULL, NULL, G_TYPE_ICON, G_PARAM_STATIC_STRINGS | G_PARAM_READABLE);
|
||
gtk_menu_tracker_item_pspecs[PROP_SENSITIVE] =
|
||
g_param_spec_boolean ("sensitive", NULL, NULL, FALSE, G_PARAM_STATIC_STRINGS | G_PARAM_READABLE);
|
||
gtk_menu_tracker_item_pspecs[PROP_ROLE] =
|
||
g_param_spec_enum ("role", NULL, NULL,
|
||
GTK_TYPE_MENU_TRACKER_ITEM_ROLE, GTK_MENU_TRACKER_ITEM_ROLE_NORMAL,
|
||
G_PARAM_STATIC_STRINGS | G_PARAM_READABLE);
|
||
gtk_menu_tracker_item_pspecs[PROP_TOGGLED] =
|
||
g_param_spec_boolean ("toggled", NULL, NULL, FALSE, G_PARAM_STATIC_STRINGS | G_PARAM_READABLE);
|
||
gtk_menu_tracker_item_pspecs[PROP_ACCEL] =
|
||
g_param_spec_string ("accel", NULL, NULL, NULL, G_PARAM_STATIC_STRINGS | G_PARAM_READABLE);
|
||
gtk_menu_tracker_item_pspecs[PROP_SUBMENU_SHOWN] =
|
||
g_param_spec_boolean ("submenu-shown", NULL, NULL, FALSE, G_PARAM_STATIC_STRINGS | G_PARAM_READABLE);
|
||
gtk_menu_tracker_item_pspecs[PROP_IS_VISIBLE] =
|
||
g_param_spec_boolean ("is-visible", NULL, NULL, FALSE, G_PARAM_STATIC_STRINGS | G_PARAM_READABLE);
|
||
|
||
g_object_class_install_properties (class, N_PROPS, gtk_menu_tracker_item_pspecs);
|
||
}
|
||
|
||
/* This syncs up the visibility for the hidden-when='' case. We call it
|
||
* from the action observer functions on changes to the action group and
|
||
* on initialisation (via the action observer functions that are invoked
|
||
* at that time).
|
||
*/
|
||
static void
|
||
gtk_menu_tracker_item_update_visibility (GtkMenuTrackerItem *self)
|
||
{
|
||
gboolean visible;
|
||
|
||
switch (self->hidden_when)
|
||
{
|
||
case HIDDEN_NEVER:
|
||
visible = TRUE;
|
||
break;
|
||
|
||
case HIDDEN_WHEN_MISSING:
|
||
visible = self->can_activate;
|
||
break;
|
||
|
||
case HIDDEN_WHEN_DISABLED:
|
||
visible = self->sensitive;
|
||
break;
|
||
|
||
case HIDDEN_WHEN_ALWAYS:
|
||
visible = FALSE;
|
||
break;
|
||
|
||
default:
|
||
g_assert_not_reached ();
|
||
}
|
||
|
||
if (visible != self->is_visible)
|
||
{
|
||
self->is_visible = visible;
|
||
g_object_notify_by_pspec (G_OBJECT (self), gtk_menu_tracker_item_pspecs[PROP_IS_VISIBLE]);
|
||
}
|
||
}
|
||
|
||
static void
|
||
gtk_menu_tracker_item_action_added (GtkActionObserver *observer,
|
||
GtkActionObservable *observable,
|
||
const char *action_name,
|
||
const GVariantType *parameter_type,
|
||
gboolean enabled,
|
||
GVariant *state)
|
||
{
|
||
GtkMenuTrackerItem *self = GTK_MENU_TRACKER_ITEM (observer);
|
||
GVariant *action_target;
|
||
gboolean old_sensitive;
|
||
gboolean old_toggled;
|
||
GtkMenuTrackerItemRole old_role;
|
||
guint n_changed;
|
||
|
||
GTK_NOTE(ACTIONS, g_message ("menutracker: action %s added", action_name));
|
||
|
||
old_sensitive = self->sensitive;
|
||
old_toggled = self->toggled;
|
||
old_role = self->role;
|
||
|
||
action_target = g_menu_item_get_attribute_value (self->item, G_MENU_ATTRIBUTE_TARGET, NULL);
|
||
|
||
self->can_activate = (action_target == NULL && parameter_type == NULL) ||
|
||
(action_target != NULL && parameter_type != NULL &&
|
||
g_variant_is_of_type (action_target, parameter_type));
|
||
|
||
if (!self->can_activate)
|
||
{
|
||
GTK_NOTE(ACTIONS, g_message ("menutracker: action %s can't be activated due to parameter type mismatch "
|
||
"(parameter type %s, target type %s)",
|
||
action_name,
|
||
parameter_type ? g_variant_type_peek_string (parameter_type) : "NULL",
|
||
action_target ? g_variant_get_type_string (action_target) : "NULL"));
|
||
|
||
if (action_target)
|
||
g_variant_unref (action_target);
|
||
return;
|
||
}
|
||
|
||
GTK_NOTE(ACTIONS, g_message ("menutracker: action %s can be activated", action_name));
|
||
|
||
self->sensitive = enabled;
|
||
|
||
GTK_NOTE(ACTIONS, g_message ("menutracker: action %s is %s", action_name, enabled ? "enabled" : "disabled"));
|
||
|
||
if (action_target != NULL && state != NULL)
|
||
{
|
||
self->toggled = g_variant_equal (state, action_target);
|
||
self->role = GTK_MENU_TRACKER_ITEM_ROLE_RADIO;
|
||
}
|
||
|
||
else if (state != NULL && g_variant_is_of_type (state, G_VARIANT_TYPE_BOOLEAN))
|
||
{
|
||
self->toggled = g_variant_get_boolean (state);
|
||
self->role = GTK_MENU_TRACKER_ITEM_ROLE_CHECK;
|
||
}
|
||
|
||
/* Avoid freeze/thaw_notify as they are quite expensive in runtime/memory
|
||
* unless we have more than one property to update. Additionally, only
|
||
* notify on properties that have changed to avoid extraneous signal
|
||
* emission. This code can get run a lot!
|
||
*/
|
||
n_changed = (old_role != self->role)
|
||
+ (old_toggled != self->toggled)
|
||
+ (old_sensitive != self->sensitive);
|
||
|
||
if (n_changed > 1)
|
||
g_object_freeze_notify (G_OBJECT (self));
|
||
|
||
if (self->sensitive != old_sensitive)
|
||
g_object_notify_by_pspec (G_OBJECT (self), gtk_menu_tracker_item_pspecs[PROP_SENSITIVE]);
|
||
|
||
if (self->toggled != old_toggled)
|
||
g_object_notify_by_pspec (G_OBJECT (self), gtk_menu_tracker_item_pspecs[PROP_TOGGLED]);
|
||
|
||
if (self->role != old_role)
|
||
g_object_notify_by_pspec (G_OBJECT (self), gtk_menu_tracker_item_pspecs[PROP_ROLE]);
|
||
|
||
if (n_changed > 1)
|
||
g_object_thaw_notify (G_OBJECT (self));
|
||
|
||
if (action_target)
|
||
g_variant_unref (action_target);
|
||
|
||
/* In case of hidden-when='', we want to Wait until after refreshing
|
||
* all of the properties to emit the signal that will cause the
|
||
* tracker to expose us (to prevent too much thrashing).
|
||
*/
|
||
gtk_menu_tracker_item_update_visibility (self);
|
||
}
|
||
|
||
static void
|
||
gtk_menu_tracker_item_action_enabled_changed (GtkActionObserver *observer,
|
||
GtkActionObservable *observable,
|
||
const char *action_name,
|
||
gboolean enabled)
|
||
{
|
||
GtkMenuTrackerItem *self = GTK_MENU_TRACKER_ITEM (observer);
|
||
|
||
GTK_NOTE(ACTIONS, g_message ("menutracker: action %s: enabled changed to %d", action_name, enabled));
|
||
|
||
if (!self->can_activate)
|
||
return;
|
||
|
||
if (self->sensitive == enabled)
|
||
return;
|
||
|
||
self->sensitive = enabled;
|
||
|
||
g_object_notify_by_pspec (G_OBJECT (self), gtk_menu_tracker_item_pspecs[PROP_SENSITIVE]);
|
||
|
||
gtk_menu_tracker_item_update_visibility (self);
|
||
}
|
||
|
||
static void
|
||
gtk_menu_tracker_item_action_state_changed (GtkActionObserver *observer,
|
||
GtkActionObservable *observable,
|
||
const char *action_name,
|
||
GVariant *state)
|
||
{
|
||
GtkMenuTrackerItem *self = GTK_MENU_TRACKER_ITEM (observer);
|
||
GVariant *action_target;
|
||
gboolean was_toggled;
|
||
|
||
GTK_NOTE(ACTIONS, g_message ("menutracker: action %s: state changed", action_name));
|
||
|
||
if (!self->can_activate)
|
||
return;
|
||
|
||
action_target = g_menu_item_get_attribute_value (self->item, G_MENU_ATTRIBUTE_TARGET, NULL);
|
||
was_toggled = self->toggled;
|
||
|
||
if (action_target)
|
||
{
|
||
self->toggled = g_variant_equal (state, action_target);
|
||
g_variant_unref (action_target);
|
||
}
|
||
|
||
else if (g_variant_is_of_type (state, G_VARIANT_TYPE_BOOLEAN))
|
||
self->toggled = g_variant_get_boolean (state);
|
||
|
||
else
|
||
self->toggled = FALSE;
|
||
|
||
if (self->toggled != was_toggled)
|
||
g_object_notify_by_pspec (G_OBJECT (self), gtk_menu_tracker_item_pspecs[PROP_TOGGLED]);
|
||
}
|
||
|
||
static void
|
||
gtk_menu_tracker_item_action_removed (GtkActionObserver *observer,
|
||
GtkActionObservable *observable,
|
||
const char *action_name)
|
||
{
|
||
GtkMenuTrackerItem *self = GTK_MENU_TRACKER_ITEM (observer);
|
||
gboolean was_sensitive, was_toggled;
|
||
GtkMenuTrackerItemRole old_role;
|
||
|
||
GTK_NOTE(ACTIONS, g_message ("menutracker: action %s was removed", action_name));
|
||
|
||
if (!self->can_activate)
|
||
return;
|
||
|
||
was_sensitive = self->sensitive;
|
||
was_toggled = self->toggled;
|
||
old_role = self->role;
|
||
|
||
self->can_activate = FALSE;
|
||
self->sensitive = FALSE;
|
||
self->toggled = FALSE;
|
||
self->role = GTK_MENU_TRACKER_ITEM_ROLE_NORMAL;
|
||
|
||
/* Backwards from adding: we want to remove ourselves from the menu
|
||
* -before- thrashing the properties.
|
||
*/
|
||
gtk_menu_tracker_item_update_visibility (self);
|
||
|
||
g_object_freeze_notify (G_OBJECT (self));
|
||
|
||
if (was_sensitive)
|
||
g_object_notify_by_pspec (G_OBJECT (self), gtk_menu_tracker_item_pspecs[PROP_SENSITIVE]);
|
||
|
||
if (was_toggled)
|
||
g_object_notify_by_pspec (G_OBJECT (self), gtk_menu_tracker_item_pspecs[PROP_TOGGLED]);
|
||
|
||
if (old_role != GTK_MENU_TRACKER_ITEM_ROLE_NORMAL)
|
||
g_object_notify_by_pspec (G_OBJECT (self), gtk_menu_tracker_item_pspecs[PROP_ROLE]);
|
||
|
||
g_object_thaw_notify (G_OBJECT (self));
|
||
}
|
||
|
||
static void
|
||
gtk_menu_tracker_item_primary_accel_changed (GtkActionObserver *observer,
|
||
GtkActionObservable *observable,
|
||
const char *action_name,
|
||
const char *action_and_target)
|
||
{
|
||
GtkMenuTrackerItem *self = GTK_MENU_TRACKER_ITEM (observer);
|
||
const char *action;
|
||
|
||
action = strrchr (self->action_and_target, '|') + 1;
|
||
|
||
if ((action_and_target && g_str_equal (action_and_target, self->action_and_target)) ||
|
||
(action_name && g_str_equal (action_name, action)))
|
||
g_object_notify_by_pspec (G_OBJECT (self), gtk_menu_tracker_item_pspecs[PROP_ACCEL]);
|
||
}
|
||
|
||
static void
|
||
gtk_menu_tracker_item_init_observer_iface (GtkActionObserverInterface *iface)
|
||
{
|
||
iface->action_added = gtk_menu_tracker_item_action_added;
|
||
iface->action_enabled_changed = gtk_menu_tracker_item_action_enabled_changed;
|
||
iface->action_state_changed = gtk_menu_tracker_item_action_state_changed;
|
||
iface->action_removed = gtk_menu_tracker_item_action_removed;
|
||
iface->primary_accel_changed = gtk_menu_tracker_item_primary_accel_changed;
|
||
}
|
||
|
||
GtkMenuTrackerItem *
|
||
_gtk_menu_tracker_item_new (GtkActionObservable *observable,
|
||
GMenuModel *model,
|
||
int item_index,
|
||
gboolean mac_os_mode,
|
||
const char *action_namespace,
|
||
gboolean is_separator)
|
||
{
|
||
GtkMenuTrackerItem *self;
|
||
const char *action_name;
|
||
const char *hidden_when;
|
||
|
||
g_return_val_if_fail (GTK_IS_ACTION_OBSERVABLE (observable), NULL);
|
||
g_return_val_if_fail (G_IS_MENU_MODEL (model), NULL);
|
||
|
||
self = g_object_new (GTK_TYPE_MENU_TRACKER_ITEM, NULL);
|
||
self->item = g_menu_item_new_from_model (model, item_index);
|
||
self->action_namespace = g_strdup (action_namespace);
|
||
self->observable = g_object_ref (observable);
|
||
self->is_separator = is_separator;
|
||
|
||
if (!is_separator && g_menu_item_get_attribute (self->item, "hidden-when", "&s", &hidden_when))
|
||
{
|
||
if (g_str_equal (hidden_when, "action-disabled"))
|
||
self->hidden_when = HIDDEN_WHEN_DISABLED;
|
||
else if (g_str_equal (hidden_when, "action-missing"))
|
||
self->hidden_when = HIDDEN_WHEN_MISSING;
|
||
else if (mac_os_mode && g_str_equal (hidden_when, "macos-menubar"))
|
||
self->hidden_when = HIDDEN_WHEN_ALWAYS;
|
||
|
||
/* Ignore other values -- this code may be running in context of a
|
||
* desktop shell or the like and should not spew criticals due to
|
||
* application bugs...
|
||
*
|
||
* Note: if we just set a hidden-when state, but don't get the
|
||
* action_name below then our visibility will be FALSE forever.
|
||
* That's to be expected since the action is missing...
|
||
*/
|
||
}
|
||
|
||
if (!is_separator && g_menu_item_get_attribute (self->item, "action", "&s", &action_name))
|
||
{
|
||
GtkActionMuxer *muxer = GTK_ACTION_MUXER (observable);
|
||
const GVariantType *parameter_type;
|
||
GVariant *target;
|
||
gboolean enabled;
|
||
GVariant *state;
|
||
gboolean found;
|
||
|
||
target = g_menu_item_get_attribute_value (self->item, "target", NULL);
|
||
|
||
self->action_and_target = gtk_print_action_and_target (action_namespace, action_name, target);
|
||
|
||
if (target)
|
||
g_variant_unref (target);
|
||
|
||
action_name = strrchr (self->action_and_target, '|') + 1;
|
||
|
||
GTK_NOTE(ACTIONS,
|
||
if (!strchr (action_name, '.'))
|
||
g_message ("menutracker: action name %s doesn't look like 'app.' or 'win.'; "
|
||
"it is unlikely to work", action_name));
|
||
|
||
state = NULL;
|
||
|
||
gtk_action_observable_register_observer (self->observable, action_name, GTK_ACTION_OBSERVER (self));
|
||
found = gtk_action_muxer_query_action (muxer, action_name, &enabled, ¶meter_type, NULL, NULL, &state);
|
||
|
||
if (found)
|
||
{
|
||
GTK_NOTE(ACTIONS, g_message ("menutracker: action %s existed from the start", action_name));
|
||
gtk_menu_tracker_item_action_added (GTK_ACTION_OBSERVER (self), observable, action_name, parameter_type, enabled, state);
|
||
}
|
||
else
|
||
{
|
||
GTK_NOTE(ACTIONS, g_message ("menutracker: action %s missing from the start", action_name));
|
||
gtk_menu_tracker_item_update_visibility (self);
|
||
}
|
||
|
||
if (state)
|
||
g_variant_unref (state);
|
||
}
|
||
else
|
||
{
|
||
gtk_menu_tracker_item_update_visibility (self);
|
||
self->sensitive = TRUE;
|
||
}
|
||
|
||
return self;
|
||
}
|
||
|
||
GtkActionObservable *
|
||
_gtk_menu_tracker_item_get_observable (GtkMenuTrackerItem *self)
|
||
{
|
||
return self->observable;
|
||
}
|
||
|
||
/*< private >
|
||
* gtk_menu_tracker_item_get_is_separator:
|
||
* @self: A GtkMenuTrackerItem instance
|
||
*
|
||
* Returns: whether the menu item is a separator. If so, only
|
||
* certain properties may need to be obeyed. See the documentation
|
||
* for GtkMenuTrackerItem.
|
||
*/
|
||
gboolean
|
||
gtk_menu_tracker_item_get_is_separator (GtkMenuTrackerItem *self)
|
||
{
|
||
return self->is_separator;
|
||
}
|
||
|
||
/*< private >
|
||
* gtk_menu_tracker_item_get_has_submenu:
|
||
* @self: A GtkMenuTrackerItem instance
|
||
*
|
||
* Returns: whether the menu item has a submenu. If so, only
|
||
* certain properties may need to be obeyed. See the documentation
|
||
* for GtkMenuTrackerItem.
|
||
*/
|
||
gboolean
|
||
gtk_menu_tracker_item_get_has_link (GtkMenuTrackerItem *self,
|
||
const char *link_name)
|
||
{
|
||
GMenuModel *link;
|
||
|
||
link = g_menu_item_get_link (self->item, link_name);
|
||
|
||
if (link)
|
||
{
|
||
g_object_unref (link);
|
||
return TRUE;
|
||
}
|
||
else
|
||
return FALSE;
|
||
}
|
||
|
||
const char *
|
||
gtk_menu_tracker_item_get_label (GtkMenuTrackerItem *self)
|
||
{
|
||
const char *label = NULL;
|
||
|
||
g_menu_item_get_attribute (self->item, G_MENU_ATTRIBUTE_LABEL, "&s", &label);
|
||
|
||
return label;
|
||
}
|
||
|
||
gboolean
|
||
gtk_menu_tracker_item_get_use_markup (GtkMenuTrackerItem *self)
|
||
{
|
||
return g_menu_item_get_attribute (self->item, "use-markup", "&s", NULL);
|
||
}
|
||
|
||
/*< private >
|
||
* gtk_menu_tracker_item_get_icon:
|
||
*
|
||
* Returns: (transfer full):
|
||
*/
|
||
GIcon *
|
||
gtk_menu_tracker_item_get_icon (GtkMenuTrackerItem *self)
|
||
{
|
||
GVariant *icon_data;
|
||
GIcon *icon;
|
||
|
||
icon_data = g_menu_item_get_attribute_value (self->item, "icon", NULL);
|
||
|
||
if (icon_data == NULL)
|
||
return NULL;
|
||
|
||
icon = g_icon_deserialize (icon_data);
|
||
g_variant_unref (icon_data);
|
||
|
||
return icon;
|
||
}
|
||
|
||
/*< private >
|
||
* gtk_menu_tracker_item_get_verb_icon:
|
||
*
|
||
* Returns: (transfer full):
|
||
*/
|
||
GIcon *
|
||
gtk_menu_tracker_item_get_verb_icon (GtkMenuTrackerItem *self)
|
||
{
|
||
GVariant *icon_data;
|
||
GIcon *icon;
|
||
|
||
icon_data = g_menu_item_get_attribute_value (self->item, "verb-icon", NULL);
|
||
|
||
if (icon_data == NULL)
|
||
return NULL;
|
||
|
||
icon = g_icon_deserialize (icon_data);
|
||
g_variant_unref (icon_data);
|
||
|
||
return icon;
|
||
}
|
||
|
||
gboolean
|
||
gtk_menu_tracker_item_get_sensitive (GtkMenuTrackerItem *self)
|
||
{
|
||
return self->sensitive;
|
||
}
|
||
|
||
GtkMenuTrackerItemRole
|
||
gtk_menu_tracker_item_get_role (GtkMenuTrackerItem *self)
|
||
{
|
||
return self->role;
|
||
}
|
||
|
||
gboolean
|
||
gtk_menu_tracker_item_get_toggled (GtkMenuTrackerItem *self)
|
||
{
|
||
return self->toggled;
|
||
}
|
||
|
||
const char *
|
||
gtk_menu_tracker_item_get_accel (GtkMenuTrackerItem *self)
|
||
{
|
||
const char *accel;
|
||
|
||
if (!self->action_and_target)
|
||
return NULL;
|
||
|
||
if (g_menu_item_get_attribute (self->item, "accel", "&s", &accel))
|
||
return accel;
|
||
|
||
if (!GTK_IS_ACTION_MUXER (self->observable))
|
||
return NULL;
|
||
|
||
return gtk_action_muxer_get_primary_accel (GTK_ACTION_MUXER (self->observable), self->action_and_target);
|
||
}
|
||
|
||
const char *
|
||
gtk_menu_tracker_item_get_special (GtkMenuTrackerItem *self)
|
||
{
|
||
const char *special = NULL;
|
||
|
||
g_menu_item_get_attribute (self->item, "x-gtk-private-special", "&s", &special);
|
||
|
||
return special;
|
||
}
|
||
|
||
const char *
|
||
gtk_menu_tracker_item_get_custom (GtkMenuTrackerItem *self)
|
||
{
|
||
const char *custom = NULL;
|
||
|
||
g_menu_item_get_attribute (self->item, "custom", "&s", &custom);
|
||
|
||
return custom;
|
||
}
|
||
|
||
const char *
|
||
gtk_menu_tracker_item_get_display_hint (GtkMenuTrackerItem *self)
|
||
{
|
||
const char *display_hint = NULL;
|
||
|
||
g_menu_item_get_attribute (self->item, "display-hint", "&s", &display_hint);
|
||
|
||
return display_hint;
|
||
}
|
||
|
||
const char *
|
||
gtk_menu_tracker_item_get_text_direction (GtkMenuTrackerItem *self)
|
||
{
|
||
const char *text_direction = NULL;
|
||
|
||
g_menu_item_get_attribute (self->item, "text-direction", "&s", &text_direction);
|
||
|
||
return text_direction;
|
||
}
|
||
|
||
GMenuModel *
|
||
_gtk_menu_tracker_item_get_link (GtkMenuTrackerItem *self,
|
||
const char *link_name)
|
||
{
|
||
return g_menu_item_get_link (self->item, link_name);
|
||
}
|
||
|
||
char *
|
||
_gtk_menu_tracker_item_get_link_namespace (GtkMenuTrackerItem *self)
|
||
{
|
||
const char *namespace;
|
||
|
||
if (g_menu_item_get_attribute (self->item, "action-namespace", "&s", &namespace))
|
||
{
|
||
if (self->action_namespace)
|
||
return g_strjoin (".", self->action_namespace, namespace, NULL);
|
||
else
|
||
return g_strdup (namespace);
|
||
}
|
||
else
|
||
return g_strdup (self->action_namespace);
|
||
}
|
||
|
||
gboolean
|
||
gtk_menu_tracker_item_get_should_request_show (GtkMenuTrackerItem *self)
|
||
{
|
||
return g_menu_item_get_attribute (self->item, "submenu-action", "&s", NULL);
|
||
}
|
||
|
||
gboolean
|
||
gtk_menu_tracker_item_get_submenu_shown (GtkMenuTrackerItem *self)
|
||
{
|
||
return self->submenu_shown;
|
||
}
|
||
|
||
static void
|
||
gtk_menu_tracker_item_set_submenu_shown (GtkMenuTrackerItem *self,
|
||
gboolean submenu_shown)
|
||
{
|
||
if (submenu_shown == self->submenu_shown)
|
||
return;
|
||
|
||
self->submenu_shown = submenu_shown;
|
||
g_object_notify_by_pspec (G_OBJECT (self), gtk_menu_tracker_item_pspecs[PROP_SUBMENU_SHOWN]);
|
||
}
|
||
|
||
void
|
||
gtk_menu_tracker_item_activated (GtkMenuTrackerItem *self)
|
||
{
|
||
const char *action_name;
|
||
GVariant *action_target;
|
||
|
||
g_return_if_fail (GTK_IS_MENU_TRACKER_ITEM (self));
|
||
|
||
if (!self->can_activate)
|
||
return;
|
||
|
||
action_name = strrchr (self->action_and_target, '|') + 1;
|
||
action_target = g_menu_item_get_attribute_value (self->item, G_MENU_ATTRIBUTE_TARGET, NULL);
|
||
|
||
gtk_action_muxer_activate_action (GTK_ACTION_MUXER (self->observable), action_name, action_target);
|
||
|
||
if (action_target)
|
||
g_variant_unref (action_target);
|
||
}
|
||
|
||
typedef struct {
|
||
GObject parent;
|
||
|
||
GtkMenuTrackerItem *item;
|
||
char *submenu_action;
|
||
gboolean first_time;
|
||
} GtkMenuTrackerOpener;
|
||
|
||
typedef struct {
|
||
GObjectClass parent_class;
|
||
} GtkMenuTrackerOpenerClass;
|
||
|
||
static void gtk_menu_tracker_opener_observer_iface_init (GtkActionObserverInterface *iface);
|
||
|
||
GType gtk_menu_tracker_opener_get_type (void) G_GNUC_CONST;
|
||
|
||
G_DEFINE_TYPE_WITH_CODE (GtkMenuTrackerOpener, gtk_menu_tracker_opener, G_TYPE_OBJECT,
|
||
G_IMPLEMENT_INTERFACE (GTK_TYPE_ACTION_OBSERVER, gtk_menu_tracker_opener_observer_iface_init))
|
||
|
||
static void
|
||
gtk_menu_tracker_opener_init (GtkMenuTrackerOpener *self)
|
||
{
|
||
}
|
||
|
||
static void
|
||
gtk_menu_tracker_opener_finalize (GObject *object)
|
||
{
|
||
GtkMenuTrackerOpener *opener = (GtkMenuTrackerOpener *)object;
|
||
|
||
if (opener->item != NULL)
|
||
{
|
||
GtkMenuTrackerItem *item = g_object_ref (opener->item);
|
||
|
||
g_clear_weak_pointer (&opener->item);
|
||
|
||
gtk_action_observable_unregister_observer (item->observable,
|
||
opener->submenu_action,
|
||
(GtkActionObserver *)opener);
|
||
|
||
if (GTK_IS_ACTION_MUXER (item->observable))
|
||
gtk_action_muxer_change_action_state (GTK_ACTION_MUXER (item->observable),
|
||
opener->submenu_action,
|
||
g_variant_new_boolean (FALSE));
|
||
|
||
gtk_menu_tracker_item_set_submenu_shown (item, FALSE);
|
||
|
||
g_object_unref (item);
|
||
}
|
||
|
||
g_clear_pointer (&opener->submenu_action, g_free);
|
||
|
||
G_OBJECT_CLASS (gtk_menu_tracker_opener_parent_class)->finalize (object);
|
||
}
|
||
|
||
static void
|
||
gtk_menu_tracker_opener_class_init (GtkMenuTrackerOpenerClass *class)
|
||
{
|
||
G_OBJECT_CLASS (class)->finalize = gtk_menu_tracker_opener_finalize;
|
||
}
|
||
|
||
static void
|
||
gtk_menu_tracker_opener_update (GtkMenuTrackerOpener *opener)
|
||
{
|
||
GtkActionMuxer *muxer = GTK_ACTION_MUXER (opener->item->observable);
|
||
gboolean is_open = TRUE;
|
||
GVariant *state;
|
||
|
||
/* We consider the menu as being "open" if the action does not exist
|
||
* or if there is another problem (no state, wrong state type, etc.).
|
||
* If the action exists, with the correct state then we consider it
|
||
* open if we have ever seen this state equal to TRUE.
|
||
*
|
||
* In the event that we see the state equal to FALSE, we force it back
|
||
* to TRUE. We do not signal that the menu was closed because this is
|
||
* likely to create UI thrashing.
|
||
*
|
||
* The only way the menu can have a true-to-false submenu-shown
|
||
* transition is if the user calls _request_submenu_shown (FALSE).
|
||
* That is handled in _free() below.
|
||
*/
|
||
|
||
if (gtk_action_muxer_query_action (muxer, opener->submenu_action, NULL, NULL, NULL, NULL, &state))
|
||
{
|
||
if (state)
|
||
{
|
||
if (g_variant_is_of_type (state, G_VARIANT_TYPE_BOOLEAN))
|
||
is_open = g_variant_get_boolean (state);
|
||
g_variant_unref (state);
|
||
}
|
||
}
|
||
|
||
/* If it is already open, signal that.
|
||
*
|
||
* If it is not open, ask it to open.
|
||
*/
|
||
if (is_open)
|
||
gtk_menu_tracker_item_set_submenu_shown (opener->item, TRUE);
|
||
|
||
if (!is_open || opener->first_time)
|
||
{
|
||
gtk_action_muxer_change_action_state (muxer, opener->submenu_action, g_variant_new_boolean (TRUE));
|
||
opener->first_time = FALSE;
|
||
}
|
||
}
|
||
|
||
static void
|
||
gtk_menu_tracker_opener_added (GtkActionObserver *observer,
|
||
GtkActionObservable *observable,
|
||
const char *action_name,
|
||
const GVariantType *parameter_type,
|
||
gboolean enabled,
|
||
GVariant *state)
|
||
{
|
||
gtk_menu_tracker_opener_update ((GtkMenuTrackerOpener *)observer);
|
||
}
|
||
|
||
static void
|
||
gtk_menu_tracker_opener_removed (GtkActionObserver *observer,
|
||
GtkActionObservable *observable,
|
||
const char *action_name)
|
||
{
|
||
gtk_menu_tracker_opener_update ((GtkMenuTrackerOpener *)observer);
|
||
}
|
||
|
||
static void
|
||
gtk_menu_tracker_opener_enabled_changed (GtkActionObserver *observer,
|
||
GtkActionObservable *observable,
|
||
const char *action_name,
|
||
gboolean enabled)
|
||
{
|
||
gtk_menu_tracker_opener_update ((GtkMenuTrackerOpener *)observer);
|
||
}
|
||
|
||
static void
|
||
gtk_menu_tracker_opener_state_changed (GtkActionObserver *observer,
|
||
GtkActionObservable *observable,
|
||
const char *action_name,
|
||
GVariant *state)
|
||
{
|
||
gtk_menu_tracker_opener_update ((GtkMenuTrackerOpener *)observer);
|
||
}
|
||
|
||
static void
|
||
gtk_menu_tracker_opener_observer_iface_init (GtkActionObserverInterface *iface)
|
||
{
|
||
iface->action_added = gtk_menu_tracker_opener_added;
|
||
iface->action_removed = gtk_menu_tracker_opener_removed;
|
||
iface->action_enabled_changed = gtk_menu_tracker_opener_enabled_changed;
|
||
iface->action_state_changed = gtk_menu_tracker_opener_state_changed;
|
||
}
|
||
|
||
static GtkMenuTrackerOpener *
|
||
gtk_menu_tracker_opener_new (GtkMenuTrackerItem *item,
|
||
const char *submenu_action)
|
||
{
|
||
GtkMenuTrackerOpener *opener;
|
||
|
||
opener = g_object_new (gtk_menu_tracker_opener_get_type (), NULL);
|
||
|
||
opener->first_time = TRUE;
|
||
|
||
g_set_weak_pointer (&opener->item, item);
|
||
|
||
if (item->action_namespace)
|
||
opener->submenu_action = g_strjoin (".", item->action_namespace, submenu_action, NULL);
|
||
else
|
||
opener->submenu_action = g_strdup (submenu_action);
|
||
|
||
gtk_action_observable_register_observer (item->observable,
|
||
opener->submenu_action,
|
||
(GtkActionObserver *)opener);
|
||
|
||
gtk_menu_tracker_opener_update (opener);
|
||
|
||
return opener;
|
||
}
|
||
|
||
void
|
||
gtk_menu_tracker_item_request_submenu_shown (GtkMenuTrackerItem *self,
|
||
gboolean shown)
|
||
{
|
||
const char *submenu_action;
|
||
gboolean has_submenu_action;
|
||
|
||
if (shown == self->submenu_requested)
|
||
return;
|
||
|
||
has_submenu_action = g_menu_item_get_attribute (self->item, "submenu-action", "&s", &submenu_action);
|
||
|
||
self->submenu_requested = shown;
|
||
|
||
/* If we have a submenu action, start a submenu opener and wait
|
||
* for the reply from the client. Otherwise, simply open the
|
||
* submenu immediately.
|
||
*/
|
||
if (has_submenu_action)
|
||
{
|
||
if (shown)
|
||
g_object_set_data_full (G_OBJECT (self), "submenu-opener",
|
||
gtk_menu_tracker_opener_new (self, submenu_action),
|
||
g_object_unref);
|
||
else
|
||
g_object_set_data (G_OBJECT (self), "submenu-opener", NULL);
|
||
}
|
||
else
|
||
gtk_menu_tracker_item_set_submenu_shown (self, shown);
|
||
}
|
||
|
||
/*
|
||
* gtk_menu_tracker_item_get_is_visible:
|
||
* @self: A GtkMenuTrackerItem instance
|
||
*
|
||
* Don't use this unless you're tracking items for yourself -- normally
|
||
* the tracker will emit add/remove automatically when this changes.
|
||
*
|
||
* Returns: if the item should currently be shown
|
||
*/
|
||
gboolean
|
||
gtk_menu_tracker_item_get_is_visible (GtkMenuTrackerItem *self)
|
||
{
|
||
return self->is_visible;
|
||
}
|
||
|
||
/*
|
||
* gtk_menu_tracker_item_may_disappear:
|
||
* @self: A GtkMenuTrackerItem instance
|
||
*
|
||
* Returns: if the item may disappear (ie: is-visible property may change)
|
||
*/
|
||
gboolean
|
||
gtk_menu_tracker_item_may_disappear (GtkMenuTrackerItem *self)
|
||
{
|
||
return self->hidden_when != HIDDEN_NEVER;
|
||
}
|