gtk2/gdk-pixbuf/pixops
05:27:43 2000 Owen Taylor a77a3d135d Properly offset y coordinate accordining to render_y0.
2000-04-22 05:27:43 2000  Owen Taylor  <otaylor@redhat.com>

	* gdk-pixbuf/pixops/pixops.c (pixops_scale_nearest): Properly
	offset y coordinate accordining to render_y0.

	* gdk-pixbuf/gdk-pixbuf-scale.c: Properly handle nonzero
	dest_x, dest_y.
2000-04-24 05:28:02 +00:00
..
.cvsignore Directory full of pixel data scaling code that will eventually migrate 2000-01-05 21:33:58 +00:00
composite_line_22_4a4_mmx.S Directory full of pixel data scaling code that will eventually migrate 2000-01-05 21:33:58 +00:00
composite_line_color_22_4a4_mmx.S Directory full of pixel data scaling code that will eventually migrate 2000-01-05 21:33:58 +00:00
have_mmx.S Directory full of pixel data scaling code that will eventually migrate 2000-01-05 21:33:58 +00:00
Makefile.am $(LIBART_CFLAGS) replaced by $(GTK_CFLAGS) - now gdk-pixbuf compiles 2000-04-14 07:04:29 +00:00
pixops-internal.h Most of this patch is based on a patch by Havoc Pennington (hp@redhat.com) 2000-04-11 07:03:25 +00:00
pixops.c Properly offset y coordinate accordining to render_y0. 2000-04-24 05:28:02 +00:00
pixops.h Most of this patch is based on a patch by Havoc Pennington (hp@redhat.com) 2000-04-11 07:03:25 +00:00
README quick fix for initializing arrays in benchmark. 2000-01-05 23:57:02 +00:00
scale_line_22_33_mmx.S Directory full of pixel data scaling code that will eventually migrate 2000-01-05 21:33:58 +00:00
timescale.c Most of this patch is based on a patch by Havoc Pennington (hp@redhat.com) 2000-04-11 07:03:25 +00:00

The code in this directory implements optimized, filtered scaling
for pixmap data. 

This code is copyright Red Hat, Inc, 2000 and licensed under the terms
of the GNU Lesser General Public License (LGPL).

(If you want to use it in a project where that license is not
appropriate, please contact me, and most likely something can be
worked out.)

Owen Taylor <otaylor@redhat.com>

PRINCIPLES
==========

The general principle of this code is that it first computes a filter
matrix for the given filtering mode, and then calls a general driver
routine, passing in functions to composite pixels and lines.

(The pixel functions are used for handling edge cases, and the line
functions are simply used for the middle parts of the image.)

The system is designed so that the line functions can be simple, 
don't have to worry about special cases, can be selected to
be specific to the particular formats involved. This allows them
to be hyper-optimized. Since most of the compution time is 
spent in these functions, this results in an overall fast design.

MMX assembly code for Intel (and compatible) processors is included
for a number of the most common special cases:

 scaling from RGB to RGB
 compositing from RGBA to RGBx
 compositing against a color from RGBA and storing in a RGBx buffer

TODO
====

* ART_FILTER_HYPER is not correctly implemented. It is currently
  implemented as a filter that is derived by doing linear interpolation
  on the source image and then averaging that with a box filter.

  It should be defined as followed (see art_filterlevel.h)

   "HYPER is the highest quality reconstruction function. It is derived
    from the hyperbolic filters in Wolberg's "Digital Image Warping,"
    and is formally defined as the hyperbolic-filter sampling the ideal
    hyperbolic-filter interpolated image (the filter is designed to be
    idempotent for 1:1 pixel mapping). It is the slowest and highest
    quality."

  The current HYPER is probably as slow, but lower quality. Also, there
  are some subtle errors in the calculation current HYPER that show up as dark
  stripes if you scale a constant-color image.

* There are some roundoff errors in the compositing routines. 
  the _nearest() variants do it right, most of the other code 
  is wrong to some degree or another.

  For instance, in composite line, we have:

    dest[0] = ((0xff0000 - a) * dest[0] + r) >> 24;

   if a is 0, then we have:

    (0xff0000 * dest[0] + r) >> 24

   which gives results which are 1 to low:

       255 => 254,   1 => 0.

   So, this should be something like:

     ((0xff0000 - a) * dest[0] + r + 0xffffff) >> 24;

   (Not checked, caveat emptor)

   An alternatve formulation of this as:

     dest[0] + (r - a * dest[0] + 0xffffff) >> 24

   may be better numerically, but would need consideration for overflow.

* The generic functions could be sped up considerably by
  switching around conditionals and inner loops in various
  places.

* Right now, in several of the most common cases, there are
  optimized mmx routines, but no optimized C routines.

  For instance, there is a 

    pixops_composite_line_22_4a4_mmx()

  But no 
  
    pixops_composite_line_22_4a4()

  Also, it may be desirable to include a few more special cases - in particular:

    pixops_composite_line_22_4a3()

  May be desirable.

* Scaling down images by large scale factors is _slow_ since huge filter
  matrixes are computed. (e.g., to scale down by a factor of 100, we compute
  101x101 filter matrixes. At some point, it would be more efficent to
  switch over to subsampling when scaling down - one should never need a filter
  matrix bigger than 16x16.