forked from AuroraMiddleware/gtk
f63e6394ac
If multiple nested widgets have drag sources on them, both using bubble phase, we need to reliably pick the inner one. Both of them will try to start dragging, and we need to make sure there are no situations where the outer widget starts drag earlier and cancels the inner one. Currently, this can easily happen via integer rounding: start and current coordinates passed into gtk_drag_check_threshold() are initially doubles (other than in GtkNotebook and GtkIconView), and are casted to ints. Then those rounded values are used to calculate deltas to compare to the drag threshold, losing quite a lot of precision along the way, and often resulting in the outer widget getting larger deltas. To avoid it, just don't round it. Introduce a variant of the function that operates on doubles: gtk_drag_check_threshold_double() and use it instead of the original everywhere.
34 lines
1.2 KiB
C
34 lines
1.2 KiB
C
/* GTK - The GIMP Toolkit
|
|
* Copyright (C) 2020 Alexander Mikhaylenko
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef __GTK_DRAG_SOURCE_PRIVATE_H__
|
|
#define __GTK_DRAG_SOURCE_PRIVATE_H__
|
|
|
|
#include "gtkdragsource.h"
|
|
|
|
G_BEGIN_DECLS
|
|
|
|
gboolean gtk_drag_check_threshold_double (GtkWidget *widget,
|
|
double start_x,
|
|
double start_y,
|
|
double current_x,
|
|
double current_y);
|
|
|
|
G_END_DECLS
|
|
|
|
#endif /* __GTK_DRAG_SOURCE_PRIVATE_H__ */
|