From 489acf6c3180d3726158864fa0e1adeea3c23fae Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Fri, 22 Jul 2016 17:41:43 -0700 Subject: [PATCH] [coretext] "Fix" crashes on CoreText < 10.10 Fixes https://github.com/behdad/harfbuzz/issues/297 --- src/hb-coretext.cc | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/hb-coretext.cc b/src/hb-coretext.cc index f4d9716e9..c50537341 100644 --- a/src/hb-coretext.cc +++ b/src/hb-coretext.cc @@ -145,6 +145,14 @@ create_ct_font (CGFontRef cg_font, CGFloat font_size) DEBUG_MSG (CORETEXT, cg_font, "Font CTFontCreateWithGraphicsFont() failed"); return NULL; } + + /* crbug.com/576941 and crbug.com/625902 and the investigation in the latter + * bug indicate that the cascade list reconfiguration occasionally causes + * crashes in CoreText on OS X 10.9, thus let's skip this step on older + * operating system versions. */ + if (&CTGetCoreTextVersion != NULL && CTGetCoreTextVersion() < kCTVersionNumber10_10) + return ct_font; + CFURLRef original_url = (CFURLRef)CTFontCopyAttribute(ct_font, kCTFontURLAttribute); /* Create font copy with cascade list that has LastResort first; this speeds up CoreText