AuroraMiddleware/harfbuzz
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[HB] Add note about auditing sanitize code for overflows

Browse Source
This commit is contained in:
Behdad Esfahbod 2009-08-14 16:12:22 -04:00
parent 15232e26f4
commit 5769538abf
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/TODO
View File

@ -3,3 +3,4 @@
- cmap14 support in get_glyph callback - cmap14 support in get_glyph callback
- size_t? - size_t?
- Figure out compiler selection (add test for link to libstdc++) - Figure out compiler selection (add test for link to libstdc++)
- Audit sanitize for int overflows

2
src/hb-ot-layout-gpos-private.hh
View File

@ -565,7 +565,7 @@ struct PairPosFormat2
SANITIZE_THIS2 (classDef1, classDef2) && SANITIZE_THIS2 (classDef1, classDef2) &&
SANITIZE_MEM (values, SANITIZE_MEM (values,
(valueFormat1.get_size () + valueFormat2.get_size ()) * (valueFormat1.get_size () + valueFormat2.get_size ()) *
class1Count * class2Count); class1Count * class2Count); /* XXX overflow (in other places too) */
} }
private: private: